Commit Graph

275 Commits

Author SHA1 Message Date
commit-bot@chromium.org
25e5a20e65 Apply matrix early in draw bitmap
R=robertphillips@google.com, senorblanco@chromium.org

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/30593003

git-svn-id: http://skia.googlecode.com/svn/trunk@11930 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-23 21:06:51 +00:00
humper@google.com
0794dcd2c0 rebaseline scaled tilemodes gms on the GPU
git-svn-id: http://skia.googlecode.com/svn/trunk@11927 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-23 19:41:08 +00:00
sugoi@google.com
afba64434d New gm expectations for imagemagnifier
git-svn-id: http://skia.googlecode.com/svn/trunk@11911 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-22 19:42:10 +00:00
bsalomon@google.com
7ce564cccb Revert "If the path is a rect, call drawRect to raster the geometry in SkCanvas::drawPath to get better performance."
This reverts commit r11904

Review URL: https://codereview.chromium.org/35543002

git-svn-id: http://skia.googlecode.com/svn/trunk@11909 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-22 16:54:15 +00:00
bsalomon@google.com
a5f30e9675 Add strokerect to ignored tests list
Review URL: https://codereview.chromium.org/35223003

git-svn-id: http://skia.googlecode.com/svn/trunk@11906 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-22 13:52:47 +00:00
bsalomon@google.com
ad254fee73 If the path is a rect, call drawRect to raster the geometry in SkCanvas::drawPath to get better performance.
Committed: http://code.google.com/p/skia/source/detail?r=11842

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/23484007

git-svn-id: http://skia.googlecode.com/svn/trunk@11904 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-22 13:19:12 +00:00
scroggo@google.com
5187c4313c More work to integrate skimage with rebaseline tools.
tools/skimage_main.cpp:
Add the ability to write the results to checksum based filenames,
much like GM uses. This will allow using the skpdiff server to
rebaseline images.
Write the keys in the JSON file as <original image>_<pref config>.png,
so it matches gm_json.IMAGE_FILENAME_PATTERN. Also replace '_' with
'-' in the original file name, to avoid confusing the pattern matcher.
The '_' to '-' replacement also happens on the output filename.
Read the keys in a similar manner.
In make_outname, no longer remove a suffix. This fixes a bug where
subset decoding writes multiple subsets to the same file.

tools/rebaseline.py:
Since the filenames written to json files now match
gm_json.IMAGE_FILENAME_PATTERN, enable the option to match based
on configs/tests when rebaselining skimage.

test json files:
Update to match the new format of output.

gm/gm_expectations:
Add a constructor that takes a BitmapAndDigest as input.

tools/tests/skimage_self_test.py:
Test that reading the expectations file just created by skimage with
the same file actually compares to the original file (rather than just
succeeding because expectations were missing).

Change the expectations files to match the new format.

Will require a buildbot change to use the new flag: https://codereview.chromium.org/27389002/

BUG=1466
R=epoger@google.com

Review URL: https://codereview.chromium.org/26297004

git-svn-id: http://skia.googlecode.com/svn/trunk@11902 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-22 00:42:46 +00:00
senorblanco@chromium.org
380355eff3 Xoom rebaselines.
Note: Some of these had no base versions in GS corresponding to the hashes in the JSON, causing the svndiff script to barf. I hacked it up to let me finish, but it should probably handle the case of a missing hash more gracefully.

TBR=epoger

Review URL: https://codereview.chromium.org/33303007

git-svn-id: http://skia.googlecode.com/svn/trunk@11900 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 22:00:47 +00:00
senorblanco@chromium.org
8204743fdb ChromeOS and IntelRhb rebaselines.
TBR=robertphillips

Review URL: https://codereview.chromium.org/32533004

git-svn-id: http://skia.googlecode.com/svn/trunk@11891 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 18:46:49 +00:00
senorblanco@chromium.org
ad6d35bbf9 Third round of matrixconvolution rebaselines, and removal from ignored-tests.txt.
"We have normality. I repeat, we have normality. Anything you still can't cope with is therefore your own problem."

TBR=robertphillips
BUG=

Review URL: https://codereview.chromium.org/33323002

git-svn-id: http://skia.googlecode.com/svn/trunk@11889 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 18:23:30 +00:00
senorblanco@chromium.org
9f51d16b54 Second round of matrixconvolution rebaselines.
TBR=robertphillips
BUG=

Review URL: https://codereview.chromium.org/33103002

git-svn-id: http://skia.googlecode.com/svn/trunk@11885 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 17:04:11 +00:00
commit-bot@chromium.org
f642f8cf90 Magnifier gpu path fix
The y axis was inverted for the offset, which should have been computed on the other side of the magnifying rectangle.

BUG=
R=bsalomon@google.com, senorblanco@google.com, senorblanco@chromium.org

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/28273005

git-svn-id: http://skia.googlecode.com/svn/trunk@11883 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 15:59:26 +00:00
senorblanco@chromium.org
718f5e2b7c First round of matrixconvolution rebaselines.
TBR=robertphillips

Review URL: https://codereview.chromium.org/32823002

git-svn-id: http://skia.googlecode.com/svn/trunk@11882 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 15:41:55 +00:00
robertphillips@google.com
466ea91886 A few stragglers for r1187 (Fix cubic->quad RR corner regression)
https://codereview.chromium.org/31333002/



git-svn-id: http://skia.googlecode.com/svn/trunk@11875 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 00:15:15 +00:00
robertphillips@google.com
7c4d5124d1 More rebaselines for r1187 (Fix cubic->quad RR corner regression)
https://codereview.chromium.org/31323002/



git-svn-id: http://skia.googlecode.com/svn/trunk@11874 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-20 23:53:11 +00:00
robertphillips@google.com
d8b0a148c5 rebaselines after r1187 (Fix cubic->quad RR corner regression)
https://codereview.chromium.org/31313002/



git-svn-id: http://skia.googlecode.com/svn/trunk@11873 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-20 23:06:40 +00:00
senorblanco@chromium.org
7938bae14a Implement crop rect support for SkMatrixConvolutionImageFilter.
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/27471002

git-svn-id: http://skia.googlecode.com/svn/trunk@11863 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 20:08:14 +00:00
bsalomon@google.com
de7de5638f rebaseline gpu complex clip tests
Review URL: https://codereview.chromium.org/29303002

git-svn-id: http://skia.googlecode.com/svn/trunk@11856 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 15:47:28 +00:00
robertphillips@google.com
e0d7277b59 Revert 11839 (rebaseline images after r11835) due to performance regression in 11835
git-svn-id: http://skia.googlecode.com/svn/trunk@11840 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 16:28:11 +00:00
robertphillips@google.com
01c51b76bf rebaseline images after r11835
https://codereview.chromium.org/27722002/



git-svn-id: http://skia.googlecode.com/svn/trunk@11839 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 15:23:26 +00:00
robertphillips@google.com
3f1588482f Added nested_bw to suppression list
git-svn-id: http://skia.googlecode.com/svn/trunk@11838 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 13:17:04 +00:00
mtklein@google.com
e4b500b0bc rebaseline stragglers from repeated radial gradient tweak
BUG=

Review URL: https://codereview.chromium.org/27700002

git-svn-id: http://skia.googlecode.com/svn/trunk@11837 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 12:34:54 +00:00
robertphillips@google.com
6b1b248bbe Fix typo in ignored-tests file
git-svn-id: http://skia.googlecode.com/svn/trunk@11836 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 12:27:55 +00:00
robertphillips@google.com
1cc385b7a4 Replace cubic round rect corners with quads
https://codereview.chromium.org/26372006/



git-svn-id: http://skia.googlecode.com/svn/trunk@11835 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 12:17:27 +00:00
bsalomon@google.com
3ae71b6b2e Initial baselines for skbug1719
Review URL: https://codereview.chromium.org/27212004

git-svn-id: http://skia.googlecode.com/svn/trunk@11832 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 21:27:18 +00:00
mtklein@google.com
6065d36bb8 tools/rebaseline.py --tests xfermodes3 drawbitmaprect scaled_tilemode_gradient tilemode_gradient
BUG=

Review URL: https://codereview.chromium.org/26233006

git-svn-id: http://skia.googlecode.com/svn/trunk@11831 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 21:23:18 +00:00
edisonn@google.com
d117910239 update drawbitmap gm (part 2)
Review URL: https://codereview.chromium.org/26435005

git-svn-id: http://skia.googlecode.com/svn/trunk@11830 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 20:45:00 +00:00
edisonn@google.com
29a2d35bd2 Updates to SkPDFDevice and SkDocument classes.
Update the SkDocument interface to allow for 1) abort won't emit pdf, 2) close can report success/failure, 3) SkCanvasSimplifier interface that will be used to simplify perspective for SkpDFDevice, 4) prepare to deprecate SkPDFDevice constructor, and route gm and render_pdfs to use SkDocument::Create pdf interface instead. 	modified:   gm/gmmain.cpp 	modified:   gyp/core.gyp 	modified:   gyp/core.gypi 	new file:   include/core/SkCanvasSimplifier.h 	modified:   include/core/SkDocument.h 	new file:   include/pdf/SkPDFCallbacks.h 	modified:   include/pdf/SkPDFDevice.h 	new file:   src/core/SkCanvasSimplifier.cpp 	modified:   src/doc/SkDocument.cpp 	modified:   src/doc/SkDocument_PDF.cpp 	modified:   src/pdf/SkPDFDevice.cpp 	modified:   src/pdf/SkPDFShader.cpp 	modified:   src/utils/SkLua.cpp 	modified:   tools/PdfRenderer.cpp 	modified:   tools/PdfRenderer.h 	modified:   tools/render_pdfs_main.cpp 	modified:   tools/skhello.cpp

BUG=

Review URL: https://codereview.chromium.org/24615006

git-svn-id: http://skia.googlecode.com/svn/trunk@11829 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 19:49:17 +00:00
senorblanco@chromium.org
41345b6a4a More displacement GM rebaselines. Also remove displacement from ignored-tests.txt, since it should now be passing on all platforms.
TBR=

Review URL: https://codereview.chromium.org/27533003

git-svn-id: http://skia.googlecode.com/svn/trunk@11814 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 16:25:21 +00:00
bsalomon@google.com
e4d3d7ca70 Rebaseline complexclip tests on GPU and remove them from ignored-tests
Review URL: https://codereview.chromium.org/27515002

git-svn-id: http://skia.googlecode.com/svn/trunk@11806 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 14:15:32 +00:00
senorblanco@chromium.org
1a01bc492e More new baselines for displacement GM.
TBR=

Review URL: https://codereview.chromium.org/27420003

git-svn-id: http://skia.googlecode.com/svn/trunk@11797 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-15 23:00:26 +00:00
bsalomon@google.com
39bdd46691 Fix test name in ignored-tests.txt
git-svn-id: http://skia.googlecode.com/svn/trunk@11796 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-15 22:08:53 +00:00
senorblanco@chromium.org
e1f5dcd0ba First round of new baselines for displacement GM.
TBR=bsalomon
BUG=

Review URL: https://codereview.chromium.org/27411002

git-svn-id: http://skia.googlecode.com/svn/trunk@11795 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-15 21:40:50 +00:00
bsalomon@google.com
3e001d2cad Add failing complex clip gpu tests to ignored-tests.txt
git-svn-id: http://skia.googlecode.com/svn/trunk@11794 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-15 21:20:26 +00:00
bsalomon@google.com
ff2c8512bc rebaseline some of the complex clip aa gpu tests and direct write blurs
git-svn-id: http://skia.googlecode.com/svn/trunk@11793 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-15 20:58:50 +00:00
senorblanco@chromium.org
01bdf3c568 Add crop rect support for SkDisplacementMapEffect (raster and GPU paths).
Covered by new test cases added to displacement GM (will require rebaseline).

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/26531002

git-svn-id: http://skia.googlecode.com/svn/trunk@11782 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-15 19:02:43 +00:00
bsalomon@google.com
62c6fa78aa gpu rebaselines
Review URL: https://codereview.chromium.org/27347004

git-svn-id: http://skia.googlecode.com/svn/trunk@11779 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-15 17:51:38 +00:00
fmalita@google.com
071860a868 Adding SkLumaColorFilter baselines.
Review URL: https://codereview.chromium.org/27213003

git-svn-id: http://skia.googlecode.com/svn/trunk@11760 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-14 17:13:35 +00:00
scroggo@google.com
b4227d20b9 Remove the old skimage expectations.
As of https://code.google.com/p/skia/source/detail?r=11712 ,
the bots are now reading the expectations from a new place,
so these are no longer needed.

Unreviewed.

BUG=skia:1466

Review URL: https://codereview.chromium.org/26909004

git-svn-id: http://skia.googlecode.com/svn/trunk@11727 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-11 15:12:46 +00:00
scroggo@google.com
429c962179 Format-only changes to skimage expectations files.
When running rebaseline.py, the format of the file changes from
what is currently checked in, but the actual data remains the
same. Update the format so future changes will be easier to see
visually (not mixed in with format changes).

Unreviewed.

Review URL: https://codereview.chromium.org/26888010

git-svn-id: http://skia.googlecode.com/svn/trunk@11726 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-11 14:51:31 +00:00
djsollen@google.com
ae748e7bd0 Rebaseline Nexus 7 GM results after upgrading devices to 4.3
The fonts have changed as a result of the upgrade so all GMs with
text are reporting as mismatches.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/26866002

git-svn-id: http://skia.googlecode.com/svn/trunk@11699 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-10 16:15:45 +00:00
scroggo@google.com
19d15cebd0 New expectations files for skimage.
Copies them from expectations/skimage/buildername.json to
expectations/skimage/buildername/expected-results.json.

Required for https://codereview.chromium.org/26734006/ and
ultimately BUG=skia:1466

A follow up change will delete the old expectations files once
https://codereview.chromium.org/26734006/ has landed.

(SkipBuildbotRuns) - Since the new expectations files aren't even
read yet (they won't be until https://codereview.chromium.org/26734006/
is checked in), this need not be tested by the buildbots (yet).

Unreviewed.

BUG=skia:1466

Review URL: https://codereview.chromium.org/26865002

git-svn-id: http://skia.googlecode.com/svn/trunk@11698 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-10 16:04:16 +00:00
bsalomon@google.com
b006fe7e2f Rebase SGX images after GrGLSLExpr change
Review URL: https://codereview.chromium.org/26223005

git-svn-id: http://skia.googlecode.com/svn/trunk@11694 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-10 14:42:45 +00:00
epoger@google.com
f00031a487 Ignore any pdf-poppler GM failures
BUG=skia:1657
R=edisonn@google.com

Review URL: https://codereview.chromium.org/26318002

git-svn-id: http://skia.googlecode.com/svn/trunk@11640 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-07 19:06:40 +00:00
epoger@google.com
3a882dda07 GM: Allow ignored-tests.txt to list configs as well as tests (and combinations too)
BUG=skia:1657

This will allow us to ignore poppler failures until bug 1657 is resolved
(but this CL doesn't actually make that change to ignored-tests.txt yet)

R=scroggo@google.com

Review URL: https://codereview.chromium.org/26294004

git-svn-id: http://skia.googlecode.com/svn/trunk@11639 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-07 18:55:09 +00:00
scroggo@google.com
680963ec83 Ignore failure for images known to not work.
BUG=skia:1282

Review URL: https://codereview.chromium.org/26315002

git-svn-id: http://skia.googlecode.com/svn/trunk@11638 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-07 18:29:38 +00:00
scroggo@google.com
e7f6f43260 Fix unparsable expectations files.
Should fix build.

Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@11631 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-07 16:43:16 +00:00
djsollen@google.com
d7df6b6452 Rebaseline Android Xoom and Nexus10
Review URL: https://codereview.chromium.org/26257002

git-svn-id: http://skia.googlecode.com/svn/trunk@11627 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-07 13:50:45 +00:00
bsalomon@google.com
d35736d2d2 rebaseline angle gradient changes
Review URL: https://codereview.chromium.org/25666017

git-svn-id: http://skia.googlecode.com/svn/trunk@11618 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-04 19:22:03 +00:00
bsalomon@google.com
ef6d8da924 Remove rebaselined tests from ignored-tests.txt
Review URL: https://codereview.chromium.org/26014002

git-svn-id: http://skia.googlecode.com/svn/trunk@11603 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-04 14:26:58 +00:00