reed
cc1229c9d5
Revert "Revert[4] "move some public headers into private""
...
This reverts commit 33e00db73dhttps://codereview.chromium.org/1288863002
2015-08-12 18:58:52 -07:00
jvanverth
65bd7ae374
Add gyp support for new GPU backend
...
Review URL: https://codereview.chromium.org/1287023006
2015-08-12 12:58:13 -07:00
reed
33e00db73d
Revert[4] "move some public headers into private"
...
This reverts commit 9cdcabefa3https://codereview.chromium.org/1291613007
2015-08-12 12:53:10 -07:00
halcanary
d9e57158eb
SkPDF: Move SkFlate into src/pdf (part 1/3) [reland]
...
Rename to SkDeflate so Chromium builders continue to work
Next, we change remove SkFlate from Chromium build files, then we can delete SkFlate.
Review URL: https://codereview.chromium.org/1285913002
2015-08-12 11:24:40 -07:00
halcanary
cc34c41326
Revert of SkPDF: Move SkFlate into src/pdf (part 1/3) (patchset #1 id:1 of https://codereview.chromium.org/1285913002/ )
...
Reason for revert:
broke gn ("Duplicate object file")
Original issue's description:
> SkPDF: Move SkFlate into src/pdf (part 1/3)
>
> Next, we change Chromium build files, then we do the actual move.
>
> Committed: https://skia.googlesource.com/skia/+/e14c1fe04fc72ec9bcf55820b5c65a71d7d0a764
TBR=bungeman@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1289863002
2015-08-12 08:53:04 -07:00
halcanary
e14c1fe04f
SkPDF: Move SkFlate into src/pdf (part 1/3)
...
Next, we change Chromium build files, then we do the actual move.
Review URL: https://codereview.chromium.org/1285913002
2015-08-12 07:39:33 -07:00
egdaniel
4b5472bdb0
Add ability to pass in an optional path to additional unit tests to run.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1280133004
2015-08-12 06:51:08 -07:00
reed
9cdcabefa3
Revert[3] "move some public headers into private"
...
This reverts commit 9d20ee57d7https://codereview.chromium.org/1286103004
Review URL: https://codereview.chromium.org/1290733002
2015-08-12 05:33:12 -07:00
reed
9d20ee57d7
Revert[2] "move some public headers into private"
...
This reverts commit 4cf9e7e147https://codereview.chromium.org/1284173002
2015-08-12 04:42:08 -07:00
msarett
3bff4749e4
Hopefully fix ios bots
...
BUG=skia:
Review URL: https://codereview.chromium.org/1286833002
2015-08-11 14:44:02 -07:00
halcanary
2ccdb636e8
SkPDF: clean up overuse of SK_SUPPORT_PDF
...
When possible use run-time checks (via SkDocument::CreatePDF)
When PDF is disabled, do not compile tests/PDF*.cpp
Review URL: https://codereview.chromium.org/1278403006
2015-08-11 13:35:12 -07:00
msarett
fcaaadee71
Switching Skia to chromium's libjpeg-turbo
...
Compile SkJpegCodec and SkImageDecoder_libjpeg with
chromium's libjpeg-turbo. SkImageDecoder_libjpeg still uses
libjpeg on Android and the Android framework. SkJpegCodec is
still not compiled on the Android framework.
BUG=skia:
Review URL: https://codereview.chromium.org/1275773004
2015-08-11 13:32:54 -07:00
jvanverth
4d0d81aec2
Add high resolution WallTimer to SampleApp
...
Gives better than 1 ms results when timing framerate.
Review URL: https://codereview.chromium.org/1288473002
2015-08-11 11:07:07 -07:00
halcanary
8ee06f21a2
SkPDF: allow PDF module to be disabled in DM and SampleApp
...
To disable PDF:
GYP_DEFINES='skia_pdf=0' bin/sync-and-gyp
ninja -C out/Debug dm SampleApp
When disabled, SkDocument::CreatePDF() always returns NULL.
Review URL: https://codereview.chromium.org/1279123007
2015-08-11 10:30:12 -07:00
reed
4cf9e7e147
Revert "move some public headers into private"
...
This reverts commit eedf0fb204https://codereview.chromium.org/1270313005
2015-08-11 08:39:18 -07:00
reed
eedf0fb204
move some public headers into private
...
BUG=skia:
Review URL: https://codereview.chromium.org/1289483002
2015-08-11 07:15:00 -07:00
joshualitt
14205b114a
Expand functionality of GrRectBatchFactory with AARects
...
BUG=skia:
Review URL: https://codereview.chromium.org/1279303002
2015-08-10 11:40:56 -07:00
joshualitt
ecd1a69fbf
Create GrRectBatchFactory
...
BUG=skia:
Review URL: https://codereview.chromium.org/1287433003
2015-08-10 10:08:26 -07:00
joshualitt
9ff6425ce4
move Stroke Rect and AAFill Rect to their own file
...
BUG=skia:
Review URL: https://codereview.chromium.org/1282723004
2015-08-10 09:03:51 -07:00
scroggo
0df0e43488
Revert of Update libwebp and resume testing scaled webp (patchset #2 id:20001 of https://codereview.chromium.org/1280073002/ )
...
Reason for revert:
Compile failures, e.g.
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android_NoNeon/builds/1427/steps/build%20most/logs/stdio
Original issue's description:
> Update libwebp and resume testing scaled webp
>
> libwebp has a fix for [1]. Update to the commit that contains the fix.
>
> Update libwebp.gypi, corresponding to libwebp's latest makefile.
>
> Turn back on DM testing for scaled webp, now that it should no longer
> use uninitialized memory.
>
> Fix a warning in config.h
>
> [1] https://code.google.com/p/webp/issues/detail?id=254
>
> BUG=skia:4038
>
> Committed: https://skia.googlesource.com/skia/+/0575d3e6c272744a66ab3281f9871366717df339
TBR=djsollen@google.com ,msarett@google.com,scroggo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4038
Review URL: https://codereview.chromium.org/1278173004
2015-08-07 12:53:25 -07:00
scroggo
0575d3e6c2
Update libwebp and resume testing scaled webp
...
libwebp has a fix for [1]. Update to the commit that contains the fix.
Update libwebp.gypi, corresponding to libwebp's latest makefile.
Turn back on DM testing for scaled webp, now that it should no longer
use uninitialized memory.
Fix a warning in config.h
[1] https://code.google.com/p/webp/issues/detail?id=254
BUG=skia:4038
Review URL: https://codereview.chromium.org/1280073002
2015-08-07 12:49:16 -07:00
joshualitt
2771b5617c
GrDrawVertices to batches
...
BUG=skia:
Review URL: https://codereview.chromium.org/1276333004
2015-08-07 12:46:26 -07:00
jvanverth
14b8803b7c
Move GrDrawAtlasBatch to separate file
...
Committed: https://skia.googlesource.com/skia/+/b091c44c33edbad3466601b29d60bc2eaa4453fa
Review URL: https://codereview.chromium.org/1274013003
2015-08-07 12:18:54 -07:00
jvanverth
1694a936f6
Revert of Move GrDrawAtlasBatch to separate file (patchset #1 id:1 of https://codereview.chromium.org/1274013003/ )
...
Reason for revert:
Build failures
Original issue's description:
> Move GrDrawAtlasBatch to separate file
>
> Committed: https://skia.googlesource.com/skia/+/b091c44c33edbad3466601b29d60bc2eaa4453fa
TBR=joshualitt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1276173003
2015-08-07 11:53:13 -07:00
jvanverth
b091c44c33
Move GrDrawAtlasBatch to separate file
...
Review URL: https://codereview.chromium.org/1274013003
2015-08-07 11:49:17 -07:00
joshualitt
74417824cd
Make folder for batches
...
BUG=skia:
Review URL: https://codereview.chromium.org/1277233002
2015-08-07 11:42:17 -07:00
bsalomon
ebc1c10fe1
Fix warnings on VS2015 x86_64 build
...
TBR=bungeman@google.com
Review URL: https://codereview.chromium.org/1276133002
2015-08-06 17:33:16 -07:00
msarett
4ab9d5f1bc
Split SkBmpCodec into three separate classes
...
Will regress behavior on gold on test32bfv4.bmp, where we
will no longer fix transparent decodes.
TODO: Start fixing transparent decodes again, or decide
that we don't want to fix them and remove isTransparent
from SkSwizzler. I think this may become more clear when I
start implementing the scanline decoder.
BUG=skia:
Review URL: https://codereview.chromium.org/1258863008
2015-08-06 15:34:42 -07:00
scroggo
9ce386a27d
Fix color swap for webp 565
...
When webp decoding to 565, swap the colors so they look right.
BUG=skia:4174
Review URL: https://codereview.chromium.org/1280693003
2015-08-06 11:44:56 -07:00
reed
743087687a
remove guard for SrcPtr in drawBitmapRect for android
...
BUG=skia:
NOTRY=True
TBR=
Review URL: https://codereview.chromium.org/1277963002
2015-08-06 11:25:15 -07:00
reed
e47829b6b1
flag to use const& instead of const* for src-rect
...
BUG=skia:
Review URL: https://codereview.chromium.org/1272713005
2015-08-06 10:02:53 -07:00
mtklein
b6394746ff
Port SkTextureCompression opts to SkOpts
...
Pretty vanilla translation. I cleaned up who calls whom a little.
Used to be utils -> opts -> utils, now it's just utils -> opts.
I may follow up with a pass over the NEON code for readability
and to clean up dead code.
This turns on NEON A8->R11EAC conversion for ARMv8.
Unit tests which now hit the NEON code still pass.
I can't find any related bench.
BUG=skia:4117
Review URL: https://codereview.chromium.org/1273103002
2015-08-06 08:17:16 -07:00
robertphillips
d0cf9d831f
Remove SK_LEGACY_SKPOINT3_CTORS flag
...
Cannot land before Blink https://codereview.chromium.org/1274673002/ (Remove reliance on legacy Skia SkPoint3 ctors in FELighting.cpp)
Review URL: https://codereview.chromium.org/1269383003
2015-08-06 07:08:31 -07:00
mtklein
f62833d9c9
Detect MIPS DSP and DSPR2 programattically.
...
Procedure:
$ platform_tools/android/toolchains/ndk-r10c-mips-darwin_v14/bin/mipsel-linux-android-gcc -dM -E - < /dev/null | sort > vanilla.mips
$ platform_tools/android/toolchains/ndk-r10c-mips-darwin_v14/bin/mipsel-linux-android-gcc -mdsp -dM -E - < /dev/null | sort > dsp.mips
$ platform_tools/android/toolchains/ndk-r10c-mips-darwin_v14/bin/mipsel-linux-android-gcc -mdspr2 -dM -E - < /dev/null | sort > dspr2.mips
$ diff vanilla.mips dsp.mips
239a240,241
> #define __mips_dsp 1
> #define __mips_dsp_rev 1
$ diff vanilla.mips dspr2.mips
239a240,242
> #define __mips_dsp 1
> #define __mips_dsp_rev 2
> #define __mips_dspr2 1
So, defined(__mips_dsp) -> SK_MIPS_HAS_DSP, defined(__mips_dspr2) -> SK_MIPS_HAS_DSPR2.
BUG=skia:
Review URL: https://codereview.chromium.org/1274873002
2015-08-05 14:17:32 -07:00
oysteine
dfcba473b0
Moved common cross-project functionality out from SkTraceEvent.h into SkTraceEventCommon.h
...
Traditionally, SkTraceEvent.h was manually kept in sync with base/trace_event/trace_event.h, with project-specific parts intermixed, and tended to drift out of sync a lot (mainly in Blink, less so in Skia).
The SkTraceEventCommon.h now has only the cross-project parts, and can be copy-pasted verbatim between projects (it's an identical copy of base/trace_event/trace_event_common.h), meaning SkTraceEvent.h shouldn't go out of sync as it has before.
BUG=skia:
[mtklein mucking around below here]
NOPRESUBMIT=true
CQ_EXCLUDE_TRYBOTS=client.skia.fyi:skia_presubmit-Trybot
Review URL: https://codereview.chromium.org/1270783002
2015-08-05 12:54:40 -07:00
bsalomon
ee14a622b0
Give strokerectbatch a proper home
...
Review URL: https://codereview.chromium.org/1274763002
2015-08-05 10:34:05 -07:00
mtklein
6c17ca5905
Update yasm .gyp for tweaked ASAN bots.
...
They're not passing -fsanitize=address anymore, rather
-fsanitize=address,bool,etc,etc,etc...
NOTREECHECKS=true
BUG=skia:
Review URL: https://codereview.chromium.org/1269383002
2015-08-05 08:58:45 -07:00
mtklein
d029ded92d
Port morphology to SkOpts.
...
Nothing too fancy.
Direction enums become enum classes so they don't get all confused. An
alternative is to create one single Direction enum that both blur and
morphology opts use.
BUG=skia:4117
Review URL: https://codereview.chromium.org/1267343004
2015-08-04 14:09:09 -07:00
halcanary
9f8754f591
Remove experimental/PdfViewer
...
Motivation: maintaining this code doesn't seem worth the time,
since no one seems to be using it. If someone wants to use it
in the future, just revert this CL.
Review URL: https://codereview.chromium.org/1266093003
2015-08-04 14:08:44 -07:00
fmalita
1dedc3d2c0
SkPictureImageGenerator
...
R=reed@google.com
Review URL: https://codereview.chromium.org/1240093004
2015-08-04 13:53:14 -07:00
scroggo
1c005e4a38
Create a scanline decoder without creating a codec
...
Prior to this CL, if a client wanted to decode scanlines, they had to
create an SkCodec in order to get an SkScanlineDecoder. This introduces
complications if input data is not easily shared between the two
objects.
Instead, add methods to SkScanlineDecoder for creating a new one from
input data, and remove the creation functions from SkCodec.
Update DM and tests.
Review URL: https://codereview.chromium.org/1267583002
2015-08-04 09:24:45 -07:00
mtklein
dce5ce4276
Port SkBlurImage opts to SkOpts.
...
+268 -535 lines
I also rearranged the code a little bit to encapsulate itself better,
mostly replacing static helper functions with lambdas. This also
let me merge the SSE2 and SSE4.1 code paths.
BUG=skia:4117
Review URL: https://codereview.chromium.org/1264103004
2015-08-04 08:49:21 -07:00
robertphillips
fae010266f
Remove IGNORE_ROT_AA_RECT_OPT flag
...
It looks like the positive version was added (SHADER_AA_FILL_RECT) but the negative version wasn't removed.
Review URL: https://codereview.chromium.org/1271903003
2015-08-04 08:04:29 -07:00
reed
e00368018d
remove flags that control no code
...
BUG=skia:
Review URL: https://codereview.chromium.org/1259653004
2015-08-03 14:44:32 -07:00
reed
4dea94f621
remove getdevice guard for android
...
BUG=skia:
NOTRY=True
Review URL: https://codereview.chromium.org/1266363002
2015-08-03 11:45:34 -07:00
reed
c2e6827952
remove now-dead flags
...
BUG=skia:
Review URL: https://codereview.chromium.org/1258963005
2015-08-01 07:03:20 -07:00
mtklein
490b61569d
Port SkXfermode opts to SkOpts.h
...
Renames Sk4pxXfermode.h to SkXfermode_opts.h,
and refactors it a tiny bit internally.
This moves xfermode optimization from being "compile-time everywhere but NEON"
to simply "runtime everywhere". I don't anticipate any effect on perf or
correctness.
BUG=skia:4117
Review URL: https://codereview.chromium.org/1264543006
2015-07-31 11:50:27 -07:00
mtklein
7eb0945af2
Port SkUtils opts to SkOpts.
...
With this new arrangement, the benefits of inlining sk_memset16/32 have changed.
On x86, they're not significantly different, except for small N<=10 where the inlined code is significantly slower.
On ARMv7 with NEON, our custom code is still significantly faster for N>10 (up to 2x faster). For small N<=10 inlining is still significantly faster.
On ARMv7 without NEON, our custom code is still ridiculously faster (up to 10x) than inlining for N>10, though for small N<=10 inlining is still a little faster.
We were not using the NEON memset16 and memset32 procs on ARMv8. At first blush, that seems to be an oversight, but if so it's an extremely lucky one. The ARMv8 code generation for our memset16/32 procs is total garbage, leaving those methods ~8x slower than just inlining the memset, using the compiler's autovectorization.
So, no need to inline any more on x86, and still inline for N<=10 on ARMv7. Always inline for ARMv8.
BUG=skia:4117
Review URL: https://codereview.chromium.org/1270573002
2015-07-31 10:46:50 -07:00
reed
96a52c8c64
remove drawimagerect flags, as skia no longer respects them
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1262333006
2015-07-31 08:49:11 -07:00
msarett
b46e5e2033
Rename SkCodec_libbmp to SkBmpCodec
...
BUG=skia:
Review URL: https://codereview.chromium.org/1254963006
2015-07-30 11:36:40 -07:00
