Commit Graph

38977 Commits

Author SHA1 Message Date
Herb Derby
cbf22bc417 Reland "Use SkFont in the ARGBFallback code"
This is a reland of 5f178e7219

Original change's description:
> Use SkFont in the ARGBFallback code
>
> Change-Id: I028da68519220c049209ec970eb8bda98a0bab65
> Reviewed-on: https://skia-review.googlesource.com/c/178282
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Herb Derby <herb@google.com>

Change-Id: Ia5d11baf34115d279ef7843810f4be7ddb590fe8
Reviewed-on: https://skia-review.googlesource.com/c/178984
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-12-18 19:41:55 +00:00
Brian Salomon
acb056eb78 Remove unused macro GR_GL_CHECK_FBO_STATUS_ONCE_PER_FORMAT
Change-Id: I697e34c779112a01b36580a2f22ebce420542e33
Reviewed-on: https://skia-review.googlesource.com/c/178933
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-12-18 18:44:13 +00:00
recipe-roller
d81d466b8c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/24f2cc0de131c95d25fcbf30369764272f0539f2 repo: Update the repo tool to 1.24. (dgarrett@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I987743086f8f7ebdc4ecf5bad97d65288a949583
Reviewed-on: https://skia-review.googlesource.com/c/178932
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-12-18 18:40:33 +00:00
Herb Derby
6f27489c65 Use SkFont for managing distance field text
Change-Id: I4512a98063301e91bbcefe3f55de16f26601d39b
Reviewed-on: https://skia-review.googlesource.com/c/178283
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-12-18 18:19:13 +00:00
Brian Salomon
34a2030d0a Remove window rects flag from GrInternalSurfaceFlags.
This flag is annoying to set correctly when writing test code.
Fortunately it has become redundant with the "is GL FBO 0" flag.

Change-Id: Ifd88292d2d6ea05bfe0d269e853baff857e70bfe
Reviewed-on: https://skia-review.googlesource.com/c/178929
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-12-18 18:17:03 +00:00
Mike Reed
fb5f43b09f add regression test for stale fLastMoveToIndex
This test used to assert/fail under ASAN because copyPath's
fLastMoveToIndex was garbage after the internal copy (in SkPath::transform).
Now the code sets it to the src's value.

Bug:883596
Change-Id: I3cba82fb63398bf4aa0abc9d3f2a0067d8ad9006
Reviewed-on: https://skia-review.googlesource.com/c/178931
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2018-12-18 17:45:12 +00:00
Mike Reed
36c4fb3fa1 force balanced save/restore after calling a GM
Gives the caller more predictable/reliable results, and allows GMs to be
a little sloppy about how they leave the canvas.

For normal saves, this isn't really significant. But if the gm left an
unbalanced saveLayer, then we can get wacky results... Before this CL:
- raster backend balanced because ~SkCanvas got called
- gpu backend was not balanced, all we did was call flush()

Bug: skia:
Change-Id: Id058351504876db22f9915e3db0f60970fa80e39
Reviewed-on: https://skia-review.googlesource.com/c/178927
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-12-18 17:15:42 +00:00
Jim Van Verth
753403cb64 Add new GM to verify Plots marked correctly during regenerate.
There was an issue on Android where a client was drawing a small bit of text,
and then a large chunk of text below it. On the next frame they started fading
out the text and then swapped out all of the large chunk of text. We were not
marking the Plot containing the small bit of text as still in use in this case,
so it was getting overwritten by later uploads. That bug has been fixed,
but this GM tests that codepath.

Bug: b/118850208
Change-Id: I81b795d6b0ee5d5d0b8e380823a568a52118ed0c
Reviewed-on: https://skia-review.googlesource.com/c/178924
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-12-18 16:32:42 +00:00
skia-autoroll
05f2c9c9fa Roll third_party/externals/angle2 0d218da49519..720ca449767c (1 commits)
0d218da495..720ca44976


git log 0d218da49519..720ca449767c --date=short --no-merges --format='%ad %ae %s'
2018-12-18 jmadill@chromium.org Pass GN header visibility check.


Created with:
  gclient setdep -r third_party/externals/angle2@720ca449767c

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=halcanary@google.com

Change-Id: I26697b4eaa0e6d779df11482d977820d2fe8bc69
Reviewed-on: https://skia-review.googlesource.com/c/178946
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-12-18 16:24:07 +00:00
Herb Derby
c80364b2f3 Revert "Use SkFont in the ARGBFallback code"
This reverts commit 5f178e7219.

Reason for revert: Wrong result for DFT

Original change's description:
> Use SkFont in the ARGBFallback code
> 
> Change-Id: I028da68519220c049209ec970eb8bda98a0bab65
> Reviewed-on: https://skia-review.googlesource.com/c/178282
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Herb Derby <herb@google.com>

TBR=mtklein@google.com,herb@google.com

Change-Id: I6b1c9ed5beae5ddb8a1cd58c11e4b604666052db
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/178983
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-12-18 16:10:33 +00:00
Mike Klein
0ba5b18f3b fold _utils.h into _matrixProcs.cpp
Change-Id: Ie7ec7924eecebc94adb3425d2ed318f228f999e0
Reviewed-on: https://skia-review.googlesource.com/c/178980
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-12-18 15:21:06 +00:00
Greg Daniel
b2a259cb3b Pass in clip bounds when creating a GpuDrawHandler for SkDrawable.
Bug: skia:
Change-Id: I2f79622aa9796e239e0487987e1fb2833055a99e
Reviewed-on: https://skia-review.googlesource.com/c/177891
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-12-18 14:46:09 +00:00
Robert Phillips
f54883cd90 Fix recording multiple DDLs from a single DDL Recorder (take 2)
The current system works if all the DDLs (generated from a single DDL Recorder) are all replayed into the same surface but would probably fail otherwise.

Change-Id: I07fb0ca9ecfb7a6aa27766bdb62e5b41311021d4
Reviewed-on: https://skia-review.googlesource.com/c/178900
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-12-18 14:41:44 +00:00
Brian Salomon
2ab5e7829c Check for null renderer string when checking ANGLE GL info
Bug: chromium:915596
Change-Id: I9e19bf2d27f15f246cfcdcbfd6379785e258b284
Reviewed-on: https://skia-review.googlesource.com/c/178921
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-12-18 14:41:04 +00:00
Hal Canary
35cc6d7e39 SkQP: experimental docker script cleanup
No-Try: true
Change-Id: I9acecd7c20dac0de0b660e183fcbe3e44ae07715
Reviewed-on: https://skia-review.googlesource.com/c/178922
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-12-18 14:04:31 +00:00
Kevin Lubick
a6e3f6288c [canvaskit] use the live CDN version for the docs
Also update pathkit's page to use most recent version.

No-Try: true
Docs-Preview: https://skia.org/?cl=178920
Bug: skia:8584
Change-Id: I53b58b12c937b78ffd0a527b8ca5080bd2e3f156
Reviewed-on: https://skia-review.googlesource.com/c/178920
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-12-18 13:39:52 +00:00
Kevin Lubick
ffde0f63dd [canvaskit] Get docs ready for npm release
Bug: skia:8584
Change-Id: I290f13e3e05af202f2ffd33f7d9b9361efa80e46
Reviewed-on: https://skia-review.googlesource.com/c/178270
Reviewed-by: Heather Miller <hcm@google.com>
2018-12-18 12:56:18 +00:00
Robert Phillips
b67edbd12b Revert "Fix recording multiple DDLs from a single DDL Recorder"
This reverts commit 99e1709ef5.

Reason for revert: DDL failures

Original change's description:
> Fix recording multiple DDLs from a single DDL Recorder
> 
> The current system works if all the DDLs (generated from a single DDL Recorder) are all replayed into the same surface but would probably fail otherwise.
> 
> Change-Id: I0e76ecbf36aa3975049e4f48aaadd35b113a22eb
> Reviewed-on: https://skia-review.googlesource.com/c/178260
> Commit-Queue: Robert Phillips <robertphillips@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>

TBR=bsalomon@google.com,robertphillips@google.com

Change-Id: I958c0419647eee4be621bd09c2421ff3801ffe71
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/178860
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-12-18 12:45:11 +00:00
skia-autoroll
c3feb9b32c Roll third_party/externals/angle2 5a8d0bc2884b..0d218da49519 (3 commits)
5a8d0bc288..0d218da495


git log 5a8d0bc2884b..0d218da49519 --date=short --no-merges --format='%ad %ae %s'
2018-12-18 xinghua.cao@intel.com Specify texture LOD in compute shader on D3D backend
2018-12-18 xinghua.cao@intel.com Add UAV format for GL_RGBA8I
2018-12-17 ianelliott@google.com Add opt-in/out unit testing for API version below minimum


Created with:
  gclient setdep -r third_party/externals/angle2@0d218da49519

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=halcanary@google.com

Change-Id: I9cd1f829529ed0f659ba2515a08fefb4036f1fa2
Reviewed-on: https://skia-review.googlesource.com/c/178780
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-12-18 06:26:52 +00:00
recipe-roller
e295af12d0 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/cf56a4bfb07c8e7361d493754482a9b1177341cf [ninjalog_uploader] Add BuildTargetFromCommandLine function (tikuta@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I359bc6e7aa096259e0f08de05dfcdd6f48290716
Reviewed-on: https://skia-review.googlesource.com/c/178820
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-12-18 06:23:52 +00:00
skia-recreate-skps
79c3decf0c Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Idd59c93ead22abc8d19e980a1a9b1275a88c1fd7
Reviewed-on: https://skia-review.googlesource.com/c/178800
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-12-18 06:12:12 +00:00
Herb Derby
880979f32c Fix 64-bit truncate warning
BUG=chromium:910360

Change-Id: Ibd353d851626cca1b44bcfe38de5039a772bc6f0
Reviewed-on: https://skia-review.googlesource.com/c/178284
Auto-Submit: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-12-18 01:11:02 +00:00
recipe-roller
62a71f9c24 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/dc70d2e73b72e43934db0f7dd816a061aa6f428d Add post_process functions for checking the status of a step. (gbeaty@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5cafb82d794e5a15f729eecf460138981ff41622
Reviewed-on: https://skia-review.googlesource.com/c/178272
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-12-18 01:03:05 +00:00
recipe-roller
82d5468aa4 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/61cb9d6ba72b221fa702e74197258b94658c7a08 [ninjalog_uploader] add tests (tikuta@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I695e45e50c136e9dd9849b23894bde332c23a5e8
Reviewed-on: https://skia-review.googlesource.com/c/178271
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-12-18 00:27:19 +00:00
Herb Derby
5f178e7219 Use SkFont in the ARGBFallback code
Change-Id: I028da68519220c049209ec970eb8bda98a0bab65
Reviewed-on: https://skia-review.googlesource.com/c/178282
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-12-17 22:35:10 +00:00
Robert Phillips
99e1709ef5 Fix recording multiple DDLs from a single DDL Recorder
The current system works if all the DDLs (generated from a single DDL Recorder) are all replayed into the same surface but would probably fail otherwise.

Change-Id: I0e76ecbf36aa3975049e4f48aaadd35b113a22eb
Reviewed-on: https://skia-review.googlesource.com/c/178260
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-12-17 21:54:40 +00:00
Kevin Lubick
a40f832ae1 [canvaskit] Add Path2D to Canvas API
This moves the shared logic into path2d.js from
canvas2dcontext.js.

Bug: skia:
Change-Id: Id63bc52a190109f7cbc4e17ddb5603e6e87d5dc0
Reviewed-on: https://skia-review.googlesource.com/c/178268
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2018-12-17 21:19:48 +00:00
recipe-roller
ec7e37a0c8 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/fb8c1a203db839a0dbbed99af3617056139bad82 gclient eval: Replace monorail with crbug.com in error message. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4e1791b751c42fd5793e6e267310fd47d51cf14a
Reviewed-on: https://skia-review.googlesource.com/c/178267
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-12-17 21:19:09 +00:00
Herb Derby
e7f662b6cb Use SkFont in getOrCreateCache for RemoteGlyphCache
Change-Id: I784e85cb154be077a1ca1949d7806ac95269d8c8
Reviewed-on: https://skia-review.googlesource.com/c/178281
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-12-17 21:11:38 +00:00
skia-autoroll
7ec5de6ed9 Roll third_party/externals/angle2 4622905b30d1..5a8d0bc2884b (1 commits)
4622905b30..5a8d0bc288


git log 4622905b30d1..5a8d0bc2884b --date=short --no-merges --format='%ad %ae %s'
2018-12-17 ianelliott@google.com Remove version-1 API of A4A opt-in/out (a.k.a. feature-support utilities)


Created with:
  gclient setdep -r third_party/externals/angle2@5a8d0bc2884b

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=halcanary@google.com

Change-Id: I202b3671e07ecd4b5eaf534e6636a56404054fb5
Reviewed-on: https://skia-review.googlesource.com/c/178304
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-12-17 20:58:38 +00:00
Brian Salomon
5790420ccc Add new DM via, "ddl2" which records/draws DDLs for each test twice.
Clears between the two DDL runs.

Also, fix up proxy unique key checks in GrSurfaceProxy.

Change-Id: I492e791ebc57a42063f3b828c10d8bf5fee70b1b
Reviewed-on: https://skia-review.googlesource.com/c/178262
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-12-17 20:22:15 +00:00
Jim Van Verth
1694a8604b Revert "Reland Reland "Remove use of integers for atlas indexing""
This reverts commit 0711094b91.

Reason for revert: Seeing artifacts on Pixel 3 and iOS.

Original change's description:
> Reland Reland "Remove use of integers for atlas indexing"
> 
> Bug: skia:
> Change-Id: Ie37b3fd6c8682b2d778b1dd0bc38976e6761524e
> Reviewed-on: https://skia-review.googlesource.com/c/172142
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Jim Van Verth <jvanverth@google.com>

TBR=jvanverth@google.com,bsalomon@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:
Change-Id: Iff9df856ff74eeb66bf5e37496a8361474e99491
Reviewed-on: https://skia-review.googlesource.com/c/178265
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2018-12-17 20:20:45 +00:00
Mike Klein
fe64e00997 bump NDK packages to r19-beta2
Originally this started as a bump to r18, the latest stable release.
That's why each packages goes up two versions, from r17 -> r18 ->
r19-beta2.

But our ASAN bots started failing with r18, and despite quite a bit of
investigating, I've been unable to find anything wrong with our code.

Luckily, r19 is coming soon, and it looks like its beta2 works fine.
I think we should just skip r18.

Original change's description:
> bump NDK packages to r18
>
> Newer Clang, GCC is gone.
>
> Clang now supports half-float math on ARMv8, which is pretty neat.
>
> They've dropped support for everything below NDK version 16,
> which happens to be what we target for 32-bit ARM.
>
> Change-Id: Idd1b1b557c5ecaabec4040026fd2ad5adfee5ee7
> Reviewed-on: https://skia-review.googlesource.com/157260
> Reviewed-by: Derek Sollenberger <djsollen@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

Cq-Include-Trybots: skia.primary:Test-Android-Clang-Pixel-CPU-Snapdragon821-arm64-Release-All-Android_ASAN
Change-Id: I0736558fc9b732113854b1b295642e1708b04581
Reviewed-on: https://skia-review.googlesource.com/c/157761
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-12-17 20:07:36 +00:00
Ben Wagner
73e2ced5f8 [infra] Do not retry xSAN and Valgrind failures
As a side-effect, explicitly specify MaxAttempts for all "kitchen"
tasks.

Change-Id: Ia0ac825a4364952f0cda678d2cd6462a30a4912e
Reviewed-on: https://skia-review.googlesource.com/c/177883
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-12-17 19:48:56 +00:00
Hal Canary
7db6e28f64 gm: Fix eror in textToGlyphs/getXPos
Change-Id: I6f588f1268cf79eb251a6819d306e423c8b8f53a
Reviewed-on: https://skia-review.googlesource.com/c/178264
Commit-Queue: Hal Canary <halcanary@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2018-12-17 19:48:35 +00:00
Herb Derby
fc1cb226ae Use SkFont and SkScalerContextEffects for creating SkScalerContext instead of SkPaint
Track a font and effects instead of a paint to lazily create SkScalerContexts.

Change-Id: I819912dd707b69a406e5a079eb51c0a1706c6c44
Reviewed-on: https://skia-review.googlesource.com/c/178280
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-12-17 19:38:20 +00:00
recipe-roller
4b24feba11 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/a1e4d48a104af8e96b34eaa436138920f029469c setdep: Add support for variables when setting CIPD vars. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4ed8d4b7586de215c381734800fd0e4204ea5b01
Reviewed-on: https://skia-review.googlesource.com/c/178263
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-12-17 19:37:50 +00:00
Hal Canary
fc97f222ff FuzzCanvas: do textToglyphs right
Bug: skia:8635
Change-Id: I6ceec131ae9cc5796a5aba6d5cfdb16de4831a45
Reviewed-on: https://skia-review.googlesource.com/c/178261
Commit-Queue: Hal Canary <halcanary@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-12-17 19:21:10 +00:00
Herb Derby
b79ba57f20 SkFont pushed up one small step for setupCache
Make one small step up removing one use of LEGACY. Two more uses
to go in GPU.

Change-Id: I8b9ad2b2992b9eddaa49c6e03df80ae4d565d8f0
Reviewed-on: https://skia-review.googlesource.com/c/178081
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-12-17 18:52:21 +00:00
Kevin Lubick
96d9dd8d01 Prevent exponential growth of 'nice' paths when fuzzing
Bug: oss-fuzz:11491, oss-fuzz:11514 and others
Change-Id: I60f05b889a73749ddcde7cf2bf3beabab33b0538
Reviewed-on: https://skia-review.googlesource.com/c/178180
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
2018-12-17 18:27:47 +00:00
Hal Canary
cc4f7ebf28 Test-SKQP: stop checking for success
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86-devrel-Android_SKQP,Test-Debian9-Clang-NUC7i5BNK-CPU-Emulator-x86-devrel-All-Android_SKQP

Change-Id: Ie258270784472d036a0d4b925bd071a764b737f8
Reviewed-on: https://skia-review.googlesource.com/c/177899
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
2018-12-17 18:00:07 +00:00
Kevin Lubick
fa720714c4 [canvaskit] Add files needed for npm release
Backport changes to pathkit too.

Bug: skia:
Change-Id: Id10f9ac52dc7d08f044eee1eeacc8737f1cd96f4
Reviewed-on: https://skia-review.googlesource.com/c/177894
Reviewed-by: Heather Miller <hcm@google.com>
2018-12-17 17:21:34 +00:00
Cary Clark
f81cfc33b1 fix fuzz assert
Recent rewrite of SkPath::isConvexity() introduced a debugging
assert while fuzzing. The convexity computed by a proper cross product
may be zero while the short-cut cross product is zero or one.

This debugging code was added to make sure that the short cut was
correctly implemented and matched the regular code, but otherwise
isn't that important to maintain (now that it works). For now,
try fixing the assert to allow the full cross product to return zero
(e.g., if it underflows). If this shows up again, probably correct
just to delete or comment out the debugging code check.

R=kjlubick@google.com

Bug: skia:
Change-Id: If3f772432852f9e325789185cd283466af837a05
Reviewed-on: https://skia-review.googlesource.com/c/177896
Commit-Queue: Cary Clark <caryclark@skia.org>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-12-17 17:21:12 +00:00
Kevin Lubick
a96ec09599 [canvaskit] Performance tuning of GL calls
Don't check glerror on texture creation.

Initialize before texSubImage2D calls, especially for drawPath
(dramatic Firefox improvement).

Bug: skia:
Change-Id: Iec39fd84fffb886e5ecccf782fe75d419e4255d0
Reviewed-on: https://skia-review.googlesource.com/c/177893
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-12-17 16:28:30 +00:00
Hal Canary
b3907a8424 SkPDF: fix bitmap type3 glyphs.
Before, I added the resource dictionary to each glyphs's content stream.
In fact, the resource dictionary should be added to the entire font.
This change keeps track of the new resources and adds them all to the
font after looping through the glyphs.

The following gms produce differenet PDFs:
    coloremoji
    coloremoji_blendmodes
    dftext
    mixedtextblobs
    scaledemoji
    scaledemoji_rendering
    scaledemojipos
The resulting PDFs are a few bytes shorter per typeface.

The new PDFs render the same in pdfium.  The old PDFs rendered
incorrectly (missing glyphs) in Apple Preview.  The new PDFs render
correctly in Apple Preview.

Bug: skia:8629

Change-Id: Ibbd1d22f54cb26e5423e22ce3f6e8fce5479baae
Reviewed-on: https://skia-review.googlesource.com/c/177890
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-12-17 16:25:23 +00:00
Herb Derby
5f7b014f29 Only reposition the fallback vertices once.
We were shifting the verticies for the fallback subrun
twice when using paths to render. Once in regenerate,
and once using MapPoints.

BUG=chromium:913057

Change-Id: I4d2e977b0edbec22cbd57c45fe47c959d172908f
Reviewed-on: https://skia-review.googlesource.com/c/177920
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-12-17 16:21:39 +00:00
Mike Klein
5e276a6376 remove old docs
- c++11.md isn't really needed any more
  - flatten.md makes reference to code that doesn't exist
  - simd.md describes a whole system that doesn't exist
  - color.md explains a model that's fundamentally different
    to how color correction works in Skia now

Change-Id: Ib09678190d04a0dcf44eadf13c617d488307332b
Reviewed-on: https://skia-review.googlesource.com/c/178080
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-12-17 16:20:20 +00:00
Mike Klein
c53ce162f0 templatize NEON SkBitmapProcState_matrixProcs
Same deal as a last time, with the NEON code.

No GM diffs locally.

Change-Id: I917ee73bd8cfcf610b51b15c89eeee575f0e8dca
Reviewed-on: https://skia-review.googlesource.com/c/176061
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
2018-12-17 16:12:09 +00:00
Michael Ludwig
be315a2748 Decal fallback for SkImageShader
Bug: skia:
Change-Id: Ib39f74886c0edc655ded8ba1075e5205361ae650
Reviewed-on: https://skia-review.googlesource.com/c/176225
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-12-17 15:30:48 +00:00
Leon Scroggins III
1be2d421ce Update Robocop docs for skia-android-triage
Instead of looking at open Skia bugs, which may already be assigned or
have lower priority, the Robocop should be looking at open bugs assigned
to skia-android-triage. New bugs will typically (though not always) be
assigned to this new alias.

No-Try: true
Docs-Preview: https://skia.org/?cl=177889
Change-Id: Ifa006bfda5ad46f37e8e23ee80a7ee1caad8b915
Reviewed-on: https://skia-review.googlesource.com/c/177889
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-12-17 15:15:18 +00:00