Commit Graph

278 Commits

Author SHA1 Message Date
Mike Klein
2bc4077c9e notes on bazel
I have been hacking around on Bazel more today,
and while I think it was a day well spent, I've
got intentionally nothing to commit except notes.

Change-Id: I711eaf403e447aff5b19830d3ed8c5132c98c469
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316910
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-09-14 23:27:37 +00:00
Kevin Lubick
493f89e577 [fuzz] Standardize, document, and backport fuzzing defines.
We had several defines around the code base that were not
very descriptive. Additionally, we had a patch of extra
runtime restrictions living in oss-fuzz that were applied
when fuzzing over there for some fuzzers.

This has all be consolidated and controlled via the defines
documented in site/dev/testing/fuzz.md

As such, we can remove one of the patches that is in oss-fuzz,
taking us closer to being able to fuzz in the CI/CQ.

PS 1 renames existing fuzz defines to the new schema.
PS 2-3 backports skia.diff from oss-fuzz and changes those
definitions to have the _GREATLY modifier.
PS 5+ further condenses the defines so that there is one
define for gating the runtime checks.

Change-Id: Ia4ad96f30c1e9620a2123b510e97c6f501a2e257
Docs-Preview: https://skia.org/?cl=316443
Bug: skia:10713
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316443
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2020-09-14 13:36:10 +00:00
Mike Klein
72de11581b update INHERITED style
Change-Id: Ic7f3dcd39083b933e1974546e4e43c981582aa58
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/314928
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2020-09-02 20:37:29 +00:00
Ravi Mistry
f759eade0d Add documentation for 'Suggested Reviewers' button.
The button is now live, you can see it on this change as well.
Screencast of the button: https://screencast.googleplex.com/cast/NTQ5MzIzMDkxOTQ4MzM5MnwwZjM2YzQ2Yi1lNw

Change-Id: I7763bae8455453b5abd55d4c3a76db758c255a72
No-Try: true
Docs-Preview: https://skia.org/?cl=312840
Bugs: skia:10659
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312840
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2020-08-24 16:38:34 +00:00
Mike Klein
bf23d5621f style guide tweaks
Most of this is just not mentioning things that need not be mentioned
anymore, but there's one slight style tweak which I think is better,
from

    case Foo: {
        ...
        break;
    }

to

    case Foo: {
        ...
    } break;

which is a little clearer that all paths through case Foo break
when the contents of the {} block become complicated.

Change-Id: Id7fe5ab09437006d125313b07862613316dd403c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312576
Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-08-24 13:37:28 +00:00
Mike Klein
216b984d39 delete nullptr,0 section of style guide
The nullptr/0 distinction should go without saying,
and I think worrying about any of the rest just burns brainpower.

Change-Id: I7d0aea300f114e512437c3820f4e80a1408575c1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312472
Reviewed-by: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-08-24 13:17:09 +00:00
John Stiles
dfded1b0a2 Describe the Skia 'onMethodName' pattern.
This pattern is used frequently throughout the codebase but seems fairly
unique to Skia. It can be misleading if you haven't seen it before.
(In particular, the `onXxxxx` naming scheme is sometimes used to
indicate message-passing or event-handling, but that's not how it is
used in Skia.)

Change-Id: I73c5f7874bc51f8fde07baa8ef6a0e47c102302a
No-Try: true
Docs-Preview: https://skia.org/?cl=310159
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/310159
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2020-08-14 14:21:28 +00:00
Mike Klein
ed93e5e810 add SkRRect::readFromMemory() fuzzer
Change-Id: I2102056847efe9e56ba6e8150e0d451bffc8f204
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/309378
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-08-11 20:26:28 +00:00
John Stiles
c45f0cfce0 Update style guidance for [[fallthrough]].
We now use compiler-enforced fallthrough annotations.
(http://review.skia.org/296938)

Change-Id: Ia02e0f6147118f7b388315341ed41f60c53b429c
No-Try: true
Docs-Preview: https://skia.org/?cl=309045
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/309045
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2020-08-10 17:56:56 +00:00
John Stiles
fb9f2e94ad Add style guidance for k prefix on constants.
The style guide only mentioned the `k` prefix for enums, but it is
also used throughout Skia for constant values.

Also removed guidance about using anonymous enums to declare an
integral constant. static constexprs should be preferred here.

Change-Id: I2f7d4d375cc914d4efb9fe60fbd90ddaaf8c1b69
No-Try: true
Docs-Preview: https://skia.org/?cl=308919
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/308919
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2020-08-10 16:09:55 +00:00
Herb Derby
f426a93ac4 add chrome bug triage to the Sheriff's Documentation
Change-Id: I24a083a5c53212913f50f2b1da6c24b2cd31b42a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/307565
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2020-08-03 18:12:22 +00:00
John Stiles
994ce8cf23 Add a dev tools section about debug visualizers.
Change-Id: Ib866d7b8fa2b30bad0716ce9649fa8d9eaab1e41
No-Try: true
Docs-Preview: https://skia.org/?cl=306723
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/306723
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2020-07-29 21:15:43 +00:00
Leon Scroggins III
a4c8098aea Remove gendered language
Bug: chromium:1101491
Bug: b/161896447

Found using

  git grep -wiEIl \ '(he)|(she)|(his)|(hers)|(him)|(her)|(guy)|(guys)'

Change-Id: I6b91853de067fd4c2e84f7ec70275522ce6c8bfc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/306186
Commit-Queue: Leon Scroggins <scroggo@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Leon Scroggins <scroggo@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2020-07-28 15:02:41 +00:00
Leon Scroggins III
1ff07066f9 Remove more references to "master"
Bug: chromium:1101491
Bug: b/161896447

Switch to more inclusive language, like "main", or remove where
simply unnecessary.

Change-Id: I36ef6ec631eb991f54f42b98887333f07c0984c2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/306060
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-07-28 13:06:07 +00:00
Leon Scroggins III
bd220a9ebf Remove references to Golden/Diamond Master
Bug: chromium:1101491
Bug: b/161896447

We're moving to using more inclusive language, and thus removing
the word "master". Now these are just "GM" and "DM", which is how
we frequently refer to them anyway.

Change-Id: I844aeb4fc1d97a58a669b4f04821fe06f45d4c73
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/306059
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2020-07-27 20:06:31 +00:00
Zepeng Hu
c86c5239ca update markdown files
Change-Id: I26cb33017f4d808c87d2dab09078a5222db826f8
No-Try: true
Docs-Preview: https://skia.org/?cl=303956
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/303956
Commit-Queue: Zepeng Hu <zepenghu@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-07-20 18:52:55 +00:00
Ben Wagner
75626e4b1a Regularize selection of fontmgr.
Change-Id: Id7c51504450c1c7c9421eba3838bd6bc3440ca4f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295437
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2020-06-11 12:28:03 +00:00
Nigel Tao
5dbc3f87e7 Fix markdown typo in the style guide
Change-Id: I58a67d145ee088142c2791f7b447beaaf93aef56
No-Try: true
Docs-Preview: https://skia.org/?cl=292496
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/292496
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
2020-05-29 16:24:57 +00:00
Robert Phillips
9460612791 [docs] Fix file path in blink.md
Bug: 943852
Change-Id: Ife8da01538a82dfb7aebca3d6a1264c94ecabf73
No-Try: true
Docs-Preview: https://skia.org/?cl=291845
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/291845
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-05-26 15:30:24 +00:00
Ravi Mistry
4c0ffe7820 [Tree Status] Update all references in Skia repo to tree-status
* Mainly updates to documentation.
* Fix some comments in PRESUBMIT.py.
* Delete tools/lua/trigger_ct_lua. It has not worked in many years.

Bug: skia:9962
Change-Id: If6f58f173f2c8bd3fc9bdfc4db440f42489fee08
Docs-Preview: https://skia.org/?cl=274597
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/274597
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2020-03-02 18:43:49 +00:00
Leon Scroggins III
1ac12c4e4c Update link to BreakingTheBuildBots bugs
The old link just took me to a list of all open Skia bugs.

No-Try: true
Docs-Preview: https://skia.org/?cl=268300
Change-Id: I739d9243c7431df4704e0427c6958ea6a577cb24
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268300
Auto-Submit: Leon Scroggins <scroggo@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2020-02-03 14:54:34 +00:00
Nathaniel Nifong
732248c2f1 Use html tags instead of markdown for images in debugger user guide
No-Try: true
Docs-Preview: https://skia.org/?cl=266559
Change-Id: Ib1945f2f6380511d1657437e99859fb79f88529c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266559
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Nathaniel Nifong <nifong@google.com>
2020-01-27 13:41:45 +00:00
Ben Wagner
496a206ede Update remote access documentation for Win2019
No-Try: true
Docs-Preview: https://skia.org/?cl=262387
Change-Id: Ifc74fbb44a17336e335af70294b50eeeb4404a57
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262387
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2020-01-07 18:55:57 +00:00
Ben Wagner
b6f98ea2c6 Enable ASAN on Windows
Docs-Preview: https://skia.org/?cl=261336
Change-Id: Ied00d717a37d92179c01158b2fbdfa47a52270c1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261336
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-12-30 17:06:26 +00:00
Nathaniel Nifong
a8352ccaae Write a debugger user guide.
No-Try: true
Docs-Preview: https://skia.org/?cl=261088
Change-Id: I5d049ca0ee71a7bb10ff70c71b2a92604a034831
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261088
Commit-Queue: Nathaniel Nifong <nifong@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2019-12-19 17:29:49 +00:00
Hal Canary
b752a63d77 Documentation: Cq-Include-Trybots
Docs-Preview: https://skia.org/dev/contrib/cqkeywords?cl=255524
No-Try: true
Change-Id: Idb7248f5eac07474b2b079041c739c9ef9717c18
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255524
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2019-11-22 14:36:13 +00:00
Ben Wagner
9c17be5301 [infra] Update docs with respect to Go modules.
Docs-Preview: https://skia.org/?cl=255085
Change-Id: I8911862ca9814b89b8598ad743b1faa9c524399f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255085
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-11-18 18:04:19 +00:00
Ben Wagner
9fa8a909dd [docs] Add skolo-builder to swarmingbots.md
Also fix a link and a typo.

No-Try: true
Docs-Preview: https://skia.org/?cl=251765
Change-Id: I9204887fb4c07af1e07f3e7c5d24ef6029bf8d00
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/251765
Commit-Queue: Ravi Mistry <rmistry@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2019-10-30 19:06:48 +00:00
Joe Gregorio
f8813913ba [docs] - Add link to buildbot search.
No-Try: true
Docs-Preview: https://skia.org/?cl=249426
Change-Id: I75e12f90a6b52cd13b9f8fc2741d610c47293d88
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249426
Auto-Submit: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Heather Miller <hcm@google.com>
2019-10-18 17:14:22 +00:00
Joe Gregorio
5363719efb [perf] - Update docs.
No-Try: true
Docs-Preview: https://skia.org/?cl=248811
Change-Id: I23deb4000dac155294f69429e37f675bcd3fa29c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248811
Reviewed-by: Heather Miller <hcm@google.com>
Auto-Submit: Joe Gregorio <jcgregorio@google.com>
2019-10-17 18:22:45 +00:00
Ravi Mistry
cbc28f7832 Move sheriff handoff doc notes higher up
Change-Id: I3a75243caa9468895341e62205d3367d74f3b738
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/246318
Reviewed-by: Ravi Mistry <rmistry@google.com>
2019-10-04 18:08:38 +00:00
Ravi Mistry
48de6fdef5 Update sheriff doc with autorollers and handoff doc
Preview: https://skia.org/dev/sheriffing?cl=246317
NoTry: true
Change-Id: I8f32a7d0387a87e39dde7c09f25b3b314b928f24
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/246317
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-10-04 14:33:19 +00:00
Shachar Langbeheim
b5037ca889 Add comment explaining that using mirrors might break git cl.
No-Try: true
Docs-Preview: https://skia.org/?cl=220496
Change-Id: I987d912c0c62e407672d2b16631dc72a37749aab
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/220496
Reviewed-by: Heather Miller <hcm@google.com>
Auto-Submit: שחר לנגבהיים <nihohit@gmail.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-09-24 19:58:02 +00:00
Heather Miller
1f0a37ac57 fix up relative links and spacing
No-Try: true
Docs-Preview: https://skia.org/?cl=218975
Bug: skia:8365
Change-Id: I290c3185d60c8e8114adda6945e5184232be78aa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/218975
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Heather Miller <hcm@google.com>
Auto-Submit: Heather Miller <hcm@google.com>
2019-06-11 14:29:38 +00:00
Kevin Lubick
d7255a716e Make fuzzing use embedded test font
This will make fuzzing more hermetic and less machine-dependent.

Docs-Preview: https://skia.org/?cl=217864
Change-Id: If29d7b86e5290e9f749cb2fdde6f2ff892ffc333
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/217864
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-06-03 16:29:21 +00:00
Kevin Lubick
00587e32b8 Prevent UBSAN from complaining too early about invalid enums
This is making reproducing https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=15052
difficult.

Docs-Preview: https://skia.org/?cl=217457
Change-Id: I131e8c1b64f621178696b94b63bd09513ca6c170
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/217457
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2019-06-03 15:58:36 +00:00
Mike Klein
2b8b06e793 rewrite docs to explicitly use python2
I don't particularly care about Python 2 vs 3,
and don't think we're likely to leave 2 soon.

Bug: skia:9079
Change-Id: Ia28c1312309d4d9218d05915dcd21a45fe6f3727
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/213506
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-05-13 19:21:47 +00:00
Mike Klein
4941a2239e switch some idiosyncratic <includes> to ""
Change-Id: I099f8a635df7dd0ddd3902459615250ea2c120c5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209874
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-04-23 17:54:48 +00:00
Eric Boren
264000254c [docs] Update documentation for branching process
Document new chrome_release_branch script.

No-Try: true
Docs-Preview: https://skia.org/?cl=209418
Bug: skia:8932
Change-Id: Ic38840f6e8ecac309e6bd7669dd2b110ff586401
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209418
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2019-04-22 16:46:33 +00:00
Ben Wagner
8037b62312 Add more detail on configuring jobs.
Docs-Preview: https://skia.org/?cl=56020
Change-Id: I7d28d7921ab9c650498f4f8a06533f7e5df19a36
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/56020
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-03-21 10:54:17 +00:00
Mike Klein
ea3f014e2b sk_tool_utils -> ToolUtils, and git clang-format
sk_tool_utils doesn't really fit the naming convention
the rest of code under tools/ tends to use.

Change-Id: I45326a174101c6eb4b6149e9c742f658f2fd23b1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202313
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-20 18:05:42 +00:00
Joe Gregorio
ffd6a7f6d1 Change all pointers to doxygen docs to point to api.skia.org.
No-Try: true
Docs-Preview: https://skia.org/?cl=199726
Bug: skia:
Change-Id: I3dc589bfe7b693b9cd29f7262b74824968569c86
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/199726
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2019-03-11 16:53:41 +00:00
Hal Canary
0374fdce1a SkQP Documentation
No-Try: true
Change-Id: Id32e909544286eed701a1db8f0913a883af4215f
Reviewed-on: https://skia-review.googlesource.com/c/196380
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-02-28 15:58:20 +00:00
Hal Canary
8c2ccf4764 tools: bin/sync just alias for git-sync-deps now
No-Try: true
Change-Id: Id323d99c4ad0526980330daf41752452e6b09c95
Reviewed-on: https://skia-review.googlesource.com/c/194381
Auto-Submit: Hal Canary <halcanary@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-02-22 20:05:05 +00:00
Joe Gregorio
dc7ef26b13 docs - Trim down infra trooper docs.
The trimmed docs have been moved to go/skia-infra-trooper.

No-Try: true
Docs-Preview: https://skia.org/?cl=190661
Bug: skia:
Change-Id: I9214575e763ed1bcd0f3396a539df63a8394a84c
Reviewed-on: https://skia-review.googlesource.com/c/190661
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Auto-Submit: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2019-02-08 15:12:26 +00:00
Kevin Lubick
9590f86e89 Add a k8s cheat sheet to trooper docs
No-Try: true
Docs-Preview: https://skia.org/?cl=190201
Bug: skia:
Change-Id: Idd7d1838a648e1e73d76720dc07bd425ff7929a3
Reviewed-on: https://skia-review.googlesource.com/c/190201
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2019-02-07 14:46:50 +00:00
Brian Osman
1345366c21 Update tracing docs slightly
Prioritize "Chrome Tracing", and rename it to not sound like it's
specific to Skia-in-Chrome. Also mention the 256 MB file size limit.
Include basic trace event example, and link to more thorough docs
in the code.

No-Try: true
Docs-Preview: https://skia.org/?cl=188306
Bug: skia:
Change-Id: I882f2a81dfcce33847029f0800b27baa2f98308d
Reviewed-on: https://skia-review.googlesource.com/c/188306
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Heather Miller <hcm@google.com>
2019-01-31 19:10:53 +00:00
Hal Canary
4ca9fa30ba SkPDF: unify Canon and Document
motivation:  The Document has become intrusive enough that we almost
always have a pointer to the Document on hand anyways.

Also: update document.

Also: forward declare more things in headers.

Also, don't try to clean up resources when abort() or close() is called.
It is easy enough for the client to delete the Document when done.

Change-Id: I21aeed37f26ba16d68af041d9317adf00e9a61f2
Reviewed-on: https://skia-review.googlesource.com/c/180646
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2019-01-14 17:56:14 +00:00
Ned Nguyen
9716603f97 Update skia docs to stop referring to NeedsManualRebaseline
No-Try: true
Docs-Preview: https://skia.org/?cl=179782
Bug: chromium:621126
Change-Id: Iee8d6d86a5cda31d84d4ebe708c7f6fd9f80f78b
Reviewed-on: https://skia-review.googlesource.com/c/179782
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-01-11 17:14:06 +00:00
Joe Gregorio
0ae5f90985 Fix link in /dev/contrib.
No-Try: true
Docs-Preview: https://skia.org/?cl=181168
Bug: skia:8654
Change-Id: I409a9138c13937f9aac986fd68866862512be9dd
Reviewed-on: https://skia-review.googlesource.com/c/181168
Auto-Submit: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2019-01-04 15:16:06 +00:00