Commit Graph

1221 Commits

Author SHA1 Message Date
robertphillips
e4c53202e9 Rebaselines for https://codereview.chromium.org/785893004/ (Fix MatrixImageFilter computeFastBounds)
The msaa4 image diffs aren't actually due to the named CL

TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/787093002
2014-12-09 07:15:20 -08:00
scroggo
2b6658a7e3 Rebaseline GalaxyS4 and Nexus10.
TBR=bsalomon

Review URL: https://codereview.chromium.org/757413003
2014-12-09 05:49:50 -08:00
Brian Salomon
cf56009d90 Massive N10 Rebaseline Part 2
BUG=skia:3205

Review URL: https://codereview.chromium.org/790533002
2014-12-08 13:57:30 -05:00
jvanverth
999f5e73a1 Update dftext expectations after https://codereview.chromium.org/772633003/.
BUG=skia:3195, skia:3188
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/778043003
2014-12-08 08:10:31 -08:00
Brian Salomon
7d74cd1312 Massive N10 Rebaseline
BUG=skia:3193

Review URL: https://codereview.chromium.org/783173002
2014-12-08 10:50:04 -05:00
reed
e78f11e9b1 rebaseline after GM change
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/784603002
2014-12-05 12:46:23 -08:00
reed
22c9ae18e2 rebaseline after change to imagefilterscropped gm change
BUG=skia:
NOTRY=True
TBR=

Review URL: https://codereview.chromium.org/779313002
2014-12-05 09:18:28 -08:00
jvanverth
b35760e286 Ignore failures for n7 and n10 dftext GM.
BUG=skia:3188
TBR=halcanary@google.com

Review URL: https://codereview.chromium.org/785433002
2014-12-04 16:01:53 -08:00
halcanary
32fee2907e rebaseline pdf-native
TBR=
NOTRY=true

Review URL: https://codereview.chromium.org/779073002
2014-12-04 10:41:45 -08:00
halcanary
4b8128ce9a pdf-mac clear to black rebaseline
NOTRY=true
TBR=
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/783543002
2014-12-04 10:21:04 -08:00
robertphillips
eeb6f0c3c0 Rebaseline multipicturedraw GMs
This is clean up after https://codereview.chromium.org/753253002/ (Use variable length key (rather than accumulated matrix) as save layer hoisting key)

TBR=halcanary@google.com

Review URL: https://codereview.chromium.org/783523002
2014-12-04 08:43:54 -08:00
halcanary
85a5750ffa Fix PdfViewer BGR byte order
BUG=skia:3184

Review URL: https://codereview.chromium.org/775763003
2014-12-03 11:03:52 -08:00
Brian Salomon
5ab7e80f2b rebaseline images
TBR=

Review URL: https://codereview.chromium.org/776983003
2014-12-03 13:36:10 -05:00
jvanverth
3e5d4a124c Update color emoji GMs after https://codereview.chromium.org/759613005/.
TBR=halcanary@google.com

Review URL: https://codereview.chromium.org/775163002
2014-12-03 10:35:37 -08:00
joshualitt
ed8bdc5193 bug fix for cubic low precision
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/776953002
2014-12-03 09:29:53 -08:00
halcanary
e2158a52e9 update tileimagefilter gm expectations
TBR=reed@google.com

NOTRY=true

Review URL: https://codereview.chromium.org/777683002
2014-12-03 08:59:48 -08:00
Mike Klein
43c79b9c64 Rebaseline verylargebitmap
BUG=skia:

Review URL: https://codereview.chromium.org/778693002
2014-12-03 11:32:37 -05:00
halcanary
cd948b56c9 (re)baseline several of my gms
TBR=
NOTRY=true

Review URL: https://codereview.chromium.org/780593002
2014-12-03 08:17:58 -08:00
joshualitt
2dd1ae016d First step to moving vertex attributes to the geometryProcessor
BUG=skia:

Review URL: https://codereview.chromium.org/761563002
2014-12-03 06:24:10 -08:00
reed
2b06ddc179 Revert of rebaseline after clear change -- pdf was not treating clear as SRC_MODE (patchset #1 id:1 of https://codereview.chromium.org/759303004/)
Reason for revert:
reverted clear() change

Original issue's description:
> rebaseline after clear change -- pdf was not treating clear as SRC_MODE
>
> BUG=skia:
> NOTRY=True
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/2fb352abebc342a322d4a66c054bbff8bd565767

TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/774073002
2014-12-02 20:04:41 -08:00
halcanary
a2a64672f3 baseline colorwheelnative
TBR=scroggo@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/777443002
2014-12-02 12:31:26 -08:00
reed
2fb352abeb rebaseline after clear change -- pdf was not treating clear as SRC_MODE
BUG=skia:
NOTRY=True
TBR=

Review URL: https://codereview.chromium.org/759303004
2014-12-02 12:21:03 -08:00
Justin Novosad
5234075b1c Adding a PictureResolution option to SkPictureImageFilter
This change adds an option to SkPictureImageFilter to make it
rasterize SkPicture in a resolution that matches the local coordinate
space (equivalent to the record-time device space).

BUG=skia:3176
R=reed@google.com, senorblanco@chromium.org

Review URL: https://codereview.chromium.org/753073010
2014-12-02 14:50:56 -05:00
derekf
367e1867b2 use drawRect when drawing a bitmap with anti-aliasing on a non-msaa target
If the dest isn't pixel aligned, or if a non 90 degree rotation is
present, we need to use drawRect() for drawing anti-aliased bitmaps on
non-msaa targets or the edges won't be anti-aliased as intended.

Note: If the bitmap size is bigger than max texture size we fall back to drawBitmapCommon.

Original-Author: Henry Song <henrysong@samsung.com>

Review URL: https://codereview.chromium.org/649313003
2014-12-02 11:02:06 -08:00
halcanary
bfda8a7785 updated expectations from d476a176b7
BUG=skia:3180
TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/773833002
2014-12-02 07:29:19 -08:00
robertphillips
01d6e5f462 Use variable length key (rather than accumulated matrix) as save layer hoisting key
Adding the rendering canvas' CTM to the layer hoisting key (i.e., Add support for hoisting layers in pictures drawn with a matrix - https://codereview.chromium.org/748853002/) has increased the cache miss rate due to accumulated floating point error. This CL fixes part of the issue by using the chain of operation indices leading to each saveLayer as the key. The canvas' CTM must still form part of the key but should be less subject to accumulated error.

BUG=skia:2315

Review URL: https://codereview.chromium.org/753253002
2014-12-01 09:09:27 -08:00
robertphillips
821e352238 Rebaselines
This CL rebaselines:

Two GMs from https://codereview.chromium.org/748853002 (Add support for hoisting layers in pictures drawn with a matrix) which are only now showing up:

S4 Debug multipicturedraw_invpathclip_tiled_gpu
S4 Debug multipicturedraw_pathclip_tiled_gpu

Two GMs most likely from https://codereview.chromium.org/747043004 (Use scratch keys for stencil buffers):

Win8 Debug dashing2_nvprmsaa4
Win8 Debug glyph_pos_n_b_msaa16

Note that the dashing2 difference fixes an erroneously set pixel in the expected.

TBR=bsalomon@google.com, tomhudson@google.com

Review URL: https://codereview.chromium.org/758023003
2014-11-25 07:38:46 -08:00
robertphillips
551051c049 Marking three GMs ignore-failure
These appear to be recurrent flakes

TBR=tomhudson@google.com

Review URL: https://codereview.chromium.org/750943003
2014-11-25 06:17:49 -08:00
bsalomon
10e23caea3 Use scratch keys for stencil buffers.
BUG=skia:2889

Committed: https://skia.googlesource.com/skia/+/91175f19664a62851da4ca4e0984a7c7c45b258f

Review URL: https://codereview.chromium.org/747043004
2014-11-25 05:52:06 -08:00
robertphillips
03bee31e55 Rebaselines for https://codereview.chromium.org/748853002
Add support for hoisting layers in pictures drawn with a matrix - https://codereview.chromium.org/748853002 changed the following GMs:

multipicturedraw_sierpinski_tiled
multipicturedraw_rrectclip_tiled
multipicturedraw_rectclip_tiled

Note that it also, somewhat mysteriously, "fixed" the rendering bugs in some of the S4's multipicturedraw images (see skia:3116).

TBR=tomhudson@google.com

Review URL: https://codereview.chromium.org/755183003
2014-11-25 05:24:00 -08:00
bsalomon
19cd0f1813 Revert "Use scratch keys for stencil buffers."
This reverts commit 91175f1966.

Revert "Cleanup res cache bench and split out into a unit test."

This reverts commit 4e4303f002.

Revert "rebaselines"

This reverts commit 65ba7b5775.

TBR=tomhudson@google.com

Review URL: https://codereview.chromium.org/752233002
2014-11-24 12:19:06 -08:00
tomhudson
9891317557 Revert of More rebaselines (patchset #1 id:1 of https://codereview.chromium.org/754833003/)
Reason for revert:
Reverted causative patchset (https://codereview.chromium.org/747043004)

Original issue's description:
> More rebaselines
>
> TBR=
> NOTRY=true
> NOTREECHECKS=true
>
> Committed: https://skia.googlesource.com/skia/+/0ef7ba2a43a41e8e1e49a5187073db6dcca345b4

TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/756633004
2014-11-24 11:27:42 -08:00
tomhudson
2a42d15e06 Revert of more rebaselines (patchset #1 id:1 of https://codereview.chromium.org/755653003/)
Reason for revert:
Reverted causative patch (https://codereview.chromium.org/747043004)

Original issue's description:
> more rebaselines
>
> TBR=
> NOTRY=true
> NOTREECHECKS=true
>
> Committed: https://skia.googlesource.com/skia/+/f2fdc8b746acac9daa94b21d3849f60a87064fd4

TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/754103002
2014-11-24 11:24:46 -08:00
robertphillips
6247fa0ba0 Suppress additional multipicturedraw GM for Android
One Android bot is failing on the rect test case.

TBR=tomhudson@google.com
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/750203003
2014-11-24 10:56:21 -08:00
robertphillips
02758c74db Sigh - remove whitespace from end of suppressions text line
TBR=tomhudson@google.com
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/754783003
2014-11-24 10:23:07 -08:00
robertphillips
0bcf523f0b Add suppressions for https://codereview.chromium.org/748853002
TBR=tomhudson@google.com
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/753103005
2014-11-24 10:06:47 -08:00
bsalomon
0ef7ba2a43 More rebaselines
TBR=
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/754833003
2014-11-24 08:39:09 -08:00
bsalomon
f2fdc8b746 more rebaselines
TBR=
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/755653003
2014-11-24 08:13:49 -08:00
bsalomon
65ba7b5775 rebaselines
NOTRY=true
NOTREECHECKS=true
TBR=

Review URL: https://codereview.chromium.org/753133003
2014-11-24 08:03:24 -08:00
mtklein
fc1e996bcc ack verylargebitmap diffs
NOTRY=true

BUG=skia:

Review URL: https://codereview.chromium.org/752693002
2014-11-21 12:52:46 -08:00
robertphillips
8f81b69ed7 Ignore a flaky msaa4 GM and some perma-broken S4 GMs
The Ubuntu12 msaa4 image seems to flake randomly
The S4 images are covered by skia:3116 (Galaxy S4 exhibits some saveLayer bugs (both normal and with hoisting))

TBR=humper@google.com

Review URL: https://codereview.chromium.org/748773003
2014-11-21 07:24:01 -08:00
joshualitt
5f3e081504 rebasing a bunch of 0% android mismatches
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/744383002
2014-11-20 16:51:50 -08:00
cdalton
ffe2f1cbd0 Rebaseline textblobshader expectation for nvpr
Rebaseline after https://codereview.chromium.org/712223002. The
difference is a result of using different bounding boxes to cover
gradient fills, which caused a few pixels do differ by a value of one.

BUG=skia:

Review URL: https://codereview.chromium.org/746603002
2014-11-20 14:30:08 -08:00
Greg Humphreys
ac1383db67 even more stragglers -- hopefully this makes the gtx machine go green?
BUG=skia:

Review URL: https://codereview.chromium.org/716243005
2014-11-19 17:28:53 -05:00
Greg Humphreys
c58a33c95b more rebaseline stragglers
BUG=skia:

Review URL: https://codereview.chromium.org/726373004
2014-11-19 17:02:31 -05:00
Greg Humphreys
c66d813c18 a few straggling rebaselines
BUG=skia:

Review URL: https://codereview.chromium.org/742893002
2014-11-19 16:35:20 -05:00
joshualitt
d31985ecc8 setting patch_primitive_nvprmsaa4 on K1 to ignore
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/743563003
2014-11-18 17:38:36 -08:00
Greg Humphreys
914dd53a42 ignore dashcubics test pending skia bug 2049
BUG=skia:2049

Review URL: https://codereview.chromium.org/741533002
2014-11-18 15:42:19 -05:00
Greg Humphreys
82e3552d68 a few straggling rebaselines
BUG=skia:

Review URL: https://codereview.chromium.org/738943003
2014-11-18 15:23:05 -05:00
Greg Humphreys
ccedeccdb7 more rebaselines for the perspective test server
BUG=skia:

Review URL: https://codereview.chromium.org/727063004
2014-11-18 15:19:45 -05:00