bsalomon@google.com
b6b0cf3215
more PDF filterbitmap ignores
...
Review URL: https://codereview.chromium.org/123933005
git-svn-id: http://skia.googlecode.com/svn/trunk@12944 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-07 17:50:04 +00:00
commit-bot@chromium.org
69ac6defc1
rebaseline_server: allow spaces within test/config names
...
(SkipBuildbotRuns)
BUG=skia:1969
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon
Author: epoger@google.com
Review URL: https://codereview.chromium.org/99373010
git-svn-id: http://skia.googlecode.com/svn/trunk@12943 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-07 17:21:11 +00:00
bsalomon@google.com
a19818a146
Make imagealphathreshold GM skip replay modes until it is fixed.
...
TBR=zork@chromium.org
Review URL: https://codereview.chromium.org/94043005
git-svn-id: http://skia.googlecode.com/svn/trunk@12942 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-07 17:20:33 +00:00
commit-bot@chromium.org
11f156201a
add unittest for render_pictures binary
...
Once committed, this will be run as part of RunToolSelfTests on http://108.170.217.252:10117/builders/Housekeeper-PerCommit .
BUG=skia:1943
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/124253002
git-svn-id: http://skia.googlecode.com/svn/trunk@12941 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-07 17:03:40 +00:00
commit-bot@chromium.org
85facf71ef
Add StackBench to measure performance on stack-like (fixed element size) work loads.
...
BUG=303282
R=reed@google.com , caryclark@google.com , mtklein@chromium.org
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/110893007
git-svn-id: http://skia.googlecode.com/svn/trunk@12940 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-07 17:03:31 +00:00
robertphillips@google.com
81e8739a10
NoSaveLayerCanvas now its own file
...
https://codereview.chromium.org/120553003/
git-svn-id: http://skia.googlecode.com/svn/trunk@12938 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-07 16:08:04 +00:00
commit-bot@chromium.org
9109e188c7
Fix build warnings in SkAlphaThresholdFilter
...
BUG=None
R=bsalomon@google.com
Author: zork@chromium.org
Review URL: https://codereview.chromium.org/101763010
git-svn-id: http://skia.googlecode.com/svn/trunk@12937 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-07 16:04:01 +00:00
skia.committer@gmail.com
179f6c5e62
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12936 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-07 07:01:50 +00:00
commit-bot@chromium.org
40eb3c1000
Add AlphaThreshold filter.
...
This is based on the Bitmap Alpha Threshold filter, and will be used by Chromium
to implement the window shape API.
R=bsalomon@chromium.org , wez@chromium.org , bsalomon@google.com , reed@google.com
Author: zork@chromium.org
Review URL: https://codereview.chromium.org/115633002
git-svn-id: http://skia.googlecode.com/svn/trunk@12935 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 23:41:14 +00:00
bsalomon@google.com
f6c8aeb174
Mark pdf filterbitmap images as failure ignored
...
Review URL: https://codereview.chromium.org/121883006
git-svn-id: http://skia.googlecode.com/svn/trunk@12933 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 23:25:38 +00:00
bsalomon@google.com
ec7d9b7880
Rebaseline filterbitmap_image_mandrill N4 GPU images
...
BUG=skia:1879
Review URL: https://codereview.chromium.org/102963011
git-svn-id: http://skia.googlecode.com/svn/trunk@12931 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 22:50:28 +00:00
bsalomon@google.com
4fdf25e6cc
rebaseline downsample_text and downsample_checkerboard GMs on gpu configs
...
BUG=skia:1879
Review URL: https://codereview.chromium.org/125463002
git-svn-id: http://skia.googlecode.com/svn/trunk@12930 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 22:31:14 +00:00
bsalomon@google.com
7b22744ff0
Rebaselines for filterbitmap_text GMs
...
BUG=skia:1879
Review URL: https://codereview.chromium.org/109403007
git-svn-id: http://skia.googlecode.com/svn/trunk@12929 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 22:00:04 +00:00
bsalomon@google.com
79c95324b1
Rebaselines for filterbitmap_checkerboard
...
BUG=skia:1879
Review URL: https://codereview.chromium.org/108653019
git-svn-id: http://skia.googlecode.com/svn/trunk@12928 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 21:48:23 +00:00
commit-bot@chromium.org
69a0d7a335
DM: fix failures when using -r by comparing unpremultiplied.
...
PNGs store unpremultiplied colors, so we have to convert back and forth with
SkBitmap. This is lossy. GM solves this problem by stripping the alpha
channel before writing the PNG.
This flips it around, converting the GM's output to unpremultiplied as needed. This way each pixel goes from premul to unpremul once, never back.
Tested:
out/Release/dm -w /tmp/w --config 565 8888 gpu
out/Release/dm -r /tmp/w --config 565 8888 gpu
BUG=
R=bsalomon@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/122923003
git-svn-id: http://skia.googlecode.com/svn/trunk@12926 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 20:24:21 +00:00
commit-bot@chromium.org
8f88117940
Cap memory usage in path_create bench.
...
Memory usage grows unbounded in path_create without this patch (growing the
paths). This bench also somewhat needlessly cycles through 32 paths, so now
we just work with one.
Peak memory usage drops from ~2-3G to ~150M. This should fix the NexusS crashes,
or at least get us to the next one.
BUG=skia:1687
R=caryclark@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/111283007
git-svn-id: http://skia.googlecode.com/svn/trunk@12925 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 20:19:14 +00:00
bsalomon@google.com
da0f7616e9
Rebaseline mandrill GMs
...
BUG=skia:1879
Review URL: https://codereview.chromium.org/114603008
git-svn-id: http://skia.googlecode.com/svn/trunk@12924 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 20:18:15 +00:00
commit-bot@chromium.org
9ee0e32886
Turn on GL drawing, allow switching via --gpu flag.
...
This CL comes after https://codereview.chromium.org/121303004/ .
BUG=
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/122453003
git-svn-id: http://skia.googlecode.com/svn/trunk@12923 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 20:03:55 +00:00
halcanary@google.com
31fdb92995
DEPS roll script
...
This script:
- searches through the last N commits to find out the hash that is
associated with the revision number.
- creates a new branch in the chromium tree, modifies the DEPS
file, commits, and uploads to Rietveld.
- create a whitespace-only commit and uploads that to to Rietveld.
BUG=
R=borenet@google.com
Review URL: https://codereview.chromium.org/123523003
git-svn-id: http://skia.googlecode.com/svn/trunk@12921 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 19:50:22 +00:00
robertphillips@google.com
11e10e340b
Patch for Windows compilation errors from r12916
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12919 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 19:09:29 +00:00
reed@google.com
614cbeef47
remove SK_SUPPORTED_DEPRECATED_FIXEDROUND, no longer needed
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12918 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 18:49:32 +00:00
rmistry@google.com
6ab96733b8
Support mesa config in render_pictures.
...
R=epoger@google.com , robertphillips@google.com
Review URL: https://codereview.chromium.org/125083004
git-svn-id: http://skia.googlecode.com/svn/trunk@12916 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 18:37:24 +00:00
commit-bot@chromium.org
2a78e82f5e
create gm/rebaseline_server/test_all.py
...
Uses proper Python unittest framework to launch all unittests within the directory.
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/125253002
git-svn-id: http://skia.googlecode.com/svn/trunk@12915 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 18:33:19 +00:00
commit-bot@chromium.org
91e3ffded5
These strings are unused.
...
R=reed@google.com , halcanary@google.com
BUG=
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/102393005
git-svn-id: http://skia.googlecode.com/svn/trunk@12914 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 18:29:14 +00:00
commit-bot@chromium.org
c8d732800e
Renamed JsCanvas to JsContext and moved into it's own file.
...
Fleshed out a lot of the Path interface.
BUG=
R=robertphillips@google.com , tfarina@chromium.org , reed@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/121303004
git-svn-id: http://skia.googlecode.com/svn/trunk@12913 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 18:17:24 +00:00
reed@google.com
d0419b1fe7
Revert "Revert "Revert "Revert of https://codereview.chromium.org/110593003/ """
...
This reverts commit aaa89649590323fe40f52439d9a9a3376bb3b8ae.
BUG=
Review URL: https://codereview.chromium.org/123223007
git-svn-id: http://skia.googlecode.com/svn/trunk@12910 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 17:08:27 +00:00
commit-bot@chromium.org
86b39f311e
Avoid some work on SkClipStack equality when the topmost genids match
...
Two clip stacks are defined being equal if the topmost genids match.
R=bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/115573005
git-svn-id: http://skia.googlecode.com/svn/trunk@12909 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 16:54:20 +00:00
reed@google.com
7627c657b0
add rowBytes param to setPreLock, in prep for onNewLockPixels change
...
need _win.cc change from https://codereview.chromium.org/124503002/ when this lands in chrome
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/125063002
git-svn-id: http://skia.googlecode.com/svn/trunk@12907 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 15:01:48 +00:00
reed@google.com
ba82bd11e2
Revert "Revert "Revert of https://codereview.chromium.org/110593003/ ""
...
This reverts commit 0fef787f33aa38109a0c8427e0098d997efdd5ff.
failed in chrome: https://codereview.chromium.org/124503002/
Review URL: https://codereview.chromium.org/105523008
git-svn-id: http://skia.googlecode.com/svn/trunk@12906 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 13:34:39 +00:00
tfarina@chromium.org
452eecb443
Convert two more tests to DEF_TEST() macro.
...
Out of three, two were converted.
These tests were found with the following command line:
$ g grep "public Test"
BUG=None
TEST=ran tests executable fine.
R=mtklein@google.com
Review URL: https://codereview.chromium.org/122943004
git-svn-id: http://skia.googlecode.com/svn/trunk@12905 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 12:43:53 +00:00
mike@reedtribe.org
9fb00413ec
SK_SUPPORTED_DEPRECATED_FIXEDROUND around deprecated fixed[round,ceil,floor]
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12903 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 03:02:37 +00:00
senorblanco@chromium.org
4e4b09a44e
Rebaselines for more straggling bots.
...
TBR=
Review URL: https://codereview.chromium.org/121943003
git-svn-id: http://skia.googlecode.com/svn/trunk@12902 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-04 17:22:04 +00:00
skia.committer@gmail.com
98272d9142
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12901 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-04 07:01:40 +00:00
senorblanco@chromium.org
7b6d4d6783
Yet more rebaselines from straggling bots.
...
BUG=
TBR=
Review URL: https://codereview.chromium.org/116463005
git-svn-id: http://skia.googlecode.com/svn/trunk@12900 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-04 04:19:38 +00:00
senorblanco@chromium.org
4e13914e3c
Stragglers.
...
TBR=
Review URL: https://codereview.chromium.org/124353004
git-svn-id: http://skia.googlecode.com/svn/trunk@12899 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-04 02:36:24 +00:00
senorblanco@chromium.org
323cc26308
New baselines for tileimagefilter, imagefiltersgraph, and everything Nexus4.
...
TBR=
Review URL: https://codereview.chromium.org/101693010
git-svn-id: http://skia.googlecode.com/svn/trunk@12898 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-04 00:14:54 +00:00
senorblanco@chromium.org
c8c599269d
Widen suppression to tileimagefilter-pdf.
...
TBR=
Review URL: https://codereview.chromium.org/122683004
git-svn-id: http://skia.googlecode.com/svn/trunk@12897 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 22:27:05 +00:00
senorblanco@chromium.org
a502d60b93
Ignore failures on tileimagefilter-pdf_poppler.
...
TBR=
Review URL: https://codereview.chromium.org/124263003
git-svn-id: http://skia.googlecode.com/svn/trunk@12896 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 22:18:12 +00:00
senorblanco@chromium.org
6776b82d46
Make SkImageFilter crop rects relative to the primitive origin, instead of relative to their parent's crop rect. This is required by SVG semantics, and is more sane anyway.
...
To do this, this patch changes the "offset/loc" parameter in filterImage() / onFilterImage() from an inout-param to an out-param only, so that the calling filter can know how much the input filter wants its result offset (and doesn't include the original primitive position). This offset can then be applied to the current filter's crop rect. (I've renamed the parameter "offset" in all cases to make this clear.) This makes the call sites in SkCanvas/SkGpuDevice responsible for applying the resulting offset to the primitive's position, which is actually a fairly small change.
This change also fixes SkTileImageFilter and SkOffsetImageFilter to correctly handle an input offset, which they weren't before. This required modifying the GM's, since they assumed the broken behaviour.
NOTE: this will require rebaselining the imagefiltersgraph test, since it has a new test case.
NOTE: this will "break" the Blink layout tests css3/filters/effect-reference-subregion-chained-hw.html and css3/filters/effect-reference-subregion-hw.html, but it actually makes them give correct results. It should be suppressed on the skia roll, and I'll rebaseline it.
R=reed@google.com
Review URL: https://codereview.chromium.org/112803004
git-svn-id: http://skia.googlecode.com/svn/trunk@12895 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 21:48:22 +00:00
reed@google.com
927138977f
Revert "Revert of https://codereview.chromium.org/110593003/ "
...
This reverts commit c7abb25b25ba8b97948371d2bf0a2e3e78468f73.
and fixes the ashmem break
BUG=
Review URL: https://codereview.chromium.org/119753010
git-svn-id: http://skia.googlecode.com/svn/trunk@12887 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 17:58:57 +00:00
commit-bot@chromium.org
d4bda508c9
Add SkPreConfig.h to core.gypi
...
BUG=
R=reed@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/116903007
git-svn-id: http://skia.googlecode.com/svn/trunk@12886 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 17:25:52 +00:00
commit-bot@chromium.org
758b7a4c89
rebaseline gm self-tests after https://code.google.com/p/skia/source/detail?r=12850
...
The GM self-test's fragility is already noted in https://code.google.com/p/skia/issues/detail?id=1068 ('make gm self-test more robust')
NOTRY=True
NOTREECHECKS=True
R=mtklein@google.com
TBR=mtklein
Author: epoger@google.com
Review URL: https://codereview.chromium.org/112203006
git-svn-id: http://skia.googlecode.com/svn/trunk@12885 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 16:37:16 +00:00
commit-bot@chromium.org
27f890219b
Revert of https://codereview.chromium.org/110593003/
...
Reason for revert: SkImageRef_ashmem doesn't compile
R=halcanary@google.com , scroggo@google.com
TBR=halcanary@google.com , scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=
Author: reed@google.com
Review URL: https://codereview.chromium.org/119753009
git-svn-id: http://skia.googlecode.com/svn/trunk@12884 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 16:32:45 +00:00
reed@google.com
f1ce05288a
Add onNewLockPixels, that returns rowbytes and relies on info in pixelref
...
This reverts commit 890a6ec633c1f54891104a072a8964b4c2c81af9.
BUG=
R=scroggo@google.com
Review URL: https://codereview.chromium.org/110593003
git-svn-id: http://skia.googlecode.com/svn/trunk@12883 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 16:22:48 +00:00
commit-bot@chromium.org
0bf919c89a
make results_test.py work better within python unittest framework
...
BUG=
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/122443006
git-svn-id: http://skia.googlecode.com/svn/trunk@12882 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 16:04:11 +00:00
reed@google.com
dcea5300dc
assert in setPixelRef that the pr matches the bitmap's config
...
BUG=
R=halcanary@google.com
Review URL: https://codereview.chromium.org/120063003
git-svn-id: http://skia.googlecode.com/svn/trunk@12880 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 13:43:01 +00:00
skia.committer@gmail.com
862020763d
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12875 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 07:01:45 +00:00
commit-bot@chromium.org
04018f37af
An SkOSWindow for Unix may experience stuttering, with missed events or long delays before events are processed when using SkEvent.postDelay().
...
The issue is with the use of a select loop to watch for events coming into the x11 file descriptor for the display. It turns out there may be XEvents queued in memory but not yet processed that need to be handled before entering the select loop. See: http://developerweb.net/viewtopic.php?id=3184
BUG=1960
R=reed@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/123303004
git-svn-id: http://skia.googlecode.com/svn/trunk@12874 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-02 22:21:47 +00:00
commit-bot@chromium.org
07adb6359f
Function pointers -> templates in SkPictureFlat.
...
These flatten/unflatten function pointers were driving me nuts when reading the
generated assembly for this code. We don't need the flexibility of function
pointers here, so let's use templates to make it more manageable. You'll
notice we get much better typing now on flatten/unflatten.
BUG=
R=reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/123213004
git-svn-id: http://skia.googlecode.com/svn/trunk@12873 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-02 22:20:49 +00:00
tfarina@chromium.org
78e7b4e1b9
Get rid of DEFINE_TESTCLASS_SHORT() macro.
...
Instead tests should be written using DEF_TEST() macro, which is much
nicer and simplifies the process of setting up an unit test.
BUG=None
TEST=skpskgr_test, pathops_unittest
R=mtklein@google.com
Review URL: https://codereview.chromium.org/117863005
git-svn-id: http://skia.googlecode.com/svn/trunk@12870 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-02 21:45:03 +00:00