Commit Graph

40164 Commits

Author SHA1 Message Date
Mike Reed
31cc6d7917 utility to check if floats are [0...1]
Bug: skia:
Change-Id: I9bab3ff73d3934786d7457c4b1bcf67d01c653f3
Reviewed-on: https://skia-review.googlesource.com/c/196060
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-02-27 21:43:31 +00:00
skia-autoroll
aee41a1792 Roll third_party/externals/swiftshader 105fd0f651d1..17078c70fc9c (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/105fd0f651d1..17078c70fc9c


git log 105fd0f651d1..17078c70fc9c --date=short --no-merges --format='%ad %ae %s'
2019-02-27 senorblanco@chromium.org Fix push & pop of XMM registers.


Created with:
  gclient setdep -r third_party/externals/swiftshader@17078c70fc9c

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I9ac72e3f02aeee159ba000ea30efea9d47f0811d
Reviewed-on: https://skia-review.googlesource.com/c/196015
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-27 21:42:51 +00:00
skia-autoroll
8d77e94b8a Roll third_party/externals/swiftshader 928dfeed1796..105fd0f651d1 (4 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/928dfeed1796..105fd0f651d1


git log 928dfeed1796..105fd0f651d1 --date=short --no-merges --format='%ad %ae %s'
2019-02-27 headlessclayton@gmail.com VkDebug.hpp: Call abort() after assert(false)
2019-02-27 headlessclayton@gmail.com CMake: Add DCHECK_ALWAYS_ON flag
2019-02-27 headlessclayton@gmail.com Fix warnings raised during release builds
2019-02-27 headlessclayton@gmail.com Suppress LLVM warnings raised during release builds.


Created with:
  gclient setdep -r third_party/externals/swiftshader@105fd0f651d1

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: Ia6b945fc2809393b52d14759fe38318d83247f7b
Reviewed-on: https://skia-review.googlesource.com/c/196005
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-27 20:42:51 +00:00
Mike Klein
e9fc58663e mark more methods inline
Since these are all already static, it doesn't have any real functional
impact in terms of linking or codegen.  But it does supress unused
function warnings in compilation units that don't use everything.

Add a new SI boilerplate macro to go along with SINT and SIT.

Change-Id: If2c09951b7453338dd20a3a88e3abbee5eefcd27
Reviewed-on: https://skia-review.googlesource.com/c/195921
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2019-02-27 20:27:10 +00:00
Mike Klein
41b995c4fb specialize if_then_else(int4,float4,float4)
Add SSE, SSE4.1, and NEON specializations.

The if_then_else() unit tests in SkVxTest.cpp should cover this.

I had to give up on my dream of not using Skia headers for now.  There's
really no good way of knowing whether we've got SSE4.1 support in MSVC
except when we explicitly define SK_CPU_SSE_LEVEL=SK_CPU_SSE_LEVEL_SSE41.

This refactor to use SK_CPU_SSE_LEVEL let MSVC point out a slight
ordering problem that would cause an infinite loop calling any of
the specializions like sqrt(float2).  I believe moving them after
the float4 specializations will fix that.

Change-Id: I83639f378a182716d1b37e92b6d725472698f874
Reviewed-on: https://skia-review.googlesource.com/c/195920
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-02-27 20:12:20 +00:00
Michael Ludwig
24adb3a356 Revert "Add general quad API to SkGpuDevice"
This reverts commit 339e1cc8d4.

Reason for revert: compositor GM breaks dm on windows

Original change's description:
> Add general quad API to SkGpuDevice
> 
> Heavily refactors SkGpuDevice's internal texturing code in an attempt
> to consolidate entry points for drawing an image. Helps lay the ground
> work for eventually implementing bitmap tiling with per-edge AA.
> 
> Bug: skia:
> Change-Id: I9feb86d5315d73119deb21e954c45e45513a63f6
> Reviewed-on: https://skia-review.googlesource.com/c/191571
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>

TBR=bsalomon@google.com,robertphillips@google.com,michaelludwig@google.com

Change-Id: I74bc7eb08855dff5535cf809fc47ce6f16d2c15d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/195889
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2019-02-27 19:42:31 +00:00
Michael Ludwig
339e1cc8d4 Add general quad API to SkGpuDevice
Heavily refactors SkGpuDevice's internal texturing code in an attempt
to consolidate entry points for drawing an image. Helps lay the ground
work for eventually implementing bitmap tiling with per-edge AA.

Bug: skia:
Change-Id: I9feb86d5315d73119deb21e954c45e45513a63f6
Reviewed-on: https://skia-review.googlesource.com/c/191571
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-02-27 19:07:20 +00:00
skia-autoroll
67d87128fd Roll third_party/externals/swiftshader 5edafb5ac109..928dfeed1796 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/5edafb5ac109..928dfeed1796


git log 5edafb5ac109..928dfeed1796 --date=short --no-merges --format='%ad %ae %s'
2019-02-27 chrisforbes@google.com Return newly-created value from SpirvRoutine::createIntermediate
2019-02-27 chrisforbes@google.com Implement indexed draws


Created with:
  gclient setdep -r third_party/externals/swiftshader@928dfeed1796

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I1dadb71ff798b7cc81faf7dfe59781bb0323fca5
Reviewed-on: https://skia-review.googlesource.com/c/195946
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-27 18:24:30 +00:00
Eric Boren
113cba82e7 [recipes] Plumb task ID through to DM results
Bug: skia:
Change-Id: If5b71aba04964b61a634ccda7115c9f37a777468
Reviewed-on: https://skia-review.googlesource.com/c/195367
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-02-27 18:24:00 +00:00
Brian Osman
34d1331323 Particles: Improvements to SkCurve
Added explicit Linear segment type, merge math evaluation helpers for
scalar and color curves. Add logic to visitFields that cuts down on the
serialized size of simple curves, and makes the GUI easier to work with.

Remove the curve plot from the GUI. It was incorrect (wrong points at
cubic handle locations), not terribly helpful, and difficult to
maintain.

Bug: skia:
Change-Id: I190cb5d118b1f4b910984e4df50ee3351c8be895
Reviewed-on: https://skia-review.googlesource.com/c/195884
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-02-27 16:46:29 +00:00
Mike Reed
95835340b2 Avoid forcing rasterpipeline due to device colorspace
Step 0 of "optimizing" for cases where we don't need to force rasterpipeline.

0: treat device colorspace of sRGB as "no colorspace" for single colors
1: convert the color to the device's colorspace (cache xformer on device?)
2: query the shader, to see if its colorspace is the same (needs a new virtual on shaderbase?)

Bug: skia:8793
Change-Id: Id49388fb4f9b8933003efb8db7a620c795c36d83
Reviewed-on: https://skia-review.googlesource.com/c/195370
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-02-27 16:36:19 +00:00
Kevin Lubick
dc822b1c9e update canvaskit docs to new API
Also add a dynamic text shaping demo

No-Try: true
Docs-Preview: https://skia.org/?cl=195440
Bug: skia:
Change-Id: I1e220cecae080a6a643fed8a1b9771ba8fe60915
Reviewed-on: https://skia-review.googlesource.com/c/195440
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2019-02-27 16:30:29 +00:00
skia-autoroll
0f5eac7fc6 Roll third_party/externals/swiftshader ead1a345a36c..5edafb5ac109 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/ead1a345a36c..5edafb5ac109


git log ead1a345a36c..5edafb5ac109 --date=short --no-merges --format='%ad %ae %s'
2019-02-27 sugoi@google.com Descriptor sets binding


Created with:
  gclient setdep -r third_party/externals/swiftshader@5edafb5ac109

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: If14da98c2defca6d91dd02728a7a626363e4ce1e
Reviewed-on: https://skia-review.googlesource.com/c/195851
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-27 16:25:59 +00:00
recipe-roller
cc61a2caa2 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/be28670fe2bf3a07f7f51ef86596739a43631ea8 [cipd] Rebuild all Go binaries with Go 1.12. (vadimsh@chromium.org)
  https://crrev.com/fe34723a55ec71b235512eac5ad561faf3151d6e Add gerrit.abandon_change command (sergiyb@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I26f76897fe27d83dcaaa94deaf354149686ff12c
Reviewed-on: https://skia-review.googlesource.com/c/195882
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2019-02-27 15:34:29 +00:00
Ben Wagner
ff84d8a900 SkTypeface::openStream to return smart pointer.
Change-Id: I2c936510e13561fcc9fd8343d5ab9f18c28c8340
Reviewed-on: https://skia-review.googlesource.com/c/195371
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-02-27 14:08:09 +00:00
skia-recreate-skps
ab3f8674c9 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I7e16c7d3cff1396766c182e62073bf2c0315f8cb
Reviewed-on: https://skia-review.googlesource.com/c/195721
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-02-27 05:38:19 +00:00
skia-autoroll
620621059b Roll third_party/externals/swiftshader 6c9fb0e6353c..ead1a345a36c (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/6c9fb0e6353c..ead1a345a36c


git log 6c9fb0e6353c..ead1a345a36c --date=short --no-merges --format='%ad %ae %s'
2019-02-27 sugoi@google.com Simple PipelineBarrier implementation


Created with:
  gclient setdep -r third_party/externals/swiftshader@ead1a345a36c

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I7235cc60ef8adc4e46b742bda4f08db9c33bf62f
Reviewed-on: https://skia-review.googlesource.com/c/195754
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-27 04:14:51 +00:00
skia-autoroll
f6faf2fcea Roll third_party/externals/angle2 9f20dd777b50..009696c56169 (2 commits)
9f20dd777b..009696c561


git log 9f20dd777b50..009696c56169 --date=short --no-merges --format='%ad %ae %s'
2019-02-26 geofflang@chromium.org Vulkan: Support EGL_ANDROID_image_native_buffer on Android.
2019-02-26 jmadill@chromium.org Use Chromium mirror for rapidjson.


Created with:
  gclient setdep -r third_party/externals/angle2@009696c56169

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=scroggo@google.com

Change-Id: Idc05db83f1d6a2f2a126e22b22471f264bcff7de
Reviewed-on: https://skia-review.googlesource.com/c/195744
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-27 02:55:20 +00:00
skia-autoroll
72fa10ef31 Roll third_party/externals/swiftshader 1bc7ee95f75b..6c9fb0e6353c (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/1bc7ee95f75b..6c9fb0e6353c


git log 1bc7ee95f75b..6c9fb0e6353c --date=short --no-merges --format='%ad %ae %s'
2019-02-27 loganchien@google.com Fix REACTOR_USE_SUBZERO flag


Created with:
  gclient setdep -r third_party/externals/swiftshader@6c9fb0e6353c

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I86ebc01c1d18648421e1fc1762dcea0dd817bd3e
Reviewed-on: https://skia-review.googlesource.com/c/195742
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-27 02:42:59 +00:00
skia-autoroll
2e9bb11db3 Roll third_party/externals/swiftshader 7f6f891204d0..1bc7ee95f75b (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/7f6f891204d0..1bc7ee95f75b


git log 7f6f891204d0..1bc7ee95f75b --date=short --no-merges --format='%ad %ae %s'
2019-02-26 headlessclayton@gmail.com Add Print helpers to reactor


Created with:
  gclient setdep -r third_party/externals/swiftshader@1bc7ee95f75b

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I2fdfe5c170d96d1ae873673814b6f2f46072c15b
Reviewed-on: https://skia-review.googlesource.com/c/195709
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-27 01:00:49 +00:00
skia-autoroll
7186504822 Roll third_party/externals/swiftshader 54c4772e855c..7f6f891204d0 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/54c4772e855c..7f6f891204d0


git log 54c4772e855c..7f6f891204d0 --date=short --no-merges --format='%ad %ae %s'
2019-02-26 sugoi@google.com VS build fix


Created with:
  gclient setdep -r third_party/externals/swiftshader@7f6f891204d0

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: Ia64cca7f89615112b0743d6c22a54bd17858e372
Reviewed-on: https://skia-review.googlesource.com/c/195703
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-27 00:08:34 +00:00
Chris Dalton
07cdcfc966 Reland "Stack-allocate pipelines for GrMeshDrawOp"
This is a reland of dfe5000a5f

Original change's description:
> Stack-allocate pipelines for GrMeshDrawOp
>
> Stack-allocates the pipelines in onExecute. This saves us from having
> to store the pipelines on the heap, as well as delaying the need to
> detach processors until onExecute. The delay is an improvement because
> it allows us to keep visiting proxies after onPrepare. (Previously,
> they were moved out of GrProcessorSet and into a pipeline during
> onPrepare, so visiting proxies was impossible after that point.)
>
> Bug: skia:8731
> Change-Id: Idc05063fb0dfbfed42b434e429fa5a497097bdae
> Reviewed-on: https://skia-review.googlesource.com/c/193368
> Commit-Queue: Chris Dalton <csmartdalton@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>

TBR=robertphillips@google.com

Bug: skia:8731
Change-Id: I32def1a35bb0593470fa672691a9e697dc6d9680
Reviewed-on: https://skia-review.googlesource.com/c/195261
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2019-02-26 23:32:54 +00:00
Mike Klein
a907dcbda7 remove mention of SkPaintDefaults_Flags
Change-Id: I0294bf2e294761bccf2e05dbd55addb003538cd1
Reviewed-on: https://skia-review.googlesource.com/c/193361
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-02-26 22:54:24 +00:00
skia-autoroll
a3d31cc5b3 Roll third_party/externals/swiftshader 8adf1fcd08d0..54c4772e855c (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/8adf1fcd08d0..54c4772e855c


git log 8adf1fcd08d0..54c4772e855c --date=short --no-merges --format='%ad %ae %s'
2019-02-26 chrisforbes@google.com Fix point rendering


Created with:
  gclient setdep -r third_party/externals/swiftshader@54c4772e855c

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I487f164684ef3fa6b0562ab30d2743644bfe9ae2
Reviewed-on: https://skia-review.googlesource.com/c/195642
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 22:29:06 +00:00
skia-autoroll
4dbb96dfaa Roll third_party/externals/swiftshader fe3d4978886b..8adf1fcd08d0 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/fe3d4978886b..8adf1fcd08d0


git log fe3d4978886b..8adf1fcd08d0 --date=short --no-merges --format='%ad %ae %s'
2019-02-26 chrisforbes@google.com OpAccessChain: Remove pointer walking inside loop
2019-02-26 sugoi@google.com Replace uses of sw::Surface with vk::ImageView in the Renderer


Created with:
  gclient setdep -r third_party/externals/swiftshader@8adf1fcd08d0

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I9304ecb15fcd8c97c90d879e89dc3bc1471c7ced
Reviewed-on: https://skia-review.googlesource.com/c/195500
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 21:33:23 +00:00
recipe-roller
c5519c3014 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/81bee2d517dae82881c1193fe9e4860fc7355f5b Implement api.buildbucket.build_url helper property (sergiyb@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9ba414e3b1dea20280fe3a1d8252abfeeaecc099
Reviewed-on: https://skia-review.googlesource.com/c/195369
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2019-02-26 20:38:45 +00:00
skia-autoroll
6099a28bc8 Roll third_party/externals/swiftshader 024f271ae0c7..fe3d4978886b (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/024f271ae0c7..fe3d4978886b


git log 024f271ae0c7..fe3d4978886b --date=short --no-merges --format='%ad %ae %s'
2019-02-26 chrisforbes@google.com Fix various issues in vertex fetch setup


Created with:
  gclient setdep -r third_party/externals/swiftshader@fe3d4978886b

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I05b74477a44612023a450836105876ff47b07e34
Reviewed-on: https://skia-review.googlesource.com/c/195460
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 20:34:37 +00:00
Brian Osman
e5d532edae Particles: remove non-stable random, add better enum reflection
The other generator was never used (or useful). String-based serialization
of enums is quite helpful, though.

Bug: skia:
Change-Id: Ic9d58f8d20cfe7aba47722bd74f1e6f8f0f219e5
Reviewed-on: https://skia-review.googlesource.com/c/195368
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-02-26 20:29:56 +00:00
Florin Malita
f12d675179 [skottie] Shape blending mode support
Starting in v. 5.4.4, BodyMovin also supports/exports per-shape
blending modes.

Change-Id: I9827f1db11df207da62bfb0de724e62489ed9255
Reviewed-on: https://skia-review.googlesource.com/c/195365
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-02-26 18:48:25 +00:00
Brian Salomon
65cb3749fe Remove legacy types/methods from SkDeferredDisplayList recorder.
Change-Id: I7a9810e14734262ee608444bd9308bebfb788a8d
Reviewed-on: https://skia-review.googlesource.com/c/195364
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
2019-02-26 18:40:55 +00:00
skia-autoroll
adfc6e40df Roll third_party/externals/angle2 0546b5380780..9f20dd777b50 (1 commits)
0546b53807..9f20dd777b


git log 0546b5380780..9f20dd777b50 --date=short --no-merges --format='%ad %ae %s'
2019-02-26 jmadill@chromium.org Add draw call perf test using 5 vertex arrays.


Created with:
  gclient setdep -r third_party/externals/angle2@9f20dd777b50

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=scroggo@google.com

Change-Id: I0f59dbf0cfd11f714f9e067a9728177d0e3226fb
Reviewed-on: https://skia-review.googlesource.com/c/195401
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 17:54:25 +00:00
Greg Daniel
cb32415753 Add support for VK_IMAGE_LAYOUT_PRESENT_SRC_KHR in skia vulkan.
This change allows Skia to handle transfering from the present layout.
Skia currently never changes to the present layout, though we are looking
at adding support for this in a different CL.

With this change a client can wrap a an VkImage into an SkSurface still in
the queue present layout and Skia will handle the transation to color
attachment. If a client uses this functiality they most likely will want
to immediately call wait(GrBackendSemaphore) on the SkSurface so that Skia
waits on the VkSemaphore that came from a call to vulkan aquire image before
doing any work on the wrapped VkImage.

Bug: skia:
Change-Id: Ia9bd12ad4e6cd972daaa972cce8698d396c002fc
Reviewed-on: https://skia-review.googlesource.com/c/194424
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-02-26 17:37:25 +00:00
skia-autoroll
317e5e2b5b Roll third_party/externals/swiftshader 2ff3639d85d7..024f271ae0c7 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/2ff3639d85d7..024f271ae0c7


git log 2ff3639d85d7..024f271ae0c7 --date=short --no-merges --format='%ad %ae %s'
2019-02-26 capn@google.com Fix fuzzer build


Created with:
  gclient setdep -r third_party/externals/swiftshader@024f271ae0c7

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I66528279958870b758897d6e4c5f6240831e0f76
Reviewed-on: https://skia-review.googlesource.com/c/195397
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 17:25:35 +00:00
Stan Iliev
cb58060404 Pass render target VkImage in GrVkDrawableInfo
Test: Ran CTS
Bug: b/115613038
Change-Id: I9493de41e0bfaa53436676c8eed2a4f178b6e51e
Reviewed-on: https://skia-review.googlesource.com/c/186400
Commit-Queue: Stan Iliev <stani@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2019-02-26 17:07:30 +00:00
Herb Derby
eafd81bf0b Make ARGB fallback use common strike lookup
This is a larger CL. It makes fallback ARGB glyphs use
the same strike lookup, and it introduces the two cases
for fallback -- source and device. Source assumes that the
strike data will be transformed while rendering. Device
assumes that the data in the strike is already in device
space.

Change-Id: I5857bc17c6aaec21d48de9ac9102adafff9688fe
Reviewed-on: https://skia-review.googlesource.com/c/192120
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-02-26 17:05:04 +00:00
Hal Canary
ed53505b43 gn/core.gni: add headers
motivation: add more headers to gen/skia.h

Change-Id: I23064ca37afa66123ad00059c1382b906b44cd9e
Reviewed-on: https://skia-review.googlesource.com/c/195362
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
2019-02-26 16:39:05 +00:00
skia-autoroll
f6b62b756a Roll third_party/externals/swiftshader 9a16248dedf3..2ff3639d85d7 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/9a16248dedf3..2ff3639d85d7


git log 9a16248dedf3..2ff3639d85d7 --date=short --no-merges --format='%ad %ae %s'
2019-02-26 capn@google.com Work around x86-64 calling convention bug


Created with:
  gclient setdep -r third_party/externals/swiftshader@2ff3639d85d7

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: Idf774e6470d09e2fd1026cabe3f4c03ebccd85db
Reviewed-on: https://skia-review.googlesource.com/c/195390
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 16:32:05 +00:00
Brian Osman
0c48681e58 Few more particle features and some generalization work
Add particle "frame" enum, to allow effects relative to local, world,
or velocity. Remove the "orient along velocity" and replace with a much
more general orientation affector (angle curve + frame). Add an angular
velocity affector to mirror the behavior of the linear velocity affector.

Bug: skia:
Change-Id: Ibbaaeb352c9547d00d81c7916d00148dd65ed2b9
Reviewed-on: https://skia-review.googlesource.com/c/195361
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-02-26 15:56:24 +00:00
jongdeok.kim
804f17e35b [Viewer] Set the current slide first before attaching the fBackendType to fWindow.
If call attach() first, Viewer::onBackendCreated() calls Window::show().
When WM_PAINT occurs, Viewer::drawSlide() is called, where a crash occurs using an uninitialized fCurrentSlide.

Bug: skia:https://bugs.chromium.org/p/skia/issues/detail?id=8792
Change-Id: I22ba6479052cb66e08d8bc2a94539473e899b604
Reviewed-on: https://skia-review.googlesource.com/c/195240
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-02-26 14:21:55 +00:00
Kevin Lubick
8abc842945 [pathkit] fix perf
Docs-Preview: https://skia.org/?cl=195360
Bug: skia:
Change-Id: I4109810832b69a71960f6e619e32288ae8fa5023
Reviewed-on: https://skia-review.googlesource.com/c/195360
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-02-26 13:17:22 +00:00
skia-autoroll
346e10e8ae Roll third_party/externals/swiftshader 377d493a0847..9a16248dedf3 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/377d493a0847..9a16248dedf3


git log 377d493a0847..9a16248dedf3 --date=short --no-merges --format='%ad %ae %s'
2019-02-26 headlessclayton@gmail.com SpirvShader: Decouple SPIR-V type attributes from object representation
2019-02-26 bclayton@google.com Strongly type object / type identifiers.


Created with:
  gclient setdep -r third_party/externals/swiftshader@9a16248dedf3

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I49b39ede8704317b8feb19f1459876841a21d9a3
Reviewed-on: https://skia-review.googlesource.com/c/195290
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 07:32:24 +00:00
skia-autoroll
202077e281 Roll third_party/externals/swiftshader 53c8957c337d..377d493a0847 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/53c8957c337d..377d493a0847


git log 53c8957c337d..377d493a0847 --date=short --no-merges --format='%ad %ae %s'
2019-02-26 chrisforbes@google.com Remove VertexProcessor::multisampling state bit


Created with:
  gclient setdep -r third_party/externals/swiftshader@377d493a0847

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I68bd67a1e8536d2ad201894c8fad7b14493f5434
Reviewed-on: https://skia-review.googlesource.com/c/195280
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 06:18:34 +00:00
skia-recreate-skps
fe23736201 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ia1678080061a0441e6d13bcf326c473c2c7b48e3
Reviewed-on: https://skia-review.googlesource.com/c/195260
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-02-26 05:47:24 +00:00
skia-autoroll
ac6d4c0c8e Roll third_party/externals/swiftshader 9b433073ba38..53c8957c337d (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/9b433073ba38..53c8957c337d


git log 9b433073ba38..53c8957c337d --date=short --no-merges --format='%ad %ae %s'
2019-02-26 hliatis@google.com Wrong macro being #undef'd in VkGetProcAddress


Created with:
  gclient setdep -r third_party/externals/swiftshader@53c8957c337d

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I5eba4af6575b71a3534209478977292022316d49
Reviewed-on: https://skia-review.googlesource.com/c/195231
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 04:57:54 +00:00
skia-autoroll
bcfbf6e94c Roll third_party/externals/angle2 c63d95525cde..0546b5380780 (4 commits)
c63d95525c..0546b53807


git log c63d95525cde..0546b5380780 --date=short --no-merges --format='%ad %ae %s'
2019-02-25 ynovikov@chromium.org Revert "Vulkan:Adding custom pool allocator"
2019-02-25 jmadill@chromium.org Add third_party/googletest to .gitignore.
2019-02-25 ynovikov@chromium.org Revert "Add system util to execute app and retrieve its output"
2019-02-25 tobine@google.com Vulkan:Adding custom pool allocator


Created with:
  gclient setdep -r third_party/externals/angle2@0546b5380780

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=scroggo@google.com

Change-Id: I22712d1a932ed11c2f995a6881519cc417fdba27
Reviewed-on: https://skia-review.googlesource.com/c/195203
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 00:50:23 +00:00
Ben Wagner
843909c91a Add full definition of SkStreamAsset.
When moving from pointer to smart pointer, the implementation of
the pointee must be available (so the destructor which isn't used
can be visible).

Change-Id: I5489365868d4a3ba48cb4e8cd10e38b262dec2da
Reviewed-on: https://skia-review.googlesource.com/c/195129
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-02-25 23:51:53 +00:00
Chris Dalton
b8af5ad73a sksl: Negate dFdy when the Y axis is flipped
Bug: skia:
Change-Id: Icbdaa6b1ebbe00168f57ebb888c2345d4f7a5e7d
Reviewed-on: https://skia-review.googlesource.com/c/195160
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2019-02-25 23:32:23 +00:00
Chris Dalton
35a3abe765 Revert "Stack-allocate pipelines for GrMeshDrawOp"
This reverts commit dfe5000a5f.

Reason for revert: HWAA pipeline flag not getting set for dashing.

Original change's description:
> Stack-allocate pipelines for GrMeshDrawOp
> 
> Stack-allocates the pipelines in onExecute. This saves us from having
> to store the pipelines on the heap, as well as delaying the need to
> detach processors until onExecute. The delay is an improvement because
> it allows us to keep visiting proxies after onPrepare. (Previously,
> they were moved out of GrProcessorSet and into a pipeline during
> onPrepare, so visiting proxies was impossible after that point.)
> 
> Bug: skia:8731
> Change-Id: Idc05063fb0dfbfed42b434e429fa5a497097bdae
> Reviewed-on: https://skia-review.googlesource.com/c/193368
> Commit-Queue: Chris Dalton <csmartdalton@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>

TBR=robertphillips@google.com,csmartdalton@google.com

Change-Id: If706f19423310846de70288f393ac12f17ffeee5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:8731
Reviewed-on: https://skia-review.googlesource.com/c/195161
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2019-02-25 23:11:47 +00:00
recipe-roller
16076702e3 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/2afcf22ad1841a0fd653a4fca72ab37eee4b4b02 Check for impossible date ranges (brucedawson@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I54a1e225f31fba73299a742d7ddc9d7557dcb3ee
Reviewed-on: https://skia-review.googlesource.com/c/195128
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2019-02-25 22:40:53 +00:00
Ben Wagner
4212a7d948 SkTypeface::onOpenStream to return unique_ptr.
This moves the smart pointer use up one more level in preparation for
changing SkTypeface::openStream to return unique_ptr as well.

Change-Id: Ib8173d59e03de38b06f6e1b4e6776f1961055ae7
Reviewed-on: https://skia-review.googlesource.com/c/195121
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-02-25 22:30:04 +00:00