bungeman
0584631f52
Avoid last param to CTFontCreateWithGraphicsFont.
...
The last parameter of CTFontCreateWithGraphicsFont (CTFontDescriptorRef
attributes) *must* be nullptr. If non-nullptr then with fonts with
variation axes, the copy will fail in CGFontVariationFromDictCallback
when it assumes kCGFontVariationAxisName is CFNumberRef which it quite
obviously is not.
TBR=reed@google.com
Blocking dev builds, just removes code.
BUG=chromium:535109
Review URL: https://codereview.chromium.org/1362053003
2015-09-23 12:51:28 -07:00
halcanary
04d7de42c1
Documentation: SkDocument::setMetadata()
...
Land after http://crrev.com/1359943003
NOTRY=true
DOCS_PREVIEW= https://skia.org/user/sample/pdf?cl=1360193002
Review URL: https://codereview.chromium.org/1360193002
2015-09-23 12:50:54 -07:00
halcanary
5cd406f0f6
GM for http://skbug.com/4374
...
BUG=skia:4374
Review URL: https://codereview.chromium.org/1367623002
2015-09-23 12:46:25 -07:00
halcanary
f12a1673f0
SkPDF: add basic metadata support
...
Motivation: I want too finalize this API before working on the more
complex problem of adding XMP metadata for PDF/A.
BUG=skia:3110
Review URL: https://codereview.chromium.org/1359943003
2015-09-23 12:45:49 -07:00
halcanary
ab26a9b427
android/apps: Add CanvasProof App;
...
Compare Ganesh and HWUI canvas rendering of SKPs on android.
Put SKP files in .../canvasproof/src/main/assets/skps
Run on a Marshmallow device.
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/1258123004
2015-09-23 12:40:34 -07:00
benjaminwagner
3420d2796b
Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373
...
BUG=skia:4373
Review URL: https://codereview.chromium.org/1365683003
2015-09-23 12:20:47 -07:00
benjaminwagner
60c73d5180
Revert of remove unused SkCachingPixelRef (patchset #1 id:1 of https://codereview.chromium.org/1364743002/ )
...
Reason for revert:
Build failure: https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android_FrameworkDefs/builds/1146
Original issue's description:
> remove unused SkCachingPixelRef
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/70d58b7da535e32bcac35739d11ab8367e99f224
TBR=halcanary@google.com ,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1359393004
2015-09-23 11:53:37 -07:00
benjaminwagner
a1a8a601ae
Blacklist GLInstancedArraysBench for GalaxyS4 due to skia:4371
...
BUG=skia:4371
Review URL: https://codereview.chromium.org/1363963002
2015-09-23 11:41:04 -07:00
reed
70d58b7da5
remove unused SkCachingPixelRef
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1364743002
2015-09-23 11:36:03 -07:00
hendrikw
6f0fdac9e7
skia: Add support for ANGLE on linux
...
This will allow the ANGLE guys to test the ANGLE gl backend
with nanobench and DM
Review URL: https://codereview.chromium.org/1343193005
2015-09-23 11:35:55 -07:00
joshualitt
10cae83e4b
Move determiniation of strokerect rects internal
...
BUG=skia:
Review URL: https://codereview.chromium.org/1345853005
2015-09-22 12:50:33 -07:00
msarett
7f69144aaa
Add nanobench tests for BitmapRegionDecoder
...
SkBitmapRegionDecoderInterface provides an interface
for multiple implementations of Android's
BitmapRegionDecoder.
We already have correctness tests in DM that will enable us
to compare the quality of our various BRD implementations.
We also need these performance tests to compare the speed
of our various implementations.
BUG=skia:4357
Review URL: https://codereview.chromium.org/1344993003
2015-09-22 11:56:16 -07:00
mtklein
cc334b36de
fix DM?
...
BUG=skia:
Review URL: https://codereview.chromium.org/1359833005
2015-09-22 11:43:53 -07:00
benjaminwagner
31459a4ace
This file was supposed to be in https://codereview.chromium.org/1347143006/
...
BUG=skia:4367
Review URL: https://codereview.chromium.org/1351073003
2015-09-22 11:38:51 -07:00
bsalomon
aca31fea8c
Stop supporting HW dither
...
Review URL: https://codereview.chromium.org/1359833004
2015-09-22 11:38:46 -07:00
mtklein
a16e8bcef1
move mutex construction out of the benchmarks.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1345853004
2015-09-22 10:38:48 -07:00
mdempsky
78041fab41
Small cleanups to SkSmallAllocator
...
- Add missing #include <new>.
- Simplify createT functions with C++11 variadic templates.
- Change destroyT helper function into a private static function.
Review URL: https://codereview.chromium.org/1359853002
2015-09-22 10:37:08 -07:00
joshualitt
11edad9098
Fix for degenerate stroke rect
...
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/511684fb52f20862f8552f5009390ff3987b08d8
Review URL: https://codereview.chromium.org/1359453002
2015-09-22 10:32:28 -07:00
mdempsky
07ed41fa40
Fix possible integer overflow in SkTSearch's midpoint calculation
...
Probably unlikely to matter in practice, but SkTQSort calculates its
midpoint correctly, so we might as well do it here too. For more
background, see Joshua Bloch's "Nearly All Binary Searches and
Mergesorts are Broken" post:
http://googleresearch.blogspot.ru/2006/06/extra-extra-read-all-about-it-nearly.html
This doesn't change any public API.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1362613002
2015-09-22 10:32:02 -07:00
egdaniel
e73f1f6dfa
Prefer dual source/framebuffer fetch paths for GPU LCD.
...
This will allow us to batch over color changes for LCD text.
BUG=skia:
Review URL: https://codereview.chromium.org/1354423002
2015-09-22 10:10:55 -07:00
bungeman
7cbeaae8bb
Avoid CTFontCreateCopyWithAttributes.
...
It appears that CTFontCreateCopyWithAttributes and
CTFontCreateCopyWithSymbolicTraits share similar issues with the default
font on OSX10.10. CTFontCreateWithFontDescriptor cannot be used as
it will not work with webfonts. Since this is all low-level use, create the
CTFonts from the underlying CGFonts directly.
BUG=chromium:524646
Committed: https://skia.googlesource.com/skia/+/d3296717b9d0930237be3502b82ab94d0b4d177f
Review URL: https://codereview.chromium.org/1344213004
2015-09-22 09:54:57 -07:00
benjaminwagner
59ea019fa0
Blacklist bleed_image on GalaxyS4.
...
BUG=skia:4367
Review URL: https://codereview.chromium.org/1347143006
2015-09-22 09:49:47 -07:00
joshualitt
a204ceda21
Revert of Fix for degenerate stroke rect (patchset #7 id:110001 of https://codereview.chromium.org/1359453002/ )
...
Reason for revert:
breaking bots
Original issue's description:
> Fix for degenerate stroke rect
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/511684fb52f20862f8552f5009390ff3987b08d8
TBR=robertphillips@google.com ,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1356223003
2015-09-22 09:48:03 -07:00
joshualitt
511684fb52
Fix for degenerate stroke rect
...
BUG=skia:
Review URL: https://codereview.chromium.org/1359453002
2015-09-22 09:27:05 -07:00
bsalomon
bf87730c7d
Move GrFragmentProcessor implementation to its own cpp file
...
TBR=joshualitt@google.com
Review URL: https://codereview.chromium.org/1350523004
2015-09-22 09:06:13 -07:00
Brian Salomon
3905c379e8
fix factory count
...
TBR=egdaniel@google.com
Review URL: https://codereview.chromium.org/1357773003 .
2015-09-22 10:08:47 -04:00
bsalomon
87ba62e67c
Replace GrExtractAlphaFragmentProcessor with DstIn compose processor
...
Review URL: https://codereview.chromium.org/1347943003
2015-09-22 06:42:00 -07:00
mdempsky
106b12427e
Remove SkNEW and SkDELETE macros
...
This CL removes the uses of SkNEW that have resprouted since commit
385fe4d
, and removes the macros entirely now that Android and Chromium
have been cleaned up to no longer depend on them.
A bunch of files implicitly depend on #include <new> from SkPostConfig.h
still though, so keep that for now. To be fixed in a followup CL.
[mtklein mucking around]
Only public API removed.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1360653004
2015-09-22 06:10:35 -07:00
halcanary
55fb4f3fda
SkTLList throw on sk_malloc fail
...
BUG=530758
Review URL: https://codereview.chromium.org/1345373006
2015-09-21 13:41:04 -07:00
halcanary
064488a411
whitespace change
...
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1349933004
2015-09-21 13:35:13 -07:00
mtklein
b758bbd84e
Revert of Combined approach. (patchset #2 id:20001 of https://codereview.chromium.org/1356133002/ )
...
Reason for revert:
whee
Original issue's description:
> Combined approach.
>
> This combines some ideas from these two CLs:
> - try stosd/w
> - update memset16/32 inlining heuristics
>
>
> BUG=skia:4316
>
> Blinking in and out for perf.skia.org.
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/46243a7c02a1d5116e55a27ff59218f9c320df97
TBR=reed@google.com ,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4316
Review URL: https://codereview.chromium.org/1353703006
2015-09-21 11:02:39 -07:00
mtklein
46243a7c02
Combined approach.
...
This combines some ideas from these two CLs:
- try stosd/w
- update memset16/32 inlining heuristics
BUG=skia:4316
Blinking in and out for perf.skia.org.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1356133002
2015-09-21 10:50:56 -07:00
halcanary
4ae26258ef
CMake: Compile in OSMesa on Linux, if found.
...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/1353383003
2015-09-21 09:42:23 -07:00
halcanary
0fc1dbe592
SK_API for include/gpu/gl/GrGLInterface.h
...
Review URL: https://codereview.chromium.org/1357823003
2015-09-21 08:22:19 -07:00
borenet
08d7747ffe
Buildbot specs for Linux ANGLE bot
...
BUG=skia:4362
Review URL: https://codereview.chromium.org/1361453002
2015-09-21 08:20:24 -07:00
hcm
3e48aabbf1
update roadmap link to latest
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1354413003
Review URL: https://codereview.chromium.org/1354413003
2015-09-21 07:32:55 -07:00
mtklein
b1cc9daa65
Revert of try simplest code: inline whenever vaguely sensible (patchset #1 id:1 of https://codereview.chromium.org/1351403005/ )
...
Reason for revert:
pingpong
Original issue's description:
> try simplest code: inline whenever vaguely sensible
>
> BUG=skia:4316
>
> Will land and revert.
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/527a0c8235b454f5d0475a9a3e34caa9520db3a2
TBR=reed@google.com ,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4316
Review URL: https://codereview.chromium.org/1355073002
2015-09-20 19:05:01 -07:00
mtklein
527a0c8235
try simplest code: inline whenever vaguely sensible
...
BUG=skia:4316
Will land and revert.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1351403005
2015-09-20 19:04:21 -07:00
mtklein
c566fddd37
Revert of try stosd/w (patchset #2 id:20001 of https://codereview.chromium.org/1355063002/ )
...
Reason for revert:
boink
Original issue's description:
> try stosd/w
>
> While we're trying things and reverting them, might as well try this too.
>
> BUG=skia:4316
>
> Blinking in and out for perf.skia.org.
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/3ca0f626a07e9b534d14a2d8213eedb93c5f7534
TBR=mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4316
Review URL: https://codereview.chromium.org/1356983004
2015-09-20 18:06:03 -07:00
mtklein
3ca0f626a0
try stosd/w
...
While we're trying things and reverting them, might as well try this too.
BUG=skia:4316
Blinking in and out for perf.skia.org.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1355063002
2015-09-20 18:05:23 -07:00
mtklein
b63d816683
Revert of update memset16/32 inlining heuristics (patchset #1 id:1 of https://codereview.chromium.org/1357193002/ )
...
Reason for revert:
Who wants to land forever?
Original issue's description:
> update memset16/32 inlining heuristics
>
> I spent some time looking at perf.skia.org and it looks like we can do better.
>
> It is weird, weird, weird that on x86, we see three completely different behaviors:
> - x86 Android: inlining better for small N, custom better for large N;
> - Windows: inlining better for large N, custom better for small N;
> - other x86: inlining generally better
>
> BUG=skia:4316,chromium:516426
>
> (Temporary, plan to revert.)
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/b68fa409fc00ce2f38e2a0fd6f9dc2379b372481
TBR=reed@google.com ,jcgregorio@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4316,chromium:516426
Review URL: https://codereview.chromium.org/1358793002
2015-09-20 15:02:54 -07:00
mtklein
b68fa409fc
update memset16/32 inlining heuristics
...
I spent some time looking at perf.skia.org and it looks like we can do better.
It is weird, weird, weird that on x86, we see three completely different behaviors:
- x86 Android: inlining better for small N, custom better for large N;
- Windows: inlining better for large N, custom better for small N;
- other x86: inlining generally better
BUG=skia:4316,chromium:516426
(Temporary, plan to revert.)
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1357193002
2015-09-20 15:02:15 -07:00
update-skps
0e7ca50756
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
Review URL: https://codereview.chromium.org/1360503002
2015-09-20 00:14:36 -07:00
bungeman
4de8c3a401
Revert of Avoid CTFontCreateCopyWithAttributes. (patchset #4 id:60001 of https://codereview.chromium.org/1344213004/ )
...
Reason for revert:
Causes issues with synthetic bold italic on all versions of OSX, with OSX10.10 resulting in many measurement related changes (this is expected though).
fast/text/atsui-multiple-renderers.html
fast/css/font-face-synthetic-bold-italic.html
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_9__retina_/6168/layout-test-results/results.html
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_10/4525/layout-test-results/results.html
Original issue's description:
> Avoid CTFontCreateCopyWithAttributes.
>
> It appears that CTFontCreateCopyWithAttributes and
> CTFontCreateCopyWithSymbolicTraits share similar issues with the default
> font on OSX10.10. CTFontCreateWithFontDescriptor cannot be used as
> it will not work with webfonts. Since this is all low-level use, create the
> CTFonts from the underlying CGFonts directly.
>
> BUG=chromium:524646
>
> Committed: https://skia.googlesource.com/skia/+/d3296717b9d0930237be3502b82ab94d0b4d177f
TBR=erikchen@chromium.org ,mtklein@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:524646
Review URL: https://codereview.chromium.org/1354323002
2015-09-18 23:03:24 -07:00
bungeman
d3296717b9
Avoid CTFontCreateCopyWithAttributes.
...
It appears that CTFontCreateCopyWithAttributes and
CTFontCreateCopyWithSymbolicTraits share similar issues with the default
font on OSX10.10. CTFontCreateWithFontDescriptor cannot be used as
it will not work with webfonts. Since this is all low-level use, create the
CTFonts from the underlying CGFonts directly.
BUG=chromium:524646
Review URL: https://codereview.chromium.org/1344213004
2015-09-18 20:13:06 -07:00
jcgregorio
2440fcd941
skia.og: Update the home page to have a showcase of Skia capabilities.
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1353473007
Review URL: https://codereview.chromium.org/1353473007
2015-09-18 14:05:41 -07:00
herb
0d39d37ddc
Delete the typefaces.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1353203002
2015-09-18 13:52:18 -07:00
joshualitt
aa37a96d55
Create append methods in batch namespaces
...
BUG=skia:
Review URL: https://codereview.chromium.org/1353553002
2015-09-18 13:03:25 -07:00
joshualitt
2120b6f2cc
Fix for combining with perspective local rects
...
TBR=robertphillips@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1347913004
2015-09-18 12:56:41 -07:00
herb
1052f51a7d
Font cache stress test.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1348883002
2015-09-18 12:09:43 -07:00