Commit Graph

45537 Commits

Author SHA1 Message Date
Brian Salomon
3517aa7b14 Fix stroked arcs for mirror matrices.
Bug: b/142280381
Change-Id: I9933543377e6916bd262c6f2e936ed9f0976d039
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259174
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-12-11 14:44:30 +00:00
Ben Wagner
2ae348247a Update iOS provisioning profile.
Change-Id: I05172b01fb4a6baeac9a0a762537abd3fc5ad417
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259163
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-12-11 12:54:42 +00:00
skia-autoroll
b2d24e11f1 Roll ../src ffcaa57570c0..cf2545c5111b (466 commits)
ffcaa57570..cf2545c511


Created with:
  gclient setdep -r ../src@cf2545c511

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Bug: None
Tbr: djsollen@google.com
Change-Id: I0304558370295a5fcb604cd902e0ae6799a60493
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259239
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-12-11 04:47:12 +00:00
skia-autoroll
75799967be Roll third_party/externals/angle2 f60da87424a4..d6053daa6203 (8 commits)
f60da87424..d6053daa62

git log f60da87424a4..d6053daa6203 --date=short --first-parent --format='%ad %ae %s'
2019-12-10 jdarpinian@chromium.org Remove tabs from source files.
2019-12-10 hckim.kim@samsung.com Vulkan: Implement Transform Feedback support via extension
2019-12-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src d519167d2ecb..6c479796f6e4 (3 commits)
2019-12-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src f34b9fb086b3..a749c31b749b (3 commits)
2019-12-10 ianelliott@google.com Vulkan: Update bugs for multisample texture failures
2019-12-10 syoussefi@chromium.org Vulkan: EXT_gpu_shader5 support: fma
2019-12-10 davidben@chromium.org Fix potential indexing into an empty vector in ANGLE tests
2019-12-10 b.schade@samsung.com Vulkan: Add options to select more device types

Created with:
  gclient setdep -r third_party/externals/angle2@d6053daa6203

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: djsollen@google.com
Change-Id: I97ed557a4b62d78e5242a26ae67656f17863b1be
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259238
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-12-11 04:37:45 +00:00
skia-autoroll
4f88b95233 Roll third_party/externals/swiftshader 31916f494c2e..50211670b4bf (28 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/31916f494c2e..50211670b4bf

git log 31916f494c2e..50211670b4bf --date=short --first-parent --format='%ad %ae %s'
2019-12-10 bclayton@google.com Kokoro: Split tests into Debug and RelWithDebInfo
2019-12-10 chrisforbes@google.com Accept ImageCubeArray SPIRV capability
2019-12-10 bclayton@google.com Vulkan/Debug: Add Thread and EventListener
2019-12-10 bclayton@google.com Vulkan/Debug: Add Location
2019-12-10 bclayton@google.com Vulkan/Debug: Add File
2019-12-10 bclayton@google.com Vulkan/Debug: Add WeakMap
2019-12-10 bclayton@google.com Vulkan/Debug: Add Value and Variable
2019-12-10 bclayton@google.com Vulkan/Debug: Add Type
2019-12-10 bclayton@google.com CMakeLists: Fix logic of BUILD_CPPDAP
2019-12-10 swiftshader.regress@gmail.com Regres: Update test lists @ d00dfe49
2019-12-10 chrisforbes@google.com Advertise VK_PRESENT_MODE_MAILBOX_KHR
2019-12-10 bclayton@google.com Regres: Reduce scope of regres CI emails
2019-12-10 amaiorano@google.com Fix REACTOR_DEFAULT_OPT_LEVEL not actually applying
2019-12-10 capn@google.com Remove Visual Studio Vulkan project files
2019-12-10 bclayton@google.com Vulkan/Debug: Add ID
2019-12-09 chrisforbes@google.com Remove Float->UInt conversion workaround
2019-12-09 capn@google.com Add Float to UInt unit test
2019-12-09 amaiorano@google.com Add REACTOR_DEFAULT_OPT_LEVEL macro
2019-12-09 amaiorano@google.com Subzero: fix alloca return address allocation
2019-12-09 amaiorano@google.com Subzero: proper fix for assert(Dest->hasReg())
2019-12-09 bclayton@google.com CMakeLists: Add CMake rules for Vulkan debugger
2019-12-09 bclayton@google.com Add github.com/google/cppdap as a third_party dependency
2019-12-09 bclayton@google.com Add github.com/nlohmann/json as a third_party dependency
2019-12-09 capn@google.com Enforce int and short to be 32- and 16-bit respectively
2019-12-09 sugoi@google.com Cubemap array support
2019-12-09 amaiorano@google.com Revert "Fix materialization of function arguments"
2019-12-09 bclayton@google.com Kokoro: Add ReactorUnitTests to windows presubmits
2019-12-09 capn@google.com Remove coverage asserts for tested code

Created with:
  gclient setdep -r third_party/externals/swiftshader@50211670b4bf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: djsollen@google.com
Change-Id: I84305c9108934595e95333c4513f954ae15a6173
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259240
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-12-11 04:34:02 +00:00
recipe-roller
5afc7b2af8 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/6865d13248b39c0f70e124e7cfe8fd7097f1652a Update git-drover to use branch CQ (agable@chromium.org)
  https://crrev.com/ee67b97daaad4373320b6f60b078d5b22d1a15b6 Roll python to actually correct packages. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I457d2a0fa04a2e84d11d99ae2c5ee8904806c7f2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259229
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-12-10 23:19:35 +00:00
Herb Derby
e3c7ff4cef Move SubRun from .h to .cpp
Change-Id: I168df05e7cd77987d6bc501ceebf1b8aaa255e73
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259170
Commit-Queue: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-12-10 23:15:56 +00:00
recipe-roller
9d1cb79e77 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/7f9e1a2dc0194ba6cb2a5c1bf4cfa730744b0d3e Roll git to 2.24.1. (iannucci@chromium.org)
  https://crrev.com/92b150fa644972ea7807dc07ca00b38c07dd1354 Roll python 2 and 3 to versions matching the fleet. (iannucci@chromium.org)
recipe_engine:
  https://crrev.com/8605aab007613ffcd29297c0462ed8f4c7f7369c [recipe_modules/platform] Update doc for arch property. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I286e3b735ae0b2c3fc35c6ad9d4aa092293b7eff
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259225
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-12-10 22:51:55 +00:00
Mike Klein
1bb7e2378d test for c++17 w/ c++14 stdlib
Apparently some of our stdlibs are not even quite c++11 compliant.

Bug: skia:9700
Change-Id: I842c2dd2eba55d576aa60b2b3a4734dbace00f6b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259074
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-12-10 22:22:30 +00:00
Leon Scroggins III
ae834f5781 SkWebpCodec: enable a loop count of 1
Commit 557fbb added animation support to SkWebpCodec, with the intent to
match Chromium. This was during the ~1.5 year period between
crbug.com/592735 and crbug.com/649264 when Chromium attempted to align
WebP with GIF, and play the animation once more than the stored number
(see crbug.com/592735). This was later reverted, because it means that a
WebP is unable to play an animation a single time (see
crbug.com/649264). This commit catches SkWebpCodec up with Chromium.

Add a legacy build flag (SK_LEGACY_WEBP_LOOP_COUNT) so we can stage the
change on Android.

Change-Id: If07e00d5e070847ceeb9ce27cd78a846974cdb4d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259161
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2019-12-10 21:41:10 +00:00
Herb Derby
aebc5f8bd7 Move luminance calculation to GrTextBlob::Make()
This allows a couple of routines to be removed, and simplifies
the calling chaing.

Change-Id: I88b9396be79e4e245bbea291f4e778d12416b836
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259196
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-12-10 20:45:10 +00:00
Greg Daniel
9715b6c450 Add GrSurfaceProxyView to the various draw atlas ops.
Bug: skia:9556
Change-Id: I9eb825ab241fd0d0d4e63408af270a89e872d1c9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258802
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2019-12-10 20:29:27 +00:00
Greg Daniel
ad994cd894 Store GrSurfaceProxyView on shadow ops.
Bug: skia:9556
Change-Id: I04a5a44a6483c3e4d70b84b1d7df7ea9db6d44d7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258814
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2019-12-10 20:16:58 +00:00
Herb Derby
cb71889318 Put SubRuns in an alloc on GrTextBlob
This improves performance when there are multiple runs.

Bug: chromium:1029972

Change-Id: If32ddb2baf974ee1af7833710bd10a60e39c0169
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258736
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2019-12-10 20:05:57 +00:00
Florin Malita
15ee970d79 [skottie] Add frame time histogram to SkottieSlide UI
Ignoring GPU flush for now...

Change-Id: Ie28718ee528ac3f708c0237472845b3cca47f97d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259160
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-12-10 19:57:58 +00:00
Julia Lavrova
c5313e6b2a Font features
Change-Id: I8ae44d715fd2fa195c209c8ecb514db3e9644c31
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259100
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Julia Lavrova <jlavrova@google.com>
2019-12-10 19:19:24 +00:00
Florin Malita
c4f6e024ca [skottie] Initial SkottieSlide UI
- reveal on hover over lower region
 - live progress bar

Planning to add more features.

Change-Id: I776d5b525070c8894ae2ca3a9d9d7c407399b9e7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259158
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-12-10 19:08:34 +00:00
Hal Canary
e9bcc4719e utils/mac/SkCreateCGImageRef: cleanup
* Use SkUniqueCFRef
  * static fns use snake_case.
  * use unique_ptr to signify ownership

Change-Id: I57c2100a64bcf5d343af43b5fe9de117cfdbcd4f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259098
Auto-Submit: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-12-10 18:38:16 +00:00
Brian Osman
3f9199a162 GrSkSLFP: "Kind" is always kPipelineStage
Change-Id: Ia32f0858bedae79ffa551ef6dde6e46d04436f5e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259096
Auto-Submit: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-12-10 17:29:53 +00:00
Robert Phillips
ab2b722fdd Switch SkImage::CompressionType to be an enum class
Following CLs use CompressionType much more widely so let's switch it first.

Bug: skia:9680
Change-Id: Ie8847f24936e90dd85e0ad79cbe5542d68c87b12
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258882
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-12-10 15:58:23 +00:00
Mike Klein
7da1a13cee delete unused gyp hack
Change-Id: I042caa65ae87e4ff2d1bf81917ccbbb647a20777
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259073
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-12-10 15:52:43 +00:00
Nathaniel Nifong
732c49739f Return image address in image info so it can be shown in dropdown.
Note that I don't dereference this pointer, I'm just showing it to the user as it is currently
the only common identifier between the command list and the resource tab.

A longer term fix would be to show the resourse tab's indices in the command list. this is tougher
because it involves replacing UrlDataManager without breaking skiaserve.

Change-Id: Iaa0d60831e96128f19b6358e82b2e89f80444927
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258800
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Nathaniel Nifong <nifong@google.com>
2019-12-10 14:40:43 +00:00
skia-autoroll
ab26643258 Roll ../src 4e96c2bed379..ffcaa57570c0 (398 commits)
4e96c2bed3..ffcaa57570


Created with:
  gclient setdep -r ../src@ffcaa57570

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Bug: None
Tbr: djsollen@google.com
Change-Id: I7a0a789074a25d9d8cb80230e9ba1a4fb8e5f0ca
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259059
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-12-10 04:44:53 +00:00
skia-autoroll
67016a7201 Roll third_party/externals/angle2 27c89d2b5c56..f60da87424a4 (8 commits)
27c89d2b5c..f60da87424

git log 27c89d2b5c56..f60da87424a4 --date=short --first-parent --format='%ad %ae %s'
2019-12-09 davidben@chromium.org Fix out-of-bounds access bug in ANGLE tests
2019-12-09 jonahr@google.com Add metal display type to angle_deqp_tests
2019-12-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-headers/src 2b89fd4e2734..0e57fc1cfa56 (1 commits)
2019-12-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader b9f03f47d5f5..31916f494c2e (7 commits)
2019-12-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 0de87ee9a5bf..d519167d2ecb (1 commits)
2019-12-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src a3ee4384fb57..f34b9fb086b3 (3 commits)
2019-12-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src e82a428605f6..983b5b4fccea (1 commits)
2019-12-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 0a0625a3dca6..5ceb7be9a3bf (1 commits)

Created with:
  gclient setdep -r third_party/externals/angle2@f60da87424a4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: djsollen@google.com
Change-Id: I6476e2b9ae8add84a5b8e982747396eefde93264
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259058
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-12-10 04:41:53 +00:00
recipe-roller
ee675f10b8 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/e9aeaee522332ff7075529cc4bf2c81f5ade3318 bot_update: only add input commit refs for gclient solution roots. (jbudorick@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0713780012f6b7037360ca070a11ed2e89175736
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259056
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-12-10 02:09:39 +00:00
recipe-roller
e56cc054db Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/19c96b27a29dbad65e5e01d28ff479e856d666bd [resultdb] Add chromium_derive function. (nodir@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6cc7b81024ab6c80f2c589815df254bd374f8e13
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258886
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-12-10 00:40:00 +00:00
recipe-roller
f56c3a7957 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/bf31df7a63e41d211bd027d77e421d41a34926be [cipd] Bump client version 2.3.1 => 2.3.2. (vadimsh@chromium.org)
  https://crrev.com/198b5629865d76b2778e9ec8f6c0d139b3c1c728 pylint: make pylint-quotes available (vapier@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifa8703403c8b25738d35f1201f167a639ef03448
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258976
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-12-10 00:09:13 +00:00
Julia Lavrova
f9c6ee5461 Fixing the fix for memory leak
Change-Id: I0be996b30d3d86fc57eb9423ee7df2feb08fbda4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258883
Commit-Queue: Julia Lavrova <jlavrova@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-12-09 23:29:33 +00:00
recipe-roller
838fd592af Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/ed71210a5f9b875cfaad2ef9d7484e2c573cb692 pylint: roll less spammy versions (vapier@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If6e22f6c18c91e8c26a1ced008c2fe806cbaf984
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258927
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-12-09 22:26:33 +00:00
Brian Salomon
095d2468a0 GrTextureDomain: Go back to doing vector impl when modes are the same
Doing it using scalars all the time caused a mysterious shader compilation
issue on Chromecast. In the past we've had similar problems for long shaders.

Change-Id: Ied667c1d4ae47fb4ae9eee62421a7ad52eecebba
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258880
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-12-09 22:02:43 +00:00
Julia Lavrova
90bfd1c1c3 Small changes
Change-Id: Ic9c41a2dd11b4df8ab24037df0109e36536ec6c3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257892
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Julia Lavrova <jlavrova@google.com>
2019-12-09 21:58:13 +00:00
Hal Canary
3f7c49c96d skparagraph: fix another leak
Change-Id: I2394dfb10994ce055d87f881ea3bd3c88ab634d6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258881
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-12-09 21:39:13 +00:00
Herb Derby
659e4092e3 Pass SkGlyphRunList to GrTextBlob::Make
Change-Id: I05703d1428be088b99b9016802b6e4cb9e6ca53d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258320
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Auto-Submit: Herb Derby <herb@google.com>
2019-12-09 20:40:37 +00:00
Herb Derby
15a1e98868 Cleanup GrTextBlob management code
* cacheBlob -> cachedBlob
* listPaint -> blobPaint
* variable contextPriv
* variable colorInfo
* color -> initialVertexColor
* filterColor -> drawingColor

Change-Id: I36c6f885f8a4d041d9b0d84f787999d5648675ac
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258807
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-12-09 20:39:12 +00:00
Jim Van Verth
9b2c06f2b5 Add persistent shader cache support to Metal.
Will store either SkSL or MSL shaders for now, until we can
find a way to store shader binaries.

Bug: skia:8243
Change-Id: I4debf553467bbcb4af57aeee96d05bc0a2f2b075
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257687
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-12-09 20:35:33 +00:00
Hal Canary
189f30216b skparagraph: fix leak
Change-Id: Ieb13a5430ac78ba3d310331c72a96f0323e67d6e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258811
Auto-Submit: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-12-09 19:33:56 +00:00
Brian Osman
c937bc5025 Improvements to uniform handling in runtime SkSL
- Support array uniforms
- Fix cases where the read head wasn't aligned in onSetData
- Default to float as the CType for half. (half4 was using
  PMColor, and other half types required a layout(ctype...)

Change-Id: I63cb1706071668de0ab80f3d812cd9ad29ff9651
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258808
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-12-09 17:57:05 +00:00
Hal Canary
425929c2f6 [minor] fix definition with different parameter names
Change-Id: If38451b11fad4973e033190bf1a436bbc576d2ba
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258810
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-12-09 17:53:35 +00:00
Kevin Lubick
99e9532050 [canvaskit] roll to 0.10.0
Change-Id: Id06aad4db1a5c827d70ae28be38709167ab749b2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258815
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-12-09 17:51:23 +00:00
Herb Derby
7c7314ac29 Remove the CACHE_SANITY_CHECK system.
This was never test and turned on. I tried this a month ago
before the large changes, and it was failing then. I don't think
this tells us anything interesting, and fails if the blob is reused.

Change-Id: I8aadc2be7e6a17d255d681ed9fab04dcbc538991
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258809
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2019-12-09 17:47:55 +00:00
Brian Salomon
63be47c488 Add testCompile function to SkRuntimeColorFilterFactory for Chrome test
Change-Id: I31f5bf4257e8404f41b146b7e64169968d3cd291
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258804
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-12-09 16:59:34 +00:00
Florin Malita
870374825b [skottie] Explicit seek(0) in tools
With recent deferred image loading changes, Skottie relies on clients
to always/explicitly seek() before drawing a frame.

Some of the existing tools are still attempt to draw before the first
seek() fires (the animation callback is not guaranteed to occur before
the first draw).  For these, add an explicit seek(0) after loading the
animation, to ensure valid state.

TBR=
Change-Id: Ie453559af2d96560602b5e6508c25169dffb484d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258805
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-12-09 16:35:02 +00:00
Brian Salomon
7caa1371f3 Support mirror-repeat in GrTextureDomain
Bug: skia:9570
Change-Id: Iccfbb36b130ec2827164efda33470e2fa75ad833
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258638
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2019-12-09 16:15:33 +00:00
Mike Klein
67e55a2380 lift Wno-class-memaccess
Bug: skia:9674
Change-Id: I0ed1c171b0182d168798444657c200bfeec77514
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258269
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-12-09 16:12:23 +00:00
Mike Klein
9347bd8671 mark SkMD5->SkUUID copy as sane
GCC gets worried when we do things like memcpy() into non-trivial types
like SkUUID, but this one is pretty clearly fine.  (SkUUID is
non-trivial because of the implicit constructor that zeros it.)  We can
stifle the warning by casting the destination pointer to void*.

Change-Id: I6637964359f5d923fa97c4af2c608e61fdd1f457
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258448
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-12-09 15:38:32 +00:00
Kevin Lubick
62836903bc [canvaskit] Expose SkShader combiners
Change-Id: I84652fcec828fea55e2aa35567c054e9678ecf80
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258797
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-12-09 14:19:24 +00:00
Nigel Tao
3dc3121286 Add SK_WUFFS_FAVORS_PERFORMANCE_OVER_ADDITIONAL_MEMORY_SAFETY option
Bug: skia:8235
Change-Id: If38fd4b4bb87798cd933147187dc6fde7120a7ef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258696
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2019-12-09 14:14:42 +00:00
Nigel Tao
f0148c4881 Release SkWuffsCodec two-pass memory earlier
Running "dm --match Animated Codec gif GIF Gif | grep RAM"...

Before:
120MB RAM, 120MB peak, 0 queued, 0 active:

After:
117MB RAM, 117MB peak, 0 queued, 0 active:

In comparison, when configured with "skia_use_wuffs = false":
108MB RAM, 108MB peak, 0 queued, 0 active:

Bug: skia:8235
Change-Id: Ib7b8ac9e224f501dbe3a5d3d82d953e57fd0e8f1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258697
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
2019-12-09 13:58:42 +00:00
skia-autoroll
9910d829ad Roll third_party/externals/angle2 11e6944ec5a8..27c89d2b5c56 (9 commits)
11e6944ec5..27c89d2b5c

git log 11e6944ec5a8..27c89d2b5c56 --date=short --first-parent --format='%ad %ae %s'
2019-12-07 syoussefi@chromium.org Vulkan: fix BufferVk::map() synchronization
2019-12-07 xinyi.he@arm.com Vulkan: Resize the result vector in EGLChooseConfigTest end2end test
2019-12-06 ianelliott@google.com Vulkan: Latest Intel driver fixes 2-sample standard positions
2019-12-06 ianelliott@google.com Fix multisample renderbuffer compliance (e.g. 3->4 samples)
2019-12-06 jonahr@google.com Also use GL_RENDERER to determine vendorID
2019-12-06 jmadill@chromium.org Revert "Re-land "Add new test runner harness.""
2019-12-06 josh@joshmatthews.net Add /APPCONTAINER linker flag to shared libraries in UWP builds.
2019-12-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader bbd0694f9ab2..b9f03f47d5f5 (18 commits)
2019-12-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src e72b61c7c20d..a3ee4384fb57 (2 commits)

Created with:
  gclient setdep -r third_party/externals/angle2@27c89d2b5c56

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: djsollen@google.com
Change-Id: If610da681ff31240f95c737f4235c75e22496259
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258776
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-12-09 04:42:47 +00:00
skia-autoroll
04c9e9bfc8 Roll third_party/externals/swiftshader b9f03f47d5f5..31916f494c2e (7 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/b9f03f47d5f5..31916f494c2e

git log b9f03f47d5f5..31916f494c2e --date=short --first-parent --format='%ad %ae %s'
2019-12-07 digit@google.com [Subzero] Remove assert that breaks Shuffle operations.
2019-12-06 bclayton@google.com SpirvShader: Use struct for MemoryVisitor callback.
2019-12-06 bclayton@google.com Regres: Update dEQP to include fence timeout fix.
2019-12-06 bclayton@google.com Vulkan: Tidy VkCommandBuffer.cpp
2019-12-06 bclayton@google.com Reactor: Rename Blend() to Shuffle()
2019-12-06 swiftshader.regress@gmail.com Regres: Update test lists @ b9f03f47
2019-12-06 bclayton@google.com Reactor: Switch swizzles over to 16-bit hex codes

Created with:
  gclient setdep -r third_party/externals/swiftshader@31916f494c2e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: djsollen@google.com
Change-Id: I4935d6eb318cfcba021a1688eb764d9ef9be6fa9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258778
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-12-09 04:38:32 +00:00