Commit Graph

6629 Commits

Author SHA1 Message Date
robertphillips@google.com
35e1563380 Patch to fix NULL ptr dereference in 8171 on Linux
TBR=junov@google.com



git-svn-id: http://skia.googlecode.com/svn/trunk@8175 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-15 16:49:34 +00:00
bsalomon@google.com
604a56ad42 Run non-rendering benches in their own config.
Currently benches that set fIsRendering = false are run as part of the first config run. This is problematic for several reasons.

1) Which config they are run as depends on the --config options passed to bench. If I run bench --config GPU --config 8888 then they will be run in the GPU config and not the 8888 config.

2) Their presence makes bench take longer to run when testing rendering changes or comparing one rendering config to another (e.g. GPU v 8888). This is especially true on Android.

3) When comparing runs of a single config across multiple bench runs (typically  with code changes) it isn't obvious from the output which benchs to ignore because they say are listed under as being part of the config.

This CL adds NONRENDERING as a config (open to name suggestions). Non-rendering tests are run in and only in the NONRENDERING config.

Will this screw up our bench bots/scripts/graphs? If so I think we should change them since running non-rendering tests separately makes a lot more sense than the current madness.
Review URL: https://codereview.chromium.org/12475012

git-svn-id: http://skia.googlecode.com/svn/trunk@8174 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-15 15:42:15 +00:00
scroggo@google.com
5159153840 In gm, install drawFilter for pipe and tiledPipe.
Fixes bugs in drawing un-antialiased text in gm.

Review URL: https://codereview.chromium.org/12812016

git-svn-id: http://skia.googlecode.com/svn/trunk@8173 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-15 15:29:02 +00:00
commit-bot@chromium.org
4b32bd53c6 Fixing SkPicture command pattern optimizations to make them work correctly with bounding box hierarchies
BUG=https://code.google.com/p/chromium/issues/detail?id=180645
TEST=render_pictures -r <skp_dir> --validate --bbh <grid|rtree> --mode tile 256 256

Author: junov@chromium.org

Reviewed By: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/12817011

git-svn-id: http://skia.googlecode.com/svn/trunk@8171 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-15 15:06:03 +00:00
rmistry@google.com
8b5144f366 SKP files have been reverted to old version. Whitespace change to trigger rebuilds.
git-svn-id: http://skia.googlecode.com/svn/trunk@8170 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-15 13:37:39 +00:00
robertphillips@google.com
23f785d530 Update performance triggers for new skps (also remove all _multi_* triggers)
git-svn-id: http://skia.googlecode.com/svn/trunk@8169 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-15 12:43:53 +00:00
skia.committer@gmail.com
c49cabfe5c Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8168 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-15 07:05:19 +00:00
mike@reedtribe.org
2bbc0e1182 draft for fontmgr
git-svn-id: http://skia.googlecode.com/svn/trunk@8167 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-15 03:15:40 +00:00
rmistry@google.com
a650a537f2 All skp files in Google Storage have been updated (AddDashboardAnnotation)
git-svn-id: http://skia.googlecode.com/svn/trunk@8164 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-14 18:28:10 +00:00
commit-bot@chromium.org
0c63fcd0ba Add purge all caches to our ashmem wrapper.
THIS IS COMPLETELY UNTESTED


Author: djsollen@google.com

Reviewed By: scroggo@google.com

Review URL: https://chromiumcodereview.appspot.com/12450016

git-svn-id: http://skia.googlecode.com/svn/trunk@8163 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-14 17:56:58 +00:00
vandebo@chromium.org
8d8d9a5606 Work around stack overflow
Review URL: https://codereview.appspot.com/7561043

git-svn-id: http://skia.googlecode.com/svn/trunk@8162 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-14 17:24:16 +00:00
caryclark@google.com
996d78b7cf shape ops work in progress
cubic tests pass

git-svn-id: http://skia.googlecode.com/svn/trunk@8161 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-14 16:24:30 +00:00
reed@google.com
bda74d33f6 fix (bool) warning with SkToBool
git-svn-id: http://skia.googlecode.com/svn/trunk@8160 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-14 15:25:45 +00:00
reed@google.com
0e8eee7b8a add (dummy) SkFontHost::GetFileName (to fix build, will soon be deprecated)
git-svn-id: http://skia.googlecode.com/svn/trunk@8159 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-14 15:19:23 +00:00
commit-bot@chromium.org
bff83f61fa fix window's build errors
Author: djsollen@google.com

Reviewed By: bsalomon@google.com,borenet@google.com,reed@google.com

Review URL: https://chromiumcodereview.appspot.com/12668007

git-svn-id: http://skia.googlecode.com/svn/trunk@8158 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-14 15:18:08 +00:00
reed@google.com
2d927e9532 make OpenStream and GetFileName public ... for now, until we fix FreeType backend.
git-svn-id: http://skia.googlecode.com/svn/trunk@8157 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-14 15:09:40 +00:00
reed@google.com
fed86bdb8b move most of SkFontHost to private (preceeding making it all private)
In this change, have to accomodate PDF wanting to call openStream and advancedMetrics
Review URL: https://codereview.chromium.org/12739006

git-svn-id: http://skia.googlecode.com/svn/trunk@8156 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-14 15:04:57 +00:00
commit-bot@chromium.org
a936e37cc7 Upstream Android modifications to the image encoders/decoders.
This CL does not update the libjpeg as that change is large enough
to warrant its own CL.


Author: djsollen@google.com

Reviewed By: reed@google.com,robertphillips@google.com,scroggo@google.com

Review URL: https://chromiumcodereview.appspot.com/12604006

git-svn-id: http://skia.googlecode.com/svn/trunk@8155 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-14 14:42:18 +00:00
djsollen@google.com
5439ea2e19 Add libwebp to svn:externals
git-svn-id: http://skia.googlecode.com/svn/trunk@8154 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-14 14:41:55 +00:00
commit-bot@chromium.org
c8e011c208 Update Android Release build to use -O3.
Author: djsollen@google.com

Reviewed By: borenet@google.com

Review URL: https://chromiumcodereview.appspot.com/12784006

git-svn-id: http://skia.googlecode.com/svn/trunk@8153 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-14 13:58:40 +00:00
robertphillips@google.com
d66fe098f0 Adjust Win7 performance trigger for outliers
git-svn-id: http://skia.googlecode.com/svn/trunk@8149 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-14 12:41:30 +00:00
borenet@google.com
9c8bf5e60a Whitespace change to trigger builds after master restart
git-svn-id: http://skia.googlecode.com/svn/trunk@8148 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-14 12:04:10 +00:00
skia.committer@gmail.com
03682beb8c Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8143 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-14 07:02:51 +00:00
robertphillips@google.com
152336f4ea Fix uninitialized memory access
https://codereview.appspot.com/7657044/



git-svn-id: http://skia.googlecode.com/svn/trunk@8142 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 21:47:56 +00:00
reed@google.com
2863f082f2 have reset() return its argument as a convenience
git-svn-id: http://skia.googlecode.com/svn/trunk@8141 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 21:28:44 +00:00
jvanverth@google.com
c3413d6f41 Increase bits for effect attribute key.
We can have an attribute index value up to 7, but only allow 2 bits for each
index in GrGLEffect::GenAttribKey. This change gives them 3 bits (and fixes an
assert when running tests in debug).

Review URL: https://codereview.chromium.org/12431018/


git-svn-id: http://skia.googlecode.com/svn/trunk@8140 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 21:05:14 +00:00
caryclark@google.com
1ab0aac672 shape ops -- fix errors
git-svn-id: http://skia.googlecode.com/svn/trunk@8138 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 20:41:48 +00:00
caryclark@google.com
1304bb25aa shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@8137 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 20:29:41 +00:00
vandebo@chromium.org
dcf9c19d38 [PDF] Always set the symbolic Flag for Fonts.
This should fix Chrome bug 124572

Review URL: https://codereview.appspot.com/7631045

git-svn-id: http://skia.googlecode.com/svn/trunk@8136 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 20:01:51 +00:00
junov@chromium.org
d34fda187c Build fix: accessing uninitialized class member (not)
TBR=sugoi

git-svn-id: http://skia.googlecode.com/svn/trunk@8135 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 19:03:26 +00:00
bensong@google.com
a9a1967bcb Cut data point upload batch size to 25.
Some bots have lower speed sending http data out, and this will make it less likely to timeout.
Did not try 50 because once we switch to using Chrome dashboard app, extra work needs to be done for each data point which will take longer. Since appengine has the fixed 30s timeout policy, there's not too much we can do unless we convince Chrome to switch to other solutions.
Current Skia data on our app instance: https://skiadash.appspot.com/report
Review URL: https://codereview.chromium.org/12703008

git-svn-id: http://skia.googlecode.com/svn/trunk@8133 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 18:31:03 +00:00
junov@chromium.org
e286e84a6a Modifying the behavior of render_pictures --validate to test the effect of bbh.
The new behavior consists in using the same renderer, with bbh disabled, as a reference
renderer when the current renderer has a bbh.
Review URL: https://codereview.chromium.org/12801002

git-svn-id: http://skia.googlecode.com/svn/trunk@8132 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 17:27:16 +00:00
bsalomon@google.com
306b2ce0e2 Use stream usage for dynamic vertex data.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/12799005

git-svn-id: http://skia.googlecode.com/svn/trunk@8129 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 15:31:11 +00:00
robertphillips@google.com
bb51fabc99 Update bench_expectations & add triggers for N7, Mac 10.8 and Ubuntu
git-svn-id: http://skia.googlecode.com/svn/trunk@8128 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 15:25:30 +00:00
reed@google.com
0b8a2fe2cd comment out debugging printfs
git-svn-id: http://skia.googlecode.com/svn/trunk@8127 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 14:58:41 +00:00
epoger@google.com
5efdd0cb9c gm: write all messages to stdout/stderr with "GM:" preamble to distinguish from various debug messages coming from elsewhere
Review URL: https://codereview.chromium.org/12691009

git-svn-id: http://skia.googlecode.com/svn/trunk@8126 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 14:18:40 +00:00
bsalomon@google.com
530efc8085 Remove extraneous paren.
Review URL: https://codereview.chromium.org/12750004

git-svn-id: http://skia.googlecode.com/svn/trunk@8125 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 13:38:30 +00:00
commit-bot@chromium.org
059a4c70d7 refactor android defines to implicitly assume NDK compliance unless it is explicitly marked as being specific to the android framework.
Author: djsollen@google.com

Reviewed By: reed@google.com,borenet@google.com

Review URL: https://chromiumcodereview.appspot.com/12739007

git-svn-id: http://skia.googlecode.com/svn/trunk@8124 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 12:48:26 +00:00
commit-bot@chromium.org
50485744e1 Whitespace change to test commit-queue
Author: rmistry@google.com

Reviewed By: borenet@google.com,epoger@google.com

Review URL: https://chromiumcodereview.appspot.com/12826004

git-svn-id: http://skia.googlecode.com/svn/trunk@8123 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 11:49:15 +00:00
skia.committer@gmail.com
91274b9972 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8120 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 07:01:04 +00:00
junov@chromium.org
c19c19111c Fixing crash in render_pictures when failing to create referenceBitmap for --validate
Review URL: https://codereview.chromium.org/12800002

git-svn-id: http://skia.googlecode.com/svn/trunk@8119 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 19:56:49 +00:00
edisonn@google.com
8c020612ba Update flag to reflect actual meaning.
Review URL: https://codereview.chromium.org/12754004

git-svn-id: http://skia.googlecode.com/svn/trunk@8118 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 19:53:16 +00:00
robertphillips@google.com
632b9ccebf Disable all multi_*_threads triggers (see issue 1160)
git-svn-id: http://skia.googlecode.com/svn/trunk@8117 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 19:20:22 +00:00
robertphillips@google.com
c04987ff73 Fixed unitialized memory access bug in r8106
git-svn-id: http://skia.googlecode.com/svn/trunk@8115 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 17:53:53 +00:00
bungeman@google.com
f44957e769 Fix GDI device context leak.
https://codereview.appspot.com/7682044/



git-svn-id: http://skia.googlecode.com/svn/trunk@8113 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 17:27:10 +00:00
borenet@google.com
5dc06785ff Make graph output optional in bench_graphs_svg
Enables https://codereview.chromium.org/12785002/
Review URL: https://codereview.chromium.org/12543019

git-svn-id: http://skia.googlecode.com/svn/trunk@8112 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 17:16:07 +00:00
robertphillips@google.com
5ba0d9064d Fixed compiler error/warning
git-svn-id: http://skia.googlecode.com/svn/trunk@8110 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 16:05:14 +00:00
jvanverth@google.com
948787737b Add GL program cache tracking.
This may help us track down cases when we change how program keys are generated
and we get invalid misses.


git-svn-id: http://skia.googlecode.com/svn/trunk@8109 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 16:00:54 +00:00
reed@google.com
7ed1534416 fix warning: use size_t when comparing to SK_ARRAY_COUNT
git-svn-id: http://skia.googlecode.com/svn/trunk@8108 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 15:55:47 +00:00
reed@google.com
1a64a54b27 add (temp) SkFontLCDConfig class to hold LCD getters/setters. This will allow
us to make SkFontHost.h private (once webkit switches to the SkFontLCDConfig api)

Stage 2 is to either move this code into chrome/webkit, or change the callers to
perform their own globals management.
Review URL: https://codereview.chromium.org/12623011

git-svn-id: http://skia.googlecode.com/svn/trunk@8107 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 15:41:18 +00:00