Mike Klein
7a353e9454
moar ws
...
BUG=skia:
Review URL: https://codereview.chromium.org/518233004
2014-08-29 18:52:18 -04:00
Mike Klein
15093a9a99
another ws
...
BUG=skia:
Review URL: https://codereview.chromium.org/519583008
2014-08-29 18:15:59 -04:00
fmalita
5577387f25
Debugger render support for SkDrawTextBlobCommand.
...
R=robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/523833003
2014-08-29 15:08:20 -07:00
bsalomon
6267f81f3d
Move MakeDivByTextureWHMatrix to GrCoordTransform
...
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/522873005
2014-08-29 15:05:53 -07:00
Mike Klein
413191419d
ws2
...
BUG=skia:
Review URL: https://codereview.chromium.org/524853004
2014-08-29 17:53:34 -04:00
Mike Klein
ae4f09bfaf
ws
...
BUG=skia:
Review URL: https://codereview.chromium.org/523133002
2014-08-29 17:20:44 -04:00
Derek Sollenberger
566a22c543
Add baselines for all GMs that are currently labeled "no comparison".
...
R=mtklein@google.com
Review URL: https://codereview.chromium.org/519063004
2014-08-29 15:46:28 -04:00
Greg Humphreys
f2b5f2c2e9
rebaseline and re-enable all perspective tests
...
BUG=skia:
Review URL: https://codereview.chromium.org/518253002
2014-08-29 15:39:03 -04:00
Greg Humphreys
a8cf3bee44
fix names of suppresssed tests on win7
...
BUG=skia:
Review URL: https://codereview.chromium.org/524643003
2014-08-29 15:35:49 -04:00
Greg Humphreys
7ad2f08ba1
partial rebaseline for image scaling
...
BUG=skia:
Review URL: https://codereview.chromium.org/520863002
2014-08-29 15:29:38 -04:00
cdalton
fa3a41ff66
Don't assert on empty GrGLPaths
...
Ensure asserts aren't fired when creating a GrGLPath path from an
empty SkPath. An empty path is valid and has practical use, for
example, as a template path for certain nvpr calls.
BUG=skia:2891
R=bsalomon@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/522883002
2014-08-29 12:18:37 -07:00
egdaniel
9bd5bbf910
Fix to use high precision on cubics not conics.
...
NOTRY=True
TBR=bsalomon@google.com
BUG=skia:2860
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/521623003
2014-08-29 11:12:30 -07:00
bungeman
2210d9e4b2
Update FontConfig valgrind suppressions.
...
FcPattern uses 'intptr_t elts_offsets' instead of 'FcPatternEltPtr elts'
to reference its elements. Therefore, valgrind suspects possible leaks
on all values, elements, and element lists in FontConfig.
BUG=skia:2879
R=djsollen@google.com , mtklein@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/518903002
2014-08-29 10:38:48 -07:00
reed
14b6aba099
harden requirements on SkBitmapCache
...
BUG=skia:
R=humper@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/521433002
2014-08-29 10:25:26 -07:00
egdaniel
b2f94d1f4a
Use highp for gpu bezier effects
...
BUG=skia:2860
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/519473003
2014-08-29 10:08:36 -07:00
fmalita
7ba7aa7e82
Quick-reject draw text blob calls.
...
R=mtklein@google.com , reed@google.com , robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/494763004
2014-08-29 09:46:36 -07:00
borenet
2269bce9be
Rebaseline N10 Recipes bot
...
BUG=skia:
R=djsollen@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/522803002
2014-08-29 09:43:06 -07:00
Derek Sollenberger
2953238dd2
Add Nexus 5 baselines to Android.
...
Review URL: https://codereview.chromium.org/519813002
2014-08-29 12:29:28 -04:00
Mike Klein
23181da8a8
Start N5 skimage expectations off with N4's expectations
...
BUG=skia:
Review URL: https://codereview.chromium.org/520753002
2014-08-29 12:24:50 -04:00
Derek Sollenberger
e92707916d
Massive rebase of Nexus 4 bots.
...
Review URL: https://codereview.chromium.org/517183003
2014-08-29 12:00:09 -04:00
george
2f26528e59
Use even rounding for better results when converting from scalar to fdot6
...
Originally from https://bugzilla.mozilla.org/show_bug.cgi?id=996108 , patch by Jeff Muizelaar
R=reed@google.com , reed1
BUG=skia:
Author: george@mozilla.com
Review URL: https://codereview.chromium.org/270263005
2014-08-29 08:47:55 -07:00
reed
b75b2c05b9
use possible corrected info when creating pixelref
...
TBR=halcanary, scroggo
Author: reed@google.com
Review URL: https://codereview.chromium.org/518103002
2014-08-29 08:23:56 -07:00
bsalomon
7187593b4b
Make SkGrPixelRef responsible for owning GrSurface's texture rather than RT.
...
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/522733003
2014-08-29 08:08:35 -07:00
robertphillips
a8d7f0b13c
Try out scalar picture sizes
...
This paves the way for removing the 'fTile' parameter from SkPictureShader (although that should be a different CL). If we like this we could also move to providing an entire cull SkRect.
R=reed@google.com , mtklein@google.com , fmalita@google.com , fmalita@chromium.org
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/513983002
2014-08-29 08:03:56 -07:00
borenet
77d724c078
Fix adb_pull_if_needed
...
BUG=skia:
R=djsollen@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/519743002
2014-08-29 07:56:14 -07:00
mtklein
970e106b88
Update LSAN suppressions.
...
Seems the obvious thing works now.
Ran nanobench,
-----------------------------------------------------
Suppressions used:
count bytes template
586 3530064 libGL.so
-----------------------------------------------------
and dm,
-----------------------------------------------------
Suppressions used:
count bytes template
340 2048160 libGL.so
-----------------------------------------------------
BUG=skia:
R=robertphillips@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/517133002
2014-08-29 07:55:35 -07:00
reed
64ba5fa1ff
Revert of Add gamma/sRGB tags to SkImageInfo (patchset #1 of https://codereview.chromium.org/517123002/ )
...
Reason for revert:
Seems to be triggering assert in blink
SSLUITest.TestRedirectHTTPToBadHTTPS (run #1 ):
[ RUN ] SSLUITest.TestRedirectHTTPToBadHTTPS
HTTP server started on http://127.0.0.1:58000 ...
sending server_data: {"host": "127.0.0.1", "port": 58000} (36 bytes)
HTTPS server started on https://127.0.0.1:58009 ...
sending server_data: {"host": "127.0.0.1", "port": 58009} (36 bytes)
ASSERTION FAILED: info.fAlphaType == m_imageInfo.fAlphaType
../../third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp(78) : virtual bool blink::DecodingImageGenerator::onGetPixels(const SkImageInfo &, void *, size_t, SkPMColor *, int *)
1 0x77eb0d3 blink::DecodingImageGenerator::onGetPixels(SkImageInfo const&, void*, unsigned long, unsigned int*, int*)
2 0x92edddc SkImageGenerator::getPixels(SkImageInfo const&, void*, unsigned long, unsigned int*, int*)
3 0x92adf78 SkDiscardablePixelRef::onNewLockPixels(SkPixelRef::LockRec*)
4 0x9369283 SkPixelRef::lockPixels(SkPixelRef::LockRec*)
5 0x9369433 SkPixelRef::lockPixels()
6 0x9213344 SkBitmap::lockPixels() const
7 0x921ca57 SkAutoLockPixels::SkAutoLockPixels(SkBitmap const&, bool)
8 0x921ad80 SkAutoLockPixels::SkAutoLockPixels(SkBitmap const&, bool)
9 0x92b7125 SkDraw::drawBitmap(SkBitmap const&, SkMatrix const&, SkPaint const&) const
10 0x921f4fb SkBitmapDevice::drawBitmap(SkDraw const&, SkBitmap const&, SkMatrix const&, SkPaint const&)
11 0x921f8c7 SkBitmapDevice::drawBitmapRect(SkDraw const&, SkBitmap const&, SkRect const*, SkRect const&, SkPaint const&, SkCanvas::DrawBitmapRectFlags)
12 0x9288e12 SkCanvas::internalDrawBitmapRect(SkBitmap const&, SkRect const*, SkRect const&, SkPaint const*, SkCanvas::DrawBitmapRectFlags)
13 0x9288ee9 SkCanvas::drawBitmapRectToRect(SkBitmap const&, SkRect const*, SkRect const&, SkPaint const*, SkCanvas::DrawBitmapRectFlags)
Original issue's description:
> Add gamma/sRGB tags to SkImageInfo
>
> requires this CL to land in chrome
> https://codereview.chromium.org/517803002/
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/228b285ba14a6e9b6d1cc95ea1583caab30168a1
R=fmalita@google.com , fmalita@chromium.org , reed@chromium.org
TBR=fmalita@chromium.org , fmalita@google.com , reed@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/519583004
2014-08-29 07:50:28 -07:00
bsalomon
32d0b3b546
Simplify SkGpuDevice construction
...
R=robertphillips@google.com , reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/506413004
2014-08-29 07:50:23 -07:00
humper
76273bb9ec
suppress one more filterbitmap GM
...
BUG=skia:
TBR=djsollen
Author: humper@google.com
Review URL: https://codereview.chromium.org/522703002
2014-08-29 07:45:23 -07:00
humper
7af7a48ed2
more suppressions to handle differences on Win7 bot
...
BUG=skia:
TBR=djsollen
Author: humper@google.com
Review URL: https://codereview.chromium.org/518833002
2014-08-29 07:45:01 -07:00
Derek Sollenberger
508b505960
Add empty expectations file for skimage on Nexus 5 (Debug).
...
Review URL: https://codereview.chromium.org/519763002
2014-08-29 10:31:49 -04:00
Derek Sollenberger
51a6a4fcf5
Add empty expectations file for skimage on Nexus 5.
...
Review URL: https://codereview.chromium.org/519753002
2014-08-29 10:27:35 -04:00
Mike Klein
6a25bd0172
Revert Jim's CL.
...
BUG=skia:
Review URL: https://codereview.chromium.org/517123005
2014-08-29 10:03:59 -04:00
reed
228b285ba1
Add gamma/sRGB tags to SkImageInfo
...
requires this CL to land in chrome
https://codereview.chromium.org/517803002/
BUG=skia:
R=fmalita@google.com , fmalita@chromium.org , reed@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/517123002
2014-08-29 04:08:43 -07:00
borenet
d684422f17
Update SKP version to 87
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/523533002
2014-08-28 21:17:53 -07:00
reed
088f4b8eb3
Revert of Revert of Revert of add gamma/sRGB to SkImageInfo (patchset #1 of https://codereview.chromium.org/511363002/ )
...
Reason for revert:
android builder in chrome reveals the caller using { } initialization for SkImageInfo, which this CL now makes illegal. Will have to fix the call site before I can re-land this
Original issue's description:
> Revert of Revert of add gamma/sRGB to SkImageInfo (patchset #1 of https://codereview.chromium.org/512243002/ )
>
> Reason for revert:
> this revert was premature -- the chrome canary I looked at is old, and newer ones were green. So trying again...
>
> Original issue's description:
> > Revert of add gamma/sRGB to SkImageInfo (patchset #4 of https://codereview.chromium.org/514753002/ )
> >
> > Reason for revert:
> > breaks linker on chrome -- may need SK_API, but not sure.
> >
> > Original issue's description:
> > > add gamma/sRGB to SkImageInfo
> > >
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/615c369777258231054840a88cdb74c68c382485
> >
> > TBR=bungeman@google.com ,bsalomon@google.com
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/dc53701216c0e9f98eacf6c0cda769ebbd200b59
>
> TBR=bungeman@google.com ,bsalomon@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/e759a2662273fdf52ebbb3822229945eda317e46
R=bungeman@google.com , bsalomon@google.com
TBR=bsalomon@google.com , bungeman@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/517113002
2014-08-28 14:46:19 -07:00
reed
0b4abb904e
Revert of add SK_API to SkImageInfo (patchset #1 of https://codereview.chromium.org/513333003/ )
...
Reason for revert:
need to revert the big ImageInfo CL but since this was landed on top of it, I need to revert this guy first.
Original issue's description:
> add SK_API to SkImageInfo
>
> BUG=skia:
> TBR=bungeman
> NOTRY=True
>
> Committed: https://skia.googlesource.com/skia/+/bedec8456ff0ea814ed1bba748a86678f458d063
TBR=
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/518543002
2014-08-28 14:44:23 -07:00
fmalita
aa1b912046
Expose drawTextBlob to devices.
...
Instead of unrolling blobs in SkCanvas, perform the equivalent ops in
SkBaseDevice.
This depends on https://codereview.chromium.org/511783005/ .
R=jvanverth@google.com , reed@google.com , robertphillips@google.com , bsalomon@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/517663003
2014-08-28 14:32:24 -07:00
humper
d73c169637
Second attempt to land the integral image scaling change.
...
Scale all images to the nearest rounded integer, and if there's still
any scaling factor left over, pass it on to the subsequent bilerp code.
Should avoid artifacts when tiling scaled images.
Original CL received an LGTM from reed; new version disabled tiling
in the downsamplebitmap GM; I verified that this fixes the issue
we were seeing there on non-neon androids.
BUG=skia:2888
R=reed@android.com
TBR=reed
Author: humper@google.com
Review URL: https://codereview.chromium.org/514383003
2014-08-28 14:27:42 -07:00
mtklein
0209e95cc2
Align all SkRecord::alloc() calls up to at least a pointer size.
...
This should make the LSAN bots able to see all our pointers.
BUG=skia:
R=reed@google.com , robertphillips@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/517073002
2014-08-28 14:10:05 -07:00
bsalomon
23b406cc04
Make SkGpuDevice constructors private.
...
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/517033002
2014-08-28 14:06:42 -07:00
bsalomon
b17c129108
Add dirty_after_edit to SkPath::moveTo. Add commented out test case that triggers assert.
...
BUG=skia:1460
R=reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/517023003
2014-08-28 14:04:55 -07:00
humper
4e4b935d52
disable autovec on 32 *and* 64 bit builds for horiz. convolve
...
Works around some garbage bottom rows for certain scaled images. Will land a separate GM that demonstrates.
BUG=skia:
R=mtklein@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/513833003
2014-08-28 14:01:31 -07:00
fmalita
228a6f275d
SkTextBlob GPipe serialization.
...
Instead of relying on unrolling blobs in SkCanvas, serialize when
passing through a GPipe.
This is a prerequisite for pushing the blob draw op to the device.
R=mtklein@google.com , reed@google.com , robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/511783005
2014-08-28 13:59:42 -07:00
reed
bedec8456f
add SK_API to SkImageInfo
...
BUG=skia:
TBR=bungeman
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/513333003
2014-08-28 13:37:52 -07:00
reed
011f39aeb2
rename ScaledImageCache to ResourceCache
...
BUG=skia:
R=bsalomon@google.com , mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/511283002
2014-08-28 13:35:23 -07:00
djsollen
7ba2828aa6
Fix memory leak in SkPDFType1Font
...
BUG=skia:2880
R=bungeman@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/514313003
2014-08-28 12:34:41 -07:00
jvanverth
d21a686324
Rebaseline N10 GPU hairmodes.
...
This bug appears to be gone.
BUG=skia:1655
TBR=bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/515303004
2014-08-28 12:18:41 -07:00
djsollen
748783d18c
Ensure that we don't reference decoders that we don't build
...
R=scroggo@google.com , robertphillips@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/517663002
2014-08-28 12:04:41 -07:00
reed
e759a26622
Revert of Revert of add gamma/sRGB to SkImageInfo (patchset #1 of https://codereview.chromium.org/512243002/ )
...
Reason for revert:
this revert was premature -- the chrome canary I looked at is old, and newer ones were green. So trying again...
Original issue's description:
> Revert of add gamma/sRGB to SkImageInfo (patchset #4 of https://codereview.chromium.org/514753002/ )
>
> Reason for revert:
> breaks linker on chrome -- may need SK_API, but not sure.
>
> Original issue's description:
> > add gamma/sRGB to SkImageInfo
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/615c369777258231054840a88cdb74c68c382485
>
> TBR=bungeman@google.com ,bsalomon@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/dc53701216c0e9f98eacf6c0cda769ebbd200b59
R=bungeman@google.com , bsalomon@google.com
TBR=bsalomon@google.com , bungeman@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/511363002
2014-08-28 11:57:34 -07:00