Commit Graph

38948 Commits

Author SHA1 Message Date
skia-autoroll
7ec5de6ed9 Roll third_party/externals/angle2 4622905b30d1..5a8d0bc2884b (1 commits)
4622905b30..5a8d0bc288


git log 4622905b30d1..5a8d0bc2884b --date=short --no-merges --format='%ad %ae %s'
2018-12-17 ianelliott@google.com Remove version-1 API of A4A opt-in/out (a.k.a. feature-support utilities)


Created with:
  gclient setdep -r third_party/externals/angle2@5a8d0bc2884b

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=halcanary@google.com

Change-Id: I202b3671e07ecd4b5eaf534e6636a56404054fb5
Reviewed-on: https://skia-review.googlesource.com/c/178304
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-12-17 20:58:38 +00:00
Brian Salomon
5790420ccc Add new DM via, "ddl2" which records/draws DDLs for each test twice.
Clears between the two DDL runs.

Also, fix up proxy unique key checks in GrSurfaceProxy.

Change-Id: I492e791ebc57a42063f3b828c10d8bf5fee70b1b
Reviewed-on: https://skia-review.googlesource.com/c/178262
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-12-17 20:22:15 +00:00
Jim Van Verth
1694a8604b Revert "Reland Reland "Remove use of integers for atlas indexing""
This reverts commit 0711094b91.

Reason for revert: Seeing artifacts on Pixel 3 and iOS.

Original change's description:
> Reland Reland "Remove use of integers for atlas indexing"
> 
> Bug: skia:
> Change-Id: Ie37b3fd6c8682b2d778b1dd0bc38976e6761524e
> Reviewed-on: https://skia-review.googlesource.com/c/172142
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Jim Van Verth <jvanverth@google.com>

TBR=jvanverth@google.com,bsalomon@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:
Change-Id: Iff9df856ff74eeb66bf5e37496a8361474e99491
Reviewed-on: https://skia-review.googlesource.com/c/178265
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2018-12-17 20:20:45 +00:00
Mike Klein
fe64e00997 bump NDK packages to r19-beta2
Originally this started as a bump to r18, the latest stable release.
That's why each packages goes up two versions, from r17 -> r18 ->
r19-beta2.

But our ASAN bots started failing with r18, and despite quite a bit of
investigating, I've been unable to find anything wrong with our code.

Luckily, r19 is coming soon, and it looks like its beta2 works fine.
I think we should just skip r18.

Original change's description:
> bump NDK packages to r18
>
> Newer Clang, GCC is gone.
>
> Clang now supports half-float math on ARMv8, which is pretty neat.
>
> They've dropped support for everything below NDK version 16,
> which happens to be what we target for 32-bit ARM.
>
> Change-Id: Idd1b1b557c5ecaabec4040026fd2ad5adfee5ee7
> Reviewed-on: https://skia-review.googlesource.com/157260
> Reviewed-by: Derek Sollenberger <djsollen@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

Cq-Include-Trybots: skia.primary:Test-Android-Clang-Pixel-CPU-Snapdragon821-arm64-Release-All-Android_ASAN
Change-Id: I0736558fc9b732113854b1b295642e1708b04581
Reviewed-on: https://skia-review.googlesource.com/c/157761
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-12-17 20:07:36 +00:00
Ben Wagner
73e2ced5f8 [infra] Do not retry xSAN and Valgrind failures
As a side-effect, explicitly specify MaxAttempts for all "kitchen"
tasks.

Change-Id: Ia0ac825a4364952f0cda678d2cd6462a30a4912e
Reviewed-on: https://skia-review.googlesource.com/c/177883
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-12-17 19:48:56 +00:00
Hal Canary
7db6e28f64 gm: Fix eror in textToGlyphs/getXPos
Change-Id: I6f588f1268cf79eb251a6819d306e423c8b8f53a
Reviewed-on: https://skia-review.googlesource.com/c/178264
Commit-Queue: Hal Canary <halcanary@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2018-12-17 19:48:35 +00:00
Herb Derby
fc1cb226ae Use SkFont and SkScalerContextEffects for creating SkScalerContext instead of SkPaint
Track a font and effects instead of a paint to lazily create SkScalerContexts.

Change-Id: I819912dd707b69a406e5a079eb51c0a1706c6c44
Reviewed-on: https://skia-review.googlesource.com/c/178280
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-12-17 19:38:20 +00:00
recipe-roller
4b24feba11 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/a1e4d48a104af8e96b34eaa436138920f029469c setdep: Add support for variables when setting CIPD vars. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4ed8d4b7586de215c381734800fd0e4204ea5b01
Reviewed-on: https://skia-review.googlesource.com/c/178263
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-12-17 19:37:50 +00:00
Hal Canary
fc97f222ff FuzzCanvas: do textToglyphs right
Bug: skia:8635
Change-Id: I6ceec131ae9cc5796a5aba6d5cfdb16de4831a45
Reviewed-on: https://skia-review.googlesource.com/c/178261
Commit-Queue: Hal Canary <halcanary@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-12-17 19:21:10 +00:00
Herb Derby
b79ba57f20 SkFont pushed up one small step for setupCache
Make one small step up removing one use of LEGACY. Two more uses
to go in GPU.

Change-Id: I8b9ad2b2992b9eddaa49c6e03df80ae4d565d8f0
Reviewed-on: https://skia-review.googlesource.com/c/178081
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-12-17 18:52:21 +00:00
Kevin Lubick
96d9dd8d01 Prevent exponential growth of 'nice' paths when fuzzing
Bug: oss-fuzz:11491, oss-fuzz:11514 and others
Change-Id: I60f05b889a73749ddcde7cf2bf3beabab33b0538
Reviewed-on: https://skia-review.googlesource.com/c/178180
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
2018-12-17 18:27:47 +00:00
Hal Canary
cc4f7ebf28 Test-SKQP: stop checking for success
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86-devrel-Android_SKQP,Test-Debian9-Clang-NUC7i5BNK-CPU-Emulator-x86-devrel-All-Android_SKQP

Change-Id: Ie258270784472d036a0d4b925bd071a764b737f8
Reviewed-on: https://skia-review.googlesource.com/c/177899
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
2018-12-17 18:00:07 +00:00
Kevin Lubick
fa720714c4 [canvaskit] Add files needed for npm release
Backport changes to pathkit too.

Bug: skia:
Change-Id: Id10f9ac52dc7d08f044eee1eeacc8737f1cd96f4
Reviewed-on: https://skia-review.googlesource.com/c/177894
Reviewed-by: Heather Miller <hcm@google.com>
2018-12-17 17:21:34 +00:00
Cary Clark
f81cfc33b1 fix fuzz assert
Recent rewrite of SkPath::isConvexity() introduced a debugging
assert while fuzzing. The convexity computed by a proper cross product
may be zero while the short-cut cross product is zero or one.

This debugging code was added to make sure that the short cut was
correctly implemented and matched the regular code, but otherwise
isn't that important to maintain (now that it works). For now,
try fixing the assert to allow the full cross product to return zero
(e.g., if it underflows). If this shows up again, probably correct
just to delete or comment out the debugging code check.

R=kjlubick@google.com

Bug: skia:
Change-Id: If3f772432852f9e325789185cd283466af837a05
Reviewed-on: https://skia-review.googlesource.com/c/177896
Commit-Queue: Cary Clark <caryclark@skia.org>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-12-17 17:21:12 +00:00
Kevin Lubick
a96ec09599 [canvaskit] Performance tuning of GL calls
Don't check glerror on texture creation.

Initialize before texSubImage2D calls, especially for drawPath
(dramatic Firefox improvement).

Bug: skia:
Change-Id: Iec39fd84fffb886e5ecccf782fe75d419e4255d0
Reviewed-on: https://skia-review.googlesource.com/c/177893
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-12-17 16:28:30 +00:00
Hal Canary
b3907a8424 SkPDF: fix bitmap type3 glyphs.
Before, I added the resource dictionary to each glyphs's content stream.
In fact, the resource dictionary should be added to the entire font.
This change keeps track of the new resources and adds them all to the
font after looping through the glyphs.

The following gms produce differenet PDFs:
    coloremoji
    coloremoji_blendmodes
    dftext
    mixedtextblobs
    scaledemoji
    scaledemoji_rendering
    scaledemojipos
The resulting PDFs are a few bytes shorter per typeface.

The new PDFs render the same in pdfium.  The old PDFs rendered
incorrectly (missing glyphs) in Apple Preview.  The new PDFs render
correctly in Apple Preview.

Bug: skia:8629

Change-Id: Ibbd1d22f54cb26e5423e22ce3f6e8fce5479baae
Reviewed-on: https://skia-review.googlesource.com/c/177890
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-12-17 16:25:23 +00:00
Herb Derby
5f7b014f29 Only reposition the fallback vertices once.
We were shifting the verticies for the fallback subrun
twice when using paths to render. Once in regenerate,
and once using MapPoints.

BUG=chromium:913057

Change-Id: I4d2e977b0edbec22cbd57c45fe47c959d172908f
Reviewed-on: https://skia-review.googlesource.com/c/177920
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-12-17 16:21:39 +00:00
Mike Klein
5e276a6376 remove old docs
- c++11.md isn't really needed any more
  - flatten.md makes reference to code that doesn't exist
  - simd.md describes a whole system that doesn't exist
  - color.md explains a model that's fundamentally different
    to how color correction works in Skia now

Change-Id: Ib09678190d04a0dcf44eadf13c617d488307332b
Reviewed-on: https://skia-review.googlesource.com/c/178080
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-12-17 16:20:20 +00:00
Mike Klein
c53ce162f0 templatize NEON SkBitmapProcState_matrixProcs
Same deal as a last time, with the NEON code.

No GM diffs locally.

Change-Id: I917ee73bd8cfcf610b51b15c89eeee575f0e8dca
Reviewed-on: https://skia-review.googlesource.com/c/176061
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
2018-12-17 16:12:09 +00:00
Michael Ludwig
be315a2748 Decal fallback for SkImageShader
Bug: skia:
Change-Id: Ib39f74886c0edc655ded8ba1075e5205361ae650
Reviewed-on: https://skia-review.googlesource.com/c/176225
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-12-17 15:30:48 +00:00
Leon Scroggins III
1be2d421ce Update Robocop docs for skia-android-triage
Instead of looking at open Skia bugs, which may already be assigned or
have lower priority, the Robocop should be looking at open bugs assigned
to skia-android-triage. New bugs will typically (though not always) be
assigned to this new alias.

No-Try: true
Docs-Preview: https://skia.org/?cl=177889
Change-Id: Ifa006bfda5ad46f37e8e23ee80a7ee1caad8b915
Reviewed-on: https://skia-review.googlesource.com/c/177889
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-12-17 15:15:18 +00:00
recipe-roller
90295c73d0 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/03640c7fe5d588c14f10643db5dfaf2388280f96 Extend documentation for `git map-branches` (clemensh@chromium.org)
  https://crrev.com/7fa4fbc468290f2943d0cc593f192614f2733efa Update documentation of `git new-branch` (clemensh@chromium.org)
  https://crrev.com/b58d4bda63e1d8a4966fe2f68e5c466610247fcd Add a feature to specify branches to be re-based (sergiyb@chromium.org)
  https://crrev.com/f423e051f343631f92cd1f261168c5215f6dacf6 [led] Update led to latest version. (iannucci@chromium.org)
  https://crrev.com/cfc9712bc80a9807370a21a7274d8f24d6483cc7 Fix git cl format following removal of Rietveld. (bryct@amazon.com)
recipe_engine:
  https://crrev.com/17552e0276fe41580387b0d2a720298ed497010a Reland "Remove old run code" (martiniss@google.com)
  https://crrev.com/4e2a492ca556e8dc991b52f0a3b683619af809a4 [protobuf] Update to protobuf 3.6.0. (iannucci@chromium.org)
  https://crrev.com/0cbbe4a2a8b0a309f08b5a5459292885e8e1ce07 [manual_roll] Add new manual_roll command. (iannucci@chromium.org)
  https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100 [stream_logdog] Remove old unused annotations.proto support. (iannucci@chromium.org)
  https://crrev.com/a42e8c4de53e8dd05042bac03f24a86e87abe4a3 [depend_on] Remove "depend_on" functionality. (iannucci@chromium.org)
  https://crrev.com/a66cf68621e2c514b7684e5404cd700a700f1aba [swarming] Create minimal swarming module. (joshuaseaton@google.com)
  https://crrev.com/d3f6d71aea0086eb34ae3cbbe7fbfd729d16b29f Fix README generation from a66cf68621e2c514b7684e5404cd700a700f1aba (iannucci@chromium.org)
  https://crrev.com/0d040fde89eac5b4762eab44a97e9556de6cffb8 [path] Add additional info to the assert in mkdtemp/mkstemp. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If8624adfc3a008a361f8191a315535b94d3bb906
Reviewed-on: https://skia-review.googlesource.com/c/177888
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-12-17 13:12:45 +00:00
recipe-roller
32def82f12 Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/143872d11b6f4faa095be0f8c2615bd681eb485b Update git recipes to use buildbucket API. (jsca@google.com)
recipe_engine:
  https://crrev.com/5e53d73e9bcec42830e10b835bc328eb75c9423f [path] Use 'cleanup' dir in mkdtemp and mkstemp (sergeyberezin@google.com)


R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9e038e4eedad70f1d4133c98c591a09459823a84
Reviewed-on: https://skia-review.googlesource.com/c/177077
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-12-17 12:46:15 +00:00
skia-autoroll
0b5e01697c Roll third_party/externals/angle2 175d918a1fe6..4622905b30d1 (1 commits)
175d918a1f..4622905b30


git log 175d918a1fe6..4622905b30d1 --date=short --no-merges --format='%ad %ae %s'
2018-12-17 jiajia.qin@intel.com ES31: Add atomic memory functions for SSBO


Created with:
  gclient setdep -r third_party/externals/angle2@4622905b30d1

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=halcanary@google.com

Change-Id: I14ac0fe04ce796acc753c533aeef9d486a142499
Reviewed-on: https://skia-review.googlesource.com/c/178047
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-12-17 08:48:25 +00:00
skia-recreate-skps
18f71ab037 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I3825374002bc4b14e90df0c7776d59c9a7c246b6
Reviewed-on: https://skia-review.googlesource.com/c/178025
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-12-17 06:01:20 +00:00
Ravi Mistry
a067690acf Revert "[infra] Flutter bot should sync to origin/skia-master"
This reverts commit 8061053b73.

Reason for revert: skia-master branch no longer exists

Original change's description:
> [infra] Flutter bot should sync to origin/skia-master
> 
> Bug: skia:
> Change-Id: I223bef522ff8605674f4ecabcbd0624cfc92cb06
> Reviewed-on: https://skia-review.googlesource.com/c/173224
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>

TBR=borenet@google.com,rmistry@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:
Change-Id: I3a40a0c6f4a354650d354f2eb4f9d20defe70a0a
Reviewed-on: https://skia-review.googlesource.com/c/178023
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-12-16 22:09:11 +00:00
Mike Reed
560d5b3cf1 use font to measure
Bug: skia:
Change-Id: I571de8f4234bd74c32fe8fba4f8726792b655c45
Reviewed-on: https://skia-review.googlesource.com/c/177887
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-12-16 22:02:40 +00:00
Mike Reed
6cd43b4456 Update SkCanonicalizeFont to also update paint
Bug: skia:
Change-Id: I3bf0ecc133778645826f83f7bc54f9c4f88e5e05
Reviewed-on: https://skia-review.googlesource.com/c/177885
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-12-16 21:29:40 +00:00
Mike Reed
1d6ae2e8f5 add docs to dump()
Bug: skia:
Change-Id: Ifc99db184095070b767f7ea1dd823d8c5f019281
Reviewed-on: https://skia-review.googlesource.com/c/177886
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-12-16 21:27:41 +00:00
skia-autoroll
c0a6331b66 Roll third_party/externals/angle2 7139b434210c..175d918a1fe6 (2 commits)
7139b43421..175d918a1f


git log 7139b434210c..175d918a1fe6 --date=short --no-merges --format='%ad %ae %s'
2018-12-16 ynovikov@chromium.org Revert "Load correct libGLESv2 on Linux and Mac."
2018-12-16 jmadill@chromium.org Load correct libGLESv2 on Linux and Mac.


Created with:
  gclient setdep -r third_party/externals/angle2@175d918a1fe6

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=halcanary@google.com

Change-Id: I749fa022a7ed4a7a8bb0ca832191fd6292742902
Reviewed-on: https://skia-review.googlesource.com/c/177958
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-12-16 20:49:54 +00:00
Mike Reed
ce5831e004 add paint param to measureText
Bug: skia:
Change-Id: I09ccb770ec37296e5e37b852296cead6cd23e00e
Reviewed-on: https://skia-review.googlesource.com/c/177884
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-12-16 20:16:53 +00:00
skia-recreate-skps
e6f635476d Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Ied237476748416db5c24a0e81507b35901f3b7cc
Reviewed-on: https://skia-review.googlesource.com/c/178022
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-12-16 08:19:11 +00:00
skia-recreate-skps
cb8157e626 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I6b17baf024cfe8cbe608f0660bbda0bf5d7a70e9
Reviewed-on: https://skia-review.googlesource.com/c/178020
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-12-16 06:04:11 +00:00
Mike Reed
2e6db18c43 use font instead of paint
Bug: skia:
Change-Id: I82b0b37c8e7b295df62cefb4053dcfeba1521e27
Reviewed-on: https://skia-review.googlesource.com/c/177803
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-12-15 19:11:13 +00:00
skia-autoroll
282ec5dc6c Roll third_party/externals/angle2 f307584255da..7139b434210c (1 commits)
f307584255..7139b43421


git log f307584255da..7139b434210c --date=short --no-merges --format='%ad %ae %s'
2018-12-15 geofflang@chromium.org Print a warning on unexpected internal errors.


Created with:
  gclient setdep -r third_party/externals/angle2@7139b434210c

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=ethannicholas@google.com

Change-Id: I7378647abe7eddb9fe6ea4e3cad3f3dc7bb09d0d
Reviewed-on: https://skia-review.googlesource.com/c/177944
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-12-15 17:34:22 +00:00
skia-autoroll
d4962e7e07 Roll third_party/externals/angle2 a7af56be7a6c..f307584255da (2 commits)
a7af56be7a..f307584255


git log a7af56be7a6c..f307584255da --date=short --no-merges --format='%ad %ae %s'
2018-12-15 timvp@google.com Use intent-filter to enforce that only a single ANGLE APK is present
2018-12-14 ynovikov@chromium.org Fix angle_apk build


Created with:
  gclient setdep -r third_party/externals/angle2@f307584255da

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=ethannicholas@google.com

Change-Id: I449bb1716313577aa415c1ecddcb96931fcbd1a0
Reviewed-on: https://skia-review.googlesource.com/c/177942
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-12-15 08:38:15 +00:00
skia-recreate-skps
8b78d70b9a Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ic6568aee66cd573ceb2184f9b54540cecc0aa7ae
Reviewed-on: https://skia-review.googlesource.com/c/177980
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-12-15 05:49:11 +00:00
skia-autoroll
a1bded9a4f Roll third_party/externals/angle2 dfaccbc08abb..a7af56be7a6c (3 commits)
dfaccbc08a..a7af56be7a


git log dfaccbc08abb..a7af56be7a6c --date=short --no-merges --format='%ad %ae %s'
2018-12-14 geofflang@chromium.org Vulkan: Print the device id in the renderer string.
2018-12-14 geofflang@chromium.org GL: Clean up workaround detection.
2018-12-14 jmadill@chromium.org Fix compile error in angle_white_box_perftests.


Created with:
  gclient setdep -r third_party/externals/angle2@a7af56be7a6c

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=ethannicholas@google.com

Change-Id: I183d877d19a4a1a4e3e4f81da060986abd555554
Reviewed-on: https://skia-review.googlesource.com/c/177845
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-12-14 23:48:12 +00:00
Brian Salomon
5ceda554f5 Fix stroked round capped circular arc batched with filled circle.
A stroked arc with round caps was batched with a filled circle. The circle op
code would choose a GeometryProcessor configuration that expected round cap
centers as vertex attributes. However, the tessellation code for the filled
circle would not put in dummy round cap centers and then didn't advance the
pointer into which vertex data was being written by the expected vertex
stride.

Bug: b/119394958
Change-Id: I6fe95b32d750599e775ed96e656757fe3087795a
Reviewed-on: https://skia-review.googlesource.com/c/177881
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-12-14 22:11:06 +00:00
Ben Wagner
16d00eeef7 CG smoothing implies gamma blit.
There are three distinct attributes controlled by font smoothing,
subpixel converage, fake bolding, and gamma 2 blitting. In macOS 14 the
subpixel coverage was removed but the other two apparently remain. Prior
to this change the code had assumed that the gamma 2 blitting had also
been removed, but this appears not to be the case.

Bug: chromium:901611
Change-Id: Ie0623267fa20c86d953e8b6c1fb3ead7be51b930
Reviewed-on: https://skia-review.googlesource.com/c/177880
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-12-14 21:32:24 +00:00
Kevin Lubick
8e4a331c8a [canvaskit] Canvas API for loading fonts
There's the barest hint of a "font manager" here.
Basically, nothing smart to deal with bold or fallbacks.

Maybe one day, we'll expose
SkTypeface* matchStyleCSS3(const SkFontStyle& pattern);

and do smart things for fallbacks, but for now that's not
in the immediate future.

Docs-Preview: https://skia.org/?cl=177067
Bug: skia:
Change-Id: Iaeabcbf5ff4511a01b37c16c983e447c25b0e3e7
Reviewed-on: https://skia-review.googlesource.com/c/177067
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-12-14 21:32:21 +00:00
Kevin Lubick
2b79d1ce45 [canvaskit] Expose setVolatile (especially for animations)
Bug: skia:
Change-Id: Ifd8ef390d1b9a102baaa89804b9f6d11e8f39955
Reviewed-on: https://skia-review.googlesource.com/c/177882
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-12-14 21:24:46 +00:00
Ben Wagner
7cbb7a11ab Add another NVIDIA LSAN suppression.
Change-Id: Ied919cacc0fde26b75a12b469bc4850d6f8a2f40
Reviewed-on: https://skia-review.googlesource.com/c/177804
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-12-14 19:48:38 +00:00
Brian Salomon
f391d0f771 Reduce the number of backend->pixelconfig GrCaps virtuals.
Moves method to get GrBackendFormat from GrBackendTexture from GrCaps
to GrBackendTexture so that a GrContext is not required.

Uses kUnknown_GrPixelConfig as failure return from GrCaps functions
rather than an GrPixelConfig* out param and bool result.

Having the texture type be part of GrBackendFormat made removing the
GrCaps function that goes from GrBackendRenderTarget to GrPixelConfig
awkward so that was left alone for now.

Change-Id: If9be0f898c538be4a7b24022b6011f63441a0317
Reviewed-on: https://skia-review.googlesource.com/c/175991
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-12-14 17:12:36 +00:00
Kevin Lubick
ec1c620316 Avoid system fonts when fuzzing
This should make reproducing certain fuzzes easier between oss-fuzz
and a typical dev's desktop.

This was the most straight-forward way I could think of to
accomplish this.  An ideal solution would "compile" a set of
fonts that was not the test set and embed it, but I lack the
domain knowledge to craft such a set.

If this method works ok, we can explore making the font set
more robust and varied.

Bug: 818769
Change-Id: I03eb2bc316caf7aec3ffa88e59ff29d76c8557ec
Reviewed-on: https://skia-review.googlesource.com/c/177800
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-12-14 17:11:56 +00:00
Cary Clark
eb82b5a3ee protect against fuzz generated fLastMoveToIndex
If fLastMoveToIndex exceeds SkPath::countPoints(),
SkPath::internalGetConvexity() reads outside allocated
memory.

R=kjlubick@google.com

Bug: skia:11842
Change-Id: Iba20c1a977645d882f0b86c22134d1d055692a0c
Reviewed-on: https://skia-review.googlesource.com/c/177801
Commit-Queue: Cary Clark <caryclark@skia.org>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-12-14 15:40:39 +00:00
skia-autoroll
af67819ee1 Roll third_party/externals/angle2 828c59462fc1..dfaccbc08abb (1 commits)
828c59462f..dfaccbc08a


git log 828c59462fc1..dfaccbc08abb --date=short --no-merges --format='%ad %ae %s'
2018-12-14 jmadill@chromium.org Clean up Windows DEF file generation.


Created with:
  gclient setdep -r third_party/externals/angle2@dfaccbc08abb

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=ethannicholas@google.com

Change-Id: I2eaecf6621eb519112340a5768e7299468882c63
Reviewed-on: https://skia-review.googlesource.com/c/177760
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-12-14 14:37:46 +00:00
Jim Van Verth
f6206f91b3 Add new method for calculating text atlas sizes
Uses a fixed quantized table to compute the ARGB texture dimensions,
and compute the A8 dimensions from that. Plot sizes are computed
based on the respective atlas's dimensions.

Bug: skia:
Change-Id: I28c56557094efa49d1a011a1d6145ef3a79b7cac
Reviewed-on: https://skia-review.googlesource.com/c/177068
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-12-14 13:53:11 +00:00
skia-bookmaker
59c9f1595e Update markdown files
Automatic commit by the Housekeeper-Nightly-Bookmaker bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I93323b54068cf900fde307be8e2f9a2a73d3e387
Reviewed-on: https://skia-review.googlesource.com/c/177741
Reviewed-by: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
2018-12-14 06:32:44 +00:00
skia-recreate-skps
e45a83d7ab Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ia0f5808cc0ff0a1cdc817381b1f8d086e5e8cf35
Reviewed-on: https://skia-review.googlesource.com/c/177740
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-12-14 06:03:14 +00:00