Commit Graph

42839 Commits

Author SHA1 Message Date
Hal Canary
3a85ed12bf ModifierKey unifies sk_app::Window::ModifierKey & Sample::Click::ModifierKey
Change-Id: Idb5dfe57a7f6e3d6078ab1e68d542b084114cfbe
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225735
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-07-09 16:16:41 +00:00
Brian Osman
489cf8888c Reland "Make the SkSL interpreter opt-in"
This reverts commit b6b966aa43.

Change-Id: I58c34fc8520384157c5adb0056f3568b8ef1d844
Bug: skia:9230
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225939
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-09 15:45:24 +00:00
Jim Van Verth
778ba8a450 Re-enable Vulkan MSAA support in Viewer
Bug: skia:
Change-Id: I2e7fc5463ea73baa82e6f1a3340e9c88d1b8be32
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226081
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-07-09 15:35:44 +00:00
Brian Salomon
b450f3be4f Use vkCmdClearColorImage to clear backend textures
Also don't use GrPixelConfig to create the VkImage.


Bug: skia:7959
Bug: skia:6718

Change-Id: Ia13c5ed2fbe0542c060b725694eff9d566c491f0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226078
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-07-09 15:00:43 +00:00
Mike Reed
21ba586f32 create outer forloop to support loops=-1
Change-Id: I1f76a798f3f95afb82ab739ab5343bf52b233c7d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226079
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Auto-Submit: Mike Reed <reed@google.com>
2019-07-09 14:41:07 +00:00
Florin Malita
0e1b0af175 [skottie] Motion blur fast path
Use the SkSG deferred blend mode isolation when possible.

This avoids per-frame layers when the frame content consists of single
draws.

Change-Id: Ia3581ffa421fc1651f0fe5637d34e8e645dcc22a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226077
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-07-09 14:07:42 +00:00
Greg Daniel
627d053913 Move uses of functions taking SkColorType to GrColorType versions in GrCaps.
Change-Id: I4feda6277cf14be0d32a8ce22257902483d7ae1a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225734
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-07-09 13:29:07 +00:00
Florin Malita
5f1108ce46 [skottie] Motion blur support
Unlike all other Skottie effects, motion blur requires sampling at multiple
points on the timeline.

To support this:

  1) Introduce MotionBlurEffect - a custom SG render node which can drive
     the timeline of its subtree using an sksg::Animator.

  2) Introduce MotionBlurController to swap for a regular LayerController
     when needed.  MotionBlurController dispatches time ticks to
     MotionBlurEffect instead of directly to the layer animators.

The actual motion blur impl is based on
https://skia-review.googlesource.com/c/skia/+/221416.

Motion blur requires Lottie files exported with this BodyMovin patch:
https://github.com/bodymovin/bodymovin-extension/pull/15

Change-Id: I075e101ea91ec9aa300bac35ee810fd539f1aced
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225416
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-07-09 13:02:17 +00:00
Brian Osman
8c4ee90b6c Revert "Enable MSAA on Gen8 Intel GPUs"
This reverts commit 0bda1cc640.

Reason for revert: Performance gap is fairly large.

Original change's description:
> Enable MSAA on Gen8 Intel GPUs
> 
> Bug: skia:9225 chromium:527565
> 
> Change-Id: I7c543bce011c247cd93cad90aca15c9754678202
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225731
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>

TBR=bsalomon@google.com,benjaminwagner@google.com,brianosman@google.com

Change-Id: I0e7f0bd53fbdcad0276462852021b9f3adc8ff6e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:9225 chromium:527565
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/226076
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-09 12:58:40 +00:00
Leon Scroggins III
112ac7f19a Check for uninitialized memory during jpeg encode
Bug: chromium:951893

This will help determine which piece of code left memory uninitialized.
Add a test that exercises all the different ways we might pass memory
to jpeg_write_scanlines.

Change-Id: I6392a414795da9b0471e8cd6b373a7fff8f0a1b1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225098
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2019-07-09 12:48:17 +00:00
Ravi Mistry
1540b3ba37 [perf_skottiewasm_lottieweb] Handle case where start TS of frame_id not added yet
NoTry: true
Bug: skia:9237
Change-Id: I37972affe2f01b4248b6dc27b146aaedb28a9de6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225899
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-07-09 12:47:37 +00:00
skia-autoroll
71fc7dc2e5 Roll third_party/externals/angle2 a1b6761e6e3c..5dfad811ce32 (13 commits)
a1b6761e6e..5dfad811ce


git log a1b6761e6e3c..5dfad811ce32 --date=short --no-merges --format='%ad %ae %s'
2019-07-09 syoussefi@chromium.org Vulkan: GLSL output support for SSBO memory qualifiers
2019-07-08 m.maiya@samsung.com Vulkan: Disable Program Binary Support
2019-07-08 spang@chromium.org Vulkan: Remove flush semaphore chain
2019-07-08 clemendeng@google.com Implement core wgl functions
2019-07-08 syoussefi@chromium.org Vulkan: Fix support for framebuffer discard extension
2019-07-08 ynovikov@chromium.org Switch standalone builders to Xenial GCEs
2019-07-08 geofflang@chromium.org Fix capitalization of opengl autogen folder name.
2019-07-08 jmadill@chromium.org Capture/Replay: Return CallCapture from capture funcs.
2019-07-08 geofflang@chromium.org Implement EGL_ANDROID_get_native_client_buffer.
2019-07-08 syoussefi@chromium.org Vulkan: Cleanup buffer dependencies
2019-07-08 geofflang@chromium.org Ensure the global mutex is not locked before deleting it.
2019-07-08 clemendeng@google.com Adding client param to context constructor so it can support other clients
2019-07-08 clemendeng@google.com Merge entry_points_utils.h and entry_points_enum_autogen


Created with:
  gclient setdep -r third_party/externals/angle2@5dfad811ce32

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
TBR=fmalita@google.com

Change-Id: I94f33641f913875f946e7e03a12aa7a39fc58bd3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225991
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-07-09 05:25:37 +00:00
skia-autoroll
bef82ab596 Roll ../src ea1730d8b2f9..9a8eb165a861 (363 commits)
ea1730d8b2..9a8eb165a8


Created with:
  gclient setdep -r ../src@9a8eb165a8

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=fmalita@google.com

Change-Id: I233e7c56e56f56e76ce57a80dec4b05d57e0f931
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225990
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-07-09 04:48:07 +00:00
skia-autoroll
c90e136468 Roll third_party/externals/swiftshader 8900e7c54a22..8c4c9e37bf96 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/8900e7c54a22..8c4c9e37bf96


git log 8900e7c54a22..8c4c9e37bf96 --date=short --no-merges --format='%ad %ae %s'
2019-07-08 chrisforbes@google.com Clean up interface component counting and reduce to spec minimum


Created with:
  gclient setdep -r third_party/externals/swiftshader@8c4c9e37bf96

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=fmalita@google.com

Change-Id: I655d0ff2765bfb355aec15b8a1b9624b4f4c04e3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225989
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-07-09 04:33:47 +00:00
recipe-roller
6b82cf6386 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/3b07526aec5572513374e26191e83d367a6e1f7b Update autoninja's psutil from v5.2.2 to v5.6.2 (jessemckenna@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7e91bb2e4137fb811b85bc83d3ab0176fdae7e96
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225977
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-07-09 00:42:20 +00:00
Hal Canary
c74a55057b GM: s/handleKey/onChar/
Change-Id: I917de2705807f61e6a6c3f76d52e290e8194d204
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225936
Commit-Queue: Ben Wagner <bungeman@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-07-08 22:28:50 +00:00
Ravi Mistry
62e37f1ec5 Parse chrome traces for skottie+wasm and lottie-web for perf
Uses the following algorithm for Skottie+WASM:
* Start timer when  you see BeginImplFrameToSendBeginMainFrame
* Stop timer for main_frame_aborted
* Abandon frame_id if you see replaced_by_new_reporter_at_same_stage, did_not_produce_frame or missed_frame

Getting consistently 25 frames for all lottie-samples with the above algorithm.


Uses the following algorithm for Lottie-Web:
* Start timer when  you see BeginImplFrameToSendBeginMainFrame
* Stop timer for missed_frame or submitted_frame
* Abandon frame_id if you see replaced_by_new_reporter_at_same_stage, did_not_produce_frame or main_frame_aborted

Getting 25 sometimes but also getting other numbers like 20, 27, etc. This is probably because there are more moving parts
and it is hard to predict when Chrome is going to render frames and how many. We might not get exactly 25 here like for
Skottie+WASM, but we will use whatever the tracer gives us (we can always revisit this later).


NoTry: true
Bug: skia:9237
Change-Id: Ia4d5aaf6ac95399b80574d1579358abda4e4e2ea
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225898
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2019-07-08 21:18:10 +00:00
Ravi Mistry
56065d9b87 [skottie-wasm-perf] Turn on chrome tracing
NoTry: true
Bug: skia:9237
Change-Id: Idca7e9417595a98ea86f4a90c98332963d0c86b0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225897
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-07-08 20:53:40 +00:00
Ravi Mistry
b2be410c57 [lottie-web-perf] Use SVG renderer and turn on chrome tracing
Parse lottie file to calculate number of frames instead of doing it in the HTML (which would interfere with tracing numbers).

NoTry: true
Bug: skia:9237
Change-Id: Ie965591206b888919fd2c104f329d703bd099c11
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225896
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-07-08 20:47:44 +00:00
Brian Osman
b6b966aa43 Revert "Make the SkSL interpreter opt-in"
This reverts commit 5cfbee286d.

Reason for revert: Breaking DM in Google3

Original change's description:
> Make the SkSL interpreter opt-in
> 
> Bug: skia:9230
> 
> Change-Id: I50b707a7dd372882a983a4570810dae05c2a3638
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225723
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>

TBR=mtklein@google.com,brianosman@google.com

Change-Id: I5ba231ab75dd44cc1d22d497f9d7e4b732e3aa14
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:9230
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225938
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-08 20:47:03 +00:00
Brian Osman
0bda1cc640 Enable MSAA on Gen8 Intel GPUs
Bug: skia:9225 chromium:527565

Change-Id: I7c543bce011c247cd93cad90aca15c9754678202
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225731
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-08 20:40:40 +00:00
Robert Phillips
7c8af174dd Remove some uses of isTestingOnlyBackendTexture
These uses seem redundant. The remaining uses are in the test "ResourceCacheWrappedResources" where the call is used to ensure borrowed resources aren't deleted.

Change-Id: I2323a3496330b53e13b84e8b7c20037b841224a9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225732
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-07-08 20:27:10 +00:00
Craig Stout
b27aeb71b8 [fuchsia] Use //src/graphics/lib/vulkan for in-tree build
Change-Id: Ifd4f0f9e91377f543393cfb2e26f9d21ce807d2f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225417
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Craig Stout <cstout@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Craig Stout <cstout@google.com>
2019-07-08 20:20:13 +00:00
Greg Daniel
2f2caeaa9b Make isFormatTexturable take a GrColorType.
Change-Id: I02db9025c49d9ee2d805dd6b48916bcc4136f9a8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225729
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-07-08 20:12:43 +00:00
Michael Ludwig
0437f0f5d8 Revert "More optimizations for CropToRect, for axis-aligned quads that have not been inverted"
This reverts commit 88a64b4696.

Reason for revert: Chrome layout tests

Original change's description:
> More optimizations for CropToRect, for axis-aligned quads that have not been inverted
> 
> Prior to CropToRect(), GrRTC::crop_filled_rect only operated on SkRects. The
> quad cropping code generalized the optimization to any axis-aligned quad, but
> a consequence of this is the code had to be robust to flips and 90 degree
> rotations. While it can handle more cases, it has lead to a 1-10% performance
> regression on cropped-rectangle-heavy perf tests in chromium.
> 
> This change brings back the simplest cropping solution when the axis-aligned
> quads have not been flipped/rotated, but the general version still exists for
> the other class of quads as well.
> 
> Bug: chromium:980608
> Change-Id: I83d71075cacc3d849fd9aac6436ea3244a0ae4b9
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225724
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Auto-Submit: Michael Ludwig <michaelludwig@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>

TBR=bsalomon@google.com,robertphillips@google.com,michaelludwig@google.com

Change-Id: I428cbefa5985c6160df0460d38b0698b43d289de
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:980608
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225733
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2019-07-08 20:03:07 +00:00
Brian Osman
5cfbee286d Make the SkSL interpreter opt-in
Bug: skia:9230

Change-Id: I50b707a7dd372882a983a4570810dae05c2a3638
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225723
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-07-08 19:44:22 +00:00
Hal Canary
352f0917a3 Sample/Shaders: use resources; cleanup code
Change-Id: Icd71734927ebb50c8db55730107deb29faf0c61a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225716
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-07-08 19:31:42 +00:00
Hal Canary
a1e88e7fb3 Sample/Lines remove boring sample
Change-Id: I8d266641d283af298a5d44b2889d4fdd4173aeee
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225722
Auto-Submit: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-07-08 19:09:43 +00:00
Hal Canary
6cc65e1fda Samples: simplify Sample::Event
Change-Id: I1daaa9dcf56812bfd29dab64ee04dae63c2660e1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225545
Commit-Queue: Ben Wagner <bungeman@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-07-08 19:09:42 +00:00
Robert Phillips
d09064263d Make BGRA_8888 renderable & textureable by default in the mock context
This is a temporary change to allow us to switch GrMockOptions to be based on GrColorType. Chrome sets up their FakeWebGraphicsContext3DProvider in this manner.

TBR=bsalomon@google.com
Change-Id: I68c6b78aeb0395e1783c7acf1dbdbd028373433c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225720
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-07-08 18:49:51 +00:00
recipe-roller
05716166ae Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/acbc4da8bc664d35bab3ba890bab1c01646d1aba [recipe_engine] Speculatively add retries on EINVAL to os.read on OS X. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2dca43de1f45ca5d5e40811f6acb05125a5418dc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225875
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-07-08 18:18:05 +00:00
Michael Ludwig
88a64b4696 More optimizations for CropToRect, for axis-aligned quads that have not been inverted
Prior to CropToRect(), GrRTC::crop_filled_rect only operated on SkRects. The
quad cropping code generalized the optimization to any axis-aligned quad, but
a consequence of this is the code had to be robust to flips and 90 degree
rotations. While it can handle more cases, it has lead to a 1-10% performance
regression on cropped-rectangle-heavy perf tests in chromium.

This change brings back the simplest cropping solution when the axis-aligned
quads have not been flipped/rotated, but the general version still exists for
the other class of quads as well.

Bug: chromium:980608
Change-Id: I83d71075cacc3d849fd9aac6436ea3244a0ae4b9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225724
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-08 18:02:15 +00:00
Hal Canary
5f4a754ea6 Sample/Patch: use resources; cleanup code
Change-Id: I8450193a6033e8b4262c1f23929a9b3d964a785a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225550
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-07-08 17:50:05 +00:00
Michael Ludwig
aee26ea14e Reland "Switch drawTexture calls to use attemptQuadOptimization"
This reverts commit dcb832ac63.

Reason for revert: chrome layout tests have been suppressed.

Original change's description:
> Revert "Switch drawTexture calls to use attemptQuadOptimization"
>
> This reverts commit 9b2defc3d5.
>
> Reason for revert: Likely broke chrome layout tests
>
> Original change's description:
> > Switch drawTexture calls to use attemptQuadOptimization
> >
> > Before the quad-rendering op refactor, regular filled rectangles and
> > textured rectangles used an internal crop_filled_rect function to crop
> > to the bounding box of the clip. As the quad op refactor progressed,
> > regular filled rectangle drawing went through the new attemptQuadOptimization
> > function that supported more cropping to the exact clip when axis-aligned,
> > and could be better handle complex paints.
> >
> > Following the generalized factories added to GrTextureOp in earlier CLs,
> > it is now possible to route all textured rectangle draws through the same
> > optimizations. While there are a number of public interfaces for drawing
> > rectangles and textures on GrRTC, internally there is now just drawFilledQuad
> > (for complex paints) and drawTexturedQuad(for textures, avoids GrPaint use).
> > Both of these are very similar, and share attemptQuadOptimization(), which
> > makes all rectangle-drawing code, regardless of shader/paint/etc., handled
> > in a consistent manner.
> >
> > This doesn't entirely resolve the complexities of non-AA clipping and non-AA
> > axis-aligned rectangle drawing. That needs additional logic added to the
> > GrQuadUtils::CropToRect function, but this CL is the last structural change
> > to how the ops are created, and to GrRTC to get Ganesh to that stage.
> >
> > Change-Id: Icfbd223eef6e3da0054699334725b5084aaee58a
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/223934
> > Commit-Queue: Michael Ludwig <michaelludwig@google.com>
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
>
> TBR=bsalomon@google.com,michaelludwig@google.com
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Change-Id: Ide21002c336dbc3831a2b042acfec92a509ebacf
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/224639
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>

TBR=bsalomon@google.com,michaelludwig@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 981879
Change-Id: I32ed19d521bd7aed93da787b3de0ca830415f42f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225725
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2019-07-08 17:18:03 +00:00
Hal Canary
b021f3e3fb Sample/Filter2View: make it work without /skimages
Change-Id: I8958e026ca9e2c5a6c99a7a1cd1ec97088c25fe9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225548
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-07-08 17:05:23 +00:00
Brian Salomon
b3b98b77b7 Reland "Disable GLPrograms test on Mac 10.1 bot"
This reverts commit ae35aff632.

Reason for revert: Looks like try bot got lucky. Bots still getting stuck in GLPrograms.

Original change's description:
> Revert "Disable GLPrograms test on Mac 10.1 bot"
> 
> This reverts commit 2a7c6d5e2a.
> 
> Bug: skia:9235
> Change-Id: Id6dc51c3254fac69665c525e73798f97a3099a17
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225539
> Reviewed-by: Jim Van Verth <jvanverth@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>

TBR=jvanverth@google.com,bsalomon@google.com

Change-Id: I4a7e1b35dc278d5d1c0249cd68101575fd1cf189
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:9235
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225726
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-07-08 16:29:45 +00:00
Leon Scroggins III
489d04b0aa Re-Enable Codec tests on Wuffs bot
Bug: skia:8235
Bug: skia:8750
Bug: skia:8762

This reverts commit 30d15e6ca0
("Blacklist Codec tests on Wuffs bot").

Change-Id: I9d8f7dcbb6333590ef3ca70997e76fac6407fcbe
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/224178
Auto-Submit: Leon Scroggins <scroggo@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2019-07-08 16:02:46 +00:00
Brian Salomon
ae35aff632 Revert "Disable GLPrograms test on Mac 10.1 bot"
This reverts commit 2a7c6d5e2a.

Bug: skia:9235
Change-Id: Id6dc51c3254fac69665c525e73798f97a3099a17
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225539
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-07-08 15:42:46 +00:00
Herb Derby
2eb0febea3 Use bulk calls in GlyhRun
+ Remove unused getAdvances

Change-Id: Id23104834edb2845f4331b9450317f70c62f480a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225429
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2019-07-08 15:37:06 +00:00
Leon Scroggins III
a0655512f5 Update libwebp to 1.03 release candidate
This will allow us to run our tests on this version.

https://groups.google.com/a/webmproject.org/forum/?utm_medium=email&utm_source=footer#!msg/webp-discuss/I-tBj7AGg7g/uuAVbuU4BwAJ

Change-Id: I193780f2b2b9e894407aa5828fcfcb2d3e09bd7f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225719
Auto-Submit: Leon Scroggins <scroggo@google.com>
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2019-07-08 14:16:07 +00:00
Mike Klein
246696843b Roll dng_sdk to quiet warnings
These don't show up on the bots with -Werror/-isystem,
but they bug me on local builds where I've forgotten
to set werror = true.

Change-Id: Ief11bb34ca77509441bb4c3874e93de3c51638c6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225403
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
2019-07-08 14:05:37 +00:00
Aaron O'Mullan
829b6a0ff4 Fix Metal includes breaking macOS local builds
Before this fix, skia (and thus Chrome) would fail to compile on macOS when the user (developer) had a case-sensitive file-system.

So I've replaced the incorrect includes of <metal/metal.h> by <Metal/Metal.h>

Change-Id: I6ebcc0f46608f6d840d80d18e5f5baf0744a7f16
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225776
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-07-08 14:02:47 +00:00
skia-autoroll
e192c4ce5a Roll third_party/externals/angle2 c26b7914f03f..a1b6761e6e3c (4 commits)
c26b7914f0..a1b6761e6e


git log c26b7914f03f..a1b6761e6e3c --date=short --no-merges --format='%ad %ae %s'
2019-07-06 syoussefi@chromium.org Vulkan: Add SSBO and combined resource limits
2019-07-05 m.maiya@samsung.com Vulkan: Enable remaining ProgramBinary end2end tests
2019-07-05 jmadill@chromium.org Capture/Replay: Add frame capture to cpp files.
2019-07-05 jmadill@chromium.org Update presubmit checks.


Created with:
  gclient setdep -r third_party/externals/angle2@a1b6761e6e3c

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
TBR=fmalita@google.com

Change-Id: I859343a9970cb765c7962d45534bab47c3c81ff8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225818
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-07-08 05:19:46 +00:00
skia-autoroll
39532cc1ff Roll third_party/externals/swiftshader 1d4f5775ee06..8900e7c54a22 (6 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/1d4f5775ee06..8900e7c54a22


git log 1d4f5775ee06..8900e7c54a22 --date=short --no-merges --format='%ad %ae %s'
2019-07-05 swiftshader.regress@gmail.com Regres: Update test lists @ 1d4f5775
2019-07-05 bclayton@google.com SpirvShader: Rename EmitState::currentBlock to block
2019-07-05 bclayton@google.com SpirvShader: Make accessors private.
2019-07-05 bclayton@google.com SpirvShader: Add Function inner class.
2019-07-05 bclayton@google.com Move pointers and intermediates from SpirvRoutine to SpirvShader::EmitState.
2019-07-05 bclayton@google.com Move GenericValue into SpirvShader


Created with:
  gclient setdep -r third_party/externals/swiftshader@8900e7c54a22

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=fmalita@google.com

Change-Id: I0ec074041d2cb5a6d2d5f26ba70b50c2172aadc5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225816
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-07-08 05:09:36 +00:00
skia-autoroll
de6758683a Roll ../src 536c762e1a81..ea1730d8b2f9 (195 commits)
536c762e1a..ea1730d8b2


Created with:
  gclient setdep -r ../src@ea1730d8b2

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=fmalita@google.com

Change-Id: I46c3c73256fb6affd6aa1c0ab41942c6f0aeb519
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225817
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-07-08 04:35:16 +00:00
skia-recreate-skps
2f62edf1ac Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I94191773de2729a3537b3be00a30f44e20067051
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225756
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-07-07 08:21:09 +00:00
skia-autoroll
1d105080c4 Roll third_party/externals/angle2 c4ef62ec1a68..c26b7914f03f (9 commits)
c4ef62ec1a..c26b7914f0


git log c4ef62ec1a68..c26b7914f03f --date=short --no-merges --format='%ad %ae %s'
2019-07-04 ynovikov@chromium.org Skip EGLSurfaceTest.SwapInterval on Linux NVIDIA Vulkan.
2019-07-04 clemendeng@google.com ANGLE tests loading wrong opengl32.dll
2019-07-04 clemendeng@google.com Don't remove GL commands that are duplicates of GLES commands
2019-07-04 jmadill@chromium.org Fix header check for GLES 1.0 conformance tests.
2019-07-04 jonahr@google.com Add missing functions to libEGL.def
2019-07-04 geofflang@chromium.org Make egl::Sync a LabeledObject.
2019-07-04 jonahr@google.com Add GLES 3.1 dEQP test results to ANGLE docs
2019-07-04 jmadill@chromium.org Store angle::Format in gl::VertexAttribute.
2019-07-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 22683b409e6d..4b4b41a63499 (1 commits)


Created with:
  gclient setdep -r third_party/externals/angle2@c26b7914f03f

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
TBR=jvanverth@google.com

Change-Id: Id903949217c154463c5dd0a2c700f95637bcaf40
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225678
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-07-05 05:29:16 +00:00
skia-autoroll
308e4a06b5 Roll third_party/externals/swiftshader 72d8104846de..1d4f5775ee06 (14 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/72d8104846de..1d4f5775ee06


git log 72d8104846de..1d4f5775ee06 --date=short --no-merges --format='%ad %ae %s'
2019-07-04 capn@google.com Clamp GLSL textureSize() lod to mipmap range
2019-07-04 bclayton@google.com LLVMReactor: Include the host mcpu in the target builder.
2019-07-04 bclayton@google.com Use the full list of optimization passes from spirv-opt
2019-07-04 sugoi@google.com Follow up on "Add support for R8_SRGB textures"
2019-07-04 bclayton@google.com SpirvShader: Fully initialize variables in emitSamplerFunction()
2019-07-04 bclayton@google.com LLVMReactor/SpirvShader: Don't zero loads on disabled lanes.
2019-07-04 bclayton@google.com SpirvShader: Optimize SIMD loads of static, equal offsets, in-bound pointers
2019-07-04 bclayton@google.com Reactor: Rework optimization flags.
2019-07-04 bclayton@google.com Refactor LLVMReactor globals into 3 classes.
2019-07-04 bclayton@google.com Regres: Bump MaxProcMemory from 2GB to 3GB
2019-07-04 bclayton@google.com Regres: Post significant changes to test times
2019-07-04 bclayton@google.com Regres: Treat ABORT()s as failures
2019-07-04 bclayton@google.com Regres: Add flag to prioritize a single change
2019-07-04 bclayton@google.com Regres: Add flag to run the daily test run on launch


Created with:
  gclient setdep -r third_party/externals/swiftshader@1d4f5775ee06

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=jvanverth@google.com

Change-Id: I893529e2d109714e3ac46d38afd0ce9fba85ad75
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225676
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-07-05 04:34:16 +00:00
skia-autoroll
6821099bf3 Roll ../src 080c02ae0336..536c762e1a81 (240 commits)
080c02ae03..536c762e1a


Created with:
  gclient setdep -r ../src@536c762e1a

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=jvanverth@google.com

Change-Id: Ia1f584171085492732cd8f83c068cf69cfebe1c6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225677
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-07-05 04:30:36 +00:00
skia-autoroll
8063f6cca0 Roll third_party/externals/angle2 66b5ff586c9c..c4ef62ec1a68 (9 commits)
66b5ff586c..c4ef62ec1a


git log 66b5ff586c9c..c4ef62ec1a68 --date=short --no-merges --format='%ad %ae %s'
2019-07-04 ianelliott@google.com Vulkan: Note newly-passing Windows tests.
2019-07-04 timvp@google.com Vulkan: dFdy is incorrect when the framebuffer is flipped
2019-07-03 tobine@google.com Restore flatten invariant behavior
2019-07-03 lfy@google.com GLES1: disable texture3DOES extension
2019-07-03 jonahr@google.com End2end test for WebGL conformance2/uniforms/large-uniform-buffers.html
2019-07-03 m.maiya@samsung.com Vulkan: Implement OES_get_program_binary extension
2019-07-03 jonahr@google.com Skip EGLFeatureControlTest.InvalidDisplay on all Win/Intel
2019-07-03 clemendeng@google.com Load the correct opengl32.dll
2019-07-03 ynovikov@chromium.org Skip ImageTest.Source3DTargetExternal on Ozone


Created with:
  gclient setdep -r third_party/externals/angle2@c4ef62ec1a68

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
TBR=jvanverth@google.com

Change-Id: Iaa26ce991a361492b46e7a8e60a736dcacd5ea76
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225637
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-07-04 05:26:03 +00:00