Commit Graph

7945 Commits

Author SHA1 Message Date
epoger@google.com
89fa4b9ee6 rebaseline.py: error out early if --expectations-root not pointing at gm-expected dir
BUG=https://code.google.com/p/skia/issues/detail?id=1403
R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/18416005

git-svn-id: http://skia.googlecode.com/svn/trunk@9961 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 16:54:10 +00:00
commit-bot@chromium.org
5396a048d2 Added a high-color (50 colors) gradient for each gradient type.
To do so I added an enumerated type called ColorType that can toggle between kColors_2 and kColors_50 to swap between 2 and 50 color gradients.





Added hicolor bench for each gradient type.

BUG=
R=reed@google.com, bsalomon@google.com

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/18655012

git-svn-id: http://skia.googlecode.com/svn/trunk@9960 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 16:13:14 +00:00
reed@google.com
262ff953a7 restore hash size to 8 bits, following windows fix in 3591f7a4a56153349240dfc542cc61a11fab2487
git-svn-id: http://skia.googlecode.com/svn/trunk@9959 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 15:55:04 +00:00
humper@google.com
5a867c74e1 fix swapped bitmap channels on Mac for debugger
BUG=
R=djsollen@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/18485004

git-svn-id: http://skia.googlecode.com/svn/trunk@9958 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 15:53:36 +00:00
reed@google.com
84e22d847f allow createScalerContext to return null, and then have the GDI backend trigger that if we fail to create the necessary GDI resources
BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/18484005

git-svn-id: http://skia.googlecode.com/svn/trunk@9957 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 15:38:20 +00:00
epoger@google.com
9de25e3fd4 rebaseline.py: use specified configs/tests as a FILTER over actually-run tests
Now that we have the actual-results.json file for every bot type, we know
the full set of tests that actual results are available for. If configs and/or
tests are specified, just use those as FILTERS over the actually available
results.

R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/18324018

git-svn-id: http://skia.googlecode.com/svn/trunk@9956 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 15:27:18 +00:00
commit-bot@chromium.org
3720fda4eb ARM Skia NEON patches - 09 - Bugfix
Misc: fix a PDF warning/bug on ARM

char is unsigned by default on ARM, so the (curNibble < 0) test is
always false, probably leading to a bug.

BUG=
R=djsollen@google.com, edisonn@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/18365005

git-svn-id: http://skia.googlecode.com/svn/trunk@9954 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 15:03:52 +00:00
commit-bot@chromium.org
89c43e84c4 ARM Skia NEON patches - 05 - Cleaning
Misc: move definition of empty SkBlitRow::ColorRectProc

For the sake of consistency, the empty SkBlitRow::ColorRectProc
should be defined in SkBlitRow_opts_none.cpp rather than
SkUtils_opts_none.cpp

BUG=
R=djsollen@google.com, reed@google.com, tomhudson@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/18314005

git-svn-id: http://skia.googlecode.com/svn/trunk@9953 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 13:55:46 +00:00
commit-bot@chromium.org
939fffed12 ARM Skia NEON patches - 02 - Tune filter clobber list
Misc: reduce clobber list in SkBitmapProcState_filter_neon.h

This may allow the compiler to do a better job

BUG=
R=djsollen@google.com, tomhudson@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/18996003

git-svn-id: http://skia.googlecode.com/svn/trunk@9952 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 13:53:19 +00:00
robertphillips@google.com
49c6b43812 More valgrind suppressions
(SkipBuildbotRuns)



git-svn-id: http://skia.googlecode.com/svn/trunk@9951 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 13:38:33 +00:00
commit-bot@chromium.org
cae27fed5e Allow the resource cache to (indirectly) flush the InOrderDrawBuffer
R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/18466005

git-svn-id: http://skia.googlecode.com/svn/trunk@9949 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 10:14:35 +00:00
skia.committer@gmail.com
9e1ec1a529 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9948 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 07:00:58 +00:00
robertphillips@google.com
ead3b83645 Fix Win7 compiler errors/warnings for r9945
git-svn-id: http://skia.googlecode.com/svn/trunk@9947 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 23:19:53 +00:00
bungeman@google.com
b17859133a Make 'rotate' animate in SampleApp.
R=reed@google.com

Review URL: https://codereview.chromium.org/18948002

git-svn-id: http://skia.googlecode.com/svn/trunk@9946 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 21:58:56 +00:00
humper@google.com
807863839f avoid introducing duplicate const in release builds
git-svn-id: http://skia.googlecode.com/svn/trunk@9945 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 21:55:47 +00:00
humper@google.com
b088947f27 New bitmap filter checkin; this time with less build breakage
BUG=

Review URL: https://codereview.chromium.org/18942002

git-svn-id: http://skia.googlecode.com/svn/trunk@9944 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 21:37:14 +00:00
reed@google.com
6e8b7ddefd use typedef to name our ID type in SkImageCache
BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/18612003

git-svn-id: http://skia.googlecode.com/svn/trunk@9943 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 21:31:54 +00:00
zachr@google.com
9432c0c284 add diff viewer website
- adjust PMetric output to be percentage

R=borenet@google.com, bsalomon@google.com

Review URL: https://codereview.chromium.org/18132007

git-svn-id: http://skia.googlecode.com/svn/trunk@9942 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 21:08:28 +00:00
djsollen@google.com
dc7919f228 Remove old and unused Android font host code
R=bungeman@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/18666003

git-svn-id: http://skia.googlecode.com/svn/trunk@9940 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 20:35:03 +00:00
commit-bot@chromium.org
13b3aa1466 Export SkPathOps.h functions for external use.
In order to make Op() and Simplify() accessible from Blink, they need to be SK_API-annotated.

R=caryclark@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18912002

git-svn-id: http://skia.googlecode.com/svn/trunk@9939 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 19:43:35 +00:00
commit-bot@chromium.org
b686539ab5 Added GM and Bench
Added GM's and Bench


Added GM file nate_gradients.cpp

BUG=
R=reed@google.com, bsalomon@google.com

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/18259012

git-svn-id: http://skia.googlecode.com/svn/trunk@9938 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 19:43:29 +00:00
humper@google.com
1a8940e558 Revert "More general image filter interface; tested implementation of standalone"
This reverts commit 4df3e8b079e019af5f60c13e7e6ec6589663962a.

git-svn-id: http://skia.googlecode.com/svn/trunk@9937 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 18:02:06 +00:00
humper@google.com
25fc6b9bfb More general image filter interface; tested implementation of standalone
image scaler (not yet plumbed).  High quality downsampler.  Fast SSE
resampler.

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/17381008

git-svn-id: http://skia.googlecode.com/svn/trunk@9936 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 17:48:15 +00:00
robertphillips@google.com
64527e9caa Fix Win7 compiler warnings/errors in r9934
git-svn-id: http://skia.googlecode.com/svn/trunk@9935 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 16:57:01 +00:00
commit-bot@chromium.org
d43f644912 Animated the PathUtils Sample to show path contours# Enter a description of the change.
Animated the PathUtils Sample to path contours

BUG=
R=reed@google.com, scroggo@google.com, djsollen@google.com

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/18552005

git-svn-id: http://skia.googlecode.com/svn/trunk@9934 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 16:30:38 +00:00
commit-bot@chromium.org
fe433c1370 When gather pixel refs was broken, REPORTER_ASSERT(data) realized that data was NULL, but subsequent lines dereferenced it anyway, and so segfaulted.
R=reed@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18904003

git-svn-id: http://skia.googlecode.com/svn/trunk@9933 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 16:04:32 +00:00
scroggo@google.com
468142b2f5 Allow ico decoder to decode PNG sub-images.
Since Windows Vista, PNG can be embedded in an ICO file. Update
our decoder to support this.

BUG=https://code.google.com/p/skia/issues/detail?id=1398
R=djsollen@google.com

Review URL: https://codereview.chromium.org/18655007

git-svn-id: http://skia.googlecode.com/svn/trunk@9932 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 15:48:24 +00:00
scroggo@google.com
bc69ce982f Remove bitmap reuse from SkImageDecoder.
Now that Android is using an SkBitmap::Allocator to reuse bitmap
memory, remove the unnecessary code to handle bitmap reuse inside
the decoders themselves.

Leaves in the code for bitmap reuse in decodeSubset, which still
may reuse bitmaps, and cropBitmap, which is called by decodeSubset.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/17620004

git-svn-id: http://skia.googlecode.com/svn/trunk@9931 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 15:45:14 +00:00
reed@google.com
4b60dbe661 move failable work outside of constructors for SkGlyphCache and SkScalerContextGDI. If we fail, try to purge everything and try again, in case the failure was from memory/os-resource exhaustion (e.g. out of HDC handles in windows)
BUG=

Review URL: https://codereview.chromium.org/18132009

git-svn-id: http://skia.googlecode.com/svn/trunk@9930 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 15:29:32 +00:00
robertphillips@google.com
e1b75b4096 GM (and fix) for drawArc capping issue
https://codereview.chromium.org/18271003/



git-svn-id: http://skia.googlecode.com/svn/trunk@9928 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 15:03:59 +00:00
humper@google.com
387db0a2e5 add extra flag (currently unused) for high quality downsampling
BUG=
R=reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/18386006

git-svn-id: http://skia.googlecode.com/svn/trunk@9927 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 14:13:04 +00:00
robertphillips@google.com
cb6d97ca71 Revert of r9902 (Consider conical shader opaque if it covers
entire plane - https://chromiumcodereview.appspot.com/18533006) due to roll issues (https://codereview.chromium.org/18859007/)



git-svn-id: http://skia.googlecode.com/svn/trunk@9926 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 13:50:09 +00:00
tfarina@chromium.org
592dee9944 Remove unused private fields from PathUtilsBench.
This allows compilation to proceed on Linux with clang when building the "most"
target.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/18338011

git-svn-id: http://skia.googlecode.com/svn/trunk@9925 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 13:33:16 +00:00
robertphillips@google.com
5d367c455c More valgrind suppressions
(SkipBuildbotRuns)



git-svn-id: http://skia.googlecode.com/svn/trunk@9923 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 12:51:58 +00:00
robertphillips@google.com
5f63fdf28c Performance trigger rebaselines
(SkipBuildbotRuns)



git-svn-id: http://skia.googlecode.com/svn/trunk@9920 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 12:38:59 +00:00
skia.committer@gmail.com
a4aced4728 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9919 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-09 07:00:56 +00:00
commit-bot@chromium.org
d8d976e7d2 Added SkPDFStream::setData(SkData*) in preparation for move from SkStream to SkData
R=vandebo@chromium.org, edisonn@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18328026

git-svn-id: http://skia.googlecode.com/svn/trunk@9916 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-08 23:17:57 +00:00
scroggo@google.com
a7df69865c Add expectations files covering new image files.
New image files are in Google Storage, so add expectations for them.
The ICO file is expected to fail, although there is a patch to fix
that out for review (https://chromiumcodereview.appspot.com/18655007/)

Unreviewed.

Since we are currently ignoring failures in skimage, this should at
most produce a warning, but I expect it to remove the current warning
state.

The razr expectation is copied from nexus-7, as razr is currently
not working.

Review URL: https://codereview.chromium.org/18271012

git-svn-id: http://skia.googlecode.com/svn/trunk@9915 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-08 23:17:29 +00:00
scroggo@google.com
c6e5fcb4c4 Debugging statements to investigate a bug.
https://code.google.com/p/skia/issues/detail?id=1395 is a non-
deterministic bug that I have been unable to reproduce. Add
some debugging information to try to help diagnose.

BUG=https://code.google.com/p/skia/issues/detail?id=1395
R=edisonn@google.com

Review URL: https://codereview.chromium.org/18523008

git-svn-id: http://skia.googlecode.com/svn/trunk@9914 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-08 22:00:17 +00:00
epoger@google.com
ba7ef37a04 rebaseline.py: look in gm-expected directory to see whether it's using git or svn
(before this change, it checked in the current working dir instead)

Review URL: https://codereview.chromium.org/18209010

git-svn-id: http://skia.googlecode.com/svn/trunk@9913 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-08 20:53:28 +00:00
epoger@google.com
e33e137623 GM: stop recording all *_pdf.png results as "INVALID" on non-Mac platforms
BUG=https://code.google.com/p/skia/issues/detail?id=1352
R=edisonn@google.com

Review URL: https://codereview.chromium.org/17366003

git-svn-id: http://skia.googlecode.com/svn/trunk@9912 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-08 19:13:33 +00:00
scroggo@google.com
056dab300d Revert "Temporary change to keep chrome happy."
Now that chrome has https://chromiumcodereview.appspot.com/18078003/,
this is no longer needed.

Fully switched over to using CreateFromStream!

Review URL: https://codereview.chromium.org/18655008

git-svn-id: http://skia.googlecode.com/svn/trunk@9911 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-08 18:40:42 +00:00
epoger@google.com
a783f2bee8 rebaseline.py: if expectations dir contains JSON format results, update those instead of image files
Part of Step 3 in https://goto.google.com/ChecksumTransitionDetail

R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/18348018

git-svn-id: http://skia.googlecode.com/svn/trunk@9910 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-08 17:51:58 +00:00
robertphillips@google.com
d7a1eea159 More valgrind suppressions
(SkipBuildbotRuns)



git-svn-id: http://skia.googlecode.com/svn/trunk@9909 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-08 17:26:07 +00:00
caryclark@google.com
07e97fccd2 path ops work in progress
BUG=

Review URL: https://codereview.chromium.org/18058007

git-svn-id: http://skia.googlecode.com/svn/trunk@9908 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-08 17:17:02 +00:00
zachr@google.com
a95959c3fb add JSONP option to output of skpdiff
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/18648002

git-svn-id: http://skia.googlecode.com/svn/trunk@9907 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-08 15:04:45 +00:00
tfarina@chromium.org
293f01939c Fix header guard typos.
This is preventing compilation on Linux with clang.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/18131007

git-svn-id: http://skia.googlecode.com/svn/trunk@9905 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-08 13:00:42 +00:00
robertphillips@google.com
561b7138c3 Performance trigger rebaselines for r9888 (Add canFilterMaskGPU & filterMaskGPU to SkMaskFilter - https://codereview.chromium.org/18110012/)
(SkipBuildbotRuns)



git-svn-id: http://skia.googlecode.com/svn/trunk@9904 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-08 12:03:47 +00:00
commit-bot@chromium.org
9839320ae1 Removing highp variables from perlin noise shader
Variables using highp on the Adreno320 (A.K.A. Nexus 4) seem to be causing issues. I modified the shader so that all variables stay in a lower range, no longer requiring the "highp" qualifier.
This may improve performance on other devices, like the xoom, where the "highp" qualifier was required.

In Blink, these layout tests may require rebaselining :
./css3/filters/effect-reference-hw.html
./css3/filters/effect-reference-zoom-hw.html

BUG=https://code.google.com/p/skia/issues/detail?id=1376
R=senorblanco@google.com, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18454004

git-svn-id: http://skia.googlecode.com/svn/trunk@9903 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-04 18:13:05 +00:00
commit-bot@chromium.org
5e6c3557f8 Consider conical shader opaque if it covers entire plane.
BUG=222380
R=junov@chromium.org, senorblanco@chromium.org, reed@google.com

Author: arbesfeld@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18533006

git-svn-id: http://skia.googlecode.com/svn/trunk@9902 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-04 14:42:26 +00:00