halcanary
385fe4d4b6
Style Change: SkNEW->new; SkDELETE->delete
...
DOCS_PREVIEW= https://skia.org/?cl=1316123003
Review URL: https://codereview.chromium.org/1316123003
2015-08-26 13:07:49 -07:00
bungeman
60e0fee6d4
Remove include of stdlib.h from SkTypes.h.
...
Unfortunately, immintrin.h (which is also included by SkTypes)
includes xmmintrin.h which includes mm_malloc.h which includes
stdlib.h for malloc even though, from the implementation, it is
difficult to see why.
Fortunately, arm_neon.h does not seem to be involved in such
shenanigans, so building for Android will keep things sane.
TBR=reed@google.com
Doesn't change Skia API, just moves an include.
Review URL: https://codereview.chromium.org/1313203003
2015-08-26 05:15:46 -07:00
borenet
cf72ed6a3e
Skip scaled_tilemodes_npot on Galaxy S4
...
It's hanging.
BUG=skia:3932
Review URL: https://codereview.chromium.org/1318503003
2015-08-25 06:53:37 -07:00
borenet
98f7e334e7
Add buildbot_spec info for Appurify bot
...
BUG=skia:4093
Review URL: https://codereview.chromium.org/1296593003
2015-08-24 12:50:59 -07:00
halcanary
2f0a728e5a
GMs: change some GMs to use SkImage over SkBitmap
...
Also, add GetResourceAsImage() to Resources.h
Motivation: test drawImage() as much as we test drawBitmap()
Review URL: https://codereview.chromium.org/1306133003
2015-08-21 07:47:23 -07:00
bungeman
99fe822606
Use static_assert instead of SK_COMPILE_ASSERT.
...
Now that static_assert is allowed, there is no need to use a non-
standard compile time assertion
Review URL: https://codereview.chromium.org/1306443004
2015-08-20 07:57:52 -07:00
bungeman
f3c15b7cfc
Move SkTemplates.h to private.
...
SkTemplates.h contains a number of Skia specific utilities which are
not designed for external use. In addition to reducing the external
support burden, this will allow Skia to freely refactor this file.
Review URL: https://codereview.chromium.org/1272293004
2015-08-19 11:56:48 -07:00
mtklein
c6ad06acef
unsigned -> int for counts and indices in picture-related code
...
also, (C)
BUG=skia:
Review URL: https://codereview.chromium.org/1300163002
2015-08-19 09:51:01 -07:00
joshualitt
5b4a7abd48
Adding sucessful exit message to VisualBench
...
BUG=skia:
Review URL: https://codereview.chromium.org/1287763004
2015-08-19 08:21:48 -07:00
bsalomon
f3bf892d71
Fix VS 2015 build
...
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/1297283003
2015-08-19 06:12:36 -07:00
egdaniel
73caadf277
Try enabling all nanobenches on Nexus7
...
BUG=skia:2774
Review URL: https://codereview.chromium.org/1290223005
2015-08-18 13:08:36 -07:00
joshualitt
892b0c3db9
Add skeleton json support to visualbench
...
BUG=skia:
Review URL: https://codereview.chromium.org/1298213002
2015-08-18 12:13:34 -07:00
mtklein
d55d13af4f
Update BUILD.public a bit.
...
- SSE2 files are unfortunately now mixed-case, _SSE2 or _sse2.
- Adds lists for SSSE3 and SSE4 files.
- Remove SkDocument_PDF_None.cpp
- Remove a few more references to animator.
- Exclude private headers from HDRS.
- Formatting and notes.
BUG=skia:
Review URL: https://codereview.chromium.org/1298003007
2015-08-18 08:51:49 -07:00
halcanary
bf3dde2716
Clean up BUILD_simulator.py
...
Review URL: https://codereview.chromium.org/1298813002
2015-08-18 08:35:45 -07:00
benjaminwagner
f82c13fced
Reland of Fix a few bugs in the google3 sync scripts. (patchset #1 id:1 of https://codereview.chromium.org/1295213002/ )
...
Reason for revert:
Retry.
Original issue's description:
> Revert of Fix a few bugs in the google3 sync scripts. (patchset #1 id:1 of https://codereview.chromium.org/1291343006/ )
>
> Reason for revert:
> MacMini buildbots were unable to apply the patch.
> fatal: Could not parse object '18af0a0080cc2b2b3464292d35a0886cdade551f'.
> http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release/builds/1580
> http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Debug/builds/1474
> http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Release/builds/1566
> http://build.chromium.org/p/client.skia/builders/Perf-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Release/builds/1480
> http://build.chromium.org/p/client.skia/builders/Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release/builds/1456
> http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug/builds/1364
>
>
> Original issue's description:
> > Fix a few bugs in the google3 sync scripts.
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/18af0a0080cc2b2b3464292d35a0886cdade551f
>
> TBR=mtklein@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/e349d6b92574c1b0acdb4ba1ed8ff905ea830131
TBR=mtklein@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1284093003
2015-08-18 06:25:14 -07:00
robertphillips
ea4529d09a
Move normal map creation methods to sk_tools
...
Split off of https://codereview.chromium.org/1261433009/ (Add SkCanvas::drawLitAtlas call)
Review URL: https://codereview.chromium.org/1298763002
2015-08-17 15:04:47 -07:00
mtklein
df5b7603d2
Add a simple script to simulate BUILD file glob() expansion.
...
This lets us test changes to BUILD.public.
This is not yet automated in any way. My hope is to trigger it quietly via the presubmit for any CL that adds or removes a file, or changes BUILD.public.
BUG=skia:
Review URL: https://codereview.chromium.org/1290833003
2015-08-17 15:02:57 -07:00
benjaminwagner
e349d6b925
Revert of Fix a few bugs in the google3 sync scripts. (patchset #1 id:1 of https://codereview.chromium.org/1291343006/ )
...
Reason for revert:
MacMini buildbots were unable to apply the patch.
fatal: Could not parse object '18af0a0080cc2b2b3464292d35a0886cdade551f'.
http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release/builds/1580
http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Debug/builds/1474
http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Release/builds/1566
http://build.chromium.org/p/client.skia/builders/Perf-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Release/builds/1480
http://build.chromium.org/p/client.skia/builders/Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release/builds/1456
http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug/builds/1364
Original issue's description:
> Fix a few bugs in the google3 sync scripts.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/18af0a0080cc2b2b3464292d35a0886cdade551f
TBR=mtklein@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1295213002
2015-08-17 14:44:01 -07:00
benjaminwagner
18af0a0080
Fix a few bugs in the google3 sync scripts.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1291343006
2015-08-17 14:23:03 -07:00
benjaminwagner
787ca87b33
Add files added to Skia HEAD in google3 to the Git repo.
...
LICENSE is modified in google3 to mention some code copied from other projects.
BUG=skia:
Review URL: https://codereview.chromium.org/1291603003
2015-08-17 12:58:10 -07:00
emmaleer
8f4ba76742
SkScaledCodec class
...
This class does scaling by using a scanlineDecoder.
getScanlines and skipScanlines are used for y sampling,
the swizzler is used for x sampling
this class is currently only working for png and jpeg images
I will update other Codec types to work soon
For SkJpegCodec to implement width wise swizzling it now
uses a swizzler. I ran performance tests on this change.
Here are the performance test results:
https://docs.google.com/a/google.com/spreadsheets/d/1D7-Q_GXD_dI68LZO005NNvb8Wq2Ee0wEBEPG72671yw/edit?usp=sharing
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/0944100ac89f797714eeae0cf2875e2335ff52ee
Committed: https://skia.googlesource.com/skia/+/d518ea7927f9f4e0ed5b4134d1b4f48243855a47
Committed: https://skia.googlesource.com/skia/+/b157917507d4f7d2651f0aeb566d31603cc02240
Review URL: https://codereview.chromium.org/1260673002
2015-08-14 07:44:46 -07:00
Mike Klein
dd958e72f9
Add tools/ubsan.supp.
...
Should unbreak TSAN bots.
BUG=skia:
Review URL: https://codereview.chromium.org/1272213003 .
2015-08-05 10:12:33 -04:00
borenet
dbf9f014a8
buildbot_spec: Add configuration, do_*_steps, upload_*_results, more env
...
NOTRY=true
BUG=skia:4132
Review URL: https://codereview.chromium.org/1258193004
2015-07-30 07:09:20 -07:00
borenet
2481b8b719
buildbot_spec.py: Include dm_flags and nanobench_flags
...
Eventually I'll want to merge them into this file, but not just yet.
NOTRY=true
BUG=skia:4132
Review URL: https://codereview.chromium.org/1257933003
2015-07-29 11:43:07 -07:00
borenet
7bccca1a82
buildbot_spec.py: Add Android/ChromeOS device info, add builder_cfg dict
...
NOTRY=true
BUG=skia:4132
Review URL: https://codereview.chromium.org/1269543002
2015-07-29 11:15:42 -07:00
borenet
b76c1f706c
Add builder_spec.py
...
Works like dm_flags.py and nanobench_flags.py; adds things like
GYP_DEFINES, additional environment variables, and build targets.
Required copying builder_name_schema from the tools/build repo.
BUG=skia:4132
Review URL: https://codereview.chromium.org/1265623002
2015-07-29 07:38:49 -07:00
mtklein
e0effd6080
Allow Srcs to veto Sinks based on their broad type.
...
This breaks Sinks down into three auto-detected types:
- GPU: anything that requests to be run in the GPU enclave
- Vector: anything that writes to the stream instead of the bitmap
- Raster: everything else
Some examples: gpu -> GPU, msaa16 -> GPU, 8888 -> raster, pdf -> vector,
svg -> vector, pipe-8888 -> raster, tiles_rt-gpu -> GPU
This lets image decoding sinks veto non-raster backends explicitly,
and can let particular GMs veto GPU or non-GPU sinks as they like.
BUG=skia:
Review URL: https://codereview.chromium.org/1239953004
2015-07-29 06:37:28 -07:00
caryclark
1818acb6a4
rename portable_typeface_always to portable_typeface
...
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1257773002
2015-07-24 12:09:25 -07:00
caryclark
37213558e6
make fontscalar gammatext lcdtext typeface verttext2 gm portable
...
Pass generic font names to tool util function to generate
platform specific fonts and gm test output by unique name.
R=bungeman@google.com
Review URL: https://codereview.chromium.org/1256903002
2015-07-24 11:08:01 -07:00
caryclark
3b0f98ee17
fix typeface leak
...
TBR=bungeman@google.com
Review URL: https://codereview.chromium.org/1239303003
2015-07-23 11:52:01 -07:00
caryclark
e663341605
fix typo
...
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1245993003
2015-07-23 09:11:58 -07:00
borenet
4cb300340e
Coverage: add a trace for not_covered_lines per file
...
Example output:
{
"build_number": "2",
"gitHash": "71f5db892ee7ed9fbb573da28ccb906e18ba24a4",
"key": {
"arch": "x86_64",
"compiler": "Clang",
"configuration": "Coverage",
"cpu_or_gpu": "CPU",
"cpu_or_gpu_value": "AVX2",
"model": "GCE",
"os": "Ubuntu"
},
"results": {
"dm_DMGpuSupport_h": {
"coverage": {
"lines_not_covered": 6,
"options": {
"dir": "dm",
"fullname": "dm/DMGpuSupport.h",
"source_type": "coverage"
},
"percent": 33.33333333333333
}
},
"dm_DMJsonWriter_cpp": {
......
BUG=skia:2430
Review URL: https://codereview.chromium.org/1246043002
2015-07-22 08:19:25 -07:00
caryclark
c3dcb67f07
make color emoji gm portable
...
R=bungeman@google.com
Review URL: https://codereview.chromium.org/1248703004
2015-07-21 12:27:36 -07:00
borenet
9b8d3580c2
Skip imagefiltersclipped GM on Galaxy S4
...
BUG=skia:4079
Review URL: https://codereview.chromium.org/1250473005
2015-07-21 05:57:22 -07:00
caryclark
6531c3619f
Generate platform specific fontmgr gm.
...
The gm output on different font platforms is so different
that comparing images in Gold has little value. Separate the
images by appending platform information to the gm name to
group somewhat similar images together.
Note that this does not attempt to make sure that all images
generated by Gold are nearly pixel identical; it only reduces
the number of nonsensical comparisons.
R=bungeman@google.com
Review URL: https://codereview.chromium.org/1245643002
2015-07-20 13:38:56 -07:00
borenet
a6ae14e223
Split llvm_coverage_run into two scripts
...
... One for running to generate the coverage data, another to parse the data into various formats.
NOTRY=true
BUG=skia:2430
Review URL: https://codereview.chromium.org/1239963002
2015-07-20 09:43:36 -07:00
joshualitt
a2a6fe8699
Some cleanups of VisualBench
...
BUG=skia:
Review URL: https://codereview.chromium.org/1240633005
2015-07-17 09:09:23 -07:00
borenet
5150a77ee7
llvm_coverage_build: Use CC and CXX variables by default
...
NOTRY=true
BUG=skia:2430
Review URL: https://codereview.chromium.org/1242573003
2015-07-17 07:31:07 -07:00
joshualitt
47d280d3b0
Fix visual bench memory leak
...
BUG=skia:
Review URL: https://codereview.chromium.org/1239103002
2015-07-16 14:23:22 -07:00
joshualitt
31b21f6719
Small fix for visualbench
...
BUG=skia:
Review URL: https://codereview.chromium.org/1237563005
2015-07-16 13:40:51 -07:00
scroggo
c1121efbc6
Stop running image tests on msaa.
...
Blacklist all image tests on msaa. We do not run them anyway (since
they will not do anything interestingly different from drawing to the
raster backend) - we early exit from Src::draw(), but we still need to
create a render target that matches the size of the image (when not
blacklisted).
Remove the more specific blacklist of a particular image, which is
covered by this one.
BUG=skia:4045
Review URL: https://codereview.chromium.org/1234313006
2015-07-16 12:36:10 -07:00
borenet
8a955af001
Coverage script: fix missing data
...
BUG=skia:2430
Review URL: https://codereview.chromium.org/1242023002
2015-07-16 07:01:44 -07:00
joshualitt
82874f8b28
Match works correctly on visualbench
...
BUG=skia:
Review URL: https://codereview.chromium.org/1234123004
2015-07-15 08:38:02 -07:00
borenet
f0c84407ae
llvm-coverage script: respect SKIA_OUT
...
NOTRY=true
BUG=skia:2430
Review URL: https://codereview.chromium.org/1239803002
2015-07-15 07:43:06 -07:00
joshualitt
d4fa90feea
Fix VisualBench to hold onto a surface
...
BUG=skia:
Review URL: https://codereview.chromium.org/1236723003
2015-07-15 06:18:57 -07:00
msarett
02b5aa3cac
Fixed valgrind issues with libjpeg-turbo
...
The fixes are in the updated libjpeg-turbo repository
pulled in by DEPS. The fixes are detailed in the linked
skia bug. To summarize briefly, we now use calloc()
instead of malloc().
BUG=skia:4030
Review URL: https://codereview.chromium.org/1237213004
2015-07-14 14:39:59 -07:00
mtklein
f059900f75
Fix up -Winconsistent-missing-override
...
(and a couple presubmit fixes)
This allows us to turn back on -Werror for LLVM coverage builds,
and more generally supports building with Clang 3.7.
No public API changes.
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1232463006
2015-07-13 06:18:39 -07:00
reed
1c84634454
add runtime option to provide data->imagegenerator factory
...
BUG=skia:
Review URL: https://codereview.chromium.org/1229933003
2015-07-09 11:47:36 -07:00
msarett
ef46468063
Temporarily suppress valgrind errors in tip of tree libjpeg-turbo
...
BUG=skia:4030
Review URL: https://codereview.chromium.org/1231613004
2015-07-09 08:23:50 -07:00
mtklein
60c0475575
Add tools/flatten to flatten nested pictures in .skps.
...
Tested by running on skps/sp_desk_nytimes.skp.
The output .skp had no nested draw picture calls, and the files were both 9.3M.
BUG=skia:
Review URL: https://codereview.chromium.org/1221303020
2015-07-08 10:06:01 -07:00