Commit Graph

34463 Commits

Author SHA1 Message Date
Mike Reed
f4f06ada60 check for huge cubics in patchutils
Bug: oss-fuzz:6128
Change-Id: I4c7551ea2ac4e32dc96c93426846f5ddcd42a449
Reviewed-on: https://skia-review.googlesource.com/125440
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
2018-05-02 19:41:08 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
2af0904bf4 Roll skia/third_party/skcms 513d372..baef14c (1 commits)
https://skia.googlesource.com/skcms.git/+log/513d372..baef14c

2018-05-02 brianosman@google.com Add MakeUsableAsDestination to replace EnsureUsableAsDestination


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@google.com

Change-Id: I809f6e42977bea720c7dc7208c3fb9545cd66317
Reviewed-on: https://skia-review.googlesource.com/125382
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-02 19:27:48 +00:00
Khushal
38a0843688 fonts: Reland push font remoting.
This relands the following changes:
1) https://skia-review.googlesource.com/c/skia/+/120283
2) https://skia-review.googlesource.com/c/skia/+/125029
3) https://skia-review.googlesource.com/c/skia/+/125140

The original changes had to be reverted due to a memory leak in
SkBaseDevice from SkTextBlobCacheDiffCanvas. This has been addressed by
https://skia-review.googlesource.com/c/skia/+/125160

TBR=herb@google.com

Bug: skia:7515, 831354
Change-Id: I73f4fcb1c397f31bf01553ff48c71ed2d6dd0770
Reviewed-on: https://skia-review.googlesource.com/125326
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
Reviewed-by: Khusal Sagar <khushalsagar@chromium.org>
2018-05-02 18:39:31 +00:00
Mike Reed
81afc04b53 check for finite vertices
Bug: oss-fuzz:6115
Change-Id: Ib971304141322cfcf62ed079ef10c2910a9e2bf1
Reviewed-on: https://skia-review.googlesource.com/125343
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
2018-05-02 18:33:10 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
521af9b3b2 Roll third_party/externals/angle2/ 47155b171..78feddc28 (5 commits)
47155b1718..78feddc28a

$ git log 47155b171..78feddc28 --date=short --no-merges --format='%ad %ae %s'
2018-04-27 jmadill Vulkan: Take serials in PipelineDesc::updateShaders.
2018-04-30 jmadill Fix ASSERT macro generating extra code in MSVC.
2018-05-01 jmadill Vulkan: Use ShaderType enum.
2018-05-01 cwallez SystemInfo.h: add some documentation
2018-04-30 oetuaho Validate blitFramebuffer for overflows on all platforms

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=brianosman@google.com

Change-Id: Iced06ef8f5f271965ec2b0367168c71483242530
Reviewed-on: https://skia-review.googlesource.com/125329
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-02 18:31:30 +00:00
Mike Reed
e02d38af8b use SkLeftShift in case the first arg is negative
Bug: oss-fuzz:6117
Change-Id: I08521aaf4372a63428a1f663f4da78e72dfdf225
Reviewed-on: https://skia-review.googlesource.com/125344
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-05-02 18:03:38 +00:00
Mike Reed
1c2a5892f1 check for 0x8000 before calling abs
Bug: oss-fuzz:6124
Change-Id: I1897a4ce8f6e60bf93b9e6579725443763e8d287
Reviewed-on: https://skia-review.googlesource.com/125342
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
2018-05-02 17:47:38 +00:00
recipe-roller
2ea8470941 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/1037c743e33821d9aebda2624be4cc2a9a35c21d presubmit: Don't overwrite cwd when running tests. (ehmaldonado@chromium.org)
  https://crrev.com/6c692edf010ce9e43737406c53f399b13631ac4f Reland "bot_update: Set user.{name,email} when applying patch refs." (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1dd2e86a516f88e156b2b216bcbc241d291441cd
Reviewed-on: https://skia-review.googlesource.com/125291
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-02 17:06:37 +00:00
Herb Derby
12a021fedc Add the filter rec bypass to make canonical strike descriptors
SkDescriptors used describe strikes need to have a standard
form to pass them between on process and another. This change
allows a canonical form.

Change-Id: I451c74e4073b4e5d6de02f88cbd2ed5eb51cdad9
Reviewed-on: https://skia-review.googlesource.com/125340
Auto-Submit: Herb Derby <herb@google.com>
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
Reviewed-by: Khusal Sagar <khushalsagar@chromium.org>
2018-05-02 16:54:07 +00:00
Robert Phillips
f9ab22385e Modify SkGpuBlurUtils::GaussianBlur's reexpand method and allow more approx fit intermediates
This CL didn't cause and gm or skp image diffs locally but, since the backing fit is being changed in some cases, it is likely to do so on some bot.

Change-Id: I13decf44fb12e457951381bcc9c2c15103553a43
Reviewed-on: https://skia-review.googlesource.com/125225
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-05-02 15:20:17 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
162b20399b Roll skia/third_party/skcms 33bdf05..513d372 (1 commits)
https://skia.googlesource.com/skcms.git/+log/33bdf05..513d372

2018-05-02 mtklein@chromium.org list _all_ sources in BUILD.gn


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@google.com

Change-Id: Ib1c1f395221a350551f6e00979b31932536f9948
Reviewed-on: https://skia-review.googlesource.com/125322
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-02 15:16:08 +00:00
Herb Derby
fcac00f2f1 Reland "Remove devKerning"
This is a reland of c86c5c0144

Original change's description:
> Remove devKerning
> 
> Dev kerning is not supported by any scalers. This is
> mostly removed. The remaining fields fRsbDelta and
> fLsbDelta are kept to keep Android compiling.
> 
> Change-Id: If1a9ee9bb599d4e1bdf4b3751ac0c65246350809
> Reviewed-on: https://skia-review.googlesource.com/124921
> Reviewed-by: Ben Wagner <bungeman@google.com>
> Commit-Queue: Herb Derby <herb@google.com>

Change-Id: Ibf5fac5f1442c7e62392d5146ad460da27b10d5c
Reviewed-on: https://skia-review.googlesource.com/125300
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-05-02 15:15:08 +00:00
Herb Derby
efe39bcfb8 Take sk_sp<SkDevice> instead of SkDevice*
Change-Id: I0b296bf5b80adc19758a3dc99160be9d2ed05680
Reviewed-on: https://skia-review.googlesource.com/125160
Commit-Queue: Herb Derby <herb@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Auto-Submit: Herb Derby <herb@google.com>
2018-05-02 14:46:17 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
83e6a67b69 Roll skia/third_party/skcms a1c0fe6..33bdf05 (1 commits)
https://skia.googlesource.com/skcms.git/+log/a1c0fe6..33bdf05

2018-05-02 brianosman@google.com fit inverse parametric directly


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@google.com

Change-Id: I4f26e49327795ca6eef1bf3dc76a3029be83531b
Reviewed-on: https://skia-review.googlesource.com/125230
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-02 14:43:47 +00:00
Kevin Lubick
20331dea3f Add public repro instructions for repoducing fuzzers
No-Try: true
Docs-Preview: https://skia.org/?cl=125241
Bug: skia:
Change-Id: I5bf3409a0a7895e636a9b0c6845239bb17b42fa5
Reviewed-on: https://skia-review.googlesource.com/125241
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
2018-05-02 14:21:17 +00:00
Mike Klein
8a232023e1 Revert "fonts: Set up remote glyph caching to push fonts."
This reverts commit 101d56359a.

Reason for revert: 5 of 5

Original change's description:
> fonts: Set up remote glyph caching to push fonts.
> 
> Currently the SkStrikeClient is designed to pull fonts from the server
> on demand, and to pre-fetch a batched request by analyzing the ops using
> a SkTextBlobCacheDiffCanvas. This change modifies the design to support
> a push based model, where the server pushes fonts required by the client
> and sets up the requisite SkGlyphCaches on the client prior to
> rasterizing the ops.
> 
> This model still relies on the SkTextBlobCacheDiffCanvas for analyzing
> the glyphs required for rasterizing an op. The glyph caches required for
> raster are locked and missing glyphs to be sent to the client are tracked
> by the SkStrikeServer. The embedder can serialize this font data at any
> point, but must ensure that this data is deserialized by the
> SkStrikeClient at the remote end, before rasterizing any ops analyzed
> prior to serialization. Any refs on the caches are released once the
> font data is serialized by the server.
> 
> The locking of glyph caches relies on the embedder providing discardable
> handles. These handles can be created on the server and serialized to be
> sent to the client, and map to an instance of SkGlyphCache. This allows
> the server to control the lifetime of the caches on the client.
> 
> Bug: skia:7515
> Change-Id: Id39f346b47b60899778404bbd0429ee811d0e53b
> Reviewed-on: https://skia-review.googlesource.com/120283
> Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
> Reviewed-by: Herb Derby <herb@google.com>

TBR=mtklein@google.com,herb@google.com,khushalsagar@chromium.org

Change-Id: If72caf968ddcbf70b8b9d71782a2339a118ed202
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7515
Reviewed-on: https://skia-review.googlesource.com/125264
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-05-02 13:55:08 +00:00
Mike Klein
c76e26a6bb Revert "Remove devKerning"
This reverts commit c86c5c0144.

Reason for revert: 4 of 5

Original change's description:
> Remove devKerning
> 
> Dev kerning is not supported by any scalers. This is
> mostly removed. The remaining fields fRsbDelta and
> fLsbDelta are kept to keep Android compiling.
> 
> Change-Id: If1a9ee9bb599d4e1bdf4b3751ac0c65246350809
> Reviewed-on: https://skia-review.googlesource.com/124921
> Reviewed-by: Ben Wagner <bungeman@google.com>
> Commit-Queue: Herb Derby <herb@google.com>

TBR=bungeman@google.com,herb@google.com,reed@google.com

Change-Id: If865f702868192a1b72cd811baa996dd1282bbce
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/125263
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-05-02 13:54:54 +00:00
Mike Klein
78a9aed075 Revert "fonts: Dont memcpy with nullptr in SkRemoteGlyphCache"
This reverts commit 7e7369f713.

Reason for revert: 3 of 5

Original change's description:
> fonts: Dont memcpy with nullptr in SkRemoteGlyphCache
> 
> The behaviour is undefined and causes ASAN bots to complain.
> 
> Bug: skia:7515
> Change-Id: I454714ab9047a6fced5ab7bfdbc12214d728eadf
> Reviewed-on: https://skia-review.googlesource.com/125029
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>

TBR=herb@google.com,brianosman@google.com,khushalsagar@chromium.org

Change-Id: I6548019d7bf34b38f964234034e58af09d0b8508
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7515
Reviewed-on: https://skia-review.googlesource.com/125262
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-05-02 13:54:40 +00:00
Mike Klein
192b18a261 Revert "fonts: Bandaid fix for desc mismatch in SkRemoteGlyphCache."
This reverts commit ef4142a9bc.

Reason for revert: 2 of 5

Original change's description:
> fonts: Bandaid fix for desc mismatch in SkRemoteGlyphCache.
> 
> Since the typeface proxies on the client don't perform the same
> filtering done on the server during SkDescriptor generation, it causes
> the desc mismatches during raster. Disable this filtering on the server
> until this is resolved.
> 
> Bug: 831354
> Change-Id: I5683372fb497a4874dede5aec9c734cd1392872c
> Reviewed-on: https://skia-review.googlesource.com/125140
> Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
> Reviewed-by: Herb Derby <herb@google.com>

TBR=herb@google.com,khushalsagar@chromium.org

Change-Id: I8e732f57aa49323c186e3c4ea6120ff1caf8e25b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 831354
Reviewed-on: https://skia-review.googlesource.com/125261
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-05-02 13:53:18 +00:00
Mike Klein
bffeb8cbf6 Revert "Add padding back to make msan happy"
This reverts commit 2050565fe1.

Reason for revert: 1 of 5

Original change's description:
> Add padding back to make msan happy
> 
> SkGlyph are stored directly in the hash table with uninitialized
> pad bytes. When the hash table is resized, the uninitialized pad
> bytes are moved causing msan to complain.
> 
> Change-Id: I559ff1bd369d12be061cce7d3c826c2afdd3a03c
> Reviewed-on: https://skia-review.googlesource.com/125240
> Commit-Queue: Herb Derby <herb@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>
> Auto-Submit: Herb Derby <herb@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,herb@google.com

Change-Id: Iaa61ad17c837544bd7394ddc6fc52c14d8389d7e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/125260
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-05-02 13:53:08 +00:00
Herbert Derby
2050565fe1 Add padding back to make msan happy
SkGlyph are stored directly in the hash table with uninitialized
pad bytes. When the hash table is resized, the uninitialized pad
bytes are moved causing msan to complain.

Change-Id: I559ff1bd369d12be061cce7d3c826c2afdd3a03c
Reviewed-on: https://skia-review.googlesource.com/125240
Commit-Queue: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-05-02 12:30:47 +00:00
Robert Phillips
eaded9d09c Fix DDL blur image filter
This fixes on of the DDL render problems in the imageblurclampmode GM.

Bug: skia:7765
Change-Id: I2d6779183cd47b63b47f9f071c2266643d222feb
Reviewed-on: https://skia-review.googlesource.com/125000
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-05-02 11:47:17 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
3fef39d94d Roll third_party/externals/angle2/ 57d9cbb67..47155b171 (1 commit)
57d9cbb67f..47155b1718

$ git log 57d9cbb67..47155b171 --date=short --no-merges --format='%ad %ae %s'
2018-04-26 oetuaho Clean up BlitGL

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=brianosman@google.com

Change-Id: I1a104ea22dc9f2e406099d8c06129420157223de
Reviewed-on: https://skia-review.googlesource.com/125221
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-02 09:25:07 +00:00
Khushal
ef4142a9bc fonts: Bandaid fix for desc mismatch in SkRemoteGlyphCache.
Since the typeface proxies on the client don't perform the same
filtering done on the server during SkDescriptor generation, it causes
the desc mismatches during raster. Disable this filtering on the server
until this is resolved.

Bug: 831354
Change-Id: I5683372fb497a4874dede5aec9c734cd1392872c
Reviewed-on: https://skia-review.googlesource.com/125140
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
2018-05-01 22:55:37 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
1b97b860b0 Roll third_party/externals/angle2/ ad3aaeba3..57d9cbb67 (4 commits)
ad3aaeba3e..57d9cbb67f

$ git log ad3aaeba3..57d9cbb67 --date=short --no-merges --format='%ad %ae %s'
2018-04-27 jmadill Sync individual attachments in RenderTargetCache.
2018-04-27 jmadill Vulkan: Add framework for internal shaders.
2018-05-01 lucferron Refactor StateChangeTests to use essl1_shaders instead
2018-04-23 lucferron Vulkan: Create tests to validate we created the pipeline when needed

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=brianosman@google.com

Change-Id: I638532043015b34b8062a15491c43a7c23d53662
Reviewed-on: https://skia-review.googlesource.com/125181
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-01 22:52:47 +00:00
Herb Derby
c86c5c0144 Remove devKerning
Dev kerning is not supported by any scalers. This is
mostly removed. The remaining fields fRsbDelta and
fLsbDelta are kept to keep Android compiling.

Change-Id: If1a9ee9bb599d4e1bdf4b3751ac0c65246350809
Reviewed-on: https://skia-review.googlesource.com/124921
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-05-01 21:12:15 +00:00
Ben Wagner
0f91bb874d Correct precondition for SDF mask format.
When creating an SDF glyph the mask format of the underlying glyph must
be A1 or A8. Currently the code just checks for ~ARGB, but LCD16, 3D,
and any other possible mask formats are also unsupported.

Change-Id: I092a18828742dddfc93687eabd9858186605fc96
Reviewed-on: https://skia-review.googlesource.com/125083
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-05-01 20:52:05 +00:00
Khushal
7e7369f713 fonts: Dont memcpy with nullptr in SkRemoteGlyphCache
The behaviour is undefined and causes ASAN bots to complain.

Bug: skia:7515
Change-Id: I454714ab9047a6fced5ab7bfdbc12214d728eadf
Reviewed-on: https://skia-review.googlesource.com/125029
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
2018-05-01 20:07:45 +00:00
Brian Salomon
3fc6a185ca Fix index overflow check for rewriting fans as triangles.
Not only could the old test cause int overflow, it was just wrong.

Bug: skia:8085
Change-Id: Id6b81f4aa1b115f0dbfd2266aee8fab5d5d30aee
Reviewed-on: https://skia-review.googlesource.com/124779
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-05-01 19:58:45 +00:00
Mike Klein
91368c9b9b Revert "Retry enabling skcms on Android"
This reverts commit 05b5e40519.

Reason for revert:

	BitmapColorSpaceTest.android.graphics.cts.BitmapColorSpaceTest.inColorSpaceP3ToSRGB (android.graphics.cts) 	06.949
 java.lang.AssertionError: expected:<67043583> but was:<117375231>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:645)
	at org.junit.Assert.assertEquals(Assert.java:631)
	at android.graphics.cts.BitmapColorSpaceTest.verifyGetPixel(BitmapColorSpaceTest.java:301)
	at android.graphics.cts.BitmapColorSpaceTest.inColorSpaceP3ToSRGB(BitmapColorSpaceTest.java:612)
	at java.lang.reflect.Method.invoke(Native Method)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:148)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:142)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.lang.Thread.run(Thread.java:764)

>>> hex(117375231)
'0x6ff00ff'
>>> hex(67043583)
'0x3ff00ff'

Original change's description:
> Retry enabling skcms on Android
> 
> Since we tried this last, DM has a direct skcms dependency
> via tests/ColorSpaceTest.cpp, so I've rearranged gn_to_bp.py slightly.
> 
> We need to keep our eyes out for BitmapRGBAF16Test.testGetPixel in CTS.
> 
> Change-Id: I3630bbebb4574522c43362c359d1a14da3bdd480
> Reviewed-on: https://skia-review.googlesource.com/124720
> Commit-Queue: Mike Klein <mtklein@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>

TBR=mtklein@chromium.org,mtklein@google.com,brianosman@google.com

Change-Id: Ib11393c427e9c5fea645de6e6e9a3034dcf06d02
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/125041
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-05-01 18:57:06 +00:00
Brian Salomon
763abf0164 Revert "Use a cached index buffer for triangle fans in GrDefaultPathRenderer."
This reverts commit ddff425b0a.

Reason for revert: bad gms

Original change's description:
> Use a cached index buffer for triangle fans in GrDefaultPathRenderer.
> 
> Change-Id: I3c3c8db6506c71e4b273c8bc7adcc68d3d768626
> Reviewed-on: https://skia-review.googlesource.com/124841
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>

TBR=bsalomon@google.com,brianosman@google.com

Change-Id: I701b55f188c949c2ee39b39f9bbf5b233f80f174
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/125040
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-05-01 18:49:46 +00:00
Khushal
101d56359a fonts: Set up remote glyph caching to push fonts.
Currently the SkStrikeClient is designed to pull fonts from the server
on demand, and to pre-fetch a batched request by analyzing the ops using
a SkTextBlobCacheDiffCanvas. This change modifies the design to support
a push based model, where the server pushes fonts required by the client
and sets up the requisite SkGlyphCaches on the client prior to
rasterizing the ops.

This model still relies on the SkTextBlobCacheDiffCanvas for analyzing
the glyphs required for rasterizing an op. The glyph caches required for
raster are locked and missing glyphs to be sent to the client are tracked
by the SkStrikeServer. The embedder can serialize this font data at any
point, but must ensure that this data is deserialized by the
SkStrikeClient at the remote end, before rasterizing any ops analyzed
prior to serialization. Any refs on the caches are released once the
font data is serialized by the server.

The locking of glyph caches relies on the embedder providing discardable
handles. These handles can be created on the server and serialized to be
sent to the client, and map to an instance of SkGlyphCache. This allows
the server to control the lifetime of the caches on the client.

Bug: skia:7515
Change-Id: Id39f346b47b60899778404bbd0429ee811d0e53b
Reviewed-on: https://skia-review.googlesource.com/120283
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
2018-05-01 18:15:15 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
e618eee833 Roll skia/third_party/skcms f504cf9..a1c0fe6 (1 commits)
https://skia.googlesource.com/skcms.git/+log/f504cf9..a1c0fe6

2018-05-01 brianosman@google.com Change sRGB and XYZD50 profiles to functions


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=brianosman@google.com

Change-Id: Id82608eebccc9bfd020495f303bee39d1a38b1b7
Reviewed-on: https://skia-review.googlesource.com/125023
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-01 18:06:35 +00:00
Brian Osman
0ab0f1c120 Convert skcms to only export functions (not data)
This simplifies shared library builds on Windows (no need to
conditionally change declspec to dllimport).

Once this lands, we can make the same change (plus update
internal references):
    https://skia-review.googlesource.com/c/skcms/+/124982

Change-Id: I0d4fa9031258f77d370e6e6e018afaf543c29d85
Reviewed-on: https://skia-review.googlesource.com/124983
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-05-01 17:42:35 +00:00
Kevin Lubick
e467d4e656 Update all remaining Chromebooks to m67
Bug: skia:
Change-Id: Ice96cc476b8f022fea250c88c1ec16de6482c704
Reviewed-on: https://skia-review.googlesource.com/124984
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-05-01 17:37:34 +00:00
recipe-roller
abd51ad92a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/166bc4ceedaf972ed01b8ea5cb5f453e4b7e2f18 Add mojom and fidl files to DEFAULT_WHITE_LIST (sergeyu@chromium.org)
  https://crrev.com/1eb58e1f8892bdc23060b37265ef4941de3965ba Add a recipe config to enable the bot_update "--with_tags" flag. (mmoss@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I793d171d7bc1ba6ab886ccde42eab2e07197c235
Reviewed-on: https://skia-review.googlesource.com/124980
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-05-01 17:32:14 +00:00
Mike Reed
e102016fef handle non-a8 masks in coverage blitter
Bug: skia:7885
Change-Id: I3ae2d3c7a762d3d718b9a6d40d8c1d696b6aaefc
Reviewed-on: https://skia-review.googlesource.com/124923
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-05-01 17:28:34 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
1ac818cb54 Roll skia/third_party/skcms fdc6366..f504cf9 (1 commits)
https://skia.googlesource.com/skcms.git/+log/fdc6366..f504cf9

2018-05-01 mtklein@chromium.org check full round-tripped index for inf/overflow


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=brianosman@google.com

Change-Id: I8d2d9cd074deb2f21b501d6008ca50798bda8e65
Reviewed-on: https://skia-review.googlesource.com/124832
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-01 17:11:34 +00:00
Brian Salomon
ddff425b0a Use a cached index buffer for triangle fans in GrDefaultPathRenderer.
Change-Id: I3c3c8db6506c71e4b273c8bc7adcc68d3d768626
Reviewed-on: https://skia-review.googlesource.com/124841
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-05-01 16:54:45 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
f8da8e59a4 Roll skia/third_party/skcms 8cf2d2c..fdc6366 (1 commits)
https://skia.googlesource.com/skcms.git/+log/8cf2d2c..fdc6366

2018-05-01 mtklein@chromium.org increase test TF dump by a digit


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=brianosman@google.com

Change-Id: Ic031ad3e0075124405decd9eb2796ece2fe474b6
Reviewed-on: https://skia-review.googlesource.com/124829
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-01 16:46:16 +00:00
Mike Klein
05b5e40519 Retry enabling skcms on Android
Since we tried this last, DM has a direct skcms dependency
via tests/ColorSpaceTest.cpp, so I've rearranged gn_to_bp.py slightly.

We need to keep our eyes out for BitmapRGBAF16Test.testGetPixel in CTS.

Change-Id: I3630bbebb4574522c43362c359d1a14da3bdd480
Reviewed-on: https://skia-review.googlesource.com/124720
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-05-01 16:40:44 +00:00
Mike Reed
dc3192b30a pin offset request before applying to region
Bug: oss-fuzz:8085
Change-Id: I2e19250822a6ffc3d68a474c8eb4cca0ea66c991
Reviewed-on: https://skia-review.googlesource.com/124700
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-05-01 15:29:14 +00:00
Kevin Lubick
ff8387fae4 Update SamsungChromebook2012 to m67
Bug: skia:
Change-Id: Icf90148fadb2293c300962bdf3551c0a9cf1aee0
Reviewed-on: https://skia-review.googlesource.com/124811
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-05-01 15:12:34 +00:00
Cary Clark
3155d9c912 Revert "remove obsolete color defines"
This reverts commit 8afbecbcc0.

Reason for revert: broke pdfium

Original change's description:
> remove obsolete color defines
> 
> The uses in Skia, Chrome, and Google3 have already
> been removed. If I missed one or more, please let
> me know (and feel free to revert).
> 
> TBR=reed@google.com,brianosman@google.com
> Bug: skia:6898
> Change-Id: I9d15b1a06f5abfc3a0fc6f3f1b4d348916c3d362
> Reviewed-on: https://skia-review.googlesource.com/124840
> Reviewed-by: Cary Clark <caryclark@skia.org>
> Commit-Queue: Cary Clark <caryclark@skia.org>
> Auto-Submit: Cary Clark <caryclark@skia.org>

TBR=brianosman@google.com,reed@google.com,caryclark@skia.org

Change-Id: Ic7c1003261cda5dee80e222da123c6717b4ea707
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:6898
Reviewed-on: https://skia-review.googlesource.com/124880
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
2018-05-01 15:00:55 +00:00
Florin Malita
41dff6ef68 [skottie] Add support for round-corners geometry effects
TBR=
Change-Id: I5505561df28d5953526662d60fe2300cb112bc37
Reviewed-on: https://skia-review.googlesource.com/124769
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-05-01 14:54:14 +00:00
Cary Clark
8afbecbcc0 remove obsolete color defines
The uses in Skia, Chrome, and Google3 have already
been removed. If I missed one or more, please let
me know (and feel free to revert).

TBR=reed@google.com,brianosman@google.com
Bug: skia:6898
Change-Id: I9d15b1a06f5abfc3a0fc6f3f1b4d348916c3d362
Reviewed-on: https://skia-review.googlesource.com/124840
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
2018-05-01 14:29:44 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
aa03bd93b7 Roll third_party/externals/angle2/ ddd772455..ad3aaeba3 (1 commit)
ddd772455c..ad3aaeba3e

$ git log ddd772455..ad3aaeba3 --date=short --no-merges --format='%ad %ae %s'
2018-05-01 jmadill Disable Vulkan layers in sanitized builds.

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=brianosman@google.com

Change-Id: I0dbb3641601eb8be1806146ea92ef5ee0e593db6
Reviewed-on: https://skia-review.googlesource.com/124821
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-01 13:48:34 +00:00
Kevin Lubick
e114e59f37 Update MaliT764 Chromebooks
Bug: skia:
NOTRY=true
Change-Id: I739e3596e1266df6c533f552b5583de2a5f5f9f5
Reviewed-on: https://skia-review.googlesource.com/124808
Reviewed-by: Eric Boren <borenet@google.com>
2018-05-01 13:17:48 +00:00
Robert Phillips
4912d903b9 Alter the decimation portion of Ganesh's GaussianBlur method
This CL doesn't change any GMs for me locally but (because of the backingFit and clipRect changes) it has the possibility of doing so.

Change-Id: Iaa1ad9baf420624d118bf1b12d8bac726218274d
Reviewed-on: https://skia-review.googlesource.com/124283
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-05-01 11:59:14 +00:00
Florin Malita
c353ee211f [skottie] Power-reduce paths (cubicTo -> lineTo)
For straight lines, Lottie exports control points conincident with the
vertices.  We can detect this case and emit more efficient lineTo's.

One wrinkle: we can only apply this power-reduction post-interpolation
(otherwise the path verbs and point count would not be guaranteed to
match).  Hence we store explicit shape data and defer the SkPath
conversion.

TBR=

Change-Id: I7818be464eabee6096d2078440843243a55c6e98
Reviewed-on: https://skia-review.googlesource.com/124800
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-05-01 02:27:34 +00:00