Commit Graph

34463 Commits

Author SHA1 Message Date
Ben Wagner
4c9b700bb5 Run only canonical configs for 32-bit Test tasks.
https://skia-review.googlesource.com/c/skia/+/127325 added a couple new
configs that caused 32-bit MSVC Test bots to be quite a bit slower.
After discussion with mtklein, we probably only want to add the more
esoteric configs for 64-bit GCE bots.

No-Try: true
Change-Id: I04e78679c43b380173dce1ea718df5d897e875b7
Reviewed-on: https://skia-review.googlesource.com/128180
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
2018-05-15 19:44:13 +00:00
Ben Wagner
ecd35c16ef Remove non-smart SkFontConfigInterface::SetGlobal.
This method is no longer used and is superseded by the 'smart' version.

Change-Id: Ic27545a2ec2666d77966727630ba7e960eac5506
Reviewed-on: https://skia-review.googlesource.com/128316
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-05-15 19:42:13 +00:00
Eric Boren
0f69010549 [recipes] BUILDTYPE and SKIA_OUT are no longer used
Bug: skia:6473
Change-Id: I67b0dbf6dba26233df1d8e44f3e2f69ca0cc9d3e
Reviewed-on: https://skia-review.googlesource.com/128320
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-15 19:36:23 +00:00
Ravi Mistry
5ab841f18b Add chromium first to .gclient
Bug: skia:7917
Change-Id: Ie76c73c5b8ea24ca0ac54e79ad7597fdac19d860
Reviewed-on: https://skia-review.googlesource.com/128011
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-05-15 19:28:43 +00:00
Ben Wagner
a588de1fee Revert "Remove non-smart SkFontConfigInterface::SetGlobal."
This reverts commit 31aa27da9d.

Reason for revert: breaks a build and forgot to remove declaration

Original change's description:
> Remove non-smart SkFontConfigInterface::SetGlobal.
> 
> This method is no longer used and is superseded by the 'smart' version.
> 
> Change-Id: I491dda095224d443d184e8d73b36b1328227c99e
> Reviewed-on: https://skia-review.googlesource.com/128312
> Reviewed-by: Herb Derby <herb@google.com>
> Commit-Queue: Ben Wagner <bungeman@google.com>

TBR=bungeman@google.com,herb@google.com

Change-Id: Ie0fb3dc055d01cf7e3a4ec83fb92de33c07a7f58
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/128360
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-05-15 19:12:55 +00:00
Ben Wagner
31aa27da9d Remove non-smart SkFontConfigInterface::SetGlobal.
This method is no longer used and is superseded by the 'smart' version.

Change-Id: I491dda095224d443d184e8d73b36b1328227c99e
Reviewed-on: https://skia-review.googlesource.com/128312
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-05-15 18:58:53 +00:00
Adrienne Walker
0e38394ffc Reland "Driver bug workaround: disable_discard_framebuffer"
This is a reland of f31fece658

Original change's description:
> Driver bug workaround: disable_discard_framebuffer
>
> Bug: chromium: 829614
> Change-Id: I285b39b31a370247518e3a0b56ac4ea54f38c0c0
> Reviewed-on: https://skia-review.googlesource.com/126749
> Commit-Queue: Adrienne Walker <enne@chromium.org>
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Auto-Submit: Adrienne Walker <enne@chromium.org>
> Reviewed-by: Brian Salomon <bsalomon@google.com>

Bug: chromium: 829614
Change-Id: I6cc2de11a6315ff224c90551e8dd3e1d1dd4139a
Reviewed-on: https://skia-review.googlesource.com/128108
Commit-Queue: Adrienne Walker <enne@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Adrienne Walker <enne@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-05-15 18:58:23 +00:00
Adrienne Walker
683148419e Reland "Driver bug workaround: disable_blend_equation_advanced"
This is a reland of f31fece658

Original change's description:
> Driver bug workaround: disable_blend_equation_advanced
>
> Bug: chromium: 829614
> Change-Id: If8eaec6d22412ec36aad8a143f84080be05f2926
> Reviewed-on: https://skia-review.googlesource.com/126748
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Adrienne Walker <enne@chromium.org>

Bug: chromium: 829614
Change-Id: Idd36ff90a99336521ef5d47f0d7baf079c1bda09
Reviewed-on: https://skia-review.googlesource.com/128107
Commit-Queue: Adrienne Walker <enne@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Adrienne Walker <enne@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-05-15 18:09:43 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
6e9f34f0e0 Roll third_party/externals/angle2/ 74a763205..2a849bf31 (10 commits)
74a763205a..2a849bf311

$ git log 74a763205..2a849bf31 --date=short --no-merges --format='%ad %ae %s'
2018-05-10 lucferron Vulkan: Pre-work for copyImage/copySubImage features
2018-05-15 geofflang Add more dEQP EGL expectations for Linux and Android.
2018-05-14 jmadill dEQP: Clean up some style in gTest source.
2018-05-14 geofflang Add more dEQP EGL expectations for Linux and Android.
2018-05-14 geofflang Add more dEQP EGL expectations for Linux and Android.
2018-05-14 cwallez DisplayGLX: Close the X display if we own it.
2018-05-14 geofflang Add more dEQP EGL expectations for Linux and Android.
2018-05-14 geofflang DEQP: Print not supported messages from tests.
2018-05-14 geofflang Add dEQP EGL test expectations for Linux and Android.
2018-05-10 jmadill Vulkan: Implement masked color clear with depth.

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=herb@google.com

Change-Id: Ib683c6fc13b5ad9d15ce0cadc0b88da7f70bbb86
Reviewed-on: https://skia-review.googlesource.com/128289
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-15 17:19:43 +00:00
Kevin Lubick
22711cfd91 Add preflight checks for SkImage deserialization
Bug: skia:7937
Change-Id: Ia6d8eeeeaf9ea38df7e4f78b23598a66142bf8de
Reviewed-on: https://skia-review.googlesource.com/128301
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-05-15 17:15:23 +00:00
Mike Klein
852a8cb1f0 switch skia to use skcms.gni
On the road to removing skcms/BUILD.gn,
and making configuring skcms a little less inside-out.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Change-Id: I3c37c019bbc32a6112d329429f906b3d8b7f0d19
Reviewed-on: https://skia-review.googlesource.com/128304
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-05-15 16:06:13 +00:00
Brian Osman
64a1d4a7fc Roll third_party/externals/angle2/ 5d2ccc534..a00ef3144 (10 commits)
Manual roll including GN fixes

5d2ccc534d..a00ef3144f

$ git log 5d2ccc534..a00ef3144 --date=short --no-merges --format='%ad %ae %s'
2018-05-14 geofflang Add more dEQP EGL expectations for Linux and Android.
2018-05-14 geofflang Add more dEQP EGL expectations for Linux and Android.
2018-05-14 cwallez DisplayGLX: Close the X display if we own it.
2018-05-14 geofflang Add more dEQP EGL expectations for Linux and Android.
2018-05-14 geofflang DEQP: Print not supported messages from tests.
2018-05-14 geofflang Add dEQP EGL test expectations for Linux and Android.
2018-05-10 jmadill Vulkan: Implement masked color clear with depth.
2018-05-14 jmadill Fix libGLESv2 wrong .def file.
2018-05-14 jmadill Fix warnings from size_t conversions.
2018-04-23 lfy GLES1: Renderer (minimal)

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=herb@google.com

Change-Id: I0ed2b9c8824b7833a4a0234204cb849805717daa
Reviewed-on: https://skia-review.googlesource.com/128322
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-05-15 15:59:23 +00:00
Ben Wagner
44a9d5726d Mark SkFontMgr_FCI methods as not implmented.
The SkFontMgr_FCI class is an attempt at transitioning off of
SkFontConfigInterface to SkFontMgr. However, since SkFontMgr_FCI must
wrap a SkFontConfigInterface it is limited in what parts of the
SkFontMgr interface it can actually implement. This CL marks the
unimplemented methods with SK_ABORT("Not implemented.") to make this
explicit.

Change-Id: I3ee1a0af549ac2257bc7098d6367db00a108e3ed
Reviewed-on: https://skia-review.googlesource.com/128340
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-05-15 15:41:53 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
12a9c45503 Roll skia/third_party/skcms 28e8b32..14c31bf (6 commits)
https://skia.googlesource.com/skcms.git/+log/28e8b32..14c31bf

2018-05-15 mtklein@chromium.org temporarily turn on SKCMS_LEGACY_POWF for GN builds
2018-05-15 mtklein@chromium.org spin sources list out of BUILD.gn
2018-05-14 mtklein@chromium.org Reland "remove loop in powf"
2018-05-14 mtklein@chromium.org Revert "remove loop in powf"
2018-05-14 brianosman@google.com Adjust fuzzers to test against parametric approximated tables
2018-05-14 mtklein@chromium.org remove loop in powf


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com

Change-Id: I0ff3903370a7c07ce7e194ab44c35ff546b7f973
Reviewed-on: https://skia-review.googlesource.com/128284
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-15 15:38:17 +00:00
Ben Wagner
f169e1f81f SkSharedMutex::acquire to check thread state.
This makes SkSharedMutex::acquire() assert if a thread has already
acquired a shared lock.

Change-Id: I35a186a137b9efcad1132093e1bb18c8822e1538
Reviewed-on: https://skia-review.googlesource.com/128160
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2018-05-15 14:59:53 +00:00
Mike Reed
81f60ecd9c Allow slides/gms to extend the UI
Bug: skia:
Change-Id: Ia5971d827e6e05ab6cc30af3105b3b32ee691a34
Reviewed-on: https://skia-review.googlesource.com/128321
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-05-15 14:29:43 +00:00
swiftshader-skia-autoroll
6bbd386a0e Roll third_party/externals/swiftshader/ 2a0def7f6..e475674ef (1 commit)
https://swiftshader.googlesource.com/SwiftShader/+log/2a0def7f6f20..e475674ef6e1

$ git log 2a0def7f6..e475674ef --date=short --no-merges --format='%ad %ae %s'
2018-05-10 krzysio Implement OES_vertex_array_object.

Created with:
  roll-dep third_party/externals/swiftshader


The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader
TBR=herb@google.com

Change-Id: I20381cba754b2d1b3f44651cdd3e7ec6296b329a
Reviewed-on: https://skia-review.googlesource.com/128201
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-15 00:30:49 +00:00
Adrienne Walker
ab7181daad Reland "Add driver bug workarounds to GrCaps"
This is a reland of 328490c6a1

Original change's description:
> Add driver bug workarounds to GrCaps
> 
> This moves GrDriverBugWorkarounds to include so that it can be included
> by GrCaps.  This also makes GrContextOptions a nearly empty class in
> the case of !SK_SUPPORT_GPU so that non-gpu builds don't need to build
> in GrDriverBugWorkarounds.cpp.
> 
> Bug: chromium: 829614
> Change-Id: Iedf73677fd09e9a487cfe618a696fd4b25c8703d
> Reviewed-on: https://skia-review.googlesource.com/126581
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Adrienne Walker <enne@chromium.org>

Bug: chromium: 829614
Change-Id: I7b539f99caa3032c8c595dd5068dc3b179747ccd
Reviewed-on: https://skia-review.googlesource.com/127304
Commit-Queue: Adrienne Walker <enne@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-05-14 23:46:49 +00:00
Florin Malita
3b9effcb1d [skottie] Sanitize polystar point counts
- limit the maximum number of points
- round instead of trunc (more accurate when interpolating)
- reserve the path verb/pts space upfront

Bug: oss-fuzz:8223
Change-Id: Ib6fb83e56c05b16e292789be81f1a48a9c529211
Reviewed-on: https://skia-review.googlesource.com/128017
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-05-14 21:41:39 +00:00
Mike Reed
026d20f888 handle huge normalize requests (including non-finite x or y)
Bug: oss-fuzz:8023
Change-Id: I622b6e335d9efbe599fa9047b3a6fcee1664aa4a
Reviewed-on: https://skia-review.googlesource.com/124581
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-05-14 21:14:09 +00:00
Brian Salomon
0cdfc32058 Make drawBitmap[Rect]() use GrTextureOp
Change-Id: If2a81bd0fdef9a91475828a6abf5c3d3ba456b5d
Reviewed-on: https://skia-review.googlesource.com/128140
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-05-14 20:54:09 +00:00
Herb Derby
8fb2e5c399 Centralize UTFN code point counting
Change-Id: Ifd6bdcb4ac88452ab01124777168b140cae965a9
Reviewed-on: https://skia-review.googlesource.com/128014
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-05-14 20:18:19 +00:00
Mike Reed
84f7c2b3c1 share impl for setlength
Bug: skia:
Change-Id: I7d137547674d1352f38935504fd6f75cc7d7286f
Reviewed-on: https://skia-review.googlesource.com/128007
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-05-14 20:14:19 +00:00
Mike Klein
77bc821b03 asan_device_setup has moved
Change-Id: I9d9d34f1b663a06605eddeacd945517c3e880f4f
Reviewed-on: https://skia-review.googlesource.com/128016
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-05-14 19:44:40 +00:00
Brian Salomon
3d945e840c Clear temp buffer in GrContextPriv::readSurfacePixels2
This fixes an issue on Chrome's MSAN bots where glReadPixels into the
temp buffer doesn't actually overwrite the buffer.

Change-Id: I9cbdd208d3bdd0d53e96bbef1996648a3a21f66f
Reviewed-on: https://skia-review.googlesource.com/128013
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-05-14 19:39:39 +00:00
Ben Wagner
a20681c2ac Move SkFontConfigInterface to smart pointers.
This old interface may be easier to move away from if it isn't so
difficult to understand.

Change-Id: Ib04b00e55fd5c11aca8cc70bc6c7b0b5ba98dcae
Reviewed-on: https://skia-review.googlesource.com/127969
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-05-14 19:25:10 +00:00
Mike Klein
8803ebb470 update to NDK r17
We haven't done this in a while.

The only interesting change I've noticed so far is that we no longer
need to link libandroid_support when targeting API 21+.

Change-Id: I6506fbe7bd02534f1ea136f2164acab7f44c29e0
Reviewed-on: https://skia-review.googlesource.com/128009
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-05-14 18:48:19 +00:00
Yuqian Li
45a6d7159e Avoid dividing by zero in SkTwoPointConicalGradient::Create
Bug: oss-fuzz:6146 oss-fuzz:7474
Change-Id: I5f0488f4572140ccb7b9374bc9a66b8ae81dd2d4
Reviewed-on: https://skia-review.googlesource.com/127990
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Yuqian Li <liyuqian@google.com>
2018-05-14 18:27:09 +00:00
Mike Reed
9236b02264 Revert "Revert "implement SkScalar versions in terms of float versions""
This reverts commit 0e6db75eeb.

Bug: skia:
Change-Id: I015d01efc58dfe03dae6bcc57c4b1102276e7566
Reviewed-on: https://skia-review.googlesource.com/127967
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-05-14 18:20:29 +00:00
Eric Boren
9030b94c60 [recipes] Separate build and test flavors
Bug: skia:6473
Change-Id: If1d6e1f64ec53624e7b540abd9d8a61cc82c4e0a
Reviewed-on: https://skia-review.googlesource.com/125947
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-14 17:27:49 +00:00
Ben Wagner
297e86b43e [infra] Switch back to 16-core GCE VMs for Perf and Test.
This partially reverts
https://skia-review.googlesource.com/c/skia/+/124340

Bug: skia:7415, skia:7416
Change-Id: I2a838ff3c543ded54e962e905294811fbc97ef88
Reviewed-on: https://skia-review.googlesource.com/127965
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-05-14 17:14:19 +00:00
Ben Wagner
8f2b7fa617 Correctly handle empty outer blurs.
Most blur styles approach the original mask as the sigma goes to zero.
The outer style however approaches nothing as the mask sigma goes to
zero. Handle this case correctly.

Change-Id: I14f76e144d7cfc78aeaff30ff5444a21f1e5f98b
Reviewed-on: https://skia-review.googlesource.com/128006
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-05-14 16:59:29 +00:00
Mike Reed
0e6db75eeb Revert "implement SkScalar versions in terms of float versions"
This reverts commit 4c3cb3767f.

Reason for revert: investigate asan failures

Original change's description:
> implement SkScalar versions in terms of float versions
> 
> Bug: skia:
> Change-Id: I44ce228290f7fda5b7e3553c8543dcf581b1ca3b
> Reviewed-on: https://skia-review.googlesource.com/127128
> Reviewed-by: Cary Clark <caryclark@google.com>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=caryclark@google.com,reed@google.com

Change-Id: Ic790b15130a67f46a0a99fdf991c5c08d682be5e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/128060
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-05-14 16:05:20 +00:00
Jim Van Verth
8c2de8f76b Merge duplicate umbra points in spot shadow.
When we search for the closest umbra point at the end of the shadow
creation process, we often find the umbra point we first added.
Previously we would add this point again and patch up the result.
This is causing issues with fixing the falloff, so this code handles
this case better by reusing the original entry in fPositions.

Bug: skia:6717
Change-Id: Ic44396f9430ecca8c67f06a6ffb37aae5a38c93b
Reviewed-on: https://skia-review.googlesource.com/127964
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-05-14 15:53:49 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
16ffdd4ede Roll third_party/externals/angle2/ 66aafcb46..5d2ccc534 (1 commit)
66aafcb464..5d2ccc534d

$ git log 66aafcb46..5d2ccc534 --date=short --no-merges --format='%ad %ae %s'
2018-05-14 hans Use DefWindowProcA for window created with CreateWindowExA

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=herb@google.com

Change-Id: Ida170b47ce098088bef12af3b0ff8e4bc00e8520
Reviewed-on: https://skia-review.googlesource.com/127983
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-14 15:26:19 +00:00
Ben Wagner
d81097e45d Don't set luminance color if not used in MakeRecAndEffects.
Luminanace values should only be set if the luminance value will be used.

This also moves the rest of SkScalerContext into SkScalerContext.cpp.
Change-Id: I339ac5e6437cc7ee0d3aba81a1c1a77f5cb0b20b
Reviewed-on: https://skia-review.googlesource.com/127742
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-05-14 15:14:29 +00:00
Mike Reed
4c3cb3767f implement SkScalar versions in terms of float versions
Bug: skia:
Change-Id: I44ce228290f7fda5b7e3553c8543dcf581b1ca3b
Reviewed-on: https://skia-review.googlesource.com/127128
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-05-14 14:17:59 +00:00
swiftshader-skia-autoroll
31ed9ebf98 Roll third_party/externals/swiftshader/ 5fd1cfaae..2a0def7f6 (1 commit)
https://swiftshader.googlesource.com/SwiftShader/+log/5fd1cfaaeaa4..2a0def7f6f20

$ git log 5fd1cfaae..2a0def7f6 --date=short --no-merges --format='%ad %ae %s'
2018-05-14 sugoi Revert part of "Fix Linux build." to fix swiftshader_unittests

Created with:
  roll-dep third_party/externals/swiftshader


The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader
TBR=herb@google.com

Change-Id: I5760e15632bbb4037b92d70b1613b4a562575e2e
Reviewed-on: https://skia-review.googlesource.com/127981
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-14 12:54:29 +00:00
Robert Phillips
5140f9a8e4 Minor refactoring to image filters
This pulls the boring parts out of: https://skia-review.googlesource.com/c/skia/+/127338 (Fix srcBounds computation in SkMatrixConvolutionImageFilter)

TBR=bsalomon@google.com
Change-Id: Iade788fcc96c4c16989d13e7592030a6a1d3f170
Reviewed-on: https://skia-review.googlesource.com/127573
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-05-14 12:01:59 +00:00
Mike Reed
b06a1eb4e5 detect overflow for morphology
Bug: oss-fuzz:8236
Change-Id: Iae911d995cbfed77c5d332f615da1a8d9b487c21
Reviewed-on: https://skia-review.googlesource.com/127703
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-05-13 18:05:16 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
ec48812c5a Roll third_party/externals/angle2/ 18e323ab2..66aafcb46 (1 commit)
18e323ab2c..66aafcb464

$ git log 18e323ab2..66aafcb46 --date=short --no-merges --format='%ad %ae %s'
2018-05-12 fjhenigman Revert "GLES1: Renderer (minimal)"

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=egdaniel@google.com

Change-Id: Ie6d767fa4eee8d2e61c51f3f188ebb5cbec3ea3c
Reviewed-on: https://skia-review.googlesource.com/127780
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-12 22:43:25 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
96b0b46f23 Roll third_party/externals/angle2/ a69099212..18e323ab2 (3 commits)
a69099212f..18e323ab2c

$ git log a69099212..18e323ab2 --date=short --no-merges --format='%ad %ae %s'
2018-05-11 jmadill D3D11: Fix out-of-range access with robust access.
2018-05-10 geofflang GL: Refactor ShaderGL to not hold renderer objects.
2018-05-11 geofflang Request EGL_DONT_CARE version instead of 0 on GL NULL configs.

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=egdaniel@google.com

Change-Id: I845de483cea05cdaf6d4ebe31cc1ee2da10d9f77
Reviewed-on: https://skia-review.googlesource.com/127683
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-12 05:58:47 +00:00
Mike Reed
3202ac4d24 Revert "Revert "reject large paths to avoid potential float overflows""
This reverts commit b8f0709aac.

Attempted fix: update the iData before we return.

Bug: oss-fuzz:8131

Change-Id: If60b8b45df4dcb1deecc18f58cb09644aaa3231d
Reviewed-on: https://skia-review.googlesource.com/127501
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-05-11 21:49:17 +00:00
swiftshader-skia-autoroll
e6bbae787d Roll third_party/externals/swiftshader/ 0641aebe3..5fd1cfaae (1 commit)
https://swiftshader.googlesource.com/SwiftShader/+log/0641aebe3155..5fd1cfaaeaa4

$ git log 0641aebe3..5fd1cfaae --date=short --no-merges --format='%ad %ae %s'
2018-05-11 sugoi Pitch fix for IO surfaces

Created with:
  roll-dep third_party/externals/swiftshader


The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader
TBR=egdaniel@google.com

Change-Id: I70b68da8145d97ccbfa79834215b1560d2066c74
Reviewed-on: https://skia-review.googlesource.com/127576
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-11 21:02:47 +00:00
Ben Wagner
9b161a9f24 Don't limit glyph mask format for path effect.
This removes code which sets the mask format of a scaler context to a8
in the presence of a path effect. This is overly limiting as both a1 and
lcd16 are supported.

Change-Id: I2a9ae88eac6a80ba1307dbac3d903041a9a93bf2
Reviewed-on: https://skia-review.googlesource.com/127398
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-05-11 20:54:47 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
67f98b9015 Roll third_party/externals/angle2/ 8073a9511..a69099212 (5 commits)
8073a9511a..a69099212f

$ git log 8073a9511..a69099212 --date=short --no-merges --format='%ad %ae %s'
2018-04-23 lfy GLES1: Renderer (minimal)
2018-05-09 ynovikov Update dEQP GLES2 expectations for Android Vulkan backend
2018-05-04 lucferron Vulkan: Incomplete textures support
2018-05-10 geofflang Pass a gl::Context to ShaderImpl methods.
2018-05-07 geofflang GL: Refactor TextureGL to not hold renderer objects.

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=egdaniel@google.com

Change-Id: Ie09a3748b4199e300f55e904982fb5a6d83b75ff
Reviewed-on: https://skia-review.googlesource.com/127575
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-11 20:37:47 +00:00
recipe-roller
06ba3fe323 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/d1de725e0b53f5f0bb331471e5673aee0e72a5b7 gclient: Prevent unprocessed deps from overriding processed ones in sync output. (jbudorick@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I42e385692bad3eece39dc1217c9e01f28e4ee5ab
Reviewed-on: https://skia-review.googlesource.com/127620
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-11 20:25:47 +00:00
Ethan Nicholas
811b944a89 fixed incorrect index in SPIR-V matrix construction
Bug: skia:7908
Change-Id: I990e5f6e84afdc81d340f433d93a9061b9dd67ef
Reviewed-on: https://skia-review.googlesource.com/127397
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2018-05-11 17:56:47 +00:00
Brian Salomon
79bf7ac3f4 Include SkUnPremultiply.h in GrContext.h to fix Android compile
Change-Id: Iab23ebbc0e3c639d4f0589ab3e8ae458b85b3298
Reviewed-on: https://skia-review.googlesource.com/127396
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
2018-05-11 17:43:57 +00:00
Hal Canary
8259114440 SkPDF: scale entire canvas for non-standard rasterDpi
TODO: add better testing around this.

BUG: chromium:481429

Change-Id: I1296fae3fc9775febf17bba75722c30f48d67a95
Reviewed-on: https://skia-review.googlesource.com/127051
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-05-11 17:36:57 +00:00