schenney@chromium.org
4da06ab335
Modifying SkPath to store all verbs provided by the user, and to give
...
correct results for all stroke and fill modes even on the various types
of degenerate paths.
The goals of this patch include:
1. Have Skia store all of the verbs implied by path construction methods, even
if those define degenerate paths. The SVG implementation in WebKit, which is
backed by Skia, needs to know about all elements of the path, even degenerate
ones, for the correct drawing of markers and line caps. For example, in SVG you
should be able to draw a scatter plot by specifying a marker for vertices and
then giving a sequence of moveTo commands. Skia will not store the moveTos,
requiring a different storage mechanism.
2. Assuming 1, maintain the current Skia behavior. That is, make Skia robust to
degenerate paths.
3. Fix an existing bug in Skia where a degenerate moveTo-lineTo pair spits out
warnings from rasterization and produces incorrect results in inverse-fill
renderings.
4. Adds extensive testing for degenerate paths and path rendering in general.
To meet these goals, the patch I am proposing will result in minor additional
storage for degenerate paths (a few bytes per degenerate path, only if the user
defines such paths). There is also some additional overhead in the iteration
code, with the path now cleaned to remove degenerate segments as part of the
iteration process. I suspect this will also fix issues with computing normal
vectors to degenerate segments. Benchmarking suggests that this change may
result in slightly (< 1%) slower path drawing due to the checks for
degeneracy. This overhead could be removed (in fact, a significant speedup
could occur) if the results of iterating to clean up the path were cached.
This would cost memory, of course, and quite a bit of it.
BUG=398
TEST=tests/PathTest.cpp
gm/cubicpaths.cpp
gm/degeneratesegments.cpp
gm/movepaths.cpp
gm/linepaths.cpp
gm/quadpaths.cpp
Review URL: http://codereview.appspot.com/5482051
git-svn-id: http://skia.googlecode.com/svn/trunk@2901 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-20 15:14:18 +00:00
reed@google.com
263cb3a79c
can't pass const to setPixels :(
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2900 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-20 14:35:32 +00:00
reed@google.com
5213c04216
defer creating offscreen until our first draw (so our constructor runs fast)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2898 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-20 13:41:09 +00:00
reed@google.com
eb85630fd6
fix positioning for scalar=fixed, still need to fix actual mode
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2862 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-12 22:15:18 +00:00
reed@google.com
eb0fa29fc4
try to make it draw correctly in fixed point
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2860 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-12 22:01:06 +00:00
bsalomon@google.com
aa814fe4a1
Access sampler matrices directly, cleanup GrSamplerState::reset()s
...
Review URL: http://codereview.appspot.com/5488048/
git-svn-id: http://skia.googlecode.com/svn/trunk@2854 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-12 18:45:07 +00:00
mike@reedtribe.org
e51755fc64
add first cut at arithmetic mode
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2849 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-10 19:36:56 +00:00
reed@google.com
a8f60f2502
change to complexclip_bw and complexclip_aa, adding more combinations as well
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2833 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-08 16:18:29 +00:00
reed@google.com
b4b49ccc41
add getBGColor() getter
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2809 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-06 16:15:42 +00:00
bsalomon@google.com
39ee0ffa72
Prep #1 for making GrDrawState a class
...
Review URL: http://codereview.appspot.com/5437138/
git-svn-id: http://skia.googlecode.com/svn/trunk@2808 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-06 15:32:52 +00:00
bsalomon@google.com
5bc34f04fe
Remove fConfig/fFormat union in GrTextureDesc
...
Review URL: http://codereview.appspot.com/5448116/
git-svn-id: http://skia.googlecode.com/svn/trunk@2806 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-06 14:46:34 +00:00
senorblanco@chromium.org
ef843cdcd1
When a bitmap is texture-backed, change SkBitmap::copyTo() to do a deep
...
copy of the texels in VRAM rather than a readback and re-upload. This
gives a 3-10X speedup on recursive canvas-to-canvas draws.
N.B.: This introduces a new GM test, which will need new baselines.
git-svn-id: http://skia.googlecode.com/svn/trunk@2790 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-12-02 19:11:17 +00:00
bsalomon@google.com
29d3501e3b
Fix issue where bumping the max gm width/height affects gpu images
...
Review URL: http://codereview.appspot.com/5440065/
git-svn-id: http://skia.googlecode.com/svn/trunk@2766 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-30 16:57:21 +00:00
reed@google.com
2f6c957afd
update verttext to remove leading space from image name
...
add mac-desktop baseline images
git-svn-id: http://skia.googlecode.com/svn/trunk@2763 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-30 14:58:16 +00:00
reed@google.com
fb82300d1b
enable shadermask optimization all the time
...
update gm for shadermask
fix bugs in lcd_blend math
git-svn-id: http://skia.googlecode.com/svn/trunk@2761 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-30 14:29:55 +00:00
bsalomon@google.com
fb30951cd9
[GPU] tile when large bitmap pased drawBitmap and only a small fraction is used
...
Review URL: http://codereview.appspot.com/5450048/
git-svn-id: http://skia.googlecode.com/svn/trunk@2760 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-30 14:13:48 +00:00
reed@google.com
e805535b19
add test for shader text w/ and w/o lcd (and w/ and w/o opaque)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2753 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-28 16:31:28 +00:00
bsalomon@google.com
31648eb1cf
Fix warnings
...
Review URL: http://codereview.appspot.com/5433054/
git-svn-id: http://skia.googlecode.com/svn/trunk@2741 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-23 15:01:08 +00:00
bsalomon@google.com
6f3795105b
Make all pixel ops go thru ctx so we can correctly flush. Unify two texture upload code paths.
...
Review URL: http://codereview.appspot.com/5373108/
git-svn-id: http://skia.googlecode.com/svn/trunk@2701 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-16 20:36:03 +00:00
senorblanco@chromium.org
54e01b2ab9
This change makes SkImageFilter and SkBlurImageFilter flattenable/unflattenable.
...
The imageblur test also needed to stop calling getDeviceSize(), since it was
returning 99999x99999 for the SkPicture case.
git-svn-id: http://skia.googlecode.com/svn/trunk@2699 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-16 18:20:47 +00:00
reed@google.com
761661580e
add test for bad scanconversion (disabled)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2673 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-14 13:14:58 +00:00
reed@google.com
14debba629
add test gm for vertical text
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2661 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-10 20:06:01 +00:00
senorblanco@chromium.org
60014ca387
Implement Gaussian blurs for images. The caller creates an an
...
SkBlurImageFilter, sets it on an SkPaint, passes that paint to saveLayer(),
draws the primitives which are to be blurred, then calls restore(), which
applies the blur. The blurs have separate sizes in the horizontal and vertical
direction. This feature is GPU-only for now.
NB: Due to the clipping change, there are slight pixel differences on the
blurs_gpu and shadows_gpu tests, so those will require rebaselining on all
platforms, as will some of the WebKit layout tests (TBD).
Review URL: http://codereview.appspot.com/5322068/
git-svn-id: http://skia.googlecode.com/svn/trunk@2643 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-09 16:05:58 +00:00
reed@google.com
8923c6cfd5
suppress font-purge messages
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2623 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-08 14:59:38 +00:00
bungeman@google.com
24babf45b1
Add font scaler gm.
...
http://codereview.appspot.com/5337044/
git-svn-id: http://skia.googlecode.com/svn/trunk@2619 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-07 16:33:40 +00:00
bsalomon@google.com
c436499622
[GPU] Add explicit byte order and PM vs. UPM 8888 configs
...
Review URL: http://codereview.appspot.com/5347042/
git-svn-id: http://skia.googlecode.com/svn/trunk@2618 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-07 15:54:49 +00:00
bsalomon@google.com
e269f210bd
Recommit r2611 with fix for gm
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2614 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-07 13:29:52 +00:00
bsalomon@google.com
b87d2b5c2a
Revert r2611 until windows gm can be debugged
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2612 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-07 01:58:39 +00:00
bsalomon@google.com
6d9adaec78
Add replacement APIs for createPlatformSurface: createPlatformTexture and createPlatformRenderTarget
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2611 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-07 01:37:22 +00:00
bungeman@google.com
0f0c2888e0
Add font scaler gm.
...
http://codereview.appspot.com/5337044/
git-svn-id: http://skia.googlecode.com/svn/trunk@2603 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-04 15:47:41 +00:00
bsalomon@google.com
c69809745e
Recommit r2584 with gpu pass of the new ReadPixels test disabled in fixed pt (gpu code doesn't work in general in fixed pt).
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2586 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-02 19:57:21 +00:00
bsalomon@google.com
ace7bd5623
Revert r2584 (new test fails in fixed pt builds)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2585 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-02 19:39:51 +00:00
bsalomon@google.com
1a8ddf0a35
Changes the SkCanvas::readPixels API. Allows caller to read into prealloced bitmap pixels. Changes how clipping to device bounds is handled.
...
Review URL: http://codereview.appspot.com/5307077/
git-svn-id: http://skia.googlecode.com/svn/trunk@2584 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-11-02 19:34:16 +00:00
reed@google.com
b2a5162f1d
all for multiple --match foo args, which will be logically OR'd together
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2567 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-10-31 16:30:04 +00:00
bsalomon@google.com
48dd1a26ec
Import all GMs as Samples.
...
Review URL: http://codereview.appspot.com/5332043/
git-svn-id: http://skia.googlecode.com/svn/trunk@2564 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-10-31 14:18:20 +00:00
bsalomon@google.com
72e49b8982
warning fixes
...
Review URL http://codereview.appspot.com/5328050/
git-svn-id: http://skia.googlecode.com/svn/trunk@2548 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-10-27 21:47:03 +00:00
bsalomon@google.com
373a6635b7
Virtualize SkGLContext with subclasses SkNativeGLContext and SkMesaGLContext, allow both in gm
...
Review URL: http://codereview.appspot.com/5307045/
git-svn-id: http://skia.googlecode.com/svn/trunk@2499 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-10-19 20:43:20 +00:00
bsalomon@google.com
e295313f01
move utils/SkEGLContext to gpu/SkGLContext, some gpu.gyp cleanup, set eol style LF on all gpu files
...
Review URL: http://codereview.appspot.com/5242056/
git-svn-id: http://skia.googlecode.com/svn/trunk@2474 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-10-13 13:33:08 +00:00
bsalomon@google.com
a310826855
Add per-vertex coverage field, use in AA rects when alpha tweak is not valid, add relevant sample/gm
...
Review URL: http://codereview.appspot.com/5181044/
git-svn-id: http://skia.googlecode.com/svn/trunk@2440 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-10-10 14:08:47 +00:00
bsalomon@google.com
f12449b5d2
Fixed signed/unsigned comparison warnings in empty path gm/sample
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2439 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-10-10 14:03:33 +00:00
bungeman@google.com
0f1541f1c3
Mac does not like empty projects.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2438 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-10-10 13:47:06 +00:00
bungeman@google.com
b29c883fb4
Add xps device to skia.
...
http://codereview.appspot.com/5076041/
git-svn-id: http://skia.googlecode.com/svn/trunk@2437 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-10-10 13:19:10 +00:00
bungeman@google.com
07faed1102
Setting perspective in fixed point.
...
http://codereview.appspot.com/5088043/
git-svn-id: http://skia.googlecode.com/svn/trunk@2435 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-10-07 21:55:56 +00:00
bungeman@google.com
01744a46e8
Fix clamped_gradients gm to work in fixed.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2425 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-10-06 19:37:39 +00:00
bsalomon@google.com
fa6ac938e6
Fixup rendering of empty paths (including inverted fills)
...
Add GM and Sample that draw empty paths with various styles and fills
Review URL: http://codereview.appspot.com/5185047/
git-svn-id: http://skia.googlecode.com/svn/trunk@2414 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-10-05 19:57:55 +00:00
bsalomon@google.com
9d12f5c11b
Fix some VS2010 warnings
...
Review URL: http://codereview.appspot.com/5155043
git-svn-id: http://skia.googlecode.com/svn/trunk@2380 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-09-29 18:08:18 +00:00
tomhudson@google.com
5ea050f662
Optimize software radial gradients (remove branches from the inner loop where
...
we can, because an entire row is conservatively either outside or inside the
gradient.) Change the gradient benchmark to capture both cases, and add new
gm to detect errors in these optimized paths.
git-svn-id: http://skia.googlecode.com/svn/trunk@2327 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-09-26 15:03:55 +00:00
bungeman@google.com
64e011a59d
Fix pdf suppression test for gm.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@2284 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-09-19 19:31:04 +00:00
reed@google.com
fbc2117288
add getFlags() to gm baseclass
...
skip PDF for hairmodes for now, since it crashes
git-svn-id: http://skia.googlecode.com/svn/trunk@2282 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-09-19 19:08:33 +00:00
reed@google.com
ab9739777c
add gm test for drawing hairlines (and varying thin lines) in xfermodes
...
add --nopdf option to gm app
git-svn-id: http://skia.googlecode.com/svn/trunk@2281 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-09-19 19:01:38 +00:00