Commit Graph

41908 Commits

Author SHA1 Message Date
skia-autoroll
f90bfd7217 Roll third_party/externals/angle2 0f4d72e63b92..19905aea14e0 (9 commits)
0f4d72e63b..19905aea14


git log 0f4d72e63b92..19905aea14e0 --date=short --no-merges --format='%ad %ae %s'
2019-05-08 ianelliott@google.com Vulkan: Set the Vulkan scissor to the GLES viewport
2019-05-07 tobine@google.com Vulkan:Only apply invariant pragma to output vars
2019-05-07 staphany@chromium.org Add using-declaration to support Googletest roll.
2019-05-07 jonahr@google.com Roll SPIRV Deps (May 7th, 2019)
2019-05-07 syoussefi@chromium.org Vulkan: add uniform buffer object support
2019-05-07 timvp@google.com Vulkan: Enable drawRangeElements()
2019-05-07 jonahr@google.com Use VPython for dependency management of scripts/generate_stats.py
2019-05-07 aleino@nvidia.com Use D3D11 GetDimensions driver workaround for 2D integer textures
2019-05-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 5fc5303eeceb..106c98d0fa0a (2 commits)


Created with:
  gclient setdep -r third_party/externals/angle2@19905aea14e0

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=robertphillips@google.com

Change-Id: If065448d7cf1a45ba3e6b6131715803479ee76e5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212641
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-08 05:18:47 +00:00
skia-autoroll
905b2c7a46 Roll ../src 648a59893e4e..d5837fbd88aa (481 commits)
648a59893e..d5837fbd88


Created with:
  gclient setdep -r ../src@d5837fbd88

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=robertphillips@google.com

Change-Id: I10ae92af820d13aafa806e54339cd52ae8541fd4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212660
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-08 04:53:47 +00:00
skia-autoroll
4497ac1799 Roll third_party/externals/swiftshader b01f2559e017..d5ed0a31ce88 (10 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/b01f2559e017..d5ed0a31ce88


git log b01f2559e017..d5ed0a31ce88 --date=short --no-merges --format='%ad %ae %s'
2019-05-08 sugoi@google.com External Memory Host tests should be unsupported
2019-05-08 sugoi@google.com Ignore VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT at pipeline creation
2019-05-07 sugoi@google.com Extension check in vkCreateDescriptorSetLayout
2019-05-07 sugoi@google.com vkBindImageMemory2 implementation
2019-05-07 chrisforbes@google.com Groundwork for quadlayout support in blit & copy ops
2019-05-07 chrisforbes@google.com Add support for Sample image operand in OpImageRead
2019-05-07 bclayton@google.com LLVMReactor: Assert return value type matches function sig.
2019-05-07 capn@google.com Fix clamp-to-border addressing mode
2019-05-07 sugoi@google.com Change decompressed type of compressed RGB formats
2019-05-07 swiftshader.regress@gmail.com Regres: Update test lists @ b01f2559


Created with:
  gclient setdep -r third_party/externals/swiftshader@d5ed0a31ce88

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=robertphillips@google.com

Change-Id: Ibc57ca43d105585b6cd695f99b3283cb178316d1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212640
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-08 04:35:17 +00:00
Ben Wagner
51e15a69ce Use SkTextEncoding enum instead of macros.
Change-Id: I4b6259590fa0693ee0522b4999a1c0fe250b173d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212504
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-05-07 20:54:16 +00:00
Ethan Nicholas
354ecf3693 fixed SkSL interpreter negate op
Bug: skia:
Change-Id: I76ff729a887948119ec1ef58221433a6d91e98a8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212484
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2019-05-07 20:49:21 +00:00
Robert Phillips
8e49a69ef9 Loosen up checks in DDLSkSurfaceFlush
Some platforms (e.g., ANGLE & CommandBuffer) don't return GrSemaphoresSubmitted::kYes from flush

Change-Id: I0810e2ecb7f9ad1088c9450ceb5669fe690e8298
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212505
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-05-07 20:49:11 +00:00
Herb Derby
f5e5f193ac Cleaup GrTextStrike and GrStrikeCache
Make names to be more explicit...
grStrike for GrTextStrike
grStrikeCache for GrStrikeCache
skStrike for SkStrike
SkStrikeCache for SkStrikeCache

Inline some small functions to identify patterns in
usage.

Change-Id: I770f12feaf7f389a633b5a194ad0eaec1672bfaa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212503
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-05-07 20:31:21 +00:00
Ethan Nicholas
444aa12c84 fixed SkSL interpreter test
Bug: skia:
Change-Id: I8ddb017994cd9e4ad01163da07888c431a5b1276
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212416
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-05-07 19:27:20 +00:00
Robert Phillips
ee5fd13ea2 Add test for DDLs and SkSurface::flush
Bug: 958055
Change-Id: I9abffd09344a731efbd29dce23db76d56d258622
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212408
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-05-07 19:22:20 +00:00
Ben Wagner
7f28e0b87f Mac slight hinting to be normal instead of none.
This is more in line with what the DirectWrite backend does, and is also
more compatible when Mac typefaces are mixed with FreeType typefaces.

Change-Id: I5dd351b452e8c7c822f71290b7a62312809bd964
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212417
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-05-07 19:22:10 +00:00
Chinmay Garde
8982076016 Allow building Skia with Fuchsia SDK enabled buildroots.
The Fuchsia SDK can now be consumed by non-Fuchsia buildroots to produce
Fuchsia artifacts.

The Fuchsia SDK comes with a JSON manifest that describes the various SDK
"parts". GN targets are stamped for each of these parts. The location of these
GN targets can be configured. That location is set to |fuchsia_sdk_root| in
each buildroot. This variable is defined in //build/fuchsia/sdk.gni in each
buildroot. For buildroots that don't care or know about the Fuchsia SDK, that
file may not exist. This is why, the import of that file is guarded behind
the is_fuchsia flag. When the Fuchsia SDK is enabled, that file will define
values for two required variable |using_fuchsia_sdk| and |fuchsia_sdk_root|.

The first flag defines if the SDK is being used. If unset (but defined), the
builds are in-tree. Eventually we want only SDK builds. |fuchsia_sdk_root|
is set to the spot in the buildroot where the GN targets for the SDK parts
are stamped.

Change-Id: I99a0b48326d722703c786263edde7421f9014179
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212034
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-05-07 18:53:50 +00:00
Hal Canary
0569447470 experimental/editor: progress
- selection
  - some state moved out of editor.
  - Editor::getPosition() translates x,y mouse position into text
    position
  - General Editor::move() function for moving cursor
  - Editor::insert() (does not yet handle newlines)
  - Editor::remove() (does not yet delete across lines)
  - new StringSlice class to replace SkString.

Change-Id: I1ca03247a745bc045e41619cd5a839c495dc405b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211884
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-05-07 18:01:50 +00:00
Ethan Nicholas
dfcad064e9 more SkSL interpreter performance work
Bug: skia:
Change-Id: I21da1f1473fb73e8ba1371e7301f3fff2e33e8cc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212199
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2019-05-07 17:29:50 +00:00
Ben Wagner
07dad1bc42 Fix some documentation for SkFont.
In particular, linear metrics now means 'linearly scalable metrics' as
expected. This also makes the documentation for the setter and getter
for subpixel positioning agree.

Change-Id: I08f5009f32516a0fdaecefc1d7dbe5f43c005a69
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212406
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-05-07 16:54:10 +00:00
Brian Osman
06e14afaa7 Add no-nonportable-include-path when building ANGLE with Windows-Clang
Fixes a slew of warnings when doing distributed builds.

Change-Id: Ie96144eef1e593479201d8bab8c93cbc6e64e87c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212407
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-05-07 15:47:21 +00:00
Eric Boren
9f0eeac820 [infra] Remove remaining references to go_deps
Change-Id: I7c4ecc3989742c4ff929c352c09b1c464aaa2943
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212403
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-05-07 14:40:35 +00:00
Brian Osman
5bee390667 Viewer: Fixes for shader editing in ANGLE
- Include default precision in viewer's highlight shader when needed
- Flush cache when switching backends. Fixes issues between (eg) GL
  and ANGLE where shader caps are different.

Change-Id: I80bc9fb56fdab49fdbe2e858db7398a5471048c6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212194
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2019-05-07 14:29:15 +00:00
Ben Wagner
9707a7e51c IWYU for tests A-D.
Change-Id: I0cb383eb6ea5a302627f93b90182a7286c2c0995
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212280
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-05-07 14:24:15 +00:00
Raul Tambre
0362dc268a Fix use of 'is' operator for comparison
The 'is' operator is not meant to be used for comparisons. It currently working is an implementation detail of CPython.
CPython 3.8 has added a SyntaxWarning for this.

Bug: chromium:958874
Change-Id: I7657bd3fddf37e849cc30aca34825fa3c0f71b58
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211663
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Raul Tambre <raul@tambre.ee>
2019-05-07 14:22:15 +00:00
Brian Salomon
b0d8b76c4f Make finish flush procs work with GL.
This will be required for async readback support.

This is implemented using sync objects when available and otherwise
calls glFinish.

Relaxes the unit test requirement that providing a callback with no
work to flush always calls the proc immediately.

Bug: skia:8962
Change-Id: Ieefcab6dccc3924e50260343f01904e7303bb12b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212198
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-05-07 10:35:38 +00:00
skia-autoroll
d05c5eec42 Roll third_party/externals/angle2 6f0c5b8dd5f2..0f4d72e63b92 (8 commits)
6f0c5b8dd5..0f4d72e63b


git log 6f0c5b8dd5f2..0f4d72e63b92 --date=short --no-merges --format='%ad %ae %s'
2019-05-06 geofflang@chromium.org Add makeCurrent and unMakeCurrent to SurfaceImpl.
2019-05-06 geofflang@chromium.org Vulkan: Add a new garbage type gated by fences.
2019-05-06 geofflang@chromium.org Format all of ANGLE's python code.
2019-05-06 lsalzman@mozilla.com add support for EXT_blend_func_extended to D3D11
2019-05-06 syoussefi@chromium.org Suppress test hitting Nvidia shield driver bug
2019-05-06 jonahr@google.com Use EnumAdapters to properly detect primary GPU on Win
2019-05-06 geofflang@chromium.org Vulkan: Store fences instead of serials in SurfaceVK::SwapHistory
2019-05-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 86c72c9486a9..c0640dabfddd (2 commits)


Created with:
  gclient setdep -r third_party/externals/angle2@0f4d72e63b92

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=robertphillips@google.com

Change-Id: Ibc2802e22275784c206aabc930704e908143674e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212342
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-07 05:21:41 +00:00
skia-autoroll
743913344b Roll ../src e300e8fa69a2..648a59893e4e (393 commits)
e300e8fa69..648a59893e


Created with:
  gclient setdep -r ../src@648a59893e

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=robertphillips@google.com

Change-Id: I0b5d073dffdf7f1c37de204834ceb282993038bd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212343
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-07 04:52:41 +00:00
skia-autoroll
d699a66fa2 Roll third_party/externals/swiftshader bb12b0e41a09..b01f2559e017 (10 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/bb12b0e41a09..b01f2559e017


git log bb12b0e41a09..b01f2559e017 --date=short --no-merges --format='%ad %ae %s'
2019-05-06 chrisforbes@google.com Add padding between slices
2019-05-06 chrisforbes@google.com Add support for spv::BuiltInSampleMask output
2019-05-06 capn@google.com Implement 1D array image sampling
2019-05-06 chrisforbes@google.com Wait on query being available, not !active.
2019-05-06 chrisforbes@google.com Allow VK_IMAGE_LAYOUT_GENERAL in vkCmdCopyImageToBuffer
2019-05-06 chrisforbes@google.com Plumb through Dref parameter to sampler
2019-05-06 chrisforbes@google.com Make shadow compare available in high precision path always
2019-05-06 sugoi@google.com Threaded Queue submit with events and fences
2019-05-06 sugoi@google.com Cube border computation
2019-05-06 sugoi@google.com ETC2 Image decompression and sampling


Created with:
  gclient setdep -r third_party/externals/swiftshader@b01f2559e017

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=robertphillips@google.com

Change-Id: I8b8e74b7829f9413e7ec32945833b46e0aa36525
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212341
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-07 04:33:51 +00:00
Hal Canary
5f2807b71e Clean up CanvasTest.cpp some more
Change-Id: I44929cbb13e784f1e1ab7410598c02d285b71def
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212268
Commit-Queue: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-05-06 21:23:36 +00:00
Ben Wagner
cbf6d30661 Clean up CanvasTest.cpp macros.
The CanvasTest test had a rather impenetrable set of macros and static
registration for its sub tests. This moves all the code only used by
this test into the test body and removes all of the static registration
and macros.

Change-Id: Ie6031591f86e17ec949db995023ac10360c9092f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212260
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-05-06 20:18:36 +00:00
Brian Osman
a9aaef0c99 Revert "Support GL_EXT_draw_buffers"
This reverts commit 77af4ecd35.

Reason for revert: iOS errors and bad images on Gold

Original change's description:
> Support GL_EXT_draw_buffers
> 
> Change-Id: I078aa7c42de4368602b0ef43bd7e18efbfd1e049
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212182
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>

TBR=bsalomon@google.com,robertphillips@google.com,brianosman@google.com

Change-Id: Ib8759d4a1009f9a8774365a699e211834d634cff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212264
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-05-06 20:07:27 +00:00
Brian Osman
77af4ecd35 Support GL_EXT_draw_buffers
Change-Id: I078aa7c42de4368602b0ef43bd7e18efbfd1e049
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212182
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-05-06 18:59:06 +00:00
Robert Phillips
d3c048234b Re-add flag to force opList splitting reduction
We need this again because I had to turn off opList splitting reduction by default but would like to keep testing it on some bots

Change-Id: I9e38d5a3d823e86799055892d191a5643a4b98ac
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212193
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-05-06 18:52:15 +00:00
recipe-roller
cb35914098 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/b3aca437d08fb4a2c6f656ad0a0afae3d0396cec Revert "bot_update: Pass target-ref to gclient." (martiniss@chromium.org)
  https://crrev.com/47ec0697f06bbe67a9156dd45e0c5b478d0f7f65 git_cache: remove the mirror_path if it exists in an incomplete state. (jbudorick@chromium.org)
  https://crrev.com/a0ffbe45058667e3ba0810557ba45436416144e2 gclient: Convert target ref to patch to a remote ref. (ehmaldonado@chromium.org)
  https://crrev.com/867e3c9511394f5bb2f51f09278e5ccc773adc36 Reland "bot_update: Pass target-ref to gclient." (ehmaldonado@chromium.org)
  https://crrev.com/fe1dbe120c9905324026fa503ac1690dc96e16e2 Fix always false 'is not' comparison with a literal (raul@tambre.ee)
  https://crrev.com/9c0620120980e4c247ff8325ee8bbdcd4d9576e0 Fix multiple confusingly escaped regex strings (brucedawson@chromium.org)
recipe_engine:
  https://crrev.com/b8cb36a2fedc4739cb317ffb60fc6fa3cc231048 [docs] Add some skeleton documentation for writing recipes. (iannucci@chromium.org)
  https://crrev.com/729f9023cff72064acd9f3f2548d90f5ea03461e [buildbucket] Fix buildbucket.search (nodir@google.com)
  https://crrev.com/0589a429cf3c164004dae4ced4c75784a50afd81 Only delete the specified element, not all of them (sergiyb@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9314b04443deeec81ca082b28174d0f1a08e7238
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212195
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-05-06 18:44:46 +00:00
Eric Boren
ebc21f64cd [infra] Pin infra code using Go modules
Change-Id: I005740aef6ab8ba78f3da4d3b9d744ce3fb326e6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211982
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-05-06 17:53:19 +00:00
Robert Phillips
25aac5c196 Make SkComposeImageFilter comply with SkImageFilter::filterBounds calling convention
In kForward mode the 'inputRect' parameter is supposed to be null

Bug: 959103
Change-Id: I2fceace384cdda3988e07dcb5d975750ba28bd39
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212187
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-05-06 17:49:04 +00:00
Tom Anderson
e772c59d94 Remove static initializer in SkExecutor.cpp
Bug: chromium:956591
Change-Id: I79732cb0266020dc00e622b126cd565e953600dd
R=thakis@chromium.org
CC=liaoyuke@chromium.org
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211835
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
2019-05-06 17:48:14 +00:00
Kevin Lubick
0921c10404 [canvaskit] 0.6.0
Change-Id: I4c408a8b711421856a14d67cee121512f7e06900
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212190
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-05-06 17:47:09 +00:00
Kevin Lubick
d6b32ed39d [img-decode] Start on proposed new spec
This adds readPixel and a partial stub of window.createImageData

Change-Id: Iee992312b9331b71852fe2198f844a7e4ae9e963
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211344
Reviewed-by: Mike Reed <reed@google.com>
2019-05-06 17:39:19 +00:00
Brian Osman
5e7fbfd9b0 Add ShaderErrorHandler to GrContextOptions
Allows clients to customize behavior when shaders fail to compile.
Added nicer shader error handling to viewer.

Change-Id: If82b48e40d64fd786f37e88c564fd623b53c7f9d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211361
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-05-06 16:29:13 +00:00
Michael Ludwig
7d2ad0fdef Fix local matrix for crop rects in backdrop image filters
Bug: chromium:955467
Change-Id: I1c4cae2499db926aa6b629e8d730fcc8cb45be6d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212030
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2019-05-06 15:11:40 +00:00
skia-autoroll
2f3637bf2e Roll third_party/externals/angle2 ddc4d33a259a..6f0c5b8dd5f2 (15 commits)
ddc4d33a25..6f0c5b8dd5


git log ddc4d33a259a..6f0c5b8dd5f2 --date=short --no-merges --format='%ad %ae %s'
2019-05-04 jmadill@chromium.org D3D11: Fix potential invalid VAO access in dispatch.
2019-05-04 syoussefi@chromium.org Vulkan: Optimize shader source macro replacement
2019-05-03 geofflang@chromium.org Vulkan: Reset swap chain image dependency information when aquiring.
2019-05-03 syoussefi@chromium.org Vulkan: Fix qualifiers for varyings
2019-05-03 jmadill@chromium.org Add option to run each test config in a separate process.
2019-05-03 yiyix@google.com Add support for dynamically allocate initial stack for Angle
2019-05-03 jmadill@chromium.org Remove EGLTest.
2019-05-03 jmadill@chromium.org Add command line option to filter by test config.
2019-05-03 syoussefi@chromium.org Vulkan: Fix layout substitution for struct varyings
2019-05-03 jmadill@chromium.org Move ANGLE Platform Methods init to GetDisplay.
2019-05-03 jonahr@google.com Consolidate 32/64 bit dEQP results on doc.
2019-05-03 jmadill@chromium.org Removed SizedFloat helper class from upload tests.
2019-05-03 yiyix@chromium.org Add support for GCC Compilers
2019-05-03 jmadill@chromium.org Simplify ANGLE test config names.
2019-05-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src c8b09744c6a1..5fc5303eeceb (2 commits)


Created with:
  gclient setdep -r third_party/externals/angle2@6f0c5b8dd5f2

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=robertphillips@google.com

Change-Id: I7d5329a07ab69039d0cb4a0d26d13bf5ae13185d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212141
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-06 05:29:20 +00:00
skia-autoroll
46e10981fe Roll ../src b81b70981d9b..e300e8fa69a2 (429 commits)
b81b70981d..e300e8fa69


Created with:
  gclient setdep -r ../src@e300e8fa69

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=robertphillips@google.com

Change-Id: If16efc2386455af08bb20562adf4b47f6e600050
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212142
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-06 04:40:49 +00:00
skia-autoroll
719a69ca5a Roll third_party/externals/swiftshader 10f7befc49a7..bb12b0e41a09 (14 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/10f7befc49a7..bb12b0e41a09


git log 10f7befc49a7..bb12b0e41a09 --date=short --no-merges --format='%ad %ae %s'
2019-05-04 swiftshader.regress@gmail.com Regres: Update test lists @ 0e14a2e3
2019-05-03 chrisforbes@google.com Fix broken optimization of alpha VK_BLEND_OP_REVERSE_SUBTRACT
2019-05-03 bclayton@google.com Add traits for Reactor arguments and return types
2019-05-03 bclayton@google.com SetupRoutine: Do not use Bool as a function return type.
2019-05-03 bclayton@google.com Reactor: Do not start the unreachable block with Unreachable
2019-05-03 bclayton@google.com LLVMReactor: Finalize the debug info earlier
2019-05-03 bclayton@google.com LLVMReactor: Fix the signature of a few instrinsics
2019-05-03 bclayton@google.com LLVM: Fix for coroutines with array allocas
2019-05-03 chrisforbes@google.com Add input attachment support for VK_FORMAT_R5G6B5_UNORM_PACK16
2019-05-03 chrisforbes@google.com Add support for sampling VK_FORMAT_D16_UNORM
2019-05-03 chrisforbes@google.com Add input attachment support for VK_FORMAT_A2B10G10R10_UINT_PACK32
2019-05-03 chrisforbes@google.com Add support for VK_FORMAT_A2B10G10R10_UINT_PACK32 render targets
2019-05-03 chrisforbes@google.com Fix blitter clears of 2D views of 3D textures
2019-05-03 swiftshader.regress@gmail.com Regres: Update test lists @ 10f7befc


Created with:
  gclient setdep -r third_party/externals/swiftshader@bb12b0e41a09

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=robertphillips@google.com

Change-Id: I289b3bc4d231bd50dd5ee9dca76254aa9e898b83
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212140
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-06 04:35:09 +00:00
skia-recreate-skps
3fd1841161 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I4d14ebc855de58ff5513d0d231cdfc44473145ef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212100
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-05-05 08:54:21 +00:00
Hal Canary
ac55784e33 Tests: re-sort gni, file name convention
Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-04 02:17:09 +00:00
Ben Wagner
feae867f84 Add harfbuzz to tools/install_dependencies.sh
No-Try: true
Change-Id: Ida3e485a7b3d218833b314f7b1cf81c9a44e3f6d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212033
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-05-03 23:52:09 +00:00
Ben Wagner
8ac78aa6df Update the list of Skia dependencies
No-Try: true
Change-Id: I66652ee2ea6afa6854387f12b203908bb99aad4b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212027
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-05-03 21:31:39 +00:00
Florin Malita
1b1b657488 Fix .bzl skottie_lib_hdrs
TBR=
Change-Id: Id50b30077045477e4a6b0dfef3b9d950ac8f40f7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212023
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-05-03 19:46:55 +00:00
Ben Wagner
c5eb81bf44 Fixes for experimental/go-skia
No-Try: true
Change-Id: I7799cde0a361984ed958386d2568a959a6cf12ac
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212024
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-05-03 19:22:51 +00:00
Hal Canary
ccab1cc6f4 docs/examples/Colors
Change-Id: I61a295daacaf8a4b0350ae7fc7641059a990552a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212020
Commit-Queue: Hal Canary <halcanary@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-05-03 18:40:17 +00:00
Florin Malita
e4e9551cc8 Add explicit .bzl sources and headers lists for skottie/sksg
(to facilitate atomic repo updates)

Also remove some _INCLUDES (no longer used).

Change-Id: I9788838fb4b837b80a9ac637ab28760f9f4ccbf1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211994
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-05-03 18:35:36 +00:00
Hal Canary
70aab82354 Shaper Tests: fix g3 build
Change-Id: Ib53a9e3224bedbbbdb6d4a99e7ed1856ff9a6717
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211997
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-05-03 18:10:46 +00:00
Ethan Nicholas
7e603db010 SkSL interpreter optimizations
Bug: skia:
Change-Id: If1e4916fc40fa5799dabd446e61b840ba3a32133
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211989
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2019-05-03 17:32:36 +00:00
Hal Canary
56947a7fa3 Shaper Tests: make a macro, rename test resources.
Change-Id: Ic7bfd4784d9b2031fdcbf57e730b8c738b9ac9d3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211990
Auto-Submit: Hal Canary <halcanary@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2019-05-03 17:16:36 +00:00