Commit Graph

37263 Commits

Author SHA1 Message Date
Herb Derby
55bc0515a7 Fixup textblob benchmark
* Correctly translate glyphs
* Make subpixel
* Use subpixel positions

Change-Id: I0011fb6cc8b985c9a7bd058f8b2fbf4b525019de
Reviewed-on: https://skia-review.googlesource.com/c/160500
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-10-08 18:44:58 +00:00
Kevin Lubick
4968843293 Add BuildStats pipeline for PathKit binaries
This should be extensible to do something similar
for libskia and other outputs.

Bug: skia:
Change-Id: Id9f30a82f4eb0e7ce868a32409b1be429917e7f6
Reviewed-on: https://skia-review.googlesource.com/c/160220
Reviewed-by: Eric Boren <borenet@google.com>
2018-10-08 18:15:32 +00:00
Hal Canary
b5ccf6f09b SkPDF: centralize procsets to remove duplication
Change-Id: I32dbb88c5c28a5c44f922826516eeb2221ae4b38
Reviewed-on: https://skia-review.googlesource.com/c/160384
Auto-Submit: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-10-08 18:05:31 +00:00
Mike Reed
2aa6475887 modify gm to avoid creating t-junctions between degernate curves and lines
Bug: skia:8453
Change-Id: Id9d4d2d02eb9db4d9af1832e506b3b39a507fe32
Reviewed-on: https://skia-review.googlesource.com/c/160460
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-10-08 18:05:21 +00:00
Robert Phillips
8ad991da4c Fix Chrome roll
Change-Id: Ie9d450965a8a912f4da292d8bd8ce62612e2485a
Reviewed-on: https://skia-review.googlesource.com/c/160382
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-10-08 15:44:15 +00:00
skia-autoroll
95320ee01f Roll third_party/externals/angle2 19b51d298334..6d765b07f86f (1 commits)
19b51d2983..6d765b07f8


git log 19b51d298334..6d765b07f86f --date=short --no-merges --format='%ad %ae %s'
2018-10-08 jiajia.qin@intel.com ES31: Fix some bugs in ShaderStorageBlockOutputHLSL


Created with:
  gclient setdep -r third_party/externals/angle2@6d765b07f86f

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: I89e5519bb5ec835e22590232e5626f480488a9fe
Reviewed-on: https://skia-review.googlesource.com/c/160322
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-08 10:45:04 +00:00
skia-recreate-skps
9aa3f90956 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I23924de66b66aec4b542b30f771c24b32386be7f
Reviewed-on: https://skia-review.googlesource.com/c/160321
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-10-08 05:53:01 +00:00
skia-autoroll
beb1559bc6 Roll third_party/externals/angle2 450bf36f7918..19b51d298334 (1 commits)
450bf36f79..19b51d2983


git log 450bf36f7918..19b51d298334 --date=short --no-merges --format='%ad %ae %s'
2018-10-08 jiawei.shao@intel.com ES31: Support textureGather[Offset] on shadow samplers


Created with:
  gclient setdep -r third_party/externals/angle2@19b51d298334

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: I9e73ea5f640d4b6f9a36cdee3136b0c0b1712c0a
Reviewed-on: https://skia-review.googlesource.com/c/160320
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-08 01:59:00 +00:00
skia-recreate-skps
e9b61ef5aa Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I978db4bad062945807d64611f5b637c8b5ed20d2
Reviewed-on: https://skia-review.googlesource.com/c/160283
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-10-07 15:49:17 +00:00
skia-recreate-skps
71143d6cc0 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I2d01f6b89a747c11d070b476ab77aff51e81fd70
Reviewed-on: https://skia-review.googlesource.com/c/160281
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-10-06 05:58:23 +00:00
skia-autoroll
623d2e4120 Roll third_party/externals/angle2 78df3362ac21..450bf36f7918 (1 commits)
78df3362ac..450bf36f79


git log 78df3362ac21..450bf36f7918 --date=short --no-merges --format='%ad %ae %s'
2018-10-05 ynovikov@chromium.org Workaround Adreno driver not supporting unsized EXT_texture_rg formats


Created with:
  gclient setdep -r third_party/externals/angle2@450bf36f7918

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=mtklein@google.com

Change-Id: I3a06ba55d204883e40942abbc3ad9a87cb381848
Reviewed-on: https://skia-review.googlesource.com/c/160280
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-06 04:58:59 +00:00
Chris Dalton
29b11d605f ccpr: Delete the stashed atlas texture before allocating a new one
Bug: skia:
Change-Id: I13c13c73f6065f2eababb174361f8bfa9e62b7e2
Reviewed-on: https://skia-review.googlesource.com/c/160200
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-10-05 21:59:30 +00:00
skia-autoroll
d037f4d204 Roll third_party/externals/angle2 0ca09753392d..78df3362ac21 (7 commits)
0ca0975339..78df3362ac


git log 0ca09753392d..78df3362ac21 --date=short --no-merges --format='%ad %ae %s'
2018-10-05 oetuaho@nvidia.com Fix clearing out-of-range default FB drawbuffer
2018-10-05 geofflang@chromium.org Suppress EXTBlendFuncExtendedDrawTestES3.FragmentArrayOutputLocationsAP on MacOS
2018-10-05 jmadill@chromium.org GL back-end error refactor.
2018-10-05 syoussefi@chromium.org Vulkan: Safer struct initialization
2018-10-05 oetuaho@nvidia.com Fix constructing void array zero nodes
2018-10-05 jmadill@chromium.org Remove gl::ErrorOrResult.
2018-10-05 jmadill@chromium.org Remove gl::LinkResult.


Created with:
  gclient setdep -r third_party/externals/angle2@78df3362ac21

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=mtklein@google.com

Change-Id: Ia0f39a8d7d02a10085585ddef716f076963768bd
Reviewed-on: https://skia-review.googlesource.com/c/160180
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-05 20:10:59 +00:00
Brian Osman
ee8603c00f Cleanup bitmap/mipmap cache key structs
Use the same pattern (of just including the entire Desc) for both,
rather than manually doing all the same work in the MipMapKey. Remove
the assert about origin when making a desc from a bitmap - this can be
violated when coming in via the MipMap cache, now - and it's handled
correctly in get_bounds_from_bitmap, anyway.

This makes it simpler when I add new fields to the Desc struct.

Bug: skia:
Change-Id: I6b0bfc11a54f3a69a67e8fda7808f116080e61bb
Reviewed-on: https://skia-review.googlesource.com/c/160030
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
2018-10-05 19:50:47 +00:00
Greg Daniel
6e2625d9ae Revert "Remove ability to sample textures in vertex or geometry shaders."
This reverts commit d50d6579d1.

Reason for revert: chromes test gles test context is broken. Need to fix that then reland this

Original change's description:
> Remove ability to sample textures in vertex or geometry shaders.
> 
> Bug: skia:
> Change-Id: I69cd07a4bbe4879e855fb4aa6289a049adf4e059
> Reviewed-on: https://skia-review.googlesource.com/c/160021
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Chris Dalton <csmartdalton@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,csmartdalton@google.com

Change-Id: I309dfa5f7118cb8d7280aaf6a88e1df232bd7099
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/160163
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-10-05 19:48:07 +00:00
Cary Clark
946a690d31 fix bookmaker
add a couple of undefined terms
and make the parameter descriptions
start lowercase

NOTRY=true
R=robertphillips@google.com

Docs-Preview: https://skia.org/?cl=160160
Bug: skia:
Change-Id: I45223943ce56d9ca13e818bc5e21607b8c4ee100
Reviewed-on: https://skia-review.googlesource.com/c/160160
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Cary Clark <caryclark@skia.org>
2018-10-05 19:31:38 +00:00
Herb Derby
f3a3864290 Remove old code by moving to new API in bitmap text
Change-Id: Ic997e40406bd0d7c298a7361ee1e42023cb3be38
Reviewed-on: https://skia-review.googlesource.com/c/160101
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-10-05 19:19:58 +00:00
recipe-roller
50fd023f9b Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/acbe9e3142610d958181460254565ef27ad47dc0 [StepPresentation] Remove all logs from memory during finalization. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifcf051520a5fe727bcd8efb6f4a3c2133e2a346b
Reviewed-on: https://skia-review.googlesource.com/c/160033
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-05 18:45:50 +00:00
Herb Derby
278b0675d0 Less stress for chromecast
Change-Id: Ib32ee8f556fc44fb2d4bad3d86b874eae0dafb23
Reviewed-on: https://skia-review.googlesource.com/c/160100
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-10-05 18:32:33 +00:00
Kevin Lubick
f4def34885 Move dumpJSON behind the SK_ENABLE_DUMP_GPU flag
This should trim the code size of a WASM CanvasKit by 10-20KB.

Bug: skia:
Change-Id: Ibf0f8596c04e891e8f7cbc2fa4f1d1852f7cb462
Reviewed-on: https://skia-review.googlesource.com/c/159261
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-10-05 18:18:30 +00:00
recipe-roller
b3d6145cb7 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/85af45334ed48cc2e35ddaef0c428f701246260a [windows_sdk] Default to cache/windows_sdk. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icd03ebb284504b95863940440c415a84ae0bf3bd
Reviewed-on: https://skia-review.googlesource.com/c/160031
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-10-05 18:15:50 +00:00
Robert Phillips
51c89e41c0 Exercise newly exposed SkYUVIndex-based SkImage factories (take 2)
Bug: skia:7903
Change-Id: Ie7d0135f392b67085a23a59cb469429f9e2b0221
Reviewed-on: https://skia-review.googlesource.com/c/160029
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-10-05 18:04:58 +00:00
recipe-roller
6ddcd89248 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/0c3bd49069d44dd6c217f3db103d27bfc1272424 bot_update: Don't use apply_patch_on_gclient. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6af9ef4d5ec55f61581ecb0d05dce1fae77319e2
Reviewed-on: https://skia-review.googlesource.com/c/160028
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-05 17:46:34 +00:00
Mike Reed
360178920c trim unused SkDraw functions
Bug: skia:
Change-Id: I9fcb92c2d4057c45f6bad4594accafc1c6e31455
Reviewed-on: https://skia-review.googlesource.com/c/160025
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-10-05 17:24:53 +00:00
Greg Daniel
d50d6579d1 Remove ability to sample textures in vertex or geometry shaders.
Bug: skia:
Change-Id: I69cd07a4bbe4879e855fb4aa6289a049adf4e059
Reviewed-on: https://skia-review.googlesource.com/c/160021
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Chris Dalton <csmartdalton@google.com>
2018-10-05 17:19:50 +00:00
Greg Daniel
cfa39352c0 Remove debug only clearStencil virtual on GrGpu.
Bug: skia:
Change-Id: Ic68cd97675f554b60e84ec36d8068ce539cce6aa
Reviewed-on: https://skia-review.googlesource.com/c/159945
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-10-05 17:19:48 +00:00
Brian Osman
bd16a1bcb3 Revert "Exercise newly exposed SkYUVIndex-based SkImage factories"
This reverts commit e1c1d4d09c.

Reason for revert: Crashing on bots that abandon the GPU context

Original change's description:
> Exercise newly exposed SkYUVIndex-based SkImage factories
> 
> Bug: skia:7903
> Change-Id: I04630ebec37b087423e8305cc1716544fa00a403
> Reviewed-on: https://skia-review.googlesource.com/c/160020
> Reviewed-by: Jim Van Verth <jvanverth@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>

TBR=jvanverth@google.com,robertphillips@google.com

Change-Id: I5cd5eca3aa55feb73737643dbe05a374a6fd7842
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7903
Reviewed-on: https://skia-review.googlesource.com/c/160026
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-10-05 17:10:16 +00:00
Mike Reed
d109503b69 split out SkDraw_text functions
Bug: skia:
Change-Id: I1cbce64fe137011e664133a1ec51feaa87898529
Reviewed-on: https://skia-review.googlesource.com/c/160023
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-10-05 16:30:52 +00:00
Robert Phillips
e1c1d4d09c Exercise newly exposed SkYUVIndex-based SkImage factories
Bug: skia:7903
Change-Id: I04630ebec37b087423e8305cc1716544fa00a403
Reviewed-on: https://skia-review.googlesource.com/c/160020
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-10-05 16:18:50 +00:00
Mike Reed
dee25ccb67 split SkPaint into separate impl files
Bug: skia:
Change-Id: If82d39be1f85f9c9487e232b56c72dde175243ab
Reviewed-on: https://skia-review.googlesource.com/c/160022
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-10-05 16:17:20 +00:00
Herb Derby
434377abfb Split out SkRunFont and SkPaint
Coping paints take significant time. The ApplyFontToPaint
idiom requires a copy and a dtor. This CL keeps the paint and
font in parallel through the code until a paint is actually
needed, then a special ctor is used to create it.

Also, inline a bunch of text blob calls that were showing up
in perf.

Change-Id: I7da746a287e4d3942e45e9536ef9acdc64f084d4
Reviewed-on: https://skia-review.googlesource.com/c/159222
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-10-05 16:10:07 +00:00
Florin Malita
2c06e14697 [skottie] Optional path control points
Make parsing the in/out Bezier control points optional (default [0,0]).

Change-Id: Id1ef43cea133fab3a112e653d4ce2ab21b91effb
Reviewed-on: https://skia-review.googlesource.com/c/159980
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-10-05 16:07:01 +00:00
Brian Osman
ba651682ae Fix two bugs in GPU special image read-back
- We always read from (0, 0), even if the subset had a different origin
- We also cached the results ignoring the origin, so future reads of
  same-sized but differently positioned subsets could return previous
  and wrong bitmaps.

Added a unit test that checks for both behaviors. Originally, both
asserts triggered. Adjusting the origin in readPixels, the first assert
was fixed, but the second continued to trigger. Adding the full subset
rect to the bitmap cache key fixed the second assert.

Bug: skia:8448 skia:8449
Change-Id: Ic6e8c0976bd59e86827be89105bd02845ad0d7cd
Reviewed-on: https://skia-review.googlesource.com/c/159981
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-10-05 15:39:06 +00:00
Florin Malita
9059c23946 [skottie] Remove temporary ResourceProvider::load() fallback
All clients are now using loadImageAsset().

TBR=
Change-Id: I3d7800fc9a294b01aaa8e21a39703e01fa866a40
Reviewed-on: https://skia-review.googlesource.com/c/159946
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Auto-Submit: Florin Malita <fmalita@chromium.org>
2018-10-05 15:32:25 +00:00
Mike Reed
6be47152b6 isolate users of SkFindAndPlaceGlyph.h
This is no longer how we interact with glyphs and the cache, so trying to remove all
of the vestigal callers. Two remain, but they are not built by default
- OverdrawCanvas
- XPSDevice
so leaving them in place for now.

Bug: skia:
Change-Id: If3e6aa092b1d658cbf22e5ad56dd7f57838ee576
Reviewed-on: https://skia-review.googlesource.com/c/159780
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-10-05 15:31:54 +00:00
Robert Phillips
b6df1c1e59 Expose the SkYUVAIndex version of the SkImage factories
TBR=bsalomon@google.com
Bug: skia:7903
Change-Id: Ib5a3bdba99da4cfb79115d1ff7b2c014272a5556
Reviewed-on: https://skia-review.googlesource.com/c/159520
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>
2018-10-05 15:24:59 +00:00
Brian Osman
bbb24101e9 Remove redundant test
All special images use proxies, so this test was now identical to the
one right above it.

Bug: skia:
Change-Id: Id0358ed2417269d2f26fd255ed192e0ccbd9bcaf
Reviewed-on: https://skia-review.googlesource.com/c/159943
Auto-Submit: Brian Osman <brianosman@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-10-05 14:51:32 +00:00
recipe-roller
032f2756df Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/dfce68bcddba7508d74016405a95e7865cbf47ba [led] Roll led to handle jobs with multiple swarming TaskSlices. (iannucci@chromium.org)
  https://crrev.com/56117720565661febf2e11ec77efd71d49f778ae Increase gerrit_util retry count and delay. (skobes@chromium.org)
  https://crrev.com/dfedcc0666fe3a7e655642ec3385ecb3fb6286c0 [cipd] More careful error handling during CIPD bootstrap on Windows. (vadimsh@chromium.org)
  https://crrev.com/2174136d2520b2f030addb8466373f13f5badd39 [cipd] Add presubmit support for checking *.digests file. (vadimsh@chromium.org)
  https://crrev.com/4aedec01f5030b36be1e8a07c65d15bd7b66d567 my_activity: faster Gerrit reviews search. (tandrii@chromium.org)
  https://crrev.com/45b20c4140ba6eed7b04d0015ce4d2e566810a03 [git_cl] Fix git cl comments json stdout printing (leszeks@chromium.org)
  https://crrev.com/ea4301e5c5d22aac5fd7184966137e8303ec4740 git cl upload: print response headers on 404 Gerrit RPC status. (tandrii@chromium.org)
  https://crrev.com/f9b4845975ffaf4b7bfe7b0b6ae0198b8a729bbd [cipd] Bump CIPD client version to 2.2.8, add presubmit check for *.digests. (vadimsh@chromium.org)
  https://crrev.com/18b4479cee3fece5afeb19b79e00bc876550a749 gerrit_util: Support OAuth2 bearer tokens in CookieAuthenticator (borenet@google.com)
  https://crrev.com/0639cbc44de0ae5be7dce0896520fe158824aa69 [buildbucket] Print build url on command line with buildbucket.py (machenbach@chromium.org)
  https://crrev.com/0526335226fb1cb4c74b5204ca2136087bbc6a71 Revert "gerrit_util: Support OAuth2 bearer tokens in CookieAuthenticator" (borenet@chromium.org)
  https://crrev.com/01710d041f2cdbdbbae1c1e145eb1e23ff998e07 [cipd] Pin hashes of CIPD packages. (vadimsh@chromium.org)
  https://crrev.com/0f322bfcf5098d175ac2649b506f297838d3ac54 [bot_update] Add gclient.get_gerrit_patch_root (nodir@google.com)
  https://crrev.com/7b54572eb0c18346d82a76e85b854c3ec316a3bd [gclient] Fix typo in get_gerrit_patch_root (nodir@google.com)
  https://crrev.com/1aa405fd859a3bd625b0d61184d6e4a3cf95c0b4 Add an option to disable adding CC emails automatically (sergiyb@chromium.org)
  https://crrev.com/33f71ae4d045483e4bd63315a18fe9fad36ad3e5 [bot_update] Update examples to use buildbucket module (nodir@google.com)
  https://crrev.com/67ef3f67e816839ce8b3984ecba9406961583eff gclient: delete unversioned directory before adding cipd dep for the same path (ehmaldonado@chromium.org)
  https://crrev.com/dd2ce986ce25528f89d36a61eae82b2213292df9 [gclient] Update set_patch_project_revision (nodir@google.com)
  https://crrev.com/86c823e88d8fdbb20800066e81f06d73e640e9b8 gerrit_util: document hack. (tandrii@chromium.org)
  https://crrev.com/78eed01c0bbd387c0b6a0851918fb65f9e40bea2 [bot_update] Use get_gerrit_patch_root (nodir@google.com)
  https://crrev.com/07b5283a4ea1056007f6c2ec233411b72caa3227 Revert "gclient: delete unversioned directory before adding cipd dep for the same path" (tandrii@chromium.org)
  https://crrev.com/53e28ecb9f9505c38c01a6ed80730fc28469402f [gclient] Remove calculate_patch_root (nodir@google.com)
  https://crrev.com/15b586a4932a5760cbff9478739d19d660e69b19 Remove PATCH_PROJECT (nodir@google.com)
  https://crrev.com/79c651330b9414a1e97450c3d22f414f9bb58a92 [gclient] Remove is_blink_mode (nodir@google.com)
  https://crrev.com/77900be4e71e5ccda7d9efeca7bbff6dc5f3c597 [windows_sdk] Allow taskkill mspdbsrv to fail. (iannucci@chromium.org)
  https://crrev.com/69f640ec0900add7fd44579c181fa99ea1693005 [buildbucket] Fix printing build url (machenbach@chromium.org)
  https://crrev.com/647e1e79eb7129ecdc021b7535d90e6d06475603 Reland "gclient: delete unversioned directory before adding cipd dep for the same path" (ehmaldonado@chromium.org)
  https://crrev.com/21a51b392104d8e58860a48e417e705ff03ae460 gclient: set the push url to the actual repository instead of the mirror. (jbudorick@chromium.org)
  https://crrev.com/f837545214f5a8666c49f02c3b717bdc04604f7a [gclient] Remove patch_projects (nodir@google.com)
  https://crrev.com/e373f26c5c3b7327046ef1af22176456a19147c6 Suppress URLErrors when uploading metrics. (sdy@chromium.org)
  https://crrev.com/9cba9ffdfdc64127ee47561c0bd6a339778599f5 Add the crcmod wheel for gsutil, to get it to shut up. (dpranke@chromium.org)
  https://crrev.com/7e301cfffe7fe9e1f912ecfcf0624e0fbded7517 [gclient] Use canonical URLs in solutions (nodir@google.com)
  https://crrev.com/92df4e63abbe9ffe24ff632927acea5523112aeb Revert "[gclient] Use canonical URLs in solutions" (nodir@chromium.org)
  https://crrev.com/8bdc1b8a0433e3e0737bab3a31bd6fba39383610 my_activity: add --completed-issues option. (tandrii@chromium.org)
  https://crrev.com/aaf2cc09c6874e394c6c1e4692360cc400d6b388 Implement --no-autocc flag for Gerrit (sergiyb@chromium.org)
  https://crrev.com/a06cd091a9e2c9017058f55ce19d7d7a97dcd727 Revert "git cl upload: print response headers on 404 Gerrit RPC status." (ajp@chromium.org)
  https://crrev.com/482d615b83e1a498a2cb3549dc3ad683bab3e78f Revert "my_activity: Add review.coreboot.org as a source" (gab@chromium.org)
  https://crrev.com/64b61330ec7f3632d5eb1ea97133ce11f3bf6627 [led] Roll led to fix missing expiration_secs issue. (iannucci@chromium.org)
  https://crrev.com/d4c867355a8bc3b62fa53d886d229632435c3172 git cl: use explicit Gerrit mirrors on 404s during upload. (tandrii@chromium.org)
  https://crrev.com/8e64369342f22b0541d438bac748c93fe4b8d14e git cl: delete old support code for Git Numberer with Rietveld. (tandrii@chromium.org)
  https://crrev.com/c4a7356a469b3b6267965d7bcc318cf35cdd3b62 git cl: cache also LABELS data on a change. (tandrii@chromium.org)
  https://crrev.com/d9fdc1f5b5ded0b2b8189a08b3f45dcdbc5951dd git cl: save description before doing any RPCs during upload. (tandrii@chromium.org)
  https://crrev.com/95d4c855637a039f4befbef17af1708ae06386b0 Add skia reviews to my_activity (enne@chromium.org)
  https://crrev.com/0daedf7758e157ee22a64e9dabcb089c0da5ef4c Remove agable, bradleynelson from //OWNERS. (dpranke@chromium.org)
  https://crrev.com/22300e1fb562291b55eb702fe73b164cb1a2317d [led] Roll led to add gerritcodereview scope to edit-cr-cl (iannucci@chromium.org)
  https://crrev.com/6af3aa85495695d609a881ad1c75fd2aa5407135 Support omitting the space after -C (brucedawson@chromium.org)
  https://crrev.com/c08566e6e27cf671133e2787fd49ca9451535163 Add non --full support to python git cl format (abenner@google.com)
  https://crrev.com/684313d6a319a33b8aef29cd0600e2dcbe26f8db gclient setdep doesn't need to update_depot_tools (oprypin@webrtc.org)
  https://crrev.com/b250ec16d39169c4f7df3f9ae40230934d0f4ddb [git_cl] Don't check .gitcookies when running on LUCI. (vadimsh@chromium.org)
  https://crrev.com/e8f574a2167a69418b45ada45f178faca7bad83a Remove git-crsync (asanka@chromium.org)
  https://crrev.com/5b1fa949bba4c75c88aead94948d89c6cb161e0c gclient: Sync CIPD deps before running hooks. (ehmaldonado@chromium.org)
  https://crrev.com/f98905e8f03cd79d132cdd72bf4af1bb5fa3ca0b [led] Roll led to fix broken Milo annotation stream. (hinoka@google.com)
  https://crrev.com/2fb6310237302dd249452470fcddeaaf2eb3941d Reland gerrit_util: Support OAuth2 bearer tokens in CookieAuthenticator (borenet@google.com)
recipe_engine:
  https://crrev.com/5831fa01c47fb7248495566e80d4d049c47d3f78 Fix config.Dict.schema_proto. (nodir@google.com)
  https://crrev.com/1f3949c4d11c89d35d1e4c688c3a1c14985bdad7 [file] Fix naming conflict bug in flatten_single_directories. (iannucci@chromium.org)
  https://crrev.com/04e26b62818d4848aed3631d9c58c2d41ecc2ed8 [buildbucket] Pass v2 build as a dict, not base64 bytes (nodir@google.com)
  https://crrev.com/241d879a3dee0f9f1a0dc8933dc67f24e0d33391 analyze: Output field default values (martiniss@google.com)
  https://crrev.com/b8db432be1add133ef005e17d5729c537349f2c9 analyze.py: Actually include default fields (martiniss@google.com)
  https://crrev.com/f7a834467c55fc302e5da1bdc0ef78c7bdecf2d9 Add comment to failing_step to indicate that it raises an exception. (erikchen@chromium.org)
  https://crrev.com/7a22cddcd7f3255e357a63c73df4396a43def8cd [context] Stringify name_prefix if unicode in api.context (joshuaseaton@google.com)
  https://crrev.com/ecba3385f199e9f9aecf783d7ce8d87c23775640 [buildbucket] Add bucket_v1 property (nodir@google.com)
  https://crrev.com/ec1f045f324fd25c985a60cdcddb913f82da0490 Add AnnotationContains post processing step (erikchen@chromium.org)
  https://crrev.com/702c6847b3cc129007d58f1ba864b009e820c11e [buildbucket] Populate created_by from legacy property (nodir@google.com)
  https://crrev.com/4232dd9f1c5aa35874d70634ae86f1cc4720bc6a Add documentation for placeholders. (erikchen@chromium.org)
  https://crrev.com/673743d3e861ad9c6d9a8cc71088f4be7d01a1bb [buildbucket] add builder_name (nodir@google.com)
  https://crrev.com/39df254c20b7052fed669e3319036b20f96e75e3 [buildbucket] Fix typo. (nodir@google.com)
  https://crrev.com/66dfa7cca67be5376d6cb54b462e9ccd832e4f01 [buildbucket] Add gitiles_commit shortcut (nodir@google.com)
  https://crrev.com/ad0e2563a79f19f916cf2939811a2019dec16386 Improve local execution of recipes (martiniss@google.com)
  https://crrev.com/d5fd7cc14d7f0a82d1358617f1ec94c4417ec85e [buildbucket] Split try_build/ci_build (nodir@google.com)
  https://crrev.com/da81755358cf32a496ed8a9eddf6ec6d4f0efd18 post_process: Add StepCommandContains check. (jbudorick@chromium.org)
  https://crrev.com/65fffecb2f6a041d71107292b1453a92ab1127fc Add post_process functions for asserting on a step's command. (gbeaty@chromium.org)
  https://crrev.com/dc1bf00db5252bb54dd09745865c3160778a882d Fix cmd error in StepCommandContains check (aluo@chromium.org)
  https://crrev.com/7d52a83204be2083edfc82042b13769846db9dff Update the recipes user guide to use post_process. (gbeaty@chromium.org)
  https://crrev.com/9f1afcb08b95a9c2cbae653dd320cd84d62287ff raw_io: pipe placeholder name through for input placeholders. (jbudorick@chromium.org)
  https://crrev.com/840950f4bfb6469b4ff72ae4e54ab5c0f5e71116 [cipd] Fix typo in pkg-deploy method. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id1922dd605a1b399b52c52e58d7908ab308575d5
Reviewed-on: https://skia-review.googlesource.com/c/159942
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-10-05 14:34:47 +00:00
Mike Klein
b3ce196a4d de-guard SK_LEGACY_TF_APPLY
Didn't need it after all.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I85685c3d838053269b10327ecf31f85c4fea1d67
Reviewed-on: https://skia-review.googlesource.com/c/159940
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-05 11:39:08 +00:00
skia-autoroll
a6262495da Roll third_party/externals/angle2 14246813a110..0ca09753392d (1 commits)
14246813a1..0ca0975339


git log 14246813a110..0ca09753392d --date=short --no-merges --format='%ad %ae %s'
2018-10-05 oetuaho@nvidia.com Add GLES3 support for EXT_blend_func_extended


Created with:
  gclient setdep -r third_party/externals/angle2@0ca09753392d

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=mtklein@google.com

Change-Id: Ie1fd11b9c0982fcb86a3e095f3bfb77af01b4b53
Reviewed-on: https://skia-review.googlesource.com/c/159920
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-05 11:18:54 +00:00
skia-bookmaker
92d10833de Update markdown files
Automatic commit by the Housekeeper-Nightly-Bookmaker bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Ic67d7c882ee7b17e439e23764fe26177494c2606
Reviewed-on: https://skia-review.googlesource.com/c/159901
Reviewed-by: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
2018-10-05 05:58:29 +00:00
skia-recreate-skps
787bb77798 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I105314b8ce6eed61421bee7865dddcc4d1ac975b
Reviewed-on: https://skia-review.googlesource.com/c/159900
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-10-05 05:52:48 +00:00
skia-autoroll
4f87e2255b Roll third_party/externals/angle2 76dd2d6f9f5e..14246813a110 (4 commits)
76dd2d6f9f..14246813a1


git log 76dd2d6f9f5e..14246813a110 --date=short --no-merges --format='%ad %ae %s'
2018-10-04 jmadill@chromium.org Update sampler directly on Texture change.
2018-10-04 jmadill@chromium.org Update Textures immediately on program change.
2018-10-04 fjhenigman@chromium.org Vulkan: read pixel buffer alignment must be 4.
2018-10-04 syoussefi@chromium.org Roll VK and SPIR-V deps forward


Created with:
  gclient setdep -r third_party/externals/angle2@14246813a110

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=mtklein@google.com

Change-Id: I91b175816606fca9142342c353c57e0b810304a5
Reviewed-on: https://skia-review.googlesource.com/c/159860
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-05 02:32:47 +00:00
Chris Dalton
1b4ad76562 ccpr: Unblacklist PowerVR Rogue
Tweaks some workarounds and re-allows PowerVR Rogue.

Bug: skia:8098
Change-Id: I0fca7380f8f071928ee9ffd18fcfb4c9abe99009
Reviewed-on: https://skia-review.googlesource.com/c/159184
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-10-05 01:02:31 +00:00
Mike Klein
d945698c5d remove SkColorSpaceTransferFn::operator()()
Looks like SkColorSpaceXformSteps is its only user,
and it can easily switch over to skcms instead.

We're now making 3-6 function calls instead of inlining,
but on the other hand, they're replacing 3-6 calls to powf()...

Guarded with SK_LEGACY_TF_APPLY.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I502d4b3979a4e912820c925b63a174406801be0b
Reviewed-on: https://skia-review.googlesource.com/c/159762
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-10-04 22:35:03 +00:00
Mike Klein
7e587330c8 Reland "remove deprecated SkRect::MakeFromIRect()"
This is a reland of 4fea17393a

Original change's description:
> remove deprecated SkRect::MakeFromIRect()
> 
> Needs https://chromium-review.googlesource.com/c/chromium/src/+/1261818
> 
> Change-Id: I529a2cd16d46ad13bc1eb9d3746e3587e25e9dbe
> Reviewed-on: https://skia-review.googlesource.com/c/159481
> Reviewed-by: Cary Clark <caryclark@google.com>

Change-Id: I53e5b23f765d5b28df50bea70cd8d8f9aac7e740
Reviewed-on: https://skia-review.googlesource.com/c/159821
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-04 22:05:27 +00:00
Chris Dalton
b7e0371650 ccpr: Fix a divide-by-zero in corner attenuation
Bug: skia:8098
Change-Id: I4ab1a9872a483b971b5e2e1903bf9ca61713eb01
Reviewed-on: https://skia-review.googlesource.com/c/159700
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-10-04 21:52:17 +00:00
Hal Canary
2e01805298 SkDynamicMemoryWStream: make moveable
Motivation:  using this in an experiment of mine (I want a
std::vector<SkDynamicMemoryWStream>.)

Change-Id: I28e2c468156ace2f9e7d5e09937e05bc8b7e8200
Reviewed-on: https://skia-review.googlesource.com/c/159326
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-10-04 21:29:49 +00:00
Mike Klein
4302eb9a6e Revert "remove deprecated SkRect::MakeFromIRect()"
This reverts commit 4fea17393a.

Reason for revert: one more in Google3.

Original change's description:
> remove deprecated SkRect::MakeFromIRect()
> 
> Needs https://chromium-review.googlesource.com/c/chromium/src/+/1261818
> 
> Change-Id: I529a2cd16d46ad13bc1eb9d3746e3587e25e9dbe
> Reviewed-on: https://skia-review.googlesource.com/c/159481
> Reviewed-by: Cary Clark <caryclark@google.com>

TBR=mtklein@google.com,caryclark@google.com

Change-Id: I02872a3dd6031e360ce7c1988c8a73c9b7096067
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/159820
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-04 20:57:58 +00:00
Mike Klein
d295dff5c6 remove SkColorSpaceTransferFn::invert()
Looks like DM may be its only user?
That was me and just for convenience... I can fold it through.

Change-Id: I4ed6ee659df4192e3d6db7ce5b055c4c923673bd
Reviewed-on: https://skia-review.googlesource.com/c/159761
Reviewed-by: Brian Osman <brianosman@google.com>
2018-10-04 20:33:20 +00:00