Commit Graph

17396 Commits

Author SHA1 Message Date
bsalomon
ab622c7b8c Move instanced index buffer creation to flush time
Review URL: https://codereview.chromium.org/1116943004
2015-05-04 08:09:30 -07:00
borenet
f15132fdcf Support SKIA_OUT on Mac and ChromeOS
BUG=skia:3774

Review URL: https://codereview.chromium.org/1122593003
2015-05-04 08:04:28 -07:00
joshualitt
edae3096af Revert of Move state management to GrInOrderDrawBuffer (patchset #4 id:60001 of https://codereview.chromium.org/1120143002/)
Reason for revert:
Breaks windows

Original issue's description:
> Move state management to GrInOrderDrawBuffer
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/5d6bb6f795143ca360b868560b52165de51fa269

TBR=bsalomon@google.com,robertphillips@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1119353002
2015-05-04 07:51:09 -07:00
joshualitt
5d6bb6f795 Move state management to GrInOrderDrawBuffer
BUG=skia:

Review URL: https://codereview.chromium.org/1120143002
2015-05-04 07:41:40 -07:00
tfarina
8566539f98 Update src/svg to follow C++11 style rule for {virtual,override}.
The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual
and final implies both virtual and override.

The entries were found using the following command line:

$ find src/ -iname "*.h" -o -iname "*.cpp" | xargs pcregrep -M
"[^\n/]+virtual\ [^;{]+\ [a-zA-Z0-9_]+\([^;{]+\ override[ \n]*[;{]"

The regex was a courtesy of nick@chromium.org

BUG=None
R=mtklein@google.com

Review URL: https://codereview.chromium.org/1123573004
2015-05-04 06:40:31 -07:00
gen.kim
b9ed884578 SkPictureShader: scale down if width or height is larger than maxTextureSize
Grdient renders black because of failure onCreateTexture
if one of width or height is larger than maxTextureSize
with --force-gpu-rasterization.

BUG=chromium:473166

Review URL: https://codereview.chromium.org/1101513004
2015-05-03 22:36:30 -07:00
skia.buildbots
05f7d5cbd8 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/1124513002
2015-05-03 01:03:55 -07:00
reed
34fdcae28e remove unneeded SK_SUPPORT_LEGACY_IMAGEFILTER_TO_COLORFILTER flag
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1120033003
2015-05-02 08:00:03 -07:00
joshualitt
40ded32418 Add hairlines batch unit test
BUG=skia:

Review URL: https://codereview.chromium.org/1119563002
2015-05-02 07:07:17 -07:00
joshualitt
4af6580b44 Fix for valgrind
TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1127453002
2015-05-02 06:58:10 -07:00
joshualitt
99c7c07e0f Move bounds to GrBatch
BUG=skia:

Review URL: https://codereview.chromium.org/1121463002
2015-05-01 13:43:30 -07:00
reed
a499f905e9 clean up pre-storage in canvas
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1117213003
2015-05-01 09:34:31 -07:00
joshualitt
3dc2ccae6c Simple CL to add a joinWithPossiblyEmptyArg to SkRect
BUG=skia:

Review URL: https://codereview.chromium.org/1118293002
2015-05-01 08:51:48 -07:00
halcanary
f7a169e225 SkPDF: clean up uses of deprecated calls in tests
BUG=skia:3585

Review URL: https://codereview.chromium.org/1106163002
2015-05-01 07:35:45 -07:00
halcanary
0b9d4118ba SkTime: return timezone information; format in ISO-8601
Motivation: PDF/A metadata will need the creation date embedded in it.

Also, GetDateTime returns local time in Win32.  This now behaves the
same as on Unix systems.

BUG=skia:3110

Review URL: https://codereview.chromium.org/1109593002
2015-05-01 07:06:23 -07:00
bsalomon
d309e7aa0e This replaces the texture creation/caching functions on GrContext with a GrTextureProvider interface. The goal is to pass this narrowly focused object in places that currently take a GrContext but don't need and shouldn't use its other methods. It also has an extended private interface for interacting with non-texture resource types.
Review URL: https://codereview.chromium.org/1107973004
2015-04-30 14:18:54 -07:00
bungeman
3ffa126066 Move resource fonts to common location.
Move resource fonts to resources/fonts, add a destortable font for
testing, and clean up how the tests create fonts from resources.

R=joshualitt@google.com

Review URL: https://codereview.chromium.org/1120823002
2015-04-30 17:12:58 -04:00
joshualitt
a09c046146 Simple CL to Compute bounds in GrContext::drawVertices
BUG=skia:

Review URL: https://codereview.chromium.org/1117953003
2015-04-30 14:03:02 -07:00
joshualitt
3e708c53f7 Add batch unit tests for ovals
BUG=skia:

Review URL: https://codereview.chromium.org/1108403005
2015-04-30 13:49:27 -07:00
reed
1c2c441fed add heuristic to pour small pictures into recordings, rather than ref'ing
BUG=skia:

Review URL: https://codereview.chromium.org/1118693003
2015-04-30 13:09:25 -07:00
mtklein
4f7ec55f71 Make SkAutoTDelete's operator T*() const, like all the others.
BUG=skia:

Review URL: https://codereview.chromium.org/1114043005
2015-04-30 12:06:19 -07:00
senorblanco
d298121f5d Fix gpu memory accounting for auto-resolving MSAA.
BUG=skia:

Review URL: https://codereview.chromium.org/1115233002
2015-04-30 12:06:10 -07:00
skia.buildbots
af2bd098ee Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1118053002
2015-04-30 10:59:13 -07:00
mtklein
0690735478 Add missing include to SkPictureContentInfo.
BUG=skia:

Review URL: https://codereview.chromium.org/1113023003
2015-04-30 09:15:44 -07:00
joshualitt
a30009bec5 simple cleanup in GrTargetCommands
BUG=skia:

Review URL: https://codereview.chromium.org/1116923003
2015-04-30 09:05:54 -07:00
robertphillips
f83be823e4 Fix for texture allocation failure in 'preAbandonGpuContext' mode
Review URL: https://codereview.chromium.org/1118723003
2015-04-30 08:55:06 -07:00
reed
dc3088570f use pathops utils to improve precision of cubic chopping in scan converter
BUG=skia:

Review URL: https://codereview.chromium.org/1113963002
2015-04-30 07:47:13 -07:00
dongseong.hwang
30297c53bd Fix build warning: 'this' pointer cannot be null in well-defined C++ code; comparison may be assumed to always evaluate to true [-Wtautological-undefined-compare]
Review URL: https://codereview.chromium.org/1109933003
2015-04-30 07:47:05 -07:00
mtklein
f1d6df772e Looks like rssPages * pageSize is overflowing on 32-bit Linux...
... resulting in apparently negative memory usage:

  (-2040/2058MB  5867) 1.81s    serialize-8888 skp  top25desk_google_com_calendar_.skp

Turns out long is 32-bit there, long long is 64-bit.

NOTREECHECKS=true

BUG=skia:

Review URL: https://codereview.chromium.org/1117923002
2015-04-30 07:35:28 -07:00
mtklein
d75c466ef5 DM+nanobench: print both current and max RSS.
out/Debug/dm:
    ( 360/380 MB  2112) 396ms   gpu gm  xfermodes

out/Release/nanobench:
    32/33  MB 1659    2.46µs  2.55µs  2.54µs  2.67µs  2%  ▄▄▄▅▅▃▂▁▂█  gpu gradient_conicalZero_clamp_hicolor

out/Debug/nanobench:
    42/42  MB   desk_css3gradients.skp_1    8888

BUG=skia:

NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1115203002
2015-04-30 07:11:22 -07:00
dongseong.hwang
181d7ba4cd Fix build warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; comparison may be assumed to always evaluate to true [-Wtautological-undefined-compare]
Review URL: https://codereview.chromium.org/1110353003
2015-04-30 05:53:27 -07:00
skia.buildbots
10fb0a6df8 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/1118683002
2015-04-30 05:19:38 -07:00
bungeman
6837b38a62 Check for NULL familyName in SkFontMgr_fontconfig.
If the familyName is NULL, don't bother spending time trying to add
it to the FcPattern.

Review URL: https://codereview.chromium.org/1115073002
2015-04-29 14:35:50 -07:00
cdalton
9954bc38c4 Use texture barriers to read directly from the RT
Updates GrXferProcessor to read directly from the RT texture when
texture barriers are supported and it needs to know the dst color.
Also adds the notion of an Xfer barrier and uses it to issue texture
barriers when the XP will read the RT.

BUG=skia:

Review URL: https://codereview.chromium.org/1040303002
2015-04-29 14:17:00 -07:00
reed
dbc3cefb0b Use colorfilter instead of imagefilter when possible
needs https://codereview.chromium.org/1115713003 to land first in chrome

BUG=skia:

Review URL: https://codereview.chromium.org/986353002
2015-04-29 12:18:57 -07:00
egdaniel
29bee0fe65 Make XPFragmentBuilder only Builder with access to DstCopy.
Plus a bunch of renaming.

BUG=skia:

Review URL: https://codereview.chromium.org/1110033004
2015-04-29 11:54:42 -07:00
bungeman
1d4ec0a1ad FontConfig character/lang match requires weak family.
In FontConfig the normal priority order of matches is character, family,
language; however family can be marked as weak which changes the order to
character, language, family. This is what is desired in
matchFamilyStyleCharacter.

Review URL: https://codereview.chromium.org/1118553002
2015-04-29 11:32:57 -07:00
joshualitt
fa2008ff6e Add dash lines batch unit test
BUG=skia:

Review URL: https://codereview.chromium.org/1108053004
2015-04-29 11:32:06 -07:00
jvanverth
e9c0fc616d Pull out shader-specific caps into GrShaderCaps and GrGLSLCaps
BUG=skia:

Review URL: https://codereview.chromium.org/1116713002
2015-04-29 11:18:05 -07:00
rmistry
23c5f51371 Handpick 16 Skia page sets to create SP enabled SKPs from
Context is in: https://code.google.com/p/skia/issues/detail?id=3763#c18

NOTRY=true
BUG=skia:3763

Review URL: https://codereview.chromium.org/1115003002
2015-04-29 10:15:07 -07:00
cdalton
3596482cc7 Fix double blend in GrAAConvexPathRenderer
Updates GrAAConvexPathRenderer to not draw the interior fan of a
convex path when it does not exist (i.e when segment count <= 2).

TODO: We should also detect and combine colinear segments in order to
make sure we catch every case.

BUG=skia:

Review URL: https://codereview.chromium.org/1094293002
2015-04-29 10:14:03 -07:00
joshualitt
3f655f34a2 Initial CL to create GrBatchTest infrastructure
BUG=skia:

Review URL: https://codereview.chromium.org/1109153004
2015-04-29 10:01:22 -07:00
reed
61f501f8c6 onCreateDevice -> NULL now means the caller should create its own (bitmap) device
BUG=skia:

Review URL: https://codereview.chromium.org/1116453002
2015-04-29 08:34:00 -07:00
caryclark
aec2510125 minor fixes to cubics code and overall alignment of how bounds and tops are computed for all curve types
All but 17 extended tests work.

A helper function is privately added to SkPath.h to permit a test to modify a given point in a path.

BUG=skia:3588

Review URL: https://codereview.chromium.org/1107353004
2015-04-29 08:28:30 -07:00
msarett
97fdea6c43 Implementing a scanline decoder for jpeg
BUG=skia:3257

Review URL: https://codereview.chromium.org/1092303003
2015-04-29 08:17:15 -07:00
mtklein
2420e10d5a Straighten out SkPicture::AccelData APIs.
Must have been we needed them to be weird (mutable, const setter) before.
It doesn't look like that's necessary now... we can just pass it to the
constructor.

BUG=skia:

Review URL: https://codereview.chromium.org/1112833003
2015-04-29 08:16:50 -07:00
bungeman
c64239a466 Remove system call in DW for default font.
The last user of the GDI default font in DW is
onMatchFamilyStyleCharacter and it doesn't appear to actually need
to use it. This change removes a system call, making things a bit
faster, as well as eliminating a call blocked in the sandbox.

BUG=chromium:459056

Review URL: https://codereview.chromium.org/1107283003
2015-04-29 08:15:31 -07:00
msarett
9e43cabaa1 Requires a minor API change to pass the color table to getScanlineDecoder, as we do with getPixels().
BUG=skia:3722

Review URL: https://codereview.chromium.org/1061713007
2015-04-29 07:38:43 -07:00
rmistry
385e88cc16 Create SP enabled SKPs from only the top_25_smooth page set.
Context is here: https://code.google.com/p/skia/issues/detail?id=3763#c14

BUG=skia:3763
NOTRY=true

Review URL: https://codereview.chromium.org/1111273003
2015-04-29 07:26:33 -07:00
bsalomon
ecb8e3e394 Remove unneeded features from GrBufferAllocPool
Review URL: https://codereview.chromium.org/1103423004
2015-04-29 04:33:52 -07:00