msarett
c29cd72df2
Make png filter functions compatible with libpng
...
We hope to upstream these functions to libpng (a C library).
Let's make the code that Skia tests on look like the code
that we are submitting.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1699953002
Review URL: https://codereview.chromium.org/1699953002
2016-02-16 08:04:34 -08:00
bsalomon
18fab30d7c
Modify interface to GrPathUtils::convertCubicToQuads
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1694403003
Review URL: https://codereview.chromium.org/1694403003
2016-02-16 08:00:05 -08:00
bsalomon
b8fea97a7a
Make copySurface work for texture dsts, return a bool, & add unit test.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684313002
Committed: https://skia.googlesource.com/skia/+/7ea5e28065e5eb797e95f5d81c1a65cf3209d741
Review URL: https://codereview.chromium.org/1684313002
2016-02-16 07:34:17 -08:00
scroggo
9dec5d2acd
Make SkRWBuffer destruct safely
...
Check for NULL before calling unref.
Add a test.
BUG=483369
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1691383002
Review URL: https://codereview.chromium.org/1691383002
2016-02-16 06:59:18 -08:00
joshualitt
ddd22d8645
Remove last bit of privacy violation for GrAtlasTextBlob
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1698503002
Review URL: https://codereview.chromium.org/1698503002
2016-02-16 06:47:52 -08:00
mtklein
6f65957335
Setup for -Fast GCE bot.
...
I'd like a bot that has got optimization turned up to 11,
to let us test things that our Chrome-like bots normally can't.
(Not quite ready to commit this bot to -ffast-math yet.)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1704473002
Review URL: https://codereview.chromium.org/1704473002
2016-02-16 06:42:51 -08:00
update-skps
03000094ca
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1698013005
Review URL: https://codereview.chromium.org/1698013005
2016-02-16 06:42:46 -08:00
reed
66a6589478
starter kit for colorspaces
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1692893003
TBR=jvanverth
Review URL: https://codereview.chromium.org/1695353002
2016-02-15 14:26:14 -08:00
msarett
b30d6984e6
Fix colorType/alphaType checks in SkCodec
...
Make getPixels() and startScanlineDecode() behave
consistently.
Require that kGray8 decodes are opaque.
Assert that creating the swizzler succeeds.
BUG=skia:4203
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1695473002
Committed: https://skia.googlesource.com/skia/+/c7578b6cdd03b61f076ffc7956efd952d6c301c0
Review URL: https://codereview.chromium.org/1695473002
2016-02-15 10:18:45 -08:00
reed
8681e60b2c
make SkComposeShader.h private
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1697523003
Review URL: https://codereview.chromium.org/1697523003
2016-02-15 08:27:14 -08:00
reed
a34be68a7e
blitters for sRGB and float16
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1697863002
Review URL: https://codereview.chromium.org/1697863002
2016-02-15 07:48:35 -08:00
brianosman
bd6366a69e
Roll back ellipse logic for now. This was (probably) still wrong.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1692303003
Review URL: https://codereview.chromium.org/1692303003
2016-02-14 10:33:03 -08:00
update-skps
fdb627dcc6
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1696023002
Review URL: https://codereview.chromium.org/1696023002
2016-02-14 00:47:34 -08:00
benjaminwagner
1751dc74f9
Revert of Add infastructure for gl_SampleMask (patchset #6 id:100001 of https://codereview.chromium.org/1690963003/ )
...
Reason for revert:
Several bots failing with error 'invalid profile "es" for version 320'.
Original issue's description:
> Add infastructure for gl_SampleMask
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1690963003
>
> Committed: https://skia.googlesource.com/skia/+/533cefe5b9c7cec2592fc7ca00ee4cf69a26c094
TBR=egdaniel@google.com ,bsalomon@google.com,cdalton@nvidia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1693113002
2016-02-12 15:20:55 -08:00
msarett
deabdb5b97
Revert of Fix colorType/alphaType checks in SkCodec (patchset #5 id:80001 of https://codereview.chromium.org/1695473002/ )
...
Reason for revert:
Really bad images in Gold.
Original issue's description:
> Fix colorType/alphaType checks in SkCodec
>
> Make getPixels() and startScanlineDecode() behave
> consistently.
>
> Require that kGray8 decodes are opaque.
>
> Assert that creating the swizzler succeeds.
>
> BUG=skia:4203
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1695473002
>
> Committed: https://skia.googlesource.com/skia/+/c7578b6cdd03b61f076ffc7956efd952d6c301c0
TBR=scroggo@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4203
Review URL: https://codereview.chromium.org/1694023002
2016-02-12 15:00:10 -08:00
msarett
3478f753ff
Adding a tool to get images from skps
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1696763002
Review URL: https://codereview.chromium.org/1696763002
2016-02-12 14:47:09 -08:00
reed
5ab17ed12e
re-emable u64 gm
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1692903002
TBR=mtklein
Review URL: https://codereview.chromium.org/1692903002
2016-02-12 14:43:18 -08:00
mtklein
97120a7ed1
Revert of SkNx refactoring (patchset #4 id:60001 of https://codereview.chromium.org/1690633003/ )
...
Reason for revert:
Precautionary revert for chromium:586487
Original issue's description:
> SkNx refactoring
>
> - add back Sk4i typedef
> - define SSE casts in terms of Sk4i
> * uint8 <-> float becomes uint8 <-> int <-> float
> * uint16 <-> float becomes uint16 <-> int <-> float
>
> This has the nice side effect of specializing uint8 <-> int
> and uint16 <-> int, which are useful in their own right.
>
> There are many cast specializations now, some of which call each other.
> I have tried to arrange them in some sort of sensible order, subject to
> the constraint that those called must precede those who call.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1690633003
> CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/c1eb311f4e98934476f1b2ad5d6de772cf140d60
TBR=herb@google.com ,mtklein@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:586487
Review URL: https://codereview.chromium.org/1696903002
2016-02-12 14:19:06 -08:00
mtklein
fed90d4712
Try fixing unused-variable warnings another way.
...
If we mark these as extern, the compiler won't complain they're unused.
This is an unsatisfying hack, but last time we tried to condition these
on non-NEON only, Chromium's GN linux ARM bot failed. They must not be
configured to use the NEON procs?
BUG=skia:4798
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1699473002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/1699473002
2016-02-12 13:56:13 -08:00
cdalton
533cefe5b9
Add infastructure for gl_SampleMask
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1690963003
Review URL: https://codereview.chromium.org/1690963003
2016-02-12 13:24:26 -08:00
msarett
c7578b6cdd
Fix colorType/alphaType checks in SkCodec
...
Make getPixels() and startScanlineDecode() behave
consistently.
Require that kGray8 decodes are opaque.
Assert that creating the swizzler succeeds.
BUG=skia:4203
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1695473002
Review URL: https://codereview.chromium.org/1695473002
2016-02-12 13:07:15 -08:00
msarett
dae774eff4
Sync DEPS to clang compatible arm v8 assembly for libjpeg-turbo
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1697623002
Review URL: https://codereview.chromium.org/1697623002
2016-02-12 13:06:30 -08:00
mtklein
c089ba5d69
followups
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1693823005
Review URL: https://codereview.chromium.org/1693823005
2016-02-12 12:58:10 -08:00
mtklein
c34940ec16
Remove check for platform_tools/android/third_party/externals.
...
We don't sync anything into it anymore, so a fresh gclient sync won't create it.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1694813004
Review URL: https://codereview.chromium.org/1694813004
2016-02-12 12:54:15 -08:00
khushalsagar
ebc465b8f2
Add support for caching font files in the Android SkFontMgr.
...
SkFontMgr_Android lazily access font files from disk, which is not
possible when it is used in the renderer sandbox on Linux. Add a flag to
SkFontMgr_Android_CustomFonts for caching readonly FILE streams when
creating the font mgr.
Since the font mgr is created before the sandbox is initialized, it can
access these files on initialization, and use these cached streams safely
for its lifetime.
Review URL: https://codereview.chromium.org/1673373003
2016-02-12 12:42:49 -08:00
msarett
70e418b468
Make SkJpegCodec compatible with libjpeg
...
BUG=skia:4470
BUG=skia:4520
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1687863003
Review URL: https://codereview.chromium.org/1687863003
2016-02-12 12:35:49 -08:00
benjaminwagner
e6af96a889
Change ScalarTo256 to more efficient implementation.
...
The previous implementation was likely more efficient when SkScalar was SkFixed.
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1693683002
Review URL: https://codereview.chromium.org/1693683002
2016-02-12 12:19:14 -08:00
mtklein
013475a272
Put all XSAN bots on the same DEPS-sourced build of Clang.
...
This adds LLVM, Clang, and compiler-rt (*san tools) to DEPS,
then uses them from xsan_build, building them if needed.
This is similar to how the CMake bots bootstrap CMake if needed.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1693733003
Review URL: https://codereview.chromium.org/1693733003
2016-02-12 12:15:23 -08:00
cdalton
c08f196648
Use noperspective interpolation for 2D draws
...
Adds a mechanism to notify GrGLSLVaryingHandler that a shader will not
emit geometry in perspective. This gives it a chance to use the
noperspective keyword if it is supported.
Updates the existing processors to notify the varying handler when
there is no perspective.
Begins using the noperspective keyword in GrGLGpu internal shaders.
Web scenes with observable benefit (Pixel C, gpu config):
tabl_nofolo.skp 4.62 -> 3.33 ms 28%
desk_tigersvg.skp 26.5 -> 24 ms 9%
desk_pokemonwiki.skp 16.1 -> 14.9 ms 7%
tabl_deviantart.skp 3.97 -> 3.7 ms 7%
desk_gws.skp 3.85 -> 3.65 ms 5%
Also adds new methods for creating varyings with flat interpolation.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1673093002
Review URL: https://codereview.chromium.org/1673093002
2016-02-12 12:14:06 -08:00
bsalomon
083617b9a7
Make copySurface work in more situations.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1693923002
Review URL: https://codereview.chromium.org/1693923002
2016-02-12 12:10:14 -08:00
ethannicholas
0a0520afcc
added clip visualization to skiaserve
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1690023004
Review URL: https://codereview.chromium.org/1690023004
2016-02-12 12:06:53 -08:00
jbroman
bbfe47bd0f
Add a dependency from the debugger on tools.gyp:url_data_manager.
...
BUG=skia:4947
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1695753003
Review URL: https://codereview.chromium.org/1695753003
2016-02-12 11:29:23 -08:00
brianosman
c6052ac41a
Put back the 0.5 bias in the shader. Only adjust the radii for the geometry, not the radii constants.
...
After working through this with Jim, this is more mathematically correct, and also accounts for the inner radius.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1692683003
Review URL: https://codereview.chromium.org/1692683003
2016-02-12 10:20:01 -08:00
ethannicholas
de8e54ccfd
skiaserve now retains the graphics context rather than creating a new one each request
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1693893002
Review URL: https://codereview.chromium.org/1693893002
2016-02-12 10:09:34 -08:00
djsollen
2a8fcb4647
Update Android framework makefile to build static and shared libs
...
Also use static lib for testing tools and expose includes needed for
other framework testing tools to statically link in Skia.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1696483002
Review URL: https://codereview.chromium.org/1696483002
2016-02-12 08:44:39 -08:00
halcanary
6f96cf4bde
Documantation: nanobench
...
DOCS_PREVIEW= https://skia.org/dev/testing/tests?cl=1696723002
https://skia.org/dev/testing/tests?cl=1696723002#bench
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1696723002
NOTRY=true
Review URL: https://codereview.chromium.org/1696723002
2016-02-12 08:08:27 -08:00
brianosman
09bf666233
Remove the 0.5 bias from the ellipse edge function. This makes coverage drop to zero before we get clipped by the rasterizer (i.e. ensures the generated ellipse is inscribed in the geometry).
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683843006
Review URL: https://codereview.chromium.org/1683843006
2016-02-12 07:45:56 -08:00
halcanary
d798feb97e
SkDocument: remove use of SkTArray (part 3/3).
...
TBR=reed
Removal only. Verbal lgtm.
Review URL: https://codereview.chromium.org/1692703003
2016-02-12 07:26:46 -08:00
ethannicholas
891ad66d14
fixed SkDebugCanvas' handling of drawPicture
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1685133008
Review URL: https://codereview.chromium.org/1685133008
2016-02-12 07:15:45 -08:00
benjaminwagner
186e0b9f59
Enable RAW codec for Google3.
...
This CL depends on internal cl/113089689.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1692513003
Review URL: https://codereview.chromium.org/1692513003
2016-02-11 16:00:24 -08:00
msarett
829caa2f6b
Delete SkDecodingImageGenerator
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1692053002
Review URL: https://codereview.chromium.org/1692053002
2016-02-11 14:17:17 -08:00
brianosman
bb2ff94e22
Switch to vertex colors rather than uniforms for color in Ellipse/Circle/RRect/DRRect
...
[Notes:]
- Performance delta on desktop looked like noise. I'm curious what the results will be on low-end mobile GPUs. I'm still trying to figure out how I determine that with perf, etc...
- There appeared to be a single one-pixel image diff while running dm, if I'm understanding the results of skdiff correctly, so that's probably good news?
- Should I include anyone else on the review?
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1675833002
Review URL: https://codereview.chromium.org/1675833002
2016-02-11 14:15:18 -08:00
cdalton
d36f2c4bc0
Add #define directives to GrGLSLShaderBuilder
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1660813002
Review URL: https://codereview.chromium.org/1660813002
2016-02-11 14:10:38 -08:00
msarett
9b9497ef14
Implement onSkipScanlines() for bmp and wbmp
...
TBR=reed@google.com
BUG=skia:4270
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1691083002
Review URL: https://codereview.chromium.org/1691083002
2016-02-11 13:29:36 -08:00
ethannicholas
f8289d9bd1
fixed off-by-one error in skiaserve /cmd
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1692683002
Review URL: https://codereview.chromium.org/1692683002
2016-02-11 13:10:37 -08:00
cdalton
5e58ceea85
Add GrShaderFlags enum
...
Replaces GrGLSLUniformHandler::ShaderVisibility with GrShaderFlags.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684063006
Review URL: https://codereview.chromium.org/1684063006
2016-02-11 12:49:47 -08:00
mtklein
ddb64c81fb
new version of SkHalfToFloat_01
...
This is a little faster than the previous version, and much better explained.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1688233002
Review URL: https://codereview.chromium.org/1688233002
2016-02-11 12:48:23 -08:00
joshualitt
bc81111f24
start to chip away at friending of GrAtlasTextBatch/GrAtlasTextBlob
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684253002
Review URL: https://codereview.chromium.org/1684253002
2016-02-11 12:42:02 -08:00
kjlubick
0eed945294
Revert of Make copySurface work for texture dsts, return a bool, & add unit test. (patchset #6 id:100001 of https://codereview.chromium.org/1684313002/ )
...
Reason for revert:
Copy surface tests are not happy for Windows, Android and probably others:
https://uberchromegw.corp.google.com/i/client.skia.android/builders/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release/builds/4161
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Win8-MSVC-ShuttleA-GPU-GTX960-x86_64-Release/builds/3694
Original issue's description:
> Make copySurface work for texture dsts, return a bool, & add unit test.
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684313002
>
> Committed: https://skia.googlesource.com/skia/+/7ea5e28065e5eb797e95f5d81c1a65cf3209d741
TBR=robertphillips@google.com ,bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1690053002
2016-02-11 12:05:24 -08:00
joshualitt
27004b7e65
Remove GrContext* from GrTextContext
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686143003
Review URL: https://codereview.chromium.org/1686143003
2016-02-11 12:00:33 -08:00