scroggo
58edea8962
Use the correct homophone of 'there'.
...
R=reed@google.com
TBR=reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/319493004
2014-06-05 07:49:04 -07:00
borenet
2e81e51d1e
Fix submit_try
...
BUG=skia:2643
R=epoger@google.com , tfarina@chromium.org
Author: borenet@google.com
Review URL: https://codereview.chromium.org/317823003
2014-06-05 07:32:15 -07:00
robertphillips
c2fce56522
Add bench for rectanizers
...
R=bsalomon@google.com , jvanverth@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/319523003
2014-06-05 07:18:03 -07:00
bsalomon
a5c2824bd3
Change default generators on windows to include msvs-ninja rather than msvs
...
BUG=skia:2439
R=epoger@google.com
TBR=epoger@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/317903002
2014-06-05 07:10:22 -07:00
krajcevski
9a3cdbb3d0
Two new benches for ETC1 bitmaps.
...
First bench: Simply render from a compressed ETC1 bitmap. This is roughly
equal between compressed and uncompressed data.
Second bench: Notify the bitmap that the pixels have changed (that's right,
like a liar) to force a re-upload to the GPU. On this bench, decompressed
textures seem to inexplicably do an order of magnitude better than
compressed textures when it should be the other way around, but that
investigation is reserved for a future CL.
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/317023002
2014-06-05 07:03:39 -07:00
jvanverth
4962140c9e
On Windows, fail if there are missing files specified in the project.
...
BUG=skia:2638
R=robertphillips@google.com , borenet@google.com , rmistry@google.com , epoger@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/319503003
2014-06-04 15:57:57 -07:00
bungeman
df1640d413
Remove SK_IGNORE_DWRITE_BITMAP_FIX.
...
This define has been removed from Blink and is no longer used anywhere.
R=reed@google.com
TBR=reed1
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/319513006
2014-06-04 15:19:47 -07:00
epoger
77f68b623e
Revert "rebaseline_server: download actual-results.json files from GCS instead of SVN"
...
This reverts commit f4666045f3
.
BUG=skia:2641
NOTREECHECKS=True
NOTRY=True
R=jcgregorio@google.com
TBR=jcgregorio
Author: epoger@google.com
Review URL: https://codereview.chromium.org/317783004
2014-06-04 15:09:18 -07:00
bungeman
30bcaa0c57
Update expectations for gyp change.
...
It appears that with the gyp update, floating point operations
on x86_32 are ever so slightly different when drawing some paths.
R=jvanverth@google.com
TBR=jvanverth@google.com
NOTRY=True
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/315043006
2014-06-04 15:04:11 -07:00
robertphillips
1a0a86f072
Remove Android flag for legacy SkCanvas::drawPicture API
...
Android should no longer need this flag
R=scroggo@google.com , djsollen@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/316933005
2014-06-04 11:43:42 -07:00
Hal Canary
479bb60622
Remove SkImageRef and related functionality.
...
From here on out, use SkDecodingImageGenerator+SkDiscardablePixelRef.
R=scroggo@google.com
Review URL: https://codereview.chromium.org/100183002
2014-06-04 14:38:48 -04:00
bungeman
c3f100b0ff
Update gyp for msvs-ninja.
...
BUG=skia:2439
R=borenet@google.com , epoger@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/311213002
2014-06-04 11:35:03 -07:00
egdaniel
ea902d9150
Add utils gypi file
...
BUG=skia:
R=bsalomon@google.com , robertphillips@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/317733003
2014-06-04 10:37:06 -07:00
fmalita
fe68617ec1
Relocate SK_IGNORE_CORRECT_HIGH_QUALITY_IMAGE_SCALE
...
Temporarily move the flag into Chromium's repo, to facilitate
atomic remove-and-suppress-failures changes.
BUG=380686
R=humper@google.com
TBR=humper@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/319533002
2014-06-04 10:27:36 -07:00
epoger
f4666045f3
rebaseline_server: download actual-results.json files from GCS instead of SVN
...
BUG=skia:553
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/310093003
2014-06-04 10:02:58 -07:00
egdaniel
90b8cafb6a
Revert of Move Dashing filterPath to a dashing utils file ( https://codereview.chromium.org/314623004/ )
...
Reason for revert:
Need to create utils.gypi file and update chrome
Original issue's description:
> Move Dashing filterPath to a dashing utils file
>
> From inside GrContext, we have a need to create an SkPath an original path and
> some dashing info. We do not have access to the original path effect so we need
> a way to make the FilterPath function accessible outside of the effect. So I moved
> the core filterPath code (and all need helper functions) out of SkDashPathEffect
> and created a SkDashPath in utils to store these helper functions.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/576dcdc793a762ec63fbecdbfd5768066b548fe5
R=bsalomon@google.com , reed@google.com , rmistry@google.com
TBR=bsalomon@google.com , reed@google.com , rmistry@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/317663003
2014-06-04 09:59:08 -07:00
krajcevski
2dc337c3ae
Add non power of two gm for ETC1 bitmap
...
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/316813005
2014-06-04 09:57:48 -07:00
scroggo
0ba5a4a306
Use tests tag for Skia tools on Android.
...
When generating the makefiles for Skia testing tools on Android,
use the tag 'tests' and do not use the tags 'optional' or 'eng'.
R=djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/315013003
2014-06-04 08:25:50 -07:00
scroggo
ca76c55d60
Use Identity matrix for SkTransparentShader.
...
The SkTransparentShader is just a placeholder that should not
actually be used, so its CTM is not meaningful. However, it needs
to be invertible in order to not assert in SkShader::Context's
constructor. So use SkMatrix::I().
This fixes a CTS test on Android.
R=reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/315743003
2014-06-04 08:21:01 -07:00
mtklein
2583b6257f
Is this SkDebug important? It drives me nuts.
...
BUG=skia:
R=bsalomon@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/310113006
2014-06-04 08:20:41 -07:00
Ravi Mistry
aca1216732
Whitespace change to test bugdroid
...
(SkipBuildbotRuns)
BUG=skia:2139
BUG=chromium:380617
2014-06-04 11:18:54 -04:00
egdaniel
576dcdc793
Move Dashing filterPath to a dashing utils file
...
From inside GrContext, we have a need to create an SkPath an original path and
some dashing info. We do not have access to the original path effect so we need
a way to make the FilterPath function accessible outside of the effect. So I moved
the core filterPath code (and all need helper functions) out of SkDashPathEffect
and created a SkDashPath in utils to store these helper functions.
BUG=skia:
R=bsalomon@google.com , reed@google.com , rmistry@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/314623004
2014-06-04 08:15:53 -07:00
egdaniel
05bb6f136d
Add bench to measure drawing a dashed grid
...
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/310083005
2014-06-04 08:15:31 -07:00
robertphillips
9b14f26d0f
Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer)
...
R=reed@google.com , bsalomon@google.com , mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/313613004
2014-06-04 05:40:44 -07:00
Ravi Mistry
232f7259a9
Whitespace change to test bugdroid
...
(SkipBuildbotRuns)
BUG=skia:2139,chromium:380617
2014-06-04 07:04:29 -04:00
borenet
e2d543a882
Update SKP version to 17
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/312043004
2014-06-03 23:13:08 -07:00
reed
abc0733760
readd SK_SUPPORT_LEGACY_SETCONFIG_INFO -- missed a place in a blink test
...
R=jvanverth@google.com
TBR=jvanverth
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/316753002
2014-06-03 16:51:10 -07:00
mtklein
e696a5962a
Disable PDF in dm for tonight. It's crashy.
...
BUG=skia:2598
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/317533003
2014-06-03 15:59:23 -07:00
kelvinly
06fdc6937d
Added grid data to logging output
...
BUG=skia:
R=bensong@google.com , jcgregorio@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/318433003
2014-06-03 15:43:34 -07:00
reed
9307073a7e
remove unneeded flags SK_SUPPORT_LEGACY_SETCONFIG_INFO and SK_SUPPORT_LEGACY_DEVICE_CONFIG
...
TBR=scroggo
Author: reed@google.com
Review URL: https://codereview.chromium.org/315733002
2014-06-03 15:39:06 -07:00
mtklein
bec3634a4a
Android: remove -lcutils dependency
...
I believe we no longer depend on this after we ported our atomics to __sync.
Tested by running android_ninja.
BUG=skia:
R=scroggo@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/318493002
2014-06-03 15:38:18 -07:00
mtklein
30bf3e2ffc
DM: add pdf
...
BUG=skia:2598
R=halcanary@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/312873002
2014-06-03 13:57:14 -07:00
mtklein
9c4ff80d9b
DM: go back to memcmp for BitmapsEqual
...
Even when autovectorized, using MaxComponentDifference is slower than memcmp.
And debug builds (most runs of DM) will never even be autovectorized.
DM::MaxComponentDifference is the top function on DM profile, and memcmp moves
to ~20th.
BUG=skia:
R=halcanary@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/315743002
2014-06-03 13:56:54 -07:00
Ravi Mistry
182a631e98
Whitespace change to test the new cron.chrome bugdroid.
...
(SkipBuildbotRuns)
BUG=skia:2139
Review URL: https://codereview.chromium.org/309333003
2014-06-03 16:39:21 -04:00
robertphillips
795883e15b
Fix neglected cleanup of SkTileGridPicture.h
...
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/312803003
2014-06-03 13:34:06 -07:00
scroggo
65044bfe02
Return NULL when building empty LayerRasterizer.
...
In SkLayerRasterizer::snapshotRasterizer() and ::detachRasterizer(),
if no layers have been added, do not attempt to create an
SkLayerRasterizer. Instead, return NULL.
This fixes an error when running tests on Android.
Update dox to state that NULL may be returned.
Add tests.
R=reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/313653006
2014-06-03 13:12:51 -07:00
krajcevski
99ffe24200
Initial KTX file decoder
...
R=bsalomon@google.com , robertphillips@google.com , halcanary@google.com , reed@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/302333002
2014-06-03 13:04:35 -07:00
robertphillips
8a35140f3f
Add LICENSE & README.google files to third_party/etc1
...
R=djsollen@google.com , krajcevski@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/309343004
2014-06-03 12:31:09 -07:00
mtklein
3a2682a77f
SK_CPU_ARM --> SK_CPU_ARM32
...
That's what it means. It keeps confusing us as named today.
BUG=skia:
R=djsollen@google.com , mtklein@google.com , reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/314643004
2014-06-03 12:07:31 -07:00
jvanverth
1800b1f51e
manual bench rebase after 55ada06
...
R=robertphillips@google.com
TBR=robertphillips@google.com
Bypassing trybots:
NOTRY=true
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/315683004
2014-06-03 11:46:30 -07:00
reed
868074b50b
remove SkBounder -- unused and unloved
...
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/312553006
2014-06-03 10:54:00 -07:00
epoger
55ada0630e
download_actuals.py: download JSON files from Google Storage instead of skia-autogen
...
uses google-api-python-client instead of gsutil binary to interact with Google Storage
BUG=skia:553
R=rmistry@google.com , bensong@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/309653005
2014-06-03 10:35:28 -07:00
humper
2db11d18af
a few rebaseline stragglers from image scaling change
...
BUG=skia:
NOTRY=True
NOTREECHECKS=True
TBR=jvanverth
Author: humper@google.com
Review URL: https://codereview.chromium.org/311853004
2014-06-03 10:20:49 -07:00
kevin.petit
866b95d65d
ARM Skia NEON patches - 38 - arm64 8888 blitters
...
Enable NEON on arm64 for most 8888 blitters
This patch enables NEON optimisation for the Color32, S32_Blend,
S32A_Opaque blitters on arm64.
Here are the perf improvements vs the existing code:
Color32:
========
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -2.39% | 23.78% |
+-------+------------+------------+
| 2 | -5.46% | 8.88% |
+-------+------------+------------+
| 4 | -4.74% | 4.89% |
+-------+------------+------------+
| 8 | 67.74% | 107.12% |
+-------+------------+------------+
| 16 | 40.03% | 101.20% |
+-------+------------+------------+
| 64 | 11.09% | 98.40% |
+-------+------------+------------+
| 256 | -2.20% | 74.81% |
+-------+------------+------------+
| 1024 | -4.28% | 78.90% |
+-------+------------+------------+
S32_Blend:
==========
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | 7.84% | -6.75% |
+-------+------------+------------+
| 2 | 28.95% | 39.77% |
+-------+------------+------------+
| 4 | 5.80% | 8.26% |
+-------+------------+------------+
| 8 | 1.35% | 33.80% |
+-------+------------+------------+
| 16 | -2.13% | 41.13% |
+-------+------------+------------+
| 64 | -4.91% | 42.84% |
+-------+------------+------------+
| 256 | -6.53% | 48.72% |
+-------+------------+------------+
| 1024 | -6.65% | 46.66% |
+-------+------------+------------+
S32A_Opaque:
============
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -7.51% | -19.06% |
+-------+------------+------------+
| 2 | -5.02% | -27.70% |
+-------+------------+------------+
| 4 | 15.38% | -21.66% |
+-------+------------+------------+
| 8 | -0.98% | 1.05% |
+-------+------------+------------+
| 16 | -7.35% | 3.34% |
+-------+------------+------------+
| 64 | 50.53% | 94.63% |
+-------+------------+------------+
| 256 | 71.17% | 164.10% |
+-------+------------+------------+
| 1024 | 79.58% | 197.60% |
+-------+------------+------------+
Signed-off-by: Kevin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com , mtklein@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/302283003
2014-06-03 10:08:07 -07:00
robertphillips
dcf9ab14a1
Remove legacy picture recording
...
This is unblocked now that Android no longer uses the old interface.
This is just the first step in cleaning this up. Future CLs will constify SkPicture access in SkCanvas and split up the SkPicture/SkPicturePlayback/SkPictureRecord trio.
R=bsalomon@google.com , reed@google.com , mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/313613002
2014-06-03 10:04:47 -07:00
borenet
66aa609a49
Update SKP version to 16
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/313593002
2014-06-03 09:38:11 -07:00
jcgregorio
92bfb09ac8
Fix etc1 support for SkFiddle.
...
Also update design doc to fix MySQL notation for auto incrementing columns.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/315643002
2014-06-03 09:04:44 -07:00
mtklein
04cd368cb4
Fix memory leak in etc1bitmap GM.
...
We never drop our first ref on fileData. (All our ref counts start at one).
SkAutoTUnref<T> is almost always the right thing to use for refcounted types.
BUG=skia:2635
R=krajcevski@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/310793003
2014-06-03 09:04:34 -07:00
scroggo
14052a0b5a
Allow chrome to use old version of installPixels.
...
R=jvanverth@google.com , reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/312703003
2014-06-03 07:57:51 -07:00
jcgregorio
d0f18b1f2b
Update link to Doxygen.
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/302543007
2014-06-03 07:38:35 -07:00