halcanary
6950de6c41
Comments Style: s/skbug.com/bug.skia.org/
...
DOCS_PREVIEW= https://skia.org/?cl=1432503003
Review URL: https://codereview.chromium.org/1432503003
2015-11-07 05:29:00 -08:00
scroggo
860e8a6719
Renable image benchmarking
...
- Remove --images '' to renable image benchmarking
- Add a flag to disable testing JPEG's buildTileIndex, since it also leaks memory
- Do not run images on GPU
- Do not run large interlaced images on 32 bit bots
- When buildTileIndex is not being used in the subset benches, do not use it for BRD
BUG=skia:3418
BUG=skia:4469
BUG=skia:4471
BUG=skia:4360
Review URL: https://codereview.chromium.org/1396113002
2015-10-15 07:51:28 -07:00
scroggo
0a3cac8a90
Reland of Pass --images '' to nanobench to disable image benchmarking. (patchset #1 id:1 of https://codereview.chromium.org/1400633002/ )
...
Reason for revert:
Still breaking. e.g.
http://build.chromium.org/p/client.skia/builders/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug/builds/1466/steps/nanobench/logs/stdio
http://build.chromium.org/p/client.skia.android/builders/Perf-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release/builds/2280/steps/nanobench/logs/stdio
Original issue's description:
> Revert of Pass --images '' to nanobench to disable image benchmarking. (patchset #1 id:1 of https://codereview.chromium.org/1381703003/ )
>
> Reason for revert:
> I have attempted to fix the problems that caused running nanobench with images to fail, so testing to see if they are in fact fixed.
>
> Original issue's description:
> > Pass --images '' to nanobench to disable image benchmarking.
> >
> > Enabling image benchmarking has caused most nanobench runs to fail,
> > both Debug and Release.
> >
> > BUG=skia:3418
> > NOTREECHECKS=true
> > TBR=scroggo@google.com
> >
> > Committed: https://skia.googlesource.com/skia/+/1f7039c6c5f0f118b629994b0bac255345e5abd6
>
> BUG=skia:3418
>
> Committed: https://skia.googlesource.com/skia/+/c2e59caa0a466040f4b4f08cb5604c86b2615efa
TBR=mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3418
Review URL: https://codereview.chromium.org/1396843003
2015-10-08 14:44:51 -07:00
scroggo
c2e59caa0a
Revert of Pass --images '' to nanobench to disable image benchmarking. (patchset #1 id:1 of https://codereview.chromium.org/1381703003/ )
...
Reason for revert:
I have attempted to fix the problems that caused running nanobench with images to fail, so testing to see if they are in fact fixed.
Original issue's description:
> Pass --images '' to nanobench to disable image benchmarking.
>
> Enabling image benchmarking has caused most nanobench runs to fail,
> both Debug and Release.
>
> BUG=skia:3418
> NOTREECHECKS=true
> TBR=scroggo@google.com
>
> Committed: https://skia.googlesource.com/skia/+/1f7039c6c5f0f118b629994b0bac255345e5abd6
BUG=skia:3418
Review URL: https://codereview.chromium.org/1400633002
2015-10-08 14:09:41 -07:00
mtklein
1f7039c6c5
Pass --images '' to nanobench to disable image benchmarking.
...
Enabling image benchmarking has caused most nanobench runs to fail,
both Debug and Release.
BUG=skia:3418
NOTREECHECKS=true
TBR=scroggo@google.com
Review URL: https://codereview.chromium.org/1381703003
2015-10-05 10:24:59 -07:00
joshualitt
399dd05962
Revert of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 (patchset #1 id:1 of https://codereview.chromium.org/1375733003/ )
...
Reason for revert:
Reverting, optimistically fixed
Original issue's description:
> Reland of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 (patchset #1 id:1 of https://codereview.chromium.org/1382933002/ )
>
> Reason for revert:
> Not fixed. :-(
>
> Original issue's description:
> > Revert of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 (patchset #1 id:1 of https://codereview.chromium.org/1365683003/ )
> >
> > Reason for revert:
> > should hopefully be fixed, please reland if not.
> >
> > Original issue's description:
> > > Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373
> > >
> > > BUG=skia:4373
> > >
> > > Committed: https://skia.googlesource.com/skia/+/3420d2796bad5ce553efb9909790ea72e578dc47
> >
> > TBR=borenet@google.com ,benjaminwagner@google.com
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:4373
> >
> > Committed: https://skia.googlesource.com/skia/+/52f8deba607fd67558b57551cd43406c8b743072
>
> TBR=borenet@google.com ,joshualitt@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:4373
>
> Committed: https://skia.googlesource.com/skia/+/9442ab8a40dd0effde253e3b2d166bcf47222e92
TBR=borenet@google.com ,benjaminwagner@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4373
Review URL: https://codereview.chromium.org/1385633002
2015-10-02 06:56:25 -07:00
benjaminwagner
9442ab8a40
Reland of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 (patchset #1 id:1 of https://codereview.chromium.org/1382933002/ )
...
Reason for revert:
Not fixed. :-(
Original issue's description:
> Revert of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 (patchset #1 id:1 of https://codereview.chromium.org/1365683003/ )
>
> Reason for revert:
> should hopefully be fixed, please reland if not.
>
> Original issue's description:
> > Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373
> >
> > BUG=skia:4373
> >
> > Committed: https://skia.googlesource.com/skia/+/3420d2796bad5ce553efb9909790ea72e578dc47
>
> TBR=borenet@google.com ,benjaminwagner@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:4373
>
> Committed: https://skia.googlesource.com/skia/+/52f8deba607fd67558b57551cd43406c8b743072
TBR=borenet@google.com ,joshualitt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4373
Review URL: https://codereview.chromium.org/1375733003
2015-10-01 16:25:51 -07:00
joshualitt
52f8deba60
Revert of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 (patchset #1 id:1 of https://codereview.chromium.org/1365683003/ )
...
Reason for revert:
should hopefully be fixed, please reland if not.
Original issue's description:
> Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373
>
> BUG=skia:4373
>
> Committed: https://skia.googlesource.com/skia/+/3420d2796bad5ce553efb9909790ea72e578dc47
TBR=borenet@google.com ,benjaminwagner@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4373
Review URL: https://codereview.chromium.org/1382933002
2015-10-01 12:09:17 -07:00
benjaminwagner
3420d2796b
Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373
...
BUG=skia:4373
Review URL: https://codereview.chromium.org/1365683003
2015-09-23 12:20:47 -07:00
benjaminwagner
a1a8a601ae
Blacklist GLInstancedArraysBench for GalaxyS4 due to skia:4371
...
BUG=skia:4371
Review URL: https://codereview.chromium.org/1363963002
2015-09-23 11:41:04 -07:00
borenet
d34d94766d
Appurify bot: don't use flags that visualbench doesn't support
...
Depends on https://codereview.chromium.org/1320423005/
BUG=skia:4277
Review URL: https://codereview.chromium.org/1310903006
2015-09-03 12:31:26 -07:00
egdaniel
73caadf277
Try enabling all nanobenches on Nexus7
...
BUG=skia:2774
Review URL: https://codereview.chromium.org/1290223005
2015-08-18 13:08:36 -07:00
mtklein
bf9e600069
nanobench: split CPU and GPU .SKP tile sizes.
...
Let's make CPU-bound .SKP benching mimic Chrome's tiles.
Unfortunately, the CPU code also performs a lot better with those big wide tiles...
BUG=skia:
Review URL: https://codereview.chromium.org/1189863002
2015-06-16 10:41:27 -07:00
stephana
340cd84c9c
Disabling ~path_hairline in iOS nanobench
...
Temporary measure to make nanobench succeed.
TBR=borenet
BUG=skia:
Review URL: https://codereview.chromium.org/1144173004
2015-05-26 06:19:11 -07:00
stephana
18b72db6aa
Temporarily disable nanobench to see what else is in the way of the bots going green.
...
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1147333002
2015-05-21 13:59:36 -07:00
borenet
e1d7e0f0a5
Blacklist desk_unicodetable SKP on Nexus Player
...
It's getting us killed for OOM.
BUG=skia:3240
Review URL: https://codereview.chromium.org/1104693002
2015-04-23 12:44:31 -07:00
borenet
1e37d1762c
Update [dm|nanobench]_flags for CPU/GPU split
...
TBR=mtklein
NOTREECHECKS=true
BUG=skia:2073
Review URL: https://codereview.chromium.org/1036223002
2015-03-27 05:42:18 -07:00
egdaniel
9a0f629973
Only use 256x256 tiles on hd2000 nanobench bots
...
Initial experiments did show that the 256 tile size fixed the hd2000 win7
nanobot failures. However it did not have any effect on other bots, so this
change is to move back to the larger tile size on all bots expect for the
hd2000.
BUG=skia:
Review URL: https://codereview.chromium.org/1022083002
2015-03-20 07:03:52 -07:00
mtklein
7e78f3d0e7
Fix bug in Valgrind flags config.
...
'GPU' is in 'Test-Ubuntu14-GCE-NoGPU-x86_64-Release-Valgrind_CPU' too.
This means we're building it in no-GPU mode, and running it in no-CPU mode.
At least it finishes quite quickly this way (~10 seconds).
BUG=skia:
Review URL: https://codereview.chromium.org/992203004
2015-03-10 08:03:26 -07:00
borenet
13e51f91ef
Run Valgrind bots with --nogpu and --nocpu as appropriate
...
BUG=skia:3506
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/986583004
2015-03-09 06:59:16 -07:00
bsalomon
bdff1fc494
Add msaa runs to nanobench
...
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/964053002
2015-02-28 16:56:31 -08:00
mtklein
f73e589c0d
Add tools/nanobench_flags.py.
...
This should look suspiciously similar to tools/dm_flags.py. In fact, I
tweaked tools/dm_flags.py a bit to make it even more suspiciously similar.
I'll leave actually deduping this to future me.
I noticed we have an opportunity to make our Valgrind run of nanobench faster,
by not only making it not auto-calibrate (--loops 1) but also take only one
measurement (--samples 1). Should be 5-10x faster than the default.
BUG=skia:
Review URL: https://codereview.chromium.org/957503002
2015-02-24 11:45:11 -08:00