scroggo
c7bfd5b441
Stop building gm in Android framework build.
...
Allows us to delete gm.
Review URL: https://codereview.chromium.org/860803004
2015-01-20 08:25:36 -08:00
reed
83c8dec46a
remove legacy flags for old image filtering
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/857193003
2015-01-20 07:41:24 -08:00
Mike Klein
2babfd96ae
force a build with new --config flags
...
BUG=skia:
Review URL: https://codereview.chromium.org/798463005
2015-01-20 10:24:19 -05:00
egdaniel
71e236c03e
Remove willReadDst from GrFragmentProcessor.
...
Since only XP's can read dst now, there is no reason to have this query on GrFP.
This also triggered a chain reaction of cleaning up/removing unnecessary code
elsewhere.
BUG=skia:
Review URL: https://codereview.chromium.org/851143003
2015-01-20 06:34:51 -08:00
scroggo
b2b416d384
Revert of remove unused SkAvoidXfermode (patchset #2 id:20001 of https://codereview.chromium.org/860583002/ )
...
Reason for revert:
Breaking Android framework build, which still uses AvoidXfermode. (failure shown here: 565b76b4bd/logs/build_error.log
)
Here is the Java class that uses it: https://cs.corp.google.com/#android/frameworks/base/graphics/java/android/graphics/AvoidXfermode.java&sq=package:android
It has been deprecated. The glue code (which actually references the Skia file) is here: https://cs.corp.google.com/#android/frameworks/base/core/jni/android/graphics/Xfermode.cpp&q=Xfermode.cpp&sq=package:android
Mike suggested we move the implementation into Android, which is fine with me.
Original issue's description:
> remove unused SkAvoidXfermode
>
> BUG=skia:
> TBR=
> NOTRY=True
>
> Committed: https://skia.googlesource.com/skia/+/2d02df7a9a50217dac8c1d11681832a927ed79ce
TBR=bsalomon@google.com ,reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/822953003
2015-01-20 06:33:14 -08:00
weiliangc
07f26976f7
Remove unused TileGridInfo
...
Chromium no longer uses TileGridInfo as of CL 856853003 and remove this
from skia.
BUG=chromium:447662
Review URL: https://codereview.chromium.org/828503004
2015-01-20 05:57:06 -08:00
rmistry
6a93900f06
Remove roll_deps and trybots_to_run.
...
BUG=skia:
Review URL: https://codereview.chromium.org/859963003
2015-01-20 05:44:46 -08:00
skia.buildbots
58b27523ce
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/786403004
2015-01-19 23:14:06 -08:00
cwallez
2467d71346
Remove a few unused statements.
...
BUG=
Review URL: https://codereview.chromium.org/837643003
2015-01-19 13:57:17 -08:00
sugoi
4043d17c63
Broken dm fix
...
BUG=skia:
Review URL: https://codereview.chromium.org/855953005
2015-01-19 10:31:35 -08:00
sugoi
692135f968
YUV planes cache
...
- Added new classes to contain YUV planes of memory, along with the associated data.
- Used these classes in load_yuv_texture() to enable YUV planes caching
- Added a unit test for the new cache
BUG=450021
Review URL: https://codereview.chromium.org/851273003
2015-01-19 10:10:27 -08:00
skia.buildbots
89499d76b9
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/860613003
2015-01-18 22:42:54 -08:00
reed
e76de5ac15
remove dead header
...
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/858813002
2015-01-18 20:12:26 -08:00
reed
2d02df7a9a
remove unused SkAvoidXfermode
...
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/860583002
2015-01-18 20:01:30 -08:00
reed
bc4f6adeba
remove dead code for scalar type
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/855273003
2015-01-18 11:19:33 -08:00
halcanary
03758b8c4a
tool --help alphabetizes command line flags
...
Review URL: https://codereview.chromium.org/854193003
2015-01-18 10:39:25 -08:00
robertphillips
46d36f0e7b
Refactor position computation to enable device space "nudge"
...
To match raster's handling of BW geometry we want to be able to perform a device space "nudge" on all geometry. This CL sets us up to be able to do that in GrGLVertexBuilder::transformToNormalizedDeviceSpace.
BUG=423834
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/854013002
2015-01-18 08:14:14 -08:00
mtklein
75d98fd6f2
DM: Don't hold onto data longer than needed.
...
On my laptop, this cuts peak memory usage by more than half.
BUG=skia:3255
Review URL: https://codereview.chromium.org/859623002
2015-01-18 07:05:01 -08:00
skia.buildbots
c9b62ad60c
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/836123008
2015-01-17 22:46:36 -08:00
reed
09519db20c
fatbits for all 4 views
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/829043005
2015-01-17 19:36:08 -08:00
skia.buildbots
95d755dbf9
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/839673006
2015-01-16 23:04:02 -08:00
reed
a9cb871de8
fix labels on image-surface gm
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/834903003
2015-01-16 14:21:40 -08:00
fmalita
a709d24226
Rebaseline pictureshader GM after http://crrev.com/852213002
...
BUG=chromium:447707
TBR=egdaniel@google.com
Review URL: https://codereview.chromium.org/853243002
2015-01-16 14:15:28 -08:00
Brian Salomon
8b4489b6e6
Revert "delete old things!"
...
This reverts commit 15b125d401
.
NOTREECHECKS=true
original change breaks android tree
BUG=skia:
Review URL: https://codereview.chromium.org/848073005
2015-01-16 16:26:32 -05:00
bsalomon
15b125d401
delete old things!
...
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/855003006
2015-01-16 12:08:54 -08:00
reed
f7094c4ed0
reorg filter quality cascade
...
BUG=skia:
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/844913004
2015-01-16 12:05:19 -08:00
rmistry
e1f630dc8b
* Add nytimes_desktop pageset.
...
* Delete cuteoverload, frantzen, transformice and nytimes_tabl.
* Increase wait time for forecastio.
BUG=skia:3320
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/808843004
2015-01-16 11:41:26 -08:00
jcgregorio
d4646f29c1
Add robots.txt
...
BUG=skia:
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/851793004
2015-01-16 11:13:53 -08:00
Brian Salomon
a2d9478e92
Fix debugger wrt to new SkGpuDevice factory signature'
...
Review URL: https://codereview.chromium.org/855083003
2015-01-16 14:01:44 -05:00
reed
753c2af6bc
add more suppressions for mipmap fix
...
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/828633003
2015-01-16 09:31:13 -08:00
reed
7729e56a29
use log2(scale) to compute mip level
...
now w/ expanded suppressions
This reverts commit b50ced7030
.
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/856723003
2015-01-16 08:35:09 -08:00
bsalomon
afe3005be3
Require budget decision when creating a RenderTarget SkSurface.
...
Restructure SkGpuDevice creation:
*SkSurfaceProps are optional.
*Use SkSurfaceProps to communicate DF text rather than a flag.
*Tell SkGpuDevice::Create whether RT comes from cache or not.
Review URL: https://codereview.chromium.org/848903004
2015-01-16 07:32:33 -08:00
reed
b50ced7030
Revert of use log2(scale) to compute mip level (patchset #7 id:120001 of https://codereview.chromium.org/849333002/ )
...
Reason for revert:
need more suppressions
Original issue's description:
> use log2(scale) to compute mip level
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/15fd47f8a07615a7f5d78581aee4c80ff9f17fd9
TBR=robertphillips@google.com ,jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/856783004
2015-01-16 07:27:46 -08:00
reed
15fd47f8a0
use log2(scale) to compute mip level
...
BUG=skia:
Review URL: https://codereview.chromium.org/849333002
2015-01-16 07:18:10 -08:00
caryclark
45fa447460
new files for pathops geometric intersection
...
There's no gyp references to these new files,
so this should only have the effect of reducing
the size of the commit that turns this code on.
TBR=
Review URL: https://codereview.chromium.org/853223002
2015-01-16 07:04:10 -08:00
egdaniel
40248f365b
Update ignore file
...
NOTRY=True
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/844813004
2015-01-16 06:44:18 -08:00
egdaniel
54f0e9d784
Add Xfer Processor for GrCustomXfermodes
...
BUG=skia:
Review URL: https://codereview.chromium.org/852203003
2015-01-16 06:29:47 -08:00
kkinnunen
678c1b019a
Fold alpha to the draw in savelayer-draw-restore patterns with non-opaque draw
...
Fold alpha of a save layer call to the subsequent draw call paint, even when
the draw call paint color is already non-opaque.
Comparing the difference of the unoptimized and the optimized call pattern
with all (layer alpha, draw alpha) combinations, this produces
off-by-one pixels ~50% of the time.
Reduces layers of current desk_carsvg.skp (recorded with cross-process
picture image filters allowed) from 122 to 115.
BUG=skia:3119
Review URL: https://codereview.chromium.org/840483005
2015-01-16 05:04:36 -08:00
reed
c695e95417
add gm to show miplevels (patchset #2 id:20001 of https://codereview.chromium.org/849173004/ )"
...
fixed memory leak
This reverts commit 04f07fcbfd
.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/854163002
2015-01-16 05:01:16 -08:00
skia.buildbots
0582f5a8f1
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/855003003
2015-01-16 04:44:24 -08:00
mtklein
05982367f5
Revert of Add temporary blacklist debugging. (patchset #1 id:1 of https://codereview.chromium.org/805643004/ )
...
Reason for revert:
fixed!
Original issue's description:
> Add temporary blacklist debugging.
>
> Not sure why blacklists don't seem to work on bots. They look right.
>
> NOTREECHECKS=true
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/f77156e1925cd5d5504070fe5533a4c456732c1b
TBR=mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/851903003
2015-01-15 19:11:55 -08:00
mtklein
04f07fcbfd
Revert of add gm to show miplevels (patchset #2 id:20001 of https://codereview.chromium.org/849173004/ )
...
Reason for revert:
==31530==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 224 byte(s) in 2 object(s) allocated from:
#0 0x7febb223f65b in operator new(unsigned long) (/home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/dm+0x35865b)
#1 0x7febb3483c56 in SkMipMap::Build(SkBitmap const&, SkDiscardableMemory* (*)(unsigned long)) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/core/SkMipMap.cpp:181:9
#2 0x7febb2c37914 in ShowMipLevels::onDraw(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/downsamplebitmap.cpp:228:24
#3 0x7febb2295736 in skiagm::GM::drawContent(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/gm.cpp:32:5
#4 0x7febb2295019 in skiagm::GM::draw(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/gm.cpp:24:5
#5 0x7febb226722f in DM::GMSrc::draw(SkCanvas*) const /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DMSrcSink.cpp:22:5
#6 0x7febb226d929 in DM::RasterSink::draw(DM::Src const&, SkBitmap*, SkWStream*) const /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DMSrcSink.cpp:230:12
#7 0x7febb224e004 in Task::Run(Task*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DM.cpp:254:25
#8 0x7febb3805e4c in (anonymous namespace)::ThreadPool::Loop(void*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/core/SkTaskGroup.cpp:149:13
#9 0x7febb460dc7c in thread_start(void*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/utils/SkThreadUtils_pthread.cpp:66:9
#10 0x7febb1251f6d in start_thread /build/buildd/eglibc-2.17/nptl/pthread_create.c:311
Indirect leak of 699528 byte(s) in 2 object(s) allocated from:
#0 0x7febb22214ab in __interceptor_malloc (/home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/dm+0x33a4ab)
#1 0x7febb473e3c6 in sk_malloc_flags(unsigned long, unsigned int) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/ports/SkMemory_malloc.cpp:54:15
#2 0x7febb473e19a in sk_malloc_throw(unsigned long) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/ports/SkMemory_malloc.cpp:40:12
#3 0x7febb3483c94 in SkMipMap::Build(SkBitmap const&, SkDiscardableMemory* (*)(unsigned long)) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/core/SkMipMap.cpp:181:18
#4 0x7febb2c37914 in ShowMipLevels::onDraw(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/downsamplebitmap.cpp:228:24
#5 0x7febb2295736 in skiagm::GM::drawContent(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/gm.cpp:32:5
#6 0x7febb2295019 in skiagm::GM::draw(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/gm.cpp:24:5
#7 0x7febb226722f in DM::GMSrc::draw(SkCanvas*) const /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DMSrcSink.cpp:22:5
#8 0x7febb226d929 in DM::RasterSink::draw(DM::Src const&, SkBitmap*, SkWStream*) const /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DMSrcSink.cpp:230:12
#9 0x7febb224e004 in Task::Run(Task*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DM.cpp:254:25
#10 0x7febb3805e4c in (anonymous namespace)::ThreadPool::Loop(void*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/core/SkTaskGroup.cpp:149:13
#11 0x7febb460dc7c in thread_start(void*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/utils/SkThreadUtils_pthread.cpp:66:9
#12 0x7febb1251f6d in start_thread /build/buildd/eglibc-2.17/nptl/pthread_create.c:311
Original issue's description:
> add gm to show miplevels
>
> BUG=skia:
> TBR=
>
> NOTREECHECKS=true
>
> Committed: https://skia.googlesource.com/skia/+/a598f4b773f066a939e0216a116c179b90550727
TBR=reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/854103004
2015-01-15 18:36:07 -08:00
mtklein
51fc019f21
force a build with fixed --blacklist
...
NOTREECHECKS=true
BUG=skia:
Review URL: https://codereview.chromium.org/850413003
2015-01-15 18:28:53 -08:00
reed
a598f4b773
add gm to show miplevels
...
BUG=skia:
TBR=
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/849173004
2015-01-15 18:09:15 -08:00
mtklein
f77156e192
Add temporary blacklist debugging.
...
Not sure why blacklists don't seem to work on bots. They look right.
NOTREECHECKS=true
BUG=skia:
Review URL: https://codereview.chromium.org/805643004
2015-01-15 16:21:24 -08:00
mtklein
9dc0910c2c
newlines after failures
...
NOTREECHECKS=true
BUG=skia:3255
Review URL: https://codereview.chromium.org/853123003
2015-01-15 15:47:33 -08:00
mtklein
2f64eec5df
Totally serialize gpu tests on Windows.
...
NOTREECHECKS=true
BUG=skia:3255
Review URL: https://codereview.chromium.org/845193006
2015-01-15 14:20:42 -08:00
mtklein
e1315526cd
Turn back on image and subset sources now that they're blacklisted on Android.
...
To land after https://codereview.chromium.org/850403002/
NOTREECHECKS=true
BUG=skia:3255
Review URL: https://codereview.chromium.org/857483003
2015-01-15 13:58:56 -08:00
mtklein
a2ef642b00
DM: add basic --blacklist <config> <srcType> <name> functionality.
...
NOTREECHECKS=true
BUG=skia:3255
Review URL: https://codereview.chromium.org/817573005
2015-01-15 13:44:22 -08:00
reed
319a9c25b2
remove suppressions (CL was reverted)
...
BUG=skia:
TBR=
NOTREECHECKS=True
NOTRY=True
Review URL: https://codereview.chromium.org/837633007
2015-01-15 13:02:03 -08:00