Commit Graph

33692 Commits

Author SHA1 Message Date
Ben Wagner
5ddb308625 Distinguish between glyphs with empty path and no path.
BUG=skia:4904

Change-Id: I065e3b4d8596b415ddaf094d7f9a4b65da64d4d4
Reviewed-on: https://skia-review.googlesource.com/117280
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2018-04-05 22:37:33 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
b45aac961d Roll third_party/externals/skcms/ 6959d4597..24c91d143 (1 commit)
https://skia.googlesource.com/skcms/+log/6959d45972e2..24c91d143c4a

$ git log 6959d4597..24c91d143 --date=short --no-merges --format='%ad %ae %s'
2018-04-05 mtklein clean up some tests.c TODOs

Created with:
  roll-dep third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=herb@google.com

Change-Id: I7def32c8ee48b2eceb374c733e62d1453d215dd8
Reviewed-on: https://skia-review.googlesource.com/118959
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-05 21:13:56 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
01d8b74927 Roll third_party/externals/skcms/ d75edb2e3..6959d4597 (1 commit)
https://skia.googlesource.com/skcms/+log/d75edb2e3bfe..6959d45972e2

$ git log d75edb2e3..6959d4597 --date=short --no-merges --format='%ad %ae %s'
2018-04-05 mtklein better matrix 3x3 invert

Created with:
  roll-dep third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=herb@google.com

Change-Id: I4823928f37905be9a9217c084bef3d0238969caf
Reviewed-on: https://skia-review.googlesource.com/118952
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-05 20:35:29 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
d9b25482ea Roll third_party/externals/skcms/ a7974d9f6..d75edb2e3 (1 commit)
https://skia.googlesource.com/skcms/+log/a7974d9f65a5..d75edb2e3bfe

$ git log a7974d9f6..d75edb2e3 --date=short --no-merges --format='%ad %ae %s'
2018-04-05 brianosman Revert "flop back to powf() for TF invert"

Created with:
  roll-dep third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=herb@google.com

Change-Id: I4f4639fe6b140e1b6ee6e5f2c0a307b72f736522
Reviewed-on: https://skia-review.googlesource.com/118951
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-05 20:01:48 +00:00
Florin Malita
6127c4c660 Clip SlideDir slides to their declared dimensions
(to avoid spilling cell content)

TBR=
Change-Id: I7bbbbf004d35faab5f264d9914bcd24d2bb8eaeb
Reviewed-on: https://skia-review.googlesource.com/118984
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-04-05 19:47:48 +00:00
Ben Wagner
93e4ea52f6 Mac to better serialize OTTO fonts.
Sometimes CoreText just gives up on filling out kCTFontFormatAttribute
properly, in which case we need a simple fallback for format detection
which isn't so reluctant to determine the type. The strategy prior to this
change is to use the most common type (WindowsTrueType), but apparently
if a font is actually an OpenType CFF font but has a WindowsTrueType tag
as the first few bytes, CoreGraphics gives up and won't load the font. So
check if there are any CFF tables and, if so, mark the font as
OpenTypeCFF.

BUG=skia:7630

Change-Id: Ie974e6db031db13628d5a19962e23ce2bf127367
Reviewed-on: https://skia-review.googlesource.com/118887
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-04-05 19:38:48 +00:00
Robert Phillips
87f852d1a3 Revert "Remove deprectated GrContext::MakeGL overloads that take raw ptr"
This reverts commit efa60a1d13.

Reason for revert: Surprise! Google3 still uses these.

Original change's description:
> Remove deprectated GrContext::MakeGL overloads that take raw ptr
> 
> Change-Id: Iae12bf61fa1e2f5d4b13b98198cddb7482656fdf
> Reviewed-on: https://skia-review.googlesource.com/118660
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>

TBR=egdaniel@google.com,bsalomon@google.com

Change-Id: Ica09d80e1563924a286a4a6aa8a1f93cb5ca9c5d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/119001
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-04-05 19:37:49 +00:00
Brian Salomon
65daa2071b Remove SK_DISABLE_TEXTURE_OP_AA
The corresponding Chrome bugs have been fixed and this macro has not been defined in Chrome for some time.

Change-Id: I618283e7e6c409d96550fc5b1026c1618280246c
Reviewed-on: https://skia-review.googlesource.com/118888
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-04-05 19:21:40 +00:00
Florin Malita
0ffa322ecd [viewer] Consolidate external slide loading
Handle all external slides (.skp, .jpg, .json, .svg) consistently:

  * support both single-file/directory flags
  * add "directory" slides for all types

Change-Id: I4881c51f597ed4cb2a5b4c61706a168c754a5a8f
Reviewed-on: https://skia-review.googlesource.com/119020
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-04-05 19:05:28 +00:00
Yuqian Li
03d4f19558 Flush before snap SkThreadedBMPDevice
Bug: skia:
Change-Id: I3551634cc3d066777b160adafa861f5c8f57d4e8
Reviewed-on: https://skia-review.googlesource.com/118961
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2018-04-05 18:39:28 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
cb7799477d Roll third_party/externals/skcms/ 3cb9ba6ae..a7974d9f6 (3 commits)
https://skia.googlesource.com/skcms/+log/3cb9ba6ae2d6..a7974d9f65a5

$ git log 3cb9ba6ae..a7974d9f6 --date=short --no-merges --format='%ad %ae %s'
2018-04-05 mtklein flop back to powf() for TF invert
2018-04-05 brianosman Run regression with two linear tolerances
2018-04-05 mtklein push profiles as part of android build

Created with:
  roll-dep third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=herb@google.com

Change-Id: Ibc898084cec9b02b4fd91ed268af404a7097c60f
Reviewed-on: https://skia-review.googlesource.com/118947
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-05 18:33:52 +00:00
Bryce Thomas
0aa81241e3 Update 'Working in a Chromium repo' documentation.
No-Try: true
Docs-Preview: https://skia.org/?cl=118521
Change-Id: Ibc639d10440ad449c875fe897af4f941fe4d4397
Reviewed-on: https://skia-review.googlesource.com/118521
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-04-05 17:52:42 +00:00
Kevin Lubick
c5f0427f14 Avoid nonsortable rects in drawRect/drawOval
Bug: skia:
Change-Id: Ia369a8f562c33e43248460076e8b6464add849a5
Reviewed-on: https://skia-review.googlesource.com/118980
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-04-05 17:32:02 +00:00
Brian Salomon
efa60a1d13 Remove deprectated GrContext::MakeGL overloads that take raw ptr
Change-Id: Iae12bf61fa1e2f5d4b13b98198cddb7482656fdf
Reviewed-on: https://skia-review.googlesource.com/118660
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-04-05 17:23:22 +00:00
Brian Salomon
f932a6328a Add maxTextureSize()/maxRenderTargetSize() to GrContext
This provides an alternative way to access these values which will allow removal GrContext::caps() from public API

Change-Id: I53d3c00563da8847e1fc14aea9750dc9fd90d1e5
Reviewed-on: https://skia-review.googlesource.com/118962
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-04-05 17:21:32 +00:00
Florin Malita
c659c2c30d Viewer SVG support
Change-Id: I93ee61271ebe960063bec16ba472b3fd243ee149
Reviewed-on: https://skia-review.googlesource.com/118885
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-04-05 16:34:22 +00:00
Ben Wagner
1861e88cad Via*::draw to finish before checking.
Currently Via*::draw checks against the reference
immediately, before the sink is completely finished. This causes
via-gl to fail, since GPUSink::onDraw does not even create the
target pixmap until after drawing the Src into the canvas. This puts off
the actual check against the reference until after the sink is finished,
allowing via-gl to work as expected.

Change-Id: If1a19cc73f184b836e3421a03966db0ee9918fbe
Reviewed-on: https://skia-review.googlesource.com/118627
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-04-05 16:15:33 +00:00
Mike Reed
c4ec816a89 replace size-alignment assert with round-down
Don't need to assert here, we just won't write into all of the external memory
if its length is not a multiple of what we need.

Bug: skia:
Change-Id: I277653f5dc3b3d7560ab71a10440275f55430833
Reviewed-on: https://skia-review.googlesource.com/118884
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
2018-04-05 16:15:02 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
fcd3ec5032 Roll third_party/externals/angle2/ bc54342bf..dd196e0bc (14 commits)
bc54342bf6..dd196e0bc0

$ git log bc54342bf..dd196e0bc --date=short --no-merges --format='%ad %ae %s'
2018-04-04 lucferron Vulkan: Implement color mask and depth mask bits
2018-04-04 oetuaho Identify functions by unique id in BuiltInFunctionEmulator
2018-03-31 jmadill Vulkan: Rename StreamingBuffer to DynamicBuffer.
2018-04-02 lfy GLES1: Add MatrixType packed enum to entry points
2018-03-30 courtneygo Fix Tokenizer issue
2018-04-04 oetuaho Disallow case statements nested in blocks
2018-03-29 lfy GLES1: glMultiTexCoord4(f|x)
2018-03-31 jmadill Vulkan: Move image layout into helper.
2018-04-04 lucferron Vulkan: Follow up change to optimize number of condition checks
2018-03-29 lucferron Vulkan: Implement stencil test support
2018-03-29 lucferron Vulkan: Depth/stencil scissored clears
2018-03-31 jmadill Vulkan: Use DrawCallParams in draw methods.
2018-04-04 jmadill Move Buffer Subject/Observer to front end.
2018-04-03 oetuaho Validate gl_FragData and gl_FragColor access after parsing

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=herb@google.com

Change-Id: I0a836d1df056233b0201427633eabdd0d163c87e
Reviewed-on: https://skia-review.googlesource.com/118900
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-05 15:56:02 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
90cf45bd6e Roll third_party/externals/skcms/ d26d270c8..3cb9ba6ae (7 commits)
https://skia.googlesource.com/skcms/+log/d26d270c88d3..3cb9ba6ae2d6

$ git log d26d270c8..3cb9ba6ae --date=short --no-merges --format='%ad %ae %s'
2018-04-05 brianosman Remove auxiliary nonlinear parameters struct
2018-04-05 brianosman Go back to float precision throughout approximation code
2018-04-04 brianosman Remove nextafter, no need to nudge D any longer
2018-04-04 mtklein clean up isfinite_
2018-04-04 brianosman Remove all usage of libm / math.h
2018-04-04 brianosman Use portable transcendental functions in more places
2018-04-04 mtklein tweaks to build with clang-6 against GCC's math.h

Created with:
  roll-dep third_party/externals/skcms
BUG=skia:


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=herb@google.com

Change-Id: Ica6f44bc7b1a21ee60c9bf99b41bb87a5d06837c
Reviewed-on: https://skia-review.googlesource.com/118826
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-05 14:57:32 +00:00
Hal Canary
0ad685a170 SkPDF: implement xheight for type3 fonts
Change-Id: Ib8e5424e31003798ea141e958a74aa8110ee52c7
Reviewed-on: https://skia-review.googlesource.com/117860
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-04-05 14:48:52 +00:00
Robert Phillips
8caf85f9f4 Add GrBackendTexture/RenderTarget accessors to SkSurface
Change-Id: I63477fd4b8d48dc50af72736f0f8df566cd96d4a
Reviewed-on: https://skia-review.googlesource.com/85220
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Cary Clark <caryclark@skia.org>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-04-05 14:21:07 +00:00
Robert Phillips
91749c8252 Add SK_API to SkSurfaceCharacterization
TBR=bsalomon@google.com
Change-Id: I111a6e3eef798d6ad904c17eb536bb64c3801bb2
Reviewed-on: https://skia-review.googlesource.com/118594
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-04-05 14:20:12 +00:00
Hal Canary
b5680ca0d8 experimental/tools: minor code cleanup
Change-Id: I4d84dfed284aea9746808bf8a22f45e5bd9c519f
Reviewed-on: https://skia-review.googlesource.com/118597
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-04-05 14:16:02 +00:00
Brian Osman
c585e20f5a Workaround for lack of ESSL3 external image extension on older Samsung devices
This undoes the original workaround[1] and moves it to our caps
workarounds. It also forces us to use the ESSL3 extension string when
applying the workaround, as that appears to be necessary. (Otherwise,
offending devices just fail to compile when using the older extension
string with a newer GLSL version).

[1] https://skia-review.googlesource.com/c/skia/+/114505

Bug: skia:7713
Change-Id: I9757034b282a663c6e4d5fd19889c977a12a4d91
Reviewed-on: https://skia-review.googlesource.com/118665
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-04-05 13:42:32 +00:00
Cary Clark
ba75aee952 tweak SkImage documentation
- fix syntactic nits
- add how to check result of getBackendTexture
- add example

R=robertphillips@google.com
TBR=reed@google.com
Docs-Preview: https://skia.org/?cl=118590
Bug: skia:6898
Change-Id: I60cfcf448dc2f201ecc34d33ead707d0c3e3b86b
Reviewed-on: https://skia-review.googlesource.com/118590
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Cary Clark <caryclark@skia.org>
2018-04-05 12:47:52 +00:00
Robert Phillips
636fbaea77 Fix iOS bot in Chrome CQ
TBR=herb@google.com
Change-Id: I5133278b8c8293ea6808ce8f0a724b884aba24f0
Reviewed-on: https://skia-review.googlesource.com/118589
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2018-04-05 12:23:22 +00:00
Update Docs
a24c622fb2 Update markdown files
Automatic commit by the Housekeeper-Nightly-Bookmaker bot.

TBR=update-docs@skia.org
NO_MERGE_BUILDS

Change-Id: I36aaa85dcacf037a821d91f40c4bb053a5a4f456
Reviewed-on: https://skia-review.googlesource.com/118522
Reviewed-by: Update Docs <update-docs@skia.org>
Commit-Queue: Update Docs <update-docs@skia.org>
2018-04-05 06:52:49 +00:00
Brian Salomon
4470e349a6 Avoid calling glGetString(GL_EXTENSIONS) on core profiles
Change-Id: I75c5cd61ddaad91187f65c494f75da720934936d
Reviewed-on: https://skia-review.googlesource.com/118683
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-04-04 23:53:38 +00:00
Brian Salomon
9a544bcab8 Stop using clear-as-draw workaround on newer Intel drivers on macOS
Bug= chromium:777849

Change-Id: I6276cbbf4bf6403ff9bf613d1fb31e56785a035e
Reviewed-on: https://skia-review.googlesource.com/118625
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-04-04 20:54:48 +00:00
Yuqian Li
4b99bbb076 Ensure that pointers/arrays are valid until flush in threaded backend
Bug: skia:7672 skia:7414
Change-Id: Ia000781401fe7b1df8040abb97692e6ca35b312f
Reviewed-on: https://skia-review.googlesource.com/118626
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2018-04-04 20:46:59 +00:00
Ben Wagner
9bd736b9b4 Add loongson3a Build jobs.
Change-Id: I4a0259f82272099e08df0e7dea91489f6d641ca4
Reviewed-on: https://skia-review.googlesource.com/113670
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-04-04 20:37:28 +00:00
Robert Phillips
c5509955b9 Add GrBackendTexture accessor to SkImage (take 2)
This makes accessing the GPU resource behind an SkImage a lot more typesafe. Additionally, the GrBackendObject is being deprecated so this is the path forward.

I split the controversial stuff off into https://skia-review.googlesource.com/c/skia/+/118575 (Add SkImage::setLayout call).

Change-Id: I297e72770e8fb360fac7c7cd74f050ae759ae133
Reviewed-on: https://skia-review.googlesource.com/118571
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-04-04 20:34:28 +00:00
Mike Reed
1fda0247a7 move SkIPoint16 to private header
Bug: skia:
Change-Id: Ib8045ac7cc24a44c4b70e73153c6faf098730b63
Reviewed-on: https://skia-review.googlesource.com/118721
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-04-04 20:16:58 +00:00
Ben Wagner
cab7d0c118 Update mips64el_toolchain_linux to GCC 7
Change-Id: I31f4f2aff4e35dac066d208a9048ab0f96020fd1
Reviewed-on: https://skia-review.googlesource.com/118681
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-04-04 20:16:48 +00:00
Florin Malita
325ea327ff Fix SkLocalMatrixShader nesting semantics
Inherited/outer local matrices are supposed to compose to the right of
(preconcat) other/nested local matrices.

BUG=skia:7781

Change-Id: Icd3c24f226845427be849a8be3d78293aef176b3
Reviewed-on: https://skia-review.googlesource.com/118344
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>
2018-04-04 18:54:28 +00:00
Greg Daniel
1efe322473 Make sure we set the origin when initDescForDstCopy fails
Bug: skia:
Change-Id: Ic46a8086c530857d57dd713363482b50b48b5a4f
Reviewed-on: https://skia-review.googlesource.com/118682
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-04-04 18:39:18 +00:00
Florin Malita
af2769d00b Banish SkShaderBase::isRasterPipelineOnly()
Keeping related heuristics in sync with actual shader capabilities is somewhat tricky,
and overall fragile.

So how about this: instead of an explicit opt-in mechanism, try to instantiate a legacy
shader context and fall back to raster pipeline on failure (null Context => implicit
opt-in for raster pipeline).  Shaders can still choose not to draw by returning both a
null Context and failing appendStages().

BUG=skia:7772
Change-Id: I2e76f51af7064853a6cb851b4c30c82eba3ee828
Reviewed-on: https://skia-review.googlesource.com/118383
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>
2018-04-04 18:13:48 +00:00
Yuqian Li
bf74a46081 Fix drawBitmapRect in the threaded backend
Previously, the threaded backend failed to drawBitmapRect (see,
e.g., GM_bitmaprect_s) because it did not intercept the call to
SkDraw::drawBitmap.

Bug: skia:
Change-Id: I7eeaae98e63d726b2b566c4d15f7ea939f59360e
Reviewed-on: https://skia-review.googlesource.com/115983
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2018-04-04 17:42:28 +00:00
Mike Klein
378679cc47 add Mac ASAN bots
Change-Id: I783c0ad51a33e4731470f457132a1d20025a3431
Reviewed-on: https://skia-review.googlesource.com/118342
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-04 16:42:18 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
5edc806a1c Roll skia/third_party/externals/skcms/ 7dd7eed65..d26d270c8 (1 commit)
https://skia.googlesource.com/skcms/+log/7dd7eed65a72..d26d270c88d3

$ git log 7dd7eed65..d26d270c8 --date=short --no-merges --format='%ad %ae %s'
2018-04-04 brianosman Weight the D point heavily during nonlinear regression

Created with:
  roll-dep skia/third_party/externals/skcms


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=herb@google.com

Change-Id: Idcfb1702dba075dd87801a035d849818e9045562
Reviewed-on: https://skia-review.googlesource.com/118573
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-04 16:38:28 +00:00
Derek Sollenberger
e1c60d660e Tag the unique keys of lazy images.
Change-Id: I54175db2aae43d28fd7aff224d57bf6ed9093b1e
Reviewed-on: https://skia-review.googlesource.com/118588
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Derek Sollenberger <djsollen@google.com>
2018-04-04 16:20:48 +00:00
Robert Phillips
c1267c6051 Add SkSurfaceCharacterization operator== && !=
TBR=bsalomon@google.com
Change-Id: Ic58849dcb3be1f00431f897af328f6f3c3f00d75
Reviewed-on: https://skia-review.googlesource.com/118340
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-04-04 15:41:48 +00:00
Brian Salomon
dc09213b17 Revert "Revert "Make SkSL GLSL generator declare sk_FragColor inout when EXT fb fetch is used.""
This reverts commit d40133092a.

Bug: skia:
Change-Id: I236505da047d5ad29e4952d8955eb7aa1bfb870b
Reviewed-on: https://skia-review.googlesource.com/118621
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-04-04 14:45:58 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
d838765478 Roll skia/third_party/externals/angle2/ 5d232d53b..bc54342bf (6 commits)
5d232d53bb..bc54342bf6

$ git log 5d232d53b..bc54342bf --date=short --no-merges --format='%ad %ae %s'
2018-03-30 jmadill Vulkan: Make RenderTargetVk use ImageHelper.
2018-03-29 lucferron Vulkan: Support for bools and bvec* uniforms
2018-03-30 jmadill Vulkan: Add an Image helper class.
2018-03-31 jmadill Fix potential bad access in LinkProgram.
2018-03-20 oetuaho Collect static use information during parsing
2018-03-21 oetuaho Avoid mangled name comparisons of 3-parameter functions

Created with:
  roll-dep skia/third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=herb@google.com

Change-Id: Ia6601a8c63e47332982b5ae4dd3d06cd03e97a6b
Reviewed-on: https://skia-review.googlesource.com/118561
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-04 14:19:41 +00:00
Greg Daniel
75a130258d Don't use the inner radius when not stroking in DIEllipse
Bug: skia:7769
Change-Id: Ida462aec8ad832f01aec07602d8be5735a9b0ca2
Reviewed-on: https://skia-review.googlesource.com/118582
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2018-04-04 14:05:01 +00:00
Brian Salomon
d40133092a Revert "Make SkSL GLSL generator declare sk_FragColor inout when EXT fb fetch is used."
This reverts commit 7e1dd2017a.

Reason for revert: breaking fp compilation

Original change's description:
> Make SkSL GLSL generator declare sk_FragColor inout when EXT fb fetch is used.
> 
> Change-Id: I5e6e3263bb49febc757cd63d5d6c1518f174322d
> Reviewed-on: https://skia-review.googlesource.com/118420
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>

TBR=egdaniel@google.com,bsalomon@google.com

Change-Id: I2aedfaff93150ba8cd1ed9fed22f3cfdd509695a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/118600
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-04-04 13:58:42 +00:00
Ben Wagner
a24d505f2a Add mips64el_toolchain_linux asset.
No-Try: true
Change-Id: Ief4e48a6bc2f126b31af3e8a381f8a6d5a73d523
Reviewed-on: https://skia-review.googlesource.com/117083
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-04-04 13:48:41 +00:00
Brian Salomon
7e1dd2017a Make SkSL GLSL generator declare sk_FragColor inout when EXT fb fetch is used.
Change-Id: I5e6e3263bb49febc757cd63d5d6c1518f174322d
Reviewed-on: https://skia-review.googlesource.com/118420
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-04-04 13:42:51 +00:00
Greg Daniel
c412b59582 Handle perspective scales in GrPathUtil scaleToleranceToSrc
Bug: skia:7769
Change-Id: Ibf52ebfe5bb79afd0358278fbd284084a10b076b
Reviewed-on: https://skia-review.googlesource.com/118180
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2018-04-04 13:39:01 +00:00