Not a critical test, but its data file is out of date.
Change-Id: I41a1a94b2235e5b853e1516af7129f1cc0c0c785
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430217
Reviewed-by: Mike Reed <reed@google.com>
This is not a tessellation shader, and only inherited from
GrPathTessellationShader because it was used by the tessellation path
renderer. Remove its dependence on GrPathTessellationShader.
Bug: skia:10419
Change-Id: Ia97ef68488fae1c90674c5a006a62a3157bb707f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430019
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Disabling multisample while rendering to an MSAA target is a dwindling
feature that comes with a heavy performance cost on some devices, and
many devices don't support it at all. This CL just flips a bit so we
never disable multisample. After a few days or weeks of soak time, we
will come back and yank out all the code that supports disabling
multisample.
Bug: skia:12196
Change-Id: Iae54d25d0e28e24eda6295d7155e5c9fbb398081
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429299
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
We should have always used the default GP here. It makes for better
reuse, and shader that draws raw triangles isn't a "tessellation"
shader anyway.
Bug: skia:10419
Change-Id: Ia2ef2a83f5ed8917005e12b9f9a52c1d9f877575
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429956
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Change-Id: I73922717d4ebd8c759f7fe5c7c8e8da4567a0aa9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430039
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Pull a thread, and end up removing logs of old fontmgr code.
Change-Id: I73cebf9c011a99e9d12fd728e8677fcb0700407f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429338
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Change-Id: I84fe0319a15065f5de85cd4bed20d648b88c2b56
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429897
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
Because C++ does not have the '^^' operator, we had previously just
skipped support for this GLSL operator. This implements it as a
function.
Change-Id: I310658d900de4609572aed4750d6fb27f88d0722
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430036
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Bug: chromium:1220246
Change-Id: I0e9db2e403455ccc5d75acc714aa8201db285afc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429678
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
When isinf is not supported, we simply add another instanced attrib that
tells the shader exactly what type of curve it's dealing with.
Bug: chromium:1220246
Change-Id: I3496de674ce8c7df205e3c40559ae89dc29488e1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429676
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Change-Id: I13ae7034cda4291743f433406ee2e8267dd48d3e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/416576
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Introduce private SkLegacyFQ to allow us to continue deserializing
old content with filter-qualities, but still remove the public enum.
Need to finish removing references in clients.
Change-Id: Iacfb602ec497260e53defc4b95e297ed1ef4e69c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429476
Auto-Submit: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
0202156442
0202156 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
Roll CAS Client from 56d8faf61a03 to 175b811c1eeb
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id3c9af7172825acd539e5bcda57ce7478a0b4932
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429736
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
397fc145b8..4d9e1f230f
2021-07-19 cnorthrop@google.com More skips for GLSLTest_ES31.TypesUsedInDifferentBlockStorages
2021-07-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ec932ff42c9b to ac347590d69b (492 revisions)
2021-07-17 timvp@google.com Call getNearestSamples() in Framebuffer::setAttachment()
2021-07-16 cnorthrop@google.com Skip GLSLTest_ES31.TypesUsedInDifferentBlockStorages AMD Linux
2021-07-16 ianelliott@google.com Two fixes to DevSetup.md
2021-07-16 geofflang@chromium.org Remove the explicit context extension.
2021-07-16 syoussefi@chromium.org Vulkan: SPIR-V Gen: Support bool in interface blocks
2021-07-16 jmadill@chromium.org Vulkan: Prefer the local vulkan loader over the system one.
2021-07-16 jmadill@chromium.org Capture/Replay tests: Enable dcheck_always_on.
2021-07-16 lunpujun@google.com Avoid recreating activity when rotating the display.
2021-07-16 jmadill@chromium.org Capture/Replay: Don't try to serialize compressed textures.
2021-07-16 jmadill@chromium.org Capture/Replay Tests: Swap before TearDown.
2021-07-16 gert.wollny@collabora.com Capture/Replay: Capture WaitSemaphore and SignalSemaphore
2021-07-16 gert.wollny@collabora.com Capture/Replay: redesign capturing of arrays passed by pointer
2021-07-16 gert.wollny@collabora.com tests: GL_NUM_BINARY_FORMATS is a ES 3.0 property
2021-07-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 8cd71c4b8d72 to ec932ff42c9b (494 revisions)
2021-07-16 gert.wollny@collabora.com Capture/Replay: Capture FenceNV parameters
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: ethannicholas@google.com
Test: Test: MultisampledRenderToTextureTest.FramebufferCompletenessSmallSampleCount
Change-Id: I9807c9bf425e212cb18520cf45ce965025435d0b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429716
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
note: our min picture-version dates from 2020
Change-Id: I5b9d2e8a13afd16fe5b3ae88f9747f0da4382d29
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428196
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools, recipe_engine) into this repository.
depot_tools:
92c396e45d
92c396e (bryner@google.com)
cpython3 3.8.10.chromium.20 to depot_tools bleeding edge.
recipe_engine:
3a8a334ce1
3a8a334 (yiwzhang@google.com)
engine: upgrade third-party library
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib006689370e25ea2ccb273762520456f95ed710b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429041
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
In a perfect world, this should always render the same, just perhaps a
bit more slowly.
Change-Id: I750ad43142d4d192be4db7396989d978025179a8
Bug: skia:12080
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429101
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.
depot_tools:
a3d1aaf112
a3d1aaf (sokcevic@google.com)
Revert "[depot_tools] Add --fork-point when computing merge-base"
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia6095dc83dee3c1dbbde615cc1e6cf50e25b9152
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429039
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
These presented as warnings while compiling on Applie silicone.
Change-Id: Icfcd2b0ad163a8bb429d81354b628ca00b0c1a8d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429137
Auto-Submit: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
The fuzzer passed in a point with a Y coordinate of NaN; this eventually
caused an integer overflow while attempting to calculate
`SK_MaxS32FitsInFloat << 2`. We now detect the NaN and return false.
Change-Id: I79e51190006bce5e2c42935e1075261a3e16aa6d
Bug: oss-fuzz:36198
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429099
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Also fixes GPU sizes to use new attachment scheme.
Bug: skia:12186
Change-Id: I4259cd26ac6b41eeda3a6d8bb42e1f283ae9e4d3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429197
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.
depot_tools:
f6f3c7a46e
f6f3c7a (johannkoenig@google.com)
[docs] update links to developer guide
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I59d206123921e70a3612b6e596eadc25733b8d7a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429038
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This is a reland of 6789b82401
Original change's description:
> Fix directional shadows.
>
> The xy offset calculation for drawShadow was not quite correct. Rather
> than normalizing the light vector and using the xy values of that as the
> base offset value, we should scale the light vector by 1/z.
>
> See https://github.com/flutter/engine/pull/27124#issuecomment-880182653
> for more detail.
>
> Bug: skia:10781
> Change-Id: Ib69a313cb96a532f8d89644e3d69f666a184e897
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428880
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Jim Van Verth <jvanverth@google.com>
Bug: skia:10781
Change-Id: Ib58d374aa03d0144512e5ded6ccd572c74783607
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428978
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
With M93 Chromium is dropping support for older Linux distributions.
The new minimum requirements are Ubuntu 18.04+, Debian 10+,
openSUSE 15.2+, or Fedora Linux 32+. Update Skia's minimum requirements
to match.
Change-Id: I280a0790d4ee4d803bc15e2e29828be692ea934e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428983
Commit-Queue: Ben Wagner <bungeman@google.com>
Commit-Queue: Heather Miller <hcm@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
SwiftShader has a bug in atan(y,x), and it turns out we have the data
already available to compute the angle we need in a different way.
Bug: skia:12217
Bug: chromium:1229486
Bug: b/193856577
Change-Id: I9b2c5fca3b0495f034c379c79e82de75e255abc6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429136
Auto-Submit: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Justin Novosad <junov@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
We now null-check the result of recordingContext() before using it.
Thanks cqjjjzr2@gmail.com for the initial discovery and suggested fix.
Change-Id: Iafcf306f8cd9deb7147ef9c5c71a21907eedc01f
Bug: skia:12214
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429098
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.
depot_tools:
5eebf6fa78
5eebf6f (mmoss@google.com)
Add docstrings so gerrit_client subcommands display properly.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I09fb49a2e344e2bfedbe1a4d3f5cac5cf7249201
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429037
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
db54b8dd65..397fc145b8
2021-07-16 jiajia.qin@intel.com Fix the ext-texture-norm16 with RG16 failures
2021-07-15 jonahr@google.com Enable SwANGLE on ozone headless
2021-07-15 thomasanderson@chromium.org [GLX] Allow usage of multiple visuals
2021-07-15 syoussefi@chromium.org Vulkan: SPIR-V Gen: Assignment between mismatching SPIR-V types
2021-07-15 syoussefi@chromium.org Vulkan: SPIR-V Gen: Support row-major blocks
2021-07-15 ynovikov@chromium.org Skip DrawRepeatUnalignedVboChange on Mac ARM Metal
2021-07-15 jmadill@chromium.org GL-CTS: Add option to run on D3D11 refrast.
2021-07-15 cnorthrop@google.com Vulkan: Suppress VVL errors triggered by external formats
2021-07-15 m.maiya@samsung.com Add YUV format utils and validation code
2021-07-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a03f2d365426 to 7c4121a2cfd0 (1 revision)
2021-07-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 47358b0400b8 to 8cd71c4b8d72 (448 revisions)
2021-07-15 timvp@google.com Capture/Replay: Refactor shared context handling
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: johnstiles@google.com
Test: Test:
Test: Test: Manual MEC and replay of Magic Tiles 3, Candy Crush Soda Saga, Temple Run 2
Change-Id: Ia88c77c9012f51855b58dcc83a5cdc7e5267f3af
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428948
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
