Commit Graph

56415 Commits

Author SHA1 Message Date
skia-autoroll
71d90cf280 Roll ANGLE from a8e98a238521 to 2534ee4c5b9d (11 revisions)
a8e98a2385..2534ee4c5b

2021-07-14 kbr@chromium.org Limit the size of declared variables in WebGL shaders.
2021-07-14 kbr@chromium.org Fix iOS Simulator build after direct-to-Metal upstreaming.
2021-07-13 jiajia.qin@intel.com Fix the INVALID_ENUM error
2021-07-13 kbr@chromium.org Use "frameworks" rather than "libs" for iOS dependencies.
2021-07-13 cnorthrop@google.com Skip SourceYUVAHBTargetExternalRGBSampleInitData on Pixel4
2021-07-13 natsu@google.com Vulkan: update D/S state in ContextVk::onFramebufferChange
2021-07-13 jonahr@google.com Suppress BlitFramebufferTest.MultisampleDepth on Metal
2021-07-13 timvp@google.com Cleanup license data and remove Android.mk files
2021-07-13 cnorthrop@google.com TracePerfTests: Add ScreenShotFrame option
2021-07-13 jonahr@google.com GL: Widen scope of disable_sync_control_support workaround.
2021-07-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7d1a6713a379 to 624f8c7a15ff (526 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: johnstiles@google.com
Test: Test: SourceYUVAHBTargetExternalRGBSampleInitData
Change-Id: I0858a0de1bf8612d07fb3fe8f526ef09e35d3ed1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427858
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-14 04:54:20 +00:00
recipe-roller
8ac703de8c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
e94ab775a0~..2d544e44a68492f5ad8502b60f065dc0eef2f417
  e94ab77 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 90ec6154778b to 647e189404be
  2d544e4 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 647e189404be to 6641f431901a

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I924daf2096d9b739f4e33a045626c7a9c5fa5364
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427840
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-14 04:26:00 +00:00
recipe-roller
662edc0343 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
779f420ee4~..fc1a279b59d11be93ec932dc82ff9f1a69a5e59e
  779f420 (yiwzhang@google.com)
      py3: write final build after encode to bytes
  fc1a279 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from cce17a1c9de7 to daf8d357b17b

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I21a96d20f83d826b12646aacc928bd0dd11fee6c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427837
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-14 03:20:50 +00:00
recipe-roller
97dba83632 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools, recipe_engine) into this repository.

depot_tools:
d5c4633772
  d5c4633 (gbeaty@chromium.org)
      Switch to absolute refs in recipes.cfg.

recipe_engine:
da7f6914c0~..2442d397bc7f451a80affc8aef7554e364fe96a0
  da7f691 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 6d46e979bf82 to 7c0d27d44d43
  2442d39 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 7c0d27d44d43 to 973fb4ea919a

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I529250431f8afb36519df9ddd080ff049af24ad0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427777
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-14 00:32:30 +00:00
recipe-roller
9be70acd26 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
c442abe17a
  c442abe (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 5c22e8e1f3bb to 8b8a9a6040ca

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1882afed273320e0b6db7b7692b9eb623cdb42b5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427776
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-13 23:29:23 +00:00
recipe-roller
9847fe79d9 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
ab261a3f93~..4c0c173629f06ff56252aed5f9fdd39f2af3bfd3
  ab261a3 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from f39c1f9769da to f3add13b9377
  4c0c173 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from f3add13b9377 to 00de4eb9ddb1

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I38ed2be81b42f938987ea3b4d90624725d360702
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427552
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-13 22:24:00 +00:00
Chris Dalton
25da4062d5 Make elliptical ops in GrOvalOpFactory compatible with DMSAA
Detects MSAA and increases the AA bloat in order to guarantee every
pixel with nonzero coverage has a full sample mask. Starts using the
oval ops from GrSurfaceDrawContext when DMSAA is available.

Bug: skia:11396
Change-Id: I83c029e7a711da62cfec6f5a1c6df249c131fa22
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427637
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-07-13 22:11:35 +00:00
Chris Dalton
8cb159b504 Never disable multisample with DMSAA
DMSAA used to disable multisample in order to use coverage ops, but it
turns out that disabling multisample while rendering to an MSAA target
is very expensive. This CL updates DMSAA to always prefer the MSAA op
unless a coverage version exists that also knows how to render when
multisampling is enabled. We will follow it up with updates to
coverage ops that make them MSAA compatible.

Bug: skia:11396
Change-Id: I8e4ea763710d96593e08877b100eb7777268d7eb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427657
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-07-13 21:58:30 +00:00
recipe-roller
03a2d276ea Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
0b9ac35680~..acda420147fd87401ae5ee1d726ae066aff71167
  0b9ac35 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from f64317bee9e6 to ac9bf6631ffc
  acda420 (yiwzhang@google.com)
      py3: make a few modules py3 compatible

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2fc289e0291d1e375f52bdab0e151b54dcdb0bc0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427656
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-13 21:23:51 +00:00
Julia Lavrova
3cf050bba6 Fixing placeholder position
Bug: skia:12130
Change-Id: Iac2f4f1799f054694d33259f31d1216aa040c5e0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426923
Commit-Queue: Julia Lavrova <jlavrova@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2021-07-13 20:47:50 +00:00
Jim Van Verth
054126580d Use attachment in GrMtlTexture rather than raw id<MTLTexture>.
Adds methods for creating GrMtlAttachment for textures and wrapped
textures.

Bug: skia:12186
Change-Id: Iaf89c4a57bdb4af25f4086581be190ae6faf0d31
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427199
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2021-07-13 20:47:40 +00:00
Michael Ludwig
8115997316 Check hairline after resolving edge flags
Change-Id: Ib0682649d298317b3bcd8c50ca473bb6351fd55b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427616
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2021-07-13 20:33:30 +00:00
recipe-roller
a63205db7e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
dfab43394d
  dfab433 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 3daf4d628858 to f64317bee9e6

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idc4858806eb910a20ebdd5cfd0b18d5c395e73eb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427636
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-13 20:29:01 +00:00
Chris Dalton
6aaf00fa7e Add a "usesMSAASurface" arg to GrMeshDrawOp::onCreateProgramInfo
onCreateProgramInfo needs to know if DMSAA will be rendering to a
separate MSAA target in order to properly set up its pipeline and
shaders. This CL mostly just plumbs this unformation through, but also
cleans up FillRRectOp now that this information is available.

Bug: skia:12201
Change-Id: I7300d2725da72484a12bd0c9d3ad298ae81bff90
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427577
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-13 20:22:31 +00:00
recipe-roller
f91013f44b Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

depot_tools:
7e133ff177
  7e133ff (sokcevic@google.com)
      Use main branch as the default branch

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I40d496b012fdb3ee3fe886685d966a6bef494c6d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427487
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-13 19:37:29 +00:00
Julia Lavrova
2eafe9c17d Fixing canvaskit test after fixing line metrics
Change-Id: I8ad525bd8cc44e194811b2c1760ea4ce430bf2a4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427486
Reviewed-by: John Stiles <johnstiles@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Julia Lavrova <jlavrova@google.com>
2021-07-13 19:24:50 +00:00
Chris Dalton
8e2c56e6b4 Disallow DMSAA with DDL
Bug: skia:12201
Change-Id: Ic31a10f0917b3faf31dfc5ec70a2e05e544db572
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427485
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2021-07-13 19:21:50 +00:00
Chris Dalton
475c9758eb Move the DMSAA surface flag into the public API
Bug: skia:11396
Change-Id: Iad175ea9727e0b18b94a7af341c831e03da46880
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427484
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-13 19:21:00 +00:00
skia-autoroll
89d5a90d9f Roll SK Tool from 2a0de43aadc8 to 662df6e651a2
https://skia.googlesource.com/buildbot.git/+log/2a0de43aadc8..662df6e651a2

2021-07-13 borenet@google.com [sk] Add --ci flag to "asset" subcommand, to switch auth methods
2021-07-13 kjlubick@google.com [gold] Include triage history in search results
2021-07-13 kjlubick@google.com [gold] Fix bug with identifying blame ranges.
2021-07-13 kjlubick@google.com [gold] More v2 API connections
2021-07-13 rmistry@google.com [skcq] Use criaClient when talking to go/cria

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: rmistry@google.com
Change-Id: I49bb746be61eead0ce74510aa2fa8e46d9cb0ef5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427544
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-13 19:19:09 +00:00
Tyler Denniston
f8b7c1ac5f Pass CTM to path effects (experimental)
Add an overload to SkPathEffect that can be used when the CTM is known
at the callsite. GPU callsites are not handled here, that will be
tackled in a separate CL.

Path effects must implement the filterPath virtual that accepts the CTM,
although they are not obligated to use it. If a path effect does
use the CTM, the output geometry must be in the original coordinate
space, not device space.

Bug: skia:11957
Change-Id: I01615985599fe2736de954bb10dac881b0554ae7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420239
Commit-Queue: Tyler Denniston <tdenniston@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2021-07-13 18:42:55 +00:00
recipe-roller
5aade83fed Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

depot_tools:
4256846f2a~..9eee47a8e9bcd031ab2cf045dc82ef01a010619a
  4256846 (yyanagisawa@chromium.org)
      Roll out new goma client binary VERSION=226
  9eee47a (sokcevic@google.com)
      Validate infra configs on presubmit

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I44125a54b7f5bdae448cb40b80791c9864522721
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427576
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-13 18:36:53 +00:00
Michael Ludwig
575c921357 Account for hairline mode in rect op bounds for clipping
Disables the preApply() clip check for rects that are subpixel since the
bounds will not be correct, and avoids pre-applying clips to rects if
the result would turn into a subpixel draw.

Also disables hairline mode for rects that are not fully anti-aliased,
which showed up in the fast_constraint GMs where we'd tile an image and
the bottom/right edges were actually subpixel. Since the objective of
per-edge AA is for tiling, we don't want those subpixel edges to be
outset more than the original geometry would have been in a non-tiling
case.

Bug: skia:12164, chromium:1210170
Change-Id: I3bca4fc3e63b6f86f1da1ea7a5e5873d221755f7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426437
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-07-13 17:33:13 +00:00
Julia Lavrova
3a44eb92e9 Apparently, line metrics should not include newlines
(Flutter doc is wrong)
Bug: skia:12127

Change-Id: I422a870d3cf6346cf8b37834fe89c846f804e236
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423586
Commit-Queue: Julia Lavrova <jlavrova@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2021-07-13 17:16:23 +00:00
skia-autoroll
51eb0ca549 Roll skcms from bae5e281e80f to ba17399285ce (1 revision)
https://skia.googlesource.com/skcms.git/+log/bae5e281e80f..ba17399285ce

2021-07-13 johnstiles@google.com Fix GCC 8.3 spurious warning when disabling -Wpsabi.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC johnstiles@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Tbr: johnstiles@google.com,mtklein@google.com
Change-Id: Ie44498b3083c90675dbc545cf15582510896bbef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427477
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-13 16:48:24 +00:00
John Stiles
1edb41f4b3 Replace benjaminwagner@ and mtklein@ with rmistry@ and jcgregorio@.
Change-Id: I42e5d85057483f48bd081f0a95cd12568f5baa20
No-Try: true
Docs-Preview: https://skia.org/?cl=427496
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427496
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2021-07-13 16:24:15 +00:00
Julia Lavrova
f3ee264564 Count trailing spaces when calculating glyph position
Bug: skia:12126
Change-Id: I1431ef3e63f8f07785a39887fa4ac6f60685c549
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423636
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Julia Lavrova <jlavrova@google.com>
2021-07-13 14:54:13 +00:00
John Stiles
7729e0a97e Add hints to slicing-constructor error messages.
This is intended to make it easier for users porting GLSL code with
slicing constructors; the error message should make it clear that a
swizzle can be used here instead.

Change-Id: Ib03276ee910dfffd6146717dbd347b058f9940d1
Bug: skia:12193
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427200
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-07-13 14:12:23 +00:00
John Stiles
82bbe606ec Add static to global nullopt symbol.
This should hopefully make the code safer in C++14 by not violating
the ODR.

(bungeman@: "I think in C++14 we will in fact get multiple definitions
of this symbol, though in C++17 we won't. Maybe we should mark this as
'static' so each TU gets its own zero byte copy in C++14 but in C++17
the 'static' will also be implicitly 'static inline' and we'll only get
one?)

Change-Id: I3570421fcf2be314e1baccff0783ded4a1078666
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427037
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-07-13 14:00:03 +00:00
Robert Phillips
a92913e169 Make GrAuditTrail V1-only
This CL has some rough edges since some classes that use it (e.g., GrOpsTask) aren't yet V1-only. That said, the big CL has to be broken up somehow.

Bug: skia:11837
Change-Id: I41ed9982ca4664f893e447ba23c7aec59f42c964
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426416
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-13 13:56:53 +00:00
John Stiles
2d25d28e51 Fix typo in doc-comments.
There is no "text" parameter. There is one called "tex".

Change-Id: Id8245a8222438c60f6c7bde0638e82bdfda0aa20
Bug: skia:12168
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427338
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-07-13 13:48:19 +00:00
Florin Malita
46f39a0aa0 [skottie] Avoid null ptr deref in motion tile effect
If the layer shader local matrix is non-invertible, we end up with a
null layer shader and a null phase pass shader.


Bug: oss-fuzz:36099
Change-Id: I4fead885709e10b42e3e447d960151e0eb29e7d9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427337
Commit-Queue: Florin Malita <fmalita@chromium.org>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: Florin Malita <fmalita@chromium.org>
Reviewed-by: John Stiles <johnstiles@google.com>
2021-07-13 13:21:23 +00:00
skia-autoroll
224e3e257d Roll Chromium from 697e53f421f9 to 3572711a2c6a (478 revisions)
697e53f421..3572711a2c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: johnstiles@google.com
Change-Id: I4bd97841b1f01645779cf8ca560c6c4125000909
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427299
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-13 04:58:25 +00:00
skia-autoroll
56a582a02a Roll ANGLE from 04cb5e1d7d89 to a8e98a238521 (6 revisions)
04cb5e1d7d..a8e98a2385

2021-07-12 penghuang@chromium.org Fix gl::Context::unMakeCurrent crashes
2021-07-12 jonahr@google.com Metal: Populate feature list in the Metal backend.
2021-07-12 jmadill@chromium.org Vulkan: Update cube map array support check.
2021-07-12 kpiddington@apple.com Upstream Apple's direct-to-Metal backend: compile libANGLE.
2021-07-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 65498c15ca60 to 4716eec90fcb (3 revisions)
2021-07-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e09623df2fbf to 7d1a6713a379 (478 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: johnstiles@google.com
Change-Id: I776fb5c9289588e25837b10f6a3b999c2d224406
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427300
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-13 04:57:42 +00:00
recipe-roller
3a00e3e32e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
3ae44290a5
  3ae4429 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 32a95f3b0fe5 to 5bf9df714d52

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I30f43a001ca7852eaf9bd0e3a4d4fcaebbf621fa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427262
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-13 03:33:24 +00:00
recipe-roller
8de415a5ab Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
ed98a674d3
  ed98a67 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from dd7c1f6328ba to 32a95f3b0fe5

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I576d511c12a4557d9876be85a5b74f4bc6d3d7b4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427261
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-13 02:37:25 +00:00
Mike Reed
63ec43cf55 Hide deprecated filterquality
Change-Id: Ia320f07c3836a077d6feafb4a59a7c89325f9fcd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/425057
Reviewed-by: Yegor Jbanov <yjbanov@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-13 00:45:12 +00:00
recipe-roller
9cc34b450f Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
dbf72f7d7c
  dbf72f7 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 976b8c8c5bab to 3ed367eb9b38

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iaed0578e57d163e4f96d7618c45552237801954c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427260
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-13 00:40:45 +00:00
recipe-roller
2ef07d8f1a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
a99dd7a5b4~..59525ad99bc67ccbf8544aface7090e263578253
  a99dd7a (yuanjunh@google.com)
      Support running different py version simulation recipe tests
  59525ad (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from a96eb9a6140c to 976b8c8c5bab

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4408eef2177af51ae13304d3021e2344d84ac123
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427280
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-12 23:41:41 +00:00
Chris Dalton
cc29a39d42 Never disable MSAA for FillRRectOp or GrDrawAtlasPathOp
Disabling MSAA on a multisampled target seems to always be a
de-optimization. This CL updates FillRRectOp and the tessellation atlas
ops to never disable MSAA because they both know how to render correctly
with or without MSAA enabled.

This also fixes a DDL bug that existed for FillRRectOp. It was
previously not detecting MSAA targets during onPrePrepare, which would
cause it to not outset enough for MSAA in the coverage ramps.

Bug: skia:12201
Change-Id: I599fe15a4ea182ac24cff375857dc309a32f2400
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427222
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-12 22:40:14 +00:00
recipe-roller
4fd997fee7 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

depot_tools:
f6228e1583
  f6228e1 (gavinmak@google.com)
      Revert "Add python3 support to bot_update recipe module"

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id70b3b2896b41f614a5300349f9bedd3d0a21868
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427259
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-12 22:38:25 +00:00
Chris Dalton
ea46ef3a9c Move clip optimizations into GrFillRRectOp
Adds a new clipToShape() virtual on GrDrawOp and implements it with
GrFillRRectOp. GrClipStack now calls this method before attempting to
clip by any other means.

Since clips are often round rects, and a round rect/round rect
intersection can itself be round rect, this allows GrFillRRectOp to
bypass clipping entirely in many cases.

Bug: chromium:928984
Change-Id: Ic19b3f481ee489e3ca85817ba11d132172089a11
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426297
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2021-07-12 21:58:21 +00:00
recipe-roller
e5ab6f242c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
3e5d69181d
  3e5d691 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from d6dd9ccd0d44 to a1d51f0e9681

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ida009ef1ca6df6e8eb7ed68926edd3985c55c4e3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427258
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-12 21:40:44 +00:00
recipe-roller
dd984dc75c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
0c779035e7
  0c77903 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 55568bcb4c51 to 552d4b5271ba

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6e293d5465cb14c1a2e6f55e3553cf7ce411020f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427256
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-12 20:42:30 +00:00
John Stiles
ce7cdcd7b4 Add test for SkSL vector-slice constructors.
SkSL does not support shrinking a vector via casting. Use a swizzle
instead.

Change-Id: Ieba78a05dad9c55f44c765924e28f0c7e1667a67
Bug: skia:12193
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427198
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-07-12 20:33:44 +00:00
John Stiles
010c0ec061 Allow swizzles on Boolean scalar expressions.
Boolean vector expressions already allowed swizzles (see the
SwizzleBoolConstants.sksl test), but scalars had been inadvertently
disallowed.

Change-Id: I89e7139db50981f0ee1a9a5086b02603e57f967d
Bug: skia:12195
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427196
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-07-12 20:33:10 +00:00
Mike Reed
5643e55f09 Add flag for filterquality in flutter
Change-Id: I8612d58efcfac82b7924c680fd8fa91b6d48614f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426956
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2021-07-12 20:09:30 +00:00
Mike Reed
bccbec3147 Remove drawImageAtCurrentFrame
Unused by flutter
Would need variants for sampling options
Easy for clients to achieve this with other APIs

Change-Id: Ia8b29f5183f5b729b62ef35e87897d5312b38da5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427197
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-12 20:08:40 +00:00
John Stiles
7f56b41fc0 Add scalar-swizzling tests for int and bool types.
Boolean scalar-swizzling is currently not working.

Change-Id: Icd965e4b64a12311d098168f65622110d5fb3437
Bug: skia:12195
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427038
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-07-12 19:54:40 +00:00
recipe-roller
0742e6ba2d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools, recipe_engine) into this repository.

depot_tools:
758807c0a4~..56c8a27430fc15fcb4b7beb02238ffc7541634ed
  758807c (gavinmak@google.com)
      Add python3 support to git recipe module
  56c8a27 (gavinmak@google.com)
      Add python3 support to gclient recipe module

recipe_engine:
3cfd9f735e
  3cfd9f7 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from f3122648f9ce to 55568bcb4c51

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6971edf0b5a8f83e3789b6e6f826b860279946fe
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427091
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-12 19:32:41 +00:00
Ethan Nicholas
59ff4e2b78 Moved swizzle error checking into Swizzle::Convert
Change-Id: Id2676ffaba1dafc4a0485d99e1c5b87b990e0861
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426976
Reviewed-by: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-07-12 18:47:40 +00:00