Commit Graph

60529 Commits

Author SHA1 Message Date
skia-autoroll
6080d9df9e Roll ANGLE from a8ebdf2b5a8b to 1d8227dab6f1 (18 revisions)
a8ebdf2b5a..1d8227dab6

2022-05-12 syoussefi@chromium.org Vulkan: Dynamic state for stencil write mask
2022-05-12 syoussefi@chromium.org Vulkan: Dynamic state for stencil compare mask
2022-05-11 senorblanco@chromium.org Cleanup from glBlitFramebuffer() 3D texture fix.
2022-05-11 syoussefi@chromium.org Vulkan: Dynamic state for blend color
2022-05-11 syoussefi@chromium.org Vulkan: Dynamic state for depth bias
2022-05-11 senorblanco@chromium.org Use GLTexture in TextureTest for RAII goodness.
2022-05-11 syoussefi@chromium.org Vulkan: Dynamic state for line width
2022-05-11 senorblanco@chromium.org D3D11: clean up ES31 test expectations.
2022-05-11 jmadill@chromium.org Add a draw call perf test for changing a single uniform.
2022-05-11 syoussefi@chromium.org Vulkan: Fix VulkanPipelineCachePerfTest
2022-05-11 senorblanco@chromium.org D3D: minor cleanup for image load/store.
2022-05-11 syoussefi@chromium.org Vulkan: Set dynamic state after binding pipeline
2022-05-11 gert.wollny@collabora.com PerfTests: Add support for eglCreateImage and eglDestroyImage
2022-05-11 lexa.knyazev@gmail.com D3D9: Enable OES_fbo_render_mipmap
2022-05-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 27ef4a0d9701 to b768d03422ea (7 revisions)
2022-05-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e4a6f2d74d3c to e0a1188d7652 (1 revision)
2022-05-11 gert.wollny@collabora.com util: Add calls for createImage* and destroyImage* to GLWindow
2022-05-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 46c13be19f0f to 693c7419bd5c (567 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: lovisolo@google.com
Change-Id: I49f5c9b795b891ba18d28efc437c00121eeb4cea
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539622
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-12 06:14:52 +00:00
skia-autoroll
866f74a1ef Roll SwiftShader from e0a1188d7652 to f1c2c0b07281 (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e0a1188d7652..f1c2c0b07281

2022-05-12 capn@google.com Revert rcpss/rsqrtss instrumentation to default propagation
2022-05-11 capn@google.com Fully enable MemorySanitizer instrumentation for GN builds

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: lovisolo@google.com
Change-Id: I6f11df554f27e24262dc51b0780566386c7699d8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539623
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-12 04:51:55 +00:00
Derek Sollenberger
d4aa36a9b6 Revert "create ParticleDrawable for animated Skotties"
This reverts commit ddd64d35c6.

Reason for revert: breaking the android build

Original change's description:
> create ParticleDrawable for animated Skotties
>
> Change-Id: Ieaea5e9c358604a25f0fecd7bac71a0450359653
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538042
> Reviewed-by: Florin Malita <fmalita@google.com>
> Commit-Queue: Jorge Betancourt <jmbetancourt@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

Change-Id: Ida2bfe6359790a49a8c2b4f8a3b96d9b14da5600
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539083
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Derek Sollenberger <djsollen@google.com>
2022-05-11 23:35:08 +00:00
John Stiles
353e2c65c9 Prevent comma operator constant-folding or constant-expression-usage.
OpenGL docs specifically insist that the sequence (comma) operator
should not be treated as a constant-expression so that attempts to
declare multidimensional arrays with a comma will fail:
http://screen/vJEpAe9yNmbzZTm

(See "12.43 Sequence operator and constant expressions" in the OpenGL
ES3 documentation or read skia:13311 for details.)

In practice, we don't get much benefit from optimizing away unused
comma-expressions; it improves some synthetic tests, but realistically
this will not help Skia in any real-world scenario. The constant folder
no longer attempts this optimization, and comma-expressions are now
rejected in a constant-expression context.

Change-Id: Ic5dea6ff90e36614b548c1ce89a444e81da944ae
Bug: skia:13311
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539565
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Arman Uguray <armansito@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2022-05-11 22:52:24 +00:00
John Stiles
e9ae96cdcd Make runtimefunctions slide much cooler.
Previously, this slide used a bunch of code to render a gray ramp. My
first impression was that the test slide was broken, but this was the
actual intent. We now use the shaders.skia.org zoomy-neurons.

Change-Id: Icd08462e30ab328b533525d74fa6064bccb76e8a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539202
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2022-05-11 21:18:53 +00:00
John Stiles
b1b1a67647 Disable optimizations when viewing shaders in the 'SkSL' setting.
Most shader text displayed in SkSL mode is passed through, exactly as
written--comments and all--and is unaffected by the optimization
setting. However, runtime effects go through the pipeline stage which
can subject them to optimizations. This is unexpected in "SkSL" mode,
where the goal is to display the shader as close to the original input
as possible.

Now, when Viewer displays a runtime effect in "SkSL" mode, it will not
have optimizations applied (other than some basic stuff like constant
folding, which is currently non-negotiable in SkSL).

Change-Id: I9bd3d8f7067d7124b3fbe88e8a422212b645597a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539200
Reviewed-by: Arman Uguray <armansito@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2022-05-11 21:18:35 +00:00
Herb Derby
31dffc0ed7 Make the SkGlyphRunPainter clearly GPU only
This includes using SkNoPixelsDevice for the GlyphTrackingDevice
in the SkChromeRemoteGlyphCache because it is the only thing that
uses SkGlyphRunPainter outside of GPU.

Change-Id: Id22e538b2c1aa0d65433878e428c9465fe222d12
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539558
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-05-11 20:29:38 +00:00
John Stiles
04a696455b Simplify identity matrix creation.
GLSL/SkSL allow creation of a uniform scale matrix by constructing a
matrix with a single scalar argument. It will be splatted across the
matrix's diagonal.

Change-Id: If3410909f8136f3f4c39f7d7208d5bd6066e4e53
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539047
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2022-05-11 20:27:16 +00:00
skia-autoroll
415c398a14 Roll SK Tool from c91f0c000f6a to a95b1801a0a9
https://skia.googlesource.com/buildbot.git/+log/c91f0c000f6a..a95b1801a0a9

2022-05-11 borenet@google.com [autoroll] Add CHROMIUM_NO_CR Gerrit label config

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: lovisolo@google.com
Change-Id: Ie73ada9fa17817bd72670ad3c314984273aa339d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539223
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-11 20:04:00 +00:00
John Stiles
625baf8e5b Disable EmptyBlocksES3 test on Pixel 2XL/3.
Looks like really old drivers struggled with weird no-op blocks.

Change-Id: Ie32754a9c221eb7c20924ee27e5facca7e9701f0
Bug: skia:13309
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539561
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2022-05-11 19:46:59 +00:00
skia-autoroll
925a500435 Roll vulkan-deps from b768d03422ea to 427a49d213e9 (3 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/b768d03422ea..427a49d213e9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn;skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE
Bug: None
Tbr: lovisolo@google.com
Change-Id: Iddb7f856e66fba3437a07db8ff1d9e52ddedcaa5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539220
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-11 18:38:19 +00:00
Jorge Betancourt
ddd64d35c6 create ParticleDrawable for animated Skotties
Change-Id: Ieaea5e9c358604a25f0fecd7bac71a0450359653
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538042
Reviewed-by: Florin Malita <fmalita@google.com>
Commit-Queue: Jorge Betancourt <jmbetancourt@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2022-05-11 17:44:53 +00:00
Michael Ludwig
928683be91 Simplify CalcNumRadialSegmentsPerRadian signature
The conceptual meat of this change is that instead of taking a local-to-
device scale factor and the local stroke width, CalcNumRadialSegments
now takes the approximated device-space stroke radius. The main benefit
of this is that hairlines can be defined exactly without needing to
invert the local-to-device matrix or otherwise estimate a local-space
radius that would transform to the 1px hairline. The actual math for
regular strokes remains the same (scale factor * radius), but is moved.

In addition, this CL fixes a bug I had introduced in
https://skia-review.googlesource.com/c/skia/+/502059/
where I had not realized the CPU code operated on stroke *width* and the
GPU code operated on stroke *radius*, so updating them to use the same
equations w/o changing their inputs actually caused us to overestimate
the number of radial segments required. With this change, both the CPU
code and GPU code operate on stroke radius.

Between that bug fix and simplifying the hairline stroke radius math,
I am expecting lots of slight AA changes around stroked paths.

Lastly, I entirely removed the StrokeTolerancesBuffer, which was a class
that buffered up calculations of CalcNumRadialSegments by looking at the
entire list of paths in an op and putting them into a 4-lane SIMD
function instead. This isn't currently available for Graphite and makes
it harder to consolidate the radial segment calculations. Locally I
found no noticeable difference in the patch writing microbenchmarks
(where it would be more significant), and somehow the motionmark SKPs
were actually a touch faster. I'm hopeful that we can drop this
complexity and not take a large performance hit.

Bug: skia:13056, skia:13012
Change-Id: If16103078ebe9e4e60470445c0868deb3904f7de
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/537239
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2022-05-11 17:44:05 +00:00
Brian Osman
30162feb61 SkLineClipper::IntersectLine - Fix out-of-bounds final result
The fuzzer found a subtle bug where our line vs. rect clipping could
produce points outside of the rect. Thanks to floating poing inaccuracy,
the first (horizontal) clip would produce a point just outside the
bounds. Then, we'd re-clip against the vertical segments - but go back
and start from the original points. Again, thanks to floating point,
we'd produce a point just outside the bounds.

The fix here is straightforward: After we've done the first clip
(reducing the magnitude of the values involved, and constraining the X
coordinates), use *that* as the new endpoints for the second clip.
Mathematically this is identical (the tmp values are new upper bounds on
the extents of the final endpoints after the first clip), but the math
is more stable this way.

Bug: chromium:1320467
Change-Id: I9c816110edb2944544243f2ad89665d5bc5c9c53
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539196
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2022-05-11 17:18:50 +00:00
Michael Ludwig
dc09cf8104 Add new file to Dawn's bazel build
Change-Id: I2a1fedbbaabd57e4546c2a628f6d297e11f4244b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539318
Reviewed-by: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2022-05-11 16:24:10 +00:00
Aditya Kushwah
faa99cb931 Plumb label for atlas and store in GrDrawOpAtlas.
This CL define a const label string in GrDrawOpAtlas and have the
constructor accept it. This will help us to label atlas.

Bug: chromium:1164111
Change-Id: I6e194b9a59b940b359887736df27c1da130b1d8a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539136
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2022-05-11 15:27:24 +00:00
Robert Phillips
e11ac02775 Remove unused flush-time OpsTask feature
This is just a cascade of changes from removing the (unused) 'flushTimeOpsTask' parameter from SurfaceDrawContext::Make.

Change-Id: Ia92dfada8df007761d9de3c16e6a9c8850c3d399
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539066
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2022-05-11 15:03:10 +00:00
John Stiles
efbc7ca3b9 Remove unnecessary use of ConstructorScalarCast.
This made sense when literals were spread across multiple classes
(FloatLiteral/IntLiteral/BoolLiteral). Nowadays we can just call
Literal::Make and pass the Type that we want our literal to be.

Change-Id: I54ce5fcf7bcadac4be1fe10a358b9c86c234de8f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539397
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2022-05-11 14:51:25 +00:00
John Stiles
3c2997cacc Disable no-op arithmetic simplification when optimization is off.
We will continue to fold expressions like `10 + 0` or `5 * 1` or
`PI * 1` (assuming PI is a const float) because both sides are known,
but non-constant-expressions like `x + 0` (assuming x is not a constant)
or `foo *= 1` will be left as-is when the optimizer is off.

This improves the accuracy of the Viewer shader tab, because a runtime
effect expression like `color *= scale` will be preserved in the final
output when optimization is off, instead of being replaced with a Nop
when scale equals one.

Change-Id: I218b327cb0cd12654dca446dee8a5baa96f589b8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539197
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2022-05-11 14:39:42 +00:00
John Stiles
d259c5e4a2 Run SkSL unit tests with optimizations disabled.
We were already running unit tests twice--once with inlining on, and
once with inlining off, but always with optimization on. Now, the two
passes are instead "inliner + optimizer both on" and "inliner +
optimizer both off". (Testing the full 2x2 matrix of possibilities seems
like overkill.)

Change-Id: I73fb0932877c7b953c1f2e122125e5e7781a8582
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539396
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2022-05-11 14:38:07 +00:00
John Stiles
462dab699c Emit dead expressions when optimizations are off.
Fixes a minor issue discovered by http://review.skia.org/539198 .

Change-Id: I63f555cc005df33ce50c412796a8c773a501d271
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539199
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2022-05-11 13:37:48 +00:00
John Stiles
2f13b32f79 Add dedicated golden test for enabling/disabling fOptimize.
Previously we didn't have any mechanism for disabling the optimizer when
building golden outputs, so every golden output always had optimizations
applied.

Change-Id: I8f370b06daab6cb50bb4339eab0d39578621413b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539198
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2022-05-11 13:37:12 +00:00
Florin Malita
e1df5b2115 Update SkVideoEncode/Decoder for latest libavcodec
Some APIs have been const-ified.

Change-Id: I08699f219944057bd730d3f7a5f5466cdd829233
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539064
Commit-Queue: Florin Malita <fmalita@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2022-05-11 12:57:30 +00:00
skia-autoroll
8d3d0bcd4b Roll ANGLE from 2b8172b9b21e to a8ebdf2b5a8b (15 revisions)
2b8172b9b2..a8ebdf2b5a

2022-05-10 yuxinhu@google.com Basis Universal Texture Experiment
2022-05-10 geofflang@google.com Metal: Log the shader source when a shader fails to translate
2022-05-10 lexa.knyazev@gmail.com D3D: Mark images clean after syncing from storage
2022-05-10 johnstiles@google.com Fix crash when calling certain gl APIs before initialization.
2022-05-10 gert.wollny@collabora.com Capture/Replay: rename ANGLE_CAPTURE to ANGLE_CAPTURE_GL
2022-05-10 antonio.caggiano@collabora.com Re-land: "Vulkan: GBM platform"
2022-05-10 syoussefi@chromium.org Vulkan: Support wide lines
2022-05-10 jmadill@chromium.org Vulkan: Clean up flag passing in ImageView init.
2022-05-10 senorblanco@chromium.org D3D11: fix 3D texture blits.
2022-05-10 syoussefi@chromium.org Vulkan: Refactor UtilsVk dynamic state handling
2022-05-10 jmadill@chromium.org Vulkan: Determined sized-ness of format in initImageViews.
2022-05-10 romanl@google.com Switch deqp merge to python3
2022-05-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 626b2fd72bde to 27ef4a0d9701 (2 revisions)
2022-05-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 1dd93361b1d9 to e4a6f2d74d3c (2 revisions)
2022-05-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7f78f00fdc5c to 46c13be19f0f (273 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: lovisolo@google.com
Change-Id: Ic670dd15a39dfe5abc5f009f9fc5aefbe80564fc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539266
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-11 05:55:47 +00:00
skia-autoroll
39d6a68535 Roll vulkan-deps from 100b1c52ea66 to b768d03422ea (5 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/100b1c52ea66..b768d03422ea

Also rolling transitive DEPS:
  https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross from 0c8a79b0b5c7 to 940efca099af
  https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools from ad3514b73237 to f74b85853c35

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn;skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE
Bug: None
Tbr: lovisolo@google.com
Change-Id: Ic26f20409620b5cdbd4a43b9b31fb47e30ee2ec7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539278
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-11 05:45:16 +00:00
skia-autoroll
ddae049c23 Roll SwiftShader from e4a6f2d74d3c to e0a1188d7652 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e4a6f2d74d3c..e0a1188d7652

2022-05-10 syoussefi@google.com Fix dynamic state for line width

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: lovisolo@google.com
Change-Id: Ife2d1a76865897441492633d3c96a1464a74970b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539267
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-11 04:53:16 +00:00
skia-autoroll
5761cae936 Roll Dawn from 824e824709a7 to b2004907a354 (5 revisions)
https://dawn.googlesource.com/dawn.git/+log/824e824709a7..b2004907a354

2022-05-11 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 9872c1d63f38 to a8ebdf2b5a8b (11 revisions)
2022-05-11 cwallez@chromium.org Fix gn check for dawn_unittests.
2022-05-11 cwallez@chromium.org Fix warning in dawn.node for the newly added shader-f16 extension.
2022-05-11 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 27ef4a0d9701 to b17c2c5b5b53 (6 revisions)
2022-05-10 kainino@chromium.org Revert "[chromium-style] Adding constructors and destructors."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: kainino@google.com
Change-Id: I2c8b17a276c03c8cd2bf9e9207e813e06729694d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539265
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-11 04:37:00 +00:00
skia-autoroll
18c861675e Roll Dawn from be0abb611aed to 824e824709a7 (31 revisions)
https://dawn.googlesource.com/dawn.git/+log/be0abb611aed..824e824709a7

2022-05-10 bclayton@google.com tint: Rename float / int literal tokens
2022-05-10 bclayton@google.com tint: Add abstract AInt and AFloat typedefs
2022-05-10 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e4a6f2d74d3c to e0a1188d7652 (1 revision)
2022-05-10 dsinclair@chromium.org [warnings] Add Wsuggest-override and Wsuggest-destructor-override.
2022-05-10 enga@chromium.org Don't use incremental build in webgpu-cts/scripts/list.py
2022-05-10 bclayton@google.com tint: Replace all ProgramBuilder float literals with '_f' suffix
2022-05-10 cwallez@chromium.org DawnTest: Make error/device loss mocks StrictMocks
2022-05-10 bclayton@google.com tint: Add a negation operator to Number
2022-05-10 bclayton@google.com tint: Prevent Expr() implicit conversion to bool
2022-05-10 bclayton@google.com tint: Lex different tokens for float suffixes
2022-05-10 cwallez@chromium.org Triage WebGPU CTS expectations
2022-05-10 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2b8172b9b21e to 9872c1d63f38 (4 revisions)
2022-05-10 dsinclair@chromium.org [warnings] Add -Wunused-macros
2022-05-10 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7de4282f2446 to 27ef4a0d9701 (1 revision)
2022-05-10 jiawei.shao@intel.com tint: Support dot4I8Packed and dot4U8Packed in sem
2022-05-10 cwallez@chromium.org ShaderModule: Don't create an inspector just to reflect exts
2022-05-10 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f5cda7835ab7 to e4a6f2d74d3c (1 revision)
2022-05-10 cwallez@chromium.org Vk: Run SingleEntryPoint before BindingRemapper.
2022-05-10 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 78d88796b44b to 2b8172b9b21e (12 revisions)
2022-05-10 dsinclair@chromium.org [chromium-style] Adding constructors and destructors.
2022-05-09 lokokung@google.com Remove NiceMock on device lost callback.
2022-05-09 dsinclair@chromium.org [chromium-style] Adding/moving constructors and destructors.
2022-05-09 bclayton@google.com tint: Add unary-ops to the intrinsic table
2022-05-09 brandon1.jones@intel.com Remove Unsafe API Toggle Check For Multiplane External Textures
2022-05-09 dsinclair@chromium.org [chromium-style] Adding/moving constructors and destructors.
2022-05-09 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 626b2fd72bde to 7de4282f2446 (1 revision)
2022-05-09 bclayton@google.com tint: Add binary-ops to the intrinsic table
2022-05-09 dsinclair@chromium.org [chromium-style] Split mock constructors/destructors to cpp files.
2022-05-09 bclayton@google.com tint: Add operator support to intrinsic-gen
2022-05-09 dsinclair@chromium.org [chromium-style] Fixup a few chromium-style issues.
2022-05-09 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 1dd93361b1d9 to f5cda7835ab7 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: kainino@google.com
Test: Test: tint_unittests
Change-Id: Icac40429be0907c2677385a84289ecfa14d8850d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539217
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-10 23:56:49 +00:00
John Stiles
f54b4d5eb4 Revert "[infra] Remove old python scripts and urllib2 references"
This reverts commit 167e608bb3.

Reason for revert: breaking Housekeeper-CheckGeneratedFiles
(fetch-clang-format)

Original change's description:
> [infra] Remove old python scripts and urllib2 references
>
> I was searching for urllib2 while resolving issues with
> https://skia-review.googlesource.com/c/skia/+/538636
> when I found several old, apparently unused scripts.
>
> Rather than fix them, let's get rid of them. If they
> are still in use, the conversion to urllib.request is
> pretty easy.
>
> Change-Id: I27d419601e81c93a3d53e280188a379dfab927c4
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538936
> Auto-Submit: Kevin Lubick <kjlubick@google.com>
> Commit-Queue: Kevin Lubick <kjlubick@google.com>
> Commit-Queue: Ravi Mistry <rmistry@google.com>
> Reviewed-by: Ravi Mistry <rmistry@google.com>

Change-Id: I139a3cd070da2e6fee2f8865138cf6a63441a8cb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539201
Auto-Submit: John Stiles <johnstiles@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2022-05-10 22:48:08 +00:00
John Stiles
c2354396f0 Update comment about emitting static code snippets.
This comment fell out-of-date when the Graphite modules were added.
(I had tweaked it slightly at the time, but had missed some other places
that talked about injecting static code snippets.)

Change-Id: Ibbdf5ce14b8c77393f9da2ee22c82001e3bfd6c3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539045
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2022-05-10 20:27:47 +00:00
Herb Derby
3612fdb811 Replace path count with the read failure line number
Make it easier to figure out READ_FAILURE is reporting a problem.

Bug: chromium:1287356
Change-Id: I3962932aed5c55efc2ded941cf218e5a8e75e972
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539044
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2022-05-10 20:05:56 +00:00
Antonio Maiorano
cd3200b7a4 Manually roll Dawn from 9483b741a..be0abb611 (36 commits; 1 trivial rolls)
https://dawn.googlesource.com/dawn.git/+log/9483b741a884..be0abb611aed

$ git log 9483b741a..be0abb611 --date=short --no-merges --format='%ad %ae %s'
2022-05-09 dawn-autoroll Roll ANGLE from e316203a6a2f to 78d88796b44b (1 revision)
2022-05-08 dawn-autoroll Roll ANGLE from 225d8f83af71 to e316203a6a2f (1 revision)
2022-05-07 dawn-autoroll Roll SwiftShader from 00efa1913863 to 1dd93361b1d9 (1 revision)
2022-05-07 dawn-autoroll Roll ANGLE from cadb933fdb12 to 225d8f83af71 (2 revisions)
2022-05-07 dawn-autoroll Roll vulkan-deps from e13072c54977 to 626b2fd72bde (2 revisions)
2022-05-07 dawn-autoroll Roll SwiftShader from 74e34ab97aeb to 00efa1913863 (2 revisions)
2022-05-06 dawn-autoroll Roll ANGLE from 1d5d09e4191a to cadb933fdb12 (14 revisions)
2022-05-06 dawn-autoroll Roll vulkan-deps from 4957ae734445 to e13072c54977 (21 revisions)
2022-05-06 dawn-autoroll Roll SwiftShader from 62c1af08ea4d to 74e34ab97aeb (5 revisions)
2022-05-06 bclayton tint: Rename and move builtin_table and builtin-gen
2022-05-06 bclayton dawn: Fix clang warning treated as error
2022-05-06 zhaoming.jiang dawn: Add shader module validation for WGSL extension
2022-05-06 dawn-autoroll Roll ANGLE from 2ce60b52a239 to 1d5d09e4191a (10 revisions)
2022-05-05 jrprice Surface Vulkan validation messages in errors
2022-05-05 bclayton tint: Change all ProgramBuilder literals to 'i' or 'u' suffix
2022-05-05 dawn-autoroll Roll ANGLE from 9865ed8b8117 to 2ce60b52a239 (4 revisions)
2022-05-05 bclayton tint: Castable - support non-default-constructable return types
2022-05-05 dawn-autoroll Roll SwiftShader from 2e793ae08002 to 62c1af08ea4d (1 revision)
2022-05-05 amaiorano tint: add --overrides flag to specify pipeline overrides
2022-05-05 pkasting Fixes for C++20 support.
2022-05-05 bclayton tint: Add Bitcast helper
2022-05-05 bclayton tint: Fix CFI error in BlockAllocator
2022-05-05 dawn-autoroll Roll ANGLE from 9053a641bf5d to 9865ed8b8117 (1 revision)
2022-05-04 senorblanco OpenGLES: disable some end2end tests which require reading from depth textures.
2022-05-04 bclayton tint/reader/spirv: Generate 'i' suffixed literals
2022-05-04 bclayton tint: Merge [S|U]intLiteralExpression
2022-05-04 dawn-autoroll Roll SwiftShader from 643179694ec7 to 2e793ae08002 (1 revision)
2022-05-04 bclayton tint: Lex three types of integer literal
2022-05-04 dsinclair Enable more `gn check` results.
2022-05-04 dawn-autoroll Roll ANGLE from 84e42c3b04da to 9053a641bf5d (12 revisions)
2022-05-04 bclayton webgpu-cts/expectations.txt: Remove expectations that now pass
2022-05-04 amaiorano Disable angle dependency on wayland
2022-05-04 bclayton tint: Chromium-style fixes
2022-05-04 jamessliu2020 AST fuzzer: Change unary expression operator
2022-05-04 dawn-autoroll Roll SwiftShader from c75846ead9a0 to 643179694ec7 (3 revisions)

Created with:
  roll-dep third_party/externals/dawn

Change-Id: I6656ab41573ce465e9ced94ad65731be9bc5dafe
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538716
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
2022-05-10 19:01:49 +00:00
James Godfrey-Kittle
930a11e0e1 [graphite] Add sweep gradient shader
The comments in this shader are copied from
719239cd69:src/gpu/ganesh/gradients/GrGradientShader.cpp;l=806.
We could also link to that code in the comments themselves if that would
be helpful.

Bug: skia:13302
Change-Id: I8f0733bd02d519c603f62612b5299b6d1d56792a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538416
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: James Godfrey-Kittle <jamesgk@google.com>
2022-05-10 18:32:54 +00:00
Brian Osman
8b3731b336 Move settings tweak for "generic" programs into the compiler
Change-Id: I4643cc4c1f75deab279625e752b9fee7da2e2779
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539039
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2022-05-10 17:49:36 +00:00
Greg Daniel
2eddf1a560 Set VMA version define to limit it to vulkan 1.1.
Bug: b/231953246
Change-Id: Ib2b6ae50bfd13c7aff0e0c656bc61e5f8a6e4345
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539038
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2022-05-10 17:43:56 +00:00
skia-autoroll
6079423e54 Roll ANGLE from e316203a6a2f to 2b8172b9b21e (13 revisions)
e316203a6a..2b8172b9b2

2022-05-09 cclao@google.com Vulkan: Add missing initialization for mTotalMemorySize
2022-05-09 syoussefi@chromium.org Vulkan: Remove suppressions and workarounds for old AMD/Windows
2022-05-09 ynovikov@chromium.org Revert "Vulkan: GBM platform"
2022-05-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from bc117969dbb5 to 7f78f00fdc5c (162 revisions)
2022-05-09 geofflang@chromium.org Reset the program executable if async linking fails.
2022-05-09 antonio.caggiano@collabora.com Vulkan: GBM platform
2022-05-09 cclao@google.com Vulkan: Fix VVL error for black desert mobile
2022-05-09 lexa.knyazev@gmail.com Add CopyTextureTest.ClearAfterCopySubTexture
2022-05-09 jmadill@chromium.org Vulkan: Use ImageView layer count functions in TextureVk.
2022-05-09 geofflang@chromium.org HLSL: Disambiguate functions that have int/uint parameters.
2022-05-09 jmadill@chromium.org Vulkan: Always init image views using image format.
2022-05-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 74e34ab97aeb to 1dd93361b1d9 (3 revisions)
2022-05-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 333c8248b125 to bc117969dbb5 (506 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: lovisolo@google.com
Change-Id: I5e012995f7315271cdfe78b8e786ae347805b512
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538977
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-10 17:20:31 +00:00
Brian Osman
d724c74a4f Ensure skia_gl_standard is correct when skia_use_angle is true
This simplifies the bot script slightly. More importantly, it means that
local developers don't need to remember to do this when building ANGLE
on Mac.

Cq-Include-Trybots: luci.skia.skia.primary:Test-Mac12-Clang-MacMini9.1-GPU-AppleM1-arm64-Release-All-ANGLE
Change-Id: Ia60cd07f15e3b447b58cfa1198ea26f68f72384b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539036
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2022-05-10 17:13:15 +00:00
skia-autoroll
d886bdc4f6 Roll vulkan-deps from 626b2fd72bde to 100b1c52ea66 (4 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/626b2fd72bde..100b1c52ea66

Also rolling transitive DEPS:
  https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools from ffc8f2d45566 to ad3514b73237
  https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers from 8ba8294c86d0 to 33d4dd987fc8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn;skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE
Bug: None
Tbr: lovisolo@google.com
Change-Id: I26efc982cfbd2e5d94ff343e6ca4e0d33277f1e3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539016
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-10 17:05:08 +00:00
skia-autoroll
0cd16173b0 Roll SwiftShader from 1dd93361b1d9 to e4a6f2d74d3c (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/1dd93361b1d9..e4a6f2d74d3c

2022-05-09 swiftshader.regress@gmail.com Regres: Update test lists @ f5cda783
2022-05-09 swiftshader.regress@gmail.com Regres: Update test lists @ 1dd93361

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: lovisolo@google.com
Change-Id: I9c6d332064ee074acfb01c52be8400ab0aa2d8cc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538978
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-10 16:59:59 +00:00
Herb Derby
14427f740d Enhance debug tracing
Use if constexpr so that tracing code does not bit rot.

Change-Id: Ib85f79b53c6a48bb1b80a51e5539dbdf077802d8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538898
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-05-10 16:59:47 +00:00
Kevin Lubick
167e608bb3 [infra] Remove old python scripts and urllib2 references
I was searching for urllib2 while resolving issues with
https://skia-review.googlesource.com/c/skia/+/538636
when I found several old, apparently unused scripts.

Rather than fix them, let's get rid of them. If they
are still in use, the conversion to urllib.request is
pretty easy.

Change-Id: I27d419601e81c93a3d53e280188a379dfab927c4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538936
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2022-05-10 16:54:39 +00:00
Herb Derby
add4004be5 Extract the CPU code of SkGlyphRunPainter called SkGlyphRunPainterCPU
Simplify the fields used by each, and simplify the CTORs in
the original SkGlyphRunPainter.

TODO: come up with a better no gpu method. Eventually, this
should be pure Sk. There is no need for GPU to make and
serialize a slug only to draw them.

Change-Id: I446fe0c285ae778a14b30e09c8a2cff3cd1a56c1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538896
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Auto-Submit: Herb Derby <herb@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2022-05-10 16:54:33 +00:00
Herb Derby
ee0d15dc9f Move the SubRun buffers to the Canvas using the GlyphRunBuilder
Move the SubRun buffers from the Paint to the Builder that is held
by the Canvas. This allows better sharing of the buffers, and enables
splitting the Painter into CPU and GPU.

Change-Id: I860441732b4042be0534af3d002d63ece02de8c5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538662
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-05-09 17:43:57 +00:00
Ben Wagner
638fcaea9f Keep SkStrike alive for its SkDrawables.
In theory all glyph representations including masks, paths and drawables
should keep a reference to the SkStrike which owns the actual data they
refer to. For paths this is worked around by always creating a copy of
the path (which is inexpensive) which itself simply reference counts the
underlying path data which is not directly owned by the SkStrike. For
masks it is impractical for every mask to hold a reference to the
SkStrike in any event as the pointer alone would often be larger than
the image. For drawables the implementation may be simply a pointer to
the scaler context and a glyph id. In theory each drawable could hold a
reference to the SkStrike, but potentially means a lot of references
when ensuring the SkStrike outlives any drawables it produces would be
more effecient.

This change ensures that the SkStrike is referenced while holding
references to drawables the SkStrike produced.

Bug: chromium:1322902
Change-Id: I6db8ae1bd614167da008caaff089e7d3e15aa9bb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/537980
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2022-05-09 17:23:49 +00:00
Brian Salomon
05d6d80743 SkImage_Raster::onMakeColorTypeAndColorSpace checks for alloc failure
Bug: chromium:1319093
Change-Id: Ie3e602538a9728d80e48f60507f73ca8c7f05f32
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/534498
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2022-05-09 17:00:19 +00:00
Herb Derby
344a7a20c8 Isolate the buffers for generating SubRuns
Isolate the buffers to move them from the Painter, where they are
situated on the Device(CPU) or SurfaceDrawContext(GPU), to the
Canvas. This will allow better sharing of the buffers, and the
splitting out of the CPU and GPU parts of the Painter.

Change-Id: Ie2a99dc7f9e784c4f00012b71ece5ff482687a88
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538660
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2022-05-09 16:14:01 +00:00
Herb Derby
3e7e4e94b4 Manage buffers at the list level only
Now that the painter has moved from a GlyphRun to a GlyphRunList,
handle the buffers at the GlyphRunList level only.

Change-Id: I37416c8b2164bbde207ecab0a77b419775d58e66
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538659
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-05-09 15:43:45 +00:00
James Godfrey-Kittle
cfe50e2e47 Update docs to reference python3
Also updates a script with 2to3 to be python3-compatible.

Change-Id: I45981349664aef4491e7ab20e49889d461f8bf3f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538417
Commit-Queue: James Godfrey-Kittle <jamesgk@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2022-05-09 15:07:22 +00:00
Michael Ludwig
072000b5d4 Do not disable tessellating path renderer over command buffer
Bug: skia:13263
Change-Id: I29e04ccc88a9ff2286c82302740e404aeba1b740
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/534669
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2022-05-09 14:37:12 +00:00
Brian Salomon
f7082cb9fa Rename SkCustomMesh to SkMesh
Also rename associated files, types, functions, etc.

Bug: skia:12720
Change-Id: Ibebb4e7071fa19c5a81cd36d567c96a42cd824f3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538040
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2022-05-09 13:36:21 +00:00