Commit Graph

36650 Commits

Author SHA1 Message Date
Cary Clark
5b1f953942 bookmaker report only changed files
Change bookmaker to omit files written with unchanged
values. Temporary copies of fiddleout.json and catalog.htm
are written, and if the same as the existing copies, are
silently deleted.

Update stdout from examples in SkColor4f_Reference that
have changed to keep up with the latest checkin.

TBR=brianosman@google.com

Docs-Preview: https://skia.org/?cl=150146
Bug: skia:6898
Change-Id: I14e326bdd53baec92853d265edbe160c84583381
Reviewed-on: https://skia-review.googlesource.com/150146
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2018-08-28 19:42:20 +00:00
recipe-roller
7e8449d227 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/0d14d0d85b8f4899b19dfe499c3af68b96a1ee08 "git cl patch" should ignore trailing "/" from remote url. (erikchen@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie3ad50fd05c3a74c8845b8a39d3fef98d9f1e9f3
Reviewed-on: https://skia-review.googlesource.com/150147
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-08-28 19:42:19 +00:00
Herb Derby
d9c93640bb Make the two too-large-glyph comparisons be the same
BUG=chromium:876767

Change-Id: I18184fe4ab50e08450748cc4cce5ac4560fc2251
Reviewed-on: https://skia-review.googlesource.com/150144
Reviewed-by: Khusal Sagar <khushalsagar@chromium.org>
Commit-Queue: Herb Derby <herb@google.com>
2018-08-28 19:12:42 +00:00
Yuqian Li
04ccd72c1a Further improve AA choice
Compared with current master:
    1.26% faster in Seal_of_New_Hampshire.svg_1
    1.90% faster in native_image_to_raster_surface
    2.70% faster in Seal_of_Texas.svg_1
    2.76% faster in WestVirginia-StateSeal.svg_1
    2.80% faster in chart_aa
    3.36% faster in Iowa-StateSeal.svg_1
    3.44% faster in Seal_of_Illinois.svg_1
    4.37% faster in Seal_of_Maryland_%28reverse%29.svg_1
    4.64% faster in Minnesota-StateSeal.svg_1
    5.06% faster in Seal_of_Tennessee.svg_1
   16.76% faster in clip_strategy_path_100

Compared with the Skia without https://skia-review.googlesource.com/c/skia/+/146220
(no significant slowdowns for any SVGs)
    4.69% slower in path_fill_big_rotated_rect_aa_45
    2.50% slower in points
    1.27% faster in native_image_to_raster_surface
    1.39% faster in patch_square_meshlines_0.100000x0.100000
    2.09% faster in path_hairline_big_noAA_line
    2.62% faster in Seal_of_Maryland_%28reverse%29.svg_1
    3.63% faster in rotated_rects_aa_alternating_transparent_and_opaque_darken
    3.93% faster in zeroradroundrect
    4.60% faster in rotated_rects_aa_same_transparent_darken
    4.64% faster in ovals_1
    4.73% faster in rotated_rects_aa_changing_opaque_darken
    4.74% faster in rotated_rects_aa_changing_transparent_darken
    5.01% faster in rotated_rects_aa_same_opaque_darken
    5.07% faster in nested_aaclip_AA
    6.06% faster in ovals_3
    6.25% faster in dash_0_noclip
    7.86% faster in rotated_rects_aa_same_transparent_src
    7.86% faster in rotated_rects_aa_changing_transparent_src
    9.31% faster in rrects_3
    9.35% faster in rotated_rects_aa_alternating_transparent_and_opaque_src
   10.95% faster in rotated_rects_aa_same_transparent_srcover
   10.95% faster in rotated_rects_aa_changing_transparent_srcover
   11.46% faster in rotated_rects_aa_alternating_transparent_and_opaque_srcover
   11.90% faster in rotated_rects_aa_same_opaque_srcover
   11.90% faster in rotated_rects_aa_changing_opaque_srcover
   12.09% faster in rotated_rects_aa_same_opaque_src
   12.13% faster in rotated_rects_aa_changing_opaque_src
   20.89% faster in path_fill_small_triangle

Bug: skia:8272
Change-Id: Ic1434ea71660b0d3a7ddf1f63d098cfe7acfd861
Reviewed-on: https://skia-review.googlesource.com/149337
Auto-Submit: Yuqian Li <liyuqian@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-08-28 18:41:16 +00:00
recipe-roller
3853bafbde Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/bc56d8cfab501c5fc908c995bbd6c1883d334c33 Fix typo in a metrics.py message (tsniatowski@vewd.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic731cdf4fa6a85d0fcff99399dfff2b51398d646
Reviewed-on: https://skia-review.googlesource.com/150143
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-08-28 18:40:35 +00:00
Greg Daniel
900e5c8f62 [infra] Update Win Intel drivers.
No-Try: true
Change-Id: If5314359997b5db7a9628972e464e8673b5e6f14
Reviewed-on: https://skia-review.googlesource.com/149740
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-08-28 18:14:08 +00:00
Brian Osman
7ba1d64f07 Revert "Remove old ICC parser, A2B SkColorSpace, SkGammas, etc..."
This reverts commit 8ae7c90faf.

Reason for revert: Chrome roll

Original change's description:
> Remove old ICC parser, A2B SkColorSpace, SkGammas, etc...
> 
> Docs-Preview: https://skia.org/?cl=148807
> Change-Id: I2d77f6543e390c4948d57242a518af77443f0165
> Reviewed-on: https://skia-review.googlesource.com/148807
> Commit-Queue: Mike Klein <mtklein@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,brianosman@google.com,reed@google.com

Change-Id: I5821591b22e395327ec0cd29ec18569bf7f61859
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/150142
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-08-28 17:52:22 +00:00
Brian Osman
52232438eb Fix alpha type when doing GPU color space conversion of unpremul images
Fixes fringing seen on bottom row of
https://gold.skia.org/detail?test=makecolorspace&digest=eccdd2a952d9503734b35b3a725a18b2

Change-Id: I4d05a2edab99dc989f4088d38a13827384f0444a
Reviewed-on: https://skia-review.googlesource.com/150121
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-08-28 17:19:42 +00:00
Mike Reed
7c8d2e940e don't support virtual onDrawTextOnPath
Bug: skia:7554
Change-Id: Ia8c663918fea7bc91f3474d1c94e7a1c5536a1d4
Reviewed-on: https://skia-review.googlesource.com/149805
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
2018-08-28 16:54:18 +00:00
Robert Phillips
de47928988 Add a flag to disable mask-filtered mask caching for Chrome
This close to branching, I'm inclined to disable this for M70.

Here is the Chrome-side CL that sets the flag:

https://chromium-review.googlesource.com/c/chromium/src/+/1193968 (
Disable mask-filtered mask caching in Skia)

Bug: 878195
Change-Id: Ifaf92fac80b75431badb52e0e5b09ccc57c08d8e
Reviewed-on: https://skia-review.googlesource.com/150080
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-08-28 16:30:17 +00:00
Cary Clark
153e76d4bf deprecate draw text on path in docs
Remove documentation, see also references, and examples
that rely on SkCanvas::drawTextOnPath(HV).

Move example that uses SkDrawTextOnPath into illustrations.
TBR=reed@google.com

Docs-Preview: https://skia.org/?cl=150020
Bug: skia:6898
Change-Id: I1d92f258b75a8a10a6aa89ebf9380871ba7ecac5
Reviewed-on: https://skia-review.googlesource.com/150020
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2018-08-28 16:22:53 +00:00
Stan Iliev
c01b5c7459 Add support for hardware buffers with protected content
Use EGL_EXT_protected_content extension if present to render
AHardwareBuffer with AHARDWAREBUFFER_USAGE_PROTECTED_CONTENT.

Bug: skia:
Change-Id: I1a5fa4cdc8f432b89ae9ef889175b50a25b846e0
Reviewed-on: https://skia-review.googlesource.com/149803
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Stan Iliev <stani@google.com>
2018-08-28 15:51:56 +00:00
Cary Clark
1cb97a2f32 fix empty region iter rect
Region iterators return bounds but do not initialize
the result if Iterator has no region or region is
empty.

Add general tests for empty region iterators.

R=reed@google.com,halcanary@google.com

Docs-Preview: https://skia.org/?cl=149980
Bug: skia:8186
Change-Id: If4367d4c0eef7fc9c7bfd7d1436143e155b78309
Reviewed-on: https://skia-review.googlesource.com/149980
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Hal Canary <halcanary@google.com>
2018-08-28 15:21:25 +00:00
Kevin Lubick
82999c037e Add docker-based infrastructure for Gold/lottie-web integration
This adds 2 docker containers (based on the ones used for PathKit
added in https://skia-review.googlesource.com/c/skia/+/147042)
which bundle Chrome and puppeteer to allow the lottiecap.js
to be run anywhere.

This adds a recipe (test_lottie_web.py) to drive the docker
container and do a little bit of set-up (and a few docs/bug
fixes discovered in the test_pathkit.py that it was based on).

Additionally, this modifies lottiecap.js to support POSTing
output to a running go server (again, the same as PathKit)
which has the image data hashed and the metadata added to
a large JSON output.

This re-works driver.html to avoid re-loading the JSON object
25 times. The performance boost is important because, right now,
the lottie files are processed individually.

In a future CL, I want to address the two TODOs in
lottie-web-aggregator.go

Bug: skia:8108
Change-Id: I100c9ce23dcc5033a27287211cbf0db898960da9
Reviewed-on: https://skia-review.googlesource.com/149282
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-08-28 15:16:22 +00:00
Brian Salomon
5b49d7883e Make missing resource message print the full expected path
Change-Id: I37ebbc57d1fe80e419e9d7978fd710c79da8d3fe
Reviewed-on: https://skia-review.googlesource.com/149983
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Derek Sollenberger <djsollen@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Derek Sollenberger <djsollen@google.com>
2018-08-28 14:45:22 +00:00
Brian Osman
da01be3ede Re-enable 6653 test on IntelVulkan, and label failures better
- This bot didn't start failing the non-ERA version that was added
  yesterday, so I suspect it's going to pass all versions.
- Also, the CCPR Pixel bots are continuing to fail, but it's not clear
  if the non-ERA version is passing, so label the failures to find out.

Bug: skia:
Change-Id: Ib5fcb3cf03065453fe31c2a4ac8a9f2fd5bdeaf8
Reviewed-on: https://skia-review.googlesource.com/149982
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-08-28 14:39:57 +00:00
Robert Phillips
d20d261a00 More liberally fold the path matrix into the CTM in GrTextBlob::flush
In this case, even if the path matrix was only a translate, we were losing the ability to create a mask-filter key (because we were transforming the path)

Bug: skia:
Change-Id: I953d8d4e9bbcda9cc0f91cc367c028fb568b2e00
Reviewed-on: https://skia-review.googlesource.com/149981
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-08-28 14:35:57 +00:00
Brian Osman
8ae7c90faf Remove old ICC parser, A2B SkColorSpace, SkGammas, etc...
Docs-Preview: https://skia.org/?cl=148807
Change-Id: I2d77f6543e390c4948d57242a518af77443f0165
Reviewed-on: https://skia-review.googlesource.com/148807
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-08-28 14:25:35 +00:00
Brian Osman
6b622963a0 Reland "Stop conflating F16 with linear gamma"
This reverts commit 5f7b5e3624.

Reason for revert: Codec CL has re-landed.

Original change's description:
> Revert "Stop conflating F16 with linear gamma"
> 
> This reverts commit d1589c7213.
> 
> Reason for revert: Depends on skcms CL that's been reverted.
> 
> Original change's description:
> > Stop conflating F16 with linear gamma
> > 
> > Note to self: I debugged this, realized that the codecs
> > need to handle A2B -> XYZ, then realized that I just need
> > to wait for https://skia-review.googlesource.com/c/skia/+/136062
> > 
> > Bug: skia:
> > Change-Id: I594c22076feb3700b8a40c471a541fef5ff4e13e
> > Reviewed-on: https://skia-review.googlesource.com/137587
> > Commit-Queue: Brian Osman <brianosman@google.com>
> > Reviewed-by: Mike Klein <mtklein@google.com>
> 
> TBR=mtklein@google.com,brianosman@google.com
> 
> Change-Id: I6dca583697c8efd2563d30cb7ab9ef505b6903ae
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/148860
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>

TBR=mtklein@google.com,brianosman@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:
Change-Id: Iee66531049843758e7ed4130b99d8df6a553d805
Reviewed-on: https://skia-review.googlesource.com/149700
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-08-28 14:23:27 +00:00
angle-skia-autoroll
ffe1c1cad0 Roll third_party/externals/angle2 33dab025ada1..47f6dd0d4a21 (4 commits)
33dab025ad..47f6dd0d4a


git log 33dab025ada1..47f6dd0d4a21 --date=short --no-merges --format='%ad %ae %s'
2018-08-28 jiajia.qin@intel.com Implement robust initialization for image texture
2018-08-28 jmadill@chromium.org Suppress TransformFeedbackNegativeAPI test on Mac AMD.
2018-08-28 xinghua.cao@intel.com ES31: support compute shader sampling on D3D backend
2018-08-28 jmadill@chromium.org Add Windows MSVC x64 builders to CQ.


Created with:
  gclient setdep -r third_party/externals/angle2@47f6dd0d4a21

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stephana@google.com

Change-Id: I6be7e9148274153cc2803a9aa6a51c0dded70182
Reviewed-on: https://skia-review.googlesource.com/149920
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-08-28 10:00:50 +00:00
recipe-roller
e24617906e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/f57841b78bedc98c7758d2dbe39a5021437abb8a git cl patch: cleanup tests. (tandrii@chromium.org)
  https://crrev.com/5cc2afd9b8fae7e6f2d0f0c07abf14a2a2916ee7 gclient_eval: Handle non-string variables. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I76e30824c0d9f4ace038751dbac9179d67e09e0a
Reviewed-on: https://skia-review.googlesource.com/149881
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-08-28 01:31:48 +00:00
angle-skia-autoroll
205369e654 Roll third_party/externals/angle2 89664843c656..33dab025ada1 (4 commits)
89664843c6..33dab025ad


git log 89664843c656..33dab025ada1 --date=short --no-merges --format='%ad %ae %s'
2018-08-27 jmadill@chromium.org Add test for transform feedback state change validation.
2018-08-27 jmadill@chromium.org Inline more buffer binding calls.
2018-08-27 bryan.bernhart@intel.com Add webgl checks in GetActiveUniformsiv.
2018-08-27 syoussefi@google.com Fix dEQP_GLES3.functional.negative_api.shader.program_binary


Created with:
  gclient setdep -r third_party/externals/angle2@33dab025ada1

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stephana@google.com

Change-Id: Id2486e3282d35eaa52a24113703b7aa31a5178aa
Reviewed-on: https://skia-review.googlesource.com/149900
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-08-28 01:01:50 +00:00
recipe-roller
ea0f7f2cd4 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/e263316d409e3aef2ecb0681dc5443054d8753f3 git cl: use project~number on Gerrit for GetChangeCommit. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I183ebc6367d117a2f3a99354d5f2807c2dfc1edd
Reviewed-on: https://skia-review.googlesource.com/149880
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-08-28 00:24:45 +00:00
Herb Derby
d4255ed037 Handle the glyph too big path fallback
BUG=chromium:876767

Change-Id: I06ea46c14e602b966600abaed3e6c059e40539f8
Reviewed-on: https://skia-review.googlesource.com/149821
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
Reviewed-by: Khusal Sagar <khushalsagar@chromium.org>
2018-08-27 22:34:42 +00:00
Greg Daniel
f125111ca7 Have GrAHardwareBufferImageGenerator use lazy proxies.
Bug: skia:
Change-Id: I0c98157ec36f056c3c1b217f3b6561e371b4f057
Reviewed-on: https://skia-review.googlesource.com/148987
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Stan Iliev <stani@google.com>
2018-08-27 21:19:16 +00:00
Brian Osman
21fc5ce7f8 Reland "Add support for unpremul image sources in the GPU backend"
This reverts commit cbf64e3634.

Reason for revert: Ancestral CLs have re-landed.

Original change's description:
> Revert "Add support for unpremul image sources in the GPU backend"
> 
> This reverts commit f06240de2c.
> 
> Reason for revert: I think this requires the skcms codec change to re-land,
> 
> Original change's description:
> > Add support for unpremul image sources in the GPU backend
> > 
> > Change-Id: Ib940fa0d658fff0b2dd923abfcc5ca4a49b2b38b
> > Reviewed-on: https://skia-review.googlesource.com/148397
> > Commit-Queue: Brian Osman <brianosman@google.com>
> > Reviewed-by: Mike Klein <mtklein@google.com>
> 
> TBR=mtklein@google.com,bsalomon@google.com,brianosman@google.com
> 
> Change-Id: Ib9358cf858c3c0887322503a4b021e08a0ac4cd5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/148861
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>

TBR=mtklein@google.com,bsalomon@google.com,brianosman@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I20d8d17f5cc6ed1a359c0f7af1c96bf5304f6885
Reviewed-on: https://skia-review.googlesource.com/149804
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-08-27 21:00:55 +00:00
Cary Clark
da6289c5f3 mark tests flaky for pathkit
retain flaky state to avoid manual edits

R=kjlubick@google.com

Bug: skia:
Change-Id: I2f30a90aed46c52a0b30af1ccb7d6235b6db6945
Reviewed-on: https://skia-review.googlesource.com/149800
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-08-27 20:35:15 +00:00
Greg Daniel
a9979d1583 Add support for vulkan extensions needed for AHardwareBuffers.
Bug: skia:
Change-Id: I68198c9f2ea1b859658d2bc75abf33f535960781
Reviewed-on: https://skia-review.googlesource.com/149284
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-08-27 20:19:58 +00:00
Mike Klein
0b0e0b8014 centralize default src/dst colorspace policy
We've long interpreted null source colorspaces as sRGB.

We've also been treating null destination colorspaces as legacy,
non-color-managed drawing.  Assigning dst=src in this situation
is the best way to express that.

I have reverted the changes to SkImageShader and SkBlitter_Sprite,
where we had very slightly different logic.

Change-Id: I90e5ab424aea534d83cfbecd282b6cf48b56d056
Reviewed-on: https://skia-review.googlesource.com/148996
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-08-27 20:18:18 +00:00
Florin Malita
a225a6b631 [skottie] Fix precomp time remapping vs time start/stretch interaction
In the presence of time remapping, time start/stretch values appear to
be ignored.

TBR=
Change-Id: I6a4dcc107f2d0fc6361f91ba4f4643e33da37d93
Reviewed-on: https://skia-review.googlesource.com/149701
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-08-27 20:01:59 +00:00
Mike Reed
c349f18ee8 use textonpath util for canvas::drawTextOnPath
- slight change in pixels
- will allow us to remove lots of virtuals

Bug: skia:7554
Change-Id: I8f95c07bf67760824d9d9bf59c28f11835971d4b
Reviewed-on: https://skia-review.googlesource.com/149683
Commit-Queue: Mike Reed <reed@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Auto-Submit: Mike Reed <reed@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-08-27 19:37:24 +00:00
Greg Daniel
9af948d468 Do some refactoring of GrAHardwareBufferImageGenerator.
This is just some pre-work to split out from the change to make the
GrAHardwareBufferImageGenerator use lazy proxies.

Bug: skia:
Change-Id: I655d0c20070cff391d2bb9487b7c73253493cf71
Reviewed-on: https://skia-review.googlesource.com/148060
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-08-27 19:31:26 +00:00
Kevin Lubick
1fd58fd34f [PathKit] Re-create test expectations
See https://skia-review.googlesource.com/c/skia/+/149620

Bug: skia:
Change-Id: I2a8c88e813b5084f667d08317145866b57bbd7ab
Reviewed-on: https://skia-review.googlesource.com/149681
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-08-27 19:13:11 +00:00
Brian Osman
22b21ea25b Stop blacklisting some critical unit tests on Metal
Bug: skia:6653
Change-Id: I034c8183c5550914d155acf842a7a73c6f1b5d15
Reviewed-on: https://skia-review.googlesource.com/149680
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-08-27 18:36:58 +00:00
Mike Reed
0fdc53f9ff textonpath util
Bug: skia:7554
Change-Id: Ifff3030f9d7be24146b5230bbf0e47f73000adfd
Reviewed-on: https://skia-review.googlesource.com/141460
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2018-08-27 18:01:21 +00:00
Cary Clark
ea2a6323bc fix pathops unsortable angles
Pathops determines which edges are kept and discarded
by sorting intersections counterclockwise. An edge
may be unsortable if it is too close to a neighbor to
clearly be on its left or right.

If a pair of lines is unsortable, they are probably
nearly coincident, but just far enough apart to escape
the coincident test.

The current code correctly marks the lines as unsortable,
but returned a guess at the sorting order anyway. Instead,
preserve the unsorted-ness (unsorted mess?) and let
the decision of what to keep defer til later.

This triggered a couple of asserts that needed rewriting
or disabling, but fixes the bug in question and does not
regress the extended tests in debug or release.

Also, fix a debugging routine that bit-rotted.

TBR=reed@google.com

Bug: skia:8228
Change-Id: Ifab90c65837ed9656bb572c385fcc5c916348778
Reviewed-on: https://skia-review.googlesource.com/149620
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2018-08-27 18:00:06 +00:00
Brian Osman
63051057b8 Remove MSAA from Metal caps
Change-Id: I54f992581b8a0c4e8470221e4753c92ae8444204
Reviewed-on: https://skia-review.googlesource.com/149622
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-08-27 17:55:51 +00:00
Brian Salomon
fdec6f469a Disable GrTextureOp Chaining
Two chrome perf regressions and bad image-surface GM on S7/MaliT880

Bug: chromium:877610
Bug: chromium:877598
Change-Id: Ibca66a936739ad0c452a0da155439c5ed8f1da39
Reviewed-on: https://skia-review.googlesource.com/149621
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-08-27 17:55:01 +00:00
Brian Osman
a3adbf28ee Don't assert trying to make an MSAA surface with Metal, just fail
Change-Id: I66b18d753f0e78cc1d647328322d12c037fa9ed5
Reviewed-on: https://skia-review.googlesource.com/149484
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-08-27 16:46:57 +00:00
Leon Scroggins III
36f7e3298e Reland "Switch SkCodec to use skcms plus fixes""
This reverts commit 83988edfd3.

The CTS failure was actually due to another CL.

TBR=brianosman@google.com
TBR=djsollen@google.com

Bug: skia:6839
Bug: skia:8052
Bug: skia:8278
Change-Id: Id9f152ec2c66467d90f49df223cb9b7c168ac2ac
Reviewed-on: https://skia-review.googlesource.com/149483
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-08-27 16:16:14 +00:00
Hal Canary
1db86c7cf5 SkPDF/Type1: fix BUG:skia:8285
Change-Id: I14ad6b110865e116c5c401a1e4cd873ebc048dd3
Reviewed-on: https://skia-review.googlesource.com/149480
Auto-Submit: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-08-27 16:12:58 +00:00
Brian Salomon
2424ec46e9 Make GrGLInterface great for Win32 x86 again
Bug: skia:8262
Change-Id: I607644198d5dc7992e2b89eb34651eb1dc88c6ba
Reviewed-on: https://skia-review.googlesource.com/149225
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-08-27 16:09:48 +00:00
angle-skia-autoroll
b23c3172ee Roll third_party/externals/angle2 8707af516c46..89664843c656 (1 commits)
8707af516c..89664843c6


git log 8707af516c46..89664843c656 --date=short --no-merges --format='%ad %ae %s'
2018-08-27 oetuaho@nvidia.com Add glTexStorage3DMultisampleANGLE entry point


Created with:
  gclient setdep -r third_party/externals/angle2@89664843c656

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stephana@google.com

Change-Id: I6cb25771f258ca92f632db83df07b24eab65ae02
Reviewed-on: https://skia-review.googlesource.com/149560
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-08-27 15:59:30 +00:00
Mike Reed
49f8da0209 use nothingToDraw more often
Bug: skia:
Change-Id: Ifafd8d90649f5aeb020335f46496a828dffac98e
Reviewed-on: https://skia-review.googlesource.com/149481
Auto-Submit: Mike Reed <reed@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-08-27 15:31:24 +00:00
Kevin Lubick
3fee9235a4 Add a renderer key to lottie gold digests
This will help us distinguish between "rendered by skottie",
"rendered by lottie-web", etc.

Bug: skia:8108
Change-Id: I48b489adf8f8b7f950df397e5e94c1103dc4d306
Reviewed-on: https://skia-review.googlesource.com/149237
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-08-27 15:15:04 +00:00
Leon Scroggins III
fdd5b69fef Ignore PLTE chunks in non-palette PNGs
Bug: oss-fuzz:10020
Change-Id: I2dd0dd07983fcc851ea6ec0980a5a30dbe312b62
Reviewed-on: https://skia-review.googlesource.com/149261
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-08-27 15:05:47 +00:00
Robert Phillips
793324cf4d Always render GPU masks with AA rendering
This makes Ganesh match the raster backend's behavior.

It, unfortunately, will alter the following GMs:

blurrects
blur2rects
bleed_alpha_*
bleed_*

Change-Id: Id8cfbe8776e8e8a11fce9d09863b4244a72fb1ce
Reviewed-on: https://skia-review.googlesource.com/148994
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-08-27 15:04:27 +00:00
Brian Osman
dd04bec39c Add a version of the skbug6653 unit test that disables explicit resource allocation
We now suspect this bug is in Ganesh, so we're looking to see if this is
related.

Bug: skia:6653
Change-Id: Ic1c61091437903d1ffe0eba4a9f90dae01cedef7
Reviewed-on: https://skia-review.googlesource.com/149440
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-08-27 14:51:23 +00:00
Ethan Nicholas
cd700e9ab7 Revert "Revert "added support for sk_Dimensions to SkSL""
This reverts commit e6ab998bc2.

Bug: skia:
Change-Id: I19451f924d514dadac9d2c326bcc8404a1b501e9
Reviewed-on: https://skia-review.googlesource.com/149239
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2018-08-27 14:42:08 +00:00
Florin Malita
9402c7dc37 [skottie] Add support for keyframed text nodes
-- introduce a new animatable value (TextValue)

 -- introduce a new adapter (TextAdapter) to translate Lottie text props to SG text props

 -- use existing animated property-bind machinery and the new constructs when parsing text layers

Change-Id: Ibbfb69daf5b0a3c9a5ce8d1ccdeedca5b5d0fa6f
Reviewed-on: https://skia-review.googlesource.com/149266
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-08-27 14:37:47 +00:00