Ravi Mistry
ed8bc196bd
Add LICENSE to third_party/vulcan
...
NoTry: true
Bug: skia:8217
Change-Id: I74212c3868b57cc002389277213d16ceb7604d60
Reviewed-on: https://skia-review.googlesource.com/144906
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-08-01 22:48:44 +00:00
Greg Daniel
da16cce7d9
Use our own checked in Vulkan header to build skia source code.
...
Core Skia will always include our own SkiaVulkan.h which basically just
includes vulkan_core.h. All platform vulkan specific stuff must be
include by the client in their own vulkan.h file. Our public interface
is set up that we only use vulkan objects that will be present in all
versions of vulkan headers that the client could include.
Bug: skia:
Change-Id: I6673fd91498eabcc923d65d20f2b5e0a89b4ccf6
Reviewed-on: https://skia-review.googlesource.com/142985
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-08-01 16:52:20 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
d27620d6a2
Roll skia/third_party/skcms dc97dc542b6d..95d1987a561d (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/dc97dc542b6d..95d1987a561d
2018-08-01 mtklein@google.com pay some attention to apply_tf()
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=scroggo@google.com
Change-Id: I4ac39555011685f177143758bdb4de8060221a1d
Reviewed-on: https://skia-review.googlesource.com/144764
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-08-01 14:30:04 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
1935aa3d27
Roll skia/third_party/skcms f80f027f8ac9..dc97dc542b6d (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/f80f027f8ac9..dc97dc542b6d
2018-07-31 mtklein@google.com turn on -fsanitize=integer on portable bot
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=scroggo@google.com
Change-Id: Ided624d7a976be030f278d86d1ef91c57b1d4ad0
Reviewed-on: https://skia-review.googlesource.com/144623
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-31 19:30:48 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
990ec990a6
Roll skia/third_party/skcms 2925dc93401c..f80f027f8ac9 (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/2925dc93401c..f80f027f8ac9
2018-07-31 mtklein@google.com add portable *SAN bot
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=scroggo@google.com
Change-Id: I431d3d2be5ed72232779b954e3c18df49ea2af70
Reviewed-on: https://skia-review.googlesource.com/144590
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-31 17:36:55 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
ce3c7bbd0d
Roll skia/third_party/skcms c663954a7567..2925dc93401c (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/c663954a7567..2925dc93401c
2018-07-31 mtklein@google.com more C++
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=scroggo@google.com
Change-Id: I7d4c2c447aa68415d1e1bd65b14902521342d8aa
Reviewed-on: https://skia-review.googlesource.com/144483
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-31 15:15:43 +00:00
Nigel Tao
a78b6dcb82
Move setAlphaAndRequiredFrame to src/codec
...
The corresponding declaration is already in src/codec/SkFrameHolder.h
That code is not solely used by third_party/gif, and in the future, we
may have another GIF implementation.
Bug: skia:
Change-Id: If04cfd4a5b1106f380c89e11c34a8d854ce2b05a
Reviewed-on: https://skia-review.googlesource.com/144240
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-07-30 18:20:17 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
53becd1fc2
Roll skia/third_party/skcms 779b8c7799f3..c663954a7567 (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/779b8c7799f3..c663954a7567
2018-07-30 mtklein@google.com more C++ cleanup
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=scroggo@google.com
Change-Id: Iaed540ec2429ff1a25537ac222354e6a09a4c200
Reviewed-on: https://skia-review.googlesource.com/144334
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-30 15:37:45 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
069b2cf19f
Roll skia/third_party/skcms 6b7ef53d3298..779b8c7799f3 (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/6b7ef53d3298..779b8c7799f3
2018-07-30 mtklein@google.com remove TSAN config
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=scroggo@google.com
Change-Id: I06da31f9a1c7960476c40cfe075248ce0947a2dc
Reviewed-on: https://skia-review.googlesource.com/144331
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-30 14:59:25 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
160e4dcc4e
Roll skia/third_party/skcms 51fba282d9a0..6b7ef53d3298 (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/51fba282d9a0..6b7ef53d3298
2018-07-30 mtklein@google.com add unit test for clamp-before-premul
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=scroggo@google.com
Change-Id: I072c40574deb81b6e1bde928e232eecd7e2b4925
Reviewed-on: https://skia-review.googlesource.com/144320
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-30 14:04:55 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
4241bab68a
Roll skia/third_party/skcms 23e7777f421d..51fba282d9a0 (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/23e7777f421d..51fba282d9a0
2018-07-30 mtklein@google.com start cleaning up src/Transform_inl.h with C++
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=scroggo@google.com
Change-Id: I3005cfe39088dae5564a8ddd9fffd6eefd122065
Reviewed-on: https://skia-review.googlesource.com/144296
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-30 13:35:45 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
60f1d83f65
Roll skia/third_party/skcms 4642d9fe69e1..23e7777f421d (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/4642d9fe69e1..23e7777f421d
2018-07-27 mtklein@google.com clamp before premul
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=benjaminwagner@google.com
Change-Id: Ia9898102aae04ad07057e1a5af1de8ad108d9631
Reviewed-on: https://skia-review.googlesource.com/143735
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-27 15:06:27 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
42c1c03334
Roll skia/third_party/skcms dad22fe0e646..4642d9fe69e1 (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/dad22fe0e646..4642d9fe69e1
2018-07-25 benjaminwagner@google.com [infra] Adjust job priorities. (skcms)
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=benjaminwagner@google.com
Change-Id: I80d5a79fdf660f07afa8966cc4c0f231dffe0b6b
Reviewed-on: https://skia-review.googlesource.com/143280
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-25 11:38:16 +00:00
Greg Daniel
ab98509717
Add new vulkan headers to third_party/vulkan.
...
Currently these headers are not used, but this is just prep for a future
change that will make skia build using these headers. The presubmit complains
about the formating of these headers so I want to land them separate from the
skia code that goes with them.
Bug: skia:
Change-Id: I97190f4af462a6b5391895ca941b3261a41615b5
Reviewed-on: https://skia-review.googlesource.com/143104
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-07-24 14:25:42 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
e7e3bb4d20
Roll skia/third_party/skcms ae6a7acc22e5..dad22fe0e646 (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/ae6a7acc22e5..dad22fe0e646
2018-07-16 borenet@google.com Remove sign_cla entry from cq.cfg
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=bungeman@google.com
Change-Id: Iead8a4318772e907629258781fc0e712cc3678fd
Reviewed-on: https://skia-review.googlesource.com/141501
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-16 14:43:06 +00:00
Hal Canary
1419534a00
Whitespace cleanup again
...
Change-Id: I38ab9ff141eb088084a4c0e664f327ceb89fcf70
Reviewed-on: https://skia-review.googlesource.com/140784
Commit-Queue: Hal Canary <halcanary@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-07-16 13:59:36 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
76cf60c06b
Roll skia/third_party/skcms 8342d776db5a..ae6a7acc22e5 (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/8342d776db5a..ae6a7acc22e5
2018-07-10 mtklein@chromium.org build as C++ the normal way
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=robertphillips@google.com
Change-Id: I0d1ad63556eaec6cb0ed73d668bf6a7584f5ea70
Reviewed-on: https://skia-review.googlesource.com/140166
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-10 15:28:24 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
c940f5d5ff
Roll skia/third_party/skcms f447e42de725..8342d776db5a (2 commits)
...
https://skia.googlesource.com/skcms.git/+log/f447e42de725..8342d776db5a
2018-07-03 mtklein@chromium.org avoid C-only flexible array members
2018-07-03 mtklein@chromium.org convert skcms to c++
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=ethannicholas@google.com
Change-Id: Iee3a21f2f7a4c939e8f5dbd773528994d4858113
Reviewed-on: https://skia-review.googlesource.com/139267
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-03 21:24:17 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
8cefce1c80
Roll skia/third_party/skcms 678e47d97bc5..f447e42de725 (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/678e47d97bc5..f447e42de725
2018-07-03 mtklein@chromium.org centralize and clean up disabled warnings
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=ethannicholas@google.com
Change-Id: Ic4b606d3193354d2cc8c8a7efca3fe8148b58925
Reviewed-on: https://skia-review.googlesource.com/139241
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-03 18:46:25 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
630741c7c0
Roll skia/third_party/skcms 9d19e2abf000..678e47d97bc5 (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/9d19e2abf000..678e47d97bc5
2018-07-03 mtklein@chromium.org rm CMakeLists.txt
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=ethannicholas@google.com
Change-Id: Iac6ee549dd200db4037b38e7fae9b3df9d29ae07
Reviewed-on: https://skia-review.googlesource.com/139144
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-03 15:16:54 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
aae58023a8
Roll skia/third_party/skcms 0977edc92270..9d19e2abf000 (4 commits)
...
https://skia.googlesource.com/skcms.git/+log/0977edc92270..9d19e2abf000
2018-07-02 mtklein@chromium.org stop using designated initializers
2018-07-02 mtklein@chromium.org explicitly cast 16-bit constants to uint16_t
2018-07-02 mtklein@chromium.org fix typo in c++ header check
2018-07-02 mtklein@chromium.org make skcms buildable as c++
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=ethannicholas@google.com
Change-Id: I5c9b29c5d8fcc3d8e3bf64ecd1ab24cac86b5d01
Reviewed-on: https://skia-review.googlesource.com/138954
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-02 20:52:52 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
2f046f1f52
Roll skia/third_party/skcms 99b01c076f47..0977edc92270 (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/99b01c076f47..0977edc92270
2018-07-02 mtklein@chromium.org tidy up skcms_internal.h
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=ethannicholas@google.com
Change-Id: I18cd1addc22aab4d1e6db2498153992b382e0635
Reviewed-on: https://skia-review.googlesource.com/138953
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-02 20:13:22 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
5155d38fdc
Roll skia/third_party/skcms 14ea609fa6ca..99b01c076f47 (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/14ea609fa6ca..99b01c076f47
2018-07-02 mtklein@chromium.org move skcms impl into skcms.c
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=ethannicholas@google.com
Change-Id: I950f7b604eef056641fec3e6691d8c8a928d2d37
Reviewed-on: https://skia-review.googlesource.com/138950
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-02 19:38:22 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
f576839c64
Roll skia/third_party/skcms 4268c0b12bf2..14ea609fa6ca (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/4268c0b12bf2..14ea609fa6ca
2018-07-02 mtklein@chromium.org centralize internal headers into skcms_internal.h
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=ethannicholas@google.com
Change-Id: I8324a33256f7c1c4b766027f9823b6401ba09a78
Reviewed-on: https://skia-review.googlesource.com/138947
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-02 19:06:00 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
5d27c51276
Roll skia/third_party/skcms 97bcdb1d73a1..4268c0b12bf2 (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/97bcdb1d73a1..4268c0b12bf2
2018-06-27 mtklein@chromium.org add a warning about non-D50 profiles
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=jcgregorio@google.com
Change-Id: I6b255af186883cf76df9884ce274abcadf20553c
Reviewed-on: https://skia-review.googlesource.com/137941
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-06-27 15:17:15 +00:00
Leon Scroggins III
665949a3ec
Update libjpeg-turbo to pre-2.0.0 (from 1.5.3)
...
jpeg_skip_scanlines was incorrectly incrementing an internal counter,
resulting in an infinite loop. (This only occurs for certain types of
progressive images, using certain sample sizes.)
The fix is at 26f109290dhttps://skia-review.googlesource.com/129459
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-06-26 15:22:12 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
09f92b94f5
Roll skia/third_party/skcms 78ef7c5c81fb..97bcdb1d73a1 (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/78ef7c5c81fb..97bcdb1d73a1
2018-06-21 brianosman@google.com Add support for Alpha8, Gray8, and 4444 pixel formats
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com
Change-Id: I0f7ec97e88bd17fbee65c825c60da2044dfece8c
Reviewed-on: https://skia-review.googlesource.com/136665
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-06-21 19:18:57 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
94ed719bf8
Roll skia/third_party/skcms eb7de4255855..78ef7c5c81fb (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/eb7de4255855..78ef7c5c81fb
2018-06-21 brianosman@google.com Treat null profiles as sRGB
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com
Change-Id: I02d32a027781e2f4b05e0ca93277d374e53550ce
Reviewed-on: https://skia-review.googlesource.com/136544
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-06-21 17:04:37 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
3e75214398
Roll skia/third_party/skcms 1be9889efd32..eb7de4255855 (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/1be9889efd32..eb7de4255855
2018-06-19 mtklein@chromium.org Move -ldl after object files that may need it.
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com
Change-Id: I071dde078205570cb19eeb567ac707bff0fb9be1
Reviewed-on: https://skia-review.googlesource.com/135926
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-06-19 21:55:18 +00:00
Brian Osman
c069a57301
added NIMA sample to showcase animations
...
improved third_party template to include headers as system headers for non-Windows machines
Bug: skia:
Change-Id: Id2fa74fc31b49f9b07cc83e7f60477c7ab4f8d83
Reviewed-on: https://skia-review.googlesource.com/135450
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-06-19 20:30:28 +00:00
Greg Daniel
37eef455fb
Add include/config to vulkan memory allocator build.
...
Bug: skia:
Change-Id: Ic5e35c6d89203fcad734349afc421e84388997fb
Reviewed-on: https://skia-review.googlesource.com/135322
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-06-15 20:47:45 +00:00
Greg Daniel
e287a94d24
Add to include path for vulkan memory allocator so SkTypes can be found.
...
Bug: skia:
Change-Id: Ie55dbd478f2d31bf2a89b5ea18ed0415f549c542
Reviewed-on: https://skia-review.googlesource.com/135261
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-06-15 17:51:05 +00:00
Greg Daniel
0e4a12b525
Don't explicitly include vulkan.h in the vulkan memory allocator.
...
Bug: skia:
Change-Id: I57dc374822fd22e25ef22d03345bdd2e159c7edd
Reviewed-on: https://skia-review.googlesource.com/135048
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-06-15 13:17:14 +00:00
Florin Malita
7d42c44cdd
[skottie] Switch to SkJSON
...
Convert to SkJSON APIs and remove RapidJSON dependency.
TBR=
Change-Id: I5b4fd78821a443326e3a5b370748d840b80ef279
Reviewed-on: https://skia-review.googlesource.com/134612
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-06-14 21:21:14 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
1bd4b31d1d
Roll skia/third_party/skcms 0fdd840..1be9889 (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/0fdd840..1be9889
2018-06-07 mtklein@chromium.org roll to latest win_toolchain
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=halcanary@google.com
Change-Id: Ifb0b110530d749a9ede83ea2a3c2f857d5c9bb58
Reviewed-on: https://skia-review.googlesource.com/132960
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-06-07 19:59:31 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
5e6853ddfd
Roll skia/third_party/skcms 2e43fec..0fdd840 (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/2e43fec..0fdd840
2018-06-05 mtklein@chromium.org force wasm into N=1 transform code paths
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=halcanary@google.com
Change-Id: Ib8763e877f4d9b8d2cd044b2c521519d9b4ee68c
Reviewed-on: https://skia-review.googlesource.com/132203
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-06-05 18:17:59 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
bd04be76ad
Roll skia/third_party/skcms a8a5c9e..2e43fec (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/a8a5c9e..2e43fec
2018-06-05 mtklein@chromium.org clean up option for old powf()
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=halcanary@google.com
Change-Id: Ic1556a1a02d339f76f53d446bd2311c6ebd775a6
Reviewed-on: https://skia-review.googlesource.com/132200
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-06-05 17:16:59 +00:00
Ben Wagner
22a8aef9d9
Roll FreeType to pick up color stuff.
...
Change-Id: Ide7d414dc0f5e112b213390dc9f62e097c6a7ef9
Reviewed-on: https://skia-review.googlesource.com/130848
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2018-05-31 15:10:13 +00:00
Greg Daniel
e45752e58f
Add LICENSE file to vulkanmemoryallocaotr
...
Bug: skia:8027
Change-Id: If5230d4c85b5501d0ba67a14a5fc93b51fb3f7e3
Reviewed-on: https://skia-review.googlesource.com/131105
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-05-31 13:23:52 +00:00
Greg Daniel
18dbfd05e4
Reland "Create API for GrVkMemoryAllocator and impliment use of AMD VulkanMemoryAllocator on this API."
...
This reverts commit 98bddf930e26c0e4c1f5https://skia-review.googlesource.com/129980
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
> > Reviewed-by: Jim Van Verth <jvanverth@google.com>
>
>
>
> Change-Id: I6c74978f778987c422e6162e7dd85ea9c6baa0e4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/130182
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>
Bug: skia:
Change-Id: I422ffb3562da567f2e85c806286ad1a17c3862cd
Reviewed-on: https://skia-review.googlesource.com/130183
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-05-30 13:27:38 +00:00
Herb Derby
264182c3f7
Make SkShaper a module
...
Change-Id: I3709e49ba865f14260660cc07a762b9ac837cb3c
Reviewed-on: https://skia-review.googlesource.com/130602
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-05-30 04:04:07 +00:00
Florin Malita
3d856bdeee
[skottie] Relocate to modules/skottie
...
TBR=
Change-Id: I218d251ca56578a3a7fd4fb86cba9abdc10fb3bd
Reviewed-on: https://skia-review.googlesource.com/130322
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-05-27 02:21:33 +00:00
Greg Daniel
98bddf930e
Revert "Create API for GrVkMemoryAllocator and impliment use of AMD VulkanMemoryAllocator on this API."
...
This reverts commit 26c0e4c1f5https://skia-review.googlesource.com/129980
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Jim Van Verth <jvanverth@google.com>
TBR=egdaniel@google.com ,jvanverth@google.com,bsalomon@google.com,bungeman@google.com
Change-Id: I6c74978f778987c422e6162e7dd85ea9c6baa0e4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/130182
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-05-25 17:25:23 +00:00
Greg Daniel
26c0e4c1f5
Create API for GrVkMemoryAllocator and impliment use of AMD VulkanMemoryAllocator on this API.
...
Bug: skia:
Change-Id: I1e122e1b11ab308c2f83cb98c36c81511f4507d0
Reviewed-on: https://skia-review.googlesource.com/129980
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2018-05-25 15:24:42 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
7cd7407901
Roll skia/third_party/skcms b01dbd2..a8a5c9e (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/b01dbd2..a8a5c9e
2018-05-24 brianosman@google.com Fix NULL dereference when using skcms to just do format conversion
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=allanmac@google.com
Change-Id: I9c2f469dcaf70f89c85696c2aa0c7a5690235301
Reviewed-on: https://skia-review.googlesource.com/130006
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-24 19:53:41 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
dcc69a507d
Roll skia/third_party/skcms 5bfec77..b01dbd2 (1 commits)
...
https://skia.googlesource.com/skcms.git/+log/5bfec77..b01dbd2
2018-05-23 brianosman@google.com Recover the original primaries (using CHAD) when emitting gamut diagrams
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=allanmac@google.com
Change-Id: I7501f2628fa30a57f445c99ade1184eea6a8bdcc
Reviewed-on: https://skia-review.googlesource.com/129709
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-23 15:16:11 +00:00
Greg Daniel
4b6d4d0ecc
MoltenVk fix for fuchsia again.
...
Bug: skia:
Change-Id: I57365b69c4c764079512dce9e6d1bb624a199d1f
Reviewed-on: https://skia-review.googlesource.com/129449
Commit-Queue: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Auto-Submit: Greg Daniel <egdaniel@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-05-22 21:04:45 +00:00
Greg Daniel
91dfa3b571
Reland "Move gn setup for vulkan library/headers into their own third_party directory."
...
This reverts commit 2c2a119f94477094250chttps://logs.chromium.org/v/?s=fuchsia%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8945885190914943680%2F%2B%2Fsteps%2Fbuild%2F0%2Fsteps%2Fbuild_fuchsia%2F0%2Fsteps%2Fgn_gen%2F0%2Fstdout
>
> Original change's description:
> > Move gn setup for vulkan library/headers into their own third_party directory.
> >
> > Bug: skia:
> > Change-Id: I4605f0d962271efb77bf3c17f1b0daaaddfb51c8
> > Reviewed-on: https://skia-review.googlesource.com/128540
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
> > Reviewed-by: Mike Klein <mtklein@google.com>
> > Reviewed-by: Ben Wagner <bungeman@google.com>
>
> TBR=egdaniel@google.com ,mtklein@google.com,bungeman@google.com
>
> Change-Id: I6e41d98e39883eff34424a2f352b0c8adec178db
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/129444
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>
Bug: skia:
Change-Id: I26b4b1f7196dd1bd8bf2e7641ef741c90c742c81
Reviewed-on: https://skia-review.googlesource.com/129445
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-05-22 19:08:05 +00:00
Mike Klein
2c2a119f94
Revert "Move gn setup for vulkan library/headers into their own third_party directory."
...
This reverts commit 477094250chttps://logs.chromium.org/v/?s=fuchsia%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8945885190914943680%2F%2B%2Fsteps%2Fbuild%2F0%2Fsteps%2Fbuild_fuchsia%2F0%2Fsteps%2Fgn_gen%2F0%2Fstdout
Original change's description:
> Move gn setup for vulkan library/headers into their own third_party directory.
>
> Bug: skia:
> Change-Id: I4605f0d962271efb77bf3c17f1b0daaaddfb51c8
> Reviewed-on: https://skia-review.googlesource.com/128540
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>
> Reviewed-by: Ben Wagner <bungeman@google.com>
TBR=egdaniel@google.com ,mtklein@google.com,bungeman@google.com
Change-Id: I6e41d98e39883eff34424a2f352b0c8adec178db
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/129444
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-05-22 12:25:55 +00:00
Greg Daniel
477094250c
Move gn setup for vulkan library/headers into their own third_party directory.
...
Bug: skia:
Change-Id: I4605f0d962271efb77bf3c17f1b0daaaddfb51c8
Reviewed-on: https://skia-review.googlesource.com/128540
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-05-21 18:17:08 +00:00
