Commit Graph

37147 Commits

Author SHA1 Message Date
Mike Klein
6719fcc43b Revert "Remove obsolete paint copy"
This reverts commit cb969c76e7.

Reason for revert: asserts triggering in PDF

Original change's description:
> Remove obsolete paint copy
> 
> All the backends use the glyph run natively now, and
> glyph runs never interpret these fields in paint.
> 
> Change-Id: I1c6fde1202057391e3a3f9be65f1e8a851205df5
> Reviewed-on: https://skia-review.googlesource.com/158720
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Herb Derby <herb@google.com>

TBR=mtklein@google.com,herb@google.com

Change-Id: I8ffcf633ffc41d4dc193ddf2a28a223cdaef9929
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/159061
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-02 18:58:35 +00:00
Robert Phillips
412dd56589 Add GM for less common YUV formats
Bug: skia:7903
Change-Id: I0d6e6d6274d66a71aaf24b68b6d9ceb0f2148b68
Reviewed-on: https://skia-review.googlesource.com/157601
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2018-10-02 18:57:58 +00:00
Mike Klein
df66894999 cleanup SkColorSpace API and members
I think this is the cleanup we can do immediately
once I rebaseline the previous CL.

Nothing will be using fromXYZD50() any longer.

I've made toXYZD50() lazily cache its SkMatrix44.
Not to many people call that function, so it'd be a
pretty straightforward cleanup to switch to the one
that writes to an SkMatrix44*, which is just fine.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iad45ef7c95ed7f9a9528d543f2307490ca5de087
Reviewed-on: https://skia-review.googlesource.com/158000
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-10-02 18:57:54 +00:00
Mike Klein
0a44d5c728 Reland "clamp gamut if needed in SkConvertPixels"
This is a reland of b8fef7c986

readpixels is now disabled on serialize-8888.
The image encoding means it doesn't quite round trip,
though the image looks fine to the eye.

Original change's description:
> clamp gamut if needed in SkConvertPixels
>
> We need to clamp here for all the same reasons we need to clamp when
> blitting.  I've centralized the clamp's implementation to help that.
>
> I've allowed any --config to run this GM.  --config 565 was actually
> pointing out this problem by asserting, and now looks fine.
>
> Change-Id: Icc066792fc53747b161302d200abdd8dc4669f7f
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://skia-review.googlesource.com/158721
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

Change-Id: I07601149e1d1e070bf96361f5303569b6a7b4e2a
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://skia-review.googlesource.com/c/159001
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-02 18:50:25 +00:00
Florin Malita
57b9d4071b [skottie] External logger support
Add a skottie::Logger interface, allowing clients to register for log events
from the animation builder.

Convert existing log messages to the new machinery.

Change-Id: If9083f89b27f197bfc0d8d81860bbacb6b764be3
Reviewed-on: https://skia-review.googlesource.com/c/158580
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-10-02 18:17:35 +00:00
Chris Dalton
76c775f48d ccpr: Fix the path cache on Android framework
Change-Id: Idfc76cde6f18bfca4daf0d34706d03d500ba4dec
Bug: skia:8127
Reviewed-on: https://skia-review.googlesource.com/c/158620
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-10-02 18:13:05 +00:00
Mike Klein
684b506f35 Revert "Always include public/include headers for vulkan and just guard src files with SK_VULKAN."
This reverts commit 6e2d607334.

Reason for revert: chrome roll

Original change's description:
> Always include public/include headers for vulkan and just guard src files with SK_VULKAN.
> 
> This should allow a client to build a skia library that doesn't use vulkan but still
> has all the public headers defined so that they don't have to build two versions of
> their code.
> 
> Bug: chromium:862144
> Change-Id: I0eecbe0bc48123619f217e2cf318eb9a8c77ccb2
> Reviewed-on: https://skia-review.googlesource.com/158661
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,cblume@chromium.org

Change-Id: I76ae6f435333755fa5d546fc1e5999a324b4fd05
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:862144
Reviewed-on: https://skia-review.googlesource.com/c/159000
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-02 18:05:54 +00:00
Kevin Lubick
d45c7811ef Fix text on CanvasKit
Updates example to use text (and be more mobile friendly).

Also make the compile step a bit nicer and remove SKOTTIE_HACK.

Docs-Preview: https://skia.org/?cl=158664
Bug: skia:
Change-Id: I4c465482058ad7d359729a492e29205c07f3933e
Reviewed-on: https://skia-review.googlesource.com/c/158664
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-10-02 17:58:33 +00:00
Mike Klein
6a76dab257 Revert "clamp gamut if needed in SkConvertPixels"
This reverts commit b8fef7c986.

Reason for revert: serialize-8888?

Original change's description:
> clamp gamut if needed in SkConvertPixels
> 
> We need to clamp here for all the same reasons we need to clamp when
> blitting.  I've centralized the clamp's implementation to help that.
> 
> I've allowed any --config to run this GM.  --config 565 was actually
> pointing out this problem by asserting, and now looks fine.
> 
> Change-Id: Icc066792fc53747b161302d200abdd8dc4669f7f
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://skia-review.googlesource.com/158721
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,brianosman@google.com

Change-Id: Id888656b313619ab2652a3387bdbc5208e192ec1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://skia-review.googlesource.com/c/158980
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-02 17:52:05 +00:00
Greg Daniel
6e2d607334 Always include public/include headers for vulkan and just guard src files with SK_VULKAN.
This should allow a client to build a skia library that doesn't use vulkan but still
has all the public headers defined so that they don't have to build two versions of
their code.

Bug: chromium:862144
Change-Id: I0eecbe0bc48123619f217e2cf318eb9a8c77ccb2
Reviewed-on: https://skia-review.googlesource.com/158661
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-10-02 17:41:53 +00:00
Jim Van Verth
f86073a131 Add some checks to GrDashOp
Bug: oss-fuzz:9322
Change-Id: I9d40e85814138fd83efa497e00c0d612cc26043e
Reviewed-on: https://skia-review.googlesource.com/158821
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2018-10-02 17:38:23 +00:00
Brian Salomon
81c8a20112 Don't crash in aaflags GM if context is abandoned
Change-Id: I5683c2f7c0fb19b5e3fb7eab599651a3fe3eab3f
Reviewed-on: https://skia-review.googlesource.com/158823
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-10-02 17:31:00 +00:00
Florin Malita
bee88d433d [sksg] Fix inval tracking in Group::removeChild()
TBR=
Change-Id: If3536f8be9d379402cde18c0482108fcf5ae01bb
Reviewed-on: https://skia-review.googlesource.com/158822
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-10-02 17:27:34 +00:00
Herb Derby
cb969c76e7 Remove obsolete paint copy
All the backends use the glyph run natively now, and
glyph runs never interpret these fields in paint.

Change-Id: I1c6fde1202057391e3a3f9be65f1e8a851205df5
Reviewed-on: https://skia-review.googlesource.com/158720
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-10-02 17:17:50 +00:00
Brian Salomon
2213ee94c7 Add support for per-edge AA to GrTextureOp.
Outsetting in perspective case outsets the original homogeneous quad
points rather than the homogenized 2d points in order to avoid seaming
issues along shared edges.

Currently there is no way to trigger this from the public API and it
is tested by directly accessing GrRenderTargetContext from the added gm.

Change-Id: I24e0d53cc5821c8c8be07c23aca5bfafb4935c33
Reviewed-on: https://skia-review.googlesource.com/157600
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-10-02 16:45:07 +00:00
Brian Salomon
75975510f3 On ES2 + EXT_color_buffer_half_float cannot render to GL_R16F.
This extension only allows rendering to:

        <internalformat> = RGBA
        <format> = RGBA
        <type> = HALF_FLOAT_OES

BUG=angleproject:2567

Change-Id: I6a85544a1d2f9b95567466330f874fd4265f047c
Reviewed-on: https://skia-review.googlesource.com/158820
Reviewed-by: Yuly Novikov <ynovikov@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-10-02 16:41:52 +00:00
Jim Van Verth
f49262d3bc Add SkImage_GpuYUVA
Bug: skia:7903
Change-Id: I06edc155b0a0a0697dc0d0aab74b6876d631ca0d
Reviewed-on: https://skia-review.googlesource.com/156942
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-10-02 16:40:01 +00:00
Ben Wagner
cc4dbfcfbd Remove SK_IGNORE_TINY_FREETYPE_SIZE_FIX
It is no longer used by any client.

Change-Id: I7d43e715c217e412a63b885ab242b26254bd5ea8
Reviewed-on: https://skia-review.googlesource.com/158560
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-10-02 16:13:48 +00:00
skia-autoroll
30150bc6b5 Roll third_party/externals/swiftshader f1d777c71f03..60be5c45fab2 (3 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/f1d777c71f03..60be5c45fab2


git log f1d777c71f03..60be5c45fab2 --date=short --no-merges --format='%ad %ae %s'
2018-10-02 capn@google.com Fix preprocessor error.
2018-10-02 merckhung@google.com Migrate to using <log/log.h> since Android O (API 27)
2018-10-02 capn@google.com Remove stray printfs.


Created with:
  gclient setdep -r third_party/externals/swiftshader@60be5c45fab2

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=mtklein@google.com

Change-Id: Ia73c18120f6b209612f44c6362a70a61be5c3eb6
Reviewed-on: https://skia-review.googlesource.com/158647
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-02 15:58:47 +00:00
Mike Reed
ce96e1e94f removed dead flag check
Missed this earlier. Should have been part of https://skia-review.googlesource.com/c/skia/+/158600

Bug: skia:
Change-Id: Id70dda3aa1e869aee3e6f10c042c84b4bfc5c211
Reviewed-on: https://skia-review.googlesource.com/158740
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-10-02 15:53:57 +00:00
Ben Wagner
9f9c2ea428 Don't set kCTFontSymbolicTrait.
This allows for requesting 'bold' and 'italic' but these requests are
redundant with the 'weight' and 'slant' requests also being made. It
appears that on macOS 14 and iOS 12 that setting kCTFontSymbolicTrait,
particularly without setting any bits, leads to strange behavior. Since
the information in kCTFontSymbolicTrait is better provided by other
traits, simply remove the code which sets it and add a comment explaining
why.

Bug: skia:8432
Change-Id: I795c9adf4a52d828d3e92bc4af0966102f9b6cc1
Reviewed-on: https://skia-review.googlesource.com/158443
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-10-02 15:49:06 +00:00
Eric Boren
c90d7ae2a4 [infra] Add missing symlink target in go_deps asset
Bug: skia:
Change-Id: Ic806bddcdc1130e9b96158c19dbff9e16900020c
Reviewed-on: https://skia-review.googlesource.com/157565
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-10-02 15:46:21 +00:00
skia-autoroll
18c57ca02c Roll third_party/externals/angle2 def1ba96cba4..16c20140e05e (1 commits)
def1ba96cb..16c20140e0


git log def1ba96cba4..16c20140e05e --date=short --no-merges --format='%ad %ae %s'
2018-10-01 jmadill@chromium.org Vulkan: Record blit commands inside blit methods.


Created with:
  gclient setdep -r third_party/externals/angle2@16c20140e05e

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=mtklein@google.com

Change-Id: I261e063040a60697c66be7b2226793f4a3cf7f46
Reviewed-on: https://skia-review.googlesource.com/158646
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-02 15:42:16 +00:00
Mike Klein
b8fef7c986 clamp gamut if needed in SkConvertPixels
We need to clamp here for all the same reasons we need to clamp when
blitting.  I've centralized the clamp's implementation to help that.

I've allowed any --config to run this GM.  --config 565 was actually
pointing out this problem by asserting, and now looks fine.

Change-Id: Icc066792fc53747b161302d200abdd8dc4669f7f
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://skia-review.googlesource.com/158721
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-02 15:41:18 +00:00
Mike Klein
0b170e81be missed a spot to clamp to gamut
When folding a constant color pipeline through back to a single color,
we're not clamping that constant color back to gamut.

I noticed this when debugging plus mode, but it's really unrelated.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ief43591373cfbb7e58d4178b0b6cc754fcf61c97
Reviewed-on: https://skia-review.googlesource.com/158540
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
2018-10-02 15:01:52 +00:00
Mike Klein
21ba77273d remove DM timestamps
The bot logs record and display their own now,
and they're slightly nicer (color coded!).

Change-Id: I4626f62ed0a12bbd0dd837bcc83d7809e4ae347d
Reviewed-on: https://skia-review.googlesource.com/158663
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-10-02 14:49:23 +00:00
skia-autoroll
209badfa6e Roll third_party/externals/angle2 9d597f8a3a1e..def1ba96cba4 (1 commits)
9d597f8a3a..def1ba96cb


git log 9d597f8a3a1e..def1ba96cba4 --date=short --no-merges --format='%ad %ae %s'
2018-10-01 geofflang@chromium.org Reland "D3D11: Resolve multisampled EGL surfaces at eglSwapBuffers"


Created with:
  gclient setdep -r third_party/externals/angle2@def1ba96cba4

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=mtklein@google.com

Change-Id: I8ac62de540a0c50090e134617fd4ac2290ee8cc6
Reviewed-on: https://skia-review.googlesource.com/158643
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-02 14:09:48 +00:00
Jim Van Verth
0bc6910dc1 Check for degenerate path when calculating shadow transform
Bug: oss-fuzz:10450
Change-Id: Ifa8500c2abfe4f1b118610f97f6b716039e4e19a
Reviewed-on: https://skia-review.googlesource.com/158563
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2018-10-02 13:53:04 +00:00
Ravi Mistry
29913abccc [Android compile bot] Break out of loop if JSON successfully loads
Noticed the problem with https://logs.chromium.org/logs/skia/20181002T125425.573885416Z_00000000008df472/+/steps/Trigger_and_wait_for_task_on_android_compile_server/0/stdout


Bug: skia:8087
Bug: skia:8387
Change-Id: I290371636f2a6f1da4077166c753668bf3e85542
Reviewed-on: https://skia-review.googlesource.com/158662
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-10-02 13:33:39 +00:00
skia-autoroll
7e4338a7cb Roll third_party/externals/angle2 996628a4a1fd..9d597f8a3a1e (1 commits)
996628a4a1..9d597f8a3a


git log 996628a4a1fd..9d597f8a3a1e --date=short --no-merges --format='%ad %ae %s'
2018-10-01 jmadill@chromium.org Vulkan: Use copyImageDataToBuffer in Texture mipmap gen.


Created with:
  gclient setdep -r third_party/externals/angle2@9d597f8a3a1e

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=mtklein@google.com

Change-Id: I570aaf886ee2d6811679416c793788d3420b4acc
Reviewed-on: https://skia-review.googlesource.com/158642
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-02 13:31:24 +00:00
Kevin Lubick
cbcff385c1 Have pathkit use libpathkit.a for faster builds
Of note, it is very important for the -DSK_RELEASE/-DSK_DEBUG
to match between libskia.a and the WASM bindings, otherwise
things like SKDEBUGCODE are sometimes compiled in and sometimes
not, which can cause headaches like sizeof() mismatching between
.cpp files and .h files.

Bug: skia:
Change-Id: Id6ef58c44a7c10014a243b36708e0891514f6008
Reviewed-on: https://skia-review.googlesource.com/158341
Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-02 13:27:29 +00:00
Brian Osman
15f0f29d7f Reland "Reland "Reland "Preserve colorType and alphaType in SkImage::makeColorSpace"""
This reverts commit 7f3ceba5dc.

Reason for revert: Guarded for chrome pixel tests.

Original change's description:
> Revert "Reland "Reland "Preserve colorType and alphaType in SkImage::makeColorSpace"""
> 
> This reverts commit 41576877bd.
> 
> Reason for revert: best guess for pixel test failures
> 
> Original change's description:
> > Reland "Reland "Preserve colorType and alphaType in SkImage::makeColorSpace""
> > 
> > This reverts commit 11f4994b84.
> > 
> > Reason for revert: Codec change should fix the layout test failures?
> > 
> > Original change's description:
> > > Revert "Reland "Preserve colorType and alphaType in SkImage::makeColorSpace""
> > > 
> > > This reverts commit 893052ea51.
> > > 
> > > Reason for revert: Chrome roll layout failures.
> > > 
> > > Original change's description:
> > > > Reland "Preserve colorType and alphaType in SkImage::makeColorSpace"
> > > > 
> > > > This reverts commit 0d08b3e4b1.
> > > > 
> > > > Reason for revert: Fixed Chrome test.
> > > > 
> > > > Original change's description:
> > > > > Revert "Preserve colorType and alphaType in SkImage::makeColorSpace"
> > > > > 
> > > > > This reverts commit d842557c07.
> > > > > 
> > > > > Reason for revert: Chrome roll failing CanvasAsyncBlobCreatorTest.ColorManagedConvertToBlob test.
> > > > > 
> > > > > Original change's description:
> > > > > > Preserve colorType and alphaType in SkImage::makeColorSpace
> > > > > > 
> > > > > > Raster images were always converting to N32, and GPU images were
> > > > > > always converting to premul. These were unexpected and inconsistent.
> > > > > > 
> > > > > > Bug: skia:8382
> > > > > > Change-Id: I78fe6cff1208eef077a71d08e676cf8f8d5fed9a
> > > > > > Reviewed-on: https://skia-review.googlesource.com/156142
> > > > > > Commit-Queue: Brian Osman <brianosman@google.com>
> > > > > > Reviewed-by: Mike Klein <mtklein@google.com>
> > > > > 
> > > > > TBR=mtklein@google.com,brianosman@google.com
> > > > > 
> > > > > Change-Id: I366b097644ac1fa920fc9addcad3e09c2a0a63cc
> > > > > No-Presubmit: true
> > > > > No-Tree-Checks: true
> > > > > No-Try: true
> > > > > Bug: skia:8382
> > > > > Reviewed-on: https://skia-review.googlesource.com/156184
> > > > > Reviewed-by: Brian Osman <brianosman@google.com>
> > > > > Commit-Queue: Brian Osman <brianosman@google.com>
> > > > 
> > > > TBR=mtklein@google.com,brianosman@google.com
> > > > 
> > > > Change-Id: I860f33a1d57e0e77ce63b78d66d49a1082d2b4dd
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: skia:8382
> > > > Reviewed-on: https://skia-review.googlesource.com/156188
> > > > Reviewed-by: Brian Osman <brianosman@google.com>
> > > > Commit-Queue: Brian Osman <brianosman@google.com>
> > > 
> > > TBR=mtklein@google.com,brianosman@google.com
> > > 
> > > Change-Id: Ib53912d014916374e5d0ee3d224ba69d41a5018c
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: skia:8382
> > > Reviewed-on: https://skia-review.googlesource.com/156360
> > > Reviewed-by: Brian Osman <brianosman@google.com>
> > > Commit-Queue: Brian Osman <brianosman@google.com>
> > 
> > TBR=mtklein@google.com,brianosman@google.com
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: skia:8382
> > Change-Id: I3bd7109dd380b6ef213883074c3b07d19ba6ca37
> > Reviewed-on: https://skia-review.googlesource.com/157743
> > Reviewed-by: Brian Osman <brianosman@google.com>
> > Commit-Queue: Brian Osman <brianosman@google.com>
> 
> TBR=mtklein@google.com,brianosman@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: skia:8382
> Change-Id: I587820c6e6c981025f3a2a5a20d8ba4df4b65634
> Reviewed-on: https://skia-review.googlesource.com/158100
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,brianosman@google.com

Change-Id: I6e78537205812f2b38f348ced22fbb8d92d322cc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:8382
Reviewed-on: https://skia-review.googlesource.com/158344
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-10-02 13:16:35 +00:00
Ravi Mistry
7dae882574 Add direct log links on milo page for Android compile bot
Bug: skia:8388
Change-Id: Id546d043a3a9be546f592dcab37325bc6b6c4e89
Reviewed-on: https://skia-review.googlesource.com/155164
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-10-02 12:40:53 +00:00
Ravi Mistry
5587b709ca Update trigger_wait_ac_task.py to use GCS instead of webhooks
* Add more frequent task status updates.
* Add exponential retries when hitting GCS.

Bug: skia:8087
Bug: skia:8387
Change-Id: Iff8320b88999fde53c1ad4814dc9243ebd8138a8
Reviewed-on: https://skia-review.googlesource.com/155163
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-10-02 12:20:58 +00:00
Cary Clark
9e92782016 fix path addrrect example in docs
Use drawTextRSXform in place of deprecated SkDrawTextOnPath
in example. I'm curious if there is a more elegant way to
illustrate where round rects start, but this is all I've
come up with.

R=reed@google.com,fmalita@google.com
NOTRY=true
Docs-Preview: https://skia.org/?cl=158444
Bug: skia:
Change-Id: I0fc02078e6425afabb5dc71f458435d606c82e77
Reviewed-on: https://skia-review.googlesource.com/158444
Commit-Queue: Cary Clark <caryclark@google.com>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-10-02 12:15:36 +00:00
Mike Reed
16c9216905 remove LEGACY_SVG code, as no one defines that flag anymore.
Bug: skia:
Change-Id: I99929ac992c0f6fd3b09036b6cf3db74a3e4d16d
Reviewed-on: https://skia-review.googlesource.com/158600
Reviewed-by: Florin Malita <fmalita@google.com>
Commit-Queue: Florin Malita <fmalita@google.com>
2018-10-02 02:41:48 +00:00
Michael Ludwig
083bc1576a Update parameter generation for randomized gradient tests
Previously, randomized gradients used layout parameters between 0 and 1.
However, that means when the ProcessorOptimizationValidationTest renders the
generated gradients, the sub-pixel gradients are stretched a lot. This may
be the source of instability in the test, if we are reaching precision issues
due to the small values scaled up so much when actually rendered.

Here is an example of a valid 2 point conical gradient produced by the original
parameter generation: https://drive.google.com/file/d/1CMc69AHcWBjLu2Ir2ty0qw29T-Vd1cOg
Here is a very similar case, rendered on another device, that also has corruption: https://drive.google.com/open?id=1K2HPXCSda2bWoGwV-x_iKwu9_xLENBt-
Here is the equivalent 2 point conical gradient from the first link, generated using the new parameters from this CL: https://drive.google.com/open?id=1Z_M0xJ2h-o-bPb5Il7-P5X4z703nWt5R

Bug: skia:
Change-Id: I89f5ef0e91fa9ff5664079936f97e90a8dbfcd19
Reviewed-on: https://skia-review.googlesource.com/158561
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2018-10-01 22:59:00 +00:00
Nico Weber
e50efdfded Remove a few exit-time destructors.
Bug: chromium:101600
Change-Id: I47da22b27703f4d47622f6f25bc1694a1bcc3099
Reviewed-on: https://skia-review.googlesource.com/158440
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-01 22:46:21 +00:00
Stan Iliev
a7a52b9de3 Fix error at run time to load skottie_android.so
Test: Ran Skottie app
Bug: skia:
Change-Id: I2147433018154069a9294ac80dbeb8692ec748cc
Reviewed-on: https://skia-review.googlesource.com/158441
Commit-Queue: Stan Iliev <stani@google.com>
Reviewed-by: Florin Malita <fmalita@google.com>
2018-10-01 20:46:50 +00:00
skia-autoroll
b099fe8348 Roll third_party/externals/swiftshader 810f3db8264a..f1d777c71f03 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/810f3db8264a..f1d777c71f03


git log 810f3db8264a..f1d777c71f03 --date=short --no-merges --format='%ad %ae %s'
2018-10-01 capn@google.com Remove duplicates in LLVM 7.0 build.


Created with:
  gclient setdep -r third_party/externals/swiftshader@f1d777c71f03

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=mtklein@google.com

Change-Id: I7d2e98dcd6440b162f1a34db056c73262000ff29
Reviewed-on: https://skia-review.googlesource.com/158480
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-01 20:31:58 +00:00
Herb Derby
7d8e1f7ca3 Move remote glyph cache DFT handling to painter
Change-Id: I68178e0675a45d77355b76a50eff06238ee1c54c
Reviewed-on: https://skia-review.googlesource.com/158380
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-01 19:42:28 +00:00
Hal Canary
8ef78eae93 SkPDF: encode all bitmap images as Type3
Change-Id: Ic99c536ea7da6b6a55dd92395eee26c969fee966
Reviewed-on: https://skia-review.googlesource.com/158343
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-10-01 19:01:56 +00:00
Brian Osman
1d5b598c4e Towards removing GrColor4f
We'd really like to converge on SkRGBA4f everywhere. This CL continues
to store GrColor4f in the GPU backend, but changes the constantColor
optimization logic to use SkPMColor4f.

GrColor[4f] have "unknown" alpha type, but in this context, they are
nearly always premul, so let's take advantage of our SkRGBA4f type
safety. We lose some of the semantic benefits and helpers that are
present in GrColor4f (OpaqueWhite, TransparentBlack).

The biggest thing that would probably help is a direct path to/from
bytes (GrColor).

Bug: skia:
Change-Id: Ic0838ad3f95d207163b3af51e5f5cf6f499c2047
Reviewed-on: https://skia-review.googlesource.com/157840
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-10-01 18:32:56 +00:00
Michael Ludwig
e8e1075a9e Add input/output image logging to processor tests
Moves SkBitmap to base64 uri code into test utils

Bug: skia:
Change-Id: I4f92761fd2e643c38ed00a200b1cb62778a85948
Reviewed-on: https://skia-review.googlesource.com/158340
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2018-10-01 18:30:06 +00:00
skia-autoroll
105ca96803 Roll third_party/externals/angle2 a78092cb2557..996628a4a1fd (2 commits)
a78092cb25..996628a4a1


git log a78092cb2557..996628a4a1fd --date=short --no-merges --format='%ad %ae %s'
2018-10-01 syoussefi@google.com Vulkan: Add support for VkPipelineCache
2018-10-01 jmadill@chromium.org Vulkan: Fix bugs in glGenerateMipmaps.


Created with:
  gclient setdep -r third_party/externals/angle2@996628a4a1fd

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=mtklein@google.com

Change-Id: Ia16311270099ed772b12a42043fe0695e440f782
Reviewed-on: https://skia-review.googlesource.com/158360
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-01 17:37:29 +00:00
Mike Reed
1eb9af9029 delete textonpath code -- not used anywhere
Bug: skia:
Change-Id: Ib645f7c140f87123429170a0bf6f7ed86ce53b3f
Reviewed-on: https://skia-review.googlesource.com/158224
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
2018-10-01 16:52:32 +00:00
Allan MacKinnon
6ddc9598ef SKC group improvements
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Bug: skia:
Change-Id: Ia1a3762b8b7537f4e672896aea7b4988410a71ef
Reviewed-on: https://skia-review.googlesource.com/158320
Reviewed-by: Allan MacKinnon <allanmac@google.com>
Commit-Queue: Allan MacKinnon <allanmac@google.com>
Auto-Submit: Allan MacKinnon <allanmac@google.com>
2018-10-01 16:17:48 +00:00
Hal Canary
3b8b11e1f9 SkPDF: Device methods setGraphicState and drawFormXObject
Change-Id: Ib94886db5ca3c76082c159c2234e2fe281ba615c
Reviewed-on: https://skia-review.googlesource.com/158101
Auto-Submit: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-10-01 15:35:29 +00:00
skia-autoroll
812743fed0 Roll third_party/externals/swiftshader 876760bb27d0..810f3db8264a (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/876760bb27d0..810f3db8264a


git log 876760bb27d0..810f3db8264a --date=short --no-merges --format='%ad %ae %s'
2018-10-01 nicolas.capens@gmail.com Fix stencil buffer memory leak.


Created with:
  gclient setdep -r third_party/externals/swiftshader@810f3db8264a

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=mtklein@google.com

Change-Id: I0e1fe5c48dca8a856faf6f935888efe7435da526
Reviewed-on: https://skia-review.googlesource.com/158260
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-01 14:50:57 +00:00
Kevin Lubick
de1a1a2de3 Open non-perf Quadro bots to rack 2
Bug: 784662
Change-Id: I49b8b396956e3442713ca2750fe19fd35f0797f0
Reviewed-on: https://skia-review.googlesource.com/158221
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-10-01 14:25:25 +00:00