Commit Graph

9769 Commits

Author SHA1 Message Date
commit-bot@chromium.org
6c4e71a5d6 Remove unnamed namespace usage from 'gm'.
Skia prefers static over unnamed namespaces.

BUG=None
TEST=None
R=bsalomon@google.com, robertphillips@google.com

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/79173002

git-svn-id: http://skia.googlecode.com/svn/trunk@12326 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 21:32:10 +00:00
scroggo@google.com
0daf00ccd7 Move SkTDStackNester into its own private file.
Also remove depth(), which is unused.

Otherwise the class is unchanged.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/64093009

git-svn-id: http://skia.googlecode.com/svn/trunk@12324 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 20:47:21 +00:00
epoger@google.com
591469b1e9 rebaseline_server: clean up thread locks
followup to https://codereview.chromium.org/66803004/ ('rebaseline_server: improve thread locks to allow read access during updates')
(SkipBuildbotRuns)

R=jcgregorio@google.com

Review URL: https://codereview.chromium.org/64273011

git-svn-id: http://skia.googlecode.com/svn/trunk@12323 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 19:58:06 +00:00
mtklein@google.com
dad7070d91 More common_conditions simplifications.
BUG=
R=bungeman@google.com, djsollen@google.com

Review URL: https://codereview.chromium.org/78653002

git-svn-id: http://skia.googlecode.com/svn/trunk@12322 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 18:06:10 +00:00
mtklein@google.com
0724e1fc2d Hide unused gFormats.
Presumably this is WIP code?  Otherwise, we delete it?

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/78503003

git-svn-id: http://skia.googlecode.com/svn/trunk@12321 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 18:02:00 +00:00
commit-bot@chromium.org
3495c9118d GpuTest::GetContext() doesn't exist.
BUG=
R=bsalomon@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/76143003

git-svn-id: http://skia.googlecode.com/svn/trunk@12320 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 17:59:54 +00:00
commit-bot@chromium.org
273104028c Remove the SKIA_IGNORE_GPU_MIPMAPS now that Chrome sets glGenMipmap for
the skia GL interface.

R=bsalomon@google.com, humper@google.com

Author: skaslev@chromium.org

Review URL: https://codereview.chromium.org/74783011

git-svn-id: http://skia.googlecode.com/svn/trunk@12319 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 17:59:48 +00:00
mtklein@google.com
f41760939f Update expectations for Ubuntu x32 bot.
GM diffs are few, tiny, and unreproducable on our workstations.

BUG=

Review URL: https://codereview.chromium.org/78913002

git-svn-id: http://skia.googlecode.com/svn/trunk@12318 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 17:08:13 +00:00
scroggo@google.com
1ecd9cf379 Fix a warning building DM using ninja on Mac.
Here is the warning:
../../dm/DMTask.cpp: In copy constructor ‘DM::Task::Task(const DM::Task&)’:
../../dm/DMTask.cpp:17: warning: base class ‘class SkRunnable’ should be explicitly initialized in the copy constructor

Also add an SK_OVERRIDE.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/76903002

git-svn-id: http://skia.googlecode.com/svn/trunk@12317 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 16:44:59 +00:00
robertphillips@google.com
8c99c9f4a6 Reverting r12315 (More Windows 64b compilation warning fixes) due to compilation failures
git-svn-id: http://skia.googlecode.com/svn/trunk@12316 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 15:56:14 +00:00
robertphillips@google.com
80051d38a3 More Windows 64b compilation warning fixes
https://codereview.chromium.org/47513017/



git-svn-id: http://skia.googlecode.com/svn/trunk@12315 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 15:46:10 +00:00
mtklein@google.com
f1077f9164 Add extra warnings to match what Android uses.
R=mtklein@google.com

Committed: https://code.google.com/p/skia/source/detail?r=12310

Review URL: https://codereview.chromium.org/74193005

git-svn-id: http://skia.googlecode.com/svn/trunk@12314 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 15:13:49 +00:00
bungeman@google.com
f7159bba8e De-generalize create_typeface on Windows.
The gdi and dw backends have a local create_typeface function.
This function is now called in only one place, onLegacyCreateTypeface.
Move the implementation into the caller.

R=caryclark@google.com

Review URL: https://codereview.chromium.org/76763002

git-svn-id: http://skia.googlecode.com/svn/trunk@12313 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 15:11:05 +00:00
mtklein@google.com
9615f8dbf1 Add missing (trivial) virtual destructors.
BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/78543002

git-svn-id: http://skia.googlecode.com/svn/trunk@12312 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 14:29:51 +00:00
scroggo@google.com
b60cdc8f4c Revert "Add extra warnings to match what Android uses."
This reverts commit d234662df1ffeb1bf45b2ade16c4acfb94f89450.

This change broke the build. Will resubmit after fixing warnings.

git-svn-id: http://skia.googlecode.com/svn/trunk@12311 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 13:58:58 +00:00
djsollen@google.com
692f88c7f0 Add extra warnings to match what Android uses.
R=mtklein@google.com

Review URL: https://codereview.chromium.org/74193005

git-svn-id: http://skia.googlecode.com/svn/trunk@12310 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 13:16:47 +00:00
djsollen@google.com
db490e9971 fix bench so that if SK_SUPPORTS_GPU even when not provided as compiler option
In the case that SK_SUPPORTS_GPU is not provided to the compiler the value is
eithe defined in in the SkUserConfig.h or SkPostConfig.h.  Prior to this change
those headers were not read prior to trying to include the GPU headers which
resulted in a failed compile.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/76213004

git-svn-id: http://skia.googlecode.com/svn/trunk@12309 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 13:15:40 +00:00
bungeman@google.com
10822c6daa SkMemoryStream::setData should also set the current offset to 0.
R=scroggo@google.com

Review URL: https://codereview.chromium.org/73273004

git-svn-id: http://skia.googlecode.com/svn/trunk@12308 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-18 21:29:36 +00:00
commit-bot@chromium.org
c32ce49df8 Remove unused kMaxPOI.
BUG=
R=djsollen@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/62333026

git-svn-id: http://skia.googlecode.com/svn/trunk@12307 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-18 21:01:29 +00:00
mtklein@google.com
0f6dc21e32 Revert SK_REQUIRE_LOCAL_VAR changes for DEPS roll.
BUG=

Review URL: https://codereview.chromium.org/59703012

git-svn-id: http://skia.googlecode.com/svn/trunk@12306 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-18 20:55:29 +00:00
commit-bot@chromium.org
da4d7cfa58 Remove unnecessary includes.
R=djsollen@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/68893028

git-svn-id: http://skia.googlecode.com/svn/trunk@12304 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-18 17:27:16 +00:00
mtklein@google.com
cf4d0fb8bb Fix Windows build after the SkAutoFoo guard CL.
BUG=

Review URL: https://codereview.chromium.org/66593004

git-svn-id: http://skia.googlecode.com/svn/trunk@12303 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-18 16:33:08 +00:00
robertphillips@google.com
701b40543d Fix DocumentTest/SkDocument memory leaks
https://codereview.chromium.org/72833002/



git-svn-id: http://skia.googlecode.com/svn/trunk@12302 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-18 16:26:25 +00:00
commit-bot@chromium.org
e61a86cfa0 Guard against most unintentionally ephemeral SkAutoFoo instantiations.
I think I applied the trick everywhere possible.  Limitations:
    - can't be used with templated classes
    - all constructors and destructors must be defined inline

A couple of the SkAutoFoo were unused in Skia, Chromium, and Android, so I
deleted them.  This change caught the same bugs Cary found in SkPath, plus one
more in SampleApp.

BUG=
R=reed@google.com, caryclark@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/72603005

git-svn-id: http://skia.googlecode.com/svn/trunk@12301 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-18 16:03:59 +00:00
commit-bot@chromium.org
8bf4c0ab7b Whitespace change to test CQ.
TBR=
NOTREECHECKS=true
NOTRY=true

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/74723002

git-svn-id: http://skia.googlecode.com/svn/trunk@12300 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-17 16:19:11 +00:00
mike@reedtribe.org
139a2359ab fix general-pespective for conical gradient bug=1744
BUG=
R=edisonn@google.com

Review URL: https://codereview.chromium.org/71303003

git-svn-id: http://skia.googlecode.com/svn/trunk@12299 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 20:15:51 +00:00
jvanverth@google.com
7d4890c6f6 Ignore GM dashing_gpu on Debug ANGLE
BUG=Skia:1844

Committed: http://code.google.com/p/skia/source/detail?r=12297

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/72993002

git-svn-id: http://skia.googlecode.com/svn/trunk@12298 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 19:50:26 +00:00
commit-bot@chromium.org
d5c75bff3f Ignore GM dashing_gpu on Debug ANGLE
BUG=Skia:1844
R=robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/72993002

git-svn-id: http://skia.googlecode.com/svn/trunk@12297 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 19:39:49 +00:00
scroggo@google.com
909228992c Pdfviewer refactoring.
Mostly superficial changes, to help me make sure I understand the
code while making modifications.

SkPdfRenderer:
First class I'm modifying. Move it into include/ and src/ directories.
Inherit from SkNoncopyable.
Replace load() with factory function which returns NULL if the load
fails.
Remove unload() and loaded(), which no longer make sense, since the
factory will return NULL on a failure to load, and unload() happens
on destruction.
Use a const char* for loading a PDF, following the convention of
SkStream::NewFromFile.
Remove unnecessary call to sqrt in SkPDFNativeRenderToBitmap.
Also in SkPDFNativeRenderToBitmap, use an appropriate SkScalar macro
to convert to an integer.
Use this-> when calling member functions.

pdf_viewer_main.cpp:
Call the new interface for SkPdfRenderer.

gyp files:
Refer to the new location of SkPdfRenderer.

R=edisonn@google.com

Review URL: https://codereview.chromium.org/59493011

git-svn-id: http://skia.googlecode.com/svn/trunk@12296 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 19:09:27 +00:00
commit-bot@chromium.org
be65a4c9d6 Add missing functions to SkNWayCanvas
R=reed@google.com
BUG=none

Author: enne@chromium.org

Review URL: https://codereview.chromium.org/65513003

git-svn-id: http://skia.googlecode.com/svn/trunk@12295 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 19:02:41 +00:00
robertphillips@google.com
9b9b04924f Remove suppression of blurrect_outer
git-svn-id: http://skia.googlecode.com/svn/trunk@12294 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 18:52:52 +00:00
robertphillips@google.com
5810420e55 rebaseline blurrect_outer images
https://codereview.chromium.org/70103015/



git-svn-id: http://skia.googlecode.com/svn/trunk@12293 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 18:45:13 +00:00
scroggo@google.com
c6e1e9a9cc Fix warnings and Win only error in pdf_viewer.
git-svn-id: http://skia.googlecode.com/svn/trunk@12292 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 17:05:05 +00:00
commit-bot@chromium.org
a1a097ee81 increase coverage of SkPath.cpp, remove unused code
Using Mike Klein's excellent coverage tool, increase the
unit testing of SkPath.cpp from 70% to 95%.

Along the way, determined that these functions were not
maintained or used:

SkPath::pathTo
SkPath::contains

as well as a large block of SkPath::cheapGetDirection().

Changed SkPath::validate() to permit infinities in
the path data points.

Fixed errors in preserving direction.
Fixed error setting direction when convexity is unknown.

Added missing conic to moveTo only detector.

BUG=
R=bsalomon@google.com, reed@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/65493004

git-svn-id: http://skia.googlecode.com/svn/trunk@12291 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 16:53:22 +00:00
jvanverth@google.com
d296d315c0 Rebaseline and re-enable rrect_aa, rrect_bw, simpleaaclip_aaclip, simpleaaclip_path, strokerect, strokes_round
git-svn-id: http://skia.googlecode.com/svn/trunk@12290 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 16:35:35 +00:00
scroggo@google.com
221253861d Include SkBitmapDevice for pdf_viewer.
git-svn-id: http://skia.googlecode.com/svn/trunk@12289 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 16:01:23 +00:00
scroggo@google.com
e917962f6e Include pdfviewer in everything.
This simplifies the process for building pdfviewer. Now it can be
built using

./gyp_skia

make pdfviewer

(ninja can also be used).

R=edisonn@google.com

Review URL: https://codereview.chromium.org/70353003

git-svn-id: http://skia.googlecode.com/svn/trunk@12288 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 15:46:25 +00:00
robertphillips@google.com
cb3b615af7 Address some more valgrind issues
R=borenet@google.com

Review URL: https://codereview.chromium.org/59713010

git-svn-id: http://skia.googlecode.com/svn/trunk@12286 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 14:47:56 +00:00
edisonn@google.com
983c022bff pdfviewer: ignore flanky test
Review URL: https://codereview.chromium.org/64223008

git-svn-id: http://skia.googlecode.com/svn/trunk@12285 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 14:43:16 +00:00
skia.committer@gmail.com
73a5d53d96 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12283 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 07:02:31 +00:00
jvanverth@google.com
94f689afde Add rrect_aa and rrect_bw to ignore list
git-svn-id: http://skia.googlecode.com/svn/trunk@12282 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 22:00:11 +00:00
jvanverth@google.com
ef10b71d62 Ignore failures for blurrect_outer (needs rebaselining).
git-svn-id: http://skia.googlecode.com/svn/trunk@12281 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 21:36:30 +00:00
edisonn@google.com
b94c7d5ae8 pdfviewer: seed expectations for Mac 10.8 native renderer
Review URL: https://codereview.chromium.org/61683010

git-svn-id: http://skia.googlecode.com/svn/trunk@12280 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 21:32:12 +00:00
jvanverth@google.com
38ad8f1ff4 Add missing rebaselines for rrect_clip.
git-svn-id: http://skia.googlecode.com/svn/trunk@12279 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 21:23:56 +00:00
jvanverth@google.com
fe11e62064 Ignore Nexus4 failures for complexclip2_path_aa_gpu.
git-svn-id: http://skia.googlecode.com/svn/trunk@12278 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 21:06:30 +00:00
jvanverth@google.com
6a9e0b0d11 Rebaseline and enable GMs: pathopsskpclip roundrects rrect rrect_clip samplerstress
git-svn-id: http://skia.googlecode.com/svn/trunk@12277 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 20:54:49 +00:00
edisonn@google.com
608c35e5c4 pdfviewer: readobject can return null, and catalog can be null
Review URL: https://codereview.chromium.org/72053002

git-svn-id: http://skia.googlecode.com/svn/trunk@12276 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 20:23:40 +00:00
bungeman@google.com
04306921f4 Remove backward compatibility shims from SkStream.h.
R=reed@google.com

Review URL: https://codereview.chromium.org/68773009

git-svn-id: http://skia.googlecode.com/svn/trunk@12275 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 19:53:46 +00:00
jvanverth@google.com
19caf6d41b Rebaseline and enable GMs: convexpaths mixed_xfermodes nested_aa ninepatch-stretch pathfill pathinterior
git-svn-id: http://skia.googlecode.com/svn/trunk@12274 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 19:09:48 +00:00
reed@google.com
3443fd8886 move SkImageInfo into its own header
BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/71813002

git-svn-id: http://skia.googlecode.com/svn/trunk@12273 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 19:09:13 +00:00