A 180 degree rotation matrix is functionally like a scale matrix, but
the elements are negative. To compensate for this, we use abs().
Bug: b/137547660
Change-Id: Ib0e7449872523af024e7de9005b9bb70743e04b5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229394
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Instead we leave color writes enabled and use a blend state that
preserves the dst color. This allows us to re-enable msaa ccpr on
PowerVR.
Bug: skia:
Change-Id: I1e902d695ad483ffb13dff6a7920749e307b49c7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229387
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
They're failing since enabling MSAA configs.
Bug: skia:9271 skia:8523
Change-Id: If2e353b169519d06ce3257fd9e6bfbd2da49983a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229392
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Since it was only called by SkQPActivity.run(), I simply moved the code
into that method.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86-devrel-Android_SKQP,Test-Debian9-Clang-NUC7i5BNK-CPU-Emulator-x86-devrel-All-Android_SKQP
Change-Id: I82ef407dd440fa94e4c01c0f21a76389793ece58
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225177
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
Skia clients shouldn't have to worry about this
Change-Id: I3a1cc191a7d4da88cf23a59cb3043cfb8b868f2c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229382
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Note: I'll follow this up with a separate CL that removes the pixel config
Bug: skia:6718
Change-Id: If069afa95bd51d5d6b24089fd3a8526e4d982820
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228257
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
02407743bd..8bb46c5b9f
git log 02407743bd72..8bb46c5b9ffc --date=short --no-merges --format='%ad %ae %s'
2019-07-23 clemendeng@google.com Refactor: add InternalFormat::isInt()
2019-07-23 jose.dapena@lge.com Do not assume __has_builtin is available
2019-07-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 76b75c40a1e2..3855447d93eb (3 commits)
Created with:
gclient setdep -r third_party/externals/angle2@8bb46c5b9ffc
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
TBR=borenet@google.com
Change-Id: Iec1a667aea1bef790bc396cdb7613941e6196450
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229443
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
- Stop testing Metal-MSAA on our Gen8 Mac. These GPUs are slow and buggy
with MSAA (we already have them disabled on other backends).
- Add Metal bots with the HD615 to get testing on a Gen9 GPU. This
should have better performance and more correct results. Also move the
DDL tests to those machines, to get testing on a newer/faster machine.
- Add MSAA configs to Vulkan and Metal perf bots (except for old Intel).
Bug: skia:9023 skia:8243
Change-Id: I214c6c4ef7b6e1401719e62e29fd5d2ad05b6aa1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229379
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
As written it was hoisting one register per tbl instruction use, which
was both correct and fast, but using more registers than necessary. We
only need one table mask for each unique Op::bytes control value.
Caught this looking at the profile for srcover_i32, which uses each of
two distinct bytes control values twice, once for the src pixel and once
for dst.
Change-Id: I42f8611b23c0258369e8aaadd75fc484d1e9cb35
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229397
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
fix toy square program
add a new toy plus_one program
also run stock srcover programs
time at N=15,255,4095
e.g.
plus_one 69 Mpx/s 435 Mpx/s 615 Mpx/s
square 73 Mpx/s 393 Mpx/s 527 Mpx/s
srcover_f32 19 Mpx/s 38 Mpx/s 39 Mpx/s
srcover_i32 36 Mpx/s 89 Mpx/s 103 Mpx/s
srcover_i32_naive 34 Mpx/s 85 Mpx/s 91 Mpx/s
srcover_i32_SWAR 49 Mpx/s 169 Mpx/s 191 Mpx/s
Change-Id: Ie041603bf1b458472dd477c64a91c61162a362e3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229396
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
This was effectively happening before, but only after we (always) failed
to find an entry without the origin. If we ever have a system that can
determine ahead of time that we won't depend on surface origin, we can
update this logic. For now, just simplify the code and remove the
useless cache lookups.
Change-Id: I2b6178a8a83a48f33fdc066e185a2a4c13aa8ddc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229284
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
This CL is intended to further wean Ganesh off of using the GrBackendTexture's pixel config
TBR=bsalomon@google.com
Bug: skia:6718
Change-Id: Iedaa7811f9c4aac552f219c702627bc476325317
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228338
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Change-Id: I6b24e47849a16ad811894b05331f798262c3cbaa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229283
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Julia Lavrova <jlavrova@google.com>
Bug: skia:9269
Change-Id: I7179c298f7b5ae580889d8fa7e3821fb2408aaad
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229077
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Calling add32 can re-allocate the key storage, so it isn't safe to call
add32n and then keep writing into the returned pointer if an extra
sampler key is encountered.
Also fix the GP sampler key code to actually set the last bit, not the
16th bit.
Change-Id: I9c83435a164ab0391e2e6a9e1a9bdf6839490a15
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229278
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
This leaves just width, height, and GrPixelConfig. Once we remove the
latter we can replace GrSurfaceDesc with SkISize.
Also remove unused GrRenderTarget::overrideResolveRect
Also remove GrSurfaceProxy::Renderable and use GrRenderable instead.
Change-Id: I652fe6169a22ca33d199b144ec6385286ac07b5a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228570
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Adding cache
Caching shaped results
Base+Index for referencing arrays
The very first and naive version of cache
Cache measurement, lines and picture
Added text blob cache for lines
Removed Run* from Cluster
Removed const char* from Cluster and Run
Few minor changes
Change-Id: I444a1defa950aed5999cfa1c3545fd83ccb54ce9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/227840
Commit-Queue: Julia Lavrova <jlavrova@google.com>
Reviewed-by: Julia Lavrova <jlavrova@google.com>
Reviewed-by: Mike Reed <reed@google.com>
9ec3f51d11..02407743bd
git log 9ec3f51d11d9..02407743bd72 --date=short --no-merges --format='%ad %ae %s'
2019-07-22 dongja@google.com Vulkan: implement indirect dispatch
2019-07-22 jmadill@chromium.org Vulkan: Rename 'extents' param to 'glExtents'.
2019-07-22 clemendeng@google.com Implicit conversions for Desktop GL shaders
2019-07-22 ynovikov@chromium.org Skip ProgramBinaryTransformFeedbackTest.GetTransformFeedbackVarying
2019-07-22 jmadill@chromium.org Vulkan: Store VkExtents3D in ImageHelper.
2019-07-22 jmadill@chromium.org Texture: Make ImageIndex store layer counts.
2019-07-22 ynovikov@chromium.org Skip ShaderStorageBufferTest31.ActiveSSBOButNotStaticallyUsed
2019-07-22 syoussefi@chromium.org Vulkan: Atomic counter buffer support
2019-07-22 ynovikov@chromium.org Revert "Reland "Temporarily disable creating D3D debug device.""
2019-07-22 syoussefi@chromium.org Vulkan: Generalize buffers desc set name to include images
2019-07-22 fei.yang@arm.com Vulkan: Intermittent failures in many GLES2 CTS
2019-07-22 jonahr@google.com Port adjust_src_dst_region_for_blitframebuffer workaround to ANGLE.
Created with:
gclient setdep -r third_party/externals/angle2@02407743bd72
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
TBR=borenet@google.com
Change-Id: Ibc366c1a343269d76c0f7a329f6a7514dd8b8aa3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229170
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/c420221f1d94fd0799e9e7aed40928bf1b321a97 [git-cl] Proofread error messages for consistency (qyearsley@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3fa79aa3f5db2a383f1c31496505afcd390e9b4f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229176
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/4a8e453fbda7dde50721b479fa9ca5dd4a65ef50 bot_update: Disable metrics collection for bots, since it's not supported. (ehmaldonado@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie58fda3684b16f23acbedfc5c2fce1f6e97fa004
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229082
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This adds a warmup phase to let each instruction do any setup
it needs, adding lookup entries for splat and bytes, and
on aarch64, hoisting the mask to a register when we can.
Oddly, this measures as a ~3x slowdown on the phone I'm testing, an
international Galaxy S9 with a Samsung Mongoose 3 processor. I've got
to imagine this somehow makes the processor think there's a carried loop
dependency when there is not? Anyway, we already know that that's a
pretty crazy CPU (reports FP16 compute but cannot), and this does deliver
a speedup on the Pixel 2's Kryo 280 / Cortex A73, so I think maybe I'll
just swap back to testing with the Pixel 2 and forget about that S9.
Here's a before/after codelisting with a hoisted tbl mask. In the
before case it's loaded in the loop with `ldr q3, #152`, and becomes
`ldr q0, #168` outside the loop. llvm-mca says this should cut one
cycle per loop, and with optimal out of order execution the loop cost
would drop from ~8.7 cycles to ~8.3. In practice, it looks like about a
15% speedup.
before:
ldr q0, #188
ldr q1, #200
cmp x0, #4 // =4
b.lt #76
ldr q2, [x1]
ldr q3, #152
tbl v3.16b, { v2.16b }, v3.16b
sub v3.8h, v0.8h, v3.8h
ldr q4, [x2]
and v5.16b, v4.16b, v1.16b
ushr v4.8h, v4.8h, #8
mul v5.8h, v5.8h, v3.8h
ushr v5.8h, v5.8h, #8
mul v3.8h, v4.8h, v3.8h
bic v3.16b, v3.16b, v1.16b
orr v3.16b, v5.16b, v3.16b
add v2.4s, v2.4s, v3.4s
str q2, [x2]
add x1, x1, #16 // =16
add x2, x2, #16 // =16
sub x0, x0, #4 // =4
b.al #-76
cmp x0, #1 // =1
b.lt #76
ldr s2, [x1]
ldr q3, #72
tbl v3.16b, { v2.16b }, v3.16b
sub v3.8h, v0.8h, v3.8h
ldr s4, [x2]
and v5.16b, v4.16b, v1.16b
ushr v4.8h, v4.8h, #8
mul v5.8h, v5.8h, v3.8h
ushr v5.8h, v5.8h, #8
mul v3.8h, v4.8h, v3.8h
bic v3.16b, v3.16b, v1.16b
orr v3.16b, v5.16b, v3.16b
add v2.4s, v2.4s, v3.4s
str s2, [x2]
add x1, x1, #4 // =4
add x2, x2, #4 // =4
sub x0, x0, #1 // =1
b.al #-76
ret
after: ldr q0, #168
ldr q1, #180
ldr q2, #192
cmp x0, #4 // =4
b.lt #72
ldr q3, [x1]
tbl v4.16b, { v3.16b }, v0.16b
sub v4.8h, v1.8h, v4.8h
ldr q5, [x2]
and v6.16b, v5.16b, v2.16b
ushr v5.8h, v5.8h, #8
mul v6.8h, v6.8h, v4.8h
ushr v6.8h, v6.8h, #8
mul v4.8h, v5.8h, v4.8h
bic v4.16b, v4.16b, v2.16b
orr v4.16b, v6.16b, v4.16b
add v3.4s, v3.4s, v4.4s
str q3, [x2]
add x1, x1, #16 // =16
add x2, x2, #16 // =16
sub x0, x0, #4 // =4
b.al #-72
cmp x0, #1 // =1
b.lt #72
ldr s3, [x1]
tbl v4.16b, { v3.16b }, v0.16b
sub v4.8h, v1.8h, v4.8h
ldr s5, [x2]
and v6.16b, v5.16b, v2.16b
ushr v5.8h, v5.8h, #8
mul v6.8h, v6.8h, v4.8h
ushr v6.8h, v6.8h, #8
mul v4.8h, v5.8h, v4.8h
bic v4.16b, v4.16b, v2.16b
orr v4.16b, v6.16b, v4.16b
add v3.4s, v3.4s, v4.4s
str s3, [x2]
add x1, x1, #4 // =4
add x2, x2, #4 // =4
sub x0, x0, #1 // =1
b.al #-72
ret
Change-Id: I352a98d3ac2ad84c338330ef4cfae0292a0b32da
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229064
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
This first tries to JIT while hoisting all constants,
and if that fails, tries again hoisting no constants.
I figure this is one of those 80/20 deals for how to
handle constant hoisting and register pressure. This
probably mostly moots doing anything fancy like using
memory operands with AVX or lane operands with NEON.
This _doesn't_ moot hoisting the NEON tbl arguments,
which is not yet done here, but probably my next CL.
Change-Id: Id09d5cdddcdb45207bdfc914a5a3128a481a26f3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229058
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Even if a JIT ultimately doesn't end up hoisting any values, it's going
to want this information while it decides. Writing it in one place also
ensures we only get it wrong in one place...
I'm no_ extending the lifetime of hoisted instructions here in Builder.
That's something to leave to the backend so they have the flexibility of
which of these values to hoist, if any. If they don't hoist, they'll
need to know when the value dies.
Moving this information back here lets the test expectation goldens
reflect the hoist bit again too. Kind of nice.
Change-Id: Ib165ca898a97c1d822cb28fe24f15bae4d570a17
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229024
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
This is useful to avoid redrawing unnecessarily when the animation
doesn't progress.
Bug: skia:9267
Change-Id: Id4184ae8308b8abd959fbfd1768e3e22d1efe0a4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229006
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Change-Id: Ib4b00712f27a47111ea1213d558e975f25eb8347
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229007
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
- shift the revalidation phase from Scene::render() to Scene::animate()
- pass an optional inval controller to Scene::animate() and Animation::seek()
- hoist the showInval logic out of SkSG, into clients
This allows clients to track dirty regions and detect cases where no updates are needed.
Bug: skia:9267
Change-Id: I3d35bf58b6eee9bfeb6e127ba58e2b96713b772d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229001
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>
