commit-bot@chromium.org
8519548693
GM: run mode comparisons for all raster configs.
...
GM works like this today:
- Test all enabled configs directly
- Render into 8888
- Test all enabled modes against that 8888.
This change makes it do this:
- Test all enabled configs directly
- for each config, if it's raster, test all enabled modes against its output.
Upshot is, we now check that picture draws identically to raster for 565 too, not just 8888. optimizations-565 is correctly failing.
BUG=skia:1994
R=epoger@google.com , reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/129203002
git-svn-id: http://skia.googlecode.com/svn/trunk@13050 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 18:27:59 +00:00
bsalomon@google.com
cd9175eddb
remove _gpu suffix from tests in ignored-tests.txt that are changed on all gpu configs (msaa, ...).
...
Review URL: https://codereview.chromium.org/136713005
git-svn-id: http://skia.googlecode.com/svn/trunk@13049 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 18:26:14 +00:00
robertphillips@google.com
a3961374fe
Rebaseline NVPR roundrects images
...
https://codereview.chromium.org/136753004/
git-svn-id: http://skia.googlecode.com/svn/trunk@13048 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 17:15:33 +00:00
commit-bot@chromium.org
439ff1b9ca
Use correct matrix to adjust blur radius for gpu
...
BUG=skia:1998
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/134973002
git-svn-id: http://skia.googlecode.com/svn/trunk@13047 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 16:39:39 +00:00
commit-bot@chromium.org
6077057cae
Remove redundant auto rt object in skpaint2grpaintshader function.
...
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/133763006
git-svn-id: http://skia.googlecode.com/svn/trunk@13046 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 15:57:05 +00:00
bsalomon@google.com
4db7a31678
Remove rects GM from ignored-tests.txt and rebaseline
...
BUG=skia:1882
Review URL: https://codereview.chromium.org/136803002
git-svn-id: http://skia.googlecode.com/svn/trunk@13045 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 15:06:54 +00:00
borenet@google.com
9c80cbeeb0
Add CONTRIBUTING file
...
This will help to direct those who stumble upon the new github mirror
to the proper channels for contributing code.
BUG=
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/134663003
git-svn-id: http://skia.googlecode.com/svn/trunk@13044 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 15:06:26 +00:00
reed@google.com
1a033fb55e
remove (now dead code) for SK_SUPPORT_LEGACY_COLORTYPE and SK_SUPPORT_LEGACY_ALPHATYPE
...
BUG=
Review URL: https://codereview.chromium.org/135033002
git-svn-id: http://skia.googlecode.com/svn/trunk@13043 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 15:04:50 +00:00
reed@google.com
bf0001d047
remove remaining references to Sk64 (obsolete)
...
BUG=
Review URL: https://codereview.chromium.org/136673002
git-svn-id: http://skia.googlecode.com/svn/trunk@13042 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 14:53:55 +00:00
commit-bot@chromium.org
a7d89c83a4
Handle drawBitmapRect src_rect->dst_rect mapping as a local matrix rather than view matrix when there is a mask filter.
...
BUG=skia:1998
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/131323004
git-svn-id: http://skia.googlecode.com/svn/trunk@13041 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 14:47:00 +00:00
robertphillips@google.com
f0a4013467
Yet another patch for r13038
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13040 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 14:13:46 +00:00
robertphillips@google.com
0e4ce14e7f
Fix for r13038
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13039 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 13:46:45 +00:00
robertphillips@google.com
56bf6e4bce
Pull in Chromium's version of GatherPixelRefs
...
https://codereview.chromium.org/134473002/
git-svn-id: http://skia.googlecode.com/svn/trunk@13038 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 13:33:26 +00:00
commit-bot@chromium.org
15ac322aae
Add bench_record.
...
I got fed up trying to figure out how best to measure recording cost with bench_pictures, render_pictures, etc, so I wrote a new tool.
Features welcome.
BUG=
R=tomhudson@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/132573002
git-svn-id: http://skia.googlecode.com/svn/trunk@13037 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 12:03:47 +00:00
commit-bot@chromium.org
c45ece5f7f
NEON fast path for box blur
...
Calculate 8 channels in parallel by using 16-bits to store each channel. Due to the limitation of VQRDMULH, (int16 * int16 * 2 + 0x8000) >> 16, the fast path can only support kernelSize < 128.
8 significant bits are kept at least in each stage, the final error should less-equal than 1.
Pre-fetching memory for X-direction read. In fact pre-fetching memory doesn't help much for Y direction read, since it is a waste to load a cache line for only read 8 bytes.(I left it there to keep the symmetry. pre-fetch is cheap :) )
bench data on Nexus 10
before:
running bench [640 480] blur_image_filter_large_10.00_10.00 8888: cmsecs = 25081.48
running bench [640 480] blur_image_filter_small_10.00_10.00 8888: cmsecs = 25038.04
running bench [640 480] blur_image_filter_large_1.00_1.00 8888: cmsecs = 25209.04
running bench [640 480] blur_image_filter_small_1.00_1.00 8888: cmsecs = 24928.01
running bench [640 480] blur_image_filter_large_0.00_1.00 8888: cmsecs = 17160.98
running bench [640 480] blur_image_filter_large_0.00_10.00 8888: cmsecs = 17924.11
running bench [640 480] blur_image_filter_large_1.00_0.00 8888: cmsecs = 14609.19
running bench [640 480] blur_image_filter_large_10.00_0.00 8888: cmsecs = 14625.91
after:
running bench [640 480] blur_image_filter_large_10.00_10.00 8888: cmsecs = 14848.42
running bench [640 480] blur_image_filter_small_10.00_10.00 8888: cmsecs = 16037.29
running bench [640 480] blur_image_filter_large_1.00_1.00 8888: cmsecs = 14819.55
running bench [640 480] blur_image_filter_small_1.00_1.00 8888: cmsecs = 14563.69
running bench [640 480] blur_image_filter_large_0.00_1.00 8888: cmsecs = 11905.34
running bench [640 480] blur_image_filter_large_0.00_10.00 8888: cmsecs = 11883.85
running bench [640 480] blur_image_filter_large_1.00_0.00 8888: cmsecs = 9576.51
running bench [640 480] blur_image_filter_large_10.00_0.00 8888: cmsecs = 9793.84
BUG=
R=senorblanco@chromium.org , mtklein@google.com , reed@google.com , kevin.petit@arm.com , kevin.petit.arm@gmail.com
Author: zheng.xu@arm.com
Review URL: https://codereview.chromium.org/105893003
git-svn-id: http://skia.googlecode.com/svn/trunk@13036 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 08:16:45 +00:00
tfarina@chromium.org
1b3fea7172
Cleanup: Remove unused includes from skia_unix.cpp
...
This also move gWindow into the main function.
BUG=None
TEST=SampleApp
R=mtklein@google.com
Review URL: https://codereview.chromium.org/133113002
git-svn-id: http://skia.googlecode.com/svn/trunk@13035 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-11 16:42:10 +00:00
commit-bot@chromium.org
7cced56550
merge multiple blurrect GMs into one GM and add versions
...
BUG=skia:1998
R=reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/134533006
git-svn-id: http://skia.googlecode.com/svn/trunk@13034 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 23:10:13 +00:00
tfarina@chromium.org
4ee16bfaed
Add a DEF_GPUTEST() macro.
...
This macro is similar to DEF_TEST() and simplifies the process of
setting up a GPU test.
BUG=skia:1952
TEST=tests
R=mtklein@google.com
Review URL: https://codereview.chromium.org/132293005
git-svn-id: http://skia.googlecode.com/svn/trunk@13033 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 22:08:27 +00:00
reed@google.com
f3abaeb0c5
remove (now unused) Sk64 -- just use int64_t
...
BUG=
Review URL: https://codereview.chromium.org/134373006
git-svn-id: http://skia.googlecode.com/svn/trunk@13032 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 22:05:41 +00:00
commit-bot@chromium.org
cd11018625
Just use one version of the scripts in both the browser and in SkV8 by using feature detection to determine if we are running in a browser, and if the platform supports the Path() object. Also add oval, console.log, and the snow example code.
...
BUG=
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/132413002
git-svn-id: http://skia.googlecode.com/svn/trunk@13031 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 21:33:01 +00:00
borenet@google.com
4d5e1366c9
Fixes to roll_deps for the bots
...
The bots are running an older version of git which does not support the
-q/--quiet flag for branch or the --short flag for symbolic-ref.
BUG=
R=halcanary@google.com
Review URL: https://codereview.chromium.org/134723002
git-svn-id: http://skia.googlecode.com/svn/trunk@13030 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 21:02:25 +00:00
bungeman@google.com
698dfa465c
Add a simple test ttc for FontHost test.
...
BUG=skia:1813
git-svn-id: http://skia.googlecode.com/svn/trunk@13029 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 20:56:21 +00:00
commit-bot@chromium.org
6e83423f16
Eliminate useless NULL push by making fIndexedData 0-based.
...
Depends on http://crrev.com/134223002
Testing: out/Debug/dm && out/Debug/tests && echo ok
BUG=skia:1979
R=dominikg@chromium.org , tomhudson@chromium.org , halcanary@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/134283002
git-svn-id: http://skia.googlecode.com/svn/trunk@13028 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 20:13:09 +00:00
bungeman@google.com
2dc54c94f0
Remove printfs from FontHostTest when font is not sfnt.
...
BUG=skia:2009
R=caryclark@google.com
Review URL: https://codereview.chromium.org/134303002
git-svn-id: http://skia.googlecode.com/svn/trunk@13027 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 19:40:56 +00:00
commit-bot@chromium.org
f85251c74d
fNextIndex is redundant. Remove it.
...
This is warmup for removing the NULL at the front.
Testing: out/Debug/tests && out/Debug/dm && echo ok
BUG=skia:1979
R=dominikg@chromium.org , tomhudson@chromium.org , halcanary@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/134223002
git-svn-id: http://skia.googlecode.com/svn/trunk@13026 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 19:37:00 +00:00
commit-bot@chromium.org
1066f08378
If poppler is disable and native pdf is enabled, we still need SkPDFRasterizer.cpp
...
R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: vandebo@chromium.org
Review URL: https://codereview.chromium.org/133583004
git-svn-id: http://skia.googlecode.com/svn/trunk@13025 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 19:09:00 +00:00
commit-bot@chromium.org
5c6f1d4424
Revert of https://codereview.chromium.org/112113005/
...
Reason for revert: breaks unit tests
R=mtklein@google.com , bsalomon@google.com , reed@google.com , scroggo@google.com
TBR=bsalomon@google.com , mtklein@google.com , reed@google.com , scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:1742
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/134453002
git-svn-id: http://skia.googlecode.com/svn/trunk@13024 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 18:28:23 +00:00
commit-bot@chromium.org
0f7e3470d6
Revert of https://codereview.chromium.org/106563002/
...
Reason for revert: There's a threading issue I don't quite understand yet. Objects are being deleted after we check they're deleted. Will try again.
R=kkinnunen@nvidia.com , kkinnunen@nvidia.com
TBR=kkinnunen@nvidia.com , kkinnunen@nvidia.com
NOTREECHECKS=true
NOTRY=true
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/134363002
git-svn-id: http://skia.googlecode.com/svn/trunk@13023 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 17:58:47 +00:00
commit-bot@chromium.org
f2595e4186
Fix genID cloning bugs.
...
SkBitmap.cpp:
When copyTo calls readPixels, only clone the genID if the resulting
SkPixelRef has the same dimensions as the original. This catches a
bug where copying an SkBitmap representing the subset of an SkPixelRef
(which implements onReadPixels) would result in the copy sharing the
genID. (Thanks to r6710, this case can only happen using setPixelRef,
so the updated GpuBitmapCopyTest checks for that.)
Move some unnecessary NULL checks to asserts.
When copyTo performs a memcpy, only clone the genID if the resulting
SkPixelRef has the same dimensions as the original. This catches a bug
where copying an extracted SkBitmap with the same width as its original
SkPixelRef would incorrectly have the same genID.
Add a comment and assert in deepCopyTo, when cloning the genID, since
that case correctly clones it.
BitmapCopyTest.cpp:
Pull redundant work out of the inner loop (setting up the source bitmaps
and testing extractSubset). Create a new inner loop for extractSubset, to
test copying the result to each different config.
Extract a subset that has the same width as the original, to catch the
bug mentioned above.
Remove the reporter assert which checks for the resulting rowbytes.
Add checks to ensure that copying the extracted subset changes the genID.
GpuBitmapCopyTest:
Create an SkBitmap that shares an existing SkPixelRef, but only represents
a subset. This is to test the first call to cloneGenID in SkBitmap::copyTo.
In this case, the genID should NOT be copied, since only a portion of the
SkPixelRef was copied.
Also test deepCopy on this subset.
TestIndividualCopy now takes a parameter stating whether the genID should
change in the copy. It also does a read back using the appropriate subset.
It no longer differentiates between copyTo and deepCopyTo, since that
distinction was only necessary for copying from/to configs other than 8888
(which are no longer being tested), where copyTo did a read back in 8888 and
then drew the result to the desired config (resulting in an imperfect copy).
BUG=skia:1742
R=mtklein@google.com , bsalomon@google.com , reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/112113005
git-svn-id: http://skia.googlecode.com/svn/trunk@13021 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 17:22:01 +00:00
commit-bot@chromium.org
4a8e17d52d
remove poplar building from mac, until it is fixed
...
BUG=skia:2008
R=mtklein@google.com , vandebo@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/134243002
git-svn-id: http://skia.googlecode.com/svn/trunk@13020 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 17:21:00 +00:00
commit-bot@chromium.org
2b8aacba52
Delete all invalidated resources with same key
...
Delete all invalidated resources with same key instead of deleting
just the first resource.
R=mtklein@google.com , kkinnunen@nvidia.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/106563002
git-svn-id: http://skia.googlecode.com/svn/trunk@13019 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 16:39:20 +00:00
robertphillips@google.com
7095607705
Suppressing imagefiltersbase_gpu on RHB device
...
https://codereview.chromium.org/134093002/
git-svn-id: http://skia.googlecode.com/svn/trunk@13018 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 15:28:19 +00:00
halcanary@google.com
2d1adf2322
Reduce verbosity of SkGraphics::Init in default case.
...
SkGraphics::Init() now checks to see if there are any non-default
runtime configuration options before announcing that it is about
to print out the non-default runtime configuration options.
This makes the executables in tools/ less verbose.
Add SkRTConfRegistry::countNonDefault() function.
BUG=
R=mtklein@google.com , reed@google.com
Review URL: https://codereview.chromium.org/133583003
git-svn-id: http://skia.googlecode.com/svn/trunk@13017 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 15:00:45 +00:00
halcanary@google.com
a9325fa237
Add REPORTF test macro.
...
This macro replaces:
SkString str;
str.printf("Foo test Expected %d got %d", x, y);
reporter->reportFailed(str);
with the shorter code:
REPORTF(reporter, ("Foo test Expected %d got %d", x, y));
The new form also appends __FILE__:__LINE__ to the message before calling reportFailed().
BUG=
R=mtklein@google.com
Review URL: https://codereview.chromium.org/132843002
git-svn-id: http://skia.googlecode.com/svn/trunk@13016 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 14:58:10 +00:00
halcanary@google.com
9acb8cdf20
SampleApp Cleanup:
...
- Set resoursePath to sensible default.
- Remove verbosity of DitherBitmap.
- SampleEncode no longer tries to mkdir('/encoded'), now stores
encoded data in memory and uses the SkDecodingImageGenerator
to decode.
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/132513003
git-svn-id: http://skia.googlecode.com/svn/trunk@13015 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 14:53:49 +00:00
robertphillips@google.com
6791138dc0
Suppress imagefiltersgraph_msaa4 failure on Nexus10
...
https://codereview.chromium.org/133643003/
git-svn-id: http://skia.googlecode.com/svn/trunk@13011 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 13:50:23 +00:00
skia.committer@gmail.com
856673a816
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13008 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 07:08:11 +00:00
commit-bot@chromium.org
83f56922e2
Fix Mac fontconfig build (try 2)
...
The Mac fontconfig just #defines the cache directory, which works fine if fontconfig never has to look up any fonts (the case until now). If it has to actually find fonts from the disk, the cache directory and config directory need to be properly defined as well as running fc-cache to populate the cache directory.
Populating the cache directory can take some time, but should only happen on a clean build. To remove this extra time, we have to not build poppler on Mac, which can now be accomplished with GYP_DEFINES="skia_mac_poppler=0"
R=epoger@google.com
Author: vandebo@chromium.org
Review URL: https://codereview.chromium.org/132333002
git-svn-id: http://skia.googlecode.com/svn/trunk@13007 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 22:54:26 +00:00
borenet@google.com
6f0f5b4aad
Remove references to Skia's SVN repository
...
BUG=
R=epoger@google.com
Review URL: https://codereview.chromium.org/132423002
git-svn-id: http://skia.googlecode.com/svn/trunk@13006 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 21:41:39 +00:00
reed@google.com
2e0f1ee593
remove bad gm expected images
...
BUG=skia:1986
R=epoger@google.com
Review URL: https://codereview.chromium.org/132023005
git-svn-id: http://skia.googlecode.com/svn/trunk@13004 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 21:05:59 +00:00
reed@google.com
303c4758ec
use bitmap's fRowBytes, as the pixelref's is not (yet) reliable
...
should fix linux browser_tests for DEPS roll
BUG=
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/132273004
git-svn-id: http://skia.googlecode.com/svn/trunk@13002 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 20:00:14 +00:00
robertphillips@google.com
fe5824af29
Fix for Mac-specific compilation issue in r13000
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13001 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 19:45:29 +00:00
robertphillips@google.com
ed9866cc8a
Expand GatherPixelRefs unit test
...
https://codereview.chromium.org/132293002/
git-svn-id: http://skia.googlecode.com/svn/trunk@13000 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 19:20:45 +00:00
commit-bot@chromium.org
88e1ec84d0
Add 565 to dm defaults.
...
Now that optimizations picture modes pass (are skipped) in 565, add 565 to the default configs DM runs.
BUG=skia:1994
R=bsalomon@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/132133002
git-svn-id: http://skia.googlecode.com/svn/trunk@12999 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 19:14:57 +00:00
bsalomon@google.com
2b199e6d4d
Mark imagefiltersgraph, IntelRhb, msaa4 config as ignore failure due to garbage on bottom line.
...
BUG=skia:2005
Review URL: https://codereview.chromium.org/132303002
git-svn-id: http://skia.googlecode.com/svn/trunk@12998 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 17:59:55 +00:00
commit-bot@chromium.org
32eea431de
Revert of https://codereview.chromium.org/113203003/
...
Reason for revert: Broken under XCode.
R=bungeman@google.com , epoger@google.com
TBR=bungeman@google.com , epoger@google.com
NOTREECHECKS=true
NOTRY=true
Author: vandebo@chromium.org
Review URL: https://codereview.chromium.org/132093003
git-svn-id: http://skia.googlecode.com/svn/trunk@12997 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 17:52:54 +00:00
commit-bot@chromium.org
2b0f7c321c
Convert Checksum test to DEF_TEST() macro.
...
BUG=None
TEST=tests
R=mtklein@google.com , bungeman@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/126743003
git-svn-id: http://skia.googlecode.com/svn/trunk@12996 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 17:48:48 +00:00
senorblanco@chromium.org
857e320300
Use truncation, not rounding, when converting perlin noise seed (required by SVG spec).
...
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/132053002
git-svn-id: http://skia.googlecode.com/svn/trunk@12995 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 17:41:42 +00:00
commit-bot@chromium.org
9a907fa0d3
Fix Mac fontconfig build
...
The Mac fontconfig just #defines the cache directory, which works fine if fontconfig never has to look up any fonts (the case until now). If it has to actually find fonts from the disk, the cache directory and config directory need to be properly defined as well as running fc-cache to populate the cache directory.
Populating the cache directory can take some time, but should only happen on a clean build. To remove this extra time, we have to not build poppler on Mac, which can now be accomplished with GYP_DEFINES="skia_mac_poppler=0"
R=bungeman@google.com , epoger@google.com
Author: vandebo@chromium.org
Review URL: https://codereview.chromium.org/113203003
git-svn-id: http://skia.googlecode.com/svn/trunk@12994 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 17:37:38 +00:00
bungeman@google.com
18b75e54ab
Fix race on creating the default typeface.
...
BUG=skia:1906
R=mtklein@google.com , reed@google.com
Review URL: https://codereview.chromium.org/113543005
git-svn-id: http://skia.googlecode.com/svn/trunk@12993 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 17:13:32 +00:00