borenet@google.com
6fb7756959
If a user requests a try on "all" builders, ask for confirmation
...
Addresses https://code.google.com/p/skia/issues/detail?id=1208
(SkipBuildbotRuns)
R=epoger@google.com
Review URL: https://codereview.chromium.org/18190006
git-svn-id: http://skia.googlecode.com/svn/trunk@10049 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-12 18:11:04 +00:00
robertphillips@google.com
cfe8aa6f56
More valgrind suppressions
...
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10048 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-12 17:29:30 +00:00
epoger@google.com
c824c83ec1
gm: since we don't record output of gpudebug test, don't record checksums either
...
BUG=https://code.google.com/p/skia/issues/detail?id=1410
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/19096012
git-svn-id: http://skia.googlecode.com/svn/trunk@10046 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-12 15:52:59 +00:00
zachr@google.com
1bc995e68c
modularize the display of diffs for skpdiff
...
R=djsollen@google.com
Review URL: https://codereview.chromium.org/18925004
git-svn-id: http://skia.googlecode.com/svn/trunk@10044 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-12 13:39:53 +00:00
djsollen@google.com
cfe3c11c76
Revert "switch all the arm7 devices to build with thumb for a while"
...
This reverts r10028 which has altered the GM expectations.
R=caryclark@google.com
Review URL: https://codereview.chromium.org/18762006
git-svn-id: http://skia.googlecode.com/svn/trunk@10043 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-12 13:31:51 +00:00
epoger@google.com
585f89a8fe
rebaseline.py: until we fix bug 1410, keep going if we can't download an actual GM result
...
Review URL: https://codereview.chromium.org/19096007
git-svn-id: http://skia.googlecode.com/svn/trunk@10037 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-12 12:32:32 +00:00
skia.committer@gmail.com
ebed410ac7
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10033 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-12 07:01:14 +00:00
robertphillips@google.com
2cab8f7573
More valgrind suppressions
...
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10031 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 23:49:56 +00:00
commit-bot@chromium.org
ef284a84f5
The two leaks are:
...
missing unrefs in megalooper GM
missing reset capability in oval renderer
This CL also expands the instance counting system to some recently adding classes (e.g., SkFontStyleSet)
R=bsalomon@google.com , jvanverth@google.com
Author: robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/18461007
git-svn-id: http://skia.googlecode.com/svn/trunk@10030 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 22:29:29 +00:00
senorblanco@chromium.org
40ea172f1e
Initialize the matrix used when recursing from a GPU image filter -> raster image filter.
...
BUG=
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/5636027884503040
git-svn-id: http://skia.googlecode.com/svn/trunk@10029 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 20:50:10 +00:00
commit-bot@chromium.org
d411681868
switch all the arm7 devices to build with thumb for a while
...
BUG=
R=djsollen@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/18563004
git-svn-id: http://skia.googlecode.com/svn/trunk@10028 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 20:28:38 +00:00
humper@google.com
523521c6bc
reenable the scale benchmark, and only bench actual canvas draw commands
...
instead of direct invocations of the (now private) bitmap scale method
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/18941009
git-svn-id: http://skia.googlecode.com/svn/trunk@10027 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 20:28:30 +00:00
commit-bot@chromium.org
0a5699ee48
ARM Skia NEON patches - 13 - S32A_Opaque
...
Blitrow32: S32A_Opaque code cleaning and speed improvement
- the old way of calculating alpha doesn't seem to be used anymore,
so remove the remaining code
- adding prefetching allows to improve performance greatly in some
cases at the expense of a little trade-off:
+-------+-----------+------------+
| count | Cortex-A9 | Cortex-A15 |
+-------+-----------+------------+
| 1,2 | 0 | 0 |
+-------+-----------+------------+
| 4 | 0 | -3% |
+-------+-----------+------------+
| 8 | 0 | -4% |
+-------+-----------+------------+
| 16 | 0 | -5% |
+-------+-----------+------------+
| 64 | +14% | 0 |
+-------+-----------+------------+
| 256 | +14% | +12% |
+-------+-----------+------------+
| 1024 | +115% | +15% |
+-------+-----------+------------+
BUG=
R=djsollen@google.com
Author: kevin.petit.arm@gmail.com
Review URL: https://chromiumcodereview.appspot.com/18459008
git-svn-id: http://skia.googlecode.com/svn/trunk@10026 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 20:28:24 +00:00
epoger@google.com
66ba9f978f
rebaseline.py: skip any platforms we don't have actual results for, with warning message
...
R=borenet@google.com
Review URL: https://codereview.chromium.org/19052007
git-svn-id: http://skia.googlecode.com/svn/trunk@10022 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 19:20:30 +00:00
borenet@google.com
e2b9037c40
Disable soft floating point on ChromeOS
...
Should fix the Daisy build.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/18812006
git-svn-id: http://skia.googlecode.com/svn/trunk@10020 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 18:46:30 +00:00
borenet@google.com
fa05719ce2
Make ChromeOS build exit nonzero on failure
...
R=djsollen@google.com
Review URL: https://codereview.chromium.org/18621004
git-svn-id: http://skia.googlecode.com/svn/trunk@10018 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 18:11:56 +00:00
borenet@google.com
6dd1545ae9
Add script to verify that image files exist for every actual_result checksum
...
Should help with https://code.google.com/p/skia/issues/detail?id=1410
(SkipBuildbotRuns)
R=epoger@google.com
Review URL: https://codereview.chromium.org/18743006
git-svn-id: http://skia.googlecode.com/svn/trunk@10017 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 18:05:25 +00:00
epoger@google.com
c28732b4d0
check JSON-format expectations into experimental/ for manual testing
...
Review URL: https://codereview.chromium.org/19052006
git-svn-id: http://skia.googlecode.com/svn/trunk@10016 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 17:51:26 +00:00
fmalita@google.com
d3ae1d6231
SkObjectParser::SaveFlagsToString() should handle SaveFlags as a bitmask.
...
Test one SaveFlags bit at a time instead of exploring the whole value space.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/18034028
git-svn-id: http://skia.googlecode.com/svn/trunk@10014 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 16:25:55 +00:00
edisonn@google.com
6a9d436260
pdfviewer: add option to run the load or render multiple times, --benchLoad, --benchRender
...
Review URL: https://codereview.chromium.org/18093008
git-svn-id: http://skia.googlecode.com/svn/trunk@10013 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 16:25:51 +00:00
edisonn@google.com
de36b69481
fix build break on sample app
...
Review URL: https://codereview.chromium.org/19000005
git-svn-id: http://skia.googlecode.com/svn/trunk@10011 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 15:40:31 +00:00
edisonn@google.com
444e25a66b
add ability to specify the DPI at which to render the page
...
Review URL: https://codereview.chromium.org/19000004
git-svn-id: http://skia.googlecode.com/svn/trunk@10009 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 15:20:50 +00:00
edisonn@google.com
1310238d82
pdfviewer: render in the same way regadless if we write the result to a file or not.
...
Review URL: https://codereview.chromium.org/18503013
git-svn-id: http://skia.googlecode.com/svn/trunk@10008 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 14:50:12 +00:00
edisonn@google.com
d1a874aaa8
(unreviewed) sample app: fix break in pdf viewer (podofo was replaced by native parser)
...
Review URL: https://codereview.chromium.org/18507004
git-svn-id: http://skia.googlecode.com/svn/trunk@10007 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 14:45:20 +00:00
edisonn@google.com
15b1118203
pdfviewer: some code cleanup in renderer
...
Review URL: https://codereview.chromium.org/18093005
git-svn-id: http://skia.googlecode.com/svn/trunk@10006 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 14:43:15 +00:00
edisonn@google.com
f8b6b01d51
Add an option to have a PdfViewer in SampleApp. Add a parameter --pdfDir to pass the dir with pdfs. Add flag --sort to sort samples acording to title, so foo.skp follows foo.pdf and we can quickly compare diffs.
...
The option needs to be enabled manually by developer to be compiled locally, since the pdf viewer is work in progress.
R=reed@google.com
Review URL: https://codereview.chromium.org/17904006
git-svn-id: http://skia.googlecode.com/svn/trunk@10004 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 14:28:04 +00:00
commit-bot@chromium.org
0c4e21da95
Streamline picture_record_recurring_ bench.
...
Reduce benchmark runtime from ~17 ms to ~13.25ms by moving SkPaint
construction out of the inner loop and by using random colors in the
SkPaints instead of sequential integers, which were seeing bad hashing.
This doesn't actually improve our performance, but makes the benchmark
more focused on pure recording costs.
BUG=
R=mtklein@google.com , reed@google.com , tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18119011
git-svn-id: http://skia.googlecode.com/svn/trunk@10003 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 14:26:09 +00:00
commit-bot@chromium.org
ab4098b4d3
add _thumb variants for arm devices
...
BUG=
R=djsollen@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/19024002
git-svn-id: http://skia.googlecode.com/svn/trunk@10001 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 13:57:29 +00:00
humper@google.com
9d5fedc5a6
add newline to bitmap rotation script output
...
BUG=
Review URL: https://codereview.chromium.org/18071007
git-svn-id: http://skia.googlecode.com/svn/trunk@10000 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 13:53:44 +00:00
edisonn@google.com
7b328fddf9
pdfviewer: add --pages arg: render a certain page (all, all in desceding order, firsl, last and by page number)
...
Review URL: https://codereview.chromium.org/18584010
git-svn-id: http://skia.googlecode.com/svn/trunk@9999 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 12:53:06 +00:00
commit-bot@chromium.org
183f7f56b8
ARM Skia NEON patches - 10 - ARM build
...
ARM-Build: make Linux arm/NEON builds possible
This factorizes the definitions common to Linux & assimilated
and Android. It also enables to do native builds on Linux for
ARM processors.
BUG=
R=djsollen@google.com , borenet@google.com
Author: kevin.petit.arm@gmail.com
Review URL: https://chromiumcodereview.appspot.com/18243007
git-svn-id: http://skia.googlecode.com/svn/trunk@9997 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 12:48:14 +00:00
edisonn@google.com
a5aaa7998f
pdfviewer: measure mem usage, command line flags library.
...
Review URL: https://codereview.chromium.org/18562010
git-svn-id: http://skia.googlecode.com/svn/trunk@9996 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 12:27:21 +00:00
rmistry@google.com
76d119279e
Add safesync_url to build-tot-chromium.sh
...
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/18429006
git-svn-id: http://skia.googlecode.com/svn/trunk@9993 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 11:28:41 +00:00
skia.committer@gmail.com
de2e4e8a64
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9992 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 07:01:01 +00:00
robertphillips@google.com
31a40ef58b
Win7/8 compiler warnings/errors fix for r9980
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9991 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-11 00:01:39 +00:00
edisonn@google.com
8bad7375d7
pdfviewer: ignore more bad stauff in pdfs
...
Review URL: https://codereview.chromium.org/18112023
git-svn-id: http://skia.googlecode.com/svn/trunk@9990 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 23:36:56 +00:00
edisonn@google.com
c8b3037eeb
pdfviewer: don't delete variables, they are managed by the doc now
...
Review URL: https://codereview.chromium.org/18435010
git-svn-id: http://skia.googlecode.com/svn/trunk@9989 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 23:26:54 +00:00
edisonn@google.com
951d6532de
pdfviewer: more load references dinamically plumming
...
Review URL: https://codereview.chromium.org/18536014
git-svn-id: http://skia.googlecode.com/svn/trunk@9988 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 23:17:31 +00:00
edisonn@google.com
432640ae0b
pdfviewer: don't crash when trailer is missing
...
Review URL: https://codereview.chromium.org/19027003
git-svn-id: http://skia.googlecode.com/svn/trunk@9987 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 22:53:40 +00:00
humper@google.com
2815c19c4d
add matrix objects to the lua bindings, as well as a lua script to find the proportion of image draw commands with different kinds of matrices
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9986 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 22:42:30 +00:00
edisonn@google.com
cdad30b35a
pdfviewer: fix bug, page -1 means render page 0 with no page extension
...
Review URL: https://codereview.chromium.org/18660009
git-svn-id: http://skia.googlecode.com/svn/trunk@9985 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 22:37:38 +00:00
humper@google.com
a8fc2680bb
fix 64 bit warnings
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9984 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 22:34:05 +00:00
edisonn@google.com
222382b30a
pdf viewer: refactor, add -w parameter to pdfviewer, add -n to remove extenassion page when there is a single page (so skdiff can be run easily) and fix a bug (SkPdfobject should not reset on destruct)
...
Review URL: https://codereview.chromium.org/18435007
git-svn-id: http://skia.googlecode.com/svn/trunk@9983 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 22:33:10 +00:00
humper@google.com
5857e0350d
remove unused variables
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9982 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 22:21:03 +00:00
reed@google.com
c1a8684a47
use SkIntToScalar
...
BUG=
R=senorblanco@chromium.org
Review URL: https://codereview.chromium.org/18622004
git-svn-id: http://skia.googlecode.com/svn/trunk@9981 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 21:51:47 +00:00
humper@google.com
87fbf4fc73
fix bug with awesome filtered images sometimes being slightly offset.
...
BUG=
Review URL: https://codereview.chromium.org/19013004
git-svn-id: http://skia.googlecode.com/svn/trunk@9980 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 21:49:29 +00:00
reed@google.com
2956387916
add paint:getEffects to return table of bools of a given effect is present on the paint
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9978 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 21:23:49 +00:00
commit-bot@chromium.org
7b320703d4
Implement offset for GPU filter path. Although we can't yet use this in Blink for FEOffset, due to SVG semantics, we can use it to support crop rect (upcoming patch).
...
This patch adds the parameter to the filterImageGPU() signature, plumbs through the code on the GPU side, and implements support for it in SkXfermodeImageFilter for both raster and GPU.
Of the remaining filters with GPU implementations, Blur, Morphology, Bicubic and Displacement work fine; they're commutative wrt offset and can simply pass it up the chain. Blend is not, but will be removed shortly anyway (has been replaced with SkXfermodeImageFilter in Blink).
R=reed@google.com , bsalomon@google.com
Author: senorblanco@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15995026
git-svn-id: http://skia.googlecode.com/svn/trunk@9977 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 21:22:18 +00:00
commit-bot@chromium.org
b446fc7f05
Remove SkRasterClip::setPath(const SkPath&, const SkRasterClip&, bool).
...
The method is only used in SkCanvas::clipPathHelper() and only called when isRect() is true (which effectively disables the !isBW branch).
Thus, we can promote the isBW branch to the caller and drop the rest of the method.
R=reed@google.com
Author: fmalita@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18552004
git-svn-id: http://skia.googlecode.com/svn/trunk@9974 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 20:55:39 +00:00
commit-bot@chromium.org
e81d1bce7e
don't leak the bitmap filter
...
BUG=
R=reed@google.com
Author: humper@google.com
Review URL: https://chromiumcodereview.appspot.com/18999005
git-svn-id: http://skia.googlecode.com/svn/trunk@9973 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-10 20:42:12 +00:00