Commit Graph

55920 Commits

Author SHA1 Message Date
skia-autoroll
7548ac0f72 Roll SK Tool from 01bc5f924777 to 1e4c97212117
https://skia.googlesource.com/buildbot.git/+log/01bc5f924777..1e4c97212117

2021-07-01 borenet@google.com [autoroll] Switch re2 and pdfium rollers to use main branch
2021-07-01 jcgregorio@google.com Use switchboard/cleanup in machineserver.
2021-07-01 lovisolo@google.com [bazel] //.bazelrc: Add comment about read-only access to the RBE remote cache from dev workstations.
2021-07-01 lovisolo@google.com [bazel] Drop rbe_autoconfig workspace rule. Use rbe_configs_gen CLI.
2021-07-01 lovisolo@google.com [bazel] Add file //.bazelversion.
2021-06-30 jcgregorio@google.com Add /machine/go/switchboard/cleanup.
2021-06-30 jcgregorio@google.com Assert all the mocks for targetconnect.
2021-06-30 jcgregorio@google.com Add pubsub.EnsureNotEmulator().
2021-06-30 borenet@google.com [autoroll] Another fix for rebase
2021-06-30 jcgregorio@google.com Make TestSingleStep_KeepAliveMeetingPointGetsCalledMultipleTimes_Returns more robust.
2021-06-30 kjlubick@google.com [machineserver] Fix missing assignment
2021-06-30 jcgregorio@google.com [machineserver] Moved to embedded configs.
2021-06-30 rmistry@google.com [skcq] Add config reader and skcq config
2021-06-30 rmistry@google.com Add skcq/go/footers/BUILD.bazel
2021-06-30 rmistry@google.com [skcq] Add codereview interface and impl for SkCQ callers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: kjlubick@google.com
Change-Id: I89c604672c16a739f10478555db24b52668756e6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423938
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-01 15:31:18 +00:00
Robert Phillips
1a82a4ea49 Remove GrResourceProvider.h from all other header files
According to
https://commondatastorage.googleapis.com/chromium-browser-clang/include-analysis.html
these account for 583,146,886 bytes of input to the compiler, or roughly
0.25% of the input used to build Chrome.

Bug: chromium:242216
Change-Id: I2d5b73db770dba296df18c02a251da21e82b9ec0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423836
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2021-07-01 15:25:14 +00:00
Kevin Lubick
2cd8067113 [fiddle] Add PRESUBMIT rule to run tools/fiddle/make_all_examples_cpp.py
It will run this only if it detected a change to docs/examples
and runs fairly quickly.

Hopefully it avoids future bitrot like:
https://skia-review.googlesource.com/c/skia/+/423956

Change-Id: I8c6a54faa3a14dfb53260e03d4e6cc61e84b76cc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423976
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2021-07-01 15:20:57 +00:00
Kevin Lubick
2d1b7165a4 [fiddle] Update named fiddles
//tools/fiddle/make_all_examples_cpp.py had not run in a while, so
some of these fiddles were not being compiled regularly and bit-rotted.

A follow-up CL will try running that script as a presubmit.

Change-Id: Ib851cb5d70485e354de3388abf56666492335d46
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423956
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-07-01 15:20:14 +00:00
Ben Wagner
e55c5872a7 Correct failure return for GrMtlGpu::clearTexture
GrMtlGpu::clearTexture returns bool. The Chromium compile complains
about returning nullptr instead.

Change-Id: I27d70fbe75edf7ba172ea8e63843cfaf7b93cac3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423996
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2021-07-01 15:13:19 +00:00
Brian Osman
4a77813008 Convert GrConfigConversionEffect to a runtime FP
Change-Id: I7f22447cf3356b1558d73665ff3e9b61639ebe83
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423576
Auto-Submit: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-07-01 14:35:33 +00:00
Mike Reed
569f29da86 Only trigger serializing blender if it isn't a mode
Change-Id: I9f9cf7f92232c365538f3dd29df226933827771c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423582
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-01 13:32:53 +00:00
Brian Osman
043f010bd1 Make a dedicated (non-runtime) FP for turning on high-precision mode
I'm about to convert GrConfigConversionEffect to GrSkSLFP, and this
seemed like a better solution that adding special flags used in one
spot.

Change-Id: I6720411e9915e76c8f2c75d2b99ca746ceaaa597
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423516
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-07-01 13:18:23 +00:00
Greg Daniel
34b52bf634 Revert "Metal: Add labels and debug groups to help with GPU Debugging."
This reverts commit 9e583bfa3f.

Reason for revert: breaking flutter, needs available checks

Original change's description:
> Metal: Add labels and debug groups to help with GPU Debugging.
>
> * Adds SK_ENABLE_MTL_DEBUG_INFO to enable labels and debug groups,
>   dependent on skia_enable_gpu_debug_layers.
>
> Bug: skia:12150
> Change-Id: I5b4538c0f6df6ceed72d7e8e6f1952fd193b7b90
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422756
> Commit-Queue: Jim Van Verth <jvanverth@google.com>
> Reviewed-by: Greg Daniel <egdaniel@google.com>

TBR=egdaniel@google.com,jvanverth@google.com,chinmaygarde@google.com

Change-Id: I62deacb3527dc709fa8bb8c9f4631e523eae27f0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:12150
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423816
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2021-07-01 11:59:55 +00:00
skia-autoroll
11dd57aeb7 Roll ANGLE from a8959a9b56b4 to dba2e1361d2d (6 revisions)
a8959a9b56..dba2e1361d

2021-07-01 gert.wollny@collabora.com Capture/Replay: Emit InitializeReplay() late
2021-06-30 matled@google.com Fix markdown link
2021-06-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 9fa02d6ab07f to 5e375439542a (4 revisions)
2021-06-30 syoussefi@chromium.org Vulkan: Disable GL_KHR_texture_compression_astc_sliced_3d
2021-06-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from a3726e06b4f1 to 9c5d0d73e2f3 (2 revisions)
2021-06-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 1078c63704e4 to 20cc6c3bb504 (842 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: bungeman@google.com
Change-Id: I1e538ccafdbaa1daa2f65414b0533858b0d5b4fa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423662
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-01 05:01:53 +00:00
skia-autoroll
255eeb7ff6 Roll Chromium from 20cc6c3bb504 to 6083e24534e3 (390 revisions)
20cc6c3bb5..6083e24534

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: bungeman@google.com
Change-Id: If5fc9c8fa030031c220c9fbb55c945be65905c03
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423659
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-01 04:59:53 +00:00
skia-autoroll
6736762913 Roll Dawn from 3d5402c0a4a0 to 2b1b14527d03 (27 revisions)
https://dawn.googlesource.com/dawn.git/+log/3d5402c0a4a0..2b1b14527d03

2021-07-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from d18f2e0d6ee6 to d4c64af11783 (17 revisions)
2021-07-01 kainino@chromium.org Remove null-deref in test
2021-06-30 sergey.ext@gmail.com CMake: update backend selection
2021-06-30 bclayton@google.com Remove all use of deprecated tint APIs and WGSL syntax
2021-06-30 pkasting@chromium.org Fix -Wunreachable-code-aggressive.
2021-06-30 cwallez@chromium.org Metal: make (robustness AND tint) => vertex pulling
2021-06-29 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 077fe64b11b9 to d18f2e0d6ee6 (11 revisions)
2021-06-29 enga@chromium.org Remove double test instantiation with/without use_tint_generator
2021-06-29 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from cb0309ed6c05 to 077fe64b11b9 (8 revisions)
2021-06-29 cwallez@chromium.org Add missing WebGPU limits to Constants.h
2021-06-29 hao.x.li@intel.com Implement zero-sized QuerySet
2021-06-29 sergey.ext@gmail.com Fix examples linking error when building with CMake
2021-06-29 yunchao.he@intel.com Implement 3D texture sampling with e2e tests
2021-06-29 sarahmashay@google.com Update compute shaders tests to include workgroup_size
2021-06-28 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from f24b37e12257 to cb0309ed6c05 (4 revisions)
2021-06-28 enga@chromium.org Remove explicit test instantiation with use_tint_generator
2021-06-28 sergey.ext@gmail.com Fix compilation error when building with CMake and Clang
2021-06-28 bajones@chromium.org Deprecated StoreOp::Clear in favor of Discard
2021-06-28 shrekshao@google.com Add placeholder virtual functions to dawn_wire Read/WriteHandle
2021-06-28 cwallez@chromium.org CopyTextureForBrowser(): Fix macro declaration
2021-06-28 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 67993b955eea to f24b37e12257 (5 revisions)
2021-06-28 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from c03a09c10656 to 67993b955eea (1 revision)
2021-06-28 bclayton@google.com common: RefBase fixes and improvements
2021-06-28 cwallez@chromium.org dawn_native: Add a force_wgsl_step toggle.
2021-06-28 jrprice@google.com Enable testing of Metal with Tint MSL generator
2021-06-28 jrprice@google.com Add missing structure padding to test
2021-06-28 cjj19970505@live.cn CMake: couple fixes for UWP

Also rolling transitive DEPS:
  https://dawn.googlesource.com/tint from c03a09c10656 to d4c64af11783

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC sarahmashay@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: sarahmashay@google.com
Change-Id: Ifb8e2e78457a722432fe073e00500a343f87002e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423661
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-01 04:56:13 +00:00
skia-autoroll
92bb5f53f1 Roll SwiftShader from 9c5d0d73e2f3 to 1231b445b902 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/9c5d0d73e2f3..1231b445b902

2021-06-30 capn@google.com Disable the legacy OpenGL ES targets for Android

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: bungeman@google.com
Change-Id: I972f3b712ec98434168f90906360ceace40680c9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423660
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-01 04:49:53 +00:00
Sarah
69a378c8a9 fix tint roll - enable tint_build_wgsl_writer
Change-Id: I2e657a61fbe614dcf2d8dee0b899f7b826d20280
Bug: dawn:706
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423116
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Sarah Mashayekhi <sarahmashay@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2021-07-01 00:32:40 +00:00
Brian Osman
eaa76b9de0 Replace mask blur FPs with GrSkSLFP
Change-Id: Ie257eca4357b7ab66845af046329ad89857cdaa5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423025
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2021-06-30 22:56:41 +00:00
Jim Van Verth
9e583bfa3f Metal: Add labels and debug groups to help with GPU Debugging.
* Adds SK_ENABLE_MTL_DEBUG_INFO to enable labels and debug groups,
  dependent on skia_enable_gpu_debug_layers.

Bug: skia:12150
Change-Id: I5b4538c0f6df6ceed72d7e8e6f1952fd193b7b90
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422756
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2021-06-30 22:48:41 +00:00
Tyler Denniston
1700f865c5 Revert "Omit inner join geometry when possible"
This reverts commit 1b0a95e0ee.

Reason for revert: breaking g3, other downstream expectations

Original change's description:
> Omit inner join geometry when possible
>
> There is some relatively cheap math we can do to determine easy cases
> when the inner join geometry can be skipped. This CL is not
> comprehensive in that there may be other cases where we can skip the
> geometry.
>
> Only handling miter joins in this CL - the other join types can likely
> have similar logic, but will require a bit more computation to compute
> the inner (reflected) miter point.
>
> Misc notes:
> - Added SK_LEGACY_INNER_JOINS ifdef in the event that clients depend on
>   the old behavior.
> - Modified stroker to track "previous previous" point, which is the
>   start point of the previous line segment.
>
> Bug: b/165379671, skia:11964
> Change-Id: I56789e85a2b4627c32f2a30fe60e47d448e9adf3
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/404717
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Tyler Denniston <tdenniston@google.com>

TBR=reed@google.com,tdenniston@google.com

Change-Id: I812b39a327606b094cd22fb04b8765afc60ac722
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/165379671, skia:11964
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423583
Reviewed-by: Tyler Denniston <tdenniston@google.com>
Commit-Queue: Tyler Denniston <tdenniston@google.com>
2021-06-30 21:29:19 +00:00
Robert Phillips
36a5dffa6f Revert "Clear the tile backend textures when drawing DDLs"
This reverts commit 0734c6223c.

Reason for revert: This was fixing the symptom and not the disease

Original change's description:
> Clear the tile backend textures when drawing DDLs
>
> It appears that the flutter SKPs don't contain an initial clear so the background can be random noise.
>
> This only appears to be an issue for the Metal backend.
>
> Change-Id: I4f5c823cdb1a0a76c0704d4d48355c3a0ed75d43
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423316
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>

TBR=robertphillips@google.com,reed@google.com,michaelludwig@google.com

Change-Id: Iaa52a66248cef2896fc310ee199c3cef7029e532
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423581
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-06-30 20:10:30 +00:00
skia-autoroll
d650c1f5e5 Roll SwiftShader from 964b9e39e44a to 9c5d0d73e2f3 (3 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/964b9e39e44a..9c5d0d73e2f3

2021-06-29 capn@google.com Fix Android Vulkan build
2021-06-29 capn@google.com Implement Pragma() for Reactor MemorySanitizer instrumentation
2021-06-29 cwallez@google.com Increase limits to support base WebGPU.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: bungeman@google.com
Change-Id: Ib86fc93fe0c9002a516d132312e54c7c44226531
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423178
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-06-30 19:52:46 +00:00
Tyler Denniston
1b0a95e0ee Omit inner join geometry when possible
There is some relatively cheap math we can do to determine easy cases
when the inner join geometry can be skipped. This CL is not
comprehensive in that there may be other cases where we can skip the
geometry.

Only handling miter joins in this CL - the other join types can likely
have similar logic, but will require a bit more computation to compute
the inner (reflected) miter point.

Misc notes:
- Added SK_LEGACY_INNER_JOINS ifdef in the event that clients depend on
  the old behavior.
- Modified stroker to track "previous previous" point, which is the
  start point of the previous line segment.

Bug: b/165379671, skia:11964
Change-Id: I56789e85a2b4627c32f2a30fe60e47d448e9adf3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/404717
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Tyler Denniston <tdenniston@google.com>
2021-06-30 19:52:42 +00:00
Ethan Nicholas
9b5e3c9971 Pulled vectors out of SkSLType and made them pointers
This is purely to reduce the size of SkSLType objects, since we create a
ton of them on compiler startup.

Change-Id: Icea7100d278cdf4805a163d04edf3b8d46c83fe6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423317
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2021-06-30 19:52:38 +00:00
Jim Van Verth
cc6ddcd142 Metal: replace last temp transfer buffer with staging slice
Change-Id: Ifc2ca70d0d6c8e325a0edccdd1f1d02b6110131f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423136
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2021-06-30 19:45:02 +00:00
Robert Phillips
0734c6223c Clear the tile backend textures when drawing DDLs
It appears that the flutter SKPs don't contain an initial clear so the background can be random noise.

This only appears to be an issue for the Metal backend.

Change-Id: I4f5c823cdb1a0a76c0704d4d48355c3a0ed75d43
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423316
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-06-30 18:56:35 +00:00
Chris Dalton
a05ccc399d Finish sk_VertexID workarounds for tessellated fills
At this point all tessellated fills are capable of drawing when
sk_VertexID is not supported.

Bug: chromium:1220246
Change-Id: Icb1deef1558b09d45fadcaa4092023bf0931e398
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423156
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-06-30 18:44:34 +00:00
Brian Osman
e5926135cc Hoist matrix transform out of GrRectBlurEffect
Change-Id: I3da5112801d244e3200ce05b6a288f75882f7ef3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423297
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2021-06-30 17:51:21 +00:00
Chris Dalton
e1f72377e5 Convert fill tessellation shaders back to indexed draws
This reduces the number of vertices we need to process by a factor of
3, and also relieves our dependence on gl_VertexID.

Bug: chromium:1220177
Bug: chromium:1220246
Change-Id: I0f79c24c0f450f9eb936709437196371f67b7f33
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422876
Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-06-30 17:40:11 +00:00
skia-autoroll
b4252b21a1 Roll ANGLE from e70c21f4cb16 to a8959a9b56b4 (18 revisions)
e70c21f4cb..a8959a9b56

2021-06-30 cnorthrop@google.com Tests: Add Toon Blast trace
2021-06-30 syoussefi@chromium.org Vulkan: SPIR-V Gen: Support switch
2021-06-30 syoussefi@chromium.org Vulkan: SPIR-V Gen: Support break and continue
2021-06-30 cnorthrop@google.com Tests: Add Township trace
2021-06-29 cnorthrop@google.com Tests: Add Farm Heroes Saga trace
2021-06-29 timvp@google.com generate_android_bp.py: Don't include buildtools/third_party/libc++/
2021-06-29 jmadill@chromium.org infra: Add perf tests to Android/Linux/Mac.
2021-06-29 jmadill@chromium.org Perf Tests: Register trace tests programatically.
2021-06-29 lubosz.sarnecki@collabora.com gl.xml: Add GL_FRAMEBUFFER_SRGB_EXT to EnableCap group.
2021-06-29 pkasting@chromium.org Fix a -Wdeprecated-copy warning.
2021-06-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 7329723d8103 to 9fa02d6ab07f (21 revisions)
2021-06-29 jmadill@chromium.org infra: Build traces on perf bots.
2021-06-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e4fea30bb438 to a3726e06b4f1 (7 revisions)
2021-06-29 gert.wollny@collabora.com Capture/Replay: enable some more passing tests
2021-06-29 gert.wollny@collabora.com Capture/Replay: enable passing WebGLCompatibilityTest tests
2021-06-29 gert.wollny@collabora.com Capture/Replay: enable IndexBufferOffsetTest.* tests
2021-06-29 gert.wollny@collabora.com Capture/Replay: Capture TexSubImage2DRobustAngle, enable tests
2021-06-29 gert.wollny@collabora.com Capture/Replay: enable passing UniformTest.Sampler/*

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: bungeman@google.com
Test: Test:
Test: Test: angle_perftests --gtest_filter="*farm_heroes_saga*"
Test: Test: angle_perftests --gtest_filter="*township*"
Test: Test: angle_project --gtest_filter="*toon_blast*"
Change-Id: I88b1442d26135bfd5270698b06b2472ab63ed5bb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423197
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-06-30 17:14:36 +00:00
skia-autoroll
bca21b3a8e Roll SK Tool from c6bdfb0f5cd1 to 01bc5f924777
https://skia.googlesource.com/buildbot.git/+log/c6bdfb0f5cd1..01bc5f924777

2021-06-30 jcgregorio@google.com [switchboard] Fold configs into test_machine_monitor exe.
2021-06-30 rmistry@google.com [skcq] Add library for listing and parsing footers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: kjlubick@google.com
Change-Id: I9fb658d203fc84035e7cc58669149bc9b1714159
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423357
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-06-30 16:34:51 +00:00
Brian Osman
c9897a5565 Always use high precision in GrRectBlurEffect
Change-Id: If209731fa2f4ef47ad57c5542ca6b09afd521ddb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423296
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-06-30 16:02:04 +00:00
Mike Reed
b393c4bccd Lots of prose fixes
Change-Id: Ie1b4b17fa6c28d15b92dc620c11dcf89d7933501
No-Try: true
Docs-Preview: https://skia.org/?cl=415901
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/415901
Reviewed-by: Mouad Debbar <mdebbar@google.com>
Reviewed-by: Yegor Jbanov <yjbanov@google.com>
2021-06-30 15:07:30 +00:00
skia-autoroll
76e45134b8 Roll Chromium from 5803a306de81 to 20cc6c3bb504 (481 revisions)
5803a306de..20cc6c3bb5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: bungeman@google.com
Change-Id: I4897bc2f1e6d345846e85e71b66b8ddcf01a6c1d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423198
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-06-30 08:08:26 +00:00
Mike Reed
55b401ed9e Make blender the source-of-truth
- blendmode is no longer stored in paint
- no perf change expected (should take all special cases we did before)
- no pixel changes expected

Prev CL this builds upon:
https://skia-review.googlesource.com/c/skia/+/419576

Change-Id: Ifb21298c26de3e0773431a58d2aaa8530cc77654
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421997
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2021-06-29 21:47:55 +00:00
Brian Osman
c6804edbae Convert Clamped and Tiled gradient effects to GrSkSLFP
Change-Id: If9a3a2e71fada81447ad697b2dc9efd4dec77a28
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423019
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2021-06-29 21:04:38 +00:00
Ravi Mistry
c3ded43e92 Run CreateDockerImage bots only on main branch
Change-Id: I82f432a7b072c52623bebea12486f54ff751807a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423076
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2021-06-29 19:18:28 +00:00
Brian Osman
581c336b73 Remove all unused GrProcessor class IDs
Change-Id: I0150fbdafaec2e8131d18956138fc100bfc45225
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423024
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-06-29 18:58:45 +00:00
Brian Osman
56b6107cad Fix a subtle bug with pass-through children of GrSkSLFP
Discovered this while converting the remaining gradient FPs. The idea is
explained in the comment - we want to detect when we're sampling a child
that was converted to pass-through. Rather than directly checking for
that, I was looking at the explicitly-sampled flag. This is usually
correct. However - that flag is propagated to all child FPs, independent
of sample-usage. In this situation, we would end up not clearing coords,
and passing the incorrect default (float2(0)), rather than the actual
incoming coords.

Change-Id: Ibd8e799ec72f1e3a1bc79f723240048dae63ee13
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423023
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-06-29 18:50:14 +00:00
skia-autoroll
62ce2488f7 Roll SK Tool from ab601dcaea01 to e3e7f63ba062
https://skia.googlesource.com/buildbot.git/+log/ab601dcaea01..e3e7f63ba062

2021-06-29 borenet@google.com [sk] Add logging during asset upload, tweak creation subprocess
2021-06-29 erikrose@google.com [machine] Bridge Switchboard types to TS.
2021-06-29 jcgregorio@google.com [kingsford] Reconnect on invalid pod.
2021-06-29 rmistry@google.com [autoroller] Return error if no changes found; add logging; commit with "-a"
2021-06-29 jcgregorio@google.com [switchboard] Embed the kubeconfig.yaml file in the application.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: kjlubick@google.com
Change-Id: I916c537e2f6a3980c4740cf9182129372deedaef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423045
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-06-29 17:47:16 +00:00
Brian Osman
4716a7681e SkRuntimeEffect: Don't keep two copies of SkSL source around
Change-Id: I98fcaa0e83e574cdbdd767abbedcf6763c0fdce4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422521
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-06-29 16:52:46 +00:00
Chris Dalton
c04503d1b2 Run gldmsaa on the AppleM1 bot
Bug: skia:11396
Change-Id: I2a4e6f6508ccbb7a7365bb567d77cc4a95c0bc4d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/415117
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-06-29 16:37:46 +00:00
Kevin Lubick
9080a2fdb5 [infra] Update M1 Mac jobs to use 11.4
These mac minis had been mysteriously low on disk space.
They reported 20 or fewer GB free, but no tool could tell
us where that space was being used.

Updating from 11.1 to 11.4 seems to have cleared that up.

Change-Id: I5291b1ac5616b9899b1cd6de35ae36af0cb8c75b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423056
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2021-06-29 15:14:34 +00:00
Greg Daniel
bee1b55f30 Make sure we aren't allocating more ycbcr desc sets in Vk than available.
Ycbcr images in vulkan can use anywhere from 1 to 3 descriptor set slots.
This comes from some gpus needing to internally treat the different
planes as different textures/samplers. So when you allocated a desc set
that includes a ycbcr image it may actually use up 3 desc set slots from
the pool. Nothing else changes in how we use the VkImage or descriptor
set. Just a matter of accounting for it in the pool.

Change-Id: I10dead981e59f0ebee54b76bdeabf968114d83b0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422520
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2021-06-29 14:35:45 +00:00
Brian Osman
2f5466e2b3 Initialize fBackend in Window_unix
Discovered while trying to run viewer in ASAN

Change-Id: Ic7469fdbf8cb77573c2f93503440b2137bdba783
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423016
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2021-06-29 14:33:26 +00:00
Robert Phillips
b25ce71cb1 Fix bug in GrResourceCache::purgeAsNeeded
Change-Id: Iafb09c2f7ea2393c2753208bd0d245c7b175bc65
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422957
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-06-29 13:32:15 +00:00
Robert Phillips
d1285c68d0 Guard default path renderer against buffer allocation failure
Apparently the guarantee of buffer space has been refactored out from
underneath this class.

Bug: 1223365
Change-Id: I9beb9566a641933322bd946a5067eeafb9c4c013
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422636
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2021-06-29 13:25:35 +00:00
Florin Malita
1df8756419 [androidkit] Color filter support
Add MatrixColorFilter, HSLAMatrixColorFilter and ComposeColorFilter.

Change-Id: I047368adcd13452566a40e91a6f594dd525efd5f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422517
Commit-Queue: Florin Malita <fmalita@google.com>
Reviewed-by: Jorge Betancourt <jmbetancourt@google.com>
2021-06-29 12:42:19 +00:00
skia-autoroll
78af79e98d Roll Chromium from a685aa37c9fa to 5803a306de81 (1325 revisions)
a685aa37c9..5803a306de

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: bungeman@google.com
Change-Id: I5f3ca12944d4ca1d4fc7d4f8a68963e34efa8368
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422841
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-06-29 05:40:19 +00:00
skia-autoroll
a7d4294642 Roll SwiftShader from e4fea30bb438 to 964b9e39e44a (6 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e4fea30bb438..964b9e39e44a

2021-06-28 bclayton@google.com SpirvShader: Consider OpEntryPoint interface IDs
2021-06-28 capn@google.com Determine MSan instrumentation for Reactor at run-time
2021-06-28 stha09@googlemail.com GCC: readd visibility attributes for EGL/GLESv2
2021-06-28 capn@google.com Fix -warn-stack-size command line option for LLVM 12
2021-06-28 sugoi@google.com Only perform LOD computation when it is necessary
2021-06-28 swiftshader.regress@gmail.com Regres: Update test lists @ e4fea30b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: bungeman@google.com
Change-Id: I81400dbb3a395fe9ebd081f415c1c68648fe01ab
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422840
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-06-29 05:00:50 +00:00
skia-autoroll
ff11290840 Roll ANGLE from 8767ec1549a7 to e70c21f4cb16 (24 revisions)
8767ec1549..e70c21f4cb

2021-06-28 cnorthrop@google.com Tests: Add Beach Buggy Racing trace
2021-06-28 timvp@google.com Fixes and updates to roll_aosp.sh
2021-06-28 jmadill@chromium.org Suppress flaky TSAN TLS false positive.
2021-06-28 gert.wollny@collabora.com Capture/Replay: enable passing DrawBuffersTest.*
2021-06-28 cnorthrop@google.com Capture/Replay: Disable GL_OES_depth32 during capture
2021-06-28 penghuang@chromium.org Disable shader cache for PowerVR Rogue GPUs.
2021-06-28 m.maiya@samsung.com Vulkan: Handle incompatible pipeline layouts
2021-06-28 jmadill@chromium.org Revert "Vulkan: Load custom Vk Loader."
2021-06-28 gert.wollny@collabora.com Capture/Replay: enable passing OcclusionQueriesTest.*
2021-06-28 cnorthrop@google.com Capture/Replay: Update CopyImageSubData params
2021-06-28 gert.wollny@collabora.com Capture/Replay: enable passing IndexedPointsTest* tests
2021-06-28 gert.wollny@collabora.com Capture/Replay: capture GetMaterialfv parameters
2021-06-28 syoussefi@chromium.org Vulkan: SPIR-V Gen: Support loops
2021-06-28 gert.wollny@collabora.com Capture/Replay: Handle Gen/Delete Semaphores and fix map emit
2021-06-28 jmadill@chromium.org Vulkan: Load custom Vk Loader.
2021-06-28 jmadill@chromium.org Add SearchType to OpenSharedLibraryWithExtension.
2021-06-28 syoussefi@chromium.org Add angle::BitMask for creating bit masks
2021-06-28 gert.wollny@collabora.com Capture/Replay: Limit number of compile processes based on load
2021-06-28 jmadill@chromium.org Trace Tests: Use hermetic depot_tools.
2021-06-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 8f075627d16b to e4fea30bb438 (3 revisions)
2021-06-28 gert.wollny@collabora.com Capture/Replay: Add test to capture an uninitialized buffer
2021-06-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 94cea2515faf to 1078c63704e4 (468 revisions)
2021-06-28 gert.wollny@collabora.com Capture/Replay: Enable BufferDataTests.*
2021-06-28 gert.wollny@collabora.com Capture/Replay: SimpleOperationTest.* pass now

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: bungeman@google.com
Test: Test: Beach Buggy Racing MEC
Test: Test: ImageTest.SourceAHBTarget2DExternalCycleThroughRgbAndYuvTargets*Vulkan
Test: Test: PUBG Mobile MEC
Test: Test: angle_perftests --gtest_filter="*beach_buggy_racing*"
Change-Id: Ifa2fd660df5ed29328133be07143a224007771b1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422839
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-06-29 04:55:49 +00:00
Chris Dalton
baae2dd7fb Implement inverse fill support in GrTessellationPathRenderer
Bug: skia:10419
Bug: skia:11396
Change-Id: I489236ec5dff59b0e7c4c4e22b83b2b5ec4e9a26
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421796
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-06-29 03:57:46 +00:00
Ben Wagner
1bddd42b98 Add base outlines to colrv1 test font
This allows tests which draw this font on platforms which do not support
the COLRv1 table to draw something rather than nothing.

Change-Id: I024dd4809498d55f8c4c9f0de9e342fed5fb69ac
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/422757
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2021-06-28 23:59:26 +00:00