Commit Graph

547 Commits

Author SHA1 Message Date
epoger@google.com
0a117be391 Re-land r9059 with empty cityhash.gyp, instead of deleted cityhash.gyp
R=rmistry@google.com

Review URL: https://codereview.chromium.org/15060008/



git-svn-id: http://skia.googlecode.com/svn/trunk@9064 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 16:04:02 +00:00
epoger@google.com
e8d08a0fc2 Roll out r9059 to unbreak bots
git-svn-id: http://skia.googlecode.com/svn/trunk@9060 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 15:22:36 +00:00
epoger@google.com
aaf7343e16 Remove third-party cityhash, unused since r8992
R=djsollen@google.com

Review URL: https://codereview.chromium.org/15027013

git-svn-id: http://skia.googlecode.com/svn/trunk@9059 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 14:49:50 +00:00
robertphillips@google.com
3faf1f1fb6 Nexus 7 performance trigger rebaselines
(SkipBuildbotRuns)



git-svn-id: http://skia.googlecode.com/svn/trunk@9040 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 17:43:22 +00:00
robertphillips@google.com
8e2cdff9ab Nexus 7 performance trigger rebaseline
(SkipBuildbotRuns)



git-svn-id: http://skia.googlecode.com/svn/trunk@9030 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 13:08:41 +00:00
jvanverth@google.com
ce0ce4fa35 Add stroked oval benches.
Reviewed by: bsalomon
Review URL: https://codereview.chromium.org/14849011/


git-svn-id: http://skia.googlecode.com/svn/trunk@9029 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 13:03:21 +00:00
robertphillips@google.com
ddb45a6ac0 Nexus 7 performance trigger rebaselines
(SkipBuildbotRuns)



git-svn-id: http://skia.googlecode.com/svn/trunk@9014 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-06 15:39:11 +00:00
robertphillips@google.com
33146a7f02 Updated performance trigger baseline
(SkipBuildbotRuns)



git-svn-id: http://skia.googlecode.com/svn/trunk@9012 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-06 14:08:08 +00:00
skia.committer@gmail.com
ecc9d28072 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9002 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-04 07:01:15 +00:00
bsalomon@google.com
292ce73728 Add benches for all xfermodes.
R=reed@google.com

Review URL: https://codereview.chromium.org/14818005

git-svn-id: http://skia.googlecode.com/svn/trunk@8990 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 16:28:33 +00:00
robertphillips@google.com
dfa1ce027f Win7 gpu performance trigger rebaseline (tabl_mlb)
(SkipBuildbotRuns)



git-svn-id: http://skia.googlecode.com/svn/trunk@8978 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 13:12:48 +00:00
reed@google.com
0889f682fb add bench for SkPoint::normalize()
git-svn-id: http://skia.googlecode.com/svn/trunk@8977 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 12:56:39 +00:00
skia.committer@gmail.com
2fd42c471c Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@8976 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 07:01:00 +00:00
robertphillips@google.com
370d835c1c Add new bench for rotated rects (aarects_rotated)
https://codereview.chromium.org/14688007/



git-svn-id: http://skia.googlecode.com/svn/trunk@8957 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 13:57:52 +00:00
borenet@google.com
e6598a04a7 Fix builder name references
... as a result of https://codereview.chromium.org/14517004/
(SkipBuildbotRuns)

R=bensong@google.com, rmistry@google.com, senorblanco@chromium.org

Review URL: https://codereview.chromium.org/14544003

git-svn-id: http://skia.googlecode.com/svn/trunk@8921 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-30 12:02:32 +00:00
skia.committer@gmail.com
8152113073 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8919 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-30 07:01:03 +00:00
mike@reedtribe.org
af5c506cd6 add routines to compute error between conic and quad
git-svn-id: http://skia.googlecode.com/svn/trunk@8916 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-30 02:14:58 +00:00
reed@google.com
cb8dce2ae3 up the inner-loop for clz bench, to get more stable results
git-svn-id: http://skia.googlecode.com/svn/trunk@8895 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-29 14:11:23 +00:00
reed@google.com
0d7aac9ce7 add bench for SkCLZ
git-svn-id: http://skia.googlecode.com/svn/trunk@8894 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-29 13:55:11 +00:00
reed@google.com
553ad65f78 use DEF_BENCH macro
git-svn-id: http://skia.googlecode.com/svn/trunk@8893 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-29 13:48:34 +00:00
mike@reedtribe.org
28552e12a0 rename SkRationalQuad to SkConic
git-svn-id: http://skia.googlecode.com/svn/trunk@8872 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-26 00:58:29 +00:00
robertphillips@google.com
3b5feb37ff Nexus 7 performance trigger rebaselines
(SkipBuildbotRuns)

-This line, and those below, will be ignored--

M    bench/bench_expectations.txt


git-svn-id: http://skia.googlecode.com/svn/trunk@8870 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-25 22:23:43 +00:00
robertphillips@google.com
9eb79e566e Adjust some Nexus 7 performance triggers
(SkipBuildbotRuns)



git-svn-id: http://skia.googlecode.com/svn/trunk@8853 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-25 12:21:18 +00:00
skia.committer@gmail.com
83f0d302e8 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8851 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-25 07:01:04 +00:00
sugoi@google.com
5d71adf4b1 Adding new bench tests for lighting and blur
Review URL: https://codereview.chromium.org/14474004

git-svn-id: http://skia.googlecode.com/svn/trunk@8846 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-24 19:36:44 +00:00
skia.committer@gmail.com
6238c57c8d Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8833 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-24 07:01:07 +00:00
jvanverth@google.com
190260e7cf Add stroked rrect benches.
Review URL: https://codereview.chromium.org/14238017/


git-svn-id: http://skia.googlecode.com/svn/trunk@8832 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-23 19:14:03 +00:00
sugoi@google.com
ca425d9fd9 Build fix
git-svn-id: http://skia.googlecode.com/svn/trunk@8826 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-23 14:37:38 +00:00
sugoi@google.com
580a17241c Added a few bench for some image filters
Review URL: https://codereview.chromium.org/14234019

git-svn-id: http://skia.googlecode.com/svn/trunk@8824 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-23 14:20:45 +00:00
commit-bot@chromium.org
5d7ca957ed Fix gyp files to allow ninja to build 64 bit on Mac.
Fix warnings that cropped up building as 64-bit.

BUG=
R=bsalomon@google.com, bungeman@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/13852013

git-svn-id: http://skia.googlecode.com/svn/trunk@8814 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-22 20:26:44 +00:00
robertphillips@google.com
f6212b36b3 Rebaseline performance triggers for new .skp files
git-svn-id: http://skia.googlecode.com/svn/trunk@8801 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-22 15:07:34 +00:00
robertphillips@google.com
4309a02bd1 Win7 Intel performance rebaseline
(SkipBuildbotRuns)



git-svn-id: http://skia.googlecode.com/svn/trunk@8789 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-20 21:51:06 +00:00
robertphillips@google.com
2240aded73 Performance rebaseline on ubuntu
(SkipBuildbotRuns)



git-svn-id: http://skia.googlecode.com/svn/trunk@8788 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-20 21:44:52 +00:00
reed@google.com
9d1cff124c use SkAutoTDelete instead of SkTScopedPtr
Review URL: https://codereview.chromium.org/13831011

git-svn-id: http://skia.googlecode.com/svn/trunk@8749 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-18 18:43:26 +00:00
robertphillips@google.com
4314f1b843 Rebaseline Nexus7 cuteoverload performance trigger
git-svn-id: http://skia.googlecode.com/svn/trunk@8735 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-18 12:32:28 +00:00
skia.committer@gmail.com
cbbdab5513 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8732 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-18 07:01:48 +00:00
junov@chromium.org
a213899d1f Build fix
TBR=reed

git-svn-id: http://skia.googlecode.com/svn/trunk@8720 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-17 13:55:45 +00:00
sugoi@google.com
4775cba7b3 Perlin noise adjustments
1 ) Added GPU simplex noise as a comparison to GPU Perlin noise. It can be enabled simply by using a #define (SK_USE_SIMPLEX_NOISE)
2 ) Enabled GPU Perlin noise tests
3 ) Added a small benchmark for noise
4 ) Disabled GPU Perlin noise on Android based on benchmarks

Review URL: https://codereview.chromium.org/14087002

git-svn-id: http://skia.googlecode.com/svn/trunk@8719 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-17 13:46:56 +00:00
junov@chromium.org
d61ba6e5cf Benchmark to measure SkSurface copy on write performance
Review URL: https://codereview.chromium.org/14297008

git-svn-id: http://skia.googlecode.com/svn/trunk@8718 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-17 13:43:04 +00:00
skia.committer@gmail.com
ab38e560e9 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8673 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-14 07:01:08 +00:00
mike@reedtribe.org
8d55101196 add special-case for chopping at exactly half for rational-quads (2-3x faster)
git-svn-id: http://skia.googlecode.com/svn/trunk@8672 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-14 02:40:50 +00:00
robertphillips@google.com
44f00b1429 Rebaseline Nexus-7 performance triggers
git-svn-id: http://skia.googlecode.com/svn/trunk@8607 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-10 23:25:36 +00:00
robertphillips@google.com
e80114d850 Remove MacMini 10.8 performance triggers because they keep flip flopping
git-svn-id: http://skia.googlecode.com/svn/trunk@8603 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-10 18:57:58 +00:00
djsollen@google.com
c2532dd0b8 Partial reapply of r5364 minus the non-neon code path.
See https://codereview.appspot.com/6465075 for a more detailed description of the contents of this CL.

Review URL: https://codereview.chromium.org/13060004

git-svn-id: http://skia.googlecode.com/svn/trunk@8579 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-09 18:06:06 +00:00
bensong@google.com
ae6f47e55d Switches to a Skia-specific appengine entry point that uses condensed data and taskqueue writes (SkipBuildbotRuns).
The default entry /add_point does not handle large data efficiently, so we've seen >30min timeouts for some bots to upload data. We now switch to using /skia_add_points that I'm writing for Skia, so we can condense the data to send to minimum (since all points in each batch have the same revision, platform and config), and dedicate the actual data processing to /skia_write_datastore which is a taskqueue task that has longer timeout and can run at app backend instead of blocking the bots.
Initial testing from my MacBook on Mac 64 bench data via vpn gave only a little more than 1 second for uploading data for one config, about 15 seconds for all 12 configs. That's a big win against 20+ minutes.
Review URL: https://codereview.chromium.org/13762002

git-svn-id: http://skia.googlecode.com/svn/trunk@8560 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-08 14:57:40 +00:00
tfarina@chromium.org
7731eada5b Fix more clang errors.
Fixed -Wunused-private-field errors.

R=reed@google.com,bsalomon@google.com

Review URL: https://codereview.chromium.org/13474012

git-svn-id: http://skia.googlecode.com/svn/trunk@8547 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-05 21:13:14 +00:00
robertphillips@google.com
97f57a6c4f Rebaseline Ubuntu performance trigger
git-svn-id: http://skia.googlecode.com/svn/trunk@8516 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-03 17:31:22 +00:00
bensong@google.com
eb6a41d600 Increases batch size for sending bench data to appengine to 66.
This is part of the attempt to avoid bench step timeout errors (10-20min).
Review URL: https://codereview.chromium.org/13430011

git-svn-id: http://skia.googlecode.com/svn/trunk@8491 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-02 16:41:55 +00:00
robertphillips@google.com
3e1ba9fd40 Re-enabling Mac 10.8 performance triggers removed in r8472
git-svn-id: http://skia.googlecode.com/svn/trunk@8484 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-02 15:05:55 +00:00
robertphillips@google.com
86b83fb0a2 Rebaseline Nexus7 performance triggers
git-svn-id: http://skia.googlecode.com/svn/trunk@8481 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-02 14:36:10 +00:00
skia.committer@gmail.com
05a2ee052c Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8477 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-02 07:01:34 +00:00
robertphillips@google.com
01f010cffe Remove MacMini_10_8 performance triggers
git-svn-id: http://skia.googlecode.com/svn/trunk@8472 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-01 21:38:37 +00:00
commit-bot@chromium.org
d7aaf6034e Add Xfermode bench. Also clear before rendering in bench (rather than after).
Author: bsalomon@google.com

Reviewed By: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/13334011

git-svn-id: http://skia.googlecode.com/svn/trunk@8454 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-01 12:51:34 +00:00
robertphillips@google.com
51c81123af Convert #warning to comment to get iOS compiling
https://codereview.chromium.org/13157002/



git-svn-id: http://skia.googlecode.com/svn/trunk@8427 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-28 13:43:16 +00:00
robertphillips@google.com
6864cb8a2e Rebaseline Mac 10.8 performance flakes
git-svn-id: http://skia.googlecode.com/svn/trunk@8368 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-25 17:16:37 +00:00
robertphillips@google.com
44b85fe217 Rebaselining performance flake
git-svn-id: http://skia.googlecode.com/svn/trunk@8356 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-25 11:52:27 +00:00
robertphillips@google.com
4d3751df26 Rebaselining performance flakes
git-svn-id: http://skia.googlecode.com/svn/trunk@8354 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-24 21:18:20 +00:00
robertphillips@google.com
72657e00ca Rebaseline for Mac 10.9 performance trigger flakes
git-svn-id: http://skia.googlecode.com/svn/trunk@8347 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-22 20:15:11 +00:00
robertphillips@google.com
28795f5e31 Widen the range on some performance trigger flakes
git-svn-id: http://skia.googlecode.com/svn/trunk@8346 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-22 18:35:28 +00:00
robertphillips@google.com
b2ef7088cb Remove Ubuntu gpu performance triggers
git-svn-id: http://skia.googlecode.com/svn/trunk@8334 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-22 13:46:30 +00:00
robertphillips@google.com
fb4038a889 Performance trigger rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@8314 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-21 21:05:49 +00:00
robertphillips@google.com
4f25baafc4 Adjust performance triggers
git-svn-id: http://skia.googlecode.com/svn/trunk@8280 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-21 00:09:12 +00:00
robertphillips@google.com
6a2ea6909b More performance rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@8220 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 14:20:22 +00:00
bsalomon@google.com
8a70eef71c Add MSAA configs to bench.
Review URL: https://codereview.chromium.org/12607013

git-svn-id: http://skia.googlecode.com/svn/trunk@8217 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 13:58:55 +00:00
robertphillips@google.com
25ba67109b More Mac 10.8 performance rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@8195 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-18 17:57:18 +00:00
robertphillips@google.com
79dca3e597 Another Mac 10.8 performance rebaseline
git-svn-id: http://skia.googlecode.com/svn/trunk@8190 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-18 14:37:16 +00:00
robertphillips@google.com
795181ded3 Perfrormance rebaseline for Mac 10.8
git-svn-id: http://skia.googlecode.com/svn/trunk@8188 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-18 12:12:37 +00:00
robertphillips@google.com
fbf66e88be Yet another performance trigger rebaseline
git-svn-id: http://skia.googlecode.com/svn/trunk@8185 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-17 22:34:56 +00:00
robertphillips@google.com
48d94b8050 More performance trigger rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@8184 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-17 20:58:08 +00:00
robertphillips@google.com
ba66694744 Rebaseline some more performance triggers (Mac 10.8 & Ubuntu)
git-svn-id: http://skia.googlecode.com/svn/trunk@8183 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-17 18:50:05 +00:00
robertphillips@google.com
d4be5dd36c Rebaselining Nexus7 performance triggers after r8171
git-svn-id: http://skia.googlecode.com/svn/trunk@8180 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-17 16:51:44 +00:00
robertphillips@google.com
8abc037da0 Rebaseline Ubuntu, Windows and Mac 10.8 performance triggers after r8171
git-svn-id: http://skia.googlecode.com/svn/trunk@8179 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-17 16:32:12 +00:00
bsalomon@google.com
604a56ad42 Run non-rendering benches in their own config.
Currently benches that set fIsRendering = false are run as part of the first config run. This is problematic for several reasons.

1) Which config they are run as depends on the --config options passed to bench. If I run bench --config GPU --config 8888 then they will be run in the GPU config and not the 8888 config.

2) Their presence makes bench take longer to run when testing rendering changes or comparing one rendering config to another (e.g. GPU v 8888). This is especially true on Android.

3) When comparing runs of a single config across multiple bench runs (typically  with code changes) it isn't obvious from the output which benchs to ignore because they say are listed under as being part of the config.

This CL adds NONRENDERING as a config (open to name suggestions). Non-rendering tests are run in and only in the NONRENDERING config.

Will this screw up our bench bots/scripts/graphs? If so I think we should change them since running non-rendering tests separately makes a lot more sense than the current madness.
Review URL: https://codereview.chromium.org/12475012

git-svn-id: http://skia.googlecode.com/svn/trunk@8174 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-15 15:42:15 +00:00
robertphillips@google.com
23f785d530 Update performance triggers for new skps (also remove all _multi_* triggers)
git-svn-id: http://skia.googlecode.com/svn/trunk@8169 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-15 12:43:53 +00:00
robertphillips@google.com
d66fe098f0 Adjust Win7 performance trigger for outliers
git-svn-id: http://skia.googlecode.com/svn/trunk@8149 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-14 12:41:30 +00:00
bensong@google.com
a9a1967bcb Cut data point upload batch size to 25.
Some bots have lower speed sending http data out, and this will make it less likely to timeout.
Did not try 50 because once we switch to using Chrome dashboard app, extra work needs to be done for each data point which will take longer. Since appengine has the fixed 30s timeout policy, there's not too much we can do unless we convince Chrome to switch to other solutions.
Current Skia data on our app instance: https://skiadash.appspot.com/report
Review URL: https://codereview.chromium.org/12703008

git-svn-id: http://skia.googlecode.com/svn/trunk@8133 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 18:31:03 +00:00
robertphillips@google.com
bb51fabc99 Update bench_expectations & add triggers for N7, Mac 10.8 and Ubuntu
git-svn-id: http://skia.googlecode.com/svn/trunk@8128 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 15:25:30 +00:00
robertphillips@google.com
632b9ccebf Disable all multi_*_threads triggers (see issue 1160)
git-svn-id: http://skia.googlecode.com/svn/trunk@8117 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 19:20:22 +00:00
borenet@google.com
5dc06785ff Make graph output optional in bench_graphs_svg
Enables https://codereview.chromium.org/12785002/
Review URL: https://codereview.chromium.org/12543019

git-svn-id: http://skia.googlecode.com/svn/trunk@8112 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 17:16:07 +00:00
bsalomon@google.com
e3613cefe2 Fix sign/unsigned warnings in benchmain.cpp and gmmain.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@8079 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 20:33:45 +00:00
bsalomon@google.com
c732f259fa Add --gpucache size to bench.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/12635009

git-svn-id: http://skia.googlecode.com/svn/trunk@8075 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 20:22:15 +00:00
sugoi@google.com
9c55f801a3 Fixing some warnings on Linux
There were only a few warnings left, so I fixed them and enabled the unused variable warning by removing the "-Wno-unused" flag. Only the -Wno-unused-parameter remains for now (could be removed later).
Review URL: https://codereview.chromium.org/12480002

git-svn-id: http://skia.googlecode.com/svn/trunk@8030 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-07 20:52:59 +00:00
bensong@google.com
848fa2bf75 Codes for writing bench data to appengine datastore.
To activate, add flag "-a https://skiadash.appspot.com/add_point" or URL to other chrome-perf app instances. Otherwise behavior will be same as before.
Review URL: https://codereview.chromium.org/12381088

git-svn-id: http://skia.googlecode.com/svn/trunk@8020 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-07 17:12:43 +00:00
sugoi@google.com
77472f06f8 Bench : Unused parameters cleanup
I removed unused parameters in bench wherever it was trivial to do so.
Review URL: https://codereview.appspot.com/7411046

git-svn-id: http://skia.googlecode.com/svn/trunk@7988 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-05 18:50:01 +00:00
scroggo@google.com
161e1ba4c0 Created my own flag parser, based off of gflags.
Share common code between bench_ and render_ to set up the PictureRenderer.
Fix an include error in SkPictureRenderer.h.
Simplified parameter passing in render_pictures_main.
Switch to using an SkAutoTUnref for the PictureRenderer.
I also changed the input format somewhat, so the buildbots need to be updated as well: https://codereview.appspot.com/7441044/
Fixed a bug in PictureBenchmark where calling setTimeIndividualTiles(false) sets the member variable to true.
Removed setDeviceType from PictureBenchmark, since only the PictureRenderer needs to know which device type to use.

Some changes to the input format:
'--logPerIter' no longer takes a 1 or 0. Instead, '--logPerIter'
turns it on and '--nologPerIter' turns it off (with off as the
default). (Note that this is for bench_pictures; bench still uses the old format)

Change '--device' to '--config' and 'bitmap' to '8888' to be
the same as gm.

Requires '--r' before inputs (to match gm), though there can be multiple inputs following it.

Changed --enable-deferred-image-decoding (which no one uses but me yet anyway) to --deferImageDecoding, since the former is incompatible with the flag parser.

Changes to behavior:
Show a short error message on failure (rather than the explanation of all
flags).

BUG=https://code.google.com/p/skia/issues/detail?id=1094

Review URL: https://codereview.appspot.com/7230053

git-svn-id: http://skia.googlecode.com/svn/trunk@7961 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-04 16:41:06 +00:00
robertphillips@google.com
6177e6999d Split GrGLContextInfo into GrGLContext & GrGLContextInfo
https://codereview.appspot.com/7436045/



git-svn-id: http://skia.googlecode.com/svn/trunk@7905 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-28 20:16:25 +00:00
bsalomon@google.com
1744f97ea7 Use glGetStringi to get extensions when available.
Review URL: https://codereview.chromium.org/12328111

git-svn-id: http://skia.googlecode.com/svn/trunk@7872 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-26 21:46:32 +00:00
bsalomon@google.com
5c90e29142 Fix signed/unsigned comparison warnings in benchmain.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@7833 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-22 19:17:13 +00:00
bsalomon@google.com
41809934d7 Fix GPU-less build of bench.
git-svn-id: http://skia.googlecode.com/svn/trunk@7828 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-22 16:25:28 +00:00
bsalomon@google.com
cb26535ff7 Make GPU versions of benchs use the same canvas size as raster.
Review URL: https://codereview.appspot.com/7400049

git-svn-id: http://skia.googlecode.com/svn/trunk@7827 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-22 16:13:16 +00:00
bsalomon@google.com
cd7421bf38 Fix ChartBench crash.
git-svn-id: http://skia.googlecode.com/svn/trunk@7826 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-22 16:07:59 +00:00
bsalomon@google.com
4a71997e0d Add chart bench.
Review URL: https://codereview.appspot.com/7368051

git-svn-id: http://skia.googlecode.com/svn/trunk@7821 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-22 15:10:36 +00:00
reed@google.com
dff53c26e7 remove obsolete build flag SK_IGNORE_CONVEX_QUAD_OPT
Review URL: https://codereview.appspot.com/7363046

git-svn-id: http://skia.googlecode.com/svn/trunk@7820 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-22 14:19:58 +00:00
skia.committer@gmail.com
d454ec135e Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7803 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-21 07:15:03 +00:00
humper@google.com
a99a92ceba Complete the implementation of the faster blur; now supports all blur styles and matches the boxfilter approximation visually. Also change the interpretation of the blur radius to be sigma/2; need to add SK_IGNORE_BLUR_RADIUS_CORRECTNESS to chromium GYP to avoid immediate layout test failures over there.
Review URL: https://codereview.appspot.com/7307076

git-svn-id: http://skia.googlecode.com/svn/trunk@7793 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-20 16:42:06 +00:00
epoger@google.com
edb711ba8e bench_graph_svg: HUGE speedup for parsing tiled bench data
Review URL: https://codereview.appspot.com/7322085

git-svn-id: http://skia.googlecode.com/svn/trunk@7762 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-17 08:59:56 +00:00
epoger@google.com
e9b31faf30 bench_graph_svg: more sorting to get deterministic results
TBR=benchen
Review URL: https://codereview.appspot.com/7333045

git-svn-id: http://skia.googlecode.com/svn/trunk@7745 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-14 20:13:32 +00:00
epoger@google.com
2459a394b8 bench_graph_svg: generate output in consistently sorted order, to make diffs more useful
TBR=benchen
Review URL: https://codereview.appspot.com/7330044

git-svn-id: http://skia.googlecode.com/svn/trunk@7744 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-14 18:58:05 +00:00
epoger@google.com
ad91d92546 try precompiling regexps to speed up bench_graph_svg.py
Review URL: https://codereview.appspot.com/7336043

git-svn-id: http://skia.googlecode.com/svn/trunk@7741 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-14 18:35:17 +00:00
bensong@google.com
ba98f95aa5 Script to plot tile vs. viewport comparison for given platform and revision.
Currently viewport bot data are only available for Android bots.
Please go to http://go/skia-buildbot to pick a green revision (-r) for an Android platform (-p). This can take a few minutes because Google Storage stores files in a flat structure instead of in directories.
Alternatively, download the bot data of interest into a local directory (or generate them from your machine) and set the script to read from there (-d).
Review URL: https://codereview.appspot.com/7093065

git-svn-id: http://skia.googlecode.com/svn/trunk@7729 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-13 23:22:29 +00:00
robertphillips@google.com
f729a711a7 Re-enabled performance checking on Windows
https://codereview.appspot.com/7309065/



git-svn-id: http://skia.googlecode.com/svn/trunk@7679 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-08 20:09:56 +00:00
bensong@google.com
6184c978b8 Removes redundant and wrong check.
Review URL: https://codereview.appspot.com/7308072

git-svn-id: http://skia.googlecode.com/svn/trunk@7676 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-08 19:02:21 +00:00
bensong@google.com
06ded2df87 Fixes indentation error.
Review URL: https://codereview.appspot.com/7307077

git-svn-id: http://skia.googlecode.com/svn/trunk@7674 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-08 18:53:24 +00:00
bensong@google.com
7325818e0b Fixes a bug that didn't address new perfdata location.
Review URL: https://codereview.appspot.com/7299070

git-svn-id: http://skia.googlecode.com/svn/trunk@7673 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-08 18:47:02 +00:00
senorblanco@chromium.org
c3799ada5b Add a bench for SkBicubicImageFilter.
Review URL: https://codereview.appspot.com/7312056

git-svn-id: http://skia.googlecode.com/svn/trunk@7668 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-08 16:40:14 +00:00
robertphillips@google.com
5990397d08 Address google3 compiler warning
https://codereview.appspot.com/7308063/



git-svn-id: http://skia.googlecode.com/svn/trunk@7655 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-07 21:02:23 +00:00
robertphillips@google.com
fe1b536bb7 Enhance GL error checking for non-Ganesh GL calls
https://codereview.appspot.com/7312057/



git-svn-id: http://skia.googlecode.com/svn/trunk@7647 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-07 19:45:46 +00:00
djsollen@google.com
efbe8e9bed Fix errors when compiling with -Wall -Werror on Android.
This CL also turns those features on by default on Android

Review URL: https://codereview.appspot.com/7313049

git-svn-id: http://skia.googlecode.com/svn/trunk@7645 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-07 18:58:35 +00:00
bsalomon@google.com
fec0bc3fc1 Remove legacy names no longer referenced in Chrome and WebKit.
Review URL: https://codereview.appspot.com/7311055

git-svn-id: http://skia.googlecode.com/svn/trunk@7640 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-07 14:43:04 +00:00
bensong@google.com
ff388f8ec4 Fixes a bug introduced by the new per-tile bench log format.
Review URL: https://codereview.appspot.com/7301056

git-svn-id: http://skia.googlecode.com/svn/trunk@7630 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-06 20:59:14 +00:00
bensong@google.com
92b0f51b9b Updates gen_skp_ranges.py on recent changes of bench names, storage locations, etc.
Sample command: bench/gen_skp_ranges.py -r 7621:7621
It is slow due to cloud storage slowness. You can download the bench logs using gsutil and set the -d flag to make it super fast.
Review URL: https://codereview.appspot.com/7307052

git-svn-id: http://skia.googlecode.com/svn/trunk@7629 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-06 20:51:55 +00:00
skia.committer@gmail.com
0c38ed3b1d Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7567 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-05 07:02:01 +00:00
bungeman@google.com
4e5a89570b Simplify and speed up SkIntroSort.
https://codereview.appspot.com/7273048/


git-svn-id: http://skia.googlecode.com/svn/trunk@7552 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-04 19:54:15 +00:00
reed@google.com
73349aa332 extend gradient_create bench to test opaque and alpha gradient ramps
git-svn-id: http://skia.googlecode.com/svn/trunk@7548 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-04 18:09:58 +00:00
reed@google.com
58ba41034e cleanup: use DEF_BENCH macro
git-svn-id: http://skia.googlecode.com/svn/trunk@7547 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-04 18:00:54 +00:00
bungeman@google.com
7de18e5c7b Add sk_ignore_unused_variable to avoid warnings.
https://codereview.appspot.com/7218045/


git-svn-id: http://skia.googlecode.com/svn/trunk@7539 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-04 15:58:08 +00:00
reed@google.com
c1f9011ceb add benchmark for stroked drawRect/drawOval/drawRRect, to prepare for optimizing
those based on special-casing stroking for single-contour-convex shapes.



git-svn-id: http://skia.googlecode.com/svn/trunk@7537 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-04 14:57:28 +00:00
mike@reedtribe.org
0cf7b824ca use DEF_BENCH macro
git-svn-id: http://skia.googlecode.com/svn/trunk@7531 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-04 05:05:36 +00:00
bungeman@google.com
29dea74ca6 Fix warnings resulting from 7496.
git-svn-id: http://skia.googlecode.com/svn/trunk@7500 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-31 20:36:30 +00:00
skia.committer@gmail.com
747f1ecce6 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7499 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-31 20:28:24 +00:00
bungeman@google.com
cfcb1bef94 Add SHA1 and MD5 to utils.
https://codereview.appspot.com/7071055/


git-svn-id: http://skia.googlecode.com/svn/trunk@7496 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-31 19:47:48 +00:00
reed@google.com
a3c1348976 add new test for region::intersect, when one is a rect, and it wholly contains
a complex region.



git-svn-id: http://skia.googlecode.com/svn/trunk@7490 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-31 15:23:44 +00:00
bungeman@google.com
70476652a0 bench_compare proper spacing and tab option.
https://codereview.appspot.com/6908056/


git-svn-id: http://skia.googlecode.com/svn/trunk@7468 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-30 19:22:51 +00:00
skia.committer@gmail.com
e16efc1882 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7406 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-26 07:06:02 +00:00
reed@google.com
a53dcce4b4 reduce array size in debug builds for sortbench. This avoids a stack-overflow
due to (1) SkTQSort's bad behavior on repeated-keys, and (2) windows-debug doesn't
implement tail-recursion.

Not an issue, since we don't care about perf in our debug builds anyway.



git-svn-id: http://skia.googlecode.com/svn/trunk@7396 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 17:49:49 +00:00
skia.committer@gmail.com
4024f32d99 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7385 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 07:06:46 +00:00
reed@google.com
4bbdeac58c add optional cull-rect to patheffects, so they can do less work if their results
lie outside of the current clip-bounds (the cull rect).
Review URL: https://codereview.appspot.com/7206044

git-svn-id: http://skia.googlecode.com/svn/trunk@7378 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-24 21:03:11 +00:00
reed@google.com
c270baf97a change giantdashline test to use 4 intervals, to explicitly avoid the asPoints
special case code (which we may test separately later).



git-svn-id: http://skia.googlecode.com/svn/trunk@7375 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-24 18:43:32 +00:00
reed@google.com
e5ceea9232 update to emphasis the culling aspect of the test (making the line much longer,
and adding hairline and non-hairline cases.)



git-svn-id: http://skia.googlecode.com/svn/trunk@7371 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-24 17:33:21 +00:00
reed@google.com
996f64f8e7 add bench for giant dashed lines, to test future optimizations for culling
git-svn-id: http://skia.googlecode.com/svn/trunk@7368 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-24 17:17:28 +00:00
reed@google.com
a8f23c7e1e use DEF_BENCH for clarity
git-svn-id: http://skia.googlecode.com/svn/trunk@7367 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-24 16:56:36 +00:00
jvanverth@google.com
e2bfd8b7b1 The oval path bench tests used to draw a circle, but I changed them to an oval
so that we could track performance changes for ovals. However, rendering the
stroked oval cases are now ~5ms slower since they're larger. This restores them
to something close to their original performance by slightly shrinking the
bounds. This will help determine what effect r7304 may have had.


git-svn-id: http://skia.googlecode.com/svn/trunk@7365 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-24 15:45:35 +00:00
bensong@google.com
7fa58acb04 Changes per-tile bench values to use the average of repetitions from new bench log output.
Corresponding logs change was done at https://codereview.appspot.com/7101060/ and this CL needs to be submitted together with that one for data consistency. Then we can turn on timePerTile.
Review URL: https://codereview.appspot.com/7193051

git-svn-id: http://skia.googlecode.com/svn/trunk@7351 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-23 20:51:17 +00:00
robertphillips@google.com
194bf824f0 Reverse sense of convex-quad-fix compiler flag
https://codereview.appspot.com/7206045/



git-svn-id: http://skia.googlecode.com/svn/trunk@7349 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-23 20:45:26 +00:00
reed@google.com
eebdd966c1 add rand10 bench for sort, which makes 10% of the entries repeats
reorder sort tests to make comparisons easier to read



git-svn-id: http://skia.googlecode.com/svn/trunk@7338 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-23 14:52:12 +00:00
mike@reedtribe.org
a3f1c8e2fe add bench for sorting
git-svn-id: http://skia.googlecode.com/svn/trunk@7330 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-23 02:23:40 +00:00
robertphillips@google.com
1e3052354a Fix bug in 1xN SkBitmapProcShader optimization
https://codereview.appspot.com/7187047/



git-svn-id: http://skia.googlecode.com/svn/trunk@7325 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 20:29:16 +00:00
jvanverth@google.com
46d3d39e65 Add GPU support for axis-aligned ovals:
- Add drawOval base function to SkDevice, and override in SkGpuDevice
- Move isSimilarityMatrix to SkMatrix (renamed to isSimilarity) and fixed up unit test
- Since both SkGpuDevice::drawOval() and GrContext::drawPath() can try to draw ovals, added GrContext::canDrawOval() and GrContext::internalDrawOval() to avoid duplicate code
- Hooked in axis-aligned oval fill shader
- Enabled GPU stroked circles
- Added stroked circle bench test

Review URL: https://codereview.appspot.com/7137050



git-svn-id: http://skia.googlecode.com/svn/trunk@7304 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 13:34:01 +00:00
skia.committer@gmail.com
15dd300ac6 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7268 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 07:07:28 +00:00
robertphillips@google.com
8e679fe023 Added new bench to test out 1xN BitmapProcShaders
https://codereview.appspot.com/7160043/



git-svn-id: http://skia.googlecode.com/svn/trunk@7264 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 19:51:41 +00:00
tomhudson@google.com
7cfb9c7b61 Revert r7241, which broke tests on most platforms.
git-svn-id: http://skia.googlecode.com/svn/trunk@7245 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 13:29:35 +00:00
tomhudson@google.com
21e4322b92 Add SSE2 multiplication for SkMatrix44 on some platforms.
Original author whunt@chromium.org.
https://codereview.appspot.com/7058077/



git-svn-id: http://skia.googlecode.com/svn/trunk@7241 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 12:17:00 +00:00
junov@chromium.org
20bd04e365 Turn on the kUsePathBoundsForClip_RecordingFlag in bench, gm and tools that use class PictureRenderer
Chrome uses this flag for recording to skpicture in order to improve performance.
Therefore, skai benchmarks should run with this flag enabled, and we need 
gm and render_pictures test coverage to validate it.  In gm, the vanilla 
SkPicture test step will still run without the flag to ensure that case still gets test
coverage, while the SkPicture test steps that use rtree and tileGrid will now run with
the flag enabled.
Review URL: https://codereview.appspot.com/7111043

git-svn-id: http://skia.googlecode.com/svn/trunk@7234 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-16 18:43:36 +00:00
bsalomon@google.com
4e23068b37 Re-enable inst counting in debug builds.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7098066

git-svn-id: http://skia.googlecode.com/svn/trunk@7206 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-15 20:37:04 +00:00
reed@google.com
9318231178 add benches for drawBitmapRectToRect with slight scale/translate
git-svn-id: http://skia.googlecode.com/svn/trunk@7202 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-15 20:21:19 +00:00
bsalomon@google.com
33cdbdea3d Fix leaks in blurrect benchs and gm.
Review URL: https://codereview.appspot.com/7071060

git-svn-id: http://skia.googlecode.com/svn/trunk@7142 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-11 20:54:44 +00:00
jvanverth@google.com
a543b604e4 Add clear after each image save, so that GPU images won't end up progressively compositing on top of one another.
git-svn-id: http://skia.googlecode.com/svn/trunk@7108 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-09 18:22:53 +00:00
mike@reedtribe.org
732fbee1cb speculative change to speedup blurrect bench for large radius, to see if the bots are timing out
git-svn-id: http://skia.googlecode.com/svn/trunk@7098 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-09 00:59:11 +00:00
reed@google.com
cb88d32b9f fix warnings (float to int), and convert to skia-style
style examples:
- use const: (const SkRect&) instead of (SkRect&)
- spacing: (Type& r) instead of ( Type &r )
- use SK_OVERRIDE
Review URL: https://codereview.appspot.com/7066051

git-svn-id: http://skia.googlecode.com/svn/trunk@7069 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 21:54:25 +00:00
humper@google.com
05af1afd42 eliminate all warnings in non-thirdparty code on mac
Most of these issues were due to functions whose definitions appear in header files; I changed those functions to be 'static inline' instead of just 'static' or 'inline', which kills the warning for such functions.

Other functions that were static or anonymous-namespaced but were unused in cpp files were probably called at some point but are no longer; someone who knows more than I do should probably scrub all the functions I either deleted or #if 0'ed out and make sure that the right thing is happening here.

Lots of unused variables removed, and one nasty const issue handled.

There remains a single warning in thirdparty/externals/cityhash/src/city.cc on line 146 related to a signed/unsigned mismatch.  I don't know if we have control over this library so I didn't fix this one, but perhaps someone could do something about that one.

BUG=

Review URL: https://codereview.appspot.com/7067044

git-svn-id: http://skia.googlecode.com/svn/trunk@7051 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 16:47:43 +00:00