AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
19,201 Commits 1 Branch 0 Tags 544 MiB
77a2e52c7d
Commit Graph

57 Commits

Author SHA1 Message Date
msarett
e6dd004c1b Fill incomplete images in SkCodec parent class 
Rather than implementing some sort of "fill" in every
SkCodec subclass for incomplete images, let's make the
parent class handle this situation.

This includes an API change to SkCodec.h

SkCodec::getScanlines() now returns the number of lines it
read successfully, rather than an SkCodec::Result enum.
getScanlines() most often fails on an incomplete input, in
which case it is useful to know how many lines were
successfully decoded - this provides more information than
kIncomplete vs kSuccess.  We do lose information when the
API is used improperly, as we are no longer able to return
kInvalidParameter or kScanlineNotStarted.

Known Issues:
Does not work for incomplete fFrameIsSubset gifs.
Does not work for incomplete icos.

BUG=skia:

Review URL: https://codereview.chromium.org/1332053002
 2015-10-09 11:07:34 -07:00
egdaniel
ccb88bcab0 Blacklisting imagefilterscropexpand on s4 since it often causes the bot to hang and crash. 
BUG=skia:4079

Review URL: https://codereview.chromium.org/1373763005
 2015-10-06 11:20:09 -07:00
halcanary
c11c62f4a2 DM: PDFSink sets rasterizer keyword 
Review URL: https://codereview.chromium.org/1376573002
 2015-09-28 11:51:54 -07:00
benjaminwagner
6fccec34d2 Blacklist ReadPixels on GalaxyS4 due to skia:4368. 
BUG=skia:4368

Review URL: https://codereview.chromium.org/1366723002
 2015-09-24 06:39:06 -07:00
benjaminwagner
59ea019fa0 Blacklist bleed_image on GalaxyS4. 
BUG=skia:4367

Review URL: https://codereview.chromium.org/1347143006
 2015-09-22 09:49:47 -07:00
borenet
cf72ed6a3e Skip scaled_tilemodes_npot on Galaxy S4 
It's hanging.

BUG=skia:3932

Review URL: https://codereview.chromium.org/1318503003
 2015-08-25 06:53:37 -07:00
emmaleer
8f4ba76742 SkScaledCodec class 
This class does scaling by using a scanlineDecoder.
getScanlines and skipScanlines are used for y sampling,
the swizzler is used for x sampling

this class is currently only working for png and jpeg images
I will update other Codec types to work soon

For SkJpegCodec to implement width wise swizzling it now
uses a swizzler. I ran performance tests on this change.
Here are the performance test results:
https://docs.google.com/a/google.com/spreadsheets/d/1D7-Q_GXD_dI68LZO005NNvb8Wq2Ee0wEBEPG72671yw/edit?usp=sharing

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/0944100ac89f797714eeae0cf2875e2335ff52ee

Committed: https://skia.googlesource.com/skia/+/d518ea7927f9f4e0ed5b4134d1b4f48243855a47

Committed: https://skia.googlesource.com/skia/+/b157917507d4f7d2651f0aeb566d31603cc02240

Review URL: https://codereview.chromium.org/1260673002
 2015-08-14 07:44:46 -07:00
mtklein
e0effd6080 Allow Srcs to veto Sinks based on their broad type. 
This breaks Sinks down into three auto-detected types:
  - GPU:    anything that requests to be run in the GPU enclave
  - Vector: anything that writes to the stream instead of the bitmap
  - Raster: everything else

Some examples: gpu -> GPU, msaa16 -> GPU, 8888 -> raster, pdf -> vector,
               svg -> vector, pipe-8888 -> raster, tiles_rt-gpu -> GPU

This lets image decoding sinks veto non-raster backends explicitly,
and can let particular GMs veto GPU or non-GPU sinks as they like.

BUG=skia:

Review URL: https://codereview.chromium.org/1239953004
 2015-07-29 06:37:28 -07:00
borenet
9b8d3580c2 Skip imagefiltersclipped GM on Galaxy S4 
BUG=skia:4079

Review URL: https://codereview.chromium.org/1250473005
 2015-07-21 05:57:22 -07:00
scroggo
c1121efbc6 Stop running image tests on msaa. 
Blacklist all image tests on msaa. We do not run them anyway (since
they will not do anything interestingly different from drawing to the
raster backend) - we early exit from Src::draw(), but we still need to
create a render target that matches the size of the image (when not
blacklisted).

Remove the more specific blacklist of a particular image, which is
covered by this one.

BUG=skia:4045

Review URL: https://codereview.chromium.org/1234313006
 2015-07-16 12:36:10 -07:00
herb
19fb80ed14 Revert of Skip SkSharedMutexMultiThreaded test on TSAN bot while investigating. (patchset #1 id:1 of https://codereview.chromium.org/1213033003/) 
Reason for revert:
Add tsan annotations to repair tests.

Original issue's description:
> Skip SkSharedMutexMultiThreaded test on TSAN bot while investigating.
>
> The ~ means "don't run this".  This keeps all the other bots running the code, skipping it only on the whiny TSAN bot.
>
> BUG=skia:3997
>
> Committed: https://skia.googlesource.com/skia/+/37cc0b2e31e4a078b12790253d7032d36271440c

TBR=mtklein@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3997

Review URL: https://codereview.chromium.org/1218153004
 2015-06-30 14:23:29 -07:00
mtklein
37cc0b2e31 Skip SkSharedMutexMultiThreaded test on TSAN bot while investigating. 
The ~ means "don't run this".  This keeps all the other bots running the code, skipping it only on the whiny TSAN bot.

BUG=skia:3997

Review URL: https://codereview.chromium.org/1213033003
 2015-06-30 10:51:50 -07:00
joshualitt
b8e0b4a328 Revert of Disable failing GPU tests on Nexus 6. (patchset #1 id:1 of https://codereview.chromium.org/1185753002/) 
Reason for revert:
this should hopefully be fixed now.

Original issue's description:
> Disable failing GPU tests on Nexus 6.
>
> BUG=skia:3942
>
> Committed: https://skia.googlesource.com/skia/+/8ed08e54f4868d3ef88225bf873ce678e7716bd9

TBR=bsalomon@google.com,djsollen@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3942

Review URL: https://codereview.chromium.org/1196653002
 2015-06-19 07:28:15 -07:00
mtklein
1866b571f1 Stop running SKPs in DM on the bots. 
We're not triaging them, and we get the same coverage (both Release and Debug)
from nanobench.

BUG=skia:

Review URL: https://codereview.chromium.org/1178943006
 2015-06-12 11:31:51 -07:00
djsollen
8ed08e54f4 Disable failing GPU tests on Nexus 6. 
BUG=skia:3942

Review URL: https://codereview.chromium.org/1185753002
 2015-06-12 10:29:27 -07:00
djsollen
e21585eabf Update flags passed to Android GPU bots to exclude running skps and image sources. 
Review URL: https://codereview.chromium.org/1176923003
 2015-06-10 09:05:14 -07:00
bsalomon
0bb8c1f2b6 Stop running tiles_rt-gpu on the bots 
BUG=skia:

Review URL: https://codereview.chromium.org/1152003009
 2015-06-04 15:10:45 -07:00
mtklein
32618cb857 Test sp-8888 mode on a few fast bots. 
(It's not particularly slow, but this mode doesn't really need global coverage.)

BUG=skia:

Review URL: https://codereview.chromium.org/1129903003
 2015-05-07 10:26:44 -07:00
borenet
d9b6be197f Remove upright-matrix- configs from Android bots 
The Android bots are flaking like crazy. I'm not sure if these configs
are hurting the situation, but let's see if this helps.

TBR=mtklein,halcanary
BUG=skia:

Review URL: https://codereview.chromium.org/1131603002
 2015-05-06 08:33:51 -07:00
borenet
e3aeaec7dd Add matrix configs to DM 
BUG=skia:832

Review URL: https://codereview.chromium.org/1125793002
 2015-05-05 13:11:27 -07:00
mtklein
e4b19c4593 Add presubmit to run {dm,nanobench}_flags.py test when changed. 
BUG=skia:

Review URL: https://codereview.chromium.org/1129443005
 2015-05-05 10:28:44 -07:00
borenet
f4e0857fe9 Blacklist tiles_rt-gpu gm imagefilterscropped on GalaxyS4 
BUG=skia:3802

Review URL: https://codereview.chromium.org/1115303004
 2015-05-05 08:28:23 -07:00
stephana
deee2980f4 cleanup 
BUG=skia:

Review URL: https://codereview.chromium.org/1085583006
 2015-05-05 07:55:06 -07:00
borenet
97025e34d3 Run DM on GalaxyS* in one thread 
Drive-by cleanup of Xoom

BUG=skia:3214

Review URL: https://codereview.chromium.org/1106173004
 2015-04-28 09:54:55 -07:00
mtklein
d557462f1f Skip msaa4 on Tegra 2 and 3. 
This will fix the N7 and Xoom bots.

TBR=borenet@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/1099943002
 2015-04-21 11:25:47 -07:00
mtklein
fca5c88873 Ask for NVPR only when we expect it to be available. 
BUG=skia:

Review URL: https://codereview.chromium.org/1099023003
 2015-04-21 10:34:47 -07:00
borenet
22ecae88ee Blacklist desk_wikipedia pdf on Valgrind bots 
BUG=skia:3506

Review URL: https://codereview.chromium.org/1056763004
 2015-04-13 13:29:26 -07:00
msarett
3c309db75b Implementing filling for SkBmpCodec 
The bmp codec currently returns kIncompleteInput
when the stream is truncated, which we treat as a
partial success.  However, we neglect the fill the
remaining pixels in the image, leaving these
uninitialized.

This CL addresses this problem by initializing the
remaining pixels in the image to default values.

BUG=skia:3257

Review URL: https://codereview.chromium.org/1075243003
 2015-04-10 14:36:49 -07:00
Mike Klein
fbcf0bd7ff expand pdf/worldjournal blacklist entry to cover the new skp too 
BUG=skia:

Review URL: https://codereview.chromium.org/1070013002
 2015-04-09 06:03:22 -04:00
msarett
2f273a1ed0 Adding non-deterministic images to blacklist 
BUG=skia:3653

Review URL: https://codereview.chromium.org/1054593006
 2015-04-06 08:38:49 -07:00
djsollen
54416de523 Update DM to allow Src's to have optional options. 
Review URL: https://codereview.chromium.org/1059513002
 2015-04-03 07:24:48 -07:00
borenet
11106f196e Skip desk_baidu skp on Valgrind bot 
This has been running for 16 hours:
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Valgrind/builds/12/

BUG=skia:3506

Review URL: https://codereview.chromium.org/1056883002
 2015-04-02 07:24:03 -07:00
borenet
1e37d1762c Update [dm|nanobench]_flags for CPU/GPU split 
TBR=mtklein
NOTREECHECKS=true
BUG=skia:2073

Review URL: https://codereview.chromium.org/1036223002
 2015-03-27 05:42:18 -07:00
mtklein
ce86687310 pdf skp tabl_worldjournal.skp took 5 days to run on Valgrind 
#notry

BUG=skia:
NOTRY=true

Review URL: https://codereview.chromium.org/1030263003
 2015-03-26 05:12:13 -07:00
msarett
114912d4b9 Fix android_run_skia script to allow for larger blacklist 
BUG=skia:

Review URL: https://codereview.chromium.org/1011653004
 2015-03-25 12:28:33 -07:00
tomhudson
7aa846c683 Revert of Enabling ico decoding with use of png and bmp decoders (patchset #10 id:280001 of https://codereview.chromium.org/1011343003/) 
Reason for revert:
Reverting on suspicion of massive bot failures - possible command line too long?

Original issue's description:
> Enabling ico decoding with use of png and bmp decoders
>
> BUG=skia:3257
>
> Committed: https://skia.googlesource.com/skia/+/15bfd075d38e4422a477e22940d06a137f66cc97

TBR=scroggo@google.com,reed@google.com,djsollen@google.com,msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3257

Review URL: https://codereview.chromium.org/1022843005
 2015-03-24 13:47:41 -07:00
msarett
15bfd075d3 Enabling ico decoding with use of png and bmp decoders 
BUG=skia:3257

Review URL: https://codereview.chromium.org/1011343003
 2015-03-24 12:24:27 -07:00
egdaniel
89c2a540a3 Blacklist certain win7 gms that are never finishing on dm 
BUG=skia:

Review URL: https://codereview.chromium.org/1013483004
 2015-03-19 13:09:17 -07:00
mtklein
905d01b95a temporarily stifle Math test on TSAN bot 
BUG=skia:3562

Review URL: https://codereview.chromium.org/1017283002
 2015-03-18 14:06:56 -07:00
mtklein
e2aab90979 DM: disable image src type on Windows. 
BUG=skia:

Review URL: https://codereview.chromium.org/1012183002
 2015-03-17 12:52:16 -07:00
mtklein
de7665a6d5 Skip absurdly slow PDF tests on Valgrind bot. 
Our Valgrind-with-keepalive CPU bot is still running its first run as I write
this.  It's been going ~48 hours.  'pdf gm fontmgr_iter' finished after ~19
hours.  'pdf image PANO_20121023_214540.jpg' still seems to be running.

After this, the next slowest will be '565 gm fontmgr_iter' at about 37 minutes.

TBR=borenet@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/1003423002
 2015-03-14 07:24:29 -07:00
mtklein
cc99dbc57b Skip WritePixels on GalaxyS3 
TBR=bsalomon@google.com

NOTREECHECKS=true

BUG=skia:

Review URL: https://codereview.chromium.org/994343003
 2015-03-11 08:43:43 -07:00
mtklein
4e2d3be035 Don't run ResourceCache unit test on NexusPlayer. 
TBR=bsalomon@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/992203005
 2015-03-10 11:55:18 -07:00
mtklein
7e78f3d0e7 Fix bug in Valgrind flags config. 
'GPU' is in 'Test-Ubuntu14-GCE-NoGPU-x86_64-Release-Valgrind_CPU' too.

This means we're building it in no-GPU mode, and running it in no-CPU mode.
At least it finishes quite quickly this way (~10 seconds).

BUG=skia:

Review URL: https://codereview.chromium.org/992203004
 2015-03-10 08:03:26 -07:00
borenet
13e51f91ef Run Valgrind bots with --nogpu and --nocpu as appropriate 
BUG=skia:3506
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/986583004
 2015-03-09 06:59:16 -07:00
mtklein
150d3503ed When running under Valgrind, don't draw .webps into .pdfs. 
This blacklist entry bans any test with 'pdf' config, any source type, whose
name has '.webp' in it.  In practice, that's 'image' or 'subset' source type
decoding some WEBP file.

BUG=skia:3505

Review URL: https://codereview.chromium.org/982163002
 2015-03-05 13:38:17 -08:00
mtklein
13e8e23967 Disable --config pdf temporarily on Valgrind bot. 
BUG=skia:3505

Review URL: https://codereview.chromium.org/987533002
 2015-03-05 13:06:30 -08:00
mtklein
82b33dbcb2 DM: no PDF for Daisy either 
BUG=skia:

Review URL: https://codereview.chromium.org/974413002
 2015-03-04 13:58:05 -08:00
mtklein
84aada88ca DM: run PDF except on Android bots. 
While we work out RAM issues on Android, run everywhere else.

BUG=skia:

Review URL: https://codereview.chromium.org/971463004
 2015-03-04 11:47:11 -08:00
mtklein
341c808070 Revert of DM: run pdf config on the bots. (patchset #1 id:1 of https://codereview.chromium.org/968953002/) 
Reason for revert:
Will try this again after investigating OOMs on Xoom, N5 (i.e. the bots that actually run non-GPU work like PDF).

Original issue's description:
> DM: run pdf config on the bots.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/b12f88152c87e006d04fade4f106669cd9e44677

TBR=stephana@google.com,halcanary@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/959123003
 2015-03-02 09:51:44 -08:00