reed
78e2768897
Allow pictures to have a full bounds
...
This reverts commit 7c4cdd2c5b
.
BUG=skia:
Review URL: https://codereview.chromium.org/738083002
2014-11-19 08:04:34 -08:00
reed
7c4cdd2c5b
Revert of allow pictures to have a full bounds (patchset #3 id:40001 of https://codereview.chromium.org/736583004/ )
...
Reason for revert:
needed to update legacy width() helpers
Original issue's description:
> allow pictures to have a full bounds
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/7e76bff26e7c74902841ca4f607eb0b24a833a4a
TBR=fmalita@google.com ,mtklein@google.com,robertphillips@google.com,fmalita@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/722043005
2014-11-19 07:17:17 -08:00
reed
7e76bff26e
allow pictures to have a full bounds
...
BUG=skia:
Review URL: https://codereview.chromium.org/736583004
2014-11-19 06:59:41 -08:00
egdaniel
ec03a46080
Add processor name to comment when printing out shaders.
...
BUG=skia:
Review URL: https://codereview.chromium.org/735153002
2014-11-19 06:22:39 -08:00
reed
b07a94f1cb
add roundOut that returns its result
...
BUG=skia:
Review URL: https://codereview.chromium.org/742663002
2014-11-19 05:03:18 -08:00
skia.buildbots
b50612cbda
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/738003002
2014-11-18 23:06:53 -08:00
reed
d02cf2664d
change roundOut() to take a dst, so we can use that signature to return IRect
...
BUG=skia:
TBR=robertphilips
Review URL: https://codereview.chromium.org/731373003
2014-11-18 18:06:45 -08:00
joshualitt
d31985ecc8
setting patch_primitive_nvprmsaa4 on K1 to ignore
...
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/743563003
2014-11-18 17:38:36 -08:00
joshualitt
7eb8c7b00a
drawinfo carries bufferinfo
...
BUG=skia:
Review URL: https://codereview.chromium.org/737723003
2014-11-18 14:24:27 -08:00
Greg Humphreys
914dd53a42
ignore dashcubics test pending skia bug 2049
...
BUG=skia:2049
Review URL: https://codereview.chromium.org/741533002
2014-11-18 15:42:19 -05:00
Greg Humphreys
82e3552d68
a few straggling rebaselines
...
BUG=skia:
Review URL: https://codereview.chromium.org/738943003
2014-11-18 15:23:05 -05:00
Greg Humphreys
ccedeccdb7
more rebaselines for the perspective test server
...
BUG=skia:
Review URL: https://codereview.chromium.org/727063004
2014-11-18 15:19:45 -05:00
Greg Humphreys
174b2232d3
rebaseline new GTX images from drive update on linux
...
BUG=skia:
TBR=borenet
NOTRY=true
Review URL: https://codereview.chromium.org/735833002
2014-11-18 15:15:27 -05:00
robertphillips
8037653195
Add computation of saveLayer information to RecordingBench
...
In (Add flag to beginRecording to request saveLayer information - https://codereview.chromium.org/721883002/ ) I claimed the extra recording cost would be negligible. This CL attempts to put some numbers behind that.
Review URL: https://codereview.chromium.org/741523002
2014-11-18 11:53:02 -08:00
halcanary
6fd5e6e261
http://skbug.com/3130 step 4 (include/utils/SkWGL.h gone for good)
...
BUG=skia:3130
Review URL: https://codereview.chromium.org/729363003
2014-11-18 11:30:20 -08:00
reed
6be2aa9a25
wip for drawables
...
Idea:
1. in its mutable recording state, keep a table of drawables on the side, and store an index in the record list.
2. In "immediate-mode" draw, just call the clients drawable directly (need access to our private list to turn the stored index into a proc)
3. when we "snap", we replace the list of drawables with a list of (sub) pictures, and then during playback of the snapped picture, we invoke a private drawable which just calls "drawPicture" on the index'd subpicture.
Review URL: https://codereview.chromium.org/727363003
2014-11-18 11:08:05 -08:00
reed
ad3a8846f8
rebaseline after dont-normalize-matrix cl
...
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/738743003
2014-11-18 09:57:50 -08:00
joshualitt
780b11e4ec
fix for use of uninit variable
...
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/740463002
2014-11-18 09:40:40 -08:00
mtklein
0bd57b2e1e
SkVarAlloc::approxBytesAllocated()
...
This is what I was getting at on the other CL.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/f27f1bcce50c8f95aea8469684a70b70c9baee09
CQ_EXTRA_TRYBOTS=client.skia.android:Test-Android-Nexus5-Adreno330-Arm7-Release-Trybot
Review URL: https://codereview.chromium.org/730193003
2014-11-18 09:32:36 -08:00
mtklein
a06a953121
Prune SkRTree
...
- Propagate a bunch of constant parameters through.
- Delete code that's not used when bulk loading.
- Allocate all Nodes together.
- Stay in SkRect.
Doing a single malloc for the nodes can't not have improved memory usage.
Looks like this might improve record performance ~5%, probably mostly from
staying in SkRects. This finally dethrones building the BBH as the hot spot.
(Now it's mapping user bounds back to device bounds and adjusting for paints.)
Recording time changes from my MBP:
desk_rectangletransition.skp 11.5us -> 11.7us 1x
desk_forecastio.skp 115us -> 114us 0.98x
desk_booking.skp 550us -> 541us 0.98x
tabl_mercurynews.skp 176us -> 173us 0.98x
tabl_hsfi.skp 294us -> 287us 0.98x
desk_wordpress.skp 351us -> 343us 0.98x
tabl_worldjournal.skp 439us -> 426us 0.97x
tabl_gmail.skp 20.3us -> 19.7us 0.97x
desk_youtubetvvideo.skp 10.8us -> 10.4us 0.97x
desk_googleplus.skp 1.1ms -> 1.07ms 0.97x
tabl_slashdot.skp 106us -> 103us 0.97x
desk_jsfiddlebigcar.skp 26.7us -> 25.7us 0.96x
tabl_techmeme.skp 95.4us -> 91.7us 0.96x
tabl_deviantart.skp 133us -> 127us 0.96x
desk_pinterest.skp 40.6us -> 38.9us 0.96x
desk_carsvg.skp 195us -> 187us 0.96x
tabl_engadget.skp 376us -> 359us 0.96x
tabl_sahadan.skp 60.5us -> 57.5us 0.95x
tabl_culturalsolutions.skp 255us -> 242us 0.95x
tabl_gspro.skp 58.3us -> 55.5us 0.95x
desk_linkedin.skp 146us -> 138us 0.94x
desk_ebay.skp 192us -> 181us 0.94x
tabl_cnn.skp 467us -> 440us 0.94x
desk_jsfiddlehumperclip.skp 29.9us -> 28.1us 0.94x
desk_tigersvg.skp 43.2us -> 40.5us 0.94x
desk_yahooanswers.skp 131us -> 123us 0.94x
desk_googlespreadsheetdashed.skp 1.18ms -> 1.11ms 0.94x
desk_blogger.skp 193us -> 181us 0.94x
tabl_mozilla.skp 1.82ms -> 1.7ms 0.94x
tabl_mlb.skp 145us -> 136us 0.93x
mobi_wikipedia.skp 577us -> 539us 0.93x
tabl_frantzen.skp 54.1us -> 50.4us 0.93x
desk_baidu.skp 87.9us -> 81.9us 0.93x
desk_techcrunch.skp 224us -> 209us 0.93x
desk_sfgate.skp 206us -> 192us 0.93x
tabl_ukwsj.skp 269us -> 250us 0.93x
desk_facebook.skp 316us -> 293us 0.93x
desk_gmailthread.skp 205us -> 190us 0.93x
tabl_googlecalendar.skp 158us -> 147us 0.93x
tabl_digg.skp 382us -> 354us 0.93x
desk_amazon.skp 106us -> 98.5us 0.93x
tabl_androidpolice.skp 693us -> 642us 0.93x
tabl_nytimes.skp 206us -> 191us 0.92x
desk_gws.skp 124us -> 114us 0.92x
desk_youtube.skp 255us -> 235us 0.92x
tabl_cuteoverload.skp 583us -> 537us 0.92x
desk_oldinboxapp.skp 18us -> 16.6us 0.92x
desk_mobilenews.skp 297us -> 273us 0.92x
tabl_pravda.skp 168us -> 154us 0.92x
tabl_vnexpress.skp 236us -> 217us 0.92x
desk_css3gradients.skp 202us -> 185us 0.92x
tabl_gamedeksiam.skp 508us -> 464us 0.91x
desk_wowwiki.skp 1.02ms -> 929us 0.91x
desk_espn.skp 209us -> 191us 0.91x
desk_chalkboard.skp 315us -> 284us 0.9x
desk_mapsvg.skp 607us -> 543us 0.89x
desk_pokemonwiki.skp 5.18ms -> 4.62ms 0.89x
desk_samoasvg.skp 335us -> 298us 0.89x
desk_youtubetvbrowse.skp 10.1us -> 8.59us 0.85x
BUG=skia:3085, skia:2834
Review URL: https://codereview.chromium.org/734723002
2014-11-18 09:27:49 -08:00
mtklein
52b7822fa6
Revert of SkVarAlloc::approxBytesAllocated (patchset #5 id:80001 of https://codereview.chromium.org/730193003/ )
...
Reason for revert:
Android needs dlmalloc_usable_size().
Original issue's description:
> SkVarAlloc::approxBytesAllocated()
>
> This is what I was getting at on the other CL.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/f27f1bcce50c8f95aea8469684a70b70c9baee09
>
> CQ_EXTRA_TRYBOTS=Test-Android-Nexus5-Adreno330-Arm7-Release-Trybot
TBR=reed@google.com ,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/741443002
2014-11-18 08:15:23 -08:00
bsalomon
6d467ecb81
minor cleanup in GrGpu.h
...
Review URL: https://codereview.chromium.org/731073003
2014-11-18 07:36:19 -08:00
reed
611f3bb4cf
rebaseline perspective gm after matrix dont-renormalize-cl
...
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/741433002
2014-11-18 07:32:26 -08:00
mtklein
f27f1bcce5
SkVarAlloc::approxBytesAllocated()
...
This is what I was getting at on the other CL.
BUG=skia:
Review URL: https://codereview.chromium.org/730193003
2014-11-18 07:24:14 -08:00
reed
9b1dd15d6d
don't normalize after perspective concat
...
BUG=skia:
Review URL: https://codereview.chromium.org/734513004
2014-11-18 06:04:37 -08:00
kkinnunen
542ecbb2bd
Remove unused NVPR related GL tokens
...
Remove unused NVPR related GL tokens.
Also replace GR_GL_PATH_INITIAL_END_CAP and GR_GL_PATH_TERMINAL_END_CAP
with a single call setting GR_GL_PATH_END_CAPS. Skia does not and
probably will not have different initial and terminal caps. This came up
in the review of command buffer implementation of the extension.
If more NVPR features will be used, the respective tokens can be added
back per implemented feature.
Review URL: https://codereview.chromium.org/723453002
2014-11-18 05:13:48 -08:00
kkinnunen
b33402bc87
Do not calculate many sierpinski fractals for each nanobench run unless needed
...
Removes work done by the constructors of picture_nesting benches,
and moves the work to the Benchmark::onPreDraw override.
This avoids PictureNesting::sierpinsky showing up in profile traces
when profiling other benches.
Review URL: https://codereview.chromium.org/725523002
2014-11-18 04:50:50 -08:00
skia.buildbots
a8f38238d6
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/733323002
2014-11-17 23:03:57 -08:00
reed
a43da3ebfe
more baselines for blur2rects
...
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/715223003
2014-11-17 18:24:34 -08:00
joshualitt
fc63f66a31
one more rebase on k1
...
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/734243002
2014-11-17 17:59:49 -08:00
joshualitt
72f7e09ece
rebase nvpr after ds on stack
...
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/726103004
2014-11-17 16:48:13 -08:00
joshualitt
9853ccef19
Drawstate on stack
...
BUG=skia:
Review URL: https://codereview.chromium.org/732693002
2014-11-17 14:22:49 -08:00
reed
b079ec682d
baselines for blur2rects
...
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/733233002
2014-11-17 13:53:15 -08:00
bsalomon
b436ed6754
Reduce the amount of validation in GrResourceCache2
...
BUG=chromium:433711
Review URL: https://codereview.chromium.org/737533002
2014-11-17 12:15:57 -08:00
robertphillips
f52a063dfd
Fix yet another convexicator issue
...
This CL fixes the case where a bad initial vector (i.e., nearly zero) managed to short circuit all of the convexicator's logic. The initial bad vector would become the last vector and then never get displaced.
The history of this is:
https://codereview.chromium.org/298973004/
Switched the convexicator to not advance the last vector when the cross product wasn't significant
https://codereview.chromium.org/573763002/
Fixed a bug (crbug.com/412640) wherein a zero area path was being incorrectly categorized as convex b.c. opposite but equal vectors were not signaling concavity.
BUG=433683
Review URL: https://codereview.chromium.org/727283003
2014-11-17 12:11:42 -08:00
scroggo
a18cc77c33
Really enable deprecation warnings for Android framework.
...
Left out of a previous CL to reenable.
(We had the define added in two places for some reason...)
Review URL: https://codereview.chromium.org/728503002
2014-11-17 10:29:18 -08:00
borenet
0f881c64a3
Remove bug_chomper
...
It has been moved into buildbot repo.
BUG=skia:
Review URL: https://codereview.chromium.org/731123003
2014-11-17 09:59:53 -08:00
bsalomon
84c8e62fad
Allow GPU resources to not be counted against the cache budget.
...
BUG=skia:2889
Review URL: https://codereview.chromium.org/721353002
2014-11-17 09:33:27 -08:00
bsalomon
bd27e514e2
Rebase GM on win7 after res cache change.
...
TBR=
Review URL: https://codereview.chromium.org/733133003
2014-11-17 08:54:04 -08:00
robertphillips
8910879098
Make BBH parameter to SkRecordComputeLayers and SkRecordFillBounds optional
...
Chromium creates a picture to contain their picture pile in order to use MultiPictureDraw. They currently do not create a bounding box for that picture but I still need layer information for it. This change allows Chromium to continue without a BBH but still have layer information.
In the future, the brute force BBH might be suitable for their use case.
Please see gpu_raster_worker_pool.cc in (Add flag to beginRecording to request saveLayer information - https://codereview.chromium.org/721883002/ ) for where this is happening in Chromium.
Review URL: https://codereview.chromium.org/733963004
2014-11-17 08:16:15 -08:00
egdaniel
912b3d24a0
Use DrawStates ProcOptInfo when creating the Optimized Draw State.
...
BUG=skia:
Review URL: https://codereview.chromium.org/726693002
2014-11-17 07:45:53 -08:00
reed
468b6b4eaf
tweak gm to show fractional offsets
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/728403002
2014-11-17 07:41:35 -08:00
bsalomon
dace19ec17
Correct accounting for wrapped resources
...
BUG=skia:2889
Review URL: https://codereview.chromium.org/720033004
2014-11-17 07:34:06 -08:00
mtklein
c6ad9eefa0
More SkPicture cleanup
...
- move field declarations together and pack them a little tighter
- get rid of fData
- remove dead code in debugger, including unused SkPicturePlayback subclass
There are now no more long-lived SkPictureData! (Really, there never were,
but now we don't pretend to support them.)
BUG=skia:
No API changes.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/725143002
2014-11-17 06:45:18 -08:00
Greg Humphreys
21c771b3fc
Revert "move SkPDFD*.h from include to src"
...
This reverts commit 693024300f
.
was breaking canary build
BUG=skia:
Review URL: https://codereview.chromium.org/731173002
2014-11-17 09:42:09 -05:00
halcanary
693024300f
move SkPDFD*.h from include to src
...
BUG=278148
Review URL: https://codereview.chromium.org/727343002
2014-11-17 06:26:21 -08:00
reed
73c2501120
separate c headers
...
BUG=skia:
Review URL: https://codereview.chromium.org/728323002
2014-11-17 06:15:42 -08:00
sugoi
1379b87ae4
Added missing validation
...
BUG=433359
Review URL: https://codereview.chromium.org/729583002
2014-11-17 05:45:55 -08:00
skia.buildbots
0a81f1ee0e
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/731003004
2014-11-16 22:31:01 -08:00
halcanary
a27ef58a50
Move SkDocument_PDF.cpp into pdf.gypi - now standard PDF API
...
TBR=reed@google.com
Review URL: https://codereview.chromium.org/714223002
2014-11-16 08:26:54 -08:00