Commit Graph

36069 Commits

Author SHA1 Message Date
angle-skia-autoroll
6192d6f0f9 Roll third_party/externals/angle2 21e9baf71e6e..306b6c168dc7 (7 commits)
21e9baf71e..306b6c168d


git log 21e9baf71e6e..306b6c168dc7 --date=short --no-merges --format='%ad %ae %s'
2018-07-27 jmadill@chromium.org D3D11: Use angle::Result error pattern. 1/3
2018-07-27 geofflang@chromium.org Fix/supress issues with EGL images on Android.
2018-07-27 geofflang@chromium.org Don't sync the read framebuffer on draw calls.
2018-07-27 lrn1986@gmail.com Support EGL_(WIDTH|HEIGHT) in eglSurfaceAttrib(), fixed resize
2018-07-27 jmadill@chromium.org D3D: Return error from getVertexSpaceRequired.
2018-07-27 jmadill@chromium.org D3D: Pass gl::Context to many more functions.
2018-07-27 jmadill@chromium.org D3D: Add streaming buffer initialize.


Created with:
  gclient setdep -r third_party/externals/angle2@306b6c168dc7

The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=benjaminwagner@google.com

Change-Id: I927dd70642666004fcf190aa86e326345d1f3667
Reviewed-on: https://skia-review.googlesource.com/144180
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-28 00:12:20 +00:00
Herb Derby
80eb42ba9e Take advantage of newly const ref text stack
Change-Id: Ib09669cbacc7b466c268af7a7bc1341b7d9e9916
Reviewed-on: https://skia-review.googlesource.com/144124
Commit-Queue: Herb Derby <herb@google.com>
Auto-Submit: Herb Derby <herb@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-07-27 21:45:00 +00:00
Brian Salomon
2183142fea Update .clang-format to handle Objective-C files
Change-Id: I8686681ee9b96f0447f03a26e5568964ec5be6d9
Reviewed-on: https://skia-review.googlesource.com/144121
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-07-27 21:33:30 +00:00
Herb Derby
c3bc69f238 Rename MakeAsTextDraw to MakeFromText
Change-Id: I3fbb4d27b728e5fc5ecec9fc9d9e215dd5a83359
Reviewed-on: https://skia-review.googlesource.com/144123
Commit-Queue: Herb Derby <herb@google.com>
Commit-Queue: Cary Clark <caryclark@google.com>
Auto-Submit: Herb Derby <herb@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>
2018-07-27 21:03:26 +00:00
Herb Derby
46dbfbb528 Make regenerateGlyphRunList on use the iterator
Change-Id: Iba68c94a62b535031594dcff46fd73ed36613b95
Reviewed-on: https://skia-review.googlesource.com/144120
Commit-Queue: Herb Derby <herb@google.com>
Auto-Submit: Herb Derby <herb@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-07-27 20:55:16 +00:00
Chris Dalton
79f99f7bf2 Fix a crash in the clockwise gm
Bug: skia:
Change-Id: Idc441d15bb03ef57ba82bb59249cce0c220c0488
Reviewed-on: https://skia-review.googlesource.com/144141
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-07-27 20:42:46 +00:00
recipe-roller
1552a43ab2 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/d795ab891c157bcda542f9cab5375805a19af7b0 Use system unzip on macOS (jeremya@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I24aa0b604d23f97d15f9121418ce34629e33b350
Reviewed-on: https://skia-review.googlesource.com/144038
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-07-27 19:55:16 +00:00
Brian Salomon
4818244804 Remove unused kTexture2D_GrSLType and kSampler_GrSLType
Also remove unused GrSLTypeIs2DCombinedSamplerType

Bug: skia:
Change-Id: I9c670535dbbc30ddeb3636acb5b784580a968ee4
Reviewed-on: https://skia-review.googlesource.com/144035
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-07-27 19:49:18 +00:00
ziadb
883ed3000e SkAR Java: fixed runtime bugs, better UI
Bug: skia:
Change-Id: Ibfee885f5ed655c2f838d637406406da90f0c6fd
Reviewed-on: https://skia-review.googlesource.com/144033
Reviewed-by: Mike Reed <reed@google.com>
2018-07-27 19:47:18 +00:00
Brian Salomon
db10ed097f Remove unused kBufferSampler_GrSLType
Change-Id: I3e0476d92dfde928ef7d49155afdc3685c4ca03e
Reviewed-on: https://skia-review.googlesource.com/144023
Auto-Submit: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-07-27 19:42:46 +00:00
Chris Dalton
49d14e98fe sksl: Add a "sk_Clockwise" built-in
This allows us to identify clockwise-winding triangles, in terms of
Skia device space, in all backends and with all render target origins.

Bug: skia:
Change-Id: I220e1c459e0129d1cc4dee6458ef94277fbedd21
Reviewed-on: https://skia-review.googlesource.com/142662
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2018-07-27 19:04:46 +00:00
Herb Derby
f4f6bbfada Duplicate drawDFPosText into drawDFGlyphRun
This CL has duplicate code, but this should be a small CL to
judge how glyphRuns will change the code.

Change-Id: Ib4700aa9d19ae3811090796a2c59bbe746361202
Reviewed-on: https://skia-review.googlesource.com/144022
Auto-Submit: Herb Derby <herb@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-07-27 18:28:56 +00:00
Ethan Nicholas
88f6d37f3f Fixed GLSL header line ordering
Under some circumstances, an extension could be written after a global variable.
This should fix the ordering so that can never happen again.

Bug: b/111582212
Change-Id: Id2f7645253fdc521ba85ca0e6863236baef63a4b
Reviewed-on: https://skia-review.googlesource.com/143102
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2018-07-27 17:23:46 +00:00
ziadb
55e553525d SkAR Java: DrawManager dox and minor changes, removed unnecessary files
Bug: skia:
Change-Id: If1a92c5b70d99233208f7db74f5dda9641b1c65b
Reviewed-on: https://skia-review.googlesource.com/144027
Reviewed-by: Mike Reed <reed@google.com>
2018-07-27 17:17:04 +00:00
Robert Phillips
6fc3092af1 Fix TSAN bug in TransferPixelsTest
Change-Id: I067d9e86d00ab6bfa91e2d22725b26315a3ec348
Reviewed-on: https://skia-review.googlesource.com/144026
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-07-27 17:07:26 +00:00
recipe-roller
8e8fec7299 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/f12600a8ba80826493da5648ee82e2bf2e6a5782 [cipd] Update cipd and vpython to v2.2.3. (vadimsh@chromium.org)
  https://crrev.com/3e65878e5ed466eba11b87e98a5429d062e7ffef Add --patch_ref to bot_update. (jbudorick@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I56375a2b68db44129bc0d1161eafca76323cff76
Reviewed-on: https://skia-review.googlesource.com/144028
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-07-27 16:54:27 +00:00
Herb Derby
227424b57d Remove SkTextBlobRunIterator.h from gni
Change-Id: I62d43c19899b4cccca9bf285a06de70a969fbe9f
Reviewed-on: https://skia-review.googlesource.com/144024
Commit-Queue: Herb Derby <herb@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Auto-Submit: Herb Derby <herb@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-07-27 16:34:17 +00:00
ziadb
2175f1b1b7 SkAR Java: minor refactoring to TapHelper (now GestureHelper)
Bug: skia:
Change-Id: I1983c6cb1727e86fec91a0c9a5706f26070b1b49
Reviewed-on: https://skia-review.googlesource.com/144021
Reviewed-by: Mike Reed <reed@google.com>
2018-07-27 16:01:47 +00:00
ziadb
3c9a0c04f2 SkAR Java: refactoring main app class & finger painting class
Main things to look at:
1) onDrawFrame changes + moving many functions as separate helpers
2) SkARFingerPainting changes (name should change too)

Bug: skia:
Change-Id: I5068ce6c416a2f5d6c6c389cd63d08d5350e83e6
Reviewed-on: https://skia-review.googlesource.com/143701
Reviewed-by: Mike Reed <reed@google.com>
2018-07-27 15:46:21 +00:00
angle-skia-autoroll
4a466d6909 Roll third_party/externals/angle2 18f7e5033040..21e9baf71e6e (2 commits)
18f7e50330..21e9baf71e


git log 18f7e5033040..21e9baf71e6e --date=short --no-merges --format='%ad %ae %s'
2018-07-27 thomasanderson@chromium.org Roll Vulkan-Loader to a835880
2018-07-27 oetuaho@nvidia.com Fix multiview combined with flat interpolation


Created with:
  gclient setdep -r third_party/externals/angle2@21e9baf71e6e

The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=benjaminwagner@google.com

Change-Id: I7b9d24576fed8e8d841925562642a09bd3608de2
Reviewed-on: https://skia-review.googlesource.com/143954
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-27 15:22:17 +00:00
Mike Klein
7af351a68c add imgcvt
This uses skcms to convert an image into a PNG with a new color profile.

Change-Id: Iaefdbbfba6f4b85637386569a65355df255b980d
Reviewed-on: https://skia-review.googlesource.com/143709
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
2018-07-27 15:11:17 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
60f1d83f65 Roll skia/third_party/skcms 4642d9fe69e1..23e7777f421d (1 commits)
https://skia.googlesource.com/skcms.git/+log/4642d9fe69e1..23e7777f421d

2018-07-27 mtklein@google.com clamp before premul


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=benjaminwagner@google.com

Change-Id: Ia9898102aae04ad07057e1a5af1de8ad108d9631
Reviewed-on: https://skia-review.googlesource.com/143735
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-27 15:06:27 +00:00
Florin Malita
ab54e7394d Hide SkTextBlob::GlyphPositioning from public API
Make private, add corresponding SkTextBlobRunIterator enum.

Also move SkTextBlobRunIterator to SkTextBlobPriv.h.

Change-Id: If3e0beabb0e8484b1ac73c6fc0827e920ca1f93b
Reviewed-on: https://skia-review.googlesource.com/142501
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>
2018-07-27 14:10:17 +00:00
Brian Salomon
504dd052b9 Reland "Go back to cleaning up MIP levels on texture export rather than assuming dirty on texture import."
This is a reland of 01d6fc9d84
Chrome layout tests have been suppressed so this shouldn't block a Skia roll.

Original change's description:
> Go back to cleaning up MIP levels on texture export rather than assuming dirty
> on texture import.
>
> Bug: skia:8155
> Change-Id: I23399f442d52c73906829132f798eda260b6d4ae
> Reviewed-on: https://skia-review.googlesource.com/143291
> Auto-Submit: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

Bug: skia:8155
Change-Id: Ia3843b66c2453daf15e566b7ecf890c2ff4aed22
Reviewed-on: https://skia-review.googlesource.com/143960
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-07-27 13:37:31 +00:00
Robert Phillips
da1be46e24 Add more optional debugging printouts for resource allocation
Change-Id: I84e9d2cc8862d366fab3f9142fee5b8ed981bed7
Reviewed-on: https://skia-review.googlesource.com/143705
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-07-27 13:35:22 +00:00
Robert Phillips
2739ab0986 Fix explicit resource allocator bug
This was folded into https://skia-review.googlesource.com/c/skia/+/142102 (Reduce arbitrary opList splitting when sorting (take 2)) but need not wait for that CL to land.

Change-Id: I883497129404fbf879e3c21f465f6debc5b5c2ed
Reviewed-on: https://skia-review.googlesource.com/143706
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-07-27 13:32:27 +00:00
Chris Dalton
9acfc6cac2 Add kAAHairline to GpuPathRenderers
With the upcoming ccpr stroking, this will no longer be the only path
renderer that can handle hairlines.

Bug: skia:
Change-Id: I45b30ccd578bee1388a3a07a234af76a19768de6
Reviewed-on: https://skia-review.googlesource.com/142272
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-07-27 13:30:17 +00:00
angle-skia-autoroll
55b1e61684 Roll third_party/externals/angle2 dbd1612782f5..18f7e5033040 (1 commits)
dbd1612782..18f7e50330


git log dbd1612782f5..18f7e5033040 --date=short --no-merges --format='%ad %ae %s'
2018-07-27 fjhenigman@chromium.org Vulkan: make DynamicBuffer reusable, always valid.


Created with:
  gclient setdep -r third_party/externals/angle2@18f7e5033040

The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=benjaminwagner@google.com

Change-Id: Ie49c384f6ff75eafc3d2306bd7844f51df8e1691
Reviewed-on: https://skia-review.googlesource.com/143803
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-27 05:23:16 +00:00
Herb Derby
b935cf8e12 const all the things
Having the glyph run list be const as it passes through the stack means
that future change can't be introduced in the device code that changes
behavior. Try to force all text changes into the SkGylphRun system.

Change-Id: I9412bc094c7adb8554887c725a6264af306e1d42
Reviewed-on: https://skia-review.googlesource.com/143702
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-07-27 03:13:56 +00:00
recipe-roller
5f1dc76d0c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/19cca6a3bdcdee5825912f8102c2818885f777dc [cipd] Bump client (+vpython) v2.1.0 (521b9b6477) => v2.2.2 (03693197fe). (vadimsh@chromium.org)
recipe_engine:
  https://crrev.com/36cdb3033498ecf5b5834dbc58eca2542164cbed led: Add task link when launching a task (martiniss@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I21bd4000982a74972be2a53fc365ada052e6ea7c
Reviewed-on: https://skia-review.googlesource.com/143703
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-07-26 21:36:46 +00:00
ziadb
f27b479f95 SkAR Java: refactored project structure
1) Changed file paths
2) Added helpers that were missing previously

Bug: skia:
Change-Id: Idb4194fcef815a23277a17670acf46255a47451d
Reviewed-on: https://skia-review.googlesource.com/143680
Reviewed-by: Mike Reed <reed@google.com>
2018-07-26 19:37:04 +00:00
ziadb
3ab3b562b1 SkAR Java: changes to DrawManager/FingerPainting
Bug: skia:
Change-Id: I609fa91f89ec0cc011046d2f20716efd9b44d4da
Reviewed-on: https://skia-review.googlesource.com/143643
Reviewed-by: Mike Reed <reed@google.com>
2018-07-26 19:29:49 +00:00
Hal Canary
2863ff22e1 site: Documentation & Fiddle links on front page
No-Try: true
Change-Id: Ib687748189052bd5bf18a997dd324b047403ca47
Reviewed-on: https://skia-review.googlesource.com/143642
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
2018-07-26 19:25:46 +00:00
ziadb
c4db8708c9 SkAR Java: refactored SkARUtil (now PaintUtil)
SkAR Java: refactored SkARMatrix.java


Merge branch 'master' of https://skia.googlesource.com/skia into skar-java


SkAR Java: better UI for finger painting


Merge branch 'master' of https://skia.googlesource.com/skia into skar-java


SkAR Java: smooth finger painting, planes draw with outlines


SkAR Java: better finger painting. Cleaner UI


FREEZE.unindexed


SkAR Java: drawing planes as paths

Bug: skia:
Change-Id: I56a26b358f1c5903fafe20cacf221c6eb6585c4b
Reviewed-on: https://skia-review.googlesource.com/143541
Reviewed-by: Ziad Ben Hadj-Alouane <ziadb@google.com>
2018-07-26 18:58:16 +00:00
ziadb
aafaf924d5 SkAR Java: refactored SkARMatrix.java (now CanvasMatrixUtil.java)
Bug: skia:
Change-Id: I57ff2f723b2445270246c96ee35e9669e2b21954
Reviewed-on: https://skia-review.googlesource.com/143503
Reviewed-by: Mike Reed <reed@google.com>
2018-07-26 18:57:30 +00:00
angle-skia-autoroll
ec3726ecc5 Roll third_party/externals/angle2 203b26f27d00..dbd1612782f5 (1 commits)
203b26f27d..dbd1612782


git log 203b26f27d00..dbd1612782f5 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 geofflang@chromium.org EGL: Implement EGL Image extensions.


Created with:
  gclient setdep -r third_party/externals/angle2@dbd1612782f5

The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=benjaminwagner@google.com

Change-Id: I9d74eb22f3795f1406c97e9cc50159c54491ba77
Reviewed-on: https://skia-review.googlesource.com/143560
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-26 18:37:36 +00:00
ziadb
90edd336ee SkAR Java: better UI for finger painting
Merge branch 'master' of https://skia.googlesource.com/skia into skar-java


SkAR Java: smooth finger painting, planes draw with outlines


SkAR Java: better finger painting. Cleaner UI


FREEZE.unindexed


SkAR Java: drawing planes as paths

Bug: skia:
Change-Id: If138d1d840c013848b1482830713affa5b5d815b
Reviewed-on: https://skia-review.googlesource.com/143502
Reviewed-by: Mike Reed <reed@google.com>
2018-07-26 18:28:45 +00:00
Herb Derby
1347144e3e Centralize bitmap glyph positioning
Centralize all text drawing for bitmap devices into SkGlyphRunListDrawer.
All drawing decisions are encapsulated in this class, and its behavior
only depends on contant properties of the device.

The method drawForBitmap will probably have to be converted to a template
based in preliminary performance numbers.

Change-Id: Id21567c1511eee9d2e9e20c7ae93544530cfdb81
Reviewed-on: https://skia-review.googlesource.com/143106
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-07-26 18:16:46 +00:00
recipe-roller
97e858f359 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/c87d45b102ac4cdf4b325d53061cf81c66d9b1d7 metrics_utils: Print notice to stderr. (ehmaldonado@chromium.org)
  https://crrev.com/7e50ee376bd57b299fb70c812b6cf76f4c34414b [cipd] Try to bootstrap CIPD from scratch if selfupdate fails. (vadimsh@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I900298486f9ee3e2b89714b4695050078829236d
Reviewed-on: https://skia-review.googlesource.com/143548
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-07-26 18:14:56 +00:00
Brian Osman
a442526622 Correctly distinguish hairline paths in the SW path renderer's cache
We typically don't get hairline paths in the SW path renderer, but an
upcoming change (https://skia-review.googlesource.com/c/skia/+/142272)
makes it possible. Therefore, we need to distinguish between hairline
and filled paths. Additionally, the CPU renderer draws hairline paths
differently with round/square caps (extended by 1/2 pixel) than with
butt caps, so include that in the key, too.

Bug: skia:8188
Change-Id: I223c11f62ef1c13f0488f2ca8c19a19875fc3d9f
Reviewed-on: https://skia-review.googlesource.com/143540
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-07-26 18:08:36 +00:00
Florin Malita
41005c3e80 Update android_build_app Gradle output location
Looks like new Gradle (4.1) changed the output location from

  build/outputs/apk/{app}-{target_cpu}-{android_buildtype}.apk

to

  build/outputs/apk/{target_cpu}/{android_buildtype}/{app}-{target_cpu}-{android_buildtype}.apk

TBR=
Change-Id: I45ed38e1f1655f82ef4a205ef7e8baf3f2da50af
Reviewed-on: https://skia-review.googlesource.com/142806
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-07-26 18:07:06 +00:00
recipe-roller
0d7288bc17 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/bad59ca738cc8692ca8b2be801d8e991d41f1e6f Use `call` in recipe bundles to allow appending to the recipes.bat file. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibaa8b8caf5af9e13d1963dd1b263e907b3565015
Reviewed-on: https://skia-review.googlesource.com/143543
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-07-26 17:14:48 +00:00
ziadb
897f256413 SkAR Java: smooth finger painting, planes draw with outlines
Bug: skia:
Change-Id: I0e6f3c00f030f7a03c3829cd4ff22ac7459dc132
Reviewed-on: https://skia-review.googlesource.com/142685
Reviewed-by: Mike Reed <reed@google.com>
2018-07-26 15:29:41 +00:00
Stephen White
d26b4d865a GrTessellator: fix for collinear edge merging.
In some cases, two edges can be collinear when tested on one side
(e.g., left top vs right edge), but non-collinear when tested on the
other (e.g., right top vs left edge). We were actually merging based
on one criterion, but assserting based on the other.

The safest fix is to merge if either condition is true, and then
assert that both conditions are false.

Bug: 866319
Change-Id: Ia1be330caf62f6d7961746752f73993ca098d0a3
Reviewed-on: https://skia-review.googlesource.com/143501
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2018-07-26 14:38:56 +00:00
Ben Wagner
b5093bc9ed [infra] Add Metal to no_upload.
In https://skia-review.googlesource.com/c/skia/+/143107, the Metal tasks
were added with a whitelist of one unit test, so there are no Gold
results to upload. Gold treats the empty results files as invalid, which
generates Trooper alerts.

No-Try: true
Change-Id: Ifcdfccefb173c5cb970d60da5b7c3a89d6bc15db
Reviewed-on: https://skia-review.googlesource.com/143500
Commit-Queue: Stephan Altmueller <stephana@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
2018-07-26 14:30:16 +00:00
Robert Phillips
01a9128a6f Maybe fix numStencilBits TSAN crash
Bug: skia:7390
Change-Id: Ied9c92147324ddb1245df796cd201df35657bbe0
Reviewed-on: https://skia-review.googlesource.com/143304
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-07-26 13:37:26 +00:00
Cary Clark
b64db38b85 avoid uninitialized under fuzzer
https://skia-review.googlesource.com/143112
introduced new logic to handle failures;
fuzzer found a way to exploit this.

FWIW, skia's fuzzer did not call pathops when
fed the test case.

TBR=kjlubick@google.com

Bug:867314
Change-Id: Id894962d3f32e206362faff332a1330db75da175
Reviewed-on: https://skia-review.googlesource.com/143318
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
2018-07-26 12:04:17 +00:00
angle-skia-autoroll
f3ac64df17 Roll third_party/externals/angle2 eb4b86975848..203b26f27d00 (1 commits)
eb4b869758..203b26f27d


git log eb4b86975848..203b26f27d00 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 jiawei.shao@intel.com ES31: Translate compute shader HLSL system variables in compile time


Created with:
  gclient setdep -r third_party/externals/angle2@203b26f27d00

The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=benjaminwagner@google.com

Change-Id: I8bfa6e7acf50edafdeb583db9da2e35bc5c5a637
Reviewed-on: https://skia-review.googlesource.com/143480
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-26 09:40:55 +00:00
recipe-roller
e54cd95dc3 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/254538b955bd353e28da028e09c1f808367a4bf4 MIPS64: Add support for depot_tools on mips64. (wangqing-hf@loongson.cn)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If8e2d77f8e93ad2fe7fb65ef4774516b742f6643
Reviewed-on: https://skia-review.googlesource.com/143315
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-07-26 02:56:55 +00:00
angle-skia-autoroll
97613523e3 Roll third_party/externals/angle2 2160821e16db..eb4b86975848 (6 commits)
2160821e16..eb4b869758


git log 2160821e16db..eb4b86975848 --date=short --no-merges --format='%ad %ae %s'
2018-07-25 theoking@google.com Introduced eglMakeCurrent Perf Test
2018-07-25 jmadill@chromium.org Pass Context to Query Impl methods.
2018-07-25 jmadill@chromium.org Pass Context to Fence Impl methods.
2018-07-25 jmadill@chromium.org Vulkan: Fix compound nested sampler struct params.
2018-07-25 jmadill@chromium.org D3D11: Reduce allocations in GenerateInitialTextureData.
2018-07-25 jmadill@chromium.org D3D11: Pass Context to more Image methods.


Created with:
  gclient setdep -r third_party/externals/angle2@eb4b86975848

The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=benjaminwagner@google.com

Change-Id: I988f1a0b884c41fea3e769a3079f212d07e178aa
Reviewed-on: https://skia-review.googlesource.com/143341
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-07-26 00:21:55 +00:00