Robert Phillips
318c419d3e
Remove RenderTarget pointer from GrRenderTargetOpList::RecordedOp
...
Change-Id: I08afe531cd9c65af4b3f6b6006bc3eaf7071cfec
Change-Id: I08afe531cd9c65af4b3f6b6006bc3eaf7071cfec
Reviewed-on: https://skia-review.googlesource.com/17117
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-05-17 14:19:40 +00:00
Robert Phillips
f7a7261b4a
Add tracking of unique proxyID beside unique renderTargetID in auditTrail and clearOp
...
Split out of: https://skia-review.googlesource.com/c/10284/ (Omnibus: Remove GrSurface-derived classes from ops)
Change-Id: I5845a47d94decc455ec3b1f0a5876b1c82aa32e8
Reviewed-on: https://skia-review.googlesource.com/10750
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2017-03-31 16:11:30 +00:00
Brian Salomon
69868af684
Remove render target unique ID virtual from GrOp.
...
GrRenderTargetOpList now stores the IDs along side each op.
This should put us closer to using proxy IDs and not forcing early render target instantiation as many comments point towards.
Change-Id: I1ee82b01a0818a80d2bcac39fdf3a4ee7dccecc9
Reviewed-on: https://skia-review.googlesource.com/6403
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2016-12-22 21:10:48 +00:00
Brian Salomon
42ad83ac19
Rename batch->op in GrAuditTrail.
...
Change-Id: I68670e5ceb06716e9928ee58485d63e157c7aca7
Reviewed-on: https://skia-review.googlesource.com/6345
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2016-12-20 21:50:09 +00:00
Brian Salomon
25a880960a
Rename GrBatch to GrOp
...
Change-Id: I27b6324f8040899fafeda23ca524bc54a4dbf090
Reviewed-on: https://skia-review.googlesource.com/5392
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2016-12-01 15:12:53 +00:00
Robert Phillips
294870ff11
Add explicit UniqueID classes for GrGpuResource & GrSurfaceProxy
...
This sets the stage for using the Proxy's/RenderTargetContext's ID above the flush and the RenderTarget's/GrGpuResource's below the flush.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4650
Change-Id: I9f1e6b00c02a0691d90b58c49e1d8c60684884c1
Reviewed-on: https://skia-review.googlesource.com/4650
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2016-11-11 18:24:56 +00:00
bungeman
6bd5284415
Remove SkAutoTUnref and SkAutoTDelete from public includes.
...
This also makes the required changed to src, tests, and tools. The few
public APIs modified by this change appear to be unused outside of Skia.
Removing these from the public API makes it easier to ensure users are
no longer using them.
This also updates GrGpu::wrapBackendXXX and the
::onWrapBackendXXX methods to clarify ownership.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2448593002
Review-Url: https://codereview.chromium.org/2448593002
2016-10-27 09:30:08 -07:00
joshualitt
b0666ad3a9
Fix up GrAuditTrail to allow arbitrary reordering
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1765123002
Review URL: https://codereview.chromium.org/1765123002
2016-03-08 10:43:42 -08:00
joshualitt
46b301d222
add /img/n/m endpoint to skiaserve
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1755563003
Review URL: https://codereview.chromium.org/1755563003
2016-03-02 08:32:37 -08:00
joshualitt
f55c364485
Wire up stack traces again
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1749163002
Review URL: https://codereview.chromium.org/1749163002
2016-03-02 08:11:34 -08:00
joshualitt
df3f2b0948
Move some GrAuditTrail fuctions to cpp file
...
TBR=ethannicholas@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1753753002
Review URL: https://codereview.chromium.org/1753753002
2016-03-01 07:47:56 -08:00
joshualitt
1d7decffbc
SkDebugCanvas ignore batch bounds if they are offscreen
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1754633002
Review URL: https://codereview.chromium.org/1754633002
2016-03-01 07:15:52 -08:00
joshualitt
10d8fc29bc
Render batch bounds as stroke rects
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1745063002
Review URL: https://codereview.chromium.org/1745063002
2016-02-29 11:15:06 -08:00
joshualitt
b95c772d45
Add abilitly to query audit trail for batches by draw op
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1745513002
Committed: https://skia.googlesource.com/skia/+/9b48a6e3f862076018cc7d63b180b6340f4873cd
Review URL: https://codereview.chromium.org/1745513002
2016-02-29 07:44:02 -08:00
joshualitt
08fc80704d
Revert of Add abilitly to query audit trail for batches by draw op (patchset #4 id:60001 of https://codereview.chromium.org/1745513002/ )
...
Reason for revert:
kInvalidID conflicts with an older xCode #define
Original issue's description:
> Add abilitly to query audit trail for batches by draw op
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1745513002
>
> Committed: https://skia.googlesource.com/skia/+/9b48a6e3f862076018cc7d63b180b6340f4873cd
TBR=ethannicholas@google.com ,jcgregorio@google.com,joshualitt@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1747893002
2016-02-29 06:32:24 -08:00
joshualitt
9b48a6e3f8
Add abilitly to query audit trail for batches by draw op
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1745513002
Review URL: https://codereview.chromium.org/1745513002
2016-02-29 05:20:38 -08:00
joshualitt
18d6b75829
Add batchlist managment to GrAuditTrail
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1724243004
Review URL: https://codereview.chromium.org/1724243004
2016-02-26 08:07:50 -08:00
ethannicholas
c85d9fbc0a
GrAuditTrail can now be enabled/disabled at runtime
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1712753002
TBR=bsalomon@google.com
Doesn't actually change the public API
Review URL: https://codereview.chromium.org/1712753002
2016-02-18 13:45:40 -08:00
joshualitt
adab5a2a4b
fix comma in GrAuditTrail json
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1704133002
Review URL: https://codereview.chromium.org/1704133002
2016-02-18 05:04:39 -08:00
joshualitt
6b3cf73af5
Add batch information to json
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1705093002
Review URL: https://codereview.chromium.org/1705093002
2016-02-17 11:20:26 -08:00
joshualitt
11fae87d39
Virtualize Frames in GrAuditTrail
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1581943004
Review URL: https://codereview.chromium.org/1581943004
2016-01-14 10:58:07 -08:00
joshualitt
87a721b246
Convert GrAuditTrail to use scoped frames
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1579193002
Review URL: https://codereview.chromium.org/1579193002
2016-01-12 12:59:28 -08:00
joshualitt
086cee12de
Add batch names and bounds to json debug information
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1577093003
Review URL: https://codereview.chromium.org/1577093003
2016-01-12 06:45:24 -08:00
joshualitt
5651ee6376
Change to wire up opnames in SkGpuDevice
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1565113004
Review URL: https://codereview.chromium.org/1565113004
2016-01-11 10:39:11 -08:00
joshualitt
27a48dc0cd
Create stub GrAuditTrail class
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1572553002
Review URL: https://codereview.chromium.org/1572553002
2016-01-08 07:19:47 -08:00