bsalomon
6d9a213694
If scissor would be empty in GrClipMaskManager::SetupClipping indicate draw can be skipped.
...
BUG=chromium:632185
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2196803002
Review-Url: https://codereview.chromium.org/2196803002
2016-07-29 12:24:29 -07:00
csmartdalton
4c18b62a00
Add ES 3.0 fallback for instanced rendering
...
Adds the ability for GLInstancedRendering to use
glDrawElementsInstanced when glDrawElementsIndirect is not supported.
The only remaining 3.1 dependency now is EXT_texture_buffer.
Also moves the cap for glDraw*Instanced out of GrCaps and into
GrGLCaps.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193303002
Review-Url: https://codereview.chromium.org/2193303002
2016-07-29 12:19:28 -07:00
egdaniel
848904e5b3
Fix vulkan build
...
TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193883002
Review-Url: https://codereview.chromium.org/2193883002
2016-07-29 11:47:58 -07:00
dvonbeck
779e1924ea
Added distance vector support for CircleGeometryProcessor
...
This CL's base is the CL that sets up the distance vector field req. exposure: https://codereview.chromium.org/2114993002/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190023002
Review-Url: https://codereview.chromium.org/2190023002
2016-07-29 11:11:51 -07:00
mtklein
6ad22315eb
Tidy up SkNx_neon.
...
This takes advantage of the fact that all the compilers we use that
support NEON implement it with their own vector extensions. This means
normal things like c = a + b work on the underlying vector types already.
Odd instructions like min or saturated add need to stay intrinsics.
Also, rearrange functions to a more consistent order.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2196773002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/2196773002
2016-07-29 11:11:12 -07:00
jcgregorio
01f696e30f
perf: Upload results to gs://skia-perf, not gs://chromium-skia-gm.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197643002
Review-Url: https://codereview.chromium.org/2197643002
2016-07-29 10:54:30 -07:00
bungeman
aa8f39402c
Conditionally define SK_SUPPORT_LEGACY_DATA_FACTORIES.
...
In order to remove this define it will first need to be defined in
Chromium. However, doing so causes redefinition warnings as errors.
Only define this macro if it is not already defined to avoid this.
TBR=reed
This doesn't change any API.
Review-Url: https://codereview.chromium.org/2198453002
2016-07-29 10:47:45 -07:00
egdaniel
31bc7df59b
Properly recycle uniform buffers in vulkan
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2195713002
Review-Url: https://codereview.chromium.org/2195713002
2016-07-29 10:46:06 -07:00
mtklein
f6593a68d9
Add some GN builders to the CQ.
...
This parallels the set of bots we use to gate commits already.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189283003
Review-Url: https://codereview.chromium.org/2189283003
2016-07-29 10:41:37 -07:00
halcanary
fa25106f02
SkPDF: PDFStream has-a not is-a PDFDict
...
Motivation:
SkPDFStream and SkPDFSharedStream now work the same.
Also:
- move SkPDFStream into SkPDFTypes (it's a fundamental PDF type).
- minor refactor of SkPDFSharedStream
- SkPDFSharedStream takes unique_ptr to represent ownership
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190883003
Review-Url: https://codereview.chromium.org/2190883003
2016-07-29 10:13:18 -07:00
mtklein
d05a875273
SkNx: add Sk4u
...
This lets us get at logical >> in a nicely principled way.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197683002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/2197683002
2016-07-29 10:10:15 -07:00
dvonbeck
4ef6dfa708
GrFP can express distance vector field req., program builder declares variable for it
...
This update allows fragment processors to require a field of vectors to the nearest edge. This requirement propagates:
- from child FPs to their parent
- from parent FPs to the GrPaint
- from GrPaint through the PipelineBuilder into GrPipeline
- acessed from GrPipeline by GrGLSLProgramBuilder
GrGLSL generates a variable for the distance vector and passes it down to the GeometryProcessor->emitCode() method.
This CL's base is the CL for adding the BevelNormalSource API: https://codereview.chromium.org/2080993002
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114993002
Review-Url: https://codereview.chromium.org/2114993002
2016-07-29 09:53:56 -07:00
mtklein
5db44aa2aa
GN: components as static library instead of source set
...
This also puts the .a in the top-level of the ouptut directory, just
like we do for .so files. It's less required than for .sos, but it
does make it easier to find the .a.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197633002
Review-Url: https://codereview.chromium.org/2197633002
2016-07-29 09:10:31 -07:00
msarett
a714bc3929
Fix various SkColorSpace bugs
...
(1) Fixes serialization/deserialization of wacky SkColorSpaces
(2) Fix gamma equals checking
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2194903002
Review-Url: https://codereview.chromium.org/2194903002
2016-07-29 08:58:33 -07:00
egdaniel
00db3fd7a7
Use HashSet instead of Dynamic hash for tracking vulkan resources
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2194823003
Review-Url: https://codereview.chromium.org/2194823003
2016-07-29 08:55:53 -07:00
fmalita
58649ccc75
[SVGDom] Parse style attributes
...
Dispatch style-encoded (style="foo: bar; ...") attributes via normal
attribute setters.
R=reed@google.com ,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193663002
Review-Url: https://codereview.chromium.org/2193663002
2016-07-29 08:52:03 -07:00
halcanary
5abbb44f68
SkPDF: flip saveLayer rightside up
...
Broken in https://skia.googlesource.com/skia/+/4b1e17e
BUG=632574
TBR=tomhudson@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197623002
Review-Url: https://codereview.chromium.org/2197623002
2016-07-29 08:41:33 -07:00
mtklein
3a88056994
GN: quick doc
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2192203002
NOTRY=true
DOCS_PREVIEW= https://skia.org/user/quick/gn?cl=2192203002
Review-Url: https://codereview.chromium.org/2192203002
2016-07-29 08:35:54 -07:00
robertphillips
1e8761809d
Remove GrContext::applyGamma
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2191323002
Review-Url: https://codereview.chromium.org/2191323002
2016-07-29 08:28:25 -07:00
csmartdalton
e0d362929d
Add test configs for instanced rendering
...
Adds the following configs and enables them on select bots:
glinst, glinst4, glinstdit4, glinst16, glinstdit16,
esinst, esinst4, esinstdit4
Makes general changes to GrContextOptions, GrCaps, etc. to facilitate
this.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2182783004
Review-Url: https://codereview.chromium.org/2182783004
2016-07-29 08:14:20 -07:00
egdaniel
0d9990f052
Merge ProgramDesc's for GL and Vulkan
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184413002
Review-Url: https://codereview.chromium.org/2184413002
2016-07-29 07:36:52 -07:00
msarett
50ce1f28ff
Add color space xform support to SkJpegCodec (includes F16!)
...
Also changes SkColorXform to support:
RGBA->RGBA
RGBA->BGRA
Instead of:
RGBA->SkPMColor
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2174493002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Committed: https://skia.googlesource.com/skia/+/73d55332e2846dd05e9efdaa2f017bcc3872884b
Review-Url: https://codereview.chromium.org/2174493002
2016-07-29 06:23:33 -07:00
mtklein
830c913625
GN: ccache+clang needs -Qunused-arguments
...
An alternative is to define CCACHE_CPP2, but
I thought I'd try this more visible way first.
(CCACHE_CPP2 may turn out to be required anyway
if we start seeing warnings about tautological compares.)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193203002
TBR=jcgregorio@google.com
NOTRY=true
Review-Url: https://codereview.chromium.org/2193203002
2016-07-29 06:03:52 -07:00
mtklein
2a1134e3f5
GN: Always quote cc and cxx.
...
To fix:
ERROR at the command-line "--args":1:34: Unexpected token '+'
is_debug=true cc=clang cxx=clang++
TBR=jcgregorio@google.com
NOTRY=true
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193593003
Review-Url: https://codereview.chromium.org/2193593003
2016-07-29 05:39:35 -07:00
mtklein
9081ceb123
GN: use ccache if available and the requested compiler.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186553006
Review-Url: https://codereview.chromium.org/2186553006
2016-07-29 05:07:39 -07:00
mtklein
4e41364b1e
Add another GM to skip in serialize mode.
...
See https://luci-milo.appspot.com/swarming/task/304ced7bada3b310/steps/dm/0/stdout
Also update .json.
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug-Trybot
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2196543002
Review-Url: https://codereview.chromium.org/2196543002
2016-07-28 19:14:08 -07:00
msarett
39979d8c6b
Revert of Add color space xform support to SkJpegCodec (includes F16!) (patchset #9 id:260001 of https://codereview.chromium.org/2174493002/ )
...
Reason for revert:
Breaking MSAN
Original issue's description:
> Add color space xform support to SkJpegCodec (includes F16!)
>
> Also changes SkColorXform to support:
> RGBA->RGBA
> RGBA->BGRA
>
> Instead of:
> RGBA->SkPMColor
>
> TBR=reed@google.com
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2174493002
> CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/73d55332e2846dd05e9efdaa2f017bcc3872884b
TBR=mtklein@google.com ,reed@google.com,herb@google.com,brianosman@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2195523002
2016-07-28 17:11:18 -07:00
robertphillips
ecf3dbe8f2
Remove use of MakeRenderTargetDirect from view system
...
Here is the CL that sent me down the SkGammaColorFilter path
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2178353005
Review-Url: https://codereview.chromium.org/2178353005
2016-07-28 15:17:34 -07:00
benjaminwagner
99fb670977
Update public.bzl based on internal cl/128616707.
...
TBR=mtklein@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186373002
Review-Url: https://codereview.chromium.org/2186373002
2016-07-28 15:12:21 -07:00
msarett
73d55332e2
Add color space xform support to SkJpegCodec (includes F16!)
...
Also changes SkColorXform to support:
RGBA->RGBA
RGBA->BGRA
Instead of:
RGBA->SkPMColor
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2174493002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/2174493002
2016-07-28 15:06:16 -07:00
mtklein
20c27d6d6f
Make coverage.py optional for dm and nanobench _flags.py
...
It is better to test partially than not test at all.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184423002
Review-Url: https://codereview.chromium.org/2184423002
2016-07-28 14:58:08 -07:00
mtklein
dc90b53350
Silence -Wclobbered in each file that needs it.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184823009
Committed: https://skia.googlesource.com/skia/+/03f704a343d7a82974f977eda8789a8c721c93e5
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Win-MSVC-GCE-CPU-AVX2-x86-Release-Trybot
Review-Url: https://codereview.chromium.org/2184823009
2016-07-28 14:45:28 -07:00
halcanary
00450f1ae5
SkPDF: drawText makes use of SkPaint.measureText() for alignment.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188303003
Review-Url: https://codereview.chromium.org/2188303003
2016-07-28 14:33:13 -07:00
reed
9b84f8c812
turn bitmaps into images during recording
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185563003
Review-Url: https://codereview.chromium.org/2185563003
2016-07-28 14:26:13 -07:00
mtklein
2b6870ccb2
GN: nanobench
...
Add nanobench, and while we're at it monobench to show off how cool
source_sets are... the bench files are only built once then linked
into both binaries. With GYP we build them twice. :/ Same deal
for GMs between nanobench and DM... build once, link twice.
nanobench uses SkImageEncoder to encode its .pngs, which requires
we link in the image encoders, which requires we get them all in.
That's the bulk of this.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193513002
Review-Url: https://codereview.chromium.org/2193513002
2016-07-28 14:17:33 -07:00
mtklein
2f428966c6
Revert of Silence -Wclobbered in each file that needs it. (patchset #2 id:20001 of https://codereview.chromium.org/2184823009/ )
...
Reason for revert:
Jpeg strategy seems to be leading to crashes. Gonna go back to warning squelch.
Original issue's description:
> Silence -Wclobbered in each file that needs it.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184823009
>
> Committed: https://skia.googlesource.com/skia/+/03f704a343d7a82974f977eda8789a8c721c93e5
TBR=msarett@google.com ,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2188313003
2016-07-28 13:59:59 -07:00
bsalomon
4d516a6903
Serialize SkColorSpace into DeferredTextureImage
...
This fixes a memory leak that occurs when DeferredTextureImage is deallocated without being destroyed. It is intended to be stored in discarable memory and thus this has to be safe.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184823010
Review-Url: https://codereview.chromium.org/2184823010
2016-07-28 13:37:31 -07:00
mtklein
03f704a343
Silence -Wclobbered in each file that needs it.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184823009
Review-Url: https://codereview.chromium.org/2184823009
2016-07-28 11:57:31 -07:00
jcgregorio
50d1847815
Fix expectations for GN bot.
...
BUG=skia:
Review-Url: https://codereview.chromium.org/2191933002
2016-07-28 11:55:51 -07:00
bsalomon
4484d6ac78
Remove unused render target members from GL and VK sk_app::WindowContext classes
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2191673002
Review-Url: https://codereview.chromium.org/2191673002
2016-07-28 11:49:12 -07:00
csmartdalton
a26efc9bad
Include NVPR configs in dm runs on TegraX1
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2174353008
Review-Url: https://codereview.chromium.org/2174353008
2016-07-28 11:48:13 -07:00
mtklein
f05c2c22a7
GN: add abbreviated versions of the command line as descriptions.
...
This should help make the bot logs a little easier to read. (On the console
this wasn't much of a big deal, as Ninja auto-abbreviates when printing to an
interactive console.)
As usual, Ninja will print the full command when a task fails.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188263002
Review-Url: https://codereview.chromium.org/2188263002
2016-07-28 11:42:34 -07:00
fmenozzi
17e829794d
Add HardStopGradientBench_ScaleNumHardStops.cpp
...
Rename HardStopGradientBench.cpp to HardStopGradientBench_ScaleNumColors.cpp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2178913003
Review-Url: https://codereview.chromium.org/2178913003
2016-07-28 10:59:49 -07:00
borenet
f49d9d77bb
Add swarmbucket_wrapper recipe
...
BUG=skia:5581
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185203003
Review-Url: https://codereview.chromium.org/2185203003
2016-07-28 10:50:54 -07:00
msarett
a0605bf9d1
Add writeToMemory() API to SkColorSpace
...
New API mirrors the form of similar APIs in SkRegion,
SkMatrix, etc.
This also fixes a bug:
SkImageInfo appears in a object that Chrome stores in
discardable memory. So when sk_sp<SkColorSpace> was added
to SkImageInfo a leak was introduced. We'll use this new
method and deserialize to store the SkColorSpace in the
discardable object.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2192903002
Review-Url: https://codereview.chromium.org/2192903002
2016-07-28 10:47:50 -07:00
mtklein
0634317cbe
GN: fix mac build again
...
Hoping to land these using the other GN bots as trybots.
Don't know what magic was letting us get to webp's headers yesterday on Linux. Might have been using /usr/include's ?
The other change is the difference between some setups using #define SK_BUILD_FOR_MAC and others #define SK_BUILD_FOR_MAC 1. We want either to mean "we're Mac".
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190713004
Review-Url: https://codereview.chromium.org/2190713004
2016-07-28 09:58:44 -07:00
fmalita
eae6a91277
SkPaint intercept API for SkTextBlob and horizontal text
...
Add getPosTextHIntercepts(), getTextBlobIntercepts().
Consolidate the implementation in GetTextIntercepts<> template.
BUG=chormium:581456
R=caryclark@google.com ,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186663004
Review-Url: https://codereview.chromium.org/2186663004
2016-07-28 09:47:24 -07:00
mtklein
fa84d94bb0
Make both SK_API definition points identical and order independent.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189983002
Review-Url: https://codereview.chromium.org/2189983002
2016-07-28 09:45:15 -07:00
jcgregorio
ba59595ea3
recipes: Add a GN flavor.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189713003
Review-Url: https://codereview.chromium.org/2189713003
2016-07-28 09:38:59 -07:00
robertphillips
a408c8fb6d
Add SkGammaColorFilter
...
WDYT about this as a means of replacing GrContext::applyGamma with a normal SkCanvas::drawImage?
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190573002
Review-Url: https://codereview.chromium.org/2190573002
2016-07-28 09:20:33 -07:00