reed@google.com
7b06ba45b3
don't unref() null (from typeface::create) you gunky
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9294 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-28 16:39:52 +00:00
reed@google.com
98447b0c74
use inttoscalar to fix warning
...
BUG=
Review URL: https://codereview.chromium.org/15929006
git-svn-id: http://skia.googlecode.com/svn/trunk@9293 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-28 15:42:21 +00:00
reed@google.com
2f51ae0e6c
use explicit conversion for int->scalar
...
BUG=
Review URL: https://codereview.chromium.org/16123004
git-svn-id: http://skia.googlecode.com/svn/trunk@9292 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-28 15:35:47 +00:00
reed@google.com
f2de1e286b
add new gm for bicubic filtering
...
BUG=
Review URL: https://codereview.chromium.org/16123003
git-svn-id: http://skia.googlecode.com/svn/trunk@9291 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-28 15:29:25 +00:00
epoger@google.com
9d33154b13
Split GM json schema out of display_json_results.py, for sharing with other tools
...
R=rmistry@google.com
Review URL: https://codereview.chromium.org/16155002
git-svn-id: http://skia.googlecode.com/svn/trunk@9290 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-28 15:25:38 +00:00
skia.committer@gmail.com
454ae46814
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9285 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-25 07:01:12 +00:00
commit-bot@chromium.org
912e68ec46
Fix degenerate and near-degenerate hairlines on the gpu
...
R=robertphillips@google.com , bsalomon@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/16035002
git-svn-id: http://skia.googlecode.com/svn/trunk@9279 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-24 18:51:55 +00:00
scroggo@google.com
dbbcaa8983
Revert "Add path utils, plus a test for it."
...
This reverts commit d172374b46cae0bd5d7c024b9848f5bdafcc6a16.
This CL broke on Windows.
Review URL: https://codereview.chromium.org/15986004
git-svn-id: http://skia.googlecode.com/svn/trunk@9278 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-24 18:28:57 +00:00
scroggo@google.com
1bee037044
Add path utils, plus a test for it.
...
SkOSFile:
Added class SkOSPath with functions for
modifying strings representing path names.
OSPathTest.cpp:
Test of the new utilities.
factory.cpp:
Use SkPathJoin.
gmmain and gm_expectations:
Use SkOSPath::SkPathJoin instead of a local version.
skimage_main.cpp:
Use the new location of SkPathJoin and SkBasename.
R=epoger@google.com
Review URL: https://codereview.chromium.org/15747004
git-svn-id: http://skia.googlecode.com/svn/trunk@9277 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-24 18:12:17 +00:00
reed@google.com
3d3a860d0b
Add flag to gradients to interpolate colors in premul space. Experimental API to encapsulate the shared parameters for all gradients into a struct.
...
BUG=
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/15893002
git-svn-id: http://skia.googlecode.com/svn/trunk@9273 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-24 14:58:44 +00:00
epoger@google.com
d4993ff360
GM: create GmResultDigest that encapsulates digest type ("bitmap-64bitMD5") and value (12345)
...
R=scroggo@google.com
Review URL: https://codereview.chromium.org/15883004
git-svn-id: http://skia.googlecode.com/svn/trunk@9271 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-24 14:33:28 +00:00
skia.committer@gmail.com
3e2345a8d5
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9266 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-24 07:01:26 +00:00
reed@google.com
0f8990cd2c
use SkScalar instead of int for loops, to avoid warning in canvas->translate() calls
...
BUG=
Review URL: https://codereview.chromium.org/15875012
git-svn-id: http://skia.googlecode.com/svn/trunk@9263 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-23 19:47:05 +00:00
reed@google.com
03ca64b832
don't overclamp cubics (see skbug.com/1316)
...
BUG=
Review URL: https://codereview.chromium.org/15924003
git-svn-id: http://skia.googlecode.com/svn/trunk@9262 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-23 19:39:15 +00:00
reed@google.com
22999c61d8
add comment
...
add test for skbug/com/1316
BUG=
Review URL: https://codereview.chromium.org/15790006
git-svn-id: http://skia.googlecode.com/svn/trunk@9261 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-23 19:30:48 +00:00
reed@google.com
ff26b7ea7c
use SK_OVERRIDE and DEF_GM
...
BUG=
Review URL: https://codereview.chromium.org/15873004
git-svn-id: http://skia.googlecode.com/svn/trunk@9259 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-23 17:04:19 +00:00
skia.committer@gmail.com
b148aca07e
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9232 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-22 07:01:13 +00:00
reed@google.com
b83cb9bf89
add SkLerpXfermode
...
BUG=
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/15602003
git-svn-id: http://skia.googlecode.com/svn/trunk@9229 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-21 21:33:11 +00:00
epoger@google.com
a55e48d6ef
Improve tool that analyzes gm JSON summary
...
BUG=https://code.google.com/p/skia/issues/detail?id=1300
R=borenet@google.com
Review URL: https://codereview.chromium.org/15298010
git-svn-id: http://skia.googlecode.com/svn/trunk@9217 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-21 16:06:40 +00:00
epoger@google.com
659c8c06cd
GM: make behavior of make_filename() more late-binding
...
This will be needed to add the option of writing out files with
checksum-based filenames.
R=scroggo@google.com
Review URL: https://codereview.chromium.org/15415003
git-svn-id: http://skia.googlecode.com/svn/trunk@9215 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-21 15:45:45 +00:00
epoger@google.com
37d747d383
GM self-tests: add testing for non --hierarchy case
...
R=scroggo@google.com
Review URL: https://codereview.chromium.org/15397007
git-svn-id: http://skia.googlecode.com/svn/trunk@9214 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-21 15:41:35 +00:00
bungeman@google.com
cefd981a4c
Fix vertical text scaling and clipping on Mac.
...
https://codereview.chromium.org/15064003/
git-svn-id: http://skia.googlecode.com/svn/trunk@9142 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-15 15:07:32 +00:00
bsalomon@google.com
6db962617f
Finish mixed_xfermodes GM.
...
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/15012026
git-svn-id: http://skia.googlecode.com/svn/trunk@9137 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-15 13:10:18 +00:00
skia.committer@gmail.com
eafdf126d4
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9135 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-15 07:01:09 +00:00
epoger@google.com
26515baa90
Add gm/confirm_no_failures_in_json.py
...
The CompareGMs step will use this (instead of running skdiff over the image
files) to decide whether to go red or green.
R=rmistry@google.com
Review URL: https://codereview.chromium.org/15100003
git-svn-id: http://skia.googlecode.com/svn/trunk@9127 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-14 18:58:12 +00:00
robertphillips@google.com
1a095191b2
Compiler warning/error fix for r9120
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9121 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-14 16:43:02 +00:00
robertphillips@google.com
dd3f365482
Add GM to track thin rectangle rendering
...
https://codereview.chromium.org/15012024/
git-svn-id: http://skia.googlecode.com/svn/trunk@9120 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-14 16:37:31 +00:00
epoger@google.com
ce057fec92
GM: include filename extension (.png) of each output file in JSON summary
...
Doing this so that, once we *do* start writing PDF checksums into the JSON
summary, we'll be able to distinguish those from the PNG checksums.
Otherwise, we could have naming collisions.
R=scroggo@google.com
Review URL: https://codereview.chromium.org/14890017
git-svn-id: http://skia.googlecode.com/svn/trunk@9119 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-14 15:17:46 +00:00
bsalomon@google.com
7d9ffc8a04
Make GrAAConvexPathRender support paths with > 64K verts.
...
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/15120004
git-svn-id: http://skia.googlecode.com/svn/trunk@9118 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-14 14:20:28 +00:00
caryclark@google.com
512c9b65fc
add wildcard test name matching to gm and bench.
...
This adds the same set of options in unit tests, i.e:
--match [~][^]match[$] [~][^]match[$] ...
~ causes a matching test to always be skipped
^ requires the start of the test to match
$ requires the end of the test to match
^ and $ requires an exact match
If a test does not match any list entry,
it is skipped unless some list entry starts with ~
Review URL: https://codereview.chromium.org/14746017
git-svn-id: http://skia.googlecode.com/svn/trunk@9096 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-10 15:16:13 +00:00
bsalomon@google.com
c978478514
Make gms use getTopDevice() rather than getDevice().
...
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/14885012
git-svn-id: http://skia.googlecode.com/svn/trunk@9091 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-10 14:12:08 +00:00
epoger@google.com
ee2c3b9fb3
GM self-test: add --writePath and --mismatchPath , but in a way that works cross-platform
...
R=scroggo@google.com
Review URL: https://codereview.chromium.org/15085007
git-svn-id: http://skia.googlecode.com/svn/trunk@9077 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 18:09:06 +00:00
scroggo@google.com
6843bdb706
Write/compare against expectations in skimage tool.
...
skimage:
Add two new modes: one to write expectations to a json file, and
another to compare results against expectations.
Use SkPATH_SEPARATOR instead of '/'.
gm_expectations:
Split into a static library so it can be used by skimage.
Make functions non static and move function definitions into source
file.
Capitalize static member functions to follow the coding style
guidelines.
BUG=https://code.google.com/p/skia/issues/detail?id=1241
R=epoger@google.com
Review URL: https://codereview.chromium.org/14670021
git-svn-id: http://skia.googlecode.com/svn/trunk@9069 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 19:14:23 +00:00
epoger@google.com
0a117be391
Re-land r9059 with empty cityhash.gyp, instead of deleted cityhash.gyp
...
R=rmistry@google.com
Review URL: https://codereview.chromium.org/15060008/
git-svn-id: http://skia.googlecode.com/svn/trunk@9064 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 16:04:02 +00:00
epoger@google.com
e8d08a0fc2
Roll out r9059 to unbreak bots
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9060 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 15:22:36 +00:00
epoger@google.com
aaf7343e16
Remove third-party cityhash, unused since r8992
...
R=djsollen@google.com
Review URL: https://codereview.chromium.org/15027013
git-svn-id: http://skia.googlecode.com/svn/trunk@9059 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 14:49:50 +00:00
epoger@google.com
fed9db6930
GM self-test: add option to exercise --writePath and --mismatchPath, but not on bots
...
(individual developers can set WRITE_IMAGE_FILES=1 for local testing)
R=rmistry@google.com
Review URL: https://codereview.chromium.org/14863009
git-svn-id: http://skia.googlecode.com/svn/trunk@9056 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 14:10:28 +00:00
epoger@google.com
366a770159
GM: now that we use MD5 instead of CityHash, the JSON should say so
...
(this should have been part of https://code.google.com/p/skia/source/detail?r=8992 )
R=bungeman@google.com
Review URL: https://codereview.chromium.org/14758003
git-svn-id: http://skia.googlecode.com/svn/trunk@9038 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 15:51:54 +00:00
commit-bot@chromium.org
c5fd461718
Mask orientation and layout correctly.
...
R=reed@google.com , clefru@google.com
Author: bungeman@google.com
Review URL: https://chromiumcodereview.appspot.com/14884010
git-svn-id: http://skia.googlecode.com/svn/trunk@9022 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-06 22:23:08 +00:00
bungeman@google.com
1ca36ecfd9
Don't use writeData to write the document in GM.
...
https://codereview.chromium.org/14824003/
git-svn-id: http://skia.googlecode.com/svn/trunk@9013 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-06 14:28:43 +00:00
epoger@google.com
b4ca46d748
SkBitmapHasher: use 64-bit-truncated MD5 instead of 64-bit CityHash
...
BUG=https://code.google.com/p/skia/issues/detail?id=1257
(if we change our mind within the next few days, we can toggle the
BITMAPHASHER_USES_TRUNCATED_MD5 #ifdef ; at some point, we'll remove that
option so we can delete our CityHash implementation entirely)
R=bungeman@google.com
Review URL: https://codereview.chromium.org/14054012
git-svn-id: http://skia.googlecode.com/svn/trunk@8992 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 17:35:39 +00:00
epoger@google.com
fdea3259d0
GM: fix --mismatchPath option
...
(currently, it doesn't actually write any files!)
TBR=rmistry
Review URL: https://codereview.chromium.org/14855005
git-svn-id: http://skia.googlecode.com/svn/trunk@8963 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-02 18:24:03 +00:00
scroggo@google.com
c4ebdb03de
Force linking with image decoders for images project.
...
Previously, each tool that wanted to use image decoders
but did not specifically reference them had to create a
dummy function that references them in order to ensure
they are not stripped by the linker.
Instead of making each tool reference each image decoder,
do it once in SkImageDecoder.cpp. Now each tool will have
image decoders linked in, assuming it includes the images
project.
This fixes a bug where SKPs with encoded data could not
be read by bench_ or render_pictures.
R=djsollen@google.com , robertphillips@google.com
Review URL: https://codereview.chromium.org/14678003
git-svn-id: http://skia.googlecode.com/svn/trunk@8941 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-01 21:17:27 +00:00
bungeman@google.com
7103344b64
Add FontMgr to DirectWrite.
...
https://codereview.chromium.org/14314008/
git-svn-id: http://skia.googlecode.com/svn/trunk@8934 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-01 14:21:20 +00:00
scroggo@google.com
74b7ffda68
Fixes for piping bitmaps with encoded data.
...
Similar goals as https://codereview.chromium.org/14437012 .
Builds on patch set 1 from that issue
(https://codereview.chromium.org/14437012/#ps1 ).
Instead of the changes in patch set 2 from that issue, this
changes SkOrderedWriteBuffer::writeBitmap to store whether an
SkBitmapHeap was used when to store the index of the SkBitmap.
SkOrderedReadBuffer::readBitmap now uses that information to
distinguish between using the heap and unflattening.
In addition, writeBitmap now records the width/height first in
all cases. If now SkBitmapHeapReader is attached, but an
SkBitmapHeap was used to record the bitmap, reading will fail
and provide the same red SkBitmap as in the case where the
SkBitmap was encoded but could not be decoded.
Updates the PICTURE_VERSION as well.
The key differences in this CL to look at are in:
SkOrderedWriteBuffer,
SkOrderedReadBuffer,
and SkPicture.
BUG=
R=djsollen@google.com
Review URL: https://codereview.chromium.org/14230022
git-svn-id: http://skia.googlecode.com/svn/trunk@8917 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-30 02:32:41 +00:00
robertphillips@google.com
6f5abddf89
add 90 degree test case to rects GM
...
https://codereview.chromium.org/13844017/
git-svn-id: http://skia.googlecode.com/svn/trunk@8911 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-29 17:44:45 +00:00
epoger@google.com
0cc99cf793
GM self-tests: always run all tests (don't stop at first failure)
...
and make rebaseline.sh rebaseline all tests in one go.
(RunBuilders:Skia_PerCommit_House_Keeping)
Review URL: https://codereview.chromium.org/13979017
git-svn-id: http://skia.googlecode.com/svn/trunk@8881 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-26 17:45:06 +00:00
epoger@google.com
76c913db20
GM: specify that currently used checksums are CityHashes of SkBitmaps
...
(distinct from other hash algorithms we may switch to, or hashes of
files such as PDFs that cannot be read into an SkBitmap)
Review URL: https://codereview.chromium.org/14284018
git-svn-id: http://skia.googlecode.com/svn/trunk@8877 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-26 15:06:44 +00:00
caryclark@google.com
45a75fb4d0
path ops : make it real
...
Add an option to SkCanvas to turn on path
ops when combining clips.
Allow Op() to use one of the input paths
as an output path.
Fix a bug in Op() when the minuend is empty
and the subtrahend is not (for difference).
Change the build to allow core to depend on pathops.
Review URL: https://codereview.chromium.org/14474002
git-svn-id: http://skia.googlecode.com/svn/trunk@8855 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-25 13:34:40 +00:00
commit-bot@chromium.org
9711e44667
Move MMap to SkData.
...
R=reed@google.com
Author: bungeman@google.com
Review URL: https://chromiumcodereview.appspot.com/14336003
git-svn-id: http://skia.googlecode.com/svn/trunk@8848 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-24 20:03:00 +00:00