bungeman
1f790aaeef
Improve assert reporting.
...
Make SkASSERTF output readable.
Ensure the assert predicate is stringified once.
Make the abort code consistent.
TBR=reed
This doesn't change any public API, most of this should be privatized.
Review-Url: https://codereview.chromium.org/2161103002
2016-07-20 09:49:10 -07:00
robertphillips
ea70c4bb22
Remove SkDevice::accessRenderTarget virtual
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167723002
Review-Url: https://codereview.chromium.org/2167723002
2016-07-20 08:54:31 -07:00
egdaniel
c1be9bc169
Add GrVkRecycledResource subclass
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167453003
Review-Url: https://codereview.chromium.org/2167453003
2016-07-20 08:33:00 -07:00
fmenozzi
35a98c733f
Add integer array uniforms to GL and Vulkan
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163173005
Review-Url: https://codereview.chromium.org/2163173005
2016-07-20 08:26:12 -07:00
bsalomon
487f8d385b
Consolidate special case shape transformation logic in GrShapeTest.
...
Enable all tests on all geometry types.
Add conversion of fill+miter-stroke->fill for rect geometries in GrShape.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2157013003
Review-Url: https://codereview.chromium.org/2157013003
2016-07-20 07:15:44 -07:00
bungeman
fbbf01af04
Add iOS to platform_os_emoji.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164783004
Review-Url: https://codereview.chromium.org/2164783004
2016-07-20 07:15:16 -07:00
martina.kollarova
7b70156334
Fix context creation problems in dm
...
Fixes these issues:
1. The glXCreateContextAttribsARB call seems to modify the
context_attrib parameter upon failure. Since context_attrib was static,
if it first tried to create an OpenGL 4.4 context and it failed, further
attempts to create a context with lower versions would also fail.
2. Getting an OpenGL 3.0 context was never tried.
3. Context creation for ES 3.0 was failing on my machine. Since ES 2.0
looks like the intended version from the surrounding code, I set it to
that. It could be rewritten to use a similar loop as standard OpenGL and
try from the highest version to the lowest.
BUG=skia:5403
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147513002
Review-Url: https://codereview.chromium.org/2147513002
2016-07-20 07:01:46 -07:00
reed
a2217ef965
use special-image for imagefilters and save/restore layer
...
add special virtuals to device, in preparation for using them instead of bitmap for imagefilters
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2155933002
patch from issue 2155933002 at patchset 20001 (http://crrev.com/2155933002#ps20001 )
use specialimages instead of bitmaps for imagefiltering
Review-Url: https://codereview.chromium.org/2155063002
2016-07-20 06:04:34 -07:00
borenet
c8fcb9ce82
Add "Infra" to the builder_name_schema
...
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2154433002
Review-Url: https://codereview.chromium.org/2154433002
2016-07-20 05:54:50 -07:00
mtklein
53574b7236
Fix color order for 565,4444, and I8 samplers.
...
10 GMs fixed on Linux/Win!
Also, don't unpremul I8 colors. It's inconsistent with the other formats.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2166623002
Review-Url: https://codereview.chromium.org/2166623002
2016-07-20 05:23:31 -07:00
kjlubick
e565450d0b
Port FuzzPathop from chromium
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2148023002
Review-Url: https://codereview.chromium.org/2148023002
2016-07-19 16:50:03 -07:00
reed
e51c356ae4
pre-land special methods on device
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2161233002
Review-Url: https://codereview.chromium.org/2161233002
2016-07-19 14:33:20 -07:00
jvanverth
a3f3caccdf
Stub in Mac viewer code.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164683002
patch from issue 2164683002 at patchset 1 (http://crrev.com/2164683002#ps1 )
Review-Url: https://codereview.chromium.org/2167503002
2016-07-19 14:17:20 -07:00
brianosman
9ecaa1d9f0
Remove unused MakeFromTextureCopy API
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165803002
Review-Url: https://codereview.chromium.org/2165803002
2016-07-19 14:16:49 -07:00
robertphillips
ecbc15d46c
Minor cleanup of GrStencilAndCoverTextContext
...
Split out of https://codereview.chromium.org/2163483002/ (Use SkFont in GrStencilAndCoverTextContext)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165673002
Review-Url: https://codereview.chromium.org/2165673002
2016-07-19 14:04:39 -07:00
mtklein
d1bd2082c5
Update rounding/clamping comments on sk_linear_to_srgb().
...
Rounding is enough. No need for an explicit clamp if the inputs are in range.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2161223002
Review-Url: https://codereview.chromium.org/2161223002
2016-07-19 13:36:03 -07:00
Ben Wagner
4bcb4c7a25
Make SkOTTable_name.cpp UTF-8.
...
When editing on Windows this file became iso-8859-1.
2016-07-19 16:10:56 -04:00
msarett
575b2a3bb9
Fix master-skia build
...
TBR=djsollen@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2159223003
Review-Url: https://codereview.chromium.org/2159223003
2016-07-19 13:00:35 -07:00
mtklein
35f255f0f7
Fix color order on LCD text when using sRGB software backend.
...
BUG=skia:5182
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2166533002
Review-Url: https://codereview.chromium.org/2166533002
2016-07-19 12:59:35 -07:00
caryclark
523e76d279
exclude test that fails on google3 asan
...
R=dogben@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164703002
Review-Url: https://codereview.chromium.org/2164703002
2016-07-19 12:27:32 -07:00
caryclark
1493b9772d
fix fuzzer
...
Previous spans always have a valid next pointer. The final span does not.
Change the test for a valid link to take into consideration whether
the links are chased forwards or backwards.
TBR=reed@google.com
BUG=629454
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2166543002
Review-Url: https://codereview.chromium.org/2166543002
2016-07-19 11:29:15 -07:00
msarett
ff1740394e
Disable qcms on build for Android framework
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2160863003
Review-Url: https://codereview.chromium.org/2160863003
2016-07-19 11:17:55 -07:00
msarett
7f119caecb
Enable libjpeg-turbo features
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2161843002
Review-Url: https://codereview.chromium.org/2161843002
2016-07-19 10:48:58 -07:00
fmenozzi
64e8e5dd0b
Clarify GrGradientEffect key enum
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2158323003
Review-Url: https://codereview.chromium.org/2158323003
2016-07-19 10:45:57 -07:00
bsalomon
c7b4b28496
Make sk_app::WindowContext directly create a SkSurface without an intermediate GrRenderTarget
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165703002
Review-Url: https://codereview.chromium.org/2165703002
2016-07-19 09:46:29 -07:00
msarett
6bdbf4412b
Improve naive SkColorXform to half floats
...
This should give us a good baseline to explore using SkRasterPipeline.
A particular colorxform to half float drops from 425us to 282us on my desktop.
Color Xform to Half Float (HP z620)
Original 425us
Trans16 (not 32) 355us
Vector Trans16 378us
Trans16 + Keep Halfs in Vector 335us
Vector Trans16 + Keep Halfs in Vector 282us
Final 282us
Color Xform to Half Float (Nexus 5X)
Original 556us
Final 472us
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2159993003
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/2159993003
2016-07-19 09:07:55 -07:00
bsalomon
9061aa4217
Create DCs instead of textures in SRGBMipMaps test
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2162973002
Review-Url: https://codereview.chromium.org/2162973002
2016-07-19 08:49:41 -07:00
bsalomon
49b264c217
Create DCs rather than textures in GrConfigConversionEffect
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2162953002
Review-Url: https://codereview.chromium.org/2162953002
2016-07-19 08:38:09 -07:00
bsalomon
28b62e6672
Simplify random_draw_context used by GLProgramsTest
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165683002
Review-Url: https://codereview.chromium.org/2165683002
2016-07-19 08:38:04 -07:00
reed
7f3ff20843
remove unused MakeFromPixmap
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2158913004
TBR=robertphilips@google.com
Review-Url: https://codereview.chromium.org/2158913004
2016-07-19 08:26:09 -07:00
mtklein
f037d48e29
GN: refactor third_party/gni
...
This fixes the build on Linux (dep on third_party:zlib -> third_party/zlib).
I've moved declare_args() {} back to each .gn file... seems like args want
to be as local as possible in GN land.
Additionally, refactor all the common third_party config and warning flag
changes into a template, third_party. This lets it all live together in a
.gni: at head unwanted_configs can be in a .gni (it's just a variable) but
config("no_warnings") (and thus third_party_configs) cannot, as configs
cannot be part of .gni files.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163653002
Review-Url: https://codereview.chromium.org/2163653002
2016-07-19 08:25:00 -07:00
bsalomon
916e02a6d0
Start from DC rather than texture in GrTexutreParamsAdjuster copy code.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2158383002
Review-Url: https://codereview.chromium.org/2158383002
2016-07-19 08:12:30 -07:00
brianosman
c4459f6a33
Fix debugging code for tracing texture creation
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164623002
Review-Url: https://codereview.chromium.org/2164623002
2016-07-19 08:02:21 -07:00
robertphillips
e34f17d236
Make SkFont a bit more useable
...
Split out of https://codereview.chromium.org/2163483002/ (Use SkFont in GrStencilAndCoverTextContext)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163633002
Review-Url: https://codereview.chromium.org/2163633002
2016-07-19 07:59:22 -07:00
bsalomon
b117ff194f
Convert readSurfacePixels to use a draw context instead of a texture
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165523003
Review-Url: https://codereview.chromium.org/2165523003
2016-07-19 07:24:40 -07:00
bsalomon
23c4f1acbc
Fix GrGLInterface::validate() to check for GL_OES_sample_shading on ES contexts
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2156343004
Review-Url: https://codereview.chromium.org/2156343004
2016-07-19 06:21:55 -07:00
fmalita
01c97230f8
Delete the legacy SVG parser
...
Unused.
R=reed@google.com ,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2154193003
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Review-Url: https://codereview.chromium.org/2154193003
2016-07-19 06:12:54 -07:00
mtklein
e817ddf9b3
GN: polyfill is_fuchsia
...
I'll tell you what, I need to practice typing fuchsia out a few hundred
times... I managed to spell it three different ways in this CL.
Plus, gn format BUILD.gn
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164453003
Review-Url: https://codereview.chromium.org/2164453003
2016-07-19 06:03:22 -07:00
fmalita
fd75dd4086
Delete SkXMLPullParser
...
Unused & not being built.
R=reed@google.com ,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163463002
Review-Url: https://codereview.chromium.org/2163463002
2016-07-19 05:14:41 -07:00
robertphillips
5139e501c5
Rename variables in SkCanvas::internalSaveLayer
...
This is split out of https://codereview.chromium.org/2145343005/ (Recast draw_filter_into_device as drawDevice) to, hopefully, make it easier to integrate that CL
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2162883002
Review-Url: https://codereview.chromium.org/2162883002
2016-07-19 05:10:40 -07:00
kolczyk
718aab1e3f
Fix the assert and clamping in SkMatrix::get*Scale[s]().
...
Follow-up after https://codereview.chromium.org/2143133005/ .
BUG=skia:4718
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2154123003
Review-Url: https://codereview.chromium.org/2154123003
2016-07-19 03:49:14 -07:00
msarett
2812f03d54
Fix rewinding bug in SkJpegCodec
...
Performing a sampled and/or subset decode will create some state
in SkJpegCodec. If we fail to clean up this state properly,
subsequent decodes may try to reuse (and potentailly overflow)
the leftover memory.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2161593003
Committed: https://skia.googlesource.com/skia/+/4ecb8ab556214c9337f56bc36d50e4d7c655ac7a
Review-Url: https://codereview.chromium.org/2161593003
2016-07-18 15:56:08 -07:00
bungeman
401ae2d2a0
Rotate bitmap strikes with FreeType.
...
BUG=skia:3490
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2139703002
Committed: https://skia.googlesource.com/skia/+/31e0c1379e6d0ce48196183e295b929af51fa74e
Review-Url: https://codereview.chromium.org/2139703002
2016-07-18 15:46:28 -07:00
msarett
db00a2a9eb
Revert of Fix rewinding bug in SkJpegCodec (patchset #1 id:1 of https://codereview.chromium.org/2161593003/ )
...
Reason for revert:
Breaking Google3 build. Will reland corrected version.
Original issue's description:
> Fix rewinding bug in SkJpegCodec
>
> Performing a sampled and/or subset decode will create some state
> in SkJpegCodec. If we fail to clean up this state properly,
> subsequent decodes may try to reuse (and potentailly overflow)
> the leftover memory.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2161593003
>
> Committed: https://skia.googlesource.com/skia/+/4ecb8ab556214c9337f56bc36d50e4d7c655ac7a
TBR=djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2155163004
2016-07-18 15:19:48 -07:00
bsalomon
7890b89418
Remove guards in GrGLInterface::validate() for functions that Chromium used to not provide.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2158983002
Review-Url: https://codereview.chromium.org/2158983002
2016-07-18 14:59:05 -07:00
robertphillips
640789d64b
Push GrPipelineBuilder down to the drawBatch calls in the TextContext
...
This is split out of https://codereview.chromium.org/2092893003/ (Retract PipelineBuilder some more)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2155983003
Review-Url: https://codereview.chromium.org/2155983003
2016-07-18 14:56:06 -07:00
fmalita
125845553b
[SkXMLParser] Initial text node support
...
Also disable entity processing.
R=bungeman@google.com ,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2154853002
Review-Url: https://codereview.chromium.org/2154853002
2016-07-18 14:47:30 -07:00
fmenozzi
d876a4b549
Add bounds info
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2159853003
Review-Url: https://codereview.chromium.org/2159853003
2016-07-18 13:33:37 -07:00
reed
01a2ff8a32
check for culled-out paths inside SkDraw
...
BUG=629026
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2155213002
Review-Url: https://codereview.chromium.org/2155213002
2016-07-18 13:22:55 -07:00
caryclark
034f243c6d
disable test that fails to compute bounds on nexus 5
...
TBR=jcgregario@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2160713003
Review-Url: https://codereview.chromium.org/2160713003
2016-07-18 12:13:23 -07:00