AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
22,919 Commits 1 Branch 0 Tags 544 MiB
7e602c2c6c
Commit Graph

22919 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
mtklein
7e602c2c6c hacking on a single-benchmark tool 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2012413004

Review-Url: https://codereview.chromium.org/2012413004
 2016-07-11 11:27:30 -07:00
robertphillips
c90bc40fdd Simplify GrDefaultPathRenderer a tiny bit 
This is far less compelling than https://codereview.chromium.org/2135053002/ (Simplify MSAA path renderer) but is probably still worth it.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2135853003

Review-Url: https://codereview.chromium.org/2135853003
 2016-07-11 10:44:07 -07:00
robertphillips
8e375309ca Simplify MSAA path renderer 
This simplification is based on the observations that:
   there were never more than 2 passes
   the only time passes[] was null was the single-pass, !stencilOnly case
   only kBoth_DrawFace was was ever used

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2135053002

Review-Url: https://codereview.chromium.org/2135053002
 2016-07-11 10:43:58 -07:00
herb
00dd4538a5 Reduce size of LinearBitmapPipeline from 281K to 134K, but keep the same speed. 
Speed checked using top25desk SKPS.

Size measured using:
 llvm-nm-3.6  -print-file-name  -print-size -U out/Release/libskia_core.a | awk '{totals[$1] += strtonum("0x" $3)} END { for (i in totals) {print totals[i], i}}' | sort -n | column -t

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2100323002

Review-Url: https://codereview.chromium.org/2100323002
 2016-07-11 10:33:37 -07:00
mtklein
f3bc76a12a Fix MIPS32r2 + DSP2 builders after NDK update. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2141643002

TBR=djsollen@google.com

CQ_INCLUDE_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-MipsDSP2-Debug-Android-Trybot,Build-Ubuntu-GCC-MipsDSP2-Release-Android-Trybot

Review-Url: https://codereview.chromium.org/2141643002
 2016-07-11 10:30:19 -07:00
tomhudson
63d14413be Remove obsolete bench analysis scripts 
R=bungeman@google.com
BUG=skia:5459
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125953002

Review-Url: https://codereview.chromium.org/2125953002
 2016-07-11 10:26:56 -07:00
mtklein
5608e2ed22 Clean up hyper-local SkCpu feature test experiment. 
This removes the code paths where we make SkCpu::Supports() calls
    from within a tight loop.  It keeps code paths using SkCpu::Supports()
    to choose entire routines from src/opts/.

    We can't rely on these hyper-local checks to be hoisted up reliably enough.
    It worked pretty well with the first couple platforms we tried (e.g. Clang
    on Linux/Mac) but we can't gaurantee it works everywhere.

    Further, I'm not able to actually do anything fancy with those tests
    outside of x86... I've not found a way to get, say, NEON+F16 conversion
    code embedded into ordinary NEON code outside writing then entire function
    in external assembly.

    This whole idea becomes less important now that we've got a way to chain
    separate function calls together efficiently.  We can now, e.g., use an
    AVX+F16C method to load some pixels, then chain that into an ordinary AVX
    method to color filter them.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2138073002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review-Url: https://codereview.chromium.org/2138073002
 2016-07-11 09:59:21 -07:00
fmenozzi
d6767aa2d5 Add HardStopGradientBench.cpp 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2131643002

Committed: https://skia.googlesource.com/skia/+/d0d652e0e0cb4bcecb7ccac9f4f4831fcaccdc45
Review-Url: https://codereview.chromium.org/2131643002
 2016-07-11 09:56:31 -07:00
fmenozzi
ffa185d3cf Revert of Add HardStopGradientBench.cpp (patchset #3 id:40001 of https://codereview.chromium.org/2131643002/ ) 
Reason for revert:
Segfaulting on HardStopGradientBench; didn't allocate enough stack memory for color/position arrays.

Original issue's description:
> Add HardStopGradientBench.cpp
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2131643002
>
> Committed: https://skia.googlesource.com/skia/+/d0d652e0e0cb4bcecb7ccac9f4f4831fcaccdc45

TBR=bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2140603003
 2016-07-11 09:30:25 -07:00
bsalomon
810efb57b7 Delay initialization of free list in SkTLList until first use of list 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2138043002

Review-Url: https://codereview.chromium.org/2138043002
 2016-07-11 08:31:27 -07:00
fmenozzi
d0d652e0e0 Add HardStopGradientBench.cpp 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2131643002

Review-Url: https://codereview.chromium.org/2131643002
 2016-07-11 08:31:23 -07:00
rmistry
3b3ee20d93 Do not use the deprecated CQ_EXTRA_TRYBOTS 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2135063003

Review-Url: https://codereview.chromium.org/2135063003
 2016-07-11 08:27:49 -07:00
mtklein
8a6d23257e ndk: r11c -> r12b 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2140603002

Review-Url: https://codereview.chromium.org/2140603002
 2016-07-11 08:27:43 -07:00
msarett
6006f678e7 Make all color xforms 'fast' (step 1) 
This refactors opt code to handle arbitrary src and dst
gammas that are specified by tables.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130013002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review-Url: https://codereview.chromium.org/2130013002
 2016-07-11 05:49:17 -07:00
dvonbeck
6af677ff8f Changed SkLightingShader API to take in a shader as color source 
This CL's base is the CL for the same modification, but in the implementation side: https://codereview.chromium.org/2062703003/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064153002

Review-Url: https://codereview.chromium.org/2064153002
 2016-07-10 18:38:34 -07:00
robertphillips
3ab14ca950 Fix misplaced guard 
This fixes an error in https://codereview.chromium.org/2125333002 (Add choke point for modifying non-AA rect draws (e.g., applying clipping)).

In GrDrawContext::drawRect, when we need to draw a filled rect, we always want to call drawFilledRect when useDrawInsteadOfClear is false. With the buggy code I believe we were falling back to drawing a path.

TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2135883002

Review-Url: https://codereview.chromium.org/2135883002
 2016-07-10 11:49:39 -07:00
reed
6092b6e0e5 Revert of change mapRectScaleTranslate to pass args/ret by value (patchset #1 id:1 of https://codereview.chromium.org/2137853002/ ) 
Reason for revert:
Triggered a compiler bug on Android?

FAILED: /usr/bin/ccache /b/work/skia/platform_tools/android/bin/../toolchains/arm-r11c-14/bin/arm-linux-androideabi-g++ -MMD -MF obj/src/core/core.SkMatrix.o.d -DSK_INTERNAL -DSK_GAMMA_APPLY_TO_A8 -DQT_NO_KEYWORDS -DSK_ALLOW_STATIC_GLOBAL_INITIALIZERS=0 -DSK_SUPPORT_GPU=1 -DSK_FORCE_DISTANCE_FIELD_TEXT=0 -DSK_HAS_GIF_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_TEST_QCMS -DSK_IS_BOT -DSK_CODEC_DECODES_RAW -DSK_ARM_HAS_NEON -DSK_BUILD_FOR_ANDROID -DSK_GAMMA_EXPONENT=1.4 -DSK_GAMMA_CONTRAST=0.0 -DSKIA_DLL -DSKIA_IMPLEMENTATION=1 -DSK_SUPPORT_LEGACY_CLIPTOLAYERFLAG -DNDEBUG -I../../../include/c -I../../../include/config -I../../../include/core -I../../../include/pathops -I../../../include/ports -I../../../include/private -I../../../include/utils -I../../../include/images -I../../../src/core -I../../../src/sfnt -I../../../src/image -I../../../src/opts -I../../../src/utils -I../../../include/gpu -I../../../src/gpu -I../../../platform_tools/android/third_party/cpufeatures -fPIC -g -fno-exceptions -fstrict-aliasing -Wall -Wextra -Winit-self -Wpointer-arith -Wsign-compare -Wvla -Wno-unused-parameter -Werror -march=armv7-a -mthumb -mfpu=neon -mfloat-abi=softfp -fuse-ld=gold -O2 -std=c++11 -fno-rtti -fno-threadsafe-statics -Wnon-virtual-dtor  -c ../../../src/core/SkMatrix.cpp -o obj/src/core/core.SkMatrix.o
../../../src/core/SkMatrix.cpp: In member function 'SkRect SkMatrix::mapRectScaleTranslate(SkRect) const':
../../../src/core/SkMatrix.cpp:1120:1: error: unrecognizable insn:
 }
 ^
(insn 32 31 33 2 (set (reg:V4SF 115 [ D.83077 ])
        (unspec:V4SF [
                (mem/c:V4SF (reg/f:SI 104 virtual-incoming-args) [0 MEM[(const __builtin_neon_sf[4] *)&src]+0 S16 A32])
            ] UNSPEC_VLD1)) /b/work/skia/platform_tools/android/toolchains/arm-r11c-14/lib/gcc/arm-linux-androideabi/4.9/include/arm_neon.h:8693 -1
     (nil))
../../../src/core/SkMatrix.cpp:1120:1: internal compiler error: in extract_insn, at recog.c:2202
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://source.android.com/source/report-bugs.html> for instructions.

Original issue's description:
> change mapRectScaleTranslate to pass args/ret by value
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2137853002
>
> TBR=mtklein
>
> Committed: https://skia.googlesource.com/skia/+/14dce6ed5934d7a6e1fac79f8e76e12f5670aae2

TBR=msarett@google.com,mtklein@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2139523002
 2016-07-10 11:45:35 -07:00
reed
14dce6ed59 change mapRectScaleTranslate to pass args/ret by value 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2137853002

TBR=mtklein

Review-Url: https://codereview.chromium.org/2137853002
 2016-07-10 11:35:03 -07:00
update-skps
4c42eebc55 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2137823002

Review-Url: https://codereview.chromium.org/2137823002
 2016-07-10 00:41:28 -07:00
pdr
48898561db Update markdown docs to specify --local for the local devserver 
If the devserver is run locally following the instructions on
https://skia.org/dev/tools/markdown, you'll get an error about influxdb.
It looks like an influxdb username/password is required but using
--local works around this issue.

-------------------8<-------------------
$ ./bin/docserver --preview
E0703 19:33:31.510379   30448 common.go:37] Initializing logserver for log level ERROR.
F0703 19:33:31.516750   30448 common.go:63] metadata.Get() failed to make HTTP request for influxdb_name: Get http://metadata/computeMetadata/v1/project/attributes/influxdb_name: dial tcp: lookup metadata: no such host
goroutine 1 [running]:
github.com/skia-dev/glog.stacks(0x772300, 0x0, 0x0, 0x0)
    /src/github.com/skia-dev/glog/glog.go:769 +0xb8
github.com/skia-dev/glog.(*loggingT).output(0x756000, 0xc800000003, 0xc820136000, 0x73613e, 0x9, 0x3f, 0x0)
    /src/github.com/skia-dev/glog/glog.go:720 +0x259
github.com/skia-dev/glog.(*loggingT).printDepth(0x756000, 0x3, 0x1, 0xc8200dde28, 0x1, 0x1)
    /src/github.com/skia-dev/glog/glog.go:649 +0x1b8
github.com/skia-dev/glog.(*loggingT).print(0x756000, 0x3, 0xc8200dde28, 0x1, 0x1)
    /src/github.com/skia-dev/glog/glog.go:640 +0x50
github.com/skia-dev/glog.Fatal(0xc8200dde28, 0x1, 0x1)
    /src/github.com/skia-dev/glog/glog.go:1128 +0x49
go.skia.org/infra/go/common.StartMetrics2(0x5103e0, 0x9, 0xc820104400, 0xc820104430, 0xc820104450, 0xc820104470, 0xc8200dde00)
    /src/go.skia.org/infra/go/common/common.go:63 +0x192
go.skia.org/infra/go/common.InitWithMetrics2(0x5103e0, 0x9, 0xc820104400, 0xc820104430, 0xc820104450, 0xc820104470, 0xc820104498)
    /src/go.skia.org/infra/go/common/common.go:48 +0x65
main.main()
    /src/skia.googlesource.com/buildbot.git/doc/go/docserver/main.go:183 +0x95
-------------------8<-------------------

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2118113002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2118113002

Review-Url: https://codereview.chromium.org/2118113002
 2016-07-09 17:08:24 -07:00
dvonbeck
e6347ad745 Abstracted diffuse color map out of SkLightingShaderImpl into a generic SkShader 
Will not run until after landing https://codereview.chromium.org/2106893003/

This CL's base is the CL for the addition of NormalSource to the API: https://codereview.chromium.org/2063793002/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062703003

Committed: https://skia.googlesource.com/skia/+/3f58cd0eb8bf4499c4f179aa6111d7e005809df8
Review-Url: https://codereview.chromium.org/2062703003
 2016-07-09 17:08:16 -07:00
robertphillips
443023975e Add choke point for modifying non-AA rect draws (e.g., applying clipping) 
NOTREECHECKS=true
NOPRESUBMIT=true

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125333002

Committed: https://skia.googlesource.com/skia/+/e5e3a7a5203f256083d015c923cc9c662877aba9
Review-Url: https://codereview.chromium.org/2125333002
 2016-07-08 14:43:04 -07:00
robertphillips
9a4cfa81de Revert of Add choke point for modifying non-AA rect draws (e.g., applying clipping) (patchset #6 id:100001 of https://codereview.chromium.org/2125333002/ ) 
Reason for revert:
problems

Original issue's description:
> Add choke point for modifying non-AA rect draws (e.g., applying clipping)
>
> NOTREECHECKS=true
> NOPRESUBMIT=true
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125333002
>
> Committed: https://skia.googlesource.com/skia/+/e5e3a7a5203f256083d015c923cc9c662877aba9

TBR=bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2136643002
 2016-07-08 13:30:04 -07:00
bungeman
7ad42cfe87 Corrected test for gcc/libc++ workaround. 
NOTREECHECKS=true
NOTRY=true
The presubmit bot is all hung up.

Review-Url: https://codereview.chromium.org/2136613002
 2016-07-08 12:25:37 -07:00
robertphillips
e5e3a7a520 Add choke point for modifying non-AA rect draws (e.g., applying clipping) 
NOTREECHECKS=true
NOPRESUBMIT=true

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125333002

Review-Url: https://codereview.chromium.org/2125333002
 2016-07-08 12:00:07 -07:00
bsalomon
6cc9006a90 Use clipped bounds for reordering decisions 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2137543002

NOTREECHECKS=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2137543002
 2016-07-08 11:31:23 -07:00
bsalomon
8e9e45a69b Revert change of bounds computation in MSAA path renderer. 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2133773002

Review-Url: https://codereview.chromium.org/2133773002
 2016-07-08 09:14:07 -07:00
dvonbeck
66ad44a3f1 Fixed error when normal.z = 1 in GPUs with binary16 floats 
Check failed in GPUs with low-precision floats since 0.9999 was too small a difference from 1 to be detected by a 16-bit float comparison. Changed it to 0.999 which fixed the issue and results in indistinguishable correct behavior.

BUG=skia:5499
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2124183004

Review-Url: https://codereview.chromium.org/2124183004
 2016-07-08 08:59:47 -07:00
reed
babc3de2ce deferred canvas 
tries to eliminate unneeded clipRects and concats (and their associated save/restores).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2120333002

Review-Url: https://codereview.chromium.org/2120333002
 2016-07-08 08:43:28 -07:00
bsalomon
bd2bbe4a17 Don't scissor draws overlapping the render target's edges 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2135673002

Review-Url: https://codereview.chromium.org/2135673002
 2016-07-08 07:36:42 -07:00
bsalomon
88cf17d099 Consolidate handling of infinitely thin primitives and aa bloat handing WRT batch bounds. 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2127673002

Review-Url: https://codereview.chromium.org/2127673002
 2016-07-08 06:40:57 -07:00
mtklein
ac41bac40f Move sRGB <-> linear conversion components to their own files. 
This makes them a little easier to use outside SkColorXform code.

I've added some notes about how best to use them and their eccentricities, and added a test.

Ultimately any software sRGB <-> linear conversion should funnel somehow through here.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128893002
CQ_EXTRA_TRYBOTS=client.skia.android:Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot;client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed: https://skia.googlesource.com/skia/+/45e58c8807179638980aae8503573b950b844e4c
Review-Url: https://codereview.chromium.org/2128893002
 2016-07-08 06:33:16 -07:00
rmistry
0e56972e5f Revert of Abstracted diffuse color map out of SkLightingShaderImpl into a generic SkShader (patchset #11 id:200001 of https://codereview.chromium.org/2062703003/ ) 
Reason for revert:
Causing the Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind builder to fail.

Started failing at this build:
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind/builds/1214

Snippet from build log:

==3016== Invalid read of size 4
==3016==    at 0xCD1901: GrFragmentProcessor::registerChildProcessor(sk_sp<GrFragmentProcessor>) (SkTArray.h:163)
==3016==    by 0xA58B47: _Z10sk_make_spI11NormalMapFPI5sk_spI19GrFragmentProcessorERK8SkMatrixEES1_IT_EDpOT0_ (SkNormalSource.cpp:84)
==3016==    by 0xA582E8: NormalMapSourceImpl::asFragmentProcessor(GrContext*, SkMatrix const&, SkMatrix const*, SkFilterQuality, SkSourceGammaTreatment) const (SkNormalSource.cpp:187)
==3016==    by 0xA0ADB5: SkLightingShaderImpl::asFragmentProcessor(GrContext*, SkMatrix const&, SkMatrix const*, SkFilterQuality, SkSourceGammaTreatment) const (SkLightingShader.cpp:268)
==3016==    by 0xDA17E6: skpaint_to_grpaint_impl(GrContext*, SkPaint const&, SkMatrix const&, sk_sp<GrFragmentProcessor>*, SkXfermode::Mode*, bool, bool, GrPaint*) (SkGr.cpp:552)
==3016==    by 0xDA4532: SkPaintToGrPaint(GrContext*, SkPaint const&, SkMatrix const&, bool, GrPaint*) (SkGr.cpp:668)
==3016==    by 0xD99B51: SkGpuDevice::drawRect(SkDraw const&, SkRect const&, SkPaint const&) (SkGpuDevice.cpp:534)
==3016==    by 0x9DDB1C: SkCanvas::onDrawRect(SkRect const&, SkPaint const&) (SkCanvas.cpp:2148)
==3016==    by 0x9DBF40: SkCanvas::drawRect(SkRect const&, SkPaint const&) (SkCanvas.cpp:1919)
==3016==    by 0x8D2A55: skiagm::LightingShaderGM::onDraw(SkCanvas*) (lightingshader.cpp:110)
==3016==    by 0x625659: skiagm::GM::drawContent(SkCanvas*) (gm.cpp:32)
==3016==    by 0x6256AD: skiagm::GM::draw(SkCanvas*) (gm.cpp:24)
==3016==    by 0x61B747: DM::GMSrc::draw(SkCanvas*) const (DMSrcSink.cpp:61)
==3016==    by 0x61F37B: DM::GPUSink::draw(DM::Src const&, SkBitmap*, SkWStream*, SkString*) const (DMSrcSink.cpp:1115)
==3016==    by 0x619261: dm_main() (DM.cpp:1016)
==3016==    by 0x619841: main (DM.cpp:1409)
==3016==  Address 0xf4 is not stack'd, malloc'd or (recently) free'd
==3016==

Caught signal 11 [Segmentation fault], was running:
	gpu gm  lightingshader

Original issue's description:
> Abstracted diffuse color map out of SkLightingShaderImpl into a generic SkShader
>
> Will not run until after landing https://codereview.chromium.org/2106893003/
>
> This CL's base is the CL for the addition of NormalSource to the API: https://codereview.chromium.org/2063793002/
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062703003
>
> Committed: https://skia.googlesource.com/skia/+/3f58cd0eb8bf4499c4f179aa6111d7e005809df8

TBR=egdaniel@google.com,robertphillips@google.com,dvonbeck@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:
NOTRY=true

Review-Url: https://codereview.chromium.org/2137513002
 2016-07-08 06:23:35 -07:00
brianosman
86dc226b60 Use sRGB pixel config for ARGB masks (color emoji) 
Fixes over-bright color emoji and GM:colortype in sRGB mode

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129913004

Committed: https://skia.googlesource.com/skia/+/920af9fac3d9e275a93910d9c626ee7bc23ed17a
Review-Url: https://codereview.chromium.org/2129913004
 2016-07-08 06:15:45 -07:00
bsalomon
4b4a7cca63 Reland of Better encapsulate oval/rrect batchs. (patchset #1 id:1 of https://codereview.chromium.org/2121313004/ ) 
Reason for revert:
Workaround for compiler/stdlib bug landed: https://codereview.chromium.org/2135453002

Original issue's description:
> Revert of Better encapsulate oval/rrect batchs. (patchset #5 id:80001 of https://codereview.chromium.org/2104423003/ )
>
> Reason for revert:
> This CL is suspected to break compilation on arm64.
> https://build.chromium.org/p/chromium.android/builders/Android%20arm64%20Builder%20%28dbg%29/builds/5851/steps/compile/logs/stdio
>
> Original issue's description:
> > Better encapsulate oval/rrect batchs.
> > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2104423003
> >
> > Committed: https://skia.googlesource.com/skia/+/5fd209e8ee477c703bc5c11b008f247d515fc0fc
> > Committed: https://skia.googlesource.com/skia/+/7f06c6947a3bef78dc57b9252779567c33604c90
> > Committed: https://skia.googlesource.com/skia/+/11bf8b2eae7d1780cb969146422a2ab3b933047a
>
> TBR=robertphillips@google.com,bsalomon@google.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/c79fc33d3e83664ffbd3651df3131c3e9e0b635c

TBR=robertphillips@google.com,hush@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2134693002
 2016-07-08 04:42:54 -07:00
reed
dde2b1f1a8 update path->rsxform to correctly interp dy 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2131043002

TBR=

Review-Url: https://codereview.chromium.org/2131043002
 2016-07-08 03:31:09 -07:00
bsalomon
f48c62fa6a Promote the GCC/libc++/<memory> 'typedef float float32_t' workaround to SkTypes.h 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2135453002

Review-Url: https://codereview.chromium.org/2135453002
 2016-07-08 03:28:42 -07:00
bsalomon
00ee2a8482 Make all parameters reqiured to GrReducedClip::ReduceClipStack 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130903002

Review-Url: https://codereview.chromium.org/2130903002
 2016-07-08 03:28:34 -07:00
mtklein
e930459a18 Revert of Move sRGB <-> linear conversion components to their own files. (patchset #5 id:80001 of https://codereview.chromium.org/2128893002/ ) 
Reason for revert:
Monotonicity assert is failing on ARM.  (Different rsqrt() and invert() precision?)  Will investigate a bit tomorrow... might reland with the test TODO.

Original issue's description:
> Move sRGB <-> linear conversion components to their own files.
>
> This makes them a little easier to use outside SkColorXform code.
>
> I've added some notes about how best to use them and their eccentricities, and added a test.
>
> Ultimately any software sRGB <-> linear conversion should funnel somehow through here.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128893002
> CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/45e58c8807179638980aae8503573b950b844e4c

TBR=reed@google.com,msarett@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2131793002
 2016-07-07 18:34:06 -07:00
reed
ea5a6513c0 make some canvas utils virtual (for proxy based subclasses) 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130973002

Review-Url: https://codereview.chromium.org/2130973002
 2016-07-07 16:44:27 -07:00
reed
63f30d9049 fix typos and capitalization on drawTextRSXform CL 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2123923006

Review-Url: https://codereview.chromium.org/2123923006
 2016-07-07 16:32:51 -07:00
pdr
c42475cea2 Update markdown to use absolute image paths, fixing broken images 
Markdown can be served with or without a trailing slash but when a
trailing slash is present, relative image links were broken.

The following example works as expected:
url: https://skia.org/dev/design/pdftheory
image url: PdfLogicalDocumentStructure.png
resolves to: https://skia.org/dev/design/PdfLogicalDocumentStructure.png

The following example was broken before this patch:
url: https://skia.org/dev/design/pdftheory/
image url: PdfLogicalDocumentStructure.png
resolves to: https://skia.org/dev/design/pdftheory/PdfLogicalDocumentStructure.png

The PdfLogicalDocumentStructure.png file lives in /dev/design/, not
/dev/design/pdftheory/. This patch updates all images in our markdown
files to be served with the full path so a trailing slash no longer
breaks images.

I hit this bug when promoting the new Skia debugger:
https://groups.google.com/a/chromium.org/d/msg/paint-dev/QJ8xpu8dNyA/F4KX2O4ZBwAJ

BUG=skia:5493
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128013003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2128013003

Review-Url: https://codereview.chromium.org/2128013003
 2016-07-07 14:48:53 -07:00
mtklein
45e58c8807 Move sRGB <-> linear conversion components to their own files. 
This makes them a little easier to use outside SkColorXform code.

I've added some notes about how best to use them and their eccentricities, and added a test.

Ultimately any software sRGB <-> linear conversion should funnel somehow through here.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128893002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review-Url: https://codereview.chromium.org/2128893002
 2016-07-07 14:47:36 -07:00
reed
6d2c3e7da6 add bounds to textblob 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2124113003

TBR=

Review-Url: https://codereview.chromium.org/2124113003
 2016-07-07 14:10:14 -07:00
hush
c79fc33d3e Revert of Better encapsulate oval/rrect batchs. (patchset #5 id:80001 of https://codereview.chromium.org/2104423003/ ) 
Reason for revert:
This CL is suspected to break compilation on arm64.
https://build.chromium.org/p/chromium.android/builders/Android%20arm64%20Builder%20%28dbg%29/builds/5851/steps/compile/logs/stdio

Original issue's description:
> Better encapsulate oval/rrect batchs.
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2104423003
>
> Committed: https://skia.googlesource.com/skia/+/5fd209e8ee477c703bc5c11b008f247d515fc0fc
> Committed: https://skia.googlesource.com/skia/+/7f06c6947a3bef78dc57b9252779567c33604c90
> Committed: https://skia.googlesource.com/skia/+/11bf8b2eae7d1780cb969146422a2ab3b933047a

TBR=robertphillips@google.com,bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2121313004
 2016-07-07 13:58:39 -07:00
brianosman
180500e5f1 Revert of Use sRGB pixel config for ARGB masks (color emoji) (patchset #1 id:1 of https://codereview.chromium.org/2129913004/ ) 
Reason for revert:
Color text rendering failing on ANGLE

Original issue's description:
> Use sRGB pixel config for ARGB masks (color emoji)
>
> Fixes over-bright color emoji and GM:colortype in sRGB mode
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129913004
>
> Committed: https://skia.googlesource.com/skia/+/920af9fac3d9e275a93910d9c626ee7bc23ed17a

TBR=bungeman@google.com,jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2128583007
 2016-07-07 13:18:51 -07:00
reed
45561a0b15 drawTextRSXform 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130643004

Review-Url: https://codereview.chromium.org/2130643004
 2016-07-07 12:47:17 -07:00
halcanary
a76a10b730 SkPDF: Fix encoding of unichr outside of basic plane 
In ToUnicode table, write unicode codepoints as one or two UTF16BE
values, rather than a single hex, as the standard requires.

Factor out uint16 -> big-endian hex code.

SkUtils is now a namespace.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2120533002

Review-Url: https://codereview.chromium.org/2120533002
 2016-07-07 12:31:55 -07:00
halcanary
492d6b5b06 SkPDF: fix PDFA-only metadata error 
Review-Url: https://codereview.chromium.org/2119883002
 2016-07-07 12:28:31 -07:00
brianosman
920af9fac3 Use sRGB pixel config for ARGB masks (color emoji) 
Fixes over-bright color emoji and GM:colortype in sRGB mode

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129913004

Review-Url: https://codereview.chromium.org/2129913004
 2016-07-07 12:22:39 -07:00