Commit Graph

8893 Commits

Author SHA1 Message Date
epoger@google.com
7e72693a6d Rebaseline "lighting" GM tests
See diffs at http://c128.i.corp.google.com/skia/pixeldiffs/lighting/diffs/

TBR=bsalomon

Review URL: https://codereview.chromium.org/23441069

git-svn-id: http://skia.googlecode.com/svn/trunk@11271 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 20:36:24 +00:00
rmistry@google.com
91042c26ca Whitespace change to test commits.
(SkipBuildbotRuns)

Review URL: https://codereview.chromium.org/23522045

git-svn-id: http://skia.googlecode.com/svn/trunk@11269 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 20:29:55 +00:00
mtklein@google.com
dbd41c8857 It looks like we're not always running long enough to give the GPU counters time to converge (and possibly the same for CPU too, but GPU is definitely worse off).
This CL changes our convergence logic from
  - did the last run take more than x milliseconds?
to
  - did the last run take more x milliseconds and are the last two runs within y% of each other?

There's also now an upper limit where we bail out with an error if we haven't yet met the convergence criteria.  Keeping the lower bound is important for benches where the constant overhead is much larger than the work done in the loop; without it we'll see T(1 loop) == T(2 loops) and converge way too early.

This CL also exposed that DeferredCanvasBench had a bug: it was running N^2 loops when we told it to run N.  (My fault.)

I threw in a couple other linty changes that I'd be happy to split off.

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23536046

git-svn-id: http://skia.googlecode.com/svn/trunk@11267 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 20:11:09 +00:00
epoger@google.com
3ad5dd009f Speed up GM ~50% by NOT running most renderModes by default
BUG=skia:1566
R=borenet@google.com, bsalomon@google.com

Review URL: https://codereview.chromium.org/23889030

git-svn-id: http://skia.googlecode.com/svn/trunk@11265 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 19:56:14 +00:00
mtklein@google.com
410e6e80f0 Refactoring: get rid of the SkBenchmark void* parameter.
While I was doing massive sed-ing, I also converted every bench to use DEF_BENCH instead of registering the ugly manual way.

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/23876006

git-svn-id: http://skia.googlecode.com/svn/trunk@11263 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 19:52:27 +00:00
edisonn@google.com
af54a513a5 pdfviewer: do not submit, uploaded for backup, and will be done actually after I refactor the params for functions, to put the char* params in a structure: report errors and warnings in pdf, infrastructure
Review URL: https://codereview.chromium.org/23902018

git-svn-id: http://skia.googlecode.com/svn/trunk@11262 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 19:33:42 +00:00
mtklein@google.com
1fb04e2540 add a way to get code coverage
BUG=
R=borenet@google.com

Review URL: https://codereview.chromium.org/23523055

git-svn-id: http://skia.googlecode.com/svn/trunk@11261 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 19:32:43 +00:00
reed@google.com
cee9dcb837 start to remove lockPixels from bitmapshader
BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/23591030

git-svn-id: http://skia.googlecode.com/svn/trunk@11258 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 16:04:49 +00:00
sugoi@google.com
f4dc60457b Canary build fix
BUG=
R=bsalomon@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/23532068

git-svn-id: http://skia.googlecode.com/svn/trunk@11257 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 15:42:46 +00:00
robertphillips@google.com
96bf2b53f2 N7 Performance trigger rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@11256 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 15:42:08 +00:00
bsalomon@google.com
9e488d8294 I don't know what you've been told, rebaselining images never gets old
R=epoger@google.com

Review URL: https://codereview.chromium.org/23531047

git-svn-id: http://skia.googlecode.com/svn/trunk@11255 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 14:27:54 +00:00
bsalomon@google.com
8c762c61bd They're RRRRRrrrrrrreeebaseline!
R=epoger@google.com

Review URL: https://codereview.chromium.org/23771006

git-svn-id: http://skia.googlecode.com/svn/trunk@11254 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 14:19:53 +00:00
bsalomon@google.com
33cd0cada2 319 bottles of rebaseline on the wall...
R=epoger@google.com

Review URL: https://codereview.chromium.org/23629042

git-svn-id: http://skia.googlecode.com/svn/trunk@11252 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 13:49:18 +00:00
robertphillips@google.com
40fcb59894 More warnings as errors fixes
git-svn-id: http://skia.googlecode.com/svn/trunk@11251 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 13:13:29 +00:00
robertphillips@google.com
558d5d3f08 Warnings as errors fix
git-svn-id: http://skia.googlecode.com/svn/trunk@11250 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 12:54:33 +00:00
commit-bot@chromium.org
4b681bc95b Fixed issues found by fuzzer
Last week, the fuzzer found a few numerical issue with filters and I had written some fixes for them. Here are the fixes with some unit tests.

For senorblanco : So I figured out what was asserting when we'd get a 0 width "result" in SkBicubicImageFilter::onFilterImage(). Basically, if the "result" SkBitmap object calls SkBitmap::setConfig() with "width" and/or "height" set to 0, then the SkBitmap object will call SkBitmap::reset(), making the SkBitmap object's config invalid. At this point, calling SkBitmap::getAddr32() will assert, even without attempting to dereference the data pointer, because the SkBitmap's config is invalid. If height is valid, but width is 0, then this call to SkBitmap::getAddr32() happens directly in SkBicubicImageFilter::onFilterImage() a few lines lower and asserts right away.

BUG=
R=senorblanco@google.com, senorblanco@chromium.org, bsalomon@google.com

Author: sugoi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23533042

git-svn-id: http://skia.googlecode.com/svn/trunk@11249 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 12:40:02 +00:00
commit-bot@chromium.org
ab13167410 Removes uses of unnamed namespace from samplecode.
Skia code prefers static over unnamed namespace.

R=bsalomon@google.com, robertphillips@google.com

Author: tfarina@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23498028

git-svn-id: http://skia.googlecode.com/svn/trunk@11248 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 12:39:55 +00:00
commit-bot@chromium.org
5792cded61 Initial error handling code
I made it as simple as possible. The impact seems minimal and it should do what's necessary to make this code secure.

BUG=
R=reed@google.com, scroggo@google.com, djsollen@google.com, sugoi@google.com, bsalomon@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org

Author: sugoi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23021015

git-svn-id: http://skia.googlecode.com/svn/trunk@11247 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 12:39:34 +00:00
commit-bot@chromium.org
2db4eabb77 ARM Skia NEON patches - 19 - Intrinsics version of the Filter32 routines
BitmapProcState: translate the filtering routines to intrinsics

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>

BUG=
R=djsollen@google.com, mtklein@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/21915004

git-svn-id: http://skia.googlecode.com/svn/trunk@11246 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 12:39:09 +00:00
epoger@google.com
4907b30312 whitespace change to trigger buildbots
Review URL: https://codereview.chromium.org/23620048

git-svn-id: http://skia.googlecode.com/svn/trunk@11240 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-12 19:50:17 +00:00
bsalomon@google.com
6924e9bbce Rebaseline ANGLE Release bot
(SkipBuildbotRuns)

R=epoger@google.com
BUG=

Review URL: https://codereview.chromium.org/23851025

git-svn-id: http://skia.googlecode.com/svn/trunk@11227 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-12 17:23:21 +00:00
borenet@google.com
3fef76a0e0 Whitespace change to trigger rebuilds
Review URL: https://codereview.chromium.org/23523054

git-svn-id: http://skia.googlecode.com/svn/trunk@11224 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-12 15:59:32 +00:00
epoger@google.com
6f3fe63bdf Whitespace commit to trigger the buildbots, and possible downfall of society.
Review URL: https://codereview.chromium.org/23542031

git-svn-id: http://skia.googlecode.com/svn/trunk@11221 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-12 05:37:01 +00:00
bsalomon@google.com
3075134de9 The final rebasline?
(SkipBuildbotRuns)

R=epoger@google.com

Review URL: https://codereview.chromium.org/23964009

git-svn-id: http://skia.googlecode.com/svn/trunk@11214 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-11 21:43:26 +00:00
bsalomon@google.com
49986400e1 Rererererebaseline
(SkipBuildbotRuns)

R=epoger@google.com

Review URL: https://codereview.chromium.org/23981010

git-svn-id: http://skia.googlecode.com/svn/trunk@11213 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-11 21:36:56 +00:00
bsalomon@google.com
e24890b51f Did you say rebaseline?
(SkipBuildbotRuns)

R=epoger@google.com

Review URL: https://codereview.chromium.org/23964008

git-svn-id: http://skia.googlecode.com/svn/trunk@11212 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-11 21:24:00 +00:00
bsalomon@google.com
78399a98f7 Fresh baselines!
(SkipBuildbotRuns)

R=epoger@google.com

Review URL: https://codereview.chromium.org/24079005

git-svn-id: http://skia.googlecode.com/svn/trunk@11211 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-11 21:11:47 +00:00
bsalomon@google.com
9da31ed0a8 More rebaselines due to re-enabling gpu batching.
(SkipBuildbotRuns)

R=epoger@google.com

Review URL: https://codereview.chromium.org/23754011

git-svn-id: http://skia.googlecode.com/svn/trunk@11210 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-11 20:47:19 +00:00
bsalomon@google.com
bb50d6148b Rebase after re-enabling GPU batching.
(SkipBuildbotRuns)

R=epoger@google.com

Review URL: https://codereview.chromium.org/23546011

git-svn-id: http://skia.googlecode.com/svn/trunk@11208 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-11 19:20:12 +00:00
epoger@google.com
bfe9167c66 Add README file so git will create empty dir
BUG=skia:1613
(SkipBuildbotRuns)

R=rmistry@google.com

Review URL: https://codereview.chromium.org/24112002

git-svn-id: http://skia.googlecode.com/svn/trunk@11203 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-11 17:31:49 +00:00
djsollen@google.com
3a98ed7658 various bug fixes.
1. update mac support for md5
2. update default build to be thumb

(SkipBuildbotRuns)

R=mtklein@google.com

Review URL: https://codereview.chromium.org/23514051

git-svn-id: http://skia.googlecode.com/svn/trunk@11201 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-11 16:56:20 +00:00
borenet@google.com
7aa8044da5 Ignore the .git directory in sanitize_source_files, remove .git directory...
R=rmistry@google.com

Review URL: https://codereview.chromium.org/23981006

git-svn-id: http://skia.googlecode.com/svn/trunk@11193 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-11 13:01:27 +00:00
skia.committer@gmail.com
ac61ce4ab9 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11192 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-11 07:38:22 +00:00
mtklein@google.com
b87bf83f48 Add explicit double -> SkScalar conversion to fix werror on Windows.
BUG=

Review URL: https://codereview.chromium.org/23432008

git-svn-id: http://skia.googlecode.com/svn/trunk@11190 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-10 19:51:10 +00:00
bsalomon@google.com
e932c98069 re-enable GrIODB
R=robertphillips@google.com
BUG=

Review URL: https://codereview.chromium.org/23542023

git-svn-id: http://skia.googlecode.com/svn/trunk@11189 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-10 19:47:01 +00:00
mtklein@google.com
78d0379dcc Add missing dependency to unbreak NOGPU build.
BUG=

Review URL: https://codereview.chromium.org/23527004

git-svn-id: http://skia.googlecode.com/svn/trunk@11188 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-10 19:42:07 +00:00
mtklein@google.com
c289743864 Major bench refactoring.
- Use FLAGS_.
   - Remove outer repeat loop.
   - Tune inner loop automatically.

BUG=skia:1590
R=epoger@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/23478013

git-svn-id: http://skia.googlecode.com/svn/trunk@11187 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-10 19:23:38 +00:00
reed@google.com
55ebe8eca0 check for --resourcePath in addition to -i to match the --help string
git-svn-id: http://skia.googlecode.com/svn/trunk@11186 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-10 19:12:07 +00:00
robertphillips@google.com
2950038110 Rebaseline fontscaler image for Mac 10.8
https://codereview.chromium.org/23536042/



git-svn-id: http://skia.googlecode.com/svn/trunk@11185 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-10 18:55:27 +00:00
jvanverth@google.com
6cc8d4470d Fix for ovals failing on Xoom.
The fallback path for ellipses when we don't have GLSL derivative
instructions was only setting one attribute in the effect stage, but
we use two attributes.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23514047

git-svn-id: http://skia.googlecode.com/svn/trunk@11184 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-10 18:24:37 +00:00
robertphillips@google.com
115fbf66a9 Fix uninitialized string bug
https://codereview.chromium.org/23499013/



git-svn-id: http://skia.googlecode.com/svn/trunk@11182 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-10 17:37:03 +00:00
borenet@google.com
8ad29cea42 Fix bench logging for --repeat 1
Addressing https://code.google.com/p/skia/issues/detail?id=1607

R=scroggo@google.com

Review URL: https://codereview.chromium.org/23923011

git-svn-id: http://skia.googlecode.com/svn/trunk@11181 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-10 17:22:43 +00:00
epoger@google.com
508780ed08 revert experimental r11177
Review URL: https://codereview.chromium.org/24019006

git-svn-id: http://skia.googlecode.com/svn/trunk@11178 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-10 08:49:29 +00:00
epoger@google.com
6e5dac6286 experiment: remove 340 of the 664 GM expectations for this platform
BUG=skia:1566

Review URL: https://codereview.chromium.org/23718007

git-svn-id: http://skia.googlecode.com/svn/trunk@11177 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-10 07:55:51 +00:00
skia.committer@gmail.com
9a070f24f1 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11176 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-10 07:01:44 +00:00
bsalomon@google.com
e9382aea71 stragglers rebaseline. (flakes?)
R=epoger@google.com
BUG=

Review URL: https://codereview.chromium.org/23904008

git-svn-id: http://skia.googlecode.com/svn/trunk@11175 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-09 23:59:06 +00:00
bsalomon@google.com
437ce1db7c rebaseline cpu configs of scaled_tiledmodes_npot DW bot
R=epoger@google.com, humper@google.com

Review URL: https://codereview.chromium.org/23548027

git-svn-id: http://skia.googlecode.com/svn/trunk@11174 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-09 23:48:46 +00:00
bsalomon@google.com
f0cac80448 Even more bulk rebaselining
R=epoger@google.com
BUG=

Review URL: https://codereview.chromium.org/23724025

git-svn-id: http://skia.googlecode.com/svn/trunk@11173 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-09 23:42:27 +00:00
bsalomon@google.com
abdbfc788e More bulk rebaselining. I reviewed all the images, mostly from CLs.
Review URL: https://codereview.chromium.org/23710019

git-svn-id: http://skia.googlecode.com/svn/trunk@11171 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-09 20:36:21 +00:00
commit-bot@chromium.org
e0e7cfe44b Change old PRG to be SkLCGRandom; change new one to SkRandom
The goal here is to get people to start using the new random number
generator, while leaving the old one in place so we don't have to 
rebaseline GMs.

R=reed@google.com, bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/23576015

git-svn-id: http://skia.googlecode.com/svn/trunk@11169 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-09 20:09:12 +00:00