qiankun.miao
8247ec313d
Fix format of nanobench result
...
Column of samples is too wide. This makes config is not align with the
'config' title. Pad 'samples' tilte with some whitespaces to fix this
issue.
BUG=skia:
R=mtklein@google.com
Author: qiankun.miao@intel.com
Review URL: https://codereview.chromium.org/549153005
2014-09-09 19:24:36 -07:00
reed
9728a2bf56
correct prev suppression
...
TBR=
NOTRY=True
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/543903005
2014-09-09 19:22:37 -07:00
reed
9a6300a2b0
suppress multipicturedraw_pathclip_tiled_nvprmsaa4 after the conservative-rasterclip cl
...
TBR=
NOTRY=True
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/555403002
2014-09-09 19:08:28 -07:00
reed
d954498c01
Revert of Revert of allow canvas to force conservative clips (for speed) (patchset #1 id:1 of https://codereview.chromium.org/554033003/ )
...
Reason for revert:
May just rebaseline, plus want to see the results of the chrome tests, so re-trying this CL.
Original issue's description:
> Revert of allow canvas to force conservative clips (for speed) (patchset #7 id:120001 of https://codereview.chromium.org/541593005/ )
>
> Reason for revert:
> multipicturedraw failed on nvprmsaa -- don't know why yet
>
> Original issue's description:
> > Allow SkCanvas to be initialized to force conservative rasterclips. This has the following effects:
> >
> > 1. Queries to the current clip will be conservatively large. This can mean the quickReject may return false more often.
> >
> > 2. The conservative clips mean less work is done.
> >
> > 3. Enabled by default for Gpu, Record, and NoSaveLayer canvases.
> >
> > 4. API is private for now.
> >
> > Committed: https://skia.googlesource.com/skia/+/27a5e656c3d6ef22f9cb34de18e1b960da3aa241
>
> TBR=robertphillips@google.com ,bsalomon@google.com,mtklein@google.com,junov@google.com
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/6f09709519b79a1159f3826645f1c5fbc101ee11
R=robertphillips@google.com , bsalomon@google.com , mtklein@google.com , junov@google.com , reed@google.com
TBR=bsalomon@google.com , junov@google.com , mtklein@google.com , reed@google.com , robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/560713002
2014-09-09 18:46:22 -07:00
bungeman
87a79236f5
Rebaselines for 6bc2c94de3
(fontmgr_iter).
...
Rebaselines for "Add font fallback support to SkFontMgr_fontconfig."
2014-09-09 21:38:04 -04:00
humper
d3b6eb246d
disable webtry seccmp on non-linux build
...
BUG=skia:
R=jcgregorio@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/555993002
2014-09-09 15:57:33 -07:00
humper
d85ad50b0e
simple build script for webtry that re-generates the code template
...
before compilation
BUG=skia:
R=jcgregorio@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/552343003
2014-09-09 15:57:26 -07:00
Mike Klein
be20c5a118
rebase a couple oddballs
...
BUG=skia:
Review URL: https://codereview.chromium.org/555193004
2014-09-09 17:52:40 -04:00
Mike Klein
ef53f158de
Rebase intel rhb gpu GMs.
...
Looks like I accidentally re-enabled GPU mode in GM for Intel RHB.
Rebaseline it so it's green today before we turn it off tomorrow.
BUG=skia:
Review URL: https://codereview.chromium.org/552413002
2014-09-09 16:00:58 -04:00
reed
6f09709519
Revert of allow canvas to force conservative clips (for speed) (patchset #7 id:120001 of https://codereview.chromium.org/541593005/ )
...
Reason for revert:
multipicturedraw failed on nvprmsaa -- don't know why yet
Original issue's description:
> Allow SkCanvas to be initialized to force conservative rasterclips. This has the following effects:
>
> 1. Queries to the current clip will be conservatively large. This can mean the quickReject may return false more often.
>
> 2. The conservative clips mean less work is done.
>
> 3. Enabled by default for Gpu, Record, and NoSaveLayer canvases.
>
> 4. API is private for now.
>
> Committed: https://skia.googlesource.com/skia/+/27a5e656c3d6ef22f9cb34de18e1b960da3aa241
R=robertphillips@google.com , bsalomon@google.com , mtklein@google.com , junov@google.com
TBR=bsalomon@google.com , junov@google.com , mtklein@google.com , robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: reed@google.com
Review URL: https://codereview.chromium.org/554033003
2014-09-09 12:51:10 -07:00
bungeman
6bc2c94de3
Add font fallback support to SkFontMgr_fontconfig.
...
R=mtklein@google.com , djsollen@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/489733005
2014-09-09 12:50:36 -07:00
senorblanco
4459a0448d
When parsing arguments on Windows, check malloc() for failure.
...
Note: this code is only executed by Skia utilities AFAIK, not by
external clients.
BUG=skia:2642
R=reed@google.com
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/548343002
2014-09-09 12:37:16 -07:00
jshin
7476cf533b
Update the alias mapping for Noto Sans CJK.
...
To make the family names 'future-proof', we decided to shorten
the name of Noto Sans CJK, which requires a change in the alias
table in Skia.
Chrome OS CL (actually updating the fonts) and Chrome CL (updating the
font preferences on CrOS) are going together with this CL.
BUG=412151
TEST=With the above two CLs in on Chrome OS, Noto Sans CJK {JP, SC} are
used when MS P Gothic / Simhei are asked for by a web page.
R=bungeman@google.com
Author: jshin@chromium.org
Review URL: https://codereview.chromium.org/554943002
2014-09-09 12:30:57 -07:00
reed
27a5e656c3
Allow SkCanvas to be initialized to force conservative rasterclips. This has the following effects:
...
1. Queries to the current clip will be conservatively large. This can mean the quickReject may return false more often.
2. The conservative clips mean less work is done.
3. Enabled by default for Gpu, Record, and NoSaveLayer canvases.
4. API is private for now.
R=robertphillips@google.com , bsalomon@google.com , mtklein@google.com , junov@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/541593005
2014-09-09 12:19:30 -07:00
mtklein
f5b6bf775c
Make -d x86 have the default GPU cache size.
...
We have no a priori reason to limit the cache for new devices.
BUG=skia:
R=djsollen@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/556863006
2014-09-09 12:07:05 -07:00
george
b3eba478d5
Outset the stroke width when computing the bounds for drawing a stroked rect, or 1 if it's a hairline
...
Adds a testcase for stroke rect bug
R=reed@google.com , reed1
BUG=skia:
Author: george@mozilla.com
Review URL: https://codereview.chromium.org/552743004
2014-09-09 11:33:57 -07:00
senorblanco
32673b99a4
Allow negative values in SkBlurImageFilter sigma.
...
There are two ways negative sigma values may occur: in
the original filter parameters, or after multiplication
by a negative scaling CTM. The former case is
invalid according to the spec, so we continue to check
for it at validation time. In the latter case, we should
interpret it as a horizontal flip in the kernel pixel
access, and simply take the absolute value (since the
filter kernel is symmetric).
Also refactor all this logic into a single place for the
CPU, GPU and onFilterBounds() paths.
BUG=https://code.google.com/p/chromium/issues/detail?id=409602
R=sugoi@google.com , reed@google.com , sugoi@chromium.org
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/555603002
2014-09-09 09:15:04 -07:00
mtklein
c54056c839
Back to hashing source content, not .png.
...
BUG=skia:
R=jcgregorio@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/560453002
2014-09-09 08:42:04 -07:00
fmalita
90dc6412b4
Revert of Use SkBitmapCache to optimize readPixels on a texture-backed bitmap (patchset #6 id:100001 of https://codereview.chromium.org/533323002/ )
...
Reason for revert:
Component inversions in Blink's printing/webgl-repeated-printing.html: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/24033/layout-test-results/printing/webgl-repeated-printing-diff.txt
Reverting to unblock rolls.
Original issue's description:
> Use SkBitmapCache to optimize readPixels on a texture-backed bitmap
>
> BUG=skia:2786
>
> Committed: https://skia.googlesource.com/skia/+/95fd68e5ccd242a91e6dd827dd695f18661efbe6
R=junov@chromium.org , reed@google.com , bsalomon@google.com , piotaixr@chromium.org
TBR=bsalomon@google.com , junov@chromium.org , piotaixr@chromium.org , reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2786
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/551523003
2014-09-09 08:12:46 -07:00
sugoi
0249ec267a
Adding texture uploads without cache for YUV and ETC1
...
BUG=skia:
R=bsalomon@google.com , robertphillips@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/552843004
2014-09-09 08:12:34 -07:00
mtklein
ea65bfa8de
Update DM JSON format.
...
Ex. dm --match patch -w bad --key arch x86 gpu nvidia model z620 --properties git_hash abcd build_number 20 ->
{
"build_number" : "20",
"git_hash" : "abcd",
"key" : {
"arch" : "x86",
"gpu" : "nvidia",
"model" : "z620"
},
"results" : [
{
"key" : {
"config" : "565",
"name" : "ninepatch-stretch"
},
"md5" : "f78cfafcbabaf815f3dfcf61fb59acc7",
"options" : {
"source_type" : "GM"
}
},
{
"key" : {
"config" : "8888",
"name" : "ninepatch-stretch"
},
"md5" : "3e8a42f35a1e76f00caa191e6310d789",
"options" : {
"source_type" : "GM"
}
},
...
This breaks -r, but that's okay. Going to follow up this CL with one that removes that entirely.
BUG=skia:
R=stephana@google.com , jcgregorio@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/551873003
2014-09-09 07:59:46 -07:00
mtklein
197ceda929
Remove expectations / -r from DM entirely.
...
It's getting tricky to coordinate changes to output for bots with -r,
and -r is not widely used. The suggested alternative is to run skdiff.
BUG=skia:
R=jcgregorio@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/553583004
2014-09-09 07:36:57 -07:00
george
49e3199e63
SkRasterClip::quickReject doesn't need to check for emptiness as SkIRect::Intersect already does that for us
...
R=reed@google.com , reed1
BUG=skia:
Author: george@mozilla.com
Review URL: https://codereview.chromium.org/554743007
2014-09-09 06:14:57 -07:00
borenet
aa07459a5b
Update SKP version to 96
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/551263002
2014-09-08 21:08:41 -07:00
jbroman
dd1e9f7596
Remove a linear search in SkPictureRecord::addTextBlob.
...
It doesn't seem that harmful to have repeated text blobs in the array
if they occur within the same picture recording. And that does not seem
to be a common occurrence right now anyhow.
BUG=skia:2919
R=fmalita@chromium.org , reed@google.com , mtklein@google.com
Author: jbroman@chromium.org
Review URL: https://codereview.chromium.org/550043003
2014-09-08 13:24:33 -07:00
mtklein
e2d4eb7072
Hash .pngs instead of SkBitmaps.
...
This has the nice property of being able to double-check hashes after the fact.
mtklein@mtklein ~/skia (hash-png)> md5sum bad/8888/3x3bitmaprect.png
deede70ab2f34067d461fb4a93332d4c bad/8888/3x3bitmaprect.png
mtklein@mtklein ~/skia (hash-png)> grep 3x3bitmaprect_8888 bad/dm.json
"3x3bitmaprect_8888" : "deede70ab2f34067d461fb4a93332d4c",
I have checked that no two premultiplied colors map to the same unpremultiplied
color (math nerds: unpremultiplication is injective), so a change in
premultiplied SkBitmap will always imply a change in the encoded
unpremultiplied .png. This means, it's safe to hash .pngs; we won't miss
subtle changes.
BUG=skia:
R=jcgregorio@google.com , stephana@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/549203003
2014-09-08 12:42:23 -07:00
bsalomon
655ad128d0
Make GrEffectStage copy constructor work correctly with pending execution refs.
...
R=egdaniel@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/551083002
2014-09-08 12:06:20 -07:00
robertphillips
46625e06e2
Fix two SkRecord-backed layer hoisting bugs
...
The two bugs are/were:
The old loop to draw the hoisted layers included the saveLayer call which caused double application of the layer's paint (This is the +1 change).
The hoisted layer is intended to be drawn in device coordinates. The old code was drawing it in the coordinate space of the saveLayer thus it was misplaced (This is the setMatrix change).
Committed: https://skia.googlesource.com/skia/+/7c0cfd4ff8f6db50a8731c886db732b106268937
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/551843002
2014-09-08 11:37:59 -07:00
mtklein
858baf5b7d
Add --nameByHash for the bots, and refactor hashing a bit.
...
No diff in dm.json output.
Here's what we get when --nameByHash is on:
mtklein@mtklein ~/skia (dm)> ls bad4/
0077fefedcee39feae9d12751853758b.png 431921de1607b4e1ae6864cc684d9b8e.png 8a3e17eba9302498700a703bb286d1ef.png c6448cb266f5e0b8d02b512ad484a9ad.png
01b0dcd515e846ea3b7f3b4c68120943.png 4372eb0fce0b0bcf5a582c502f90ecef.png 8a6acdd96cf6915fa01a9cea6d6291b0.png c6db4e2c9860b900130af429373eafaa.png
02974ab0efa7aa325b3bf22515b33899.png 43bddc2e255a3501ce2728544b1d409d.png 8aa8763d11afd397c2768e54d5599181.png c716a9a53513a16e0572c67863e3be08.png
02b7b9e5e95e69f89b6cec9c4539d972.png 43cf7adda66b3719e4abd19e92dda55e.png 8ade6bb4c9e2244e0dbd9436cf6e2132.png c854bb6dd105644a71d0219025409039.png
02d29dbfd29260f9318fcd6177c6ba7b.png 4423958139a2b64185583dacb7379b13.png 8b039171593685112a9454879f40a965.png c863ac2394e519690c57e1392b14b19f.png
...
BUG=skia:
R=jcgregorio@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/550283002
2014-09-08 11:33:48 -07:00
egdaniel
8067412d92
Remove extra proctected in GrRODrawState.h
...
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/550243002
2014-09-08 10:48:37 -07:00
bsalomon
18444b1649
Remove debug-only ref of GrEffectStage
...
BUG=skia:2889
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/553973002
2014-09-08 10:45:58 -07:00
caryclark
361b8b0885
fail when coincidence is too far apart
...
TBR=
BUG=410552
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/556433002
2014-09-08 10:25:38 -07:00
robertphillips
224310941e
Revert of Fix two SkRecord-backed layer hoisting bugs (patchset #1 id:1 of https://codereview.chromium.org/551843002/ )
...
Reason for revert:
turning bots red
Original issue's description:
> Fix two SkRecord-backed layer hoisting bugs
>
> The two bugs are/were:
> The old loop to draw the hoisted layers included the saveLayer call which caused double application of the layer's paint (This is the +1 change).
>
> The hoisted layer is intended to be drawn in device coordinates. The old code was drawing it in the coordinate space of the saveLayer thus it was misplaced (This is the setMatrix change).
>
> Committed: https://skia.googlesource.com/skia/+/7c0cfd4ff8f6db50a8731c886db732b106268937
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/553983003
2014-09-08 10:10:51 -07:00
robertphillips
7c0cfd4ff8
Fix two SkRecord-backed layer hoisting bugs
...
The two bugs are/were:
The old loop to draw the hoisted layers included the saveLayer call which caused double application of the layer's paint (This is the +1 change).
The hoisted layer is intended to be drawn in device coordinates. The old code was drawing it in the coordinate space of the saveLayer thus it was misplaced (This is the setMatrix change).
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/551843002
2014-09-08 09:53:58 -07:00
mtklein
23c94f05ca
Let .skps have Expectations (i.e. work with -r) too.
...
BUG=skia:
R=jcgregorio@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/549183002
2014-09-08 09:12:28 -07:00
mtklein
93f52a6944
Turn on the save-layer optimization.
...
BUG=skia:
R=robertphillips@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/551853002
2014-09-08 08:41:37 -07:00
piotaixr
95fd68e5cc
Use SkBitmapCache to optimize readPixels on a texture-backed bitmap
...
BUG=skia:2786
R=junov@chromium.org , reed@google.com , bsalomon@google.com
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/533323002
2014-09-08 08:07:47 -07:00
mtklein
1d0f1642e8
Start to rework DM JSON handling.
...
DM's striking off into its own JSON world. This gets strawman implementations
in place for writing and reading a JSON file mapping test name to hashes.
For what it's worth, I basically want to change _all_ these pieces,
- MD5 is slow and we can replace it with something faster,
- JSON schema needs room to grow more data,
- it'd be nice to hash once instead of twice when reading and writing,
- this code wants lots of refactoring,
but this gives us a starting platform to work on these bits at our leisure.
E.x. file for now:
mtklein@mtklein ~/skia (dm)> cat good/dm.json
{
"3x3bitmaprect_565" : "fc70d985fbfbe70e3a3c9dc626d4f5bc",
"3x3bitmaprect_8888" : "df1591dde35907399734ea19feb76663",
"3x3bitmaprect_gpu" : "df1591dde35907399734ea19feb76663",
"aaclip_565" : "1862798689b838a7ab0dc0652b9ace3a",
"aaclip_8888" : "47bb314329f0ce243f1d83fd583decb7",
"aaclip_gpu" : "75f72412d0ef4815770202d297246e7d",
...
BUG=skia:
R=jcgregorio@google.com , stephana@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/546873002
2014-09-08 08:05:18 -07:00
mtklein
87c4138fae
Turn on all pixel-perfect SkRecord optimizations.
...
BUG=skia:
R=robertphillips@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/550083006
2014-09-08 07:31:18 -07:00
borenet
6dcccc476b
Update SKP version to 95
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/552663002
2014-09-07 20:52:37 -07:00
borenet
9f8cab1538
Update SKP version to 94
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/541173005
2014-09-06 20:40:51 -07:00
borenet
ce23aaee8d
Update SKP version to 93
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/543343002
2014-09-05 21:23:05 -07:00
reed
d64c948713
move rasterclip_ helper into rasterclip
...
R=robertphillips@google.com , reed@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/546113002
2014-09-05 17:37:38 -07:00
bsalomon
2a9ca782ba
Make GrDrawState and GrEffectStage use the pending io/exec ref mechanisms.
...
BUG=skia:2889
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/542723004
2014-09-05 14:27:43 -07:00
stephana
03e844a0bc
Refactored frontend for the rebaseline server.
...
This is going to serve as the starting point for the new front-end once the backend is rewritten.
BUG=skia:
NOTRY=true
R=jcgregorio@google.com
Author: stephana@google.com
Review URL: https://codereview.chromium.org/538613002
2014-09-05 13:51:24 -07:00
bsalomon
49f085dddf
"NULL !=" = NULL
...
R=reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/544233002
2014-09-05 13:34:00 -07:00
stephana
7260d7292b
For certain input skpdiff segfaulted. This prevents the segfault and should fix the failed test in housekeeping.
...
BUG=skia:2902
R=mtklein@google.com , rmistry@google.com
Author: stephana@google.com
Review URL: https://codereview.chromium.org/546753003
2014-09-05 13:21:42 -07:00
bsalomon
52e9d63f71
Don't take a ref on GP in AutoEffectRestore.
...
BUG=skia:2889
R=joshualitt@chromium.org , robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/546043002
2014-09-05 12:23:12 -07:00
joshualitt
5a80be2241
Small fix for RODrawState
...
BUG=skia:
R=egdaniel@google.com , joshualitt@google.com
Author: joshualitt@chromium.org
Review URL: https://codereview.chromium.org/545273002
2014-09-05 10:45:30 -07:00
mtklein
4f90c50b56
Suppress mystery leak.
...
BUG=skia:2916
R=caryclark@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/543063002
2014-09-05 10:36:40 -07:00