brianosman
8aeec39f1f
New helper for creating a color space from another, with linear gamma
...
Going to need this in many places once we expliclty require F16 surfaces
to have linear gamma color spaces.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2270103002
Review-Url: https://codereview.chromium.org/2270103002
2016-08-24 05:11:20 -07:00
rmistry
3f1c9c0a72
Apply gerrit ref if it is a Gerrit patch.
...
Also:
* Pass through a new property 'patch_storage' to DM/Nanobench/Coverage. This will be used by the different frameworks to figure out if it is Rietveld or Gerrit issue.
* Calculate issue and patchset for Gerrit patches similar to Rietveld.
BUG=skia:5627
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263323002
Review-Url: https://codereview.chromium.org/2263323002
2016-08-24 05:07:06 -07:00
reed
6a88206b2e
combine setRectFan and mapRect
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2276603002
Review-Url: https://codereview.chromium.org/2276603002
2016-08-24 04:22:08 -07:00
msarett
9dc6cf6b88
Fix generic color space xform, ColorSpaceXformTest
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275563002
Review-Url: https://codereview.chromium.org/2275563002
2016-08-23 17:53:06 -07:00
msarett
ae6377c08e
Make singleton SkColorSpaces thread safe
...
SkColorSpaces may be once-ptrs, so we can reuse common color spaces.
This means that they must be thread safe. SkMatrix44 is not
thread safe because it maintains a mutable type mask.
This CL ensures that we precompute the type mask so we
can use const SkMatrix44's safely.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277463002
Review-Url: https://codereview.chromium.org/2277463002
2016-08-23 14:36:20 -07:00
bsalomon
19fe41e85e
Remove SkPixelRef::getTexture()
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264293003
Review-Url: https://codereview.chromium.org/2264293003
2016-08-23 14:02:54 -07:00
mtklein
457b42a639
GN: extract optional() as a template and use for giflib-dependent code
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2270833003
Review-Url: https://codereview.chromium.org/2270833003
2016-08-23 13:56:37 -07:00
mtklein
09e61f7233
GN: Fix up Ganesh native interface hooks.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2269213002
Review-Url: https://codereview.chromium.org/2269213002
2016-08-23 13:35:28 -07:00
csmartdalton
5ecbbbef58
Skip non-AA intersect rects in GrReducedClip
...
Skips non-AA rects whose op is intersect or replace, and who do not
precede elements that grow the clip, by tightening fIBounds.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271493002
Review-Url: https://codereview.chromium.org/2271493002
2016-08-23 13:26:40 -07:00
bungeman
1f0e78ddf9
SkScalerContextRec::computeMatrices to return status.
...
When computing the matricies for a scaler context, there is a special
case when the matrix is determined to be singular. No port properly
handles zero sized text, so we detect this case and return a 'normal'
text size and a zero matrix for all computed transformations. This
CL causes computeMatricies to return 'false' in this case.
This is used in the constructor of SkScalerContext_Mac in order to
avoid calling CGAffineTransformInvert on non-invertible transformations.
CGAffineTransformInvert documents that if the transform is
non-invertible it will return the passed transform unchanged. It does
so, but then also prints a message to stdout. Since the information is
already available to avoid this chatty behavior, use it to keep things
quiet.
BUG=skia:3231,chromium:630169
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2276583003
Review-Url: https://codereview.chromium.org/2276583003
2016-08-23 13:19:01 -07:00
mtklein
da19f6f3b5
Assume all TURBO_HAS_* are true.
...
Should be everyone's on libjpeg-turbo >= 1.5.0.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2274643002
Review-Url: https://codereview.chromium.org/2274643002
2016-08-23 11:49:29 -07:00
vjiaoblack
e1e5c74086
Moving SkBlurImageFilter into core
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003
Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48
Committed: https://skia.googlesource.com/skia/+/e426babe7552b1cb4e27cdf4e90826feabb9e3b0
Committed: https://skia.googlesource.com/skia/+/4d760175686df8f61a11b66946eb307d89dd2c75
Committed: https://skia.googlesource.com/skia/+/a97a1ab5719d5c355f7900b7f17dec1e467cf57e
Review-Url: https://codereview.chromium.org/2255803003
2016-08-23 11:13:14 -07:00
mtklein
d805f20c8d
CMake: require libjpeg-turbo, not libjpeg
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273753002
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Review-Url: https://codereview.chromium.org/2273753002
2016-08-23 11:01:33 -07:00
halcanary
5eb8bffe42
experimental/tools/mskp_parser.py
...
TBR=
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2268403003
Review-Url: https://codereview.chromium.org/2268403003
2016-08-23 10:32:54 -07:00
bungeman
2a57f2fb2f
Revert of Moving SkBlurImageFilter into core (patchset #9 id:160001 of https://codereview.chromium.org/2255803003/ )
...
Reason for revert:
Breaking internal roll. Still needs 'Create'.
Original issue's description:
> Moving SkBlurImageFilter into core
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003
>
> Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48
> Committed: https://skia.googlesource.com/skia/+/e426babe7552b1cb4e27cdf4e90826feabb9e3b0
> Committed: https://skia.googlesource.com/skia/+/4d760175686df8f61a11b66946eb307d89dd2c75
> Committed: https://skia.googlesource.com/skia/+/a97a1ab5719d5c355f7900b7f17dec1e467cf57e
TBR=reed@google.com ,fmalita@chromium.org,vjiaoblack@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2274603003
2016-08-23 10:04:54 -07:00
caryclark
3cebe24682
fix conic path fuzz
...
The test conic has a very large weight, so it reduces to a pair
of lines. Detect this case rather than subdividing the conic
so much that the answers are meaningless.
R=herb@google.com , reed@google.com
BUG=638223
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2268073004
Review-Url: https://codereview.chromium.org/2268073004
2016-08-23 09:41:00 -07:00
halcanary
c966ef9f07
SkMultiSKP: version 2
...
Measurable size improvement.
BUG=skia:5370
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255333003
Review-Url: https://codereview.chromium.org/2255333003
2016-08-23 09:15:04 -07:00
halcanary
afdc177e77
SkPDF: PDFDevice cleanup.
...
Remove unused fContentSize.
Combine SkPDFDevice::writeContent and SkPDFDevice::content.
Remove unused SkPDFDevice::initialTransform().
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264113003
Review-Url: https://codereview.chromium.org/2264113003
2016-08-23 09:02:12 -07:00
mtklein
a2d2f38600
f16<->f32 ftz is an optional thing for speed.
...
The ARMv8 asm path actually does it right... that should be okay.
My Nexus 5x fails `dm -m _finite_ftz` before this and passes after it.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2276533002
TBR=msarett@google.com
Review-Url: https://codereview.chromium.org/2276533002
2016-08-23 08:58:12 -07:00
vjiaoblack
a97a1ab571
Moving SkBlurImageFilter into core
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003
Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48
Committed: https://skia.googlesource.com/skia/+/e426babe7552b1cb4e27cdf4e90826feabb9e3b0
Committed: https://skia.googlesource.com/skia/+/4d760175686df8f61a11b66946eb307d89dd2c75
Review-Url: https://codereview.chromium.org/2255803003
2016-08-23 07:50:52 -07:00
caryclark
bb51f4a3a7
fix pathops fuzz
...
Extreme cubics may split so that one half is a point.
Discard this rather than generating a degenerate line.
TBR=reed@google.com
BUG=640025
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2276503002
Review-Url: https://codereview.chromium.org/2276503002
2016-08-23 07:38:49 -07:00
mtklein
eb3c425f1b
GN: make libwebp an optional dependency
...
This will be handy for folks who don't have libwebp, like Fuchsia.
I convinced myself that this is done right by:
- building in all three modes (default and explicitly set both ways);
- looking at verbose Ninja logs to see the presence/lack of SK_HAS_WEBP_LIBRARY;
- running dm -m Codec, which passes with libwebp and segfault without it.
If this is viable, I intend to make all third-party dependencies optional
and follow this pattern. :skia should link and degrade gracefully without
any of //third_party. It's okay for tools to have hard third-party
dependencies; we just need them to get past the `gn gen` stage without them.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2270693004
Review-Url: https://codereview.chromium.org/2270693004
2016-08-23 07:38:09 -07:00
csmartdalton
7535f419e2
Reduce window rectangles cap to 8
...
Lowers the cap to 8 and adds a warning message if this value is ever
exceeded. The largest (only) implementation currently supports 8, so
there isn't yet reason to go higher.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2254013002
Committed: https://skia.googlesource.com/skia/+/52d721580ee22525c285e2d13cf3975a7a1b2843
Review-Url: https://codereview.chromium.org/2254013002
2016-08-23 06:51:00 -07:00
robertphillips
5eca3e187e
Cleanup use of legacy SkSurface creation methods a bit
...
This CL cleans up some remaining uses of the old API
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223023002
Committed: https://skia.googlesource.com/skia/+/f21cd16228c20927fa4e9b937d6951471cfaa37a
Review-Url: https://codereview.chromium.org/2223023002
2016-08-23 06:39:35 -07:00
robertphillips
08197b2265
Fix valgrind issue in CircleBatch__Test
...
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271653002
Review-Url: https://codereview.chromium.org/2271653002
2016-08-23 06:19:15 -07:00
martina.kollarova
d01c7d09e9
Remove file samplecode/SampleDraw.cpp
...
The file is not used in any build target and seems dead, i.e. failed to compile when I added it to
the SampleApp target.
BUG=None
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2269583002
Review-Url: https://codereview.chromium.org/2269583002
2016-08-23 00:17:42 -07:00
robertphillips
6cfb106002
Fix Ganesh analytic blurred rect draws
...
This CL does two things:
It fixes the SkBlurMaskFilterImpl::directFilterRRectMaskGPU draw path to explicitly handle rects
It fixes the SkGpuDevice::drawTextureProducerImpl draw path to provide the correct (src & device space) inputs to directFilterRRectMaskGPU.
How this was working before was that GrRRectBlurEffect::Make would reject rect-rrects and the code would fallback to
GrBlurUtils::drawPathWithMaskFilter which mapped the rect-rrect into device space correctly (of course,
the rect-ness of the path was removed at that point so it was going through the slow path).
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2268583002
Review-Url: https://codereview.chromium.org/2268583002
2016-08-22 16:13:48 -07:00
bsalomon
0515593064
Fix GLSL int to float error in arc code in GrOvalRenderer.
...
BUG=skia:
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263213004
Review-Url: https://codereview.chromium.org/2263213004
2016-08-22 15:17:48 -07:00
msarett
4ff08df15a
More robust check for sRGB gamma tables
...
This is in response to a UMA showing that 5% dst gammas are
unidentified tables. We want to see if some of these tables
should be marked as sRGB.
https://uma.googleplex.com/p/chrome/histograms?endDate=latest&dayCount=1&histograms=Blink.ColorSpace.Destination&fixupData=true&showMax=true&filters=isofficial%2Ceq%2CTrue&implicitFilters=isofficial
This check is not fast. If we find that it doesn't help
us recognize sRGB curves, we should delete it.
BUG=skia:5656
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263233003
Review-Url: https://codereview.chromium.org/2263233003
2016-08-22 14:58:56 -07:00
bsalomon
dcb406c29d
Remove virtual from overrides in SkGpuDevice.h
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2265323002
Review-Url: https://codereview.chromium.org/2265323002
2016-08-22 14:48:36 -07:00
bsalomon
cadf75a8a4
Fix CircleBatch::TestCreate to always use a legal matrix
...
TBR=robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2267953002
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2267953002
2016-08-22 14:24:24 -07:00
bsalomon
bdc335f9b9
Mark temporary paths created by SkCanvas for clipping as volatile
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2268723002
Review-Url: https://codereview.chromium.org/2268723002
2016-08-22 13:42:17 -07:00
liyuqian
236e272380
Remove vulkan from most build variants
...
Since many devices don't support vulkan, we have to remove it for most
build variants and only turn it on manually by selecting arm64vulkan
build variant.
BUG=skia:5516
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255973003
Review-Url: https://codereview.chromium.org/2255973003
2016-08-22 13:36:57 -07:00
mtklein
8ae991e433
Flush denorm half floats to zero.
...
I think we convinced ourselves that denorms, while a good chunk of half floats,
cover a rather small fraction of the representable range, which is always
close enough to zero to flush.
This makes both paths of the conversion to or from float considerably simpler.
These functions now work for zero-or-normal half floats (excluding infinite, NaN).
I'm not aware of a term for this class so I've called them "ordinary".
A handful of GMs and SKPs draw differently in --config f16, but all imperceptibly.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2256023002
Review-Url: https://codereview.chromium.org/2256023002
2016-08-22 13:20:18 -07:00
bsalomon
4f3a0ca85d
GPU implementation of drawArc.
...
This adds analytic shaders for filled arcs and butt-cap stroked arcs where the center point is not used.
BUG=skia:5227
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259323003
Review-Url: https://codereview.chromium.org/2259323003
2016-08-22 13:14:26 -07:00
bsalomon
4c261d0c1e
Add cap type variations to circular arcs GMs
...
BUG=skia:5227
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2269723002
Review-Url: https://codereview.chromium.org/2269723002
2016-08-22 13:10:46 -07:00
reed
4d2cce442d
check for wide-open inside quickContains
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263373002
Review-Url: https://codereview.chromium.org/2263373002
2016-08-22 13:03:47 -07:00
msarett
d331742d27
Fix MSAN - mark temporary memory as kNo_ZeroInitialized
...
TBR=mtklein@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261173004
Review-Url: https://codereview.chromium.org/2261173004
2016-08-22 13:00:05 -07:00
rmistry
674b925227
Add trooper documentation for CT bots and for iOS "the service is invalid"
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263103003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2263103003
Review-Url: https://codereview.chromium.org/2263103003
2016-08-22 12:54:54 -07:00
msarett
d9015a43cf
Fix Equals and serialization for rare pngs
...
PNGs may contain a gAMA chunk that specifies gamma
values as floats. If so, we will use these floats
to create an SkColorSpace.
This CL fixes Equals(), serialize(), and
Deserialize() to correctly handle SkColorSpaces
with strange gammas, where we are unable to fall
back on the profile data.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221983002
Review-Url: https://codereview.chromium.org/2221983002
2016-08-22 12:29:32 -07:00
vjiaoblack
a90dcf791b
Revert of Moving SkBlurImageFilter into core (patchset #8 id:140001 of https://codereview.chromium.org/2255803003/ )
...
Reason for revert:
Misnamed function.
Original issue's description:
> Moving SkBlurImageFilter into core
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003
>
> Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48
> Committed: https://skia.googlesource.com/skia/+/e426babe7552b1cb4e27cdf4e90826feabb9e3b0
> Committed: https://skia.googlesource.com/skia/+/4d760175686df8f61a11b66946eb307d89dd2c75
TBR=reed@google.com ,fmalita@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2265263002
2016-08-22 12:04:41 -07:00
vjiaoblack
4d76017568
Moving SkBlurImageFilter into core
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003
Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48
Committed: https://skia.googlesource.com/skia/+/e426babe7552b1cb4e27cdf4e90826feabb9e3b0
Review-Url: https://codereview.chromium.org/2255803003
2016-08-22 12:00:25 -07:00
robertphillips
3a0c3696f0
Remove quantization of device-space dest rect for Ganesh analytic rrect blurs
...
At least on Windows, this fixes a lot of the horrible banded blurs. AFAICT there is no good reason to quantize the device space rect passed to the GrRectBlurEffect.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2262263002
Review-Url: https://codereview.chromium.org/2262263002
2016-08-22 11:48:44 -07:00
bsalomon
6bf233176f
Mark temp paths in SkBaseDevice::drawArc and ::drawDRRect as volatile
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261123004
Review-Url: https://codereview.chromium.org/2261123004
2016-08-22 11:46:35 -07:00
liyuqian
23d24587ee
Fix touch event parameter order
...
The issue is so obvious... However, all newer Android devices (e.g.,
Nexus 6P, 5X, 9) are immune to this bug. So I didn't notice this until I
tested Viewer app on Nexus 7 yesterday...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2254223002
Review-Url: https://codereview.chromium.org/2254223002
2016-08-22 11:31:09 -07:00
vjiaoblack
7b145120f2
Revert of Moving SkBlurImageFilter into core (patchset #8 id:140001 of https://codereview.chromium.org/2255803003/ )
...
Reason for revert:
Fixed it wrong, needs to revert to re-discuss and re-land.
Original issue's description:
> Moving SkBlurImageFilter into core
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003
>
> Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48
> Committed: https://skia.googlesource.com/skia/+/e426babe7552b1cb4e27cdf4e90826feabb9e3b0
TBR=reed@google.com ,fmalita@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2266063002
2016-08-22 11:30:40 -07:00
vjiaoblack
e426babe75
Moving SkBlurImageFilter into core
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003
Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48
Review-Url: https://codereview.chromium.org/2255803003
2016-08-22 10:51:27 -07:00
bsalomon
ac1d0abfd8
Add stroke-and-fill circular arc test, test near 180deg arc in all circular_arc_tests
...
BUG=skia:5227
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261233002
Review-Url: https://codereview.chromium.org/2261233002
2016-08-22 10:00:14 -07:00
msarett
0f0c4f0902
Detect all named gammas
...
Our DstColorSpace UMA is showing some named gammas that are
not appropriately detected and placed in named categories.
https://uma.googleplex.com/p/chrome/histograms?endDate=latest&dayCount=1&histograms=Blink.ColorSpace.Destination&fixupData=true&showMax=true&filters=isofficial%2Ceq%2CTrue&implicitFilters=isofficial
This CL should fix that.
I'm not sure (yet) how I feel about this landing permanently.
Seems a little messy.
But it will be interesting to see how this affects the UMA.
My best guess is that we are hitting this case when all
three gammas are "invalid" in different ways. I'm expecting
to see some profiles end up in the "invalid" category now.
It's also possible that we'll see these cases being absorbed
into sRGB or somewhere else.
BUG=skia:5656
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261213002
Review-Url: https://codereview.chromium.org/2261213002
2016-08-22 09:44:35 -07:00
mtklein
a61b6d4f9e
compress_r11eac_blocks() required more alignment than dst has.
...
This shouldn't change any behavior except that the stores to dst
will no longer require 8-byte alignment.
Empirically it seems like we can use 4-byte alignment here,
but u8 (i.e. 1-byte alignment) is always safe.
BUG=skia:5637
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264103002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/2264103002
2016-08-22 09:30:54 -07:00