reed
8e47478333
implement some so we can test it
...
NOTRY=True
TBR=
Review URL: https://codereview.chromium.org/629903004
2014-10-06 11:00:51 -07:00
humper
8d56e27ef5
a few more tweaks to the webtry setup doc
...
BUG=skia:
TBR=tfarina
Review URL: https://codereview.chromium.org/626623002
2014-10-06 09:56:14 -07:00
Greg Humphreys
bc3dbbd8fd
add environment variable to webtry local run documentation
...
BUG=skia:
Review URL: https://codereview.chromium.org/631693003
2014-10-06 12:33:32 -04:00
Greg Humphreys
de9bec4f04
Automatically resize the webtry text editor to fit the content
...
BUG=skia:
Review URL: https://codereview.chromium.org/626033004
2014-10-06 12:31:42 -04:00
Greg Humphreys
d3b7ef6c2b
fix webtry local run documentation
...
BUG=skia:
Review URL: https://codereview.chromium.org/630093002
2014-10-06 12:04:40 -04:00
reed
938dfba51d
experimental c api
...
BUG=skia:
Review URL: https://codereview.chromium.org/624973004
2014-10-06 06:08:16 -07:00
tfarina
f16cd28a04
Restart webtry to pick up changes.
...
Also add webtry.db to gitignore so it does not polute `git status`.
BUG=None
TEST=None
R=humper@google.com
Review URL: https://codereview.chromium.org/626703002
2014-10-03 21:05:00 -07:00
humper
f0e2154b45
Update webtry setup docs to reflect new installation procedure
...
BUG=skia:
Review URL: https://codereview.chromium.org/626443004
2014-10-02 10:37:14 -07:00
humper
149366e884
fix sudo redirection in setup script
...
BUG=skia:
Review URL: https://codereview.chromium.org/618013004
2014-10-02 10:36:59 -07:00
humper
b77955e1b1
complete overhaul of webtry work partition between jail and host
...
BUG=skia:
Review URL: https://codereview.chromium.org/619943002
2014-10-01 14:27:31 -07:00
tfarina
b1dfb03685
webtry: More README doc cleanups.
...
Puts it much more in sync with the README in perf/.
BUG=None
TEST=None
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/615313002
2014-10-01 09:18:58 -07:00
tfarina
fffa16cc27
webtry: Only create sqlite3 tables if they don't exist yet.
...
Otherwise it will through an error like the following:
2014/09/28 21:22:24 Info: status creating sqlite table for sources:
"table source_images already exists"
2014/09/28 21:22:24 Info: status creating sqlite table for webtry:
"table webtry already exists"
2014/09/28 21:22:24 Info: status creating sqlite table for workspace:
"table workspace already exists"
2014/09/28 21:22:24 Info: status creating sqlite table for workspace
try: "table workspacetry already exists"
To test locally the following was done:
$ ./gyp_skia gyp/webtry.gyp gyp/most.gyp -Dskia_gpu=0
$ ninja -C out/Debug webtry
$ cd experimental/webtry
$ go get -d
$ go build webtry.go
$ ./webtry
$ google-chrome http://localhost:8000
Expected: see no more the above messages.
BUG=None
TEST=see above
R=stephana@google.com , jcgregorio@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/613593002
2014-09-30 08:17:11 -07:00
tfarina
320a4e658b
Fix some references to non-existant polyfill directory.
...
Looks like the name of the directory is "poly" rather than "polyfill".
BUG=None
TEST=None
R=humper@google.com , jcgregorio@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/610003003
2014-09-29 10:50:59 -07:00
tfarina
c425ae3a12
Mention 'go get' command in the README file.
...
This is necessary to build webtry.go as it imports packages from
github.com
BUG=None
TEST=follow the README instructions
R=humper@google.com , jcgregorio@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/601033004
2014-09-29 10:50:29 -07:00
tfarina
4ceb039301
webtry database has more than one table.
...
Fix the wording in the DESIGN doc. Currently it says "the only table" as
implying the database has just a single table.
That is not true, the webtry database has four tables: webtry,
workspace, workspacetry and source_images.
BUG=None
TEST=None
R=jcgregorio@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/611763002
2014-09-29 08:16:12 -07:00
humper
9f58dd047c
run the webtry build script instead of using go build
...
BUG=skia:
R=jcgregorio@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/601203002
2014-09-29 07:40:41 -07:00
fmalita
05c4a4322e
Revert of Revert of Fix SkTextBlob offset semantics. (patchset #1 id:1 of https://codereview.chromium.org/609223003/ )
...
Reason for revert:
Re-landing: Chromium-side fix to be landed with the roll (https://codereview.chromium.org/607853003/ )
Original issue's description:
> Revert of Fix SkTextBlob offset semantics. (patchset #2 id:20001 of https://codereview.chromium.org/605533002/ )
>
> Reason for revert:
> Breaking the Chrome builds with the error:
>
> [14:54:14.317833] ../../skia/ext/pixel_ref_utils.cc:221:16: error: 'drawPosText' marked 'override' but does not override any member functions
> [14:54:14.318022] virtual void drawPosText(const SkDraw& draw,
> [14:54:14.318082] ^
>
> Original issue's description:
> > Fix SkTextBlob offset semantics.
> >
> > Implement proper x/y drawTextBlob() handling by plumbing a
> > drawPosText() offset parameter (to act as an additional glyph pos
> > translation) throughout the device layer.
> >
> > The new offset superceeds the existing constY, with a minor semantic
> > tweak: whereas previous implementations were ignoring constY in 2D
> > positioning mode (scalarsPerGlyph == 2), now the offset is always
> > observed, in all positioning modes. We can do this because existing
> > drawPosText() clients always pass constY == 0 for full positioning mode.
> >
> > R=reed@google.com , jvanverth@google.com , robertphillips@google.com
> >
> > Committed: https://skia.googlesource.com/skia/+/c13bc571d3e61a43b87eb97f0719abd304cafaf2
>
> TBR=jvanverth@google.com ,reed@google.com,bsalomon@google.com,fmalita@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/d46b8d2bab7cfba8458432248e1568ac377429e9
R=jvanverth@google.com , reed@google.com , bsalomon@google.com , robertphillips@google.com
TBR=bsalomon@google.com , jvanverth@google.com , reed@google.com , robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/607413003
2014-09-29 06:29:53 -07:00
robertphillips
d46b8d2bab
Revert of Fix SkTextBlob offset semantics. (patchset #2 id:20001 of https://codereview.chromium.org/605533002/ )
...
Reason for revert:
Breaking the Chrome builds with the error:
[14:54:14.317833] ../../skia/ext/pixel_ref_utils.cc:221:16: error: 'drawPosText' marked 'override' but does not override any member functions
[14:54:14.318022] virtual void drawPosText(const SkDraw& draw,
[14:54:14.318082] ^
Original issue's description:
> Fix SkTextBlob offset semantics.
>
> Implement proper x/y drawTextBlob() handling by plumbing a
> drawPosText() offset parameter (to act as an additional glyph pos
> translation) throughout the device layer.
>
> The new offset superceeds the existing constY, with a minor semantic
> tweak: whereas previous implementations were ignoring constY in 2D
> positioning mode (scalarsPerGlyph == 2), now the offset is always
> observed, in all positioning modes. We can do this because existing
> drawPosText() clients always pass constY == 0 for full positioning mode.
>
> R=reed@google.com , jvanverth@google.com , robertphillips@google.com
>
> Committed: https://skia.googlesource.com/skia/+/c13bc571d3e61a43b87eb97f0719abd304cafaf2
R=jvanverth@google.com , reed@google.com , bsalomon@google.com , fmalita@chromium.org
TBR=bsalomon@google.com , fmalita@chromium.org , jvanverth@google.com , reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/609223003
2014-09-29 04:48:52 -07:00
Florin Malita
c13bc571d3
Fix SkTextBlob offset semantics.
...
Implement proper x/y drawTextBlob() handling by plumbing a
drawPosText() offset parameter (to act as an additional glyph pos
translation) throughout the device layer.
The new offset superceeds the existing constY, with a minor semantic
tweak: whereas previous implementations were ignoring constY in 2D
positioning mode (scalarsPerGlyph == 2), now the offset is always
observed, in all positioning modes. We can do this because existing
drawPosText() clients always pass constY == 0 for full positioning mode.
R=reed@google.com , jvanverth@google.com , robertphillips@google.com
Review URL: https://codereview.chromium.org/605533002
2014-09-26 10:33:37 -04:00
tfarina
fbe8d890ce
Reinitialize monit to changes take effect.
...
Otherwise changes made to the configuration won't take effect when they
are synced.
BUG=None
TEST=None
R=jcgregorio@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/602293002
2014-09-26 06:10:00 -07:00
jcgregorio
c0a77553f7
Fix typo in experimental/webtry/DESIGN.md.
...
R=tfarina@chromium.org
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/593723003
2014-09-22 10:33:00 -07:00
humper
95b7144adf
fixes to linux build for webtry
...
BUG=skia:
R=jcgregorio@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/578013003
2014-09-18 10:58:33 -07:00
reed
e010f1c2a0
hide deviceproperties, prepare the way for surfaceprops
...
BUG=skia:
NOTRY=True
R=bungeman@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/577023002
2014-09-17 10:49:38 -07:00
humper
9a0267fa9a
gyp build of skfiddle apps, take 2
...
BUG=skia:
R=jcgregorio@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/553333004
2014-09-17 08:42:46 -07:00
bsalomon
3850971d54
Revert "Revert "Move SkGpuDevice.h to src/gpu""
...
This reverts commit b0a35f7c5d
.
R=borenet@google.com
TBR=borenet@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/575783003
2014-09-17 07:44:25 -07:00
borenet
b0a35f7c5d
Revert "Move SkGpuDevice.h to src/gpu"
...
This reverts commit d99bbb61e5
.
Causing Chrome canary failures as well as failures of Chrome trybots due to
not cleaning up properly after failed DEPS roll attempts.
BUG=skia:
R=bsalomon@google.com , reed@google.com
TBR=bsalomon, reed
Author: borenet@google.com
Review URL: https://codereview.chromium.org/579733003
2014-09-17 06:14:35 -07:00
bsalomon
d99bbb61e5
Move SkGpuDevice.h to src/gpu
...
R=reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/545193006
2014-09-16 14:09:13 -07:00
humper
d3b6eb246d
disable webtry seccmp on non-linux build
...
BUG=skia:
R=jcgregorio@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/555993002
2014-09-09 15:57:33 -07:00
humper
d85ad50b0e
simple build script for webtry that re-generates the code template
...
before compilation
BUG=skia:
R=jcgregorio@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/552343003
2014-09-09 15:57:26 -07:00
robertphillips
c5ba71d2e5
Change SkPicture::draw to playback
...
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/540963002
2014-09-04 08:42:50 -07:00
reed
e5ea500d47
Hide fields in SkImageInfo
...
R=rmistry@google.com
TBR=bsalomon
Author: reed@google.com
Review URL: https://codereview.chromium.org/536003002
2014-09-03 11:54:58 -07:00
robertphillips
a8d7f0b13c
Try out scalar picture sizes
...
This paves the way for removing the 'fTile' parameter from SkPictureShader (although that should be a different CL). If we like this we could also move to providing an entire cull SkRect.
R=reed@google.com , mtklein@google.com , fmalita@google.com , fmalita@chromium.org
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/513983002
2014-08-29 08:03:56 -07:00
reed
8bf3df68c5
remove code for (dead) SK_SUPPORT_LEGACY_GETCLIPTYPE
...
BUG=skia:
R=djsollen@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/489103003
2014-08-21 05:51:22 -07:00
epoger
d9f18a35d5
add headers to experimental SKP expectations
...
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
(SkipBuildbotRuns)
Author: epoger@google.com
Review URL: https://codereview.chromium.org/491023003
2014-08-20 11:51:39 -07:00
epoger
5fc8edc81d
update experimental SKP expectations using the new tool
...
BUG=skia:1918
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
Author: epoger@google.com
Review URL: https://codereview.chromium.org/488203002
2014-08-20 11:10:30 -07:00
epoger
a38acc74bb
add 2 missing SKP expectations files within experimental dir
...
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
(SkipBuildbotRuns)
Author: epoger@google.com
Review URL: https://codereview.chromium.org/470193006
2014-08-20 08:22:26 -07:00
epoger
802aa8c15b
start maintaining some experimental SKP expectations
...
BUG=skia:1942
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
Author: epoger@google.com
Review URL: https://codereview.chromium.org/491003002
2014-08-20 07:52:29 -07:00
mtklein
753b870c62
Define NDEBUG instead of SK_DEBUG/SK_RELEASE.
...
This makes our builds more like Chrome's, and will make our builds fail
if we accidentally use if SK_DEBUG instead of ifdef SK_DEBUG.
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/481513004
2014-08-20 07:38:46 -07:00
halcanary
97d2c0a216
Move SkReadBuffer.h and SkReader32.h out of include.
...
Committed: https://skia.googlesource.com/skia/+/2a51d7c74cec217195f861677de8998b382b39e4
R=mtklein@google.com , reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/481053002
2014-08-19 06:27:53 -07:00
halcanary
f128f53a5b
Revert "Move SkReadBuffer.h and SkReader32.h out of include."
...
This reverts commit 2a51d7c74c
.
Breaking Blink
NOTRY=true
R=bungeman@google.com
TBR=bungeman@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/472303006
2014-08-18 13:48:13 -07:00
halcanary
2a51d7c74c
Move SkReadBuffer.h and SkReader32.h out of include.
...
R=mtklein@google.com , reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/481053002
2014-08-18 13:04:59 -07:00
reed
5b1b2dbe76
remove SkStippleMaskFilter - no external clients
...
TBR=
Author: reed@google.com
Review URL: https://codereview.chromium.org/462013002
2014-08-12 05:50:10 -07:00
reed
d5fa1a455a
add drawPicture variant that takes a matrix and paint
...
will need some staging strategy, since chrome and blink have overrides of onDrawPicture
R=robertphillips@google.com , fmalita@google.com , bsalomon@google.com , mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/448793004
2014-08-09 11:08:05 -07:00
tfarina
a8e2e1504b
Cleanup: Rename SkOSPath functions.
...
Mostly for brevity and matches better with Python:
Python | Old C++ | New C++
os.path.join | SkOSPath::SkPathJoin | SkOSPath::Join
os.path.basename | SkOSPath::SkBasename | SkOSPath::Basename
BUG=None
TEST=make all
R=mtklein@google.com , bsalomon@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/428443002
2014-07-28 19:26:58 -07:00
caryclark
17f0b6df72
share dm and command flags
...
Share command flags between dm and unit tests.
Also, allow dm's core to be included by itself and iOSShell.
Command line flags that are the same (or nearly the same) in DM
and in skia_tests have been moved to common_flags. Authors,
please check to see that the shared common flag is correct for
the tool.
For iOS, the 'tool_main' entry point has a wrapper to allow multiple
tools to be statically linked in the iOSShell.
Since SkCommandLineFlags::Parse can only be called once, these calls
are disabled in the IOS build.
Since the iOS app directory is dynamically assigned a name, use '@' to
select it. (This is the same convention chosen by the Mobile Harness
iOS file system utilities.)
Move the heart of dm.gyp into dm.gypi so that it can be included by
itself and iOSShell.gyp.
Add tools/flags/SkCommonFlags.* to define and declare common
command line flags.
Add support for dm to iOSShell.
BUG=skia:
R=scroggo@google.com , mtklein@google.com , jvanverth@google.com , bsalomon@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/389653004
2014-07-22 10:15:35 -07:00
kozyatinskiy
c09e8c2ec9
https://chromiumcodereview.appspot.com/331133004/
...
patch from issue 331133004
2014-07-15 11:11:25 -04:00
caryclark
93de7a27e0
fix ios break
...
R=reed@android.com
TBR=reed
NOTREECHECKS=TRUE
NOTRY=TRUE
BUG=skia:
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/388933003
2014-07-11 13:21:17 -07:00
caryclark
936b73424f
ios fixes
...
skia_ios.mm
Get the app's Documents directory and pass use it to set the resource path.
This is a quick hack which will be replaced by a new application that is
a tiny shim around a command line tool.
SkImageEncoder.h
SkForceLinking.cpp
SkImageDecoder_CG.cpp
Add support for FORCE_LINKING so iOS sees the PNG encoder and others.
SkFloatBits.cpp
SkPoint.cpp
Handle denormalized numbers that are floored by the iOS ARM processor.
SkImageDecoder_iOS.mm
Remove empty encoder factory.
SkTouchGesture.cpp
Return early on empty state on touch rather than aborting (crashing)
JpegTest.cpp
Hal via stackoverflow.com says partial jpegs can be gray as well.
skia_test.cpp
Remove crash handler call for now to avoid link failure.
OverwriteLine.h
Remove fancy line overwrite for iOS.
Resources.cpp
Add interface to set resource directory based on runtime query.
BUG=skia:2736 skia:2737 skia:2738
R=reed@google.com , halcanary@google.com , mtklein@google.com , tfarina@chromium.org
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/373383003
2014-07-11 12:14:51 -07:00
bensong
c15ba1d544
bench rebase tool: add ability to specify a second CL for fluctuating data adjustment.
...
R=borenet@google.com
TBR=borenet@google.com
BUG=skia:2657
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/370413002
2014-07-08 14:36:56 -07:00
jcgregorio
3ef0453299
Fix history handling for workspaces, issue with M36
...
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/363003004
2014-07-07 06:56:44 -07:00